1 use rustc_data_structures::fx::FxHashMap;
2 use rustc_errors::struct_span_err;
4 use rustc_hir::def_id::{DefId, LocalDefId};
5 use rustc_hir::hir_id::HirId;
6 use rustc_hir::intravisit;
7 use rustc_middle::mir::visit::{MutatingUseContext, PlaceContext, Visitor};
8 use rustc_middle::ty::query::Providers;
9 use rustc_middle::ty::{self, TyCtxt};
10 use rustc_middle::{lint, mir::*};
11 use rustc_session::lint::builtin::{UNSAFE_OP_IN_UNSAFE_FN, UNUSED_UNSAFE};
12 use rustc_session::lint::Level;
14 use std::collections::hash_map;
17 pub struct UnsafetyChecker<'a, 'tcx> {
20 violations: Vec<UnsafetyViolation>,
21 source_info: SourceInfo,
23 param_env: ty::ParamEnv<'tcx>,
25 /// Used `unsafe` blocks in this function. This is used for the "unused_unsafe" lint.
27 /// The keys are the used `unsafe` blocks, the UnusedUnsafeKind indicates whether
28 /// or not any of the usages happen at a place that doesn't allow `unsafe_op_in_unsafe_fn`.
29 used_unsafe_blocks: FxHashMap<HirId, UsedUnsafeBlockData>,
32 impl<'a, 'tcx> UnsafetyChecker<'a, 'tcx> {
37 param_env: ty::ParamEnv<'tcx>,
43 source_info: SourceInfo::outermost(body.span),
46 used_unsafe_blocks: Default::default(),
51 impl<'tcx> Visitor<'tcx> for UnsafetyChecker<'_, 'tcx> {
52 fn visit_terminator(&mut self, terminator: &Terminator<'tcx>, location: Location) {
53 self.source_info = terminator.source_info;
54 match terminator.kind {
55 TerminatorKind::Goto { .. }
56 | TerminatorKind::SwitchInt { .. }
57 | TerminatorKind::Drop { .. }
58 | TerminatorKind::Yield { .. }
59 | TerminatorKind::Assert { .. }
60 | TerminatorKind::DropAndReplace { .. }
61 | TerminatorKind::GeneratorDrop
62 | TerminatorKind::Resume
63 | TerminatorKind::Abort
64 | TerminatorKind::Return
65 | TerminatorKind::Unreachable
66 | TerminatorKind::FalseEdge { .. }
67 | TerminatorKind::FalseUnwind { .. } => {
68 // safe (at least as emitted during MIR construction)
71 TerminatorKind::Call { ref func, .. } => {
72 let func_ty = func.ty(self.body, self.tcx);
73 let sig = func_ty.fn_sig(self.tcx);
74 if let hir::Unsafety::Unsafe = sig.unsafety() {
76 UnsafetyViolationKind::General,
77 UnsafetyViolationDetails::CallToUnsafeFunction,
81 if let ty::FnDef(func_id, _) = func_ty.kind() {
82 self.check_target_features(*func_id);
86 TerminatorKind::InlineAsm { .. } => self.require_unsafe(
87 UnsafetyViolationKind::General,
88 UnsafetyViolationDetails::UseOfInlineAssembly,
91 self.super_terminator(terminator, location);
94 fn visit_statement(&mut self, statement: &Statement<'tcx>, location: Location) {
95 self.source_info = statement.source_info;
96 match statement.kind {
97 StatementKind::Assign(..)
98 | StatementKind::FakeRead(..)
99 | StatementKind::SetDiscriminant { .. }
100 | StatementKind::Deinit(..)
101 | StatementKind::StorageLive(..)
102 | StatementKind::StorageDead(..)
103 | StatementKind::Retag { .. }
104 | StatementKind::AscribeUserType(..)
105 | StatementKind::Coverage(..)
106 | StatementKind::Nop => {
107 // safe (at least as emitted during MIR construction)
110 StatementKind::CopyNonOverlapping(..) => unreachable!(),
112 self.super_statement(statement, location);
115 fn visit_rvalue(&mut self, rvalue: &Rvalue<'tcx>, location: Location) {
117 Rvalue::Aggregate(box ref aggregate, _) => match aggregate {
118 &AggregateKind::Array(..) | &AggregateKind::Tuple => {}
119 &AggregateKind::Adt(adt_did, ..) => {
120 match self.tcx.layout_scalar_valid_range(adt_did) {
121 (Bound::Unbounded, Bound::Unbounded) => {}
122 _ => self.require_unsafe(
123 UnsafetyViolationKind::General,
124 UnsafetyViolationDetails::InitializingTypeWith,
128 &AggregateKind::Closure(def_id, _) | &AggregateKind::Generator(def_id, _, _) => {
129 let UnsafetyCheckResult { violations, used_unsafe_blocks, .. } =
130 self.tcx.unsafety_check_result(def_id.expect_local());
131 self.register_violations(
133 used_unsafe_blocks.iter().map(|(&h, &d)| (h, d)),
139 self.super_rvalue(rvalue, location);
142 fn visit_place(&mut self, place: &Place<'tcx>, context: PlaceContext, _location: Location) {
143 // On types with `scalar_valid_range`, prevent
146 // * `&x.field` if `field`'s type has interior mutability
147 // because either of these would allow modifying the layout constrained field and
148 // insert values that violate the layout constraints.
149 if context.is_mutating_use() || context.is_borrow() {
150 self.check_mut_borrowing_layout_constrained_field(*place, context.is_mutating_use());
153 // Some checks below need the extra meta info of the local declaration.
154 let decl = &self.body.local_decls[place.local];
156 // Check the base local: it might be an unsafe-to-access static. We only check derefs of the
157 // temporary holding the static pointer to avoid duplicate errors
158 // <https://github.com/rust-lang/rust/pull/78068#issuecomment-731753506>.
159 if decl.internal && place.projection.first() == Some(&ProjectionElem::Deref) {
160 // If the projection root is an artificial local that we introduced when
161 // desugaring `static`, give a more specific error message
162 // (avoid the general "raw pointer" clause below, that would only be confusing).
163 if let Some(box LocalInfo::StaticRef { def_id, .. }) = decl.local_info {
164 if self.tcx.is_mutable_static(def_id) {
166 UnsafetyViolationKind::General,
167 UnsafetyViolationDetails::UseOfMutableStatic,
170 } else if self.tcx.is_foreign_item(def_id) {
172 UnsafetyViolationKind::General,
173 UnsafetyViolationDetails::UseOfExternStatic,
180 // Check for raw pointer `Deref`.
181 for (base, proj) in place.iter_projections() {
182 if proj == ProjectionElem::Deref {
183 let base_ty = base.ty(self.body, self.tcx).ty;
184 if base_ty.is_unsafe_ptr() {
186 UnsafetyViolationKind::General,
187 UnsafetyViolationDetails::DerefOfRawPointer,
193 // Check for union fields. For this we traverse right-to-left, as the last `Deref` changes
194 // whether we *read* the union field or potentially *write* to it (if this place is being assigned to).
195 let mut saw_deref = false;
196 for (base, proj) in place.iter_projections().rev() {
197 if proj == ProjectionElem::Deref {
202 let base_ty = base.ty(self.body, self.tcx).ty;
203 if base_ty.is_union() {
204 // If we did not hit a `Deref` yet and the overall place use is an assignment, the
205 // rules are different.
206 let assign_to_field = !saw_deref
209 PlaceContext::MutatingUse(
210 MutatingUseContext::Store
211 | MutatingUseContext::Drop
212 | MutatingUseContext::AsmOutput
215 // If this is just an assignment, determine if the assigned type needs dropping.
217 // We have to check the actual type of the assignment, as that determines if the
218 // old value is being dropped.
219 let assigned_ty = place.ty(&self.body.local_decls, self.tcx).ty;
220 // To avoid semver hazard, we only consider `Copy` and `ManuallyDrop` non-dropping.
221 let manually_drop = assigned_ty
223 .map_or(false, |adt_def| adt_def.is_manually_drop());
224 let nodrop = manually_drop
225 || assigned_ty.is_copy_modulo_regions(
226 self.tcx.at(self.source_info.span),
231 UnsafetyViolationKind::General,
232 UnsafetyViolationDetails::AssignToDroppingUnionField,
235 // write to non-drop union field, safe
239 UnsafetyViolationKind::General,
240 UnsafetyViolationDetails::AccessToUnionField,
248 impl<'tcx> UnsafetyChecker<'_, 'tcx> {
249 fn require_unsafe(&mut self, kind: UnsafetyViolationKind, details: UnsafetyViolationDetails) {
250 // Violations can turn out to be `UnsafeFn` during analysis, but they should not start out as such.
251 assert_ne!(kind, UnsafetyViolationKind::UnsafeFn);
253 let source_info = self.source_info;
254 let lint_root = self.body.source_scopes[self.source_info.scope]
257 .assert_crate_local()
259 self.register_violations(
260 [&UnsafetyViolation { source_info, lint_root, kind, details }],
265 fn register_violations<'a>(
267 violations: impl IntoIterator<Item = &'a UnsafetyViolation>,
268 new_used_unsafe_blocks: impl IntoIterator<Item = (HirId, UsedUnsafeBlockData)>,
270 use UsedUnsafeBlockData::{AllAllowedInUnsafeFn, SomeDisallowedInUnsafeFn};
272 let update_entry = |this: &mut Self, hir_id, new_usage| {
273 match this.used_unsafe_blocks.entry(hir_id) {
274 hash_map::Entry::Occupied(mut entry) => {
275 if new_usage == SomeDisallowedInUnsafeFn {
276 *entry.get_mut() = SomeDisallowedInUnsafeFn;
279 hash_map::Entry::Vacant(entry) => {
280 entry.insert(new_usage);
284 let safety = self.body.source_scopes[self.source_info.scope]
287 .assert_crate_local()
290 // `unsafe` blocks are required in safe code
291 Safety::Safe => violations.into_iter().for_each(|&violation| {
292 match violation.kind {
293 UnsafetyViolationKind::General => {}
294 UnsafetyViolationKind::UnsafeFn => {
295 bug!("`UnsafetyViolationKind::UnsafeFn` in an `Safe` context")
298 if !self.violations.contains(&violation) {
299 self.violations.push(violation)
302 // With the RFC 2585, no longer allow `unsafe` operations in `unsafe fn`s
303 Safety::FnUnsafe => violations.into_iter().for_each(|&(mut violation)| {
304 violation.kind = UnsafetyViolationKind::UnsafeFn;
305 if !self.violations.contains(&violation) {
306 self.violations.push(violation)
309 Safety::BuiltinUnsafe => {}
310 Safety::ExplicitUnsafe(hir_id) => violations.into_iter().for_each(|violation| {
314 match self.tcx.lint_level_at_node(UNSAFE_OP_IN_UNSAFE_FN, violation.lint_root).0
316 Level::Allow => AllAllowedInUnsafeFn(violation.lint_root),
317 _ => SomeDisallowedInUnsafeFn,
323 new_used_unsafe_blocks
325 .for_each(|(hir_id, usage_data)| update_entry(self, hir_id, usage_data));
327 fn check_mut_borrowing_layout_constrained_field(
332 for (place_base, elem) in place.iter_projections().rev() {
334 // Modifications behind a dereference don't affect the value of
336 ProjectionElem::Deref => return,
337 ProjectionElem::Field(..) => {
338 let ty = place_base.ty(&self.body.local_decls, self.tcx).ty;
339 if let ty::Adt(def, _) = ty.kind() {
340 if self.tcx.layout_scalar_valid_range(def.did())
341 != (Bound::Unbounded, Bound::Unbounded)
343 let details = if is_mut_use {
344 UnsafetyViolationDetails::MutationOfLayoutConstrainedField
346 // Check `is_freeze` as late as possible to avoid cycle errors
347 // with opaque types.
349 .ty(self.body, self.tcx)
351 .is_freeze(self.tcx.at(self.source_info.span), self.param_env)
353 UnsafetyViolationDetails::BorrowOfLayoutConstrainedField
357 self.require_unsafe(UnsafetyViolationKind::General, details);
366 /// Checks whether calling `func_did` needs an `unsafe` context or not, i.e. whether
367 /// the called function has target features the calling function hasn't.
368 fn check_target_features(&mut self, func_did: DefId) {
369 // Unsafety isn't required on wasm targets. For more information see
370 // the corresponding check in typeck/src/collect.rs
371 if self.tcx.sess.target.options.is_like_wasm {
375 let callee_features = &self.tcx.codegen_fn_attrs(func_did).target_features;
376 let self_features = &self.tcx.codegen_fn_attrs(self.body_did).target_features;
378 // Is `callee_features` a subset of `calling_features`?
379 if !callee_features.iter().all(|feature| self_features.contains(feature)) {
381 UnsafetyViolationKind::General,
382 UnsafetyViolationDetails::CallToFunctionWith,
388 pub(crate) fn provide(providers: &mut Providers) {
389 *providers = Providers {
390 unsafety_check_result: |tcx, def_id| {
391 if let Some(def) = ty::WithOptConstParam::try_lookup(def_id, tcx) {
392 tcx.unsafety_check_result_for_const_arg(def)
394 unsafety_check_result(tcx, ty::WithOptConstParam::unknown(def_id))
397 unsafety_check_result_for_const_arg: |tcx, (did, param_did)| {
398 unsafety_check_result(
400 ty::WithOptConstParam { did, const_param_did: Some(param_did) },
407 /// Context information for [`UnusedUnsafeVisitor`] traversal,
408 /// saves (innermost) relevant context
409 #[derive(Copy, Clone, Debug)]
412 /// in an `unsafe fn`
414 /// in a *used* `unsafe` block
415 /// (i.e. a block without unused-unsafe warning)
419 struct UnusedUnsafeVisitor<'a, 'tcx> {
421 used_unsafe_blocks: &'a FxHashMap<HirId, UsedUnsafeBlockData>,
423 unused_unsafes: &'a mut Vec<(HirId, UnusedUnsafe)>,
426 impl<'tcx> intravisit::Visitor<'tcx> for UnusedUnsafeVisitor<'_, 'tcx> {
427 fn visit_block(&mut self, block: &'tcx hir::Block<'tcx>) {
428 use UsedUnsafeBlockData::{AllAllowedInUnsafeFn, SomeDisallowedInUnsafeFn};
430 if let hir::BlockCheckMode::UnsafeBlock(hir::UnsafeSource::UserProvided) = block.rules {
431 let used = match self.tcx.lint_level_at_node(UNUSED_UNSAFE, block.hir_id) {
432 (Level::Allow, _) => Some(SomeDisallowedInUnsafeFn),
433 _ => self.used_unsafe_blocks.get(&block.hir_id).copied(),
435 let unused_unsafe = match (self.context, used) {
436 (_, None) => UnusedUnsafe::Unused,
437 (Context::Safe, Some(_))
438 | (Context::UnsafeFn(_), Some(SomeDisallowedInUnsafeFn)) => {
439 let previous_context = self.context;
440 self.context = Context::UnsafeBlock(block.hir_id);
441 intravisit::walk_block(self, block);
442 self.context = previous_context;
445 (Context::UnsafeFn(hir_id), Some(AllAllowedInUnsafeFn(lint_root))) => {
446 UnusedUnsafe::InUnsafeFn(hir_id, lint_root)
448 (Context::UnsafeBlock(hir_id), Some(_)) => UnusedUnsafe::InUnsafeBlock(hir_id),
450 self.unused_unsafes.push((block.hir_id, unused_unsafe));
452 intravisit::walk_block(self, block);
457 fk: intravisit::FnKind<'tcx>,
458 _fd: &'tcx hir::FnDecl<'tcx>,
460 _s: rustc_span::Span,
463 if matches!(fk, intravisit::FnKind::Closure) {
464 self.visit_body(self.tcx.hir().body(b))
469 fn check_unused_unsafe(
472 used_unsafe_blocks: &FxHashMap<HirId, UsedUnsafeBlockData>,
473 ) -> Vec<(HirId, UnusedUnsafe)> {
474 let hir_id = tcx.hir().local_def_id_to_hir_id(def_id);
475 let body_id = tcx.hir().maybe_body_owned_by(hir_id);
477 let Some(body_id) = body_id else {
478 debug!("check_unused_unsafe({:?}) - no body found", def_id);
481 let body = tcx.hir().body(body_id);
483 let context = match tcx.hir().fn_sig_by_hir_id(hir_id) {
484 Some(sig) if sig.header.unsafety == hir::Unsafety::Unsafe => Context::UnsafeFn(hir_id),
489 "check_unused_unsafe({:?}, context={:?}, body={:?}, used_unsafe_blocks={:?})",
490 def_id, body, context, used_unsafe_blocks
493 let mut unused_unsafes = vec![];
495 let mut visitor = UnusedUnsafeVisitor {
499 unused_unsafes: &mut unused_unsafes,
501 intravisit::Visitor::visit_body(&mut visitor, body);
506 fn unsafety_check_result<'tcx>(
508 def: ty::WithOptConstParam<LocalDefId>,
509 ) -> &'tcx UnsafetyCheckResult {
510 debug!("unsafety_violations({:?})", def);
512 // N.B., this borrow is valid because all the consumers of
513 // `mir_built` force this.
514 let body = &tcx.mir_built(def).borrow();
516 let param_env = tcx.param_env(def.did);
518 let mut checker = UnsafetyChecker::new(body, def.did, tcx, param_env);
519 checker.visit_body(&body);
521 let unused_unsafes = (!tcx.is_closure(def.did.to_def_id()))
522 .then(|| check_unused_unsafe(tcx, def.did, &checker.used_unsafe_blocks));
524 tcx.arena.alloc(UnsafetyCheckResult {
525 violations: checker.violations,
526 used_unsafe_blocks: checker.used_unsafe_blocks,
531 fn report_unused_unsafe(tcx: TyCtxt<'_>, kind: UnusedUnsafe, id: HirId) {
532 let span = tcx.sess.source_map().guess_head_span(tcx.hir().span(id));
533 tcx.struct_span_lint_hir(UNUSED_UNSAFE, id, span, |lint| {
534 let msg = "unnecessary `unsafe` block";
535 let mut db = lint.build(msg);
536 db.span_label(span, msg);
538 UnusedUnsafe::Unused => {}
539 UnusedUnsafe::InUnsafeBlock(id) => {
541 tcx.sess.source_map().guess_head_span(tcx.hir().span(id)),
542 format!("because it's nested under this `unsafe` block"),
545 UnusedUnsafe::InUnsafeFn(id, usage_lint_root) => {
547 tcx.sess.source_map().guess_head_span(tcx.hir().span(id)),
548 format!("because it's nested under this `unsafe` fn"),
551 "this `unsafe` block does contain unsafe operations, \
552 but those are already allowed in an `unsafe fn`",
554 let (level, source) =
555 tcx.lint_level_at_node(UNSAFE_OP_IN_UNSAFE_FN, usage_lint_root);
556 assert_eq!(level, Level::Allow);
557 lint::explain_lint_level_source(
558 UNSAFE_OP_IN_UNSAFE_FN,
570 pub fn check_unsafety(tcx: TyCtxt<'_>, def_id: LocalDefId) {
571 debug!("check_unsafety({:?})", def_id);
573 // closures are handled by their parent fn.
574 if tcx.is_closure(def_id.to_def_id()) {
578 let UnsafetyCheckResult { violations, unused_unsafes, .. } = tcx.unsafety_check_result(def_id);
580 for &UnsafetyViolation { source_info, lint_root, kind, details } in violations.iter() {
581 let (description, note) = details.description_and_note();
585 if unsafe_op_in_unsafe_fn_allowed(tcx, lint_root) { " function or" } else { "" };
588 UnsafetyViolationKind::General => {
594 "{} is unsafe and requires unsafe{} block",
598 .span_label(source_info.span, description)
602 UnsafetyViolationKind::UnsafeFn => tcx.struct_span_lint_hir(
603 UNSAFE_OP_IN_UNSAFE_FN,
608 "{} is unsafe and requires unsafe block (error E0133)",
611 .span_label(source_info.span, description)
619 for &(block_id, kind) in unused_unsafes.as_ref().unwrap() {
620 report_unused_unsafe(tcx, kind, block_id);
624 fn unsafe_op_in_unsafe_fn_allowed(tcx: TyCtxt<'_>, id: HirId) -> bool {
625 tcx.lint_level_at_node(UNSAFE_OP_IN_UNSAFE_FN, id).0 == Level::Allow