1 use crate::build::ExprCategory;
2 use rustc_middle::thir::visit::{self, Visitor};
4 use rustc_errors::struct_span_err;
6 use rustc_middle::mir::BorrowKind;
7 use rustc_middle::thir::*;
8 use rustc_middle::ty::{self, ParamEnv, Ty, TyCtxt};
9 use rustc_session::lint::builtin::{UNSAFE_OP_IN_UNSAFE_FN, UNUSED_UNSAFE};
10 use rustc_session::lint::Level;
11 use rustc_span::def_id::{DefId, LocalDefId};
12 use rustc_span::symbol::Symbol;
17 struct UnsafetyVisitor<'a, 'tcx> {
20 /// The `HirId` of the current scope, which would be the `HirId`
21 /// of the current HIR node, modulo adjustments. Used for lint levels.
22 hir_context: hir::HirId,
23 /// The current "safety context". This notably tracks whether we are in an
24 /// `unsafe` block, and whether it has been used.
25 safety_context: SafetyContext,
26 body_unsafety: BodyUnsafety,
27 /// The `#[target_feature]` attributes of the body. Used for checking
28 /// calls to functions with `#[target_feature]` (RFC 2396).
29 body_target_features: &'tcx Vec<Symbol>,
30 /// When inside the LHS of an assignment to a field, this is the type
31 /// of the LHS and the span of the assignment expression.
32 assignment_info: Option<(Ty<'tcx>, Span)>,
33 in_union_destructure: bool,
34 param_env: ParamEnv<'tcx>,
38 impl<'tcx> UnsafetyVisitor<'_, 'tcx> {
39 fn in_safety_context(&mut self, safety_context: SafetyContext, f: impl FnOnce(&mut Self)) {
41 SafetyContext::UnsafeBlock { span: enclosing_span, .. },
42 SafetyContext::UnsafeBlock { span: block_span, hir_id, .. },
43 ) = (self.safety_context, safety_context)
45 self.warn_unused_unsafe(
48 Some((self.tcx.sess.source_map().guess_head_span(enclosing_span), "block")),
52 let prev_context = self.safety_context;
53 self.safety_context = safety_context;
57 if let SafetyContext::UnsafeBlock { used: false, span, hir_id } = self.safety_context {
58 self.warn_unused_unsafe(
61 if self.unsafe_op_in_unsafe_fn_allowed() {
62 self.body_unsafety.unsafe_fn_sig_span().map(|span| (span, "fn"))
68 self.safety_context = prev_context;
72 fn requires_unsafe(&mut self, span: Span, kind: UnsafeOpKind) {
73 let (description, note) = kind.description_and_note();
74 let unsafe_op_in_unsafe_fn_allowed = self.unsafe_op_in_unsafe_fn_allowed();
75 match self.safety_context {
76 SafetyContext::BuiltinUnsafeBlock => {}
77 SafetyContext::UnsafeBlock { ref mut used, .. } => {
78 if !self.body_unsafety.is_unsafe() || !unsafe_op_in_unsafe_fn_allowed {
79 // Mark this block as useful
83 SafetyContext::UnsafeFn if unsafe_op_in_unsafe_fn_allowed => {}
84 SafetyContext::UnsafeFn => {
85 // unsafe_op_in_unsafe_fn is disallowed
86 self.tcx.struct_span_lint_hir(
87 UNSAFE_OP_IN_UNSAFE_FN,
92 "{} is unsafe and requires unsafe block (error E0133)",
95 .span_label(span, description)
101 SafetyContext::Safe => {
102 let fn_sugg = if unsafe_op_in_unsafe_fn_allowed { " function or" } else { "" };
107 "{} is unsafe and requires unsafe{} block",
111 .span_label(span, description)
118 fn warn_unused_unsafe(
122 enclosing_unsafe: Option<(Span, &'static str)>,
124 let block_span = self.tcx.sess.source_map().guess_head_span(block_span);
125 self.tcx.struct_span_lint_hir(UNUSED_UNSAFE, hir_id, block_span, |lint| {
126 let msg = "unnecessary `unsafe` block";
127 let mut db = lint.build(msg);
128 db.span_label(block_span, msg);
129 if let Some((span, kind)) = enclosing_unsafe {
130 db.span_label(span, format!("because it's nested under this `unsafe` {}", kind));
136 /// Whether the `unsafe_op_in_unsafe_fn` lint is `allow`ed at the current HIR node.
137 fn unsafe_op_in_unsafe_fn_allowed(&self) -> bool {
138 self.tcx.lint_level_at_node(UNSAFE_OP_IN_UNSAFE_FN, self.hir_context).0 == Level::Allow
142 // Searches for accesses to layout constrained fields.
143 struct LayoutConstrainedPlaceVisitor<'a, 'tcx> {
145 thir: &'a Thir<'tcx>,
149 impl<'a, 'tcx> LayoutConstrainedPlaceVisitor<'a, 'tcx> {
150 fn new(thir: &'a Thir<'tcx>, tcx: TyCtxt<'tcx>) -> Self {
151 Self { found: false, thir, tcx }
155 impl<'a, 'tcx> Visitor<'a, 'tcx> for LayoutConstrainedPlaceVisitor<'a, 'tcx> {
156 fn thir(&self) -> &'a Thir<'tcx> {
160 fn visit_expr(&mut self, expr: &Expr<'tcx>) {
162 ExprKind::Field { lhs, .. } => {
163 if let ty::Adt(adt_def, _) = self.thir[lhs].ty.kind() {
164 if (Bound::Unbounded, Bound::Unbounded)
165 != self.tcx.layout_scalar_valid_range(adt_def.did)
170 visit::walk_expr(self, expr);
173 // Keep walking through the expression as long as we stay in the same
174 // place, i.e. the expression is a place expression and not a dereference
175 // (since dereferencing something leads us to a different place).
176 ExprKind::Deref { .. } => {}
177 ref kind if ExprCategory::of(kind).map_or(true, |cat| cat == ExprCategory::Place) => {
178 visit::walk_expr(self, expr);
186 impl<'a, 'tcx> Visitor<'a, 'tcx> for UnsafetyVisitor<'a, 'tcx> {
187 fn thir(&self) -> &'a Thir<'tcx> {
191 fn visit_block(&mut self, block: &Block) {
192 match block.safety_mode {
193 // compiler-generated unsafe code should not count towards the usefulness of
194 // an outer unsafe block
195 BlockSafety::BuiltinUnsafe => {
196 self.in_safety_context(SafetyContext::BuiltinUnsafeBlock, |this| {
197 visit::walk_block(this, block)
200 BlockSafety::ExplicitUnsafe(hir_id) => {
201 self.in_safety_context(
202 SafetyContext::UnsafeBlock { span: block.span, hir_id, used: false },
203 |this| visit::walk_block(this, block),
206 BlockSafety::Safe => {
207 visit::walk_block(self, block);
212 fn visit_pat(&mut self, pat: &Pat<'tcx>) {
213 if self.in_union_destructure {
215 // binding to a variable allows getting stuff out of variable
216 PatKind::Binding { .. }
217 // match is conditional on having this value
218 | PatKind::Constant { .. }
219 | PatKind::Variant { .. }
220 | PatKind::Leaf { .. }
221 | PatKind::Deref { .. }
222 | PatKind::Range { .. }
223 | PatKind::Slice { .. }
224 | PatKind::Array { .. } => {
225 self.requires_unsafe(pat.span, AccessToUnionField);
226 return; // we can return here since this already requires unsafe
228 // wildcard doesn't take anything
230 // these just wrap other patterns
232 PatKind::AscribeUserType { .. } => {}
237 PatKind::Leaf { .. } => {
238 if let ty::Adt(adt_def, ..) = pat.ty.kind() {
239 if adt_def.is_union() {
240 let old_in_union_destructure =
241 std::mem::replace(&mut self.in_union_destructure, true);
242 visit::walk_pat(self, pat);
243 self.in_union_destructure = old_in_union_destructure;
244 } else if (Bound::Unbounded, Bound::Unbounded)
245 != self.tcx.layout_scalar_valid_range(adt_def.did)
247 let old_inside_adt = std::mem::replace(&mut self.inside_adt, true);
248 visit::walk_pat(self, pat);
249 self.inside_adt = old_inside_adt;
251 visit::walk_pat(self, pat);
254 visit::walk_pat(self, pat);
257 PatKind::Binding { mode: BindingMode::ByRef(borrow_kind), ty, .. } => {
259 let ty::Ref(_, ty, _) = ty.kind() else {
262 "BindingMode::ByRef in pattern, but found non-reference type {}",
267 BorrowKind::Shallow | BorrowKind::Shared | BorrowKind::Unique => {
268 if !ty.is_freeze(self.tcx.at(pat.span), self.param_env) {
269 self.requires_unsafe(pat.span, BorrowOfLayoutConstrainedField);
272 BorrowKind::Mut { .. } => {
273 self.requires_unsafe(pat.span, MutationOfLayoutConstrainedField);
277 visit::walk_pat(self, pat);
279 PatKind::Deref { .. } => {
280 let old_inside_adt = std::mem::replace(&mut self.inside_adt, false);
281 visit::walk_pat(self, pat);
282 self.inside_adt = old_inside_adt;
285 visit::walk_pat(self, pat);
290 fn visit_expr(&mut self, expr: &Expr<'tcx>) {
291 // could we be in the LHS of an assignment to a field?
293 ExprKind::Field { .. }
294 | ExprKind::VarRef { .. }
295 | ExprKind::UpvarRef { .. }
296 | ExprKind::Scope { .. }
297 | ExprKind::Cast { .. } => {}
299 ExprKind::AddressOf { .. }
300 | ExprKind::Adt { .. }
301 | ExprKind::Array { .. }
302 | ExprKind::Binary { .. }
303 | ExprKind::Block { .. }
304 | ExprKind::Borrow { .. }
305 | ExprKind::Literal { .. }
306 | ExprKind::ConstBlock { .. }
307 | ExprKind::Deref { .. }
308 | ExprKind::Index { .. }
309 | ExprKind::NeverToAny { .. }
310 | ExprKind::PlaceTypeAscription { .. }
311 | ExprKind::ValueTypeAscription { .. }
312 | ExprKind::Pointer { .. }
313 | ExprKind::Repeat { .. }
314 | ExprKind::StaticRef { .. }
315 | ExprKind::ThreadLocalRef { .. }
316 | ExprKind::Tuple { .. }
317 | ExprKind::Unary { .. }
318 | ExprKind::Call { .. }
319 | ExprKind::Assign { .. }
320 | ExprKind::AssignOp { .. }
321 | ExprKind::Break { .. }
322 | ExprKind::Closure { .. }
323 | ExprKind::Continue { .. }
324 | ExprKind::Return { .. }
325 | ExprKind::Yield { .. }
326 | ExprKind::Loop { .. }
327 | ExprKind::Let { .. }
328 | ExprKind::Match { .. }
329 | ExprKind::Box { .. }
330 | ExprKind::If { .. }
331 | ExprKind::InlineAsm { .. }
332 | ExprKind::LlvmInlineAsm { .. }
333 | ExprKind::LogicalOp { .. }
334 | ExprKind::Use { .. } => {
335 // We don't need to save the old value and restore it
336 // because all the place expressions can't have more
338 self.assignment_info = None;
342 ExprKind::Scope { value, lint_level: LintLevel::Explicit(hir_id), region_scope: _ } => {
343 let prev_id = self.hir_context;
344 self.hir_context = hir_id;
345 self.visit_expr(&self.thir[value]);
346 self.hir_context = prev_id;
347 return; // don't visit the whole expression
349 ExprKind::Call { fun, ty: _, args: _, from_hir_call: _, fn_span: _ } => {
350 if self.thir[fun].ty.fn_sig(self.tcx).unsafety() == hir::Unsafety::Unsafe {
351 self.requires_unsafe(expr.span, CallToUnsafeFunction);
352 } else if let &ty::FnDef(func_did, _) = self.thir[fun].ty.kind() {
353 // If the called function has target features the calling function hasn't,
354 // the call requires `unsafe`. Don't check this on wasm
355 // targets, though. For more information on wasm see the
356 // is_like_wasm check in typeck/src/collect.rs
357 if !self.tcx.sess.target.options.is_like_wasm
360 .codegen_fn_attrs(func_did)
363 .all(|feature| self.body_target_features.contains(feature))
365 self.requires_unsafe(expr.span, CallToFunctionWith);
369 ExprKind::Deref { arg } => {
370 if let ExprKind::StaticRef { def_id, .. } = self.thir[arg].kind {
371 if self.tcx.is_mutable_static(def_id) {
372 self.requires_unsafe(expr.span, UseOfMutableStatic);
373 } else if self.tcx.is_foreign_item(def_id) {
374 self.requires_unsafe(expr.span, UseOfExternStatic);
376 } else if self.thir[arg].ty.is_unsafe_ptr() {
377 self.requires_unsafe(expr.span, DerefOfRawPointer);
380 ExprKind::InlineAsm { .. } | ExprKind::LlvmInlineAsm { .. } => {
381 self.requires_unsafe(expr.span, UseOfInlineAssembly);
383 ExprKind::Adt(box Adt {
390 }) => match self.tcx.layout_scalar_valid_range(adt_def.did) {
391 (Bound::Unbounded, Bound::Unbounded) => {}
392 _ => self.requires_unsafe(expr.span, InitializingTypeWith),
401 let closure_id = closure_id.expect_local();
402 let closure_def = if let Some((did, const_param_id)) =
403 ty::WithOptConstParam::try_lookup(closure_id, self.tcx)
405 ty::WithOptConstParam { did, const_param_did: Some(const_param_id) }
407 ty::WithOptConstParam::unknown(closure_id)
409 let (closure_thir, expr) = self.tcx.thir_body(closure_def);
410 let closure_thir = &closure_thir.borrow();
411 let hir_context = self.tcx.hir().local_def_id_to_hir_id(closure_id);
412 let mut closure_visitor =
413 UnsafetyVisitor { thir: closure_thir, hir_context, ..*self };
414 closure_visitor.visit_expr(&closure_thir[expr]);
415 // Unsafe blocks can be used in closures, make sure to take it into account
416 self.safety_context = closure_visitor.safety_context;
418 ExprKind::Field { lhs, .. } => {
419 let lhs = &self.thir[lhs];
420 if let ty::Adt(adt_def, _) = lhs.ty.kind() {
421 if adt_def.is_union() {
422 if let Some((assigned_ty, assignment_span)) = self.assignment_info {
423 // To avoid semver hazard, we only consider `Copy` and `ManuallyDrop` non-dropping.
426 .map_or(false, |adt| adt.is_manually_drop())
428 .is_copy_modulo_regions(self.tcx.at(expr.span), self.param_env))
430 self.requires_unsafe(assignment_span, AssignToDroppingUnionField);
432 // write to non-drop union field, safe
435 self.requires_unsafe(expr.span, AccessToUnionField);
440 ExprKind::Assign { lhs, rhs } | ExprKind::AssignOp { lhs, rhs, .. } => {
441 let lhs = &self.thir[lhs];
442 // First, check whether we are mutating a layout constrained field
443 let mut visitor = LayoutConstrainedPlaceVisitor::new(self.thir, self.tcx);
444 visit::walk_expr(&mut visitor, lhs);
446 self.requires_unsafe(expr.span, MutationOfLayoutConstrainedField);
449 // Second, check for accesses to union fields
450 // don't have any special handling for AssignOp since it causes a read *and* write to lhs
451 if matches!(expr.kind, ExprKind::Assign { .. }) {
452 self.assignment_info = Some((lhs.ty, expr.span));
453 visit::walk_expr(self, lhs);
454 self.assignment_info = None;
455 visit::walk_expr(self, &self.thir()[rhs]);
456 return; // we have already visited everything by now
459 ExprKind::Borrow { borrow_kind, arg } => {
460 let mut visitor = LayoutConstrainedPlaceVisitor::new(self.thir, self.tcx);
461 visit::walk_expr(&mut visitor, expr);
464 BorrowKind::Shallow | BorrowKind::Shared | BorrowKind::Unique
467 .is_freeze(self.tcx.at(self.thir[arg].span), self.param_env) =>
469 self.requires_unsafe(expr.span, BorrowOfLayoutConstrainedField)
471 BorrowKind::Mut { .. } => {
472 self.requires_unsafe(expr.span, MutationOfLayoutConstrainedField)
474 BorrowKind::Shallow | BorrowKind::Shared | BorrowKind::Unique => {}
478 ExprKind::Let { expr: expr_id, .. } => {
479 let let_expr = &self.thir[expr_id];
480 if let ty::Adt(adt_def, _) = let_expr.ty.kind() {
481 if adt_def.is_union() {
482 self.requires_unsafe(expr.span, AccessToUnionField);
488 visit::walk_expr(self, expr);
492 #[derive(Clone, Copy)]
497 UnsafeBlock { span: Span, hir_id: hir::HirId, used: bool },
500 #[derive(Clone, Copy)]
502 /// The body is not unsafe.
504 /// The body is an unsafe function. The span points to
505 /// the signature of the function.
510 /// Returns whether the body is unsafe.
511 fn is_unsafe(&self) -> bool {
512 matches!(self, BodyUnsafety::Unsafe(_))
515 /// If the body is unsafe, returns the `Span` of its signature.
516 fn unsafe_fn_sig_span(self) -> Option<Span> {
518 BodyUnsafety::Unsafe(span) => Some(span),
519 BodyUnsafety::Safe => None,
524 #[derive(Clone, Copy, PartialEq)]
526 CallToUnsafeFunction,
528 InitializingTypeWith,
532 AssignToDroppingUnionField,
534 MutationOfLayoutConstrainedField,
535 BorrowOfLayoutConstrainedField,
542 pub fn description_and_note(&self) -> (&'static str, &'static str) {
544 CallToUnsafeFunction => (
545 "call to unsafe function",
546 "consult the function's documentation for information on how to avoid undefined \
549 UseOfInlineAssembly => (
550 "use of inline assembly",
551 "inline assembly is entirely unchecked and can cause undefined behavior",
553 InitializingTypeWith => (
554 "initializing type with `rustc_layout_scalar_valid_range` attr",
555 "initializing a layout restricted type's field with a value outside the valid \
556 range is undefined behavior",
558 UseOfMutableStatic => (
559 "use of mutable static",
560 "mutable statics can be mutated by multiple threads: aliasing violations or data \
561 races will cause undefined behavior",
563 UseOfExternStatic => (
564 "use of extern static",
565 "extern statics are not controlled by the Rust type system: invalid data, \
566 aliasing violations or data races will cause undefined behavior",
568 DerefOfRawPointer => (
569 "dereference of raw pointer",
570 "raw pointers may be null, dangling or unaligned; they can violate aliasing rules \
571 and cause data races: all of these are undefined behavior",
573 AssignToDroppingUnionField => (
574 "assignment to union field that might need dropping",
575 "the previous content of the field will be dropped, which causes undefined \
576 behavior if the field was not properly initialized",
578 AccessToUnionField => (
579 "access to union field",
580 "the field may not be properly initialized: using uninitialized data will cause \
583 MutationOfLayoutConstrainedField => (
584 "mutation of layout constrained field",
585 "mutating layout constrained fields cannot statically be checked for valid values",
587 BorrowOfLayoutConstrainedField => (
588 "borrow of layout constrained field with interior mutability",
589 "references to fields of layout constrained fields lose the constraints. Coupled \
590 with interior mutability, the field can be changed to invalid values",
592 CallToFunctionWith => (
593 "call to function with `#[target_feature]`",
594 "can only be called if the required target features are available",
600 pub fn check_unsafety<'tcx>(tcx: TyCtxt<'tcx>, def: ty::WithOptConstParam<LocalDefId>) {
601 // THIR unsafeck is gated under `-Z thir-unsafeck`
602 if !tcx.sess.opts.debugging_opts.thir_unsafeck {
606 // Closures are handled by their owner, if it has a body
607 if tcx.is_closure(def.did.to_def_id()) {
609 let owner = hir.enclosing_body_owner(hir.local_def_id_to_hir_id(def.did));
610 tcx.ensure().thir_check_unsafety(hir.local_def_id(owner));
614 let (thir, expr) = tcx.thir_body(def);
615 let thir = &thir.borrow();
616 // If `thir` is empty, a type error occured, skip this body.
617 if thir.exprs.is_empty() {
621 let hir_id = tcx.hir().local_def_id_to_hir_id(def.did);
622 let body_unsafety = tcx.hir().fn_sig_by_hir_id(hir_id).map_or(BodyUnsafety::Safe, |fn_sig| {
623 if fn_sig.header.unsafety == hir::Unsafety::Unsafe {
624 BodyUnsafety::Unsafe(fn_sig.span)
629 let body_target_features = &tcx.codegen_fn_attrs(def.did).target_features;
631 if body_unsafety.is_unsafe() { SafetyContext::UnsafeFn } else { SafetyContext::Safe };
632 let mut visitor = UnsafetyVisitor {
638 body_target_features,
639 assignment_info: None,
640 in_union_destructure: false,
641 param_env: tcx.param_env(def.did),
644 visitor.visit_expr(&thir[expr]);
647 crate fn thir_check_unsafety<'tcx>(tcx: TyCtxt<'tcx>, def_id: LocalDefId) {
648 if let Some(def) = ty::WithOptConstParam::try_lookup(def_id, tcx) {
649 tcx.thir_check_unsafety_for_const_arg(def)
651 check_unsafety(tcx, ty::WithOptConstParam::unknown(def_id))
655 crate fn thir_check_unsafety_for_const_arg<'tcx>(
657 (did, param_did): (LocalDefId, DefId),
659 check_unsafety(tcx, ty::WithOptConstParam { did, const_param_did: Some(param_did) })