2 extern crate rustc_macros;
4 pub use self::Level::*;
5 use rustc_ast::node_id::{NodeId, NodeMap};
6 use rustc_data_structures::stable_hasher::{HashStable, StableHasher, ToStableHashKey};
7 use rustc_serialize::json::Json;
8 use rustc_span::edition::Edition;
9 use rustc_span::{sym, symbol::Ident, MultiSpan, Span, Symbol};
10 use rustc_target::spec::abi::Abi;
15 macro_rules! pluralize {
17 if $x != 1 { "s" } else { "" }
21 /// Indicates the confidence in the correctness of a suggestion.
23 /// All suggestions are marked with an `Applicability`. Tools use the applicability of a suggestion
24 /// to determine whether it should be automatically applied or if the user should be consulted
25 /// before applying the suggestion.
26 #[derive(Copy, Clone, Debug, PartialEq, Hash, Encodable, Decodable)]
27 pub enum Applicability {
28 /// The suggestion is definitely what the user intended, or maintains the exact meaning of the code.
29 /// This suggestion should be automatically applied.
31 /// In case of multiple `MachineApplicable` suggestions (whether as part of
32 /// the same `multipart_suggestion` or not), all of them should be
33 /// automatically applied.
36 /// The suggestion may be what the user intended, but it is uncertain. The suggestion should
37 /// result in valid Rust code if it is applied.
40 /// The suggestion contains placeholders like `(...)` or `{ /* fields */ }`. The suggestion
41 /// cannot be applied automatically because it will not result in valid Rust code. The user
42 /// will need to fill in the placeholders.
45 /// The applicability of the suggestion is unknown.
49 /// Setting for how to handle a lint.
50 #[derive(Clone, Copy, PartialEq, PartialOrd, Eq, Ord, Debug, Hash)]
59 rustc_data_structures::impl_stable_hash_via_hash!(Level);
62 /// Converts a level to a lower-case string.
63 pub fn as_str(self) -> &'static str {
65 Level::Allow => "allow",
66 Level::Warn => "warn",
67 Level::ForceWarn => "force-warn",
68 Level::Deny => "deny",
69 Level::Forbid => "forbid",
73 /// Converts a lower-case string to a level.
74 pub fn from_str(x: &str) -> Option<Level> {
76 "allow" => Some(Level::Allow),
77 "warn" => Some(Level::Warn),
78 "deny" => Some(Level::Deny),
79 "forbid" => Some(Level::Forbid),
84 /// Converts a symbol to a level.
85 pub fn from_symbol(x: Symbol) -> Option<Level> {
87 sym::allow => Some(Level::Allow),
88 sym::warn => Some(Level::Warn),
89 sym::deny => Some(Level::Deny),
90 sym::forbid => Some(Level::Forbid),
96 /// Specification of a single lint.
97 #[derive(Copy, Clone, Debug)]
99 /// A string identifier for the lint.
101 /// This identifies the lint in attributes and in command-line arguments.
102 /// In those contexts it is always lowercase, but this field is compared
103 /// in a way which is case-insensitive for ASCII characters. This allows
104 /// `declare_lint!()` invocations to follow the convention of upper-case
105 /// statics without repeating the name.
107 /// The name is written with underscores, e.g., "unused_imports".
108 /// On the command line, underscores become dashes.
110 /// See <https://rustc-dev-guide.rust-lang.org/diagnostics.html#lint-naming>
111 /// for naming guidelines.
112 pub name: &'static str,
114 /// Default level for the lint.
116 /// See <https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels>
117 /// for guidelines on choosing a default level.
118 pub default_level: Level,
120 /// Description of the lint or the issue it detects.
122 /// e.g., "imports that are never used"
123 pub desc: &'static str,
125 /// Starting at the given edition, default to the given lint level. If this is `None`, then use
127 pub edition_lint_opts: Option<(Edition, Level)>,
129 /// `true` if this lint is reported even inside expansions of external macros.
130 pub report_in_external_macro: bool,
132 pub future_incompatible: Option<FutureIncompatibleInfo>,
136 /// `Some` if this lint is feature gated, otherwise `None`.
137 pub feature_gate: Option<Symbol>,
139 pub crate_level_only: bool,
142 /// Extra information for a future incompatibility lint.
143 #[derive(Copy, Clone, Debug)]
144 pub struct FutureIncompatibleInfo {
145 /// e.g., a URL for an issue/PR/RFC or error code
146 pub reference: &'static str,
147 /// The reason for the lint used by diagnostics to provide
148 /// the right help message
149 pub reason: FutureIncompatibilityReason,
150 /// Whether to explain the reason to the user.
152 /// Set to false for lints that already include a more detailed
154 pub explain_reason: bool,
157 /// The reason for future incompatibility
158 #[derive(Copy, Clone, Debug)]
159 pub enum FutureIncompatibilityReason {
160 /// This will be an error in a future release
163 /// This will be an error in a future release, and
164 /// Cargo should create a report even for dependencies
165 FutureReleaseErrorReportNow,
166 /// Previously accepted code that will become an
167 /// error in the provided edition
168 EditionError(Edition),
169 /// Code that changes meaning in some way in
170 /// the provided edition
171 EditionSemanticsChange(Edition),
174 impl FutureIncompatibilityReason {
175 pub fn edition(self) -> Option<Edition> {
177 Self::EditionError(e) => Some(e),
178 Self::EditionSemanticsChange(e) => Some(e),
184 impl FutureIncompatibleInfo {
185 pub const fn default_fields_for_macro() -> Self {
186 FutureIncompatibleInfo {
188 reason: FutureIncompatibilityReason::FutureReleaseError,
189 explain_reason: true,
195 pub const fn default_fields_for_macro() -> Self {
198 default_level: Level::Forbid,
200 edition_lint_opts: None,
202 report_in_external_macro: false,
203 future_incompatible: None,
205 crate_level_only: false,
209 /// Gets the lint's name, with ASCII letters converted to lowercase.
210 pub fn name_lower(&self) -> String {
211 self.name.to_ascii_lowercase()
214 pub fn default_level(&self, edition: Edition) -> Level {
215 self.edition_lint_opts
216 .filter(|(e, _)| *e <= edition)
218 .unwrap_or(self.default_level)
222 /// Identifies a lint known to the compiler.
223 #[derive(Clone, Copy, Debug)]
225 // Identity is based on pointer equality of this field.
226 pub lint: &'static Lint,
229 impl PartialEq for LintId {
230 fn eq(&self, other: &LintId) -> bool {
231 std::ptr::eq(self.lint, other.lint)
235 impl Eq for LintId {}
237 impl std::hash::Hash for LintId {
238 fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
239 let ptr = self.lint as *const Lint;
245 /// Gets the `LintId` for a `Lint`.
246 pub fn of(lint: &'static Lint) -> LintId {
250 pub fn lint_name_raw(&self) -> &'static str {
254 /// Gets the name of the lint.
255 pub fn to_string(&self) -> String {
256 self.lint.name_lower()
260 impl<HCX> HashStable<HCX> for LintId {
262 fn hash_stable(&self, hcx: &mut HCX, hasher: &mut StableHasher) {
263 self.lint_name_raw().hash_stable(hcx, hasher);
267 impl<HCX> ToStableHashKey<HCX> for LintId {
268 type KeyType = &'static str;
271 fn to_stable_hash_key(&self, _: &HCX) -> &'static str {
276 // Duplicated from rustc_session::config::ExternDepSpec to avoid cyclic dependency
277 #[derive(PartialEq, Debug)]
278 pub enum ExternDepSpec {
283 // This could be a closure, but then implementing derive trait
284 // becomes hacky (and it gets allocated).
285 #[derive(PartialEq, Debug)]
286 pub enum BuiltinLintDiagnostics {
288 AbsPathWithModule(Span),
289 ProcMacroDeriveResolutionFallback(Span),
290 MacroExpandedMacroExportsAccessedByAbsolutePaths(Span),
291 UnknownCrateTypes(Span, String, String),
292 UnusedImports(String, Vec<(Span, String)>, Option<Span>),
293 RedundantImport(Vec<(Span, bool)>, Ident),
294 DeprecatedMacro(Option<Symbol>, Span),
295 MissingAbi(Span, Abi),
296 UnusedDocComment(Span),
297 UnusedBuiltinAttribute { attr_name: Symbol, macro_name: String, invoc_span: Span },
298 PatternsInFnsWithoutBody(Span, Ident),
299 LegacyDeriveHelpers(Span),
300 ExternDepSpec(String, ExternDepSpec),
301 ProcMacroBackCompat(String),
302 OrPatternsBackCompat(Span, String),
303 ReservedPrefix(Span),
304 TrailingMacro(bool, Ident),
305 BreakWithLabelAndLoop(Span),
306 NamedAsmLabel(String),
307 UnicodeTextFlow(Span, String),
310 /// Lints that are buffered up early on in the `Session` before the
311 /// `LintLevels` is calculated.
313 pub struct BufferedEarlyLint {
314 /// The span of code that we are linting on.
317 /// The lint message.
320 /// The `NodeId` of the AST node that generated the lint.
323 /// A lint Id that can be passed to
324 /// `rustc_lint::early::EarlyContextAndPass::check_id`.
327 /// Customization of the `DiagnosticBuilder<'_>` for the lint.
328 pub diagnostic: BuiltinLintDiagnostics,
332 pub struct LintBuffer {
333 pub map: NodeMap<Vec<BufferedEarlyLint>>,
337 pub fn add_early_lint(&mut self, early_lint: BufferedEarlyLint) {
338 let arr = self.map.entry(early_lint.node_id).or_default();
339 if !arr.contains(&early_lint) {
340 arr.push(early_lint);
350 diagnostic: BuiltinLintDiagnostics,
352 let lint_id = LintId::of(lint);
353 let msg = msg.to_string();
354 self.add_early_lint(BufferedEarlyLint { lint_id, node_id, span, msg, diagnostic });
357 pub fn take(&mut self, id: NodeId) -> Vec<BufferedEarlyLint> {
358 self.map.remove(&id).unwrap_or_default()
365 sp: impl Into<MultiSpan>,
368 self.add_lint(lint, id, sp.into(), msg, BuiltinLintDiagnostics::Normal)
371 pub fn buffer_lint_with_diagnostic(
375 sp: impl Into<MultiSpan>,
377 diagnostic: BuiltinLintDiagnostics,
379 self.add_lint(lint, id, sp.into(), msg, diagnostic)
383 /// Declares a static item of type `&'static Lint`.
385 /// See <https://rustc-dev-guide.rust-lang.org/diagnostics.html> for
386 /// documentation and guidelines on writing lints.
388 /// The macro call should start with a doc comment explaining the lint
389 /// which will be embedded in the rustc user documentation book. It should
390 /// be written in markdown and have a format that looks like this:
392 /// ```rust,ignore (doc-example)
393 /// /// The `my_lint_name` lint detects [short explanation here].
398 /// /// [insert a concise example that triggers the lint]
403 /// /// ### Explanation
405 /// /// This should be a detailed explanation of *why* the lint exists,
406 /// /// and also include suggestions on how the user should fix the problem.
407 /// /// Try to keep the text simple enough that a beginner can understand,
408 /// /// and include links to other documentation for terminology that a
409 /// /// beginner may not be familiar with. If this is "allow" by default,
410 /// /// it should explain why (are there false positives or other issues?). If
411 /// /// this is a future-incompatible lint, it should say so, with text that
412 /// /// looks roughly like this:
414 /// /// This is a [future-incompatible] lint to transition this to a hard
415 /// /// error in the future. See [issue #xxxxx] for more details.
417 /// /// [issue #xxxxx]: https://github.com/rust-lang/rust/issues/xxxxx
420 /// The `{{produces}}` tag will be automatically replaced with the output from
421 /// the example by the build system. If the lint example is too complex to run
422 /// as a simple example (for example, it needs an extern crate), mark the code
423 /// block with `ignore` and manually replace the `{{produces}}` line with the
424 /// expected output in a `text` code block.
426 /// If this is a rustdoc-only lint, then only include a brief introduction
427 /// with a link with the text `[rustdoc book]` so that the validator knows
428 /// that this is for rustdoc only (see BROKEN_INTRA_DOC_LINKS as an example).
430 /// Commands to view and test the documentation:
432 /// * `./x.py doc --stage=1 src/doc/rustc --open`: Builds the rustc book and opens it.
433 /// * `./x.py test src/tools/lint-docs`: Validates that the lint docs have the
434 /// correct style, and that the code example actually emits the expected
437 /// If you have already built the compiler, and you want to make changes to
438 /// just the doc comments, then use the `--keep-stage=0` flag with the above
439 /// commands to avoid rebuilding the compiler.
441 macro_rules! declare_lint {
442 ($(#[$attr:meta])* $vis: vis $NAME: ident, $Level: ident, $desc: expr) => (
443 $crate::declare_lint!(
444 $(#[$attr])* $vis $NAME, $Level, $desc,
447 ($(#[$attr:meta])* $vis: vis $NAME: ident, $Level: ident, $desc: expr,
448 $(@feature_gate = $gate:expr;)?
449 $(@future_incompatible = FutureIncompatibleInfo { $($field:ident : $val:expr),* $(,)* }; )?
452 $vis static $NAME: &$crate::Lint = &$crate::Lint {
453 name: stringify!($NAME),
454 default_level: $crate::$Level,
456 edition_lint_opts: None,
459 $(feature_gate: Some($gate),)*
460 $(future_incompatible: Some($crate::FutureIncompatibleInfo {
462 ..$crate::FutureIncompatibleInfo::default_fields_for_macro()
464 ..$crate::Lint::default_fields_for_macro()
467 ($(#[$attr:meta])* $vis: vis $NAME: ident, $Level: ident, $desc: expr,
468 $lint_edition: expr => $edition_level: ident
471 $vis static $NAME: &$crate::Lint = &$crate::Lint {
472 name: stringify!($NAME),
473 default_level: $crate::$Level,
475 edition_lint_opts: Some(($lint_edition, $crate::Level::$edition_level)),
476 report_in_external_macro: false,
483 macro_rules! declare_tool_lint {
485 $(#[$attr:meta])* $vis:vis $tool:ident ::$NAME:ident, $Level: ident, $desc: expr
487 $crate::declare_tool_lint!{$(#[$attr])* $vis $tool::$NAME, $Level, $desc, false}
490 $(#[$attr:meta])* $vis:vis $tool:ident ::$NAME:ident, $Level:ident, $desc:expr,
491 report_in_external_macro: $rep:expr
493 $crate::declare_tool_lint!{$(#[$attr])* $vis $tool::$NAME, $Level, $desc, $rep}
496 $(#[$attr:meta])* $vis:vis $tool:ident ::$NAME:ident, $Level:ident, $desc:expr,
500 $vis static $NAME: &$crate::Lint = &$crate::Lint {
501 name: &concat!(stringify!($tool), "::", stringify!($NAME)),
502 default_level: $crate::$Level,
504 edition_lint_opts: None,
505 report_in_external_macro: $external,
506 future_incompatible: None,
509 crate_level_only: false,
514 /// Declares a static `LintArray` and return it as an expression.
516 macro_rules! lint_array {
517 ($( $lint:expr ),* ,) => { lint_array!( $($lint),* ) };
518 ($( $lint:expr ),*) => {{
523 pub type LintArray = Vec<&'static Lint>;
526 fn name(&self) -> &'static str;
529 /// Implements `LintPass for $ty` with the given list of `Lint` statics.
531 macro_rules! impl_lint_pass {
532 ($ty:ty => [$($lint:expr),* $(,)?]) => {
533 impl $crate::LintPass for $ty {
534 fn name(&self) -> &'static str { stringify!($ty) }
537 pub fn get_lints() -> $crate::LintArray { $crate::lint_array!($($lint),*) }
542 /// Declares a type named `$name` which implements `LintPass`.
543 /// To the right of `=>` a comma separated list of `Lint` statics is given.
545 macro_rules! declare_lint_pass {
546 ($(#[$m:meta])* $name:ident => [$($lint:expr),* $(,)?]) => {
547 $(#[$m])* #[derive(Copy, Clone)] pub struct $name;
548 $crate::impl_lint_pass!($name => [$($lint),*]);