1 // ignore-tidy-filelength
3 //! Lints in the Rust compiler.
5 //! This contains lints which can feasibly be implemented as their own
6 //! AST visitor. Also see `rustc_session::lint::builtin`, which contains the
7 //! definitions of lints that are emitted directly inside the main compiler.
9 //! To add a new lint to rustc, declare it here using `declare_lint!()`.
10 //! Then add code to emit the new lint in the appropriate circumstances.
11 //! You can do that in an existing `LintPass` if it makes sense, or in a
12 //! new `LintPass`, or using `Session::add_lint` elsewhere in the
13 //! compiler. Only do the latter if the check can't be written cleanly as a
14 //! `LintPass` (also, note that such lints will need to be defined in
15 //! `rustc_session::lint::builtin`, not here).
17 //! If you define a new `EarlyLintPass`, you will also need to add it to the
18 //! `add_early_builtin!` or `add_early_builtin_with_new!` invocation in
19 //! `lib.rs`. Use the former for unit-like structs and the latter for structs
20 //! with a `pub fn new()`.
22 //! If you define a new `LateLintPass`, you will also need to add it to the
23 //! `late_lint_methods!` invocation in `lib.rs`.
26 types::{transparent_newtype_field, CItemKind},
27 EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintContext,
30 use rustc_ast::tokenstream::{TokenStream, TokenTree};
31 use rustc_ast::visit::{FnCtxt, FnKind};
32 use rustc_ast::{self as ast, *};
33 use rustc_ast_pretty::pprust::{self, expr_to_string};
34 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
35 use rustc_data_structures::stack::ensure_sufficient_stack;
36 use rustc_errors::{Applicability, DiagnosticBuilder, DiagnosticStyledString};
37 use rustc_feature::{deprecated_attributes, AttributeGate, AttributeTemplate, AttributeType};
38 use rustc_feature::{GateIssue, Stability};
40 use rustc_hir::def::{DefKind, Res};
41 use rustc_hir::def_id::{DefId, LocalDefId, LocalDefIdSet};
42 use rustc_hir::{ForeignItemKind, GenericParamKind, PatKind};
43 use rustc_hir::{HirId, Node};
44 use rustc_index::vec::Idx;
45 use rustc_middle::lint::LintDiagnosticBuilder;
46 use rustc_middle::ty::print::with_no_trimmed_paths;
47 use rustc_middle::ty::subst::{GenericArgKind, Subst};
48 use rustc_middle::ty::Instance;
49 use rustc_middle::ty::{self, layout::LayoutError, Ty, TyCtxt};
50 use rustc_session::Session;
51 use rustc_span::edition::Edition;
52 use rustc_span::source_map::Spanned;
53 use rustc_span::symbol::{kw, sym, Ident, Symbol};
54 use rustc_span::{BytePos, Span};
55 use rustc_target::abi::{LayoutOf, VariantIdx};
56 use rustc_trait_selection::traits::misc::can_type_implement_copy;
58 use crate::nonstandard_style::{method_context, MethodLateContext};
61 use tracing::{debug, trace};
63 // hardwired lints from librustc_middle
64 pub use rustc_session::lint::builtin::*;
67 /// The `while_true` lint detects `while true { }`.
81 /// `while true` should be replaced with `loop`. A `loop` expression is
82 /// the preferred way to write an infinite loop because it more directly
83 /// expresses the intent of the loop.
86 "suggest using `loop { }` instead of `while true { }`"
89 declare_lint_pass!(WhileTrue => [WHILE_TRUE]);
91 /// Traverse through any amount of parenthesis and return the first non-parens expression.
92 fn pierce_parens(mut expr: &ast::Expr) -> &ast::Expr {
93 while let ast::ExprKind::Paren(sub) = &expr.kind {
99 impl EarlyLintPass for WhileTrue {
100 fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &ast::Expr) {
101 if let ast::ExprKind::While(cond, _, label) = &e.kind {
102 if let ast::ExprKind::Lit(ref lit) = pierce_parens(cond).kind {
103 if let ast::LitKind::Bool(true) = lit.kind {
104 if !lit.span.from_expansion() {
105 let msg = "denote infinite loops with `loop { ... }`";
106 let condition_span = e.span.with_hi(cond.span.hi());
107 cx.struct_span_lint(WHILE_TRUE, condition_span, |lint| {
109 .span_suggestion_short(
114 label.map_or_else(String::new, |label| format!(
119 Applicability::MachineApplicable,
131 /// The `box_pointers` lints use of the Box type.
135 /// ```rust,compile_fail
136 /// #![deny(box_pointers)]
146 /// This lint is mostly historical, and not particularly useful. `Box<T>`
147 /// used to be built into the language, and the only way to do heap
148 /// allocation. Today's Rust can call into other allocators, etc.
151 "use of owned (Box type) heap memory"
154 declare_lint_pass!(BoxPointers => [BOX_POINTERS]);
157 fn check_heap_type(&self, cx: &LateContext<'_>, span: Span, ty: Ty<'_>) {
158 for leaf in ty.walk() {
159 if let GenericArgKind::Type(leaf_ty) = leaf.unpack() {
160 if leaf_ty.is_box() {
161 cx.struct_span_lint(BOX_POINTERS, span, |lint| {
162 lint.build(&format!("type uses owned (Box type) pointers: {}", ty)).emit()
170 impl<'tcx> LateLintPass<'tcx> for BoxPointers {
171 fn check_item(&mut self, cx: &LateContext<'_>, it: &hir::Item<'_>) {
173 hir::ItemKind::Fn(..)
174 | hir::ItemKind::TyAlias(..)
175 | hir::ItemKind::Enum(..)
176 | hir::ItemKind::Struct(..)
177 | hir::ItemKind::Union(..) => {
178 self.check_heap_type(cx, it.span, cx.tcx.type_of(it.def_id))
183 // If it's a struct, we also have to check the fields' types
185 hir::ItemKind::Struct(ref struct_def, _) | hir::ItemKind::Union(ref struct_def, _) => {
186 for struct_field in struct_def.fields() {
187 let def_id = cx.tcx.hir().local_def_id(struct_field.hir_id);
188 self.check_heap_type(cx, struct_field.span, cx.tcx.type_of(def_id));
195 fn check_expr(&mut self, cx: &LateContext<'_>, e: &hir::Expr<'_>) {
196 let ty = cx.typeck_results().node_type(e.hir_id);
197 self.check_heap_type(cx, e.span, ty);
202 /// The `non_shorthand_field_patterns` lint detects using `Struct { x: x }`
203 /// instead of `Struct { x }` in a pattern.
221 /// Point { x: x, y: y } => (),
230 /// The preferred style is to avoid the repetition of specifying both the
231 /// field name and the binding name if both identifiers are the same.
232 NON_SHORTHAND_FIELD_PATTERNS,
234 "using `Struct { x: x }` instead of `Struct { x }` in a pattern"
237 declare_lint_pass!(NonShorthandFieldPatterns => [NON_SHORTHAND_FIELD_PATTERNS]);
239 impl<'tcx> LateLintPass<'tcx> for NonShorthandFieldPatterns {
240 fn check_pat(&mut self, cx: &LateContext<'_>, pat: &hir::Pat<'_>) {
241 if let PatKind::Struct(ref qpath, field_pats, _) = pat.kind {
246 .expect("struct pattern type is not an ADT")
247 .variant_of_res(cx.qpath_res(qpath, pat.hir_id));
248 for fieldpat in field_pats {
249 if fieldpat.is_shorthand {
252 if fieldpat.span.from_expansion() {
253 // Don't lint if this is a macro expansion: macro authors
254 // shouldn't have to worry about this kind of style issue
258 if let PatKind::Binding(binding_annot, _, ident, None) = fieldpat.pat.kind {
259 if cx.tcx.find_field_index(ident, &variant)
260 == Some(cx.tcx.field_index(fieldpat.hir_id, cx.typeck_results()))
262 cx.struct_span_lint(NON_SHORTHAND_FIELD_PATTERNS, fieldpat.span, |lint| {
264 .build(&format!("the `{}:` in this pattern is redundant", ident));
265 let binding = match binding_annot {
266 hir::BindingAnnotation::Unannotated => None,
267 hir::BindingAnnotation::Mutable => Some("mut"),
268 hir::BindingAnnotation::Ref => Some("ref"),
269 hir::BindingAnnotation::RefMut => Some("ref mut"),
271 let ident = if let Some(binding) = binding {
272 format!("{} {}", binding, ident)
278 "use shorthand field pattern",
280 Applicability::MachineApplicable,
292 /// The `unsafe_code` lint catches usage of `unsafe` code.
296 /// ```rust,compile_fail
297 /// #![deny(unsafe_code)]
309 /// This lint is intended to restrict the usage of `unsafe`, which can be
310 /// difficult to use correctly.
313 "usage of `unsafe` code"
316 declare_lint_pass!(UnsafeCode => [UNSAFE_CODE]);
321 cx: &EarlyContext<'_>,
323 decorate: impl for<'a> FnOnce(LintDiagnosticBuilder<'a>),
325 // This comes from a macro that has `#[allow_internal_unsafe]`.
326 if span.allows_unsafe() {
330 cx.struct_span_lint(UNSAFE_CODE, span, decorate);
333 fn report_overriden_symbol_name(&self, cx: &EarlyContext<'_>, span: Span, msg: &str) {
334 self.report_unsafe(cx, span, |lint| {
337 "the linker's behavior with multiple libraries exporting duplicate symbol \
338 names is undefined and Rust cannot provide guarantees when you manually \
346 impl EarlyLintPass for UnsafeCode {
347 fn check_attribute(&mut self, cx: &EarlyContext<'_>, attr: &ast::Attribute) {
348 if cx.sess().check_name(attr, sym::allow_internal_unsafe) {
349 self.report_unsafe(cx, attr.span, |lint| {
351 "`allow_internal_unsafe` allows defining \
352 macros using unsafe without triggering \
353 the `unsafe_code` lint at their call site",
360 fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &ast::Expr) {
361 if let ast::ExprKind::Block(ref blk, _) = e.kind {
362 // Don't warn about generated blocks; that'll just pollute the output.
363 if blk.rules == ast::BlockCheckMode::Unsafe(ast::UserProvided) {
364 self.report_unsafe(cx, blk.span, |lint| {
365 lint.build("usage of an `unsafe` block").emit()
371 fn check_item(&mut self, cx: &EarlyContext<'_>, it: &ast::Item) {
373 ast::ItemKind::Trait(box ast::TraitKind(_, ast::Unsafe::Yes(_), ..)) => self
374 .report_unsafe(cx, it.span, |lint| {
375 lint.build("declaration of an `unsafe` trait").emit()
378 ast::ItemKind::Impl(box ast::ImplKind { unsafety: ast::Unsafe::Yes(_), .. }) => self
379 .report_unsafe(cx, it.span, |lint| {
380 lint.build("implementation of an `unsafe` trait").emit()
383 ast::ItemKind::Fn(..) => {
384 if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::no_mangle) {
385 self.report_overriden_symbol_name(
388 "declaration of a `no_mangle` function",
391 if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::export_name) {
392 self.report_overriden_symbol_name(
395 "declaration of a function with `export_name`",
400 ast::ItemKind::Static(..) => {
401 if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::no_mangle) {
402 self.report_overriden_symbol_name(
405 "declaration of a `no_mangle` static",
408 if let Some(attr) = cx.sess().find_by_name(&it.attrs, sym::export_name) {
409 self.report_overriden_symbol_name(
412 "declaration of a static with `export_name`",
421 fn check_fn(&mut self, cx: &EarlyContext<'_>, fk: FnKind<'_>, span: Span, _: ast::NodeId) {
425 ast::FnSig { header: ast::FnHeader { unsafety: ast::Unsafe::Yes(_), .. }, .. },
430 let msg = match ctxt {
431 FnCtxt::Foreign => return,
432 FnCtxt::Free => "declaration of an `unsafe` function",
433 FnCtxt::Assoc(_) if body.is_none() => "declaration of an `unsafe` method",
434 FnCtxt::Assoc(_) => "implementation of an `unsafe` method",
436 self.report_unsafe(cx, span, |lint| lint.build(msg).emit());
442 /// The `missing_docs` lint detects missing documentation for public items.
446 /// ```rust,compile_fail
447 /// #![deny(missing_docs)]
455 /// This lint is intended to ensure that a library is well-documented.
456 /// Items without documentation can be difficult for users to understand
457 /// how to use properly.
459 /// This lint is "allow" by default because it can be noisy, and not all
460 /// projects may want to enforce everything to be documented.
463 "detects missing documentation for public members",
464 report_in_external_macro
467 pub struct MissingDoc {
468 /// Stack of whether `#[doc(hidden)]` is set at each level which has lint attributes.
469 doc_hidden_stack: Vec<bool>,
471 /// Private traits or trait items that leaked through. Don't check their methods.
472 private_traits: FxHashSet<hir::HirId>,
475 impl_lint_pass!(MissingDoc => [MISSING_DOCS]);
477 fn has_doc(sess: &Session, attr: &ast::Attribute) -> bool {
478 if attr.is_doc_comment() {
482 if !sess.check_name(attr, sym::doc) {
486 if attr.value_str().is_some() {
490 if let Some(list) = attr.meta_item_list() {
492 if meta.has_name(sym::include) || meta.has_name(sym::hidden) {
502 pub fn new() -> MissingDoc {
503 MissingDoc { doc_hidden_stack: vec![false], private_traits: FxHashSet::default() }
506 fn doc_hidden(&self) -> bool {
507 *self.doc_hidden_stack.last().expect("empty doc_hidden_stack")
510 fn check_missing_docs_attrs(
512 cx: &LateContext<'_>,
515 article: &'static str,
518 // If we're building a test harness, then warning about
519 // documentation is probably not really relevant right now.
520 if cx.sess().opts.test {
524 // `#[doc(hidden)]` disables missing_docs check.
525 if self.doc_hidden() {
529 // Only check publicly-visible items, using the result from the privacy pass.
530 // It's an option so the crate root can also use this function (it doesn't
532 if id != hir::CRATE_HIR_ID {
533 if !cx.access_levels.is_exported(id) {
538 let attrs = cx.tcx.hir().attrs(id);
539 let has_doc = attrs.iter().any(|a| has_doc(cx.sess(), a));
543 cx.tcx.sess.source_map().guess_head_span(sp),
545 lint.build(&format!("missing documentation for {} {}", article, desc)).emit()
552 impl<'tcx> LateLintPass<'tcx> for MissingDoc {
553 fn enter_lint_attrs(&mut self, cx: &LateContext<'_>, attrs: &[ast::Attribute]) {
554 let doc_hidden = self.doc_hidden()
555 || attrs.iter().any(|attr| {
556 cx.sess().check_name(attr, sym::doc)
557 && match attr.meta_item_list() {
559 Some(l) => attr::list_contains_name(&l, sym::hidden),
562 self.doc_hidden_stack.push(doc_hidden);
565 fn exit_lint_attrs(&mut self, _: &LateContext<'_>, _attrs: &[ast::Attribute]) {
566 self.doc_hidden_stack.pop().expect("empty doc_hidden_stack");
569 fn check_crate(&mut self, cx: &LateContext<'_>, krate: &hir::Crate<'_>) {
570 self.check_missing_docs_attrs(cx, hir::CRATE_HIR_ID, krate.item.inner, "the", "crate");
572 for macro_def in krate.exported_macros {
573 let attrs = cx.tcx.hir().attrs(macro_def.hir_id());
574 let has_doc = attrs.iter().any(|a| has_doc(cx.sess(), a));
578 cx.tcx.sess.source_map().guess_head_span(macro_def.span),
579 |lint| lint.build("missing documentation for macro").emit(),
585 fn check_item(&mut self, cx: &LateContext<'_>, it: &hir::Item<'_>) {
587 hir::ItemKind::Trait(.., trait_item_refs) => {
588 // Issue #11592: traits are always considered exported, even when private.
589 if let hir::VisibilityKind::Inherited = it.vis.node {
590 self.private_traits.insert(it.hir_id());
591 for trait_item_ref in trait_item_refs {
592 self.private_traits.insert(trait_item_ref.id.hir_id());
597 hir::ItemKind::Impl(hir::Impl { of_trait: Some(ref trait_ref), items, .. }) => {
598 // If the trait is private, add the impl items to `private_traits` so they don't get
599 // reported for missing docs.
600 let real_trait = trait_ref.path.res.def_id();
601 if let Some(def_id) = real_trait.as_local() {
602 let hir_id = cx.tcx.hir().local_def_id_to_hir_id(def_id);
603 if let Some(Node::Item(item)) = cx.tcx.hir().find(hir_id) {
604 if let hir::VisibilityKind::Inherited = item.vis.node {
605 for impl_item_ref in items {
606 self.private_traits.insert(impl_item_ref.id.hir_id());
614 hir::ItemKind::TyAlias(..)
615 | hir::ItemKind::Fn(..)
616 | hir::ItemKind::Mod(..)
617 | hir::ItemKind::Enum(..)
618 | hir::ItemKind::Struct(..)
619 | hir::ItemKind::Union(..)
620 | hir::ItemKind::Const(..)
621 | hir::ItemKind::Static(..) => {}
626 let (article, desc) = cx.tcx.article_and_description(it.def_id.to_def_id());
628 self.check_missing_docs_attrs(cx, it.hir_id(), it.span, article, desc);
631 fn check_trait_item(&mut self, cx: &LateContext<'_>, trait_item: &hir::TraitItem<'_>) {
632 if self.private_traits.contains(&trait_item.hir_id()) {
636 let (article, desc) = cx.tcx.article_and_description(trait_item.def_id.to_def_id());
638 self.check_missing_docs_attrs(cx, trait_item.hir_id(), trait_item.span, article, desc);
641 fn check_impl_item(&mut self, cx: &LateContext<'_>, impl_item: &hir::ImplItem<'_>) {
642 // If the method is an impl for a trait, don't doc.
643 if method_context(cx, impl_item.hir_id()) == MethodLateContext::TraitImpl {
647 let (article, desc) = cx.tcx.article_and_description(impl_item.def_id.to_def_id());
648 self.check_missing_docs_attrs(cx, impl_item.hir_id(), impl_item.span, article, desc);
651 fn check_foreign_item(&mut self, cx: &LateContext<'_>, foreign_item: &hir::ForeignItem<'_>) {
652 let (article, desc) = cx.tcx.article_and_description(foreign_item.def_id.to_def_id());
653 self.check_missing_docs_attrs(cx, foreign_item.hir_id(), foreign_item.span, article, desc);
656 fn check_field_def(&mut self, cx: &LateContext<'_>, sf: &hir::FieldDef<'_>) {
657 if !sf.is_positional() {
658 self.check_missing_docs_attrs(cx, sf.hir_id, sf.span, "a", "struct field")
662 fn check_variant(&mut self, cx: &LateContext<'_>, v: &hir::Variant<'_>) {
663 self.check_missing_docs_attrs(cx, v.id, v.span, "a", "variant");
668 /// The `missing_copy_implementations` lint detects potentially-forgotten
669 /// implementations of [`Copy`].
671 /// [`Copy`]: https://doc.rust-lang.org/std/marker/trait.Copy.html
675 /// ```rust,compile_fail
676 /// #![deny(missing_copy_implementations)]
687 /// Historically (before 1.0), types were automatically marked as `Copy`
688 /// if possible. This was changed so that it required an explicit opt-in
689 /// by implementing the `Copy` trait. As part of this change, a lint was
690 /// added to alert if a copyable type was not marked `Copy`.
692 /// This lint is "allow" by default because this code isn't bad; it is
693 /// common to write newtypes like this specifically so that a `Copy` type
694 /// is no longer `Copy`. `Copy` types can result in unintended copies of
695 /// large data which can impact performance.
696 pub MISSING_COPY_IMPLEMENTATIONS,
698 "detects potentially-forgotten implementations of `Copy`"
701 declare_lint_pass!(MissingCopyImplementations => [MISSING_COPY_IMPLEMENTATIONS]);
703 impl<'tcx> LateLintPass<'tcx> for MissingCopyImplementations {
704 fn check_item(&mut self, cx: &LateContext<'_>, item: &hir::Item<'_>) {
705 if !cx.access_levels.is_reachable(item.hir_id()) {
708 let (def, ty) = match item.kind {
709 hir::ItemKind::Struct(_, ref ast_generics) => {
710 if !ast_generics.params.is_empty() {
713 let def = cx.tcx.adt_def(item.def_id);
714 (def, cx.tcx.mk_adt(def, cx.tcx.intern_substs(&[])))
716 hir::ItemKind::Union(_, ref ast_generics) => {
717 if !ast_generics.params.is_empty() {
720 let def = cx.tcx.adt_def(item.def_id);
721 (def, cx.tcx.mk_adt(def, cx.tcx.intern_substs(&[])))
723 hir::ItemKind::Enum(_, ref ast_generics) => {
724 if !ast_generics.params.is_empty() {
727 let def = cx.tcx.adt_def(item.def_id);
728 (def, cx.tcx.mk_adt(def, cx.tcx.intern_substs(&[])))
732 if def.has_dtor(cx.tcx) {
735 let param_env = ty::ParamEnv::empty();
736 if ty.is_copy_modulo_regions(cx.tcx.at(item.span), param_env) {
739 if can_type_implement_copy(cx.tcx, param_env, ty).is_ok() {
740 cx.struct_span_lint(MISSING_COPY_IMPLEMENTATIONS, item.span, |lint| {
742 "type could implement `Copy`; consider adding `impl \
752 /// The `missing_debug_implementations` lint detects missing
753 /// implementations of [`fmt::Debug`].
755 /// [`fmt::Debug`]: https://doc.rust-lang.org/std/fmt/trait.Debug.html
759 /// ```rust,compile_fail
760 /// #![deny(missing_debug_implementations)]
769 /// Having a `Debug` implementation on all types can assist with
770 /// debugging, as it provides a convenient way to format and display a
771 /// value. Using the `#[derive(Debug)]` attribute will automatically
772 /// generate a typical implementation, or a custom implementation can be
773 /// added by manually implementing the `Debug` trait.
775 /// This lint is "allow" by default because adding `Debug` to all types can
776 /// have a negative impact on compile time and code size. It also requires
777 /// boilerplate to be added to every type, which can be an impediment.
778 MISSING_DEBUG_IMPLEMENTATIONS,
780 "detects missing implementations of Debug"
784 pub struct MissingDebugImplementations {
785 impling_types: Option<LocalDefIdSet>,
788 impl_lint_pass!(MissingDebugImplementations => [MISSING_DEBUG_IMPLEMENTATIONS]);
790 impl<'tcx> LateLintPass<'tcx> for MissingDebugImplementations {
791 fn check_item(&mut self, cx: &LateContext<'_>, item: &hir::Item<'_>) {
792 if !cx.access_levels.is_reachable(item.hir_id()) {
797 hir::ItemKind::Struct(..) | hir::ItemKind::Union(..) | hir::ItemKind::Enum(..) => {}
801 let debug = match cx.tcx.get_diagnostic_item(sym::debug_trait) {
802 Some(debug) => debug,
806 if self.impling_types.is_none() {
807 let mut impls = LocalDefIdSet::default();
808 cx.tcx.for_each_impl(debug, |d| {
809 if let Some(ty_def) = cx.tcx.type_of(d).ty_adt_def() {
810 if let Some(def_id) = ty_def.did.as_local() {
811 impls.insert(def_id);
816 self.impling_types = Some(impls);
817 debug!("{:?}", self.impling_types);
820 if !self.impling_types.as_ref().unwrap().contains(&item.def_id) {
821 cx.struct_span_lint(MISSING_DEBUG_IMPLEMENTATIONS, item.span, |lint| {
823 "type does not implement `{}`; consider adding `#[derive(Debug)]` \
824 or a manual implementation",
825 cx.tcx.def_path_str(debug)
834 /// The `anonymous_parameters` lint detects anonymous parameters in trait
839 /// ```rust,edition2015,compile_fail
840 /// #![deny(anonymous_parameters)]
852 /// This syntax is mostly a historical accident, and can be worked around
853 /// quite easily by adding an `_` pattern or a descriptive identifier:
857 /// fn foo(_: usize);
861 /// This syntax is now a hard error in the 2018 edition. In the 2015
862 /// edition, this lint is "warn" by default. This lint
863 /// enables the [`cargo fix`] tool with the `--edition` flag to
864 /// automatically transition old code from the 2015 edition to 2018. The
865 /// tool will run this lint and automatically apply the
866 /// suggested fix from the compiler (which is to add `_` to each
867 /// parameter). This provides a completely automated way to update old
868 /// code for a new edition. See [issue #41686] for more details.
870 /// [issue #41686]: https://github.com/rust-lang/rust/issues/41686
871 /// [`cargo fix`]: https://doc.rust-lang.org/cargo/commands/cargo-fix.html
872 pub ANONYMOUS_PARAMETERS,
874 "detects anonymous parameters",
875 @future_incompatible = FutureIncompatibleInfo {
876 reference: "issue #41686 <https://github.com/rust-lang/rust/issues/41686>",
877 edition: Some(Edition::Edition2018),
882 /// Checks for use of anonymous parameters (RFC 1685).
883 AnonymousParameters => [ANONYMOUS_PARAMETERS]
886 impl EarlyLintPass for AnonymousParameters {
887 fn check_trait_item(&mut self, cx: &EarlyContext<'_>, it: &ast::AssocItem) {
888 if cx.sess.edition() != Edition::Edition2015 {
889 // This is a hard error in future editions; avoid linting and erroring
892 if let ast::AssocItemKind::Fn(box FnKind(_, ref sig, _, _)) = it.kind {
893 for arg in sig.decl.inputs.iter() {
894 if let ast::PatKind::Ident(_, ident, None) = arg.pat.kind {
895 if ident.name == kw::Empty {
896 cx.struct_span_lint(ANONYMOUS_PARAMETERS, arg.pat.span, |lint| {
897 let ty_snip = cx.sess.source_map().span_to_snippet(arg.ty.span);
899 let (ty_snip, appl) = if let Ok(ref snip) = ty_snip {
900 (snip.as_str(), Applicability::MachineApplicable)
902 ("<type>", Applicability::HasPlaceholders)
906 "anonymous parameters are deprecated and will be \
907 removed in the next edition.",
911 "try naming the parameter or explicitly \
913 format!("_: {}", ty_snip),
925 /// Check for use of attributes which have been deprecated.
927 pub struct DeprecatedAttr {
928 // This is not free to compute, so we want to keep it around, rather than
929 // compute it for every attribute.
930 depr_attrs: Vec<&'static (Symbol, AttributeType, AttributeTemplate, AttributeGate)>,
933 impl_lint_pass!(DeprecatedAttr => []);
935 impl DeprecatedAttr {
936 pub fn new() -> DeprecatedAttr {
937 DeprecatedAttr { depr_attrs: deprecated_attributes() }
941 fn lint_deprecated_attr(
942 cx: &EarlyContext<'_>,
943 attr: &ast::Attribute,
945 suggestion: Option<&str>,
947 cx.struct_span_lint(DEPRECATED, attr.span, |lint| {
949 .span_suggestion_short(
951 suggestion.unwrap_or("remove this attribute"),
953 Applicability::MachineApplicable,
959 impl EarlyLintPass for DeprecatedAttr {
960 fn check_attribute(&mut self, cx: &EarlyContext<'_>, attr: &ast::Attribute) {
961 for &&(n, _, _, ref g) in &self.depr_attrs {
962 if attr.ident().map(|ident| ident.name) == Some(n) {
963 if let &AttributeGate::Gated(
964 Stability::Deprecated(link, suggestion),
971 format!("use of deprecated attribute `{}`: {}. See {}", name, reason, link);
972 lint_deprecated_attr(cx, attr, &msg, suggestion);
977 if cx.sess().check_name(attr, sym::no_start) || cx.sess().check_name(attr, sym::crate_id) {
978 let path_str = pprust::path_to_string(&attr.get_normal_item().path);
979 let msg = format!("use of deprecated attribute `{}`: no longer used.", path_str);
980 lint_deprecated_attr(cx, attr, &msg, None);
985 fn warn_if_doc(cx: &EarlyContext<'_>, node_span: Span, node_kind: &str, attrs: &[ast::Attribute]) {
986 let mut attrs = attrs.iter().peekable();
988 // Accumulate a single span for sugared doc comments.
989 let mut sugared_span: Option<Span> = None;
991 while let Some(attr) = attrs.next() {
992 if attr.is_doc_comment() {
994 Some(sugared_span.map_or(attr.span, |span| span.with_hi(attr.span.hi())));
997 if attrs.peek().map_or(false, |next_attr| next_attr.is_doc_comment()) {
1001 let span = sugared_span.take().unwrap_or(attr.span);
1003 if attr.is_doc_comment() || cx.sess().check_name(attr, sym::doc) {
1004 cx.struct_span_lint(UNUSED_DOC_COMMENTS, span, |lint| {
1005 let mut err = lint.build("unused doc comment");
1008 format!("rustdoc does not generate documentation for {}", node_kind),
1016 impl EarlyLintPass for UnusedDocComment {
1017 fn check_stmt(&mut self, cx: &EarlyContext<'_>, stmt: &ast::Stmt) {
1018 let kind = match stmt.kind {
1019 ast::StmtKind::Local(..) => "statements",
1020 // Disabled pending discussion in #78306
1021 ast::StmtKind::Item(..) => return,
1022 // expressions will be reported by `check_expr`.
1023 ast::StmtKind::Empty
1024 | ast::StmtKind::Semi(_)
1025 | ast::StmtKind::Expr(_)
1026 | ast::StmtKind::MacCall(_) => return,
1029 warn_if_doc(cx, stmt.span, kind, stmt.kind.attrs());
1032 fn check_arm(&mut self, cx: &EarlyContext<'_>, arm: &ast::Arm) {
1033 let arm_span = arm.pat.span.with_hi(arm.body.span.hi());
1034 warn_if_doc(cx, arm_span, "match arms", &arm.attrs);
1037 fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &ast::Expr) {
1038 warn_if_doc(cx, expr.span, "expressions", &expr.attrs);
1043 /// The `no_mangle_const_items` lint detects any `const` items with the
1044 /// [`no_mangle` attribute].
1046 /// [`no_mangle` attribute]: https://doc.rust-lang.org/reference/abi.html#the-no_mangle-attribute
1050 /// ```rust,compile_fail
1052 /// const FOO: i32 = 5;
1059 /// Constants do not have their symbols exported, and therefore, this
1060 /// probably means you meant to use a [`static`], not a [`const`].
1062 /// [`static`]: https://doc.rust-lang.org/reference/items/static-items.html
1063 /// [`const`]: https://doc.rust-lang.org/reference/items/constant-items.html
1064 NO_MANGLE_CONST_ITEMS,
1066 "const items will not have their symbols exported"
1070 /// The `no_mangle_generic_items` lint detects generic items that must be
1077 /// fn foo<T>(t: T) {
1086 /// An function with generics must have its symbol mangled to accommodate
1087 /// the generic parameter. The [`no_mangle` attribute] has no effect in
1088 /// this situation, and should be removed.
1090 /// [`no_mangle` attribute]: https://doc.rust-lang.org/reference/abi.html#the-no_mangle-attribute
1091 NO_MANGLE_GENERIC_ITEMS,
1093 "generic items must be mangled"
1096 declare_lint_pass!(InvalidNoMangleItems => [NO_MANGLE_CONST_ITEMS, NO_MANGLE_GENERIC_ITEMS]);
1098 impl<'tcx> LateLintPass<'tcx> for InvalidNoMangleItems {
1099 fn check_item(&mut self, cx: &LateContext<'_>, it: &hir::Item<'_>) {
1100 let attrs = cx.tcx.hir().attrs(it.hir_id());
1102 hir::ItemKind::Fn(.., ref generics, _) => {
1103 if let Some(no_mangle_attr) = cx.sess().find_by_name(attrs, sym::no_mangle) {
1104 for param in generics.params {
1106 GenericParamKind::Lifetime { .. } => {}
1107 GenericParamKind::Type { .. } | GenericParamKind::Const { .. } => {
1108 cx.struct_span_lint(NO_MANGLE_GENERIC_ITEMS, it.span, |lint| {
1110 "functions generic over types or consts must be mangled",
1112 .span_suggestion_short(
1113 no_mangle_attr.span,
1114 "remove this attribute",
1116 // Use of `#[no_mangle]` suggests FFI intent; correct
1117 // fix may be to monomorphize source by hand
1118 Applicability::MaybeIncorrect,
1128 hir::ItemKind::Const(..) => {
1129 if cx.sess().contains_name(attrs, sym::no_mangle) {
1130 // Const items do not refer to a particular location in memory, and therefore
1131 // don't have anything to attach a symbol to
1132 cx.struct_span_lint(NO_MANGLE_CONST_ITEMS, it.span, |lint| {
1133 let msg = "const items should never be `#[no_mangle]`";
1134 let mut err = lint.build(msg);
1136 // account for "pub const" (#45562)
1141 .span_to_snippet(it.span)
1142 .map(|snippet| snippet.find("const").unwrap_or(0))
1143 .unwrap_or(0) as u32;
1144 // `const` is 5 chars
1145 let const_span = it.span.with_hi(BytePos(it.span.lo().0 + start + 5));
1146 err.span_suggestion(
1148 "try a static value",
1149 "pub static".to_owned(),
1150 Applicability::MachineApplicable,
1162 /// The `mutable_transmutes` lint catches transmuting from `&T` to `&mut
1163 /// T` because it is [undefined behavior].
1165 /// [undefined behavior]: https://doc.rust-lang.org/reference/behavior-considered-undefined.html
1169 /// ```rust,compile_fail
1171 /// let y = std::mem::transmute::<&i32, &mut i32>(&5);
1179 /// Certain assumptions are made about aliasing of data, and this transmute
1180 /// violates those assumptions. Consider using [`UnsafeCell`] instead.
1182 /// [`UnsafeCell`]: https://doc.rust-lang.org/std/cell/struct.UnsafeCell.html
1185 "mutating transmuted &mut T from &T may cause undefined behavior"
1188 declare_lint_pass!(MutableTransmutes => [MUTABLE_TRANSMUTES]);
1190 impl<'tcx> LateLintPass<'tcx> for MutableTransmutes {
1191 fn check_expr(&mut self, cx: &LateContext<'_>, expr: &hir::Expr<'_>) {
1192 use rustc_target::spec::abi::Abi::RustIntrinsic;
1193 if let Some((&ty::Ref(_, _, from_mt), &ty::Ref(_, _, to_mt))) =
1194 get_transmute_from_to(cx, expr).map(|(ty1, ty2)| (ty1.kind(), ty2.kind()))
1196 if to_mt == hir::Mutability::Mut && from_mt == hir::Mutability::Not {
1197 let msg = "mutating transmuted &mut T from &T may cause undefined behavior, \
1198 consider instead using an UnsafeCell";
1199 cx.struct_span_lint(MUTABLE_TRANSMUTES, expr.span, |lint| lint.build(msg).emit());
1203 fn get_transmute_from_to<'tcx>(
1204 cx: &LateContext<'tcx>,
1205 expr: &hir::Expr<'_>,
1206 ) -> Option<(Ty<'tcx>, Ty<'tcx>)> {
1207 let def = if let hir::ExprKind::Path(ref qpath) = expr.kind {
1208 cx.qpath_res(qpath, expr.hir_id)
1212 if let Res::Def(DefKind::Fn, did) = def {
1213 if !def_id_is_transmute(cx, did) {
1216 let sig = cx.typeck_results().node_type(expr.hir_id).fn_sig(cx.tcx);
1217 let from = sig.inputs().skip_binder()[0];
1218 let to = sig.output().skip_binder();
1219 return Some((from, to));
1224 fn def_id_is_transmute(cx: &LateContext<'_>, def_id: DefId) -> bool {
1225 cx.tcx.fn_sig(def_id).abi() == RustIntrinsic
1226 && cx.tcx.item_name(def_id) == sym::transmute
1232 /// The `unstable_features` is deprecated and should no longer be used.
1235 "enabling unstable features (deprecated. do not use)"
1239 /// Forbids using the `#[feature(...)]` attribute
1240 UnstableFeatures => [UNSTABLE_FEATURES]
1243 impl<'tcx> LateLintPass<'tcx> for UnstableFeatures {
1244 fn check_attribute(&mut self, cx: &LateContext<'_>, attr: &ast::Attribute) {
1245 if cx.sess().check_name(attr, sym::feature) {
1246 if let Some(items) = attr.meta_item_list() {
1248 cx.struct_span_lint(UNSTABLE_FEATURES, item.span(), |lint| {
1249 lint.build("unstable feature").emit()
1258 /// The `unreachable_pub` lint triggers for `pub` items not reachable from
1263 /// ```rust,compile_fail
1264 /// #![deny(unreachable_pub)]
1276 /// A bare `pub` visibility may be misleading if the item is not actually
1277 /// publicly exported from the crate. The `pub(crate)` visibility is
1278 /// recommended to be used instead, which more clearly expresses the intent
1279 /// that the item is only visible within its own crate.
1281 /// This lint is "allow" by default because it will trigger for a large
1282 /// amount existing Rust code, and has some false-positives. Eventually it
1283 /// is desired for this to become warn-by-default.
1284 pub UNREACHABLE_PUB,
1286 "`pub` items not reachable from crate root"
1290 /// Lint for items marked `pub` that aren't reachable from other crates.
1291 UnreachablePub => [UNREACHABLE_PUB]
1294 impl UnreachablePub {
1297 cx: &LateContext<'_>,
1300 vis: &hir::Visibility<'_>,
1304 let mut applicability = Applicability::MachineApplicable;
1306 hir::VisibilityKind::Public if !cx.access_levels.is_reachable(id) => {
1307 if span.from_expansion() {
1308 applicability = Applicability::MaybeIncorrect;
1310 let def_span = cx.tcx.sess.source_map().guess_head_span(span);
1311 cx.struct_span_lint(UNREACHABLE_PUB, def_span, |lint| {
1312 let mut err = lint.build(&format!("unreachable `pub` {}", what));
1313 let replacement = if cx.tcx.features().crate_visibility_modifier {
1320 err.span_suggestion(
1322 "consider restricting its visibility",
1327 err.help("or consider exporting it for use by other crates");
1337 impl<'tcx> LateLintPass<'tcx> for UnreachablePub {
1338 fn check_item(&mut self, cx: &LateContext<'_>, item: &hir::Item<'_>) {
1339 self.perform_lint(cx, "item", item.hir_id(), &item.vis, item.span, true);
1342 fn check_foreign_item(&mut self, cx: &LateContext<'_>, foreign_item: &hir::ForeignItem<'tcx>) {
1346 foreign_item.hir_id(),
1353 fn check_field_def(&mut self, cx: &LateContext<'_>, field: &hir::FieldDef<'_>) {
1354 self.perform_lint(cx, "field", field.hir_id, &field.vis, field.span, false);
1357 fn check_impl_item(&mut self, cx: &LateContext<'_>, impl_item: &hir::ImplItem<'_>) {
1358 self.perform_lint(cx, "item", impl_item.hir_id(), &impl_item.vis, impl_item.span, false);
1363 /// The `type_alias_bounds` lint detects bounds in type aliases.
1368 /// type SendVec<T: Send> = Vec<T>;
1375 /// The trait bounds in a type alias are currently ignored, and should not
1376 /// be included to avoid confusion. This was previously allowed
1377 /// unintentionally; this may become a hard error in the future.
1380 "bounds in type aliases are not enforced"
1384 /// Lint for trait and lifetime bounds in type aliases being mostly ignored.
1385 /// They are relevant when using associated types, but otherwise neither checked
1386 /// at definition site nor enforced at use site.
1387 TypeAliasBounds => [TYPE_ALIAS_BOUNDS]
1390 impl TypeAliasBounds {
1391 fn is_type_variable_assoc(qpath: &hir::QPath<'_>) -> bool {
1393 hir::QPath::TypeRelative(ref ty, _) => {
1394 // If this is a type variable, we found a `T::Assoc`.
1396 hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) => {
1397 matches!(path.res, Res::Def(DefKind::TyParam, _))
1402 hir::QPath::Resolved(..) | hir::QPath::LangItem(..) => false,
1406 fn suggest_changing_assoc_types(ty: &hir::Ty<'_>, err: &mut DiagnosticBuilder<'_>) {
1407 // Access to associates types should use `<T as Bound>::Assoc`, which does not need a
1408 // bound. Let's see if this type does that.
1410 // We use a HIR visitor to walk the type.
1411 use rustc_hir::intravisit::{self, Visitor};
1412 struct WalkAssocTypes<'a, 'db> {
1413 err: &'a mut DiagnosticBuilder<'db>,
1415 impl<'a, 'db, 'v> Visitor<'v> for WalkAssocTypes<'a, 'db> {
1416 type Map = intravisit::ErasedMap<'v>;
1418 fn nested_visit_map(&mut self) -> intravisit::NestedVisitorMap<Self::Map> {
1419 intravisit::NestedVisitorMap::None
1422 fn visit_qpath(&mut self, qpath: &'v hir::QPath<'v>, id: hir::HirId, span: Span) {
1423 if TypeAliasBounds::is_type_variable_assoc(qpath) {
1426 "use fully disambiguated paths (i.e., `<T as Trait>::Assoc`) to refer to \
1427 associated types in type aliases",
1430 intravisit::walk_qpath(self, qpath, id, span)
1434 // Let's go for a walk!
1435 let mut visitor = WalkAssocTypes { err };
1436 visitor.visit_ty(ty);
1440 impl<'tcx> LateLintPass<'tcx> for TypeAliasBounds {
1441 fn check_item(&mut self, cx: &LateContext<'_>, item: &hir::Item<'_>) {
1442 let (ty, type_alias_generics) = match item.kind {
1443 hir::ItemKind::TyAlias(ref ty, ref generics) => (&*ty, generics),
1446 if let hir::TyKind::OpaqueDef(..) = ty.kind {
1447 // Bounds are respected for `type X = impl Trait`
1450 let mut suggested_changing_assoc_types = false;
1451 // There must not be a where clause
1452 if !type_alias_generics.where_clause.predicates.is_empty() {
1456 let mut err = lint.build("where clauses are not enforced in type aliases");
1457 let spans: Vec<_> = type_alias_generics
1461 .map(|pred| pred.span())
1463 err.set_span(spans);
1464 err.span_suggestion(
1465 type_alias_generics.where_clause.span_for_predicates_or_empty_place(),
1466 "the clause will not be checked when the type alias is used, and should be removed",
1468 Applicability::MachineApplicable,
1470 if !suggested_changing_assoc_types {
1471 TypeAliasBounds::suggest_changing_assoc_types(ty, &mut err);
1472 suggested_changing_assoc_types = true;
1478 // The parameters must not have bounds
1479 for param in type_alias_generics.params.iter() {
1480 let spans: Vec<_> = param.bounds.iter().map(|b| b.span()).collect();
1481 let suggestion = spans
1484 let start = param.span.between(*sp); // Include the `:` in `T: Bound`.
1485 (start.to(*sp), String::new())
1488 if !spans.is_empty() {
1489 cx.struct_span_lint(TYPE_ALIAS_BOUNDS, spans, |lint| {
1491 lint.build("bounds on generic parameters are not enforced in type aliases");
1492 let msg = "the bound will not be checked when the type alias is used, \
1493 and should be removed";
1494 err.multipart_suggestion(&msg, suggestion, Applicability::MachineApplicable);
1495 if !suggested_changing_assoc_types {
1496 TypeAliasBounds::suggest_changing_assoc_types(ty, &mut err);
1497 suggested_changing_assoc_types = true;
1507 /// Lint constants that are erroneous.
1508 /// Without this lint, we might not get any diagnostic if the constant is
1509 /// unused within this crate, even though downstream crates can't use it
1510 /// without producing an error.
1511 UnusedBrokenConst => []
1514 impl<'tcx> LateLintPass<'tcx> for UnusedBrokenConst {
1515 fn check_item(&mut self, cx: &LateContext<'_>, it: &hir::Item<'_>) {
1517 hir::ItemKind::Const(_, body_id) => {
1518 let def_id = cx.tcx.hir().body_owner_def_id(body_id).to_def_id();
1519 // trigger the query once for all constants since that will already report the errors
1520 // FIXME: Use ensure here
1521 let _ = cx.tcx.const_eval_poly(def_id);
1523 hir::ItemKind::Static(_, _, body_id) => {
1524 let def_id = cx.tcx.hir().body_owner_def_id(body_id).to_def_id();
1525 // FIXME: Use ensure here
1526 let _ = cx.tcx.eval_static_initializer(def_id);
1534 /// The `trivial_bounds` lint detects trait bounds that don't depend on
1535 /// any type parameters.
1540 /// #![feature(trivial_bounds)]
1541 /// pub struct A where i32: Copy;
1548 /// Usually you would not write a trait bound that you know is always
1549 /// true, or never true. However, when using macros, the macro may not
1550 /// know whether or not the constraint would hold or not at the time when
1551 /// generating the code. Currently, the compiler does not alert you if the
1552 /// constraint is always true, and generates an error if it is never true.
1553 /// The `trivial_bounds` feature changes this to be a warning in both
1554 /// cases, giving macros more freedom and flexibility to generate code,
1555 /// while still providing a signal when writing non-macro code that
1556 /// something is amiss.
1558 /// See [RFC 2056] for more details. This feature is currently only
1559 /// available on the nightly channel, see [tracking issue #48214].
1561 /// [RFC 2056]: https://github.com/rust-lang/rfcs/blob/master/text/2056-allow-trivial-where-clause-constraints.md
1562 /// [tracking issue #48214]: https://github.com/rust-lang/rust/issues/48214
1565 "these bounds don't depend on an type parameters"
1569 /// Lint for trait and lifetime bounds that don't depend on type parameters
1570 /// which either do nothing, or stop the item from being used.
1571 TrivialConstraints => [TRIVIAL_BOUNDS]
1574 impl<'tcx> LateLintPass<'tcx> for TrivialConstraints {
1575 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'tcx>) {
1576 use rustc_middle::ty::fold::TypeFoldable;
1577 use rustc_middle::ty::PredicateKind::*;
1579 if cx.tcx.features().trivial_bounds {
1580 let predicates = cx.tcx.predicates_of(item.def_id);
1581 for &(predicate, span) in predicates.predicates {
1582 let predicate_kind_name = match predicate.kind().skip_binder() {
1583 Trait(..) => "Trait",
1585 RegionOutlives(..) => "Lifetime",
1587 // Ignore projections, as they can only be global
1588 // if the trait bound is global
1590 // Ignore bounds that a user can't type
1595 ConstEvaluatable(..) |
1597 TypeWellFormedFromEnv(..) => continue,
1599 if predicate.is_global() {
1600 cx.struct_span_lint(TRIVIAL_BOUNDS, span, |lint| {
1601 lint.build(&format!(
1602 "{} bound {} does not depend on any type \
1603 or lifetime parameters",
1604 predicate_kind_name, predicate
1615 /// Does nothing as a lint pass, but registers some `Lint`s
1616 /// which are used by other parts of the compiler.
1620 NON_SHORTHAND_FIELD_PATTERNS,
1623 MISSING_COPY_IMPLEMENTATIONS,
1624 MISSING_DEBUG_IMPLEMENTATIONS,
1625 ANONYMOUS_PARAMETERS,
1626 UNUSED_DOC_COMMENTS,
1627 NO_MANGLE_CONST_ITEMS,
1628 NO_MANGLE_GENERIC_ITEMS,
1638 /// The `ellipsis_inclusive_range_patterns` lint detects the [`...` range
1639 /// pattern], which is deprecated.
1641 /// [`...` range pattern]: https://doc.rust-lang.org/reference/patterns.html#range-patterns
1657 /// The `...` range pattern syntax was changed to `..=` to avoid potential
1658 /// confusion with the [`..` range expression]. Use the new form instead.
1660 /// [`..` range expression]: https://doc.rust-lang.org/reference/expressions/range-expr.html
1661 pub ELLIPSIS_INCLUSIVE_RANGE_PATTERNS,
1663 "`...` range patterns are deprecated"
1667 pub struct EllipsisInclusiveRangePatterns {
1668 /// If `Some(_)`, suppress all subsequent pattern
1669 /// warnings for better diagnostics.
1670 node_id: Option<ast::NodeId>,
1673 impl_lint_pass!(EllipsisInclusiveRangePatterns => [ELLIPSIS_INCLUSIVE_RANGE_PATTERNS]);
1675 impl EarlyLintPass for EllipsisInclusiveRangePatterns {
1676 fn check_pat(&mut self, cx: &EarlyContext<'_>, pat: &ast::Pat) {
1677 if self.node_id.is_some() {
1678 // Don't recursively warn about patterns inside range endpoints.
1682 use self::ast::{PatKind, RangeSyntax::DotDotDot};
1684 /// If `pat` is a `...` pattern, return the start and end of the range, as well as the span
1685 /// corresponding to the ellipsis.
1686 fn matches_ellipsis_pat(pat: &ast::Pat) -> Option<(Option<&Expr>, &Expr, Span)> {
1691 Spanned { span, node: RangeEnd::Included(DotDotDot) },
1692 ) => Some((a.as_deref(), b, *span)),
1697 let (parenthesise, endpoints) = match &pat.kind {
1698 PatKind::Ref(subpat, _) => (true, matches_ellipsis_pat(&subpat)),
1699 _ => (false, matches_ellipsis_pat(pat)),
1702 if let Some((start, end, join)) = endpoints {
1703 let msg = "`...` range patterns are deprecated";
1704 let suggestion = "use `..=` for an inclusive range";
1706 self.node_id = Some(pat.id);
1707 cx.struct_span_lint(ELLIPSIS_INCLUSIVE_RANGE_PATTERNS, pat.span, |lint| {
1708 let end = expr_to_string(&end);
1709 let replace = match start {
1710 Some(start) => format!("&({}..={})", expr_to_string(&start), end),
1711 None => format!("&(..={})", end),
1718 Applicability::MachineApplicable,
1723 cx.struct_span_lint(ELLIPSIS_INCLUSIVE_RANGE_PATTERNS, join, |lint| {
1725 .span_suggestion_short(
1729 Applicability::MachineApplicable,
1737 fn check_pat_post(&mut self, _cx: &EarlyContext<'_>, pat: &ast::Pat) {
1738 if let Some(node_id) = self.node_id {
1739 if pat.id == node_id {
1747 /// The `unnameable_test_items` lint detects [`#[test]`][test] functions
1748 /// that are not able to be run by the test harness because they are in a
1749 /// position where they are not nameable.
1751 /// [test]: https://doc.rust-lang.org/reference/attributes/testing.html#the-test-attribute
1759 /// // This test will not fail because it does not run.
1760 /// assert_eq!(1, 2);
1769 /// In order for the test harness to run a test, the test function must be
1770 /// located in a position where it can be accessed from the crate root.
1771 /// This generally means it must be defined in a module, and not anywhere
1772 /// else such as inside another function. The compiler previously allowed
1773 /// this without an error, so a lint was added as an alert that a test is
1774 /// not being used. Whether or not this should be allowed has not yet been
1775 /// decided, see [RFC 2471] and [issue #36629].
1777 /// [RFC 2471]: https://github.com/rust-lang/rfcs/pull/2471#issuecomment-397414443
1778 /// [issue #36629]: https://github.com/rust-lang/rust/issues/36629
1779 UNNAMEABLE_TEST_ITEMS,
1781 "detects an item that cannot be named being marked as `#[test_case]`",
1782 report_in_external_macro
1785 pub struct UnnameableTestItems {
1786 boundary: Option<LocalDefId>, // Id of the item under which things are not nameable
1787 items_nameable: bool,
1790 impl_lint_pass!(UnnameableTestItems => [UNNAMEABLE_TEST_ITEMS]);
1792 impl UnnameableTestItems {
1793 pub fn new() -> Self {
1794 Self { boundary: None, items_nameable: true }
1798 impl<'tcx> LateLintPass<'tcx> for UnnameableTestItems {
1799 fn check_item(&mut self, cx: &LateContext<'_>, it: &hir::Item<'_>) {
1800 if self.items_nameable {
1801 if let hir::ItemKind::Mod(..) = it.kind {
1803 self.items_nameable = false;
1804 self.boundary = Some(it.def_id);
1809 let attrs = cx.tcx.hir().attrs(it.hir_id());
1810 if let Some(attr) = cx.sess().find_by_name(attrs, sym::rustc_test_marker) {
1811 cx.struct_span_lint(UNNAMEABLE_TEST_ITEMS, attr.span, |lint| {
1812 lint.build("cannot test inner items").emit()
1817 fn check_item_post(&mut self, _cx: &LateContext<'_>, it: &hir::Item<'_>) {
1818 if !self.items_nameable && self.boundary == Some(it.def_id) {
1819 self.items_nameable = true;
1825 /// The `keyword_idents` lint detects edition keywords being used as an
1830 /// ```rust,edition2015,compile_fail
1831 /// #![deny(keyword_idents)]
1840 /// Rust [editions] allow the language to evolve without breaking
1841 /// backwards compatibility. This lint catches code that uses new keywords
1842 /// that are added to the language that are used as identifiers (such as a
1843 /// variable name, function name, etc.). If you switch the compiler to a
1844 /// new edition without updating the code, then it will fail to compile if
1845 /// you are using a new keyword as an identifier.
1847 /// You can manually change the identifiers to a non-keyword, or use a
1848 /// [raw identifier], for example `r#dyn`, to transition to a new edition.
1850 /// This lint solves the problem automatically. It is "allow" by default
1851 /// because the code is perfectly valid in older editions. The [`cargo
1852 /// fix`] tool with the `--edition` flag will switch this lint to "warn"
1853 /// and automatically apply the suggested fix from the compiler (which is
1854 /// to use a raw identifier). This provides a completely automated way to
1855 /// update old code for a new edition.
1857 /// [editions]: https://doc.rust-lang.org/edition-guide/
1858 /// [raw identifier]: https://doc.rust-lang.org/reference/identifiers.html
1859 /// [`cargo fix`]: https://doc.rust-lang.org/cargo/commands/cargo-fix.html
1862 "detects edition keywords being used as an identifier",
1863 @future_incompatible = FutureIncompatibleInfo {
1864 reference: "issue #49716 <https://github.com/rust-lang/rust/issues/49716>",
1865 edition: Some(Edition::Edition2018),
1870 /// Check for uses of edition keywords used as an identifier.
1871 KeywordIdents => [KEYWORD_IDENTS]
1874 struct UnderMacro(bool);
1876 impl KeywordIdents {
1877 fn check_tokens(&mut self, cx: &EarlyContext<'_>, tokens: TokenStream) {
1878 for tt in tokens.into_trees() {
1880 // Only report non-raw idents.
1881 TokenTree::Token(token) => {
1882 if let Some((ident, false)) = token.ident() {
1883 self.check_ident_token(cx, UnderMacro(true), ident);
1886 TokenTree::Delimited(_, _, tts) => self.check_tokens(cx, tts),
1891 fn check_ident_token(
1893 cx: &EarlyContext<'_>,
1894 UnderMacro(under_macro): UnderMacro,
1897 let next_edition = match cx.sess.edition() {
1898 Edition::Edition2015 => {
1900 kw::Async | kw::Await | kw::Try => Edition::Edition2018,
1902 // rust-lang/rust#56327: Conservatively do not
1903 // attempt to report occurrences of `dyn` within
1904 // macro definitions or invocations, because `dyn`
1905 // can legitimately occur as a contextual keyword
1906 // in 2015 code denoting its 2018 meaning, and we
1907 // do not want rustfix to inject bugs into working
1908 // code by rewriting such occurrences.
1910 // But if we see `dyn` outside of a macro, we know
1911 // its precise role in the parsed AST and thus are
1912 // assured this is truly an attempt to use it as
1914 kw::Dyn if !under_macro => Edition::Edition2018,
1920 // There are no new keywords yet for the 2018 edition and beyond.
1924 // Don't lint `r#foo`.
1925 if cx.sess.parse_sess.raw_identifier_spans.borrow().contains(&ident.span) {
1929 cx.struct_span_lint(KEYWORD_IDENTS, ident.span, |lint| {
1930 lint.build(&format!("`{}` is a keyword in the {} edition", ident, next_edition))
1933 "you can use a raw identifier to stay compatible",
1934 format!("r#{}", ident),
1935 Applicability::MachineApplicable,
1942 impl EarlyLintPass for KeywordIdents {
1943 fn check_mac_def(&mut self, cx: &EarlyContext<'_>, mac_def: &ast::MacroDef, _id: ast::NodeId) {
1944 self.check_tokens(cx, mac_def.body.inner_tokens());
1946 fn check_mac(&mut self, cx: &EarlyContext<'_>, mac: &ast::MacCall) {
1947 self.check_tokens(cx, mac.args.inner_tokens());
1949 fn check_ident(&mut self, cx: &EarlyContext<'_>, ident: Ident) {
1950 self.check_ident_token(cx, UnderMacro(false), ident);
1954 declare_lint_pass!(ExplicitOutlivesRequirements => [EXPLICIT_OUTLIVES_REQUIREMENTS]);
1956 impl ExplicitOutlivesRequirements {
1957 fn lifetimes_outliving_lifetime<'tcx>(
1958 inferred_outlives: &'tcx [(ty::Predicate<'tcx>, Span)],
1960 ) -> Vec<ty::Region<'tcx>> {
1963 .filter_map(|(pred, _)| match pred.kind().skip_binder() {
1964 ty::PredicateKind::RegionOutlives(ty::OutlivesPredicate(a, b)) => match a {
1965 ty::ReEarlyBound(ebr) if ebr.index == index => Some(b),
1973 fn lifetimes_outliving_type<'tcx>(
1974 inferred_outlives: &'tcx [(ty::Predicate<'tcx>, Span)],
1976 ) -> Vec<ty::Region<'tcx>> {
1979 .filter_map(|(pred, _)| match pred.kind().skip_binder() {
1980 ty::PredicateKind::TypeOutlives(ty::OutlivesPredicate(a, b)) => {
1981 a.is_param(index).then_some(b)
1988 fn collect_outlived_lifetimes<'tcx>(
1990 param: &'tcx hir::GenericParam<'tcx>,
1992 inferred_outlives: &'tcx [(ty::Predicate<'tcx>, Span)],
1993 ty_generics: &'tcx ty::Generics,
1994 ) -> Vec<ty::Region<'tcx>> {
1996 ty_generics.param_def_id_to_index[&tcx.hir().local_def_id(param.hir_id).to_def_id()];
1999 hir::GenericParamKind::Lifetime { .. } => {
2000 Self::lifetimes_outliving_lifetime(inferred_outlives, index)
2002 hir::GenericParamKind::Type { .. } => {
2003 Self::lifetimes_outliving_type(inferred_outlives, index)
2005 hir::GenericParamKind::Const { .. } => Vec::new(),
2009 fn collect_outlives_bound_spans<'tcx>(
2012 bounds: &hir::GenericBounds<'_>,
2013 inferred_outlives: &[ty::Region<'tcx>],
2015 ) -> Vec<(usize, Span)> {
2016 use rustc_middle::middle::resolve_lifetime::Region;
2021 .filter_map(|(i, bound)| {
2022 if let hir::GenericBound::Outlives(lifetime) = bound {
2023 let is_inferred = match tcx.named_region(lifetime.hir_id) {
2024 Some(Region::Static) if infer_static => {
2025 inferred_outlives.iter().any(|r| matches!(r, ty::ReStatic))
2027 Some(Region::EarlyBound(index, ..)) => inferred_outlives.iter().any(|r| {
2028 if let ty::ReEarlyBound(ebr) = r { ebr.index == index } else { false }
2032 is_inferred.then_some((i, bound.span()))
2040 fn consolidate_outlives_bound_spans(
2043 bounds: &hir::GenericBounds<'_>,
2044 bound_spans: Vec<(usize, Span)>,
2046 if bounds.is_empty() {
2049 if bound_spans.len() == bounds.len() {
2050 let (_, last_bound_span) = bound_spans[bound_spans.len() - 1];
2051 // If all bounds are inferable, we want to delete the colon, so
2052 // start from just after the parameter (span passed as argument)
2053 vec![lo.to(last_bound_span)]
2055 let mut merged = Vec::new();
2056 let mut last_merged_i = None;
2058 let mut from_start = true;
2059 for (i, bound_span) in bound_spans {
2060 match last_merged_i {
2061 // If the first bound is inferable, our span should also eat the leading `+`.
2063 merged.push(bound_span.to(bounds[1].span().shrink_to_lo()));
2064 last_merged_i = Some(0);
2066 // If consecutive bounds are inferable, merge their spans
2067 Some(h) if i == h + 1 => {
2068 if let Some(tail) = merged.last_mut() {
2069 // Also eat the trailing `+` if the first
2070 // more-than-one bound is inferable
2071 let to_span = if from_start && i < bounds.len() {
2072 bounds[i + 1].span().shrink_to_lo()
2076 *tail = tail.to(to_span);
2077 last_merged_i = Some(i);
2079 bug!("another bound-span visited earlier");
2083 // When we find a non-inferable bound, subsequent inferable bounds
2084 // won't be consecutive from the start (and we'll eat the leading
2085 // `+` rather than the trailing one)
2087 merged.push(bounds[i - 1].span().shrink_to_hi().to(bound_span));
2088 last_merged_i = Some(i);
2097 impl<'tcx> LateLintPass<'tcx> for ExplicitOutlivesRequirements {
2098 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
2099 use rustc_middle::middle::resolve_lifetime::Region;
2101 let infer_static = cx.tcx.features().infer_static_outlives_requirements;
2102 let def_id = item.def_id;
2103 if let hir::ItemKind::Struct(_, ref hir_generics)
2104 | hir::ItemKind::Enum(_, ref hir_generics)
2105 | hir::ItemKind::Union(_, ref hir_generics) = item.kind
2107 let inferred_outlives = cx.tcx.inferred_outlives_of(def_id);
2108 if inferred_outlives.is_empty() {
2112 let ty_generics = cx.tcx.generics_of(def_id);
2114 let mut bound_count = 0;
2115 let mut lint_spans = Vec::new();
2117 for param in hir_generics.params {
2118 let has_lifetime_bounds = param
2121 .any(|bound| matches!(bound, hir::GenericBound::Outlives(_)));
2122 if !has_lifetime_bounds {
2126 let relevant_lifetimes =
2127 self.collect_outlived_lifetimes(param, cx.tcx, inferred_outlives, ty_generics);
2128 if relevant_lifetimes.is_empty() {
2132 let bound_spans = self.collect_outlives_bound_spans(
2135 &relevant_lifetimes,
2138 bound_count += bound_spans.len();
2139 lint_spans.extend(self.consolidate_outlives_bound_spans(
2140 param.span.shrink_to_hi(),
2146 let mut where_lint_spans = Vec::new();
2147 let mut dropped_predicate_count = 0;
2148 let num_predicates = hir_generics.where_clause.predicates.len();
2149 for (i, where_predicate) in hir_generics.where_clause.predicates.iter().enumerate() {
2150 let (relevant_lifetimes, bounds, span) = match where_predicate {
2151 hir::WherePredicate::RegionPredicate(predicate) => {
2152 if let Some(Region::EarlyBound(index, ..)) =
2153 cx.tcx.named_region(predicate.lifetime.hir_id)
2156 Self::lifetimes_outliving_lifetime(inferred_outlives, index),
2164 hir::WherePredicate::BoundPredicate(predicate) => {
2165 // FIXME we can also infer bounds on associated types,
2166 // and should check for them here.
2167 match predicate.bounded_ty.kind {
2168 hir::TyKind::Path(hir::QPath::Resolved(None, ref path)) => {
2169 if let Res::Def(DefKind::TyParam, def_id) = path.res {
2170 let index = ty_generics.param_def_id_to_index[&def_id];
2172 Self::lifetimes_outliving_type(inferred_outlives, index),
2187 if relevant_lifetimes.is_empty() {
2191 let bound_spans = self.collect_outlives_bound_spans(
2194 &relevant_lifetimes,
2197 bound_count += bound_spans.len();
2199 let drop_predicate = bound_spans.len() == bounds.len();
2201 dropped_predicate_count += 1;
2204 // If all the bounds on a predicate were inferable and there are
2205 // further predicates, we want to eat the trailing comma.
2206 if drop_predicate && i + 1 < num_predicates {
2207 let next_predicate_span = hir_generics.where_clause.predicates[i + 1].span();
2208 where_lint_spans.push(span.to(next_predicate_span.shrink_to_lo()));
2210 where_lint_spans.extend(self.consolidate_outlives_bound_spans(
2211 span.shrink_to_lo(),
2218 // If all predicates are inferable, drop the entire clause
2219 // (including the `where`)
2220 if num_predicates > 0 && dropped_predicate_count == num_predicates {
2221 let where_span = hir_generics
2224 .expect("span of (nonempty) where clause should exist");
2225 // Extend the where clause back to the closing `>` of the
2226 // generics, except for tuple struct, which have the `where`
2227 // after the fields of the struct.
2228 let full_where_span =
2229 if let hir::ItemKind::Struct(hir::VariantData::Tuple(..), _) = item.kind {
2232 hir_generics.span.shrink_to_hi().to(where_span)
2234 lint_spans.push(full_where_span);
2236 lint_spans.extend(where_lint_spans);
2239 if !lint_spans.is_empty() {
2240 cx.struct_span_lint(EXPLICIT_OUTLIVES_REQUIREMENTS, lint_spans.clone(), |lint| {
2241 lint.build("outlives requirements can be inferred")
2242 .multipart_suggestion(
2243 if bound_count == 1 {
2246 "remove these bounds"
2250 .map(|span| (span, "".to_owned()))
2251 .collect::<Vec<_>>(),
2252 Applicability::MachineApplicable,
2262 /// The `incomplete_features` lint detects unstable features enabled with
2263 /// the [`feature` attribute] that may function improperly in some or all
2266 /// [`feature` attribute]: https://doc.rust-lang.org/nightly/unstable-book/
2271 /// #![feature(generic_associated_types)]
2278 /// Although it is encouraged for people to experiment with unstable
2279 /// features, some of them are known to be incomplete or faulty. This lint
2280 /// is a signal that the feature has not yet been finished, and you may
2281 /// experience problems with it.
2282 pub INCOMPLETE_FEATURES,
2284 "incomplete features that may function improperly in some or all cases"
2288 /// Check for used feature gates in `INCOMPLETE_FEATURES` in `rustc_feature/src/active.rs`.
2289 IncompleteFeatures => [INCOMPLETE_FEATURES]
2292 impl EarlyLintPass for IncompleteFeatures {
2293 fn check_crate(&mut self, cx: &EarlyContext<'_>, _: &ast::Crate) {
2294 let features = cx.sess.features_untracked();
2296 .declared_lang_features
2298 .map(|(name, span, _)| (name, span))
2299 .chain(features.declared_lib_features.iter().map(|(name, span)| (name, span)))
2300 .filter(|(name, _)| rustc_feature::INCOMPLETE_FEATURES.iter().any(|f| name == &f))
2301 .for_each(|(&name, &span)| {
2302 cx.struct_span_lint(INCOMPLETE_FEATURES, span, |lint| {
2303 let mut builder = lint.build(&format!(
2304 "the feature `{}` is incomplete and may not be safe to use \
2305 and/or cause compiler crashes",
2308 if let Some(n) = rustc_feature::find_feature_issue(name, GateIssue::Language) {
2309 builder.note(&format!(
2310 "see issue #{} <https://github.com/rust-lang/rust/issues/{}> \
2311 for more information",
2315 if HAS_MIN_FEATURES.contains(&name) {
2316 builder.help(&format!(
2317 "consider using `min_{}` instead, which is more stable and complete",
2327 const HAS_MIN_FEATURES: &[Symbol] = &[sym::specialization];
2330 /// The `invalid_value` lint detects creating a value that is not valid,
2331 /// such as a NULL reference.
2336 /// # #![allow(unused)]
2338 /// let x: &'static i32 = std::mem::zeroed();
2346 /// In some situations the compiler can detect that the code is creating
2347 /// an invalid value, which should be avoided.
2349 /// In particular, this lint will check for improper use of
2350 /// [`mem::zeroed`], [`mem::uninitialized`], [`mem::transmute`], and
2351 /// [`MaybeUninit::assume_init`] that can cause [undefined behavior]. The
2352 /// lint should provide extra information to indicate what the problem is
2353 /// and a possible solution.
2355 /// [`mem::zeroed`]: https://doc.rust-lang.org/std/mem/fn.zeroed.html
2356 /// [`mem::uninitialized`]: https://doc.rust-lang.org/std/mem/fn.uninitialized.html
2357 /// [`mem::transmute`]: https://doc.rust-lang.org/std/mem/fn.transmute.html
2358 /// [`MaybeUninit::assume_init`]: https://doc.rust-lang.org/std/mem/union.MaybeUninit.html#method.assume_init
2359 /// [undefined behavior]: https://doc.rust-lang.org/reference/behavior-considered-undefined.html
2362 "an invalid value is being created (such as a NULL reference)"
2365 declare_lint_pass!(InvalidValue => [INVALID_VALUE]);
2367 impl<'tcx> LateLintPass<'tcx> for InvalidValue {
2368 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &hir::Expr<'_>) {
2369 #[derive(Debug, Copy, Clone, PartialEq)]
2375 /// Information about why a type cannot be initialized this way.
2376 /// Contains an error message and optionally a span to point at.
2377 type InitError = (String, Option<Span>);
2379 /// Test if this constant is all-0.
2380 fn is_zero(expr: &hir::Expr<'_>) -> bool {
2381 use hir::ExprKind::*;
2382 use rustc_ast::LitKind::*;
2385 if let Int(i, _) = lit.node {
2391 Tup(tup) => tup.iter().all(is_zero),
2396 /// Determine if this expression is a "dangerous initialization".
2397 fn is_dangerous_init(cx: &LateContext<'_>, expr: &hir::Expr<'_>) -> Option<InitKind> {
2398 if let hir::ExprKind::Call(ref path_expr, ref args) = expr.kind {
2399 // Find calls to `mem::{uninitialized,zeroed}` methods.
2400 if let hir::ExprKind::Path(ref qpath) = path_expr.kind {
2401 let def_id = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id()?;
2403 if cx.tcx.is_diagnostic_item(sym::mem_zeroed, def_id) {
2404 return Some(InitKind::Zeroed);
2405 } else if cx.tcx.is_diagnostic_item(sym::mem_uninitialized, def_id) {
2406 return Some(InitKind::Uninit);
2407 } else if cx.tcx.is_diagnostic_item(sym::transmute, def_id) && is_zero(&args[0])
2409 return Some(InitKind::Zeroed);
2412 } else if let hir::ExprKind::MethodCall(_, _, ref args, _) = expr.kind {
2413 // Find problematic calls to `MaybeUninit::assume_init`.
2414 let def_id = cx.typeck_results().type_dependent_def_id(expr.hir_id)?;
2415 if cx.tcx.is_diagnostic_item(sym::assume_init, def_id) {
2416 // This is a call to *some* method named `assume_init`.
2417 // See if the `self` parameter is one of the dangerous constructors.
2418 if let hir::ExprKind::Call(ref path_expr, _) = args[0].kind {
2419 if let hir::ExprKind::Path(ref qpath) = path_expr.kind {
2420 let def_id = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id()?;
2422 if cx.tcx.is_diagnostic_item(sym::maybe_uninit_zeroed, def_id) {
2423 return Some(InitKind::Zeroed);
2424 } else if cx.tcx.is_diagnostic_item(sym::maybe_uninit_uninit, def_id) {
2425 return Some(InitKind::Uninit);
2435 /// Test if this enum has several actually "existing" variants.
2436 /// Zero-sized uninhabited variants do not always have a tag assigned and thus do not "exist".
2437 fn is_multi_variant(adt: &ty::AdtDef) -> bool {
2438 // As an approximation, we only count dataless variants. Those are definitely inhabited.
2439 let existing_variants = adt.variants.iter().filter(|v| v.fields.is_empty()).count();
2440 existing_variants > 1
2443 /// Return `Some` only if we are sure this type does *not*
2444 /// allow zero initialization.
2445 fn ty_find_init_error<'tcx>(
2449 ) -> Option<InitError> {
2450 use rustc_middle::ty::TyKind::*;
2452 // Primitive types that don't like 0 as a value.
2453 Ref(..) => Some(("references must be non-null".to_string(), None)),
2454 Adt(..) if ty.is_box() => Some(("`Box` must be non-null".to_string(), None)),
2455 FnPtr(..) => Some(("function pointers must be non-null".to_string(), None)),
2456 Never => Some(("the `!` type has no valid value".to_string(), None)),
2457 RawPtr(tm) if matches!(tm.ty.kind(), Dynamic(..)) =>
2458 // raw ptr to dyn Trait
2460 Some(("the vtable of a wide raw pointer must be non-null".to_string(), None))
2462 // Primitive types with other constraints.
2463 Bool if init == InitKind::Uninit => {
2464 Some(("booleans must be either `true` or `false`".to_string(), None))
2466 Char if init == InitKind::Uninit => {
2467 Some(("characters must be a valid Unicode codepoint".to_string(), None))
2469 // Recurse and checks for some compound types.
2470 Adt(adt_def, substs) if !adt_def.is_union() => {
2471 // First check if this ADT has a layout attribute (like `NonNull` and friends).
2472 use std::ops::Bound;
2473 match tcx.layout_scalar_valid_range(adt_def.did) {
2474 // We exploit here that `layout_scalar_valid_range` will never
2475 // return `Bound::Excluded`. (And we have tests checking that we
2476 // handle the attribute correctly.)
2477 (Bound::Included(lo), _) if lo > 0 => {
2478 return Some((format!("`{}` must be non-null", ty), None));
2480 (Bound::Included(_), _) | (_, Bound::Included(_))
2481 if init == InitKind::Uninit =>
2485 "`{}` must be initialized inside its custom valid range",
2494 match adt_def.variants.len() {
2495 0 => Some(("enums with no variants have no valid value".to_string(), None)),
2497 // Struct, or enum with exactly one variant.
2498 // Proceed recursively, check all fields.
2499 let variant = &adt_def.variants[VariantIdx::from_u32(0)];
2500 variant.fields.iter().find_map(|field| {
2501 ty_find_init_error(tcx, field.ty(tcx, substs), init).map(
2504 // Point to this field, should be helpful for figuring
2505 // out where the source of the error is.
2506 let span = tcx.def_span(field.did);
2509 " (in this {} field)",
2522 // Multi-variant enum.
2524 if init == InitKind::Uninit && is_multi_variant(adt_def) {
2525 let span = tcx.def_span(adt_def.did);
2527 "enums have to be initialized to a variant".to_string(),
2531 // In principle, for zero-initialization we could figure out which variant corresponds
2532 // to tag 0, and check that... but for now we just accept all zero-initializations.
2539 // Proceed recursively, check all fields.
2540 ty.tuple_fields().find_map(|field| ty_find_init_error(tcx, field, init))
2542 // Conservative fallback.
2547 if let Some(init) = is_dangerous_init(cx, expr) {
2548 // This conjures an instance of a type out of nothing,
2549 // using zeroed or uninitialized memory.
2550 // We are extremely conservative with what we warn about.
2551 let conjured_ty = cx.typeck_results().expr_ty(expr);
2552 if let Some((msg, span)) =
2553 with_no_trimmed_paths(|| ty_find_init_error(cx.tcx, conjured_ty, init))
2555 cx.struct_span_lint(INVALID_VALUE, expr.span, |lint| {
2556 let mut err = lint.build(&format!(
2557 "the type `{}` does not permit {}",
2560 InitKind::Zeroed => "zero-initialization",
2561 InitKind::Uninit => "being left uninitialized",
2564 err.span_label(expr.span, "this code causes undefined behavior when executed");
2567 "help: use `MaybeUninit<T>` instead, \
2568 and only call `assume_init` after initialization is done",
2570 if let Some(span) = span {
2571 err.span_note(span, &msg);
2583 /// The `clashing_extern_declarations` lint detects when an `extern fn`
2584 /// has been declared with the same name but different types.
2604 /// Because two symbols of the same name cannot be resolved to two
2605 /// different functions at link time, and one function cannot possibly
2606 /// have two types, a clashing extern declaration is almost certainly a
2607 /// mistake. Check to make sure that the `extern` definitions are correct
2608 /// and equivalent, and possibly consider unifying them in one location.
2610 /// This lint does not run between crates because a project may have
2611 /// dependencies which both rely on the same extern function, but declare
2612 /// it in a different (but valid) way. For example, they may both declare
2613 /// an opaque type for one or more of the arguments (which would end up
2614 /// distinct types), or use types that are valid conversions in the
2615 /// language the `extern fn` is defined in. In these cases, the compiler
2616 /// can't say that the clashing declaration is incorrect.
2617 pub CLASHING_EXTERN_DECLARATIONS,
2619 "detects when an extern fn has been declared with the same name but different types"
2622 pub struct ClashingExternDeclarations {
2623 /// Map of function symbol name to the first-seen hir id for that symbol name.. If seen_decls
2624 /// contains an entry for key K, it means a symbol with name K has been seen by this lint and
2625 /// the symbol should be reported as a clashing declaration.
2626 // FIXME: Technically, we could just store a &'tcx str here without issue; however, the
2627 // `impl_lint_pass` macro doesn't currently support lints parametric over a lifetime.
2628 seen_decls: FxHashMap<Symbol, HirId>,
2631 /// Differentiate between whether the name for an extern decl came from the link_name attribute or
2632 /// just from declaration itself. This is important because we don't want to report clashes on
2633 /// symbol name if they don't actually clash because one or the other links against a symbol with a
2636 /// The name of the symbol + the span of the annotation which introduced the link name.
2638 /// No link name, so just the name of the symbol.
2643 fn get_name(&self) -> Symbol {
2645 SymbolName::Link(s, _) | SymbolName::Normal(s) => *s,
2650 impl ClashingExternDeclarations {
2651 crate fn new() -> Self {
2652 ClashingExternDeclarations { seen_decls: FxHashMap::default() }
2654 /// Insert a new foreign item into the seen set. If a symbol with the same name already exists
2655 /// for the item, return its HirId without updating the set.
2656 fn insert(&mut self, tcx: TyCtxt<'_>, fi: &hir::ForeignItem<'_>) -> Option<HirId> {
2657 let did = fi.def_id.to_def_id();
2658 let instance = Instance::new(did, ty::List::identity_for_item(tcx, did));
2659 let name = Symbol::intern(tcx.symbol_name(instance).name);
2660 if let Some(&hir_id) = self.seen_decls.get(&name) {
2661 // Avoid updating the map with the new entry when we do find a collision. We want to
2662 // make sure we're always pointing to the first definition as the previous declaration.
2663 // This lets us avoid emitting "knock-on" diagnostics.
2666 self.seen_decls.insert(name, fi.hir_id())
2670 /// Get the name of the symbol that's linked against for a given extern declaration. That is,
2671 /// the name specified in a #[link_name = ...] attribute if one was specified, else, just the
2673 fn name_of_extern_decl(tcx: TyCtxt<'_>, fi: &hir::ForeignItem<'_>) -> SymbolName {
2674 if let Some((overridden_link_name, overridden_link_name_span)) =
2675 tcx.codegen_fn_attrs(fi.def_id).link_name.map(|overridden_link_name| {
2676 // FIXME: Instead of searching through the attributes again to get span
2677 // information, we could have codegen_fn_attrs also give span information back for
2678 // where the attribute was defined. However, until this is found to be a
2679 // bottleneck, this does just fine.
2681 overridden_link_name,
2682 tcx.get_attrs(fi.def_id.to_def_id())
2684 .find(|at| tcx.sess.check_name(at, sym::link_name))
2690 SymbolName::Link(overridden_link_name, overridden_link_name_span)
2692 SymbolName::Normal(fi.ident.name)
2696 /// Checks whether two types are structurally the same enough that the declarations shouldn't
2697 /// clash. We need this so we don't emit a lint when two modules both declare an extern struct,
2698 /// with the same members (as the declarations shouldn't clash).
2699 fn structurally_same_type<'tcx>(
2700 cx: &LateContext<'tcx>,
2705 fn structurally_same_type_impl<'tcx>(
2706 seen_types: &mut FxHashSet<(Ty<'tcx>, Ty<'tcx>)>,
2707 cx: &LateContext<'tcx>,
2712 debug!("structurally_same_type_impl(cx, a = {:?}, b = {:?})", a, b);
2715 // Given a transparent newtype, reach through and grab the inner
2716 // type unless the newtype makes the type non-null.
2717 let non_transparent_ty = |ty: Ty<'tcx>| -> Ty<'tcx> {
2720 if let ty::Adt(def, substs) = *ty.kind() {
2721 let is_transparent = def.subst(tcx, substs).repr.transparent();
2722 let is_non_null = crate::types::nonnull_optimization_guaranteed(tcx, &def);
2724 "non_transparent_ty({:?}) -- type is transparent? {}, type is non-null? {}",
2725 ty, is_transparent, is_non_null
2727 if is_transparent && !is_non_null {
2728 debug_assert!(def.variants.len() == 1);
2729 let v = &def.variants[VariantIdx::new(0)];
2730 ty = transparent_newtype_field(tcx, v)
2732 "single-variant transparent structure with zero-sized field",
2738 debug!("non_transparent_ty -> {:?}", ty);
2743 let a = non_transparent_ty(a);
2744 let b = non_transparent_ty(b);
2746 if !seen_types.insert((a, b)) {
2747 // We've encountered a cycle. There's no point going any further -- the types are
2748 // structurally the same.
2752 if a == b || rustc_middle::ty::TyS::same_type(a, b) {
2753 // All nominally-same types are structurally same, too.
2756 // Do a full, depth-first comparison between the two.
2757 use rustc_middle::ty::TyKind::*;
2758 let a_kind = a.kind();
2759 let b_kind = b.kind();
2761 let compare_layouts = |a, b| -> Result<bool, LayoutError<'tcx>> {
2762 debug!("compare_layouts({:?}, {:?})", a, b);
2763 let a_layout = &cx.layout_of(a)?.layout.abi;
2764 let b_layout = &cx.layout_of(b)?.layout.abi;
2766 "comparing layouts: {:?} == {:?} = {}",
2769 a_layout == b_layout
2771 Ok(a_layout == b_layout)
2774 #[allow(rustc::usage_of_ty_tykind)]
2775 let is_primitive_or_pointer = |kind: &ty::TyKind<'_>| {
2776 kind.is_primitive() || matches!(kind, RawPtr(..) | Ref(..))
2779 ensure_sufficient_stack(|| {
2780 match (a_kind, b_kind) {
2781 (Adt(a_def, a_substs), Adt(b_def, b_substs)) => {
2782 let a = a.subst(cx.tcx, a_substs);
2783 let b = b.subst(cx.tcx, b_substs);
2784 debug!("Comparing {:?} and {:?}", a, b);
2786 // We can immediately rule out these types as structurally same if
2787 // their layouts differ.
2788 match compare_layouts(a, b) {
2789 Ok(false) => return false,
2790 _ => (), // otherwise, continue onto the full, fields comparison
2793 // Grab a flattened representation of all fields.
2794 let a_fields = a_def.variants.iter().flat_map(|v| v.fields.iter());
2795 let b_fields = b_def.variants.iter().flat_map(|v| v.fields.iter());
2797 // Perform a structural comparison for each field.
2800 |&ty::FieldDef { did: a_did, .. },
2801 &ty::FieldDef { did: b_did, .. }| {
2802 structurally_same_type_impl(
2812 (Array(a_ty, a_const), Array(b_ty, b_const)) => {
2813 // For arrays, we also check the constness of the type.
2814 a_const.val == b_const.val
2815 && structurally_same_type_impl(seen_types, cx, a_ty, b_ty, ckind)
2817 (Slice(a_ty), Slice(b_ty)) => {
2818 structurally_same_type_impl(seen_types, cx, a_ty, b_ty, ckind)
2820 (RawPtr(a_tymut), RawPtr(b_tymut)) => {
2821 a_tymut.mutbl == b_tymut.mutbl
2822 && structurally_same_type_impl(
2830 (Ref(_a_region, a_ty, a_mut), Ref(_b_region, b_ty, b_mut)) => {
2831 // For structural sameness, we don't need the region to be same.
2833 && structurally_same_type_impl(seen_types, cx, a_ty, b_ty, ckind)
2835 (FnDef(..), FnDef(..)) => {
2836 let a_poly_sig = a.fn_sig(tcx);
2837 let b_poly_sig = b.fn_sig(tcx);
2839 // As we don't compare regions, skip_binder is fine.
2840 let a_sig = a_poly_sig.skip_binder();
2841 let b_sig = b_poly_sig.skip_binder();
2843 (a_sig.abi, a_sig.unsafety, a_sig.c_variadic)
2844 == (b_sig.abi, b_sig.unsafety, b_sig.c_variadic)
2845 && a_sig.inputs().iter().eq_by(b_sig.inputs().iter(), |a, b| {
2846 structurally_same_type_impl(seen_types, cx, a, b, ckind)
2848 && structurally_same_type_impl(
2856 (Tuple(a_substs), Tuple(b_substs)) => {
2857 a_substs.types().eq_by(b_substs.types(), |a_ty, b_ty| {
2858 structurally_same_type_impl(seen_types, cx, a_ty, b_ty, ckind)
2861 // For these, it's not quite as easy to define structural-sameness quite so easily.
2862 // For the purposes of this lint, take the conservative approach and mark them as
2863 // not structurally same.
2864 (Dynamic(..), Dynamic(..))
2865 | (Error(..), Error(..))
2866 | (Closure(..), Closure(..))
2867 | (Generator(..), Generator(..))
2868 | (GeneratorWitness(..), GeneratorWitness(..))
2869 | (Projection(..), Projection(..))
2870 | (Opaque(..), Opaque(..)) => false,
2872 // These definitely should have been caught above.
2873 (Bool, Bool) | (Char, Char) | (Never, Never) | (Str, Str) => unreachable!(),
2875 // An Adt and a primitive or pointer type. This can be FFI-safe if non-null
2876 // enum layout optimisation is being applied.
2877 (Adt(..), other_kind) | (other_kind, Adt(..))
2878 if is_primitive_or_pointer(other_kind) =>
2880 let (primitive, adt) =
2881 if is_primitive_or_pointer(a.kind()) { (a, b) } else { (b, a) };
2882 if let Some(ty) = crate::types::repr_nullable_ptr(cx, adt, ckind) {
2885 compare_layouts(a, b).unwrap_or(false)
2888 // Otherwise, just compare the layouts. This may fail to lint for some
2889 // incompatible types, but at the very least, will stop reads into
2890 // uninitialised memory.
2891 _ => compare_layouts(a, b).unwrap_or(false),
2896 let mut seen_types = FxHashSet::default();
2897 structurally_same_type_impl(&mut seen_types, cx, a, b, ckind)
2901 impl_lint_pass!(ClashingExternDeclarations => [CLASHING_EXTERN_DECLARATIONS]);
2903 impl<'tcx> LateLintPass<'tcx> for ClashingExternDeclarations {
2904 fn check_foreign_item(&mut self, cx: &LateContext<'tcx>, this_fi: &hir::ForeignItem<'_>) {
2905 trace!("ClashingExternDeclarations: check_foreign_item: {:?}", this_fi);
2906 if let ForeignItemKind::Fn(..) = this_fi.kind {
2908 if let Some(existing_hid) = self.insert(tcx, this_fi) {
2909 let existing_decl_ty = tcx.type_of(tcx.hir().local_def_id(existing_hid));
2910 let this_decl_ty = tcx.type_of(this_fi.def_id);
2912 "ClashingExternDeclarations: Comparing existing {:?}: {:?} to this {:?}: {:?}",
2913 existing_hid, existing_decl_ty, this_fi.def_id, this_decl_ty
2915 // Check that the declarations match.
2916 if !Self::structurally_same_type(
2920 CItemKind::Declaration,
2922 let orig_fi = tcx.hir().expect_foreign_item(existing_hid);
2923 let orig = Self::name_of_extern_decl(tcx, orig_fi);
2925 // We want to ensure that we use spans for both decls that include where the
2926 // name was defined, whether that was from the link_name attribute or not.
2927 let get_relevant_span =
2928 |fi: &hir::ForeignItem<'_>| match Self::name_of_extern_decl(tcx, fi) {
2929 SymbolName::Normal(_) => fi.span,
2930 SymbolName::Link(_, annot_span) => fi.span.to(annot_span),
2932 // Finally, emit the diagnostic.
2933 tcx.struct_span_lint_hir(
2934 CLASHING_EXTERN_DECLARATIONS,
2936 get_relevant_span(this_fi),
2938 let mut expected_str = DiagnosticStyledString::new();
2939 expected_str.push(existing_decl_ty.fn_sig(tcx).to_string(), false);
2940 let mut found_str = DiagnosticStyledString::new();
2941 found_str.push(this_decl_ty.fn_sig(tcx).to_string(), true);
2943 lint.build(&format!(
2944 "`{}` redeclare{} with a different signature",
2946 if orig.get_name() == this_fi.ident.name {
2949 format!("s `{}`", orig.get_name())
2953 get_relevant_span(orig_fi),
2954 &format!("`{}` previously declared here", orig.get_name()),
2957 get_relevant_span(this_fi),
2958 "this signature doesn't match the previous declaration",
2960 .note_expected_found(&"", expected_str, &"", found_str)
2971 /// The `deref_nullptr` lint detects when an null pointer is dereferenced,
2972 /// which causes [undefined behavior].
2977 /// # #![allow(unused)]
2980 /// let x = &*ptr::null::<i32>();
2981 /// let x = ptr::addr_of!(*ptr::null::<i32>());
2982 /// let x = *(0 as *const i32);
2990 /// Dereferencing a null pointer causes [undefined behavior] even as a place expression,
2991 /// like `&*(0 as *const i32)` or `addr_of!(*(0 as *const i32))`.
2993 /// [undefined behavior]: https://doc.rust-lang.org/reference/behavior-considered-undefined.html
2996 "detects when an null pointer is dereferenced"
2999 declare_lint_pass!(DerefNullPtr => [DEREF_NULLPTR]);
3001 impl<'tcx> LateLintPass<'tcx> for DerefNullPtr {
3002 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &hir::Expr<'_>) {
3003 /// test if expression is a null ptr
3004 fn is_null_ptr(cx: &LateContext<'_>, expr: &hir::Expr<'_>) -> bool {
3006 rustc_hir::ExprKind::Cast(ref expr, ref ty) => {
3007 if let rustc_hir::TyKind::Ptr(_) = ty.kind {
3008 return is_zero(expr) || is_null_ptr(cx, expr);
3011 // check for call to `core::ptr::null` or `core::ptr::null_mut`
3012 rustc_hir::ExprKind::Call(ref path, _) => {
3013 if let rustc_hir::ExprKind::Path(ref qpath) = path.kind {
3014 if let Some(def_id) = cx.qpath_res(qpath, path.hir_id).opt_def_id() {
3015 return cx.tcx.is_diagnostic_item(sym::ptr_null, def_id)
3016 || cx.tcx.is_diagnostic_item(sym::ptr_null_mut, def_id);
3025 /// test if experssion is the literal `0`
3026 fn is_zero(expr: &hir::Expr<'_>) -> bool {
3028 rustc_hir::ExprKind::Lit(ref lit) => {
3029 if let LitKind::Int(a, _) = lit.node {
3038 if let rustc_hir::ExprKind::Unary(ref un_op, ref expr_deref) = expr.kind {
3039 if let rustc_hir::UnOp::Deref = un_op {
3040 if is_null_ptr(cx, expr_deref) {
3041 cx.struct_span_lint(DEREF_NULLPTR, expr.span, |lint| {
3042 let mut err = lint.build("dereferencing a null pointer");
3045 "this code causes undefined behavior when executed",