1 //! Type checking expressions.
3 //! See `mod.rs` for more context on type checking in general.
6 use crate::coercion::CoerceMany;
7 use crate::coercion::DynamicCoerceMany;
8 use crate::errors::{AddressOfTemporaryTaken, ReturnStmtOutsideOfFnBody, StructExprNonExhaustive};
10 FieldMultiplySpecifiedInInitializer, FunctionalRecordUpdateOnNonStruct,
11 YieldExprOutsideOfGenerator,
13 use crate::fatally_break_rust;
14 use crate::method::SelfSource;
15 use crate::type_error_struct;
16 use crate::Expectation::{self, ExpectCastableToType, ExpectHasType, NoExpectation};
18 report_unexpected_variant_res, BreakableCtxt, Diverges, FnCtxt, Needs,
19 TupleArgumentsFlag::DontTupleArguments,
22 use rustc_data_structures::fx::FxHashMap;
23 use rustc_data_structures::stack::ensure_sufficient_stack;
25 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, DiagnosticId,
26 ErrorGuaranteed, StashKey,
29 use rustc_hir::def::{CtorKind, DefKind, Res};
30 use rustc_hir::def_id::DefId;
31 use rustc_hir::intravisit::Visitor;
32 use rustc_hir::lang_items::LangItem;
33 use rustc_hir::{ExprKind, HirId, QPath};
34 use rustc_hir_analysis::astconv::AstConv as _;
35 use rustc_hir_analysis::check::ty_kind_suggestion;
36 use rustc_infer::infer;
37 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
38 use rustc_infer::infer::InferOk;
39 use rustc_infer::traits::ObligationCause;
40 use rustc_middle::middle::stability;
41 use rustc_middle::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase};
42 use rustc_middle::ty::error::TypeError::FieldMisMatch;
43 use rustc_middle::ty::subst::SubstsRef;
44 use rustc_middle::ty::{self, AdtKind, Ty, TypeVisitable};
45 use rustc_session::errors::ExprParenthesesNeeded;
46 use rustc_session::parse::feature_err;
47 use rustc_span::hygiene::DesugaringKind;
48 use rustc_span::lev_distance::find_best_match_for_name;
49 use rustc_span::source_map::{Span, Spanned};
50 use rustc_span::symbol::{kw, sym, Ident, Symbol};
51 use rustc_target::spec::abi::Abi::RustIntrinsic;
52 use rustc_trait_selection::infer::InferCtxtExt;
53 use rustc_trait_selection::traits::{self, ObligationCauseCode};
55 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
56 fn check_expr_eq_type(&self, expr: &'tcx hir::Expr<'tcx>, expected: Ty<'tcx>) {
57 let ty = self.check_expr_with_hint(expr, expected);
58 self.demand_eqtype(expr.span, expected, ty);
61 pub fn check_expr_has_type_or_error(
63 expr: &'tcx hir::Expr<'tcx>,
65 extend_err: impl FnMut(&mut Diagnostic),
67 self.check_expr_meets_expectation_or_error(expr, ExpectHasType(expected), extend_err)
70 fn check_expr_meets_expectation_or_error(
72 expr: &'tcx hir::Expr<'tcx>,
73 expected: Expectation<'tcx>,
74 mut extend_err: impl FnMut(&mut Diagnostic),
76 let expected_ty = expected.to_option(&self).unwrap_or(self.tcx.types.bool);
77 let mut ty = self.check_expr_with_expectation(expr, expected);
79 // While we don't allow *arbitrary* coercions here, we *do* allow
80 // coercions from ! to `expected`.
82 if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
83 let reported = self.tcx().sess.delay_span_bug(
85 "expression with never type wound up being adjusted",
87 return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
90 self.tcx().ty_error_with_guaranteed(reported)
94 let adj_ty = self.next_ty_var(TypeVariableOrigin {
95 kind: TypeVariableOriginKind::AdjustmentType,
98 self.apply_adjustments(
100 vec![Adjustment { kind: Adjust::NeverToAny, target: adj_ty }],
105 if let Some(mut err) = self.demand_suptype_diag(expr.span, expected_ty, ty) {
106 // FIXME(compiler-errors): We probably should fold some of the
107 // `suggest_` functions from `emit_coerce_suggestions` into here,
108 // since some of those aren't necessarily just coerce suggestions.
109 let _ = self.suggest_deref_ref_or_into(
111 expr.peel_drop_temps(),
115 ) || self.suggest_option_to_bool(&mut err, expr, ty, expected_ty);
116 extend_err(&mut err);
122 pub(super) fn check_expr_coercable_to_type(
124 expr: &'tcx hir::Expr<'tcx>,
126 expected_ty_expr: Option<&'tcx hir::Expr<'tcx>>,
128 let ty = self.check_expr_with_hint(expr, expected);
129 // checks don't need two phase
130 self.demand_coerce(expr, ty, expected, expected_ty_expr, AllowTwoPhase::No)
133 pub(super) fn check_expr_with_hint(
135 expr: &'tcx hir::Expr<'tcx>,
138 self.check_expr_with_expectation(expr, ExpectHasType(expected))
141 fn check_expr_with_expectation_and_needs(
143 expr: &'tcx hir::Expr<'tcx>,
144 expected: Expectation<'tcx>,
147 let ty = self.check_expr_with_expectation(expr, expected);
149 // If the expression is used in a place whether mutable place is required
150 // e.g. LHS of assignment, perform the conversion.
151 if let Needs::MutPlace = needs {
152 self.convert_place_derefs_to_mutable(expr);
158 pub(super) fn check_expr(&self, expr: &'tcx hir::Expr<'tcx>) -> Ty<'tcx> {
159 self.check_expr_with_expectation(expr, NoExpectation)
162 pub(super) fn check_expr_with_needs(
164 expr: &'tcx hir::Expr<'tcx>,
167 self.check_expr_with_expectation_and_needs(expr, NoExpectation, needs)
171 /// If an expression has any sub-expressions that result in a type error,
172 /// inspecting that expression's type with `ty.references_error()` will return
173 /// true. Likewise, if an expression is known to diverge, inspecting its
174 /// type with `ty::type_is_bot` will return true (n.b.: since Rust is
175 /// strict, _|_ can appear in the type of an expression that does not,
176 /// itself, diverge: for example, fn() -> _|_.)
177 /// Note that inspecting a type's structure *directly* may expose the fact
178 /// that there are actually multiple representations for `Error`, so avoid
179 /// that when err needs to be handled differently.
180 #[instrument(skip(self, expr), level = "debug")]
181 pub(super) fn check_expr_with_expectation(
183 expr: &'tcx hir::Expr<'tcx>,
184 expected: Expectation<'tcx>,
186 self.check_expr_with_expectation_and_args(expr, expected, &[])
189 /// Same as `check_expr_with_expectation`, but allows us to pass in the arguments of a
190 /// `ExprKind::Call` when evaluating its callee when it is an `ExprKind::Path`.
191 pub(super) fn check_expr_with_expectation_and_args(
193 expr: &'tcx hir::Expr<'tcx>,
194 expected: Expectation<'tcx>,
195 args: &'tcx [hir::Expr<'tcx>],
197 if self.tcx().sess.verbose() {
198 // make this code only run with -Zverbose because it is probably slow
199 if let Ok(lint_str) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
200 if !lint_str.contains('\n') {
201 debug!("expr text: {lint_str}");
203 let mut lines = lint_str.lines();
204 if let Some(line0) = lines.next() {
205 let remaining_lines = lines.count();
206 debug!("expr text: {line0}");
207 debug!("expr text: ...(and {remaining_lines} more lines)");
213 // True if `expr` is a `Try::from_ok(())` that is a result of desugaring a try block
214 // without the final expr (e.g. `try { return; }`). We don't want to generate an
215 // unreachable_code lint for it since warnings for autogenerated code are confusing.
216 let is_try_block_generated_unit_expr = match expr.kind {
217 ExprKind::Call(_, args) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {
218 args.len() == 1 && args[0].span.is_desugaring(DesugaringKind::TryBlock)
224 // Warn for expressions after diverging siblings.
225 if !is_try_block_generated_unit_expr {
226 self.warn_if_unreachable(expr.hir_id, expr.span, "expression");
229 // Hide the outer diverging and has_errors flags.
230 let old_diverges = self.diverges.replace(Diverges::Maybe);
232 let ty = ensure_sufficient_stack(|| match &expr.kind {
234 qpath @ hir::QPath::Resolved(..) | qpath @ hir::QPath::TypeRelative(..),
235 ) => self.check_expr_path(qpath, expr, args),
236 _ => self.check_expr_kind(expr, expected),
239 // Warn for non-block expressions with diverging children.
245 | ExprKind::Match(..) => {}
246 // If `expr` is a result of desugaring the try block and is an ok-wrapped
247 // diverging expression (e.g. it arose from desugaring of `try { return }`),
248 // we skip issuing a warning because it is autogenerated code.
249 ExprKind::Call(..) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {}
250 ExprKind::Call(callee, _) => self.warn_if_unreachable(expr.hir_id, callee.span, "call"),
251 ExprKind::MethodCall(segment, ..) => {
252 self.warn_if_unreachable(expr.hir_id, segment.ident.span, "call")
254 _ => self.warn_if_unreachable(expr.hir_id, expr.span, "expression"),
257 // Any expression that produces a value of type `!` must have diverged
259 self.diverges.set(self.diverges.get() | Diverges::always(expr.span));
262 // Record the type, which applies it effects.
263 // We need to do this after the warning above, so that
264 // we don't warn for the diverging expression itself.
265 self.write_ty(expr.hir_id, ty);
267 // Combine the diverging and has_error flags.
268 self.diverges.set(self.diverges.get() | old_diverges);
270 debug!("type of {} is...", self.tcx.hir().node_to_string(expr.hir_id));
271 debug!("... {:?}, expected is {:?}", ty, expected);
276 #[instrument(skip(self, expr), level = "debug")]
279 expr: &'tcx hir::Expr<'tcx>,
280 expected: Expectation<'tcx>,
282 trace!("expr={:#?}", expr);
286 ExprKind::Box(subexpr) => self.check_expr_box(subexpr, expected),
287 ExprKind::Lit(ref lit) => self.check_lit(&lit, expected),
288 ExprKind::Binary(op, lhs, rhs) => self.check_binop(expr, op, lhs, rhs, expected),
289 ExprKind::Assign(lhs, rhs, span) => {
290 self.check_expr_assign(expr, expected, lhs, rhs, span)
292 ExprKind::AssignOp(op, lhs, rhs) => {
293 self.check_binop_assign(expr, op, lhs, rhs, expected)
295 ExprKind::Unary(unop, oprnd) => self.check_expr_unary(unop, oprnd, expected, expr),
296 ExprKind::AddrOf(kind, mutbl, oprnd) => {
297 self.check_expr_addr_of(kind, mutbl, oprnd, expected, expr)
299 ExprKind::Path(QPath::LangItem(lang_item, _, hir_id)) => {
300 self.check_lang_item_path(lang_item, expr, hir_id)
302 ExprKind::Path(ref qpath) => self.check_expr_path(qpath, expr, &[]),
303 ExprKind::InlineAsm(asm) => {
304 // We defer some asm checks as we may not have resolved the input and output types yet (they may still be infer vars).
305 self.deferred_asm_checks.borrow_mut().push((asm, expr.hir_id));
306 self.check_expr_asm(asm)
308 ExprKind::Break(destination, ref expr_opt) => {
309 self.check_expr_break(destination, expr_opt.as_deref(), expr)
311 ExprKind::Continue(destination) => {
312 if destination.target_id.is_ok() {
315 // There was an error; make type-check fail.
319 ExprKind::Ret(ref expr_opt) => self.check_expr_return(expr_opt.as_deref(), expr),
320 ExprKind::Let(let_expr) => self.check_expr_let(let_expr),
321 ExprKind::Loop(body, _, source, _) => {
322 self.check_expr_loop(body, source, expected, expr)
324 ExprKind::Match(discrim, arms, match_src) => {
325 self.check_match(expr, &discrim, arms, expected, match_src)
327 ExprKind::Closure(closure) => self.check_expr_closure(closure, expr.span, expected),
328 ExprKind::Block(body, _) => self.check_block_with_expected(&body, expected),
329 ExprKind::Call(callee, args) => self.check_call(expr, &callee, args, expected),
330 ExprKind::MethodCall(segment, receiver, args, _) => {
331 self.check_method_call(expr, segment, receiver, args, expected)
333 ExprKind::Cast(e, t) => self.check_expr_cast(e, t, expr),
334 ExprKind::Type(e, t) => {
335 let ty = self.to_ty_saving_user_provided_ty(&t);
336 self.check_expr_eq_type(&e, ty);
339 ExprKind::If(cond, then_expr, opt_else_expr) => {
340 self.check_then_else(cond, then_expr, opt_else_expr, expr.span, expected)
342 ExprKind::DropTemps(e) => self.check_expr_with_expectation(e, expected),
343 ExprKind::Array(args) => self.check_expr_array(args, expected, expr),
344 ExprKind::ConstBlock(ref anon_const) => {
345 self.check_expr_const_block(anon_const, expected, expr)
347 ExprKind::Repeat(element, ref count) => {
348 self.check_expr_repeat(element, count, expected, expr)
350 ExprKind::Tup(elts) => self.check_expr_tuple(elts, expected, expr),
351 ExprKind::Struct(qpath, fields, ref base_expr) => {
352 self.check_expr_struct(expr, expected, qpath, fields, base_expr)
354 ExprKind::Field(base, field) => self.check_field(expr, &base, field),
355 ExprKind::Index(base, idx) => self.check_expr_index(base, idx, expr),
356 ExprKind::Yield(value, ref src) => self.check_expr_yield(value, expr, src),
357 hir::ExprKind::Err => tcx.ty_error(),
361 fn check_expr_box(&self, expr: &'tcx hir::Expr<'tcx>, expected: Expectation<'tcx>) -> Ty<'tcx> {
362 let expected_inner = expected.to_option(self).map_or(NoExpectation, |ty| match ty.kind() {
363 ty::Adt(def, _) if def.is_box() => Expectation::rvalue_hint(self, ty.boxed_ty()),
366 let referent_ty = self.check_expr_with_expectation(expr, expected_inner);
367 self.require_type_is_sized(referent_ty, expr.span, traits::SizedBoxType);
368 self.tcx.mk_box(referent_ty)
374 oprnd: &'tcx hir::Expr<'tcx>,
375 expected: Expectation<'tcx>,
376 expr: &'tcx hir::Expr<'tcx>,
379 let expected_inner = match unop {
380 hir::UnOp::Not | hir::UnOp::Neg => expected,
381 hir::UnOp::Deref => NoExpectation,
383 let mut oprnd_t = self.check_expr_with_expectation(&oprnd, expected_inner);
385 if !oprnd_t.references_error() {
386 oprnd_t = self.structurally_resolved_type(expr.span, oprnd_t);
388 hir::UnOp::Deref => {
389 if let Some(ty) = self.lookup_derefing(expr, oprnd, oprnd_t) {
392 let mut err = type_error_struct!(
397 "type `{oprnd_t}` cannot be dereferenced",
399 let sp = tcx.sess.source_map().start_point(expr.span);
401 tcx.sess.parse_sess.ambiguous_block_expr_parse.borrow().get(&sp)
403 err.subdiagnostic(ExprParenthesesNeeded::surrounding(*sp));
405 oprnd_t = tcx.ty_error_with_guaranteed(err.emit());
409 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
410 // If it's builtin, we can reuse the type, this helps inference.
411 if !(oprnd_t.is_integral() || *oprnd_t.kind() == ty::Bool) {
416 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
417 // If it's builtin, we can reuse the type, this helps inference.
418 if !oprnd_t.is_numeric() {
427 fn check_expr_addr_of(
429 kind: hir::BorrowKind,
430 mutbl: hir::Mutability,
431 oprnd: &'tcx hir::Expr<'tcx>,
432 expected: Expectation<'tcx>,
433 expr: &'tcx hir::Expr<'tcx>,
435 let hint = expected.only_has_type(self).map_or(NoExpectation, |ty| {
437 ty::Ref(_, ty, _) | ty::RawPtr(ty::TypeAndMut { ty, .. }) => {
438 if oprnd.is_syntactic_place_expr() {
439 // Places may legitimately have unsized types.
440 // For example, dereferences of a fat pointer and
441 // the last field of a struct can be unsized.
444 Expectation::rvalue_hint(self, *ty)
451 self.check_expr_with_expectation_and_needs(&oprnd, hint, Needs::maybe_mut_place(mutbl));
453 let tm = ty::TypeAndMut { ty, mutbl };
455 _ if tm.ty.references_error() => self.tcx.ty_error(),
456 hir::BorrowKind::Raw => {
457 self.check_named_place_expr(oprnd);
460 hir::BorrowKind::Ref => {
461 // Note: at this point, we cannot say what the best lifetime
462 // is to use for resulting pointer. We want to use the
463 // shortest lifetime possible so as to avoid spurious borrowck
464 // errors. Moreover, the longest lifetime will depend on the
465 // precise details of the value whose address is being taken
466 // (and how long it is valid), which we don't know yet until
467 // type inference is complete.
469 // Therefore, here we simply generate a region variable. The
470 // region inferencer will then select a suitable value.
471 // Finally, borrowck will infer the value of the region again,
472 // this time with enough precision to check that the value
473 // whose address was taken can actually be made to live as long
474 // as it needs to live.
475 let region = self.next_region_var(infer::AddrOfRegion(expr.span));
476 self.tcx.mk_ref(region, tm)
481 /// Does this expression refer to a place that either:
482 /// * Is based on a local or static.
483 /// * Contains a dereference
484 /// Note that the adjustments for the children of `expr` should already
485 /// have been resolved.
486 fn check_named_place_expr(&self, oprnd: &'tcx hir::Expr<'tcx>) {
487 let is_named = oprnd.is_place_expr(|base| {
488 // Allow raw borrows if there are any deref adjustments.
490 // const VAL: (i32,) = (0,);
491 // const REF: &(i32,) = &(0,);
493 // &raw const VAL.0; // ERROR
494 // &raw const REF.0; // OK, same as &raw const (*REF).0;
496 // This is maybe too permissive, since it allows
497 // `let u = &raw const Box::new((1,)).0`, which creates an
498 // immediately dangling raw pointer.
503 .map_or(false, |x| x.iter().any(|adj| matches!(adj.kind, Adjust::Deref(_))))
506 self.tcx.sess.emit_err(AddressOfTemporaryTaken { span: oprnd.span });
510 fn check_lang_item_path(
512 lang_item: hir::LangItem,
513 expr: &'tcx hir::Expr<'tcx>,
514 hir_id: Option<hir::HirId>,
516 self.resolve_lang_item_path(lang_item, expr.span, expr.hir_id, hir_id).1
519 pub(crate) fn check_expr_path(
521 qpath: &'tcx hir::QPath<'tcx>,
522 expr: &'tcx hir::Expr<'tcx>,
523 args: &'tcx [hir::Expr<'tcx>],
526 let (res, opt_ty, segs) =
527 self.resolve_ty_and_res_fully_qualified_call(qpath, expr.hir_id, expr.span);
530 self.set_tainted_by_errors();
533 Res::Def(DefKind::Ctor(_, CtorKind::Fictive), _) => {
534 report_unexpected_variant_res(tcx, res, qpath, expr.span);
537 _ => self.instantiate_value_path(segs, opt_ty, res, expr.span, expr.hir_id).0,
540 if let ty::FnDef(did, ..) = *ty.kind() {
541 let fn_sig = ty.fn_sig(tcx);
542 if tcx.fn_sig(did).abi() == RustIntrinsic && tcx.item_name(did) == sym::transmute {
543 let from = fn_sig.inputs().skip_binder()[0];
544 let to = fn_sig.output().skip_binder();
545 // We defer the transmute to the end of typeck, once all inference vars have
546 // been resolved or we errored. This is important as we can only check transmute
547 // on concrete types, but the output type may not be known yet (it would only
548 // be known if explicitly specified via turbofish).
549 self.deferred_transmute_checks.borrow_mut().push((from, to, expr.hir_id));
551 if !tcx.features().unsized_fn_params {
552 // We want to remove some Sized bounds from std functions,
553 // but don't want to expose the removal to stable Rust.
554 // i.e., we don't want to allow
560 // to work in stable even if the Sized bound on `drop` is relaxed.
561 for i in 0..fn_sig.inputs().skip_binder().len() {
562 // We just want to check sizedness, so instead of introducing
563 // placeholder lifetimes with probing, we just replace higher lifetimes
565 let span = args.get(i).map(|a| a.span).unwrap_or(expr.span);
566 let input = self.replace_bound_vars_with_fresh_vars(
568 infer::LateBoundRegionConversionTime::FnCall,
571 self.require_type_is_sized_deferred(
574 traits::SizedArgumentType(None),
578 // Here we want to prevent struct constructors from returning unsized types.
579 // There were two cases this happened: fn pointer coercion in stable
580 // and usual function call in presence of unsized_locals.
581 // Also, as we just want to check sizedness, instead of introducing
582 // placeholder lifetimes with probing, we just replace higher lifetimes
584 let output = self.replace_bound_vars_with_fresh_vars(
586 infer::LateBoundRegionConversionTime::FnCall,
589 self.require_type_is_sized_deferred(output, expr.span, traits::SizedReturnType);
592 // We always require that the type provided as the value for
593 // a type parameter outlives the moment of instantiation.
594 let substs = self.typeck_results.borrow().node_substs(expr.hir_id);
595 self.add_wf_bounds(substs, expr);
602 destination: hir::Destination,
603 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
604 expr: &'tcx hir::Expr<'tcx>,
607 if let Ok(target_id) = destination.target_id {
609 if let Some(e) = expr_opt {
610 // If this is a break with a value, we need to type-check
611 // the expression. Get an expected type from the loop context.
612 let opt_coerce_to = {
613 // We should release `enclosing_breakables` before the `check_expr_with_hint`
614 // below, so can't move this block of code to the enclosing scope and share
615 // `ctxt` with the second `enclosing_breakables` borrow below.
616 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
617 match enclosing_breakables.opt_find_breakable(target_id) {
618 Some(ctxt) => ctxt.coerce.as_ref().map(|coerce| coerce.expected_ty()),
620 // Avoid ICE when `break` is inside a closure (#65383).
621 return tcx.ty_error_with_message(
623 "break was outside loop, but no error was emitted",
629 // If the loop context is not a `loop { }`, then break with
630 // a value is illegal, and `opt_coerce_to` will be `None`.
631 // Just set expectation to error in that case.
632 let coerce_to = opt_coerce_to.unwrap_or_else(|| tcx.ty_error());
634 // Recurse without `enclosing_breakables` borrowed.
635 e_ty = self.check_expr_with_hint(e, coerce_to);
636 cause = self.misc(e.span);
638 // Otherwise, this is a break *without* a value. That's
639 // always legal, and is equivalent to `break ()`.
640 e_ty = tcx.mk_unit();
641 cause = self.misc(expr.span);
644 // Now that we have type-checked `expr_opt`, borrow
645 // the `enclosing_loops` field and let's coerce the
646 // type of `expr_opt` into what is expected.
647 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
648 let Some(ctxt) = enclosing_breakables.opt_find_breakable(target_id) else {
649 // Avoid ICE when `break` is inside a closure (#65383).
650 return tcx.ty_error_with_message(
652 "break was outside loop, but no error was emitted",
656 if let Some(ref mut coerce) = ctxt.coerce {
657 if let Some(ref e) = expr_opt {
658 coerce.coerce(self, &cause, e, e_ty);
660 assert!(e_ty.is_unit());
661 let ty = coerce.expected_ty();
662 coerce.coerce_forced_unit(
666 self.suggest_mismatched_types_on_tail(
667 &mut err, expr, ty, e_ty, target_id,
669 if let Some(val) = ty_kind_suggestion(ty) {
670 let label = destination
672 .map(|l| format!(" {}", l.ident))
673 .unwrap_or_else(String::new);
676 "give it a value of the expected type",
677 format!("break{label} {val}"),
678 Applicability::HasPlaceholders,
686 // If `ctxt.coerce` is `None`, we can just ignore
687 // the type of the expression. This is because
688 // either this was a break *without* a value, in
689 // which case it is always a legal type (`()`), or
690 // else an error would have been flagged by the
691 // `loops` pass for using break with an expression
692 // where you are not supposed to.
693 assert!(expr_opt.is_none() || self.tcx.sess.has_errors().is_some());
696 // If we encountered a `break`, then (no surprise) it may be possible to break from the
697 // loop... unless the value being returned from the loop diverges itself, e.g.
698 // `break return 5` or `break loop {}`.
699 ctxt.may_break |= !self.diverges.get().is_always();
701 // the type of a `break` is always `!`, since it diverges
704 // Otherwise, we failed to find the enclosing loop;
705 // this can only happen if the `break` was not
706 // inside a loop at all, which is caught by the
707 // loop-checking pass.
708 let err = self.tcx.ty_error_with_message(
710 "break was outside loop, but no error was emitted",
713 // We still need to assign a type to the inner expression to
714 // prevent the ICE in #43162.
715 if let Some(e) = expr_opt {
716 self.check_expr_with_hint(e, err);
718 // ... except when we try to 'break rust;'.
719 // ICE this expression in particular (see #43162).
720 if let ExprKind::Path(QPath::Resolved(_, path)) = e.kind {
721 if path.segments.len() == 1 && path.segments[0].ident.name == sym::rust {
722 fatally_break_rust(self.tcx.sess);
727 // There was an error; make type-check fail.
732 fn check_expr_return(
734 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
735 expr: &'tcx hir::Expr<'tcx>,
737 if self.ret_coercion.is_none() {
738 let mut err = ReturnStmtOutsideOfFnBody {
740 encl_body_span: None,
744 let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
746 if let Some(hir::Node::Item(hir::Item {
747 kind: hir::ItemKind::Fn(..),
751 | Some(hir::Node::TraitItem(hir::TraitItem {
752 kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),
756 | Some(hir::Node::ImplItem(hir::ImplItem {
757 kind: hir::ImplItemKind::Fn(..),
760 })) = self.tcx.hir().find_by_def_id(encl_item_id.def_id)
762 // We are inside a function body, so reporting "return statement
763 // outside of function body" needs an explanation.
765 let encl_body_owner_id = self.tcx.hir().enclosing_body_owner(expr.hir_id);
767 // If this didn't hold, we would not have to report an error in
769 assert_ne!(encl_item_id.def_id, encl_body_owner_id);
771 let encl_body_id = self.tcx.hir().body_owned_by(encl_body_owner_id);
772 let encl_body = self.tcx.hir().body(encl_body_id);
774 err.encl_body_span = Some(encl_body.value.span);
775 err.encl_fn_span = Some(*encl_fn_span);
778 self.tcx.sess.emit_err(err);
780 if let Some(e) = expr_opt {
781 // We still have to type-check `e` (issue #86188), but calling
782 // `check_return_expr` only works inside fn bodies.
785 } else if let Some(e) = expr_opt {
786 if self.ret_coercion_span.get().is_none() {
787 self.ret_coercion_span.set(Some(e.span));
789 self.check_return_expr(e, true);
791 let mut coercion = self.ret_coercion.as_ref().unwrap().borrow_mut();
792 if self.ret_coercion_span.get().is_none() {
793 self.ret_coercion_span.set(Some(expr.span));
795 let cause = self.cause(expr.span, ObligationCauseCode::ReturnNoExpression);
796 if let Some((fn_decl, _)) = self.get_fn_decl(expr.hir_id) {
797 coercion.coerce_forced_unit(
801 let span = fn_decl.output.span();
802 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
805 format!("expected `{snippet}` because of this return type"),
812 coercion.coerce_forced_unit(self, &cause, &mut |_| (), true);
818 /// `explicit_return` is `true` if we're checking an explicit `return expr`,
819 /// and `false` if we're checking a trailing expression.
820 pub(super) fn check_return_expr(
822 return_expr: &'tcx hir::Expr<'tcx>,
823 explicit_return: bool,
825 let ret_coercion = self.ret_coercion.as_ref().unwrap_or_else(|| {
826 span_bug!(return_expr.span, "check_return_expr called outside fn body")
829 let ret_ty = ret_coercion.borrow().expected_ty();
830 let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty);
831 let mut span = return_expr.span;
832 // Use the span of the trailing expression for our cause,
833 // not the span of the entire function
834 if !explicit_return {
835 if let ExprKind::Block(body, _) = return_expr.kind && let Some(last_expr) = body.expr {
836 span = last_expr.span;
839 ret_coercion.borrow_mut().coerce(
841 &self.cause(span, ObligationCauseCode::ReturnValue(return_expr.hir_id)),
846 if let Some(fn_sig) = self.body_fn_sig()
847 && fn_sig.output().has_opaque_types()
849 // Point any obligations that were registered due to opaque type
850 // inference at the return expression.
851 self.select_obligations_where_possible(|errors| {
852 self.point_at_return_for_opaque_ty_error(errors, span, return_expr_ty);
857 fn point_at_return_for_opaque_ty_error(
859 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
861 return_expr_ty: Ty<'tcx>,
863 // Don't point at the whole block if it's empty
864 if span == self.tcx.hir().span(self.body_id) {
868 let cause = &mut err.obligation.cause;
869 if let ObligationCauseCode::OpaqueReturnType(None) = cause.code() {
870 let new_cause = ObligationCause::new(
873 ObligationCauseCode::OpaqueReturnType(Some((return_expr_ty, span))),
880 pub(crate) fn check_lhs_assignable(
882 lhs: &'tcx hir::Expr<'tcx>,
883 err_code: &'static str,
885 adjust_err: impl FnOnce(&mut Diagnostic),
887 if lhs.is_syntactic_place_expr() {
891 // FIXME: Make this use Diagnostic once error codes can be dynamically set.
892 let mut err = self.tcx.sess.struct_span_err_with_code(
894 "invalid left-hand side of assignment",
895 DiagnosticId::Error(err_code.into()),
897 err.span_label(lhs.span, "cannot assign to this expression");
899 self.comes_from_while_condition(lhs.hir_id, |expr| {
900 err.span_suggestion_verbose(
901 expr.span.shrink_to_lo(),
902 "you might have meant to use pattern destructuring",
904 Applicability::MachineApplicable,
908 adjust_err(&mut err);
913 // Check if an expression `original_expr_id` comes from the condition of a while loop,
914 // as opposed from the body of a while loop, which we can naively check by iterating
915 // parents until we find a loop...
916 pub(super) fn comes_from_while_condition(
918 original_expr_id: HirId,
919 then: impl FnOnce(&hir::Expr<'_>),
921 let mut parent = self.tcx.hir().get_parent_node(original_expr_id);
922 while let Some(node) = self.tcx.hir().find(parent) {
924 hir::Node::Expr(hir::Expr {
931 hir::ExprKind::Match(expr, ..) | hir::ExprKind::If(expr, ..),
937 hir::LoopSource::While,
942 // Check if our original expression is a child of the condition of a while loop
943 let expr_is_ancestor = std::iter::successors(Some(original_expr_id), |id| {
944 self.tcx.hir().find_parent_node(*id)
946 .take_while(|id| *id != parent)
947 .any(|id| id == expr.hir_id);
948 // if it is, then we have a situation like `while Some(0) = value.get(0) {`,
949 // where `while let` was more likely intended.
950 if expr_is_ancestor {
956 | hir::Node::ImplItem(_)
957 | hir::Node::TraitItem(_)
958 | hir::Node::Crate(_) => break,
960 parent = self.tcx.hir().get_parent_node(parent);
966 // A generic function for checking the 'then' and 'else' clauses in an 'if'
967 // or 'if-else' expression.
970 cond_expr: &'tcx hir::Expr<'tcx>,
971 then_expr: &'tcx hir::Expr<'tcx>,
972 opt_else_expr: Option<&'tcx hir::Expr<'tcx>>,
974 orig_expected: Expectation<'tcx>,
976 let cond_ty = self.check_expr_has_type_or_error(cond_expr, self.tcx.types.bool, |_| {});
978 self.warn_if_unreachable(
981 "block in `if` or `while` expression",
984 let cond_diverges = self.diverges.get();
985 self.diverges.set(Diverges::Maybe);
987 let expected = orig_expected.adjust_for_branches(self);
988 let then_ty = self.check_expr_with_expectation(then_expr, expected);
989 let then_diverges = self.diverges.get();
990 self.diverges.set(Diverges::Maybe);
992 // We've already taken the expected type's preferences
993 // into account when typing the `then` branch. To figure
994 // out the initial shot at a LUB, we thus only consider
995 // `expected` if it represents a *hard* constraint
996 // (`only_has_type`); otherwise, we just go with a
997 // fresh type variable.
998 let coerce_to_ty = expected.coercion_target_type(self, sp);
999 let mut coerce: DynamicCoerceMany<'_> = CoerceMany::new(coerce_to_ty);
1001 coerce.coerce(self, &self.misc(sp), then_expr, then_ty);
1003 if let Some(else_expr) = opt_else_expr {
1004 let else_ty = self.check_expr_with_expectation(else_expr, expected);
1005 let else_diverges = self.diverges.get();
1007 let opt_suggest_box_span = self.opt_suggest_box_span(then_ty, else_ty, orig_expected);
1008 let if_cause = self.if_cause(
1015 opt_suggest_box_span,
1018 coerce.coerce(self, &if_cause, else_expr, else_ty);
1020 // We won't diverge unless both branches do (or the condition does).
1021 self.diverges.set(cond_diverges | then_diverges & else_diverges);
1023 self.if_fallback_coercion(sp, then_expr, &mut coerce);
1025 // If the condition is false we can't diverge.
1026 self.diverges.set(cond_diverges);
1029 let result_ty = coerce.complete(self);
1030 if cond_ty.references_error() { self.tcx.ty_error() } else { result_ty }
1033 /// Type check assignment expression `expr` of form `lhs = rhs`.
1034 /// The expected type is `()` and is passed to the function for the purposes of diagnostics.
1035 fn check_expr_assign(
1037 expr: &'tcx hir::Expr<'tcx>,
1038 expected: Expectation<'tcx>,
1039 lhs: &'tcx hir::Expr<'tcx>,
1040 rhs: &'tcx hir::Expr<'tcx>,
1043 let expected_ty = expected.coercion_target_type(self, expr.span);
1044 if expected_ty == self.tcx.types.bool {
1045 // The expected type is `bool` but this will result in `()` so we can reasonably
1046 // say that the user intended to write `lhs == rhs` instead of `lhs = rhs`.
1047 // The likely cause of this is `if foo = bar { .. }`.
1048 let actual_ty = self.tcx.mk_unit();
1049 let mut err = self.demand_suptype_diag(expr.span, expected_ty, actual_ty).unwrap();
1050 let lhs_ty = self.check_expr(&lhs);
1051 let rhs_ty = self.check_expr(&rhs);
1052 let (applicability, eq) = if self.can_coerce(rhs_ty, lhs_ty) {
1053 (Applicability::MachineApplicable, true)
1054 } else if let ExprKind::Binary(
1055 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1060 // if x == 1 && y == 2 { .. }
1062 let actual_lhs_ty = self.check_expr(&rhs_expr);
1063 (Applicability::MaybeIncorrect, self.can_coerce(rhs_ty, actual_lhs_ty))
1064 } else if let ExprKind::Binary(
1065 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1070 // if x == 1 && y == 2 { .. }
1072 let actual_rhs_ty = self.check_expr(&lhs_expr);
1073 (Applicability::MaybeIncorrect, self.can_coerce(actual_rhs_ty, lhs_ty))
1075 (Applicability::MaybeIncorrect, false)
1077 if !lhs.is_syntactic_place_expr()
1078 && lhs.is_approximately_pattern()
1079 && !matches!(lhs.kind, hir::ExprKind::Lit(_))
1081 // Do not suggest `if let x = y` as `==` is way more likely to be the intention.
1082 let hir = self.tcx.hir();
1083 if let hir::Node::Expr(hir::Expr { kind: ExprKind::If { .. }, .. }) =
1084 hir.get(hir.get_parent_node(hir.get_parent_node(expr.hir_id)))
1086 err.span_suggestion_verbose(
1087 expr.span.shrink_to_lo(),
1088 "you might have meant to use pattern matching",
1095 err.span_suggestion_verbose(
1096 span.shrink_to_hi(),
1097 "you might have meant to compare for equality",
1103 // If the assignment expression itself is ill-formed, don't
1104 // bother emitting another error
1105 let reported = err.emit_unless(lhs_ty.references_error() || rhs_ty.references_error());
1106 return self.tcx.ty_error_with_guaranteed(reported);
1109 let lhs_ty = self.check_expr_with_needs(&lhs, Needs::MutPlace);
1111 let suggest_deref_binop = |err: &mut Diagnostic, rhs_ty: Ty<'tcx>| {
1112 if let Some(lhs_deref_ty) = self.deref_once_mutably_for_diagnostic(lhs_ty) {
1113 // Can only assign if the type is sized, so if `DerefMut` yields a type that is
1114 // unsized, do not suggest dereferencing it.
1115 let lhs_deref_ty_is_sized = self
1117 .type_implements_trait(
1118 self.tcx.lang_items().sized_trait().unwrap(),
1124 if lhs_deref_ty_is_sized && self.can_coerce(rhs_ty, lhs_deref_ty) {
1125 err.span_suggestion_verbose(
1126 lhs.span.shrink_to_lo(),
1127 "consider dereferencing here to assign to the mutably borrowed value",
1129 Applicability::MachineApplicable,
1135 // This is (basically) inlined `check_expr_coercable_to_type`, but we want
1136 // to suggest an additional fixup here in `suggest_deref_binop`.
1137 let rhs_ty = self.check_expr_with_hint(&rhs, lhs_ty);
1138 if let (_, Some(mut diag)) =
1139 self.demand_coerce_diag(rhs, rhs_ty, lhs_ty, Some(lhs), AllowTwoPhase::No)
1141 suggest_deref_binop(&mut diag, rhs_ty);
1145 self.check_lhs_assignable(lhs, "E0070", span, |err| {
1146 if let Some(rhs_ty) = self.typeck_results.borrow().expr_ty_opt(rhs) {
1147 suggest_deref_binop(err, rhs_ty);
1151 self.require_type_is_sized(lhs_ty, lhs.span, traits::AssignmentLhsSized);
1153 if lhs_ty.references_error() || rhs_ty.references_error() {
1160 pub(super) fn check_expr_let(&self, let_expr: &'tcx hir::Let<'tcx>) -> Ty<'tcx> {
1161 // for let statements, this is done in check_stmt
1162 let init = let_expr.init;
1163 self.warn_if_unreachable(init.hir_id, init.span, "block in `let` expression");
1164 // otherwise check exactly as a let statement
1165 self.check_decl(let_expr.into());
1166 // but return a bool, for this is a boolean expression
1172 body: &'tcx hir::Block<'tcx>,
1173 source: hir::LoopSource,
1174 expected: Expectation<'tcx>,
1175 expr: &'tcx hir::Expr<'tcx>,
1177 let coerce = match source {
1178 // you can only use break with a value from a normal `loop { }`
1179 hir::LoopSource::Loop => {
1180 let coerce_to = expected.coercion_target_type(self, body.span);
1181 Some(CoerceMany::new(coerce_to))
1184 hir::LoopSource::While | hir::LoopSource::ForLoop => None,
1187 let ctxt = BreakableCtxt {
1189 may_break: false, // Will get updated if/when we find a `break`.
1192 let (ctxt, ()) = self.with_breakable_ctxt(expr.hir_id, ctxt, || {
1193 self.check_block_no_value(&body);
1197 // No way to know whether it's diverging because
1198 // of a `break` or an outer `break` or `return`.
1199 self.diverges.set(Diverges::Maybe);
1202 // If we permit break with a value, then result type is
1203 // the LUB of the breaks (possibly ! if none); else, it
1204 // is nil. This makes sense because infinite loops
1205 // (which would have type !) are only possible iff we
1206 // permit break with a value [1].
1207 if ctxt.coerce.is_none() && !ctxt.may_break {
1209 self.tcx.sess.delay_span_bug(body.span, "no coercion, but loop may not break");
1211 ctxt.coerce.map(|c| c.complete(self)).unwrap_or_else(|| self.tcx.mk_unit())
1214 /// Checks a method call.
1215 fn check_method_call(
1217 expr: &'tcx hir::Expr<'tcx>,
1218 segment: &hir::PathSegment<'_>,
1219 rcvr: &'tcx hir::Expr<'tcx>,
1220 args: &'tcx [hir::Expr<'tcx>],
1221 expected: Expectation<'tcx>,
1223 let rcvr_t = self.check_expr(&rcvr);
1224 // no need to check for bot/err -- callee does that
1225 let rcvr_t = self.structurally_resolved_type(rcvr.span, rcvr_t);
1226 let span = segment.ident.span;
1228 let method = match self.lookup_method(rcvr_t, segment, span, expr, rcvr, args) {
1230 // We could add a "consider `foo::<params>`" suggestion here, but I wasn't able to
1231 // trigger this codepath causing `structurally_resolved_type` to emit an error.
1233 self.write_method_call(expr.hir_id, method);
1237 if segment.ident.name != kw::Empty {
1238 if let Some(mut err) = self.report_method_error(
1242 SelfSource::MethodCall(rcvr),
1253 // Call the generic checker.
1254 self.check_method_argument_types(span, expr, method, &args, DontTupleArguments, expected)
1259 e: &'tcx hir::Expr<'tcx>,
1260 t: &'tcx hir::Ty<'tcx>,
1261 expr: &'tcx hir::Expr<'tcx>,
1263 // Find the type of `e`. Supply hints based on the type we are casting to,
1265 let t_cast = self.to_ty_saving_user_provided_ty(t);
1266 let t_cast = self.resolve_vars_if_possible(t_cast);
1267 let t_expr = self.check_expr_with_expectation(e, ExpectCastableToType(t_cast));
1268 let t_expr = self.resolve_vars_if_possible(t_expr);
1270 // Eagerly check for some obvious errors.
1271 if t_expr.references_error() || t_cast.references_error() {
1274 // Defer other checks until we're done type checking.
1275 let mut deferred_cast_checks = self.deferred_cast_checks.borrow_mut();
1276 match cast::CastCheck::new(
1283 self.param_env.constness(),
1287 "check_expr_cast: deferring cast from {:?} to {:?}: {:?}",
1288 t_cast, t_expr, cast_check,
1290 deferred_cast_checks.push(cast_check);
1293 Err(_) => self.tcx.ty_error(),
1298 fn check_expr_array(
1300 args: &'tcx [hir::Expr<'tcx>],
1301 expected: Expectation<'tcx>,
1302 expr: &'tcx hir::Expr<'tcx>,
1304 let element_ty = if !args.is_empty() {
1305 let coerce_to = expected
1307 .and_then(|uty| match *uty.kind() {
1308 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1311 .unwrap_or_else(|| {
1312 self.next_ty_var(TypeVariableOrigin {
1313 kind: TypeVariableOriginKind::TypeInference,
1317 let mut coerce = CoerceMany::with_coercion_sites(coerce_to, args);
1318 assert_eq!(self.diverges.get(), Diverges::Maybe);
1320 let e_ty = self.check_expr_with_hint(e, coerce_to);
1321 let cause = self.misc(e.span);
1322 coerce.coerce(self, &cause, e, e_ty);
1324 coerce.complete(self)
1326 self.next_ty_var(TypeVariableOrigin {
1327 kind: TypeVariableOriginKind::TypeInference,
1331 let array_len = args.len() as u64;
1332 self.suggest_array_len(expr, array_len);
1333 self.tcx.mk_array(element_ty, array_len)
1336 fn suggest_array_len(&self, expr: &'tcx hir::Expr<'tcx>, array_len: u64) {
1337 let parent_node = self.tcx.hir().parent_iter(expr.hir_id).find(|(_, node)| {
1338 !matches!(node, hir::Node::Expr(hir::Expr { kind: hir::ExprKind::AddrOf(..), .. }))
1341 hir::Node::Local(hir::Local { ty: Some(ty), .. })
1342 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Const(ty, _), .. }))
1343 ) = parent_node else {
1346 if let hir::TyKind::Array(_, length) = ty.peel_refs().kind
1347 && let hir::ArrayLen::Body(hir::AnonConst { hir_id, .. }) = length
1348 && let Some(span) = self.tcx.hir().opt_span(hir_id)
1350 match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
1352 err.span_suggestion(
1354 "consider specifying the array length",
1356 Applicability::MaybeIncorrect,
1365 fn check_expr_const_block(
1367 anon_const: &'tcx hir::AnonConst,
1368 expected: Expectation<'tcx>,
1369 _expr: &'tcx hir::Expr<'tcx>,
1371 let body = self.tcx.hir().body(anon_const.body);
1373 // Create a new function context.
1374 let fcx = FnCtxt::new(self, self.param_env.with_const(), body.value.hir_id);
1375 crate::GatherLocalsVisitor::new(&fcx).visit_body(body);
1377 let ty = fcx.check_expr_with_expectation(&body.value, expected);
1378 fcx.require_type_is_sized(ty, body.value.span, traits::ConstSized);
1379 fcx.write_ty(anon_const.hir_id, ty);
1383 fn check_expr_repeat(
1385 element: &'tcx hir::Expr<'tcx>,
1386 count: &'tcx hir::ArrayLen,
1387 expected: Expectation<'tcx>,
1388 expr: &'tcx hir::Expr<'tcx>,
1391 let count = self.array_length_to_const(count);
1392 if let Some(count) = count.try_eval_usize(tcx, self.param_env) {
1393 self.suggest_array_len(expr, count);
1396 let uty = match expected {
1397 ExpectHasType(uty) => match *uty.kind() {
1398 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1404 let (element_ty, t) = match uty {
1406 self.check_expr_coercable_to_type(&element, uty, None);
1410 let ty = self.next_ty_var(TypeVariableOrigin {
1411 kind: TypeVariableOriginKind::MiscVariable,
1414 let element_ty = self.check_expr_has_type_or_error(&element, ty, |_| {});
1419 if element_ty.references_error() {
1420 return tcx.ty_error();
1423 self.check_repeat_element_needs_copy_bound(element, count, element_ty);
1425 tcx.mk_ty(ty::Array(t, count))
1428 fn check_repeat_element_needs_copy_bound(
1430 element: &hir::Expr<'_>,
1431 count: ty::Const<'tcx>,
1432 element_ty: Ty<'tcx>,
1435 // Actual constants as the repeat element get inserted repeatedly instead of getting copied via Copy.
1436 match &element.kind {
1437 hir::ExprKind::ConstBlock(..) => return,
1438 hir::ExprKind::Path(qpath) => {
1439 let res = self.typeck_results.borrow().qpath_res(qpath, element.hir_id);
1440 if let Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::AnonConst, _) = res
1447 // If someone calls a const fn, they can extract that call out into a separate constant (or a const
1448 // block in the future), so we check that to tell them that in the diagnostic. Does not affect typeck.
1449 let is_const_fn = match element.kind {
1450 hir::ExprKind::Call(func, _args) => match *self.node_ty(func.hir_id).kind() {
1451 ty::FnDef(def_id, _) => tcx.is_const_fn(def_id),
1457 // If the length is 0, we don't create any elements, so we don't copy any. If the length is 1, we
1458 // don't copy that one element, we move it. Only check for Copy if the length is larger.
1459 if count.try_eval_usize(tcx, self.param_env).map_or(true, |len| len > 1) {
1460 let lang_item = self.tcx.require_lang_item(LangItem::Copy, None);
1461 let code = traits::ObligationCauseCode::RepeatElementCopy { is_const_fn };
1462 self.require_type_meets(element_ty, element.span, code, lang_item);
1466 fn check_expr_tuple(
1468 elts: &'tcx [hir::Expr<'tcx>],
1469 expected: Expectation<'tcx>,
1470 expr: &'tcx hir::Expr<'tcx>,
1472 let flds = expected.only_has_type(self).and_then(|ty| {
1473 let ty = self.resolve_vars_with_obligations(ty);
1475 ty::Tuple(flds) => Some(&flds[..]),
1480 let elt_ts_iter = elts.iter().enumerate().map(|(i, e)| match flds {
1481 Some(fs) if i < fs.len() => {
1483 self.check_expr_coercable_to_type(&e, ety, None);
1486 _ => self.check_expr_with_expectation(&e, NoExpectation),
1488 let tuple = self.tcx.mk_tup(elt_ts_iter);
1489 if tuple.references_error() {
1492 self.require_type_is_sized(tuple, expr.span, traits::TupleInitializerSized);
1497 fn check_expr_struct(
1499 expr: &hir::Expr<'_>,
1500 expected: Expectation<'tcx>,
1502 fields: &'tcx [hir::ExprField<'tcx>],
1503 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1505 // Find the relevant variant
1506 let Some((variant, adt_ty)) = self.check_struct_path(qpath, expr.hir_id) else {
1507 self.check_struct_fields_on_error(fields, base_expr);
1508 return self.tcx.ty_error();
1511 // Prohibit struct expressions when non-exhaustive flag is set.
1512 let adt = adt_ty.ty_adt_def().expect("`check_struct_path` returned non-ADT type");
1513 if !adt.did().is_local() && variant.is_field_list_non_exhaustive() {
1516 .emit_err(StructExprNonExhaustive { span: expr.span, what: adt.variant_descr() });
1519 self.check_expr_struct_fields(
1530 self.require_type_is_sized(adt_ty, expr.span, traits::StructInitializerSized);
1534 fn check_expr_struct_fields(
1537 expected: Expectation<'tcx>,
1538 expr_id: hir::HirId,
1540 variant: &'tcx ty::VariantDef,
1541 ast_fields: &'tcx [hir::ExprField<'tcx>],
1542 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1547 let expected_inputs =
1548 self.expected_inputs_for_expected_output(span, expected, adt_ty, &[adt_ty]);
1549 let adt_ty_hint = if let Some(expected_inputs) = expected_inputs {
1550 expected_inputs.get(0).cloned().unwrap_or(adt_ty)
1554 // re-link the regions that EIfEO can erase.
1555 self.demand_eqtype(span, adt_ty_hint, adt_ty);
1557 let ty::Adt(adt, substs) = adt_ty.kind() else {
1558 span_bug!(span, "non-ADT passed to check_expr_struct_fields");
1560 let adt_kind = adt.adt_kind();
1562 let mut remaining_fields = variant
1566 .map(|(i, field)| (field.ident(tcx).normalize_to_macros_2_0(), (i, field)))
1567 .collect::<FxHashMap<_, _>>();
1569 let mut seen_fields = FxHashMap::default();
1571 let mut error_happened = false;
1573 // Type-check each field.
1574 for (idx, field) in ast_fields.iter().enumerate() {
1575 let ident = tcx.adjust_ident(field.ident, variant.def_id);
1576 let field_type = if let Some((i, v_field)) = remaining_fields.remove(&ident) {
1577 seen_fields.insert(ident, field.span);
1578 self.write_field_index(field.hir_id, i);
1580 // We don't look at stability attributes on
1581 // struct-like enums (yet...), but it's definitely not
1582 // a bug to have constructed one.
1583 if adt_kind != AdtKind::Enum {
1584 tcx.check_stability(v_field.did, Some(expr_id), field.span, None);
1587 self.field_ty(field.span, v_field, substs)
1589 error_happened = true;
1590 if let Some(prev_span) = seen_fields.get(&ident) {
1591 tcx.sess.emit_err(FieldMultiplySpecifiedInInitializer {
1592 span: field.ident.span,
1593 prev_span: *prev_span,
1597 self.report_unknown_field(
1602 adt.variant_descr(),
1610 // Make sure to give a type to the field even if there's
1611 // an error, so we can continue type-checking.
1612 let ty = self.check_expr_with_hint(&field.expr, field_type);
1614 self.demand_coerce_diag(&field.expr, ty, field_type, None, AllowTwoPhase::No);
1616 if let Some(mut diag) = diag {
1617 if idx == ast_fields.len() - 1 && remaining_fields.is_empty() {
1618 self.suggest_fru_from_range(field, variant, substs, &mut diag);
1624 // Make sure the programmer specified correct number of fields.
1625 if adt_kind == AdtKind::Union {
1626 if ast_fields.len() != 1 {
1631 "union expressions should have exactly one field",
1637 // If check_expr_struct_fields hit an error, do not attempt to populate
1638 // the fields with the base_expr. This could cause us to hit errors later
1639 // when certain fields are assumed to exist that in fact do not.
1644 if let Some(base_expr) = base_expr {
1645 // FIXME: We are currently creating two branches here in order to maintain
1646 // consistency. But they should be merged as much as possible.
1647 let fru_tys = if self.tcx.features().type_changing_struct_update {
1648 if adt.is_struct() {
1649 // Make some fresh substitutions for our ADT type.
1650 let fresh_substs = self.fresh_substs_for_item(base_expr.span, adt.did());
1651 // We do subtyping on the FRU fields first, so we can
1652 // learn exactly what types we expect the base expr
1653 // needs constrained to be compatible with the struct
1654 // type we expect from the expectation value.
1655 let fru_tys = variant
1659 let fru_ty = self.normalize_associated_types_in(
1661 self.field_ty(base_expr.span, f, fresh_substs),
1663 let ident = self.tcx.adjust_ident(f.ident(self.tcx), variant.def_id);
1664 if let Some(_) = remaining_fields.remove(&ident) {
1665 let target_ty = self.field_ty(base_expr.span, f, substs);
1666 let cause = self.misc(base_expr.span);
1667 match self.at(&cause, self.param_env).sup(target_ty, fru_ty) {
1668 Ok(InferOk { obligations, value: () }) => {
1669 self.register_predicates(obligations)
1672 // This should never happen, since we're just subtyping the
1673 // remaining_fields, but it's fine to emit this, I guess.
1675 .report_mismatched_types(
1679 FieldMisMatch(variant.name, ident.name),
1685 self.resolve_vars_if_possible(fru_ty)
1688 // The use of fresh substs that we have subtyped against
1689 // our base ADT type's fields allows us to guide inference
1690 // along so that, e.g.
1692 // MyStruct<'a, F1, F2, const C: usize> {
1694 // // Other fields that reference `'a`, `F2`, and `C`
1697 // let x = MyStruct {
1702 // will have the `other_struct` expression constrained to
1703 // `MyStruct<'a, _, F2, C>`, as opposed to just `_`...
1704 // This is important to allow coercions to happen in
1705 // `other_struct` itself. See `coerce-in-base-expr.rs`.
1706 let fresh_base_ty = self.tcx.mk_adt(*adt, fresh_substs);
1707 self.check_expr_has_type_or_error(
1709 self.resolve_vars_if_possible(fresh_base_ty),
1714 // Check the base_expr, regardless of a bad expected adt_ty, so we can get
1715 // type errors on that expression, too.
1716 self.check_expr(base_expr);
1719 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1723 self.check_expr_has_type_or_error(base_expr, adt_ty, |_| {
1724 let base_ty = self.typeck_results.borrow().expr_ty(*base_expr);
1725 let same_adt = match (adt_ty.kind(), base_ty.kind()) {
1726 (ty::Adt(adt, _), ty::Adt(base_adt, _)) if adt == base_adt => true,
1729 if self.tcx.sess.is_nightly_build() && same_adt {
1731 &self.tcx.sess.parse_sess,
1732 sym::type_changing_struct_update,
1734 "type changing struct updating is experimental",
1739 match adt_ty.kind() {
1740 ty::Adt(adt, substs) if adt.is_struct() => variant
1744 self.normalize_associated_types_in(expr_span, f.ty(self.tcx, substs))
1750 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1755 self.typeck_results.borrow_mut().fru_field_types_mut().insert(expr_id, fru_tys);
1756 } else if adt_kind != AdtKind::Union && !remaining_fields.is_empty() {
1757 debug!(?remaining_fields);
1758 let private_fields: Vec<&ty::FieldDef> = variant
1761 .filter(|field| !field.vis.is_accessible_from(tcx.parent_module(expr_id), tcx))
1764 if !private_fields.is_empty() {
1765 self.report_private_fields(adt_ty, span, private_fields, ast_fields);
1767 self.report_missing_fields(
1779 fn check_struct_fields_on_error(
1781 fields: &'tcx [hir::ExprField<'tcx>],
1782 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1784 for field in fields {
1785 self.check_expr(&field.expr);
1787 if let Some(base) = *base_expr {
1788 self.check_expr(&base);
1792 /// Report an error for a struct field expression when there are fields which aren't provided.
1795 /// error: missing field `you_can_use_this_field` in initializer of `foo::Foo`
1796 /// --> src/main.rs:8:5
1798 /// 8 | foo::Foo {};
1799 /// | ^^^^^^^^ missing `you_can_use_this_field`
1801 /// error: aborting due to previous error
1803 fn report_missing_fields(
1807 remaining_fields: FxHashMap<Ident, (usize, &ty::FieldDef)>,
1808 variant: &'tcx ty::VariantDef,
1809 ast_fields: &'tcx [hir::ExprField<'tcx>],
1810 substs: SubstsRef<'tcx>,
1812 let len = remaining_fields.len();
1814 let mut displayable_field_names: Vec<&str> =
1815 remaining_fields.keys().map(|ident| ident.as_str()).collect();
1816 // sorting &str primitives here, sort_unstable is ok
1817 displayable_field_names.sort_unstable();
1819 let mut truncated_fields_error = String::new();
1820 let remaining_fields_names = match &displayable_field_names[..] {
1821 [field1] => format!("`{}`", field1),
1822 [field1, field2] => format!("`{field1}` and `{field2}`"),
1823 [field1, field2, field3] => format!("`{field1}`, `{field2}` and `{field3}`"),
1825 truncated_fields_error =
1826 format!(" and {} other field{}", len - 3, pluralize!(len - 3));
1827 displayable_field_names
1830 .map(|n| format!("`{n}`"))
1831 .collect::<Vec<_>>()
1836 let mut err = struct_span_err!(
1840 "missing field{} {}{} in initializer of `{}`",
1842 remaining_fields_names,
1843 truncated_fields_error,
1846 err.span_label(span, format!("missing {remaining_fields_names}{truncated_fields_error}"));
1848 if let Some(last) = ast_fields.last() {
1849 self.suggest_fru_from_range(last, variant, substs, &mut err);
1855 /// If the last field is a range literal, but it isn't supposed to be, then they probably
1856 /// meant to use functional update syntax.
1857 fn suggest_fru_from_range(
1859 last_expr_field: &hir::ExprField<'tcx>,
1860 variant: &ty::VariantDef,
1861 substs: SubstsRef<'tcx>,
1862 err: &mut Diagnostic,
1864 // I don't use 'is_range_literal' because only double-sided, half-open ranges count.
1865 if let ExprKind::Struct(
1866 QPath::LangItem(LangItem::Range, ..),
1867 &[ref range_start, ref range_end],
1869 ) = last_expr_field.expr.kind
1870 && let variant_field =
1871 variant.fields.iter().find(|field| field.ident(self.tcx) == last_expr_field.ident)
1872 && let range_def_id = self.tcx.lang_items().range_struct()
1874 .and_then(|field| field.ty(self.tcx, substs).ty_adt_def())
1875 .map(|adt| adt.did())
1882 .span_to_snippet(range_end.expr.span)
1883 .map(|s| format!(" from `{s}`"))
1884 .unwrap_or_default();
1885 err.span_suggestion(
1886 range_start.span.shrink_to_hi(),
1887 &format!("to set the remaining fields{instead}, separate the last named field with a comma"),
1889 Applicability::MaybeIncorrect,
1894 /// Report an error for a struct field expression when there are invisible fields.
1897 /// error: cannot construct `Foo` with struct literal syntax due to private fields
1898 /// --> src/main.rs:8:5
1900 /// 8 | foo::Foo {};
1903 /// error: aborting due to previous error
1905 fn report_private_fields(
1909 private_fields: Vec<&ty::FieldDef>,
1910 used_fields: &'tcx [hir::ExprField<'tcx>],
1912 let mut err = self.tcx.sess.struct_span_err(
1915 "cannot construct `{adt_ty}` with struct literal syntax due to private fields",
1918 let (used_private_fields, remaining_private_fields): (
1919 Vec<(Symbol, Span, bool)>,
1920 Vec<(Symbol, Span, bool)>,
1924 match used_fields.iter().find(|used_field| field.name == used_field.ident.name) {
1925 Some(used_field) => (field.name, used_field.span, true),
1926 None => (field.name, self.tcx.def_span(field.did), false),
1929 .partition(|field| field.2);
1930 err.span_labels(used_private_fields.iter().map(|(_, span, _)| *span), "private field");
1931 if !remaining_private_fields.is_empty() {
1932 let remaining_private_fields_len = remaining_private_fields.len();
1933 let names = match &remaining_private_fields
1935 .map(|(name, _, _)| name)
1936 .collect::<Vec<_>>()[..]
1938 _ if remaining_private_fields_len > 6 => String::new(),
1939 [name] => format!("`{name}` "),
1940 [names @ .., last] => {
1941 let names = names.iter().map(|name| format!("`{name}`")).collect::<Vec<_>>();
1942 format!("{} and `{last}` ", names.join(", "))
1944 [] => unreachable!(),
1947 "... and other private field{s} {names}that {were} not provided",
1948 s = pluralize!(remaining_private_fields_len),
1949 were = pluralize!("was", remaining_private_fields_len),
1955 fn report_unknown_field(
1958 variant: &'tcx ty::VariantDef,
1959 field: &hir::ExprField<'_>,
1960 skip_fields: &[hir::ExprField<'_>],
1964 if variant.is_recovered() {
1965 self.set_tainted_by_errors();
1968 let mut err = self.err_ctxt().type_error_struct_with_diag(
1970 |actual| match ty.kind() {
1971 ty::Adt(adt, ..) if adt.is_enum() => struct_span_err!(
1975 "{} `{}::{}` has no field named `{}`",
1981 _ => struct_span_err!(
1985 "{} `{}` has no field named `{}`",
1994 let variant_ident_span = self.tcx.def_ident_span(variant.def_id).unwrap();
1995 match variant.ctor_kind {
1996 CtorKind::Fn => match ty.kind() {
1997 ty::Adt(adt, ..) if adt.is_enum() => {
2001 "`{adt}::{variant}` defined here",
2003 variant = variant.name,
2006 err.span_label(field.ident.span, "field does not exist");
2007 err.span_suggestion_verbose(
2010 "`{adt}::{variant}` is a tuple {kind_name}, use the appropriate syntax",
2012 variant = variant.name,
2015 "{adt}::{variant}(/* fields */)",
2017 variant = variant.name,
2019 Applicability::HasPlaceholders,
2023 err.span_label(variant_ident_span, format!("`{adt}` defined here", adt = ty));
2024 err.span_label(field.ident.span, "field does not exist");
2025 err.span_suggestion_verbose(
2028 "`{adt}` is a tuple {kind_name}, use the appropriate syntax",
2030 kind_name = kind_name,
2032 format!("{adt}(/* fields */)", adt = ty),
2033 Applicability::HasPlaceholders,
2038 // prevent all specified fields from being suggested
2039 let skip_fields = skip_fields.iter().map(|x| x.ident.name);
2040 if let Some(field_name) = self.suggest_field_name(
2043 skip_fields.collect(),
2046 err.span_suggestion(
2048 "a field with a similar name exists",
2050 Applicability::MaybeIncorrect,
2054 ty::Adt(adt, ..) => {
2058 format!("`{}::{}` does not have this field", ty, variant.name),
2063 format!("`{ty}` does not have this field"),
2066 let available_field_names =
2067 self.available_field_names(variant, expr_span);
2068 if !available_field_names.is_empty() {
2070 "available fields are: {}",
2071 self.name_series_display(available_field_names)
2075 _ => bug!("non-ADT passed to report_unknown_field"),
2083 // Return a hint about the closest match in field names
2084 fn suggest_field_name(
2086 variant: &'tcx ty::VariantDef,
2089 // The span where stability will be checked
2091 ) -> Option<Symbol> {
2095 .filter_map(|field| {
2096 // ignore already set fields and private fields from non-local crates
2097 // and unstable fields.
2098 if skip.iter().any(|&x| x == field.name)
2099 || (!variant.def_id.is_local() && !field.vis.is_public())
2101 self.tcx.eval_stability(field.did, None, span, None),
2102 stability::EvalResult::Deny { .. }
2110 .collect::<Vec<Symbol>>();
2112 find_best_match_for_name(&names, field, None)
2115 fn available_field_names(
2117 variant: &'tcx ty::VariantDef,
2124 let def_scope = self
2126 .adjust_ident_and_get_scope(field.ident(self.tcx), variant.def_id, self.body_id)
2128 field.vis.is_accessible_from(def_scope, self.tcx)
2130 self.tcx.eval_stability(field.did, None, access_span, None),
2131 stability::EvalResult::Deny { .. }
2134 .filter(|field| !self.tcx.is_doc_hidden(field.did))
2135 .map(|field| field.name)
2139 fn name_series_display(&self, names: Vec<Symbol>) -> String {
2140 // dynamic limit, to never omit just one field
2141 let limit = if names.len() == 6 { 6 } else { 5 };
2143 names.iter().take(limit).map(|n| format!("`{}`", n)).collect::<Vec<_>>().join(", ");
2144 if names.len() > limit {
2145 display = format!("{} ... and {} others", display, names.len() - limit);
2150 // Check field access expressions
2153 expr: &'tcx hir::Expr<'tcx>,
2154 base: &'tcx hir::Expr<'tcx>,
2157 debug!("check_field(expr: {:?}, base: {:?}, field: {:?})", expr, base, field);
2158 let base_ty = self.check_expr(base);
2159 let base_ty = self.structurally_resolved_type(base.span, base_ty);
2160 let mut private_candidate = None;
2161 let mut autoderef = self.autoderef(expr.span, base_ty);
2162 while let Some((deref_base_ty, _)) = autoderef.next() {
2163 debug!("deref_base_ty: {:?}", deref_base_ty);
2164 match deref_base_ty.kind() {
2165 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2166 debug!("struct named {:?}", deref_base_ty);
2167 let (ident, def_scope) =
2168 self.tcx.adjust_ident_and_get_scope(field, base_def.did(), self.body_id);
2169 let fields = &base_def.non_enum_variant().fields;
2170 if let Some(index) = fields
2172 .position(|f| f.ident(self.tcx).normalize_to_macros_2_0() == ident)
2174 let field = &fields[index];
2175 let field_ty = self.field_ty(expr.span, field, substs);
2176 // Save the index of all fields regardless of their visibility in case
2177 // of error recovery.
2178 self.write_field_index(expr.hir_id, index);
2179 let adjustments = self.adjust_steps(&autoderef);
2180 if field.vis.is_accessible_from(def_scope, self.tcx) {
2181 self.apply_adjustments(base, adjustments);
2182 self.register_predicates(autoderef.into_obligations());
2184 self.tcx.check_stability(field.did, Some(expr.hir_id), expr.span, None);
2187 private_candidate = Some((adjustments, base_def.did(), field_ty));
2191 let fstr = field.as_str();
2192 if let Ok(index) = fstr.parse::<usize>() {
2193 if fstr == index.to_string() {
2194 if let Some(&field_ty) = tys.get(index) {
2195 let adjustments = self.adjust_steps(&autoderef);
2196 self.apply_adjustments(base, adjustments);
2197 self.register_predicates(autoderef.into_obligations());
2199 self.write_field_index(expr.hir_id, index);
2208 self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
2210 if let Some((adjustments, did, field_ty)) = private_candidate {
2211 // (#90483) apply adjustments to avoid ExprUseVisitor from
2212 // creating erroneous projection.
2213 self.apply_adjustments(base, adjustments);
2214 self.ban_private_field_access(expr, base_ty, field, did);
2218 if field.name == kw::Empty {
2219 } else if self.method_exists(field, base_ty, expr.hir_id, true) {
2220 self.ban_take_value_of_method(expr, base_ty, field);
2221 } else if !base_ty.is_primitive_ty() {
2222 self.ban_nonexisting_field(field, base, expr, base_ty);
2224 let field_name = field.to_string();
2225 let mut err = type_error_struct!(
2230 "`{base_ty}` is a primitive type and therefore doesn't have fields",
2232 let is_valid_suffix = |field: &str| {
2233 if field == "f32" || field == "f64" {
2236 let mut chars = field.chars().peekable();
2237 match chars.peek() {
2238 Some('e') | Some('E') => {
2240 if let Some(c) = chars.peek()
2241 && !c.is_numeric() && *c != '-' && *c != '+'
2245 while let Some(c) = chars.peek() {
2246 if !c.is_numeric() {
2254 let suffix = chars.collect::<String>();
2255 suffix.is_empty() || suffix == "f32" || suffix == "f64"
2257 let maybe_partial_suffix = |field: &str| -> Option<&str> {
2258 let first_chars = ['f', 'l'];
2260 && field.to_lowercase().starts_with(first_chars)
2261 && field[1..].chars().all(|c| c.is_ascii_digit())
2263 if field.to_lowercase().starts_with(['f']) { Some("f32") } else { Some("f64") }
2268 if let ty::Infer(ty::IntVar(_)) = base_ty.kind()
2269 && let ExprKind::Lit(Spanned {
2270 node: ast::LitKind::Int(_, ast::LitIntType::Unsuffixed),
2273 && !base.span.from_expansion()
2275 if is_valid_suffix(&field_name) {
2276 err.span_suggestion_verbose(
2277 field.span.shrink_to_lo(),
2278 "if intended to be a floating point literal, consider adding a `0` after the period",
2280 Applicability::MaybeIncorrect,
2282 } else if let Some(correct_suffix) = maybe_partial_suffix(&field_name) {
2283 err.span_suggestion_verbose(
2285 format!("if intended to be a floating point literal, consider adding a `0` after the period and a `{correct_suffix}` suffix"),
2286 format!("0{correct_suffix}"),
2287 Applicability::MaybeIncorrect,
2294 self.tcx().ty_error()
2297 fn suggest_await_on_field_access(
2299 err: &mut Diagnostic,
2301 base: &'tcx hir::Expr<'tcx>,
2304 let output_ty = match self.get_impl_future_output_ty(ty) {
2305 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
2308 let mut add_label = true;
2309 if let ty::Adt(def, _) = output_ty.skip_binder().kind() {
2310 // no field access on enum type
2316 .any(|field| field.ident(self.tcx) == field_ident)
2321 "field not available in `impl Future`, but it is available in its `Output`",
2323 err.span_suggestion_verbose(
2324 base.span.shrink_to_hi(),
2325 "consider `await`ing on the `Future` and access the field of its `Output`",
2327 Applicability::MaybeIncorrect,
2333 err.span_label(field_ident.span, &format!("field not found in `{ty}`"));
2337 fn ban_nonexisting_field(
2340 base: &'tcx hir::Expr<'tcx>,
2341 expr: &'tcx hir::Expr<'tcx>,
2345 "ban_nonexisting_field: field={:?}, base={:?}, expr={:?}, base_ty={:?}",
2346 ident, base, expr, base_ty
2348 let mut err = self.no_such_field_err(ident, base_ty, base.hir_id);
2350 match *base_ty.peel_refs().kind() {
2351 ty::Array(_, len) => {
2352 self.maybe_suggest_array_indexing(&mut err, expr, base, ident, len);
2355 self.suggest_first_deref_field(&mut err, expr, base, ident);
2357 ty::Adt(def, _) if !def.is_enum() => {
2358 self.suggest_fields_on_recordish(&mut err, def, ident, expr.span);
2360 ty::Param(param_ty) => {
2361 self.point_at_param_definition(&mut err, param_ty);
2363 ty::Opaque(_, _) => {
2364 self.suggest_await_on_field_access(&mut err, ident, base, base_ty.peel_refs());
2369 self.suggest_fn_call(&mut err, base, base_ty, |output_ty| {
2370 if let ty::Adt(def, _) = output_ty.kind() && !def.is_enum() {
2371 def.non_enum_variant().fields.iter().any(|field| {
2372 field.ident(self.tcx) == ident
2373 && field.vis.is_accessible_from(expr.hir_id.owner.def_id, self.tcx)
2375 } else if let ty::Tuple(tys) = output_ty.kind()
2376 && let Ok(idx) = ident.as_str().parse::<usize>()
2384 if ident.name == kw::Await {
2385 // We know by construction that `<expr>.await` is either on Rust 2015
2386 // or results in `ExprKind::Await`. Suggest switching the edition to 2018.
2387 err.note("to `.await` a `Future`, switch to Rust 2018 or later");
2388 err.help_use_latest_edition();
2394 fn ban_private_field_access(
2396 expr: &hir::Expr<'_>,
2401 let struct_path = self.tcx().def_path_str(base_did);
2402 let kind_name = self.tcx().def_kind(base_did).descr(base_did);
2403 let mut err = struct_span_err!(
2407 "field `{field}` of {kind_name} `{struct_path}` is private",
2409 err.span_label(field.span, "private field");
2410 // Also check if an accessible method exists, which is often what is meant.
2411 if self.method_exists(field, expr_t, expr.hir_id, false) && !self.expr_in_place(expr.hir_id)
2413 self.suggest_method_call(
2415 &format!("a method `{field}` also exists, call it with parentheses"),
2425 fn ban_take_value_of_method(&self, expr: &hir::Expr<'_>, expr_t: Ty<'tcx>, field: Ident) {
2426 let mut err = type_error_struct!(
2431 "attempted to take value of method `{field}` on type `{expr_t}`",
2433 err.span_label(field.span, "method, not a field");
2435 if let hir::Node::Expr(hir::Expr { kind: ExprKind::Call(callee, _args), .. }) =
2436 self.tcx.hir().get(self.tcx.hir().get_parent_node(expr.hir_id))
2438 expr.hir_id == callee.hir_id
2443 self.tcx.sess.source_map().span_to_snippet(expr.span).unwrap_or_default();
2444 let is_wrapped = expr_snippet.starts_with('(') && expr_snippet.ends_with(')');
2445 let after_open = expr.span.lo() + rustc_span::BytePos(1);
2446 let before_close = expr.span.hi() - rustc_span::BytePos(1);
2448 if expr_is_call && is_wrapped {
2449 err.multipart_suggestion(
2450 "remove wrapping parentheses to call the method",
2452 (expr.span.with_hi(after_open), String::new()),
2453 (expr.span.with_lo(before_close), String::new()),
2455 Applicability::MachineApplicable,
2457 } else if !self.expr_in_place(expr.hir_id) {
2458 // Suggest call parentheses inside the wrapping parentheses
2459 let span = if is_wrapped {
2460 expr.span.with_lo(after_open).with_hi(before_close)
2464 self.suggest_method_call(
2466 "use parentheses to call the method",
2472 } else if let ty::RawPtr(ty_and_mut) = expr_t.kind()
2473 && let ty::Adt(adt_def, _) = ty_and_mut.ty.kind()
2474 && let ExprKind::Field(base_expr, _) = expr.kind
2475 && adt_def.variants().len() == 1
2483 .any(|f| f.ident(self.tcx) == field)
2485 err.multipart_suggestion(
2486 "to access the field, dereference first",
2488 (base_expr.span.shrink_to_lo(), "(*".to_string()),
2489 (base_expr.span.shrink_to_hi(), ")".to_string()),
2491 Applicability::MaybeIncorrect,
2494 err.help("methods are immutable and cannot be assigned to");
2500 fn point_at_param_definition(&self, err: &mut Diagnostic, param: ty::ParamTy) {
2501 let generics = self.tcx.generics_of(self.body_id.owner.to_def_id());
2502 let generic_param = generics.type_param(¶m, self.tcx);
2503 if let ty::GenericParamDefKind::Type { synthetic: true, .. } = generic_param.kind {
2506 let param_def_id = generic_param.def_id;
2507 let param_hir_id = match param_def_id.as_local() {
2508 Some(x) => self.tcx.hir().local_def_id_to_hir_id(x),
2511 let param_span = self.tcx.hir().span(param_hir_id);
2512 let param_name = self.tcx.hir().ty_param_name(param_def_id.expect_local());
2514 err.span_label(param_span, &format!("type parameter '{param_name}' declared here"));
2517 fn suggest_fields_on_recordish(
2519 err: &mut Diagnostic,
2520 def: ty::AdtDef<'tcx>,
2524 if let Some(suggested_field_name) =
2525 self.suggest_field_name(def.non_enum_variant(), field.name, vec![], access_span)
2527 err.span_suggestion(
2529 "a field with a similar name exists",
2530 suggested_field_name,
2531 Applicability::MaybeIncorrect,
2534 err.span_label(field.span, "unknown field");
2535 let struct_variant_def = def.non_enum_variant();
2536 let field_names = self.available_field_names(struct_variant_def, access_span);
2537 if !field_names.is_empty() {
2539 "available fields are: {}",
2540 self.name_series_display(field_names),
2546 fn maybe_suggest_array_indexing(
2548 err: &mut Diagnostic,
2549 expr: &hir::Expr<'_>,
2550 base: &hir::Expr<'_>,
2552 len: ty::Const<'tcx>,
2554 if let (Some(len), Ok(user_index)) =
2555 (len.try_eval_usize(self.tcx, self.param_env), field.as_str().parse::<u64>())
2556 && let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
2558 let help = "instead of using tuple indexing, use array indexing";
2559 let suggestion = format!("{base}[{field}]");
2560 let applicability = if len < user_index {
2561 Applicability::MachineApplicable
2563 Applicability::MaybeIncorrect
2565 err.span_suggestion(expr.span, help, suggestion, applicability);
2569 fn suggest_first_deref_field(
2571 err: &mut Diagnostic,
2572 expr: &hir::Expr<'_>,
2573 base: &hir::Expr<'_>,
2576 if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span) {
2577 let msg = format!("`{base}` is a raw pointer; try dereferencing it");
2578 let suggestion = format!("(*{base}).{field}");
2579 err.span_suggestion(expr.span, &msg, suggestion, Applicability::MaybeIncorrect);
2583 fn no_such_field_err(
2588 ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
2589 let span = field.span;
2590 debug!("no_such_field_err(span: {:?}, field: {:?}, expr_t: {:?})", span, field, expr_t);
2592 let mut err = type_error_struct!(
2597 "no field `{field}` on type `{expr_t}`",
2600 // try to add a suggestion in case the field is a nested field of a field of the Adt
2601 let mod_id = self.tcx.parent_module(id).to_def_id();
2602 if let Some((fields, substs)) =
2603 self.get_field_candidates_considering_privacy(span, expr_t, mod_id)
2605 let candidate_fields: Vec<_> = fields
2606 .filter_map(|candidate_field| {
2607 self.check_for_nested_field_satisfying(
2609 &|candidate_field, _| candidate_field.ident(self.tcx()) == field,
2616 .map(|mut field_path| {
2620 .map(|id| id.name.to_ident_string())
2621 .collect::<Vec<String>>()
2624 .collect::<Vec<_>>();
2626 let len = candidate_fields.len();
2628 err.span_suggestions(
2629 field.span.shrink_to_lo(),
2631 "{} of the expressions' fields {} a field of the same name",
2632 if len > 1 { "some" } else { "one" },
2633 if len > 1 { "have" } else { "has" },
2635 candidate_fields.iter().map(|path| format!("{path}.")),
2636 Applicability::MaybeIncorrect,
2643 pub(crate) fn get_field_candidates_considering_privacy(
2648 ) -> Option<(impl Iterator<Item = &'tcx ty::FieldDef> + 'tcx, SubstsRef<'tcx>)> {
2649 debug!("get_field_candidates(span: {:?}, base_t: {:?}", span, base_ty);
2651 for (base_t, _) in self.autoderef(span, base_ty) {
2652 match base_t.kind() {
2653 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2655 let fields = &base_def.non_enum_variant().fields;
2656 // Some struct, e.g. some that impl `Deref`, have all private fields
2657 // because you're expected to deref them to access the _real_ fields.
2658 // This, for example, will help us suggest accessing a field through a `Box<T>`.
2659 if fields.iter().all(|field| !field.vis.is_accessible_from(mod_id, tcx)) {
2665 .filter(move |field| field.vis.is_accessible_from(mod_id, tcx))
2666 // For compile-time reasons put a limit on number of fields we search
2677 /// This method is called after we have encountered a missing field error to recursively
2678 /// search for the field
2679 pub(crate) fn check_for_nested_field_satisfying(
2682 matches: &impl Fn(&ty::FieldDef, Ty<'tcx>) -> bool,
2683 candidate_field: &ty::FieldDef,
2684 subst: SubstsRef<'tcx>,
2685 mut field_path: Vec<Ident>,
2687 ) -> Option<Vec<Ident>> {
2689 "check_for_nested_field_satisfying(span: {:?}, candidate_field: {:?}, field_path: {:?}",
2690 span, candidate_field, field_path
2693 if field_path.len() > 3 {
2694 // For compile-time reasons and to avoid infinite recursion we only check for fields
2695 // up to a depth of three
2698 field_path.push(candidate_field.ident(self.tcx).normalize_to_macros_2_0());
2699 let field_ty = candidate_field.ty(self.tcx, subst);
2700 if matches(candidate_field, field_ty) {
2701 return Some(field_path);
2702 } else if let Some((nested_fields, subst)) =
2703 self.get_field_candidates_considering_privacy(span, field_ty, mod_id)
2705 // recursively search fields of `candidate_field` if it's a ty::Adt
2706 for field in nested_fields {
2707 if let Some(field_path) = self.check_for_nested_field_satisfying(
2715 return Some(field_path);
2723 fn check_expr_index(
2725 base: &'tcx hir::Expr<'tcx>,
2726 idx: &'tcx hir::Expr<'tcx>,
2727 expr: &'tcx hir::Expr<'tcx>,
2729 let base_t = self.check_expr(&base);
2730 let idx_t = self.check_expr(&idx);
2732 if base_t.references_error() {
2734 } else if idx_t.references_error() {
2737 let base_t = self.structurally_resolved_type(base.span, base_t);
2738 match self.lookup_indexing(expr, base, base_t, idx, idx_t) {
2739 Some((index_ty, element_ty)) => {
2740 // two-phase not needed because index_ty is never mutable
2741 self.demand_coerce(idx, idx_t, index_ty, None, AllowTwoPhase::No);
2742 self.select_obligations_where_possible(|errors| {
2743 self.point_at_index_if_possible(errors, idx.span)
2748 let mut err = type_error_struct!(
2753 "cannot index into a value of type `{base_t}`",
2755 // Try to give some advice about indexing tuples.
2756 if let ty::Tuple(..) = base_t.kind() {
2757 let mut needs_note = true;
2758 // If the index is an integer, we can show the actual
2759 // fixed expression:
2760 if let ExprKind::Lit(ref lit) = idx.kind {
2761 if let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node {
2762 let snip = self.tcx.sess.source_map().span_to_snippet(base.span);
2763 if let Ok(snip) = snip {
2764 err.span_suggestion(
2766 "to access tuple elements, use",
2767 format!("{snip}.{i}"),
2768 Applicability::MachineApplicable,
2776 "to access tuple elements, use tuple indexing \
2777 syntax (e.g., `tuple.0`)",
2781 let reported = err.emit();
2782 self.tcx.ty_error_with_guaranteed(reported)
2788 fn point_at_index_if_possible(
2790 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
2793 for error in errors {
2794 match error.obligation.predicate.kind().skip_binder() {
2795 ty::PredicateKind::Trait(predicate)
2796 if self.tcx.is_diagnostic_item(sym::SliceIndex, predicate.trait_ref.def_id) => {
2800 error.obligation.cause.span = span;
2804 fn check_expr_yield(
2806 value: &'tcx hir::Expr<'tcx>,
2807 expr: &'tcx hir::Expr<'tcx>,
2808 src: &'tcx hir::YieldSource,
2810 match self.resume_yield_tys {
2811 Some((resume_ty, yield_ty)) => {
2812 self.check_expr_coercable_to_type(&value, yield_ty, None);
2816 // Given that this `yield` expression was generated as a result of lowering a `.await`,
2817 // we know that the yield type must be `()`; however, the context won't contain this
2818 // information. Hence, we check the source of the yield expression here and check its
2819 // value's type against `()` (this check should always hold).
2820 None if src.is_await() => {
2821 self.check_expr_coercable_to_type(&value, self.tcx.mk_unit(), None);
2825 self.tcx.sess.emit_err(YieldExprOutsideOfGenerator { span: expr.span });
2826 // Avoid expressions without types during writeback (#78653).
2827 self.check_expr(value);
2833 fn check_expr_asm_operand(&self, expr: &'tcx hir::Expr<'tcx>, is_input: bool) {
2834 let needs = if is_input { Needs::None } else { Needs::MutPlace };
2835 let ty = self.check_expr_with_needs(expr, needs);
2836 self.require_type_is_sized(ty, expr.span, traits::InlineAsmSized);
2838 if !is_input && !expr.is_syntactic_place_expr() {
2839 let mut err = self.tcx.sess.struct_span_err(expr.span, "invalid asm output");
2840 err.span_label(expr.span, "cannot assign to this expression");
2844 // If this is an input value, we require its type to be fully resolved
2845 // at this point. This allows us to provide helpful coercions which help
2846 // pass the type candidate list in a later pass.
2848 // We don't require output types to be resolved at this point, which
2849 // allows them to be inferred based on how they are used later in the
2852 let ty = self.structurally_resolved_type(expr.span, ty);
2855 let fnptr_ty = self.tcx.mk_fn_ptr(ty.fn_sig(self.tcx));
2856 self.demand_coerce(expr, ty, fnptr_ty, None, AllowTwoPhase::No);
2858 ty::Ref(_, base_ty, mutbl) => {
2859 let ptr_ty = self.tcx.mk_ptr(ty::TypeAndMut { ty: base_ty, mutbl });
2860 self.demand_coerce(expr, ty, ptr_ty, None, AllowTwoPhase::No);
2867 fn check_expr_asm(&self, asm: &'tcx hir::InlineAsm<'tcx>) -> Ty<'tcx> {
2868 for (op, _op_sp) in asm.operands {
2870 hir::InlineAsmOperand::In { expr, .. } => {
2871 self.check_expr_asm_operand(expr, true);
2873 hir::InlineAsmOperand::Out { expr: Some(expr), .. }
2874 | hir::InlineAsmOperand::InOut { expr, .. } => {
2875 self.check_expr_asm_operand(expr, false);
2877 hir::InlineAsmOperand::Out { expr: None, .. } => {}
2878 hir::InlineAsmOperand::SplitInOut { in_expr, out_expr, .. } => {
2879 self.check_expr_asm_operand(in_expr, true);
2880 if let Some(out_expr) = out_expr {
2881 self.check_expr_asm_operand(out_expr, false);
2884 // `AnonConst`s have their own body and is type-checked separately.
2885 // As they don't flow into the type system we don't need them to
2887 hir::InlineAsmOperand::Const { .. } | hir::InlineAsmOperand::SymFn { .. } => {}
2888 hir::InlineAsmOperand::SymStatic { .. } => {}
2891 if asm.options.contains(ast::InlineAsmOptions::NORETURN) {
2892 self.tcx.types.never