1 //! Type checking expressions.
3 //! See `mod.rs` for more context on type checking in general.
6 use crate::coercion::CoerceMany;
7 use crate::coercion::DynamicCoerceMany;
8 use crate::errors::TypeMismatchFruTypo;
9 use crate::errors::{AddressOfTemporaryTaken, ReturnStmtOutsideOfFnBody, StructExprNonExhaustive};
11 FieldMultiplySpecifiedInInitializer, FunctionalRecordUpdateOnNonStruct,
12 YieldExprOutsideOfGenerator,
14 use crate::fatally_break_rust;
15 use crate::method::SelfSource;
16 use crate::type_error_struct;
17 use crate::Expectation::{self, ExpectCastableToType, ExpectHasType, NoExpectation};
19 report_unexpected_variant_res, BreakableCtxt, Diverges, FnCtxt, Needs,
20 TupleArgumentsFlag::DontTupleArguments,
23 use rustc_data_structures::fx::FxHashMap;
24 use rustc_data_structures::stack::ensure_sufficient_stack;
26 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, DiagnosticId,
27 ErrorGuaranteed, StashKey,
30 use rustc_hir::def::{CtorKind, DefKind, Res};
31 use rustc_hir::def_id::DefId;
32 use rustc_hir::intravisit::Visitor;
33 use rustc_hir::lang_items::LangItem;
34 use rustc_hir::{ExprKind, HirId, QPath};
35 use rustc_hir_analysis::astconv::AstConv as _;
36 use rustc_hir_analysis::check::ty_kind_suggestion;
37 use rustc_infer::infer;
38 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
39 use rustc_infer::infer::InferOk;
40 use rustc_infer::traits::ObligationCause;
41 use rustc_middle::middle::stability;
42 use rustc_middle::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase};
43 use rustc_middle::ty::error::TypeError::FieldMisMatch;
44 use rustc_middle::ty::subst::SubstsRef;
45 use rustc_middle::ty::{self, AdtKind, Ty, TypeVisitable};
46 use rustc_session::errors::ExprParenthesesNeeded;
47 use rustc_session::parse::feature_err;
48 use rustc_span::hygiene::DesugaringKind;
49 use rustc_span::lev_distance::find_best_match_for_name;
50 use rustc_span::source_map::{Span, Spanned};
51 use rustc_span::symbol::{kw, sym, Ident, Symbol};
52 use rustc_target::spec::abi::Abi::RustIntrinsic;
53 use rustc_trait_selection::infer::InferCtxtExt;
54 use rustc_trait_selection::traits::{self, ObligationCauseCode};
56 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
57 fn check_expr_eq_type(&self, expr: &'tcx hir::Expr<'tcx>, expected: Ty<'tcx>) {
58 let ty = self.check_expr_with_hint(expr, expected);
59 self.demand_eqtype(expr.span, expected, ty);
62 pub fn check_expr_has_type_or_error(
64 expr: &'tcx hir::Expr<'tcx>,
66 extend_err: impl FnMut(&mut Diagnostic),
68 self.check_expr_meets_expectation_or_error(expr, ExpectHasType(expected), extend_err)
71 fn check_expr_meets_expectation_or_error(
73 expr: &'tcx hir::Expr<'tcx>,
74 expected: Expectation<'tcx>,
75 mut extend_err: impl FnMut(&mut Diagnostic),
77 let expected_ty = expected.to_option(&self).unwrap_or(self.tcx.types.bool);
78 let mut ty = self.check_expr_with_expectation(expr, expected);
80 // While we don't allow *arbitrary* coercions here, we *do* allow
81 // coercions from ! to `expected`.
83 if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
84 let reported = self.tcx().sess.delay_span_bug(
86 "expression with never type wound up being adjusted",
88 return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
91 self.tcx().ty_error_with_guaranteed(reported)
95 let adj_ty = self.next_ty_var(TypeVariableOrigin {
96 kind: TypeVariableOriginKind::AdjustmentType,
99 self.apply_adjustments(
101 vec![Adjustment { kind: Adjust::NeverToAny, target: adj_ty }],
106 if let Some(mut err) = self.demand_suptype_diag(expr.span, expected_ty, ty) {
107 // FIXME(compiler-errors): We probably should fold some of the
108 // `suggest_` functions from `emit_coerce_suggestions` into here,
109 // since some of those aren't necessarily just coerce suggestions.
110 let _ = self.suggest_deref_ref_or_into(
112 expr.peel_drop_temps(),
116 ) || self.suggest_option_to_bool(&mut err, expr, ty, expected_ty);
117 extend_err(&mut err);
123 pub(super) fn check_expr_coercable_to_type(
125 expr: &'tcx hir::Expr<'tcx>,
127 expected_ty_expr: Option<&'tcx hir::Expr<'tcx>>,
129 let ty = self.check_expr_with_hint(expr, expected);
130 // checks don't need two phase
131 self.demand_coerce(expr, ty, expected, expected_ty_expr, AllowTwoPhase::No)
134 pub(super) fn check_expr_with_hint(
136 expr: &'tcx hir::Expr<'tcx>,
139 self.check_expr_with_expectation(expr, ExpectHasType(expected))
142 fn check_expr_with_expectation_and_needs(
144 expr: &'tcx hir::Expr<'tcx>,
145 expected: Expectation<'tcx>,
148 let ty = self.check_expr_with_expectation(expr, expected);
150 // If the expression is used in a place whether mutable place is required
151 // e.g. LHS of assignment, perform the conversion.
152 if let Needs::MutPlace = needs {
153 self.convert_place_derefs_to_mutable(expr);
159 pub(super) fn check_expr(&self, expr: &'tcx hir::Expr<'tcx>) -> Ty<'tcx> {
160 self.check_expr_with_expectation(expr, NoExpectation)
163 pub(super) fn check_expr_with_needs(
165 expr: &'tcx hir::Expr<'tcx>,
168 self.check_expr_with_expectation_and_needs(expr, NoExpectation, needs)
172 /// If an expression has any sub-expressions that result in a type error,
173 /// inspecting that expression's type with `ty.references_error()` will return
174 /// true. Likewise, if an expression is known to diverge, inspecting its
175 /// type with `ty::type_is_bot` will return true (n.b.: since Rust is
176 /// strict, _|_ can appear in the type of an expression that does not,
177 /// itself, diverge: for example, fn() -> _|_.)
178 /// Note that inspecting a type's structure *directly* may expose the fact
179 /// that there are actually multiple representations for `Error`, so avoid
180 /// that when err needs to be handled differently.
181 #[instrument(skip(self, expr), level = "debug")]
182 pub(super) fn check_expr_with_expectation(
184 expr: &'tcx hir::Expr<'tcx>,
185 expected: Expectation<'tcx>,
187 self.check_expr_with_expectation_and_args(expr, expected, &[])
190 /// Same as `check_expr_with_expectation`, but allows us to pass in the arguments of a
191 /// `ExprKind::Call` when evaluating its callee when it is an `ExprKind::Path`.
192 pub(super) fn check_expr_with_expectation_and_args(
194 expr: &'tcx hir::Expr<'tcx>,
195 expected: Expectation<'tcx>,
196 args: &'tcx [hir::Expr<'tcx>],
198 if self.tcx().sess.verbose() {
199 // make this code only run with -Zverbose because it is probably slow
200 if let Ok(lint_str) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
201 if !lint_str.contains('\n') {
202 debug!("expr text: {lint_str}");
204 let mut lines = lint_str.lines();
205 if let Some(line0) = lines.next() {
206 let remaining_lines = lines.count();
207 debug!("expr text: {line0}");
208 debug!("expr text: ...(and {remaining_lines} more lines)");
214 // True if `expr` is a `Try::from_ok(())` that is a result of desugaring a try block
215 // without the final expr (e.g. `try { return; }`). We don't want to generate an
216 // unreachable_code lint for it since warnings for autogenerated code are confusing.
217 let is_try_block_generated_unit_expr = match expr.kind {
218 ExprKind::Call(_, args) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {
219 args.len() == 1 && args[0].span.is_desugaring(DesugaringKind::TryBlock)
225 // Warn for expressions after diverging siblings.
226 if !is_try_block_generated_unit_expr {
227 self.warn_if_unreachable(expr.hir_id, expr.span, "expression");
230 // Hide the outer diverging and has_errors flags.
231 let old_diverges = self.diverges.replace(Diverges::Maybe);
233 let ty = ensure_sufficient_stack(|| match &expr.kind {
235 qpath @ hir::QPath::Resolved(..) | qpath @ hir::QPath::TypeRelative(..),
236 ) => self.check_expr_path(qpath, expr, args),
237 _ => self.check_expr_kind(expr, expected),
240 // Warn for non-block expressions with diverging children.
246 | ExprKind::Match(..) => {}
247 // If `expr` is a result of desugaring the try block and is an ok-wrapped
248 // diverging expression (e.g. it arose from desugaring of `try { return }`),
249 // we skip issuing a warning because it is autogenerated code.
250 ExprKind::Call(..) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {}
251 ExprKind::Call(callee, _) => self.warn_if_unreachable(expr.hir_id, callee.span, "call"),
252 ExprKind::MethodCall(segment, ..) => {
253 self.warn_if_unreachable(expr.hir_id, segment.ident.span, "call")
255 _ => self.warn_if_unreachable(expr.hir_id, expr.span, "expression"),
258 // Any expression that produces a value of type `!` must have diverged
260 self.diverges.set(self.diverges.get() | Diverges::always(expr.span));
263 // Record the type, which applies it effects.
264 // We need to do this after the warning above, so that
265 // we don't warn for the diverging expression itself.
266 self.write_ty(expr.hir_id, ty);
268 // Combine the diverging and has_error flags.
269 self.diverges.set(self.diverges.get() | old_diverges);
271 debug!("type of {} is...", self.tcx.hir().node_to_string(expr.hir_id));
272 debug!("... {:?}, expected is {:?}", ty, expected);
277 #[instrument(skip(self, expr), level = "debug")]
280 expr: &'tcx hir::Expr<'tcx>,
281 expected: Expectation<'tcx>,
283 trace!("expr={:#?}", expr);
287 ExprKind::Box(subexpr) => self.check_expr_box(subexpr, expected),
288 ExprKind::Lit(ref lit) => self.check_lit(&lit, expected),
289 ExprKind::Binary(op, lhs, rhs) => self.check_binop(expr, op, lhs, rhs, expected),
290 ExprKind::Assign(lhs, rhs, span) => {
291 self.check_expr_assign(expr, expected, lhs, rhs, span)
293 ExprKind::AssignOp(op, lhs, rhs) => {
294 self.check_binop_assign(expr, op, lhs, rhs, expected)
296 ExprKind::Unary(unop, oprnd) => self.check_expr_unary(unop, oprnd, expected, expr),
297 ExprKind::AddrOf(kind, mutbl, oprnd) => {
298 self.check_expr_addr_of(kind, mutbl, oprnd, expected, expr)
300 ExprKind::Path(QPath::LangItem(lang_item, _, hir_id)) => {
301 self.check_lang_item_path(lang_item, expr, hir_id)
303 ExprKind::Path(ref qpath) => self.check_expr_path(qpath, expr, &[]),
304 ExprKind::InlineAsm(asm) => {
305 // We defer some asm checks as we may not have resolved the input and output types yet (they may still be infer vars).
306 self.deferred_asm_checks.borrow_mut().push((asm, expr.hir_id));
307 self.check_expr_asm(asm)
309 ExprKind::Break(destination, ref expr_opt) => {
310 self.check_expr_break(destination, expr_opt.as_deref(), expr)
312 ExprKind::Continue(destination) => {
313 if destination.target_id.is_ok() {
316 // There was an error; make type-check fail.
320 ExprKind::Ret(ref expr_opt) => self.check_expr_return(expr_opt.as_deref(), expr),
321 ExprKind::Let(let_expr) => self.check_expr_let(let_expr),
322 ExprKind::Loop(body, _, source, _) => {
323 self.check_expr_loop(body, source, expected, expr)
325 ExprKind::Match(discrim, arms, match_src) => {
326 self.check_match(expr, &discrim, arms, expected, match_src)
328 ExprKind::Closure(closure) => self.check_expr_closure(closure, expr.span, expected),
329 ExprKind::Block(body, _) => self.check_block_with_expected(&body, expected),
330 ExprKind::Call(callee, args) => self.check_call(expr, &callee, args, expected),
331 ExprKind::MethodCall(segment, receiver, args, _) => {
332 self.check_method_call(expr, segment, receiver, args, expected)
334 ExprKind::Cast(e, t) => self.check_expr_cast(e, t, expr),
335 ExprKind::Type(e, t) => {
336 let ty = self.to_ty_saving_user_provided_ty(&t);
337 self.check_expr_eq_type(&e, ty);
340 ExprKind::If(cond, then_expr, opt_else_expr) => {
341 self.check_then_else(cond, then_expr, opt_else_expr, expr.span, expected)
343 ExprKind::DropTemps(e) => self.check_expr_with_expectation(e, expected),
344 ExprKind::Array(args) => self.check_expr_array(args, expected, expr),
345 ExprKind::ConstBlock(ref anon_const) => {
346 self.check_expr_const_block(anon_const, expected, expr)
348 ExprKind::Repeat(element, ref count) => {
349 self.check_expr_repeat(element, count, expected, expr)
351 ExprKind::Tup(elts) => self.check_expr_tuple(elts, expected, expr),
352 ExprKind::Struct(qpath, fields, ref base_expr) => {
353 self.check_expr_struct(expr, expected, qpath, fields, base_expr)
355 ExprKind::Field(base, field) => self.check_field(expr, &base, field),
356 ExprKind::Index(base, idx) => self.check_expr_index(base, idx, expr),
357 ExprKind::Yield(value, ref src) => self.check_expr_yield(value, expr, src),
358 hir::ExprKind::Err => tcx.ty_error(),
362 fn check_expr_box(&self, expr: &'tcx hir::Expr<'tcx>, expected: Expectation<'tcx>) -> Ty<'tcx> {
363 let expected_inner = expected.to_option(self).map_or(NoExpectation, |ty| match ty.kind() {
364 ty::Adt(def, _) if def.is_box() => Expectation::rvalue_hint(self, ty.boxed_ty()),
367 let referent_ty = self.check_expr_with_expectation(expr, expected_inner);
368 self.require_type_is_sized(referent_ty, expr.span, traits::SizedBoxType);
369 self.tcx.mk_box(referent_ty)
375 oprnd: &'tcx hir::Expr<'tcx>,
376 expected: Expectation<'tcx>,
377 expr: &'tcx hir::Expr<'tcx>,
380 let expected_inner = match unop {
381 hir::UnOp::Not | hir::UnOp::Neg => expected,
382 hir::UnOp::Deref => NoExpectation,
384 let mut oprnd_t = self.check_expr_with_expectation(&oprnd, expected_inner);
386 if !oprnd_t.references_error() {
387 oprnd_t = self.structurally_resolved_type(expr.span, oprnd_t);
389 hir::UnOp::Deref => {
390 if let Some(ty) = self.lookup_derefing(expr, oprnd, oprnd_t) {
393 let mut err = type_error_struct!(
398 "type `{oprnd_t}` cannot be dereferenced",
400 let sp = tcx.sess.source_map().start_point(expr.span);
402 tcx.sess.parse_sess.ambiguous_block_expr_parse.borrow().get(&sp)
404 err.subdiagnostic(ExprParenthesesNeeded::surrounding(*sp));
406 oprnd_t = tcx.ty_error_with_guaranteed(err.emit());
410 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
411 // If it's builtin, we can reuse the type, this helps inference.
412 if !(oprnd_t.is_integral() || *oprnd_t.kind() == ty::Bool) {
417 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
418 // If it's builtin, we can reuse the type, this helps inference.
419 if !oprnd_t.is_numeric() {
428 fn check_expr_addr_of(
430 kind: hir::BorrowKind,
431 mutbl: hir::Mutability,
432 oprnd: &'tcx hir::Expr<'tcx>,
433 expected: Expectation<'tcx>,
434 expr: &'tcx hir::Expr<'tcx>,
436 let hint = expected.only_has_type(self).map_or(NoExpectation, |ty| {
438 ty::Ref(_, ty, _) | ty::RawPtr(ty::TypeAndMut { ty, .. }) => {
439 if oprnd.is_syntactic_place_expr() {
440 // Places may legitimately have unsized types.
441 // For example, dereferences of a fat pointer and
442 // the last field of a struct can be unsized.
445 Expectation::rvalue_hint(self, *ty)
452 self.check_expr_with_expectation_and_needs(&oprnd, hint, Needs::maybe_mut_place(mutbl));
454 let tm = ty::TypeAndMut { ty, mutbl };
456 _ if tm.ty.references_error() => self.tcx.ty_error(),
457 hir::BorrowKind::Raw => {
458 self.check_named_place_expr(oprnd);
461 hir::BorrowKind::Ref => {
462 // Note: at this point, we cannot say what the best lifetime
463 // is to use for resulting pointer. We want to use the
464 // shortest lifetime possible so as to avoid spurious borrowck
465 // errors. Moreover, the longest lifetime will depend on the
466 // precise details of the value whose address is being taken
467 // (and how long it is valid), which we don't know yet until
468 // type inference is complete.
470 // Therefore, here we simply generate a region variable. The
471 // region inferencer will then select a suitable value.
472 // Finally, borrowck will infer the value of the region again,
473 // this time with enough precision to check that the value
474 // whose address was taken can actually be made to live as long
475 // as it needs to live.
476 let region = self.next_region_var(infer::AddrOfRegion(expr.span));
477 self.tcx.mk_ref(region, tm)
482 /// Does this expression refer to a place that either:
483 /// * Is based on a local or static.
484 /// * Contains a dereference
485 /// Note that the adjustments for the children of `expr` should already
486 /// have been resolved.
487 fn check_named_place_expr(&self, oprnd: &'tcx hir::Expr<'tcx>) {
488 let is_named = oprnd.is_place_expr(|base| {
489 // Allow raw borrows if there are any deref adjustments.
491 // const VAL: (i32,) = (0,);
492 // const REF: &(i32,) = &(0,);
494 // &raw const VAL.0; // ERROR
495 // &raw const REF.0; // OK, same as &raw const (*REF).0;
497 // This is maybe too permissive, since it allows
498 // `let u = &raw const Box::new((1,)).0`, which creates an
499 // immediately dangling raw pointer.
504 .map_or(false, |x| x.iter().any(|adj| matches!(adj.kind, Adjust::Deref(_))))
507 self.tcx.sess.emit_err(AddressOfTemporaryTaken { span: oprnd.span });
511 fn check_lang_item_path(
513 lang_item: hir::LangItem,
514 expr: &'tcx hir::Expr<'tcx>,
515 hir_id: Option<hir::HirId>,
517 self.resolve_lang_item_path(lang_item, expr.span, expr.hir_id, hir_id).1
520 pub(crate) fn check_expr_path(
522 qpath: &'tcx hir::QPath<'tcx>,
523 expr: &'tcx hir::Expr<'tcx>,
524 args: &'tcx [hir::Expr<'tcx>],
527 let (res, opt_ty, segs) =
528 self.resolve_ty_and_res_fully_qualified_call(qpath, expr.hir_id, expr.span);
532 self.tcx.sess.delay_span_bug(qpath.span(), "`Res::Err` but no error emitted");
533 self.set_tainted_by_errors(e);
534 tcx.ty_error_with_guaranteed(e)
536 Res::Def(DefKind::Variant, _) => {
537 let e = report_unexpected_variant_res(tcx, res, qpath, expr.span, "E0533", "value");
538 tcx.ty_error_with_guaranteed(e)
540 _ => self.instantiate_value_path(segs, opt_ty, res, expr.span, expr.hir_id).0,
543 if let ty::FnDef(did, ..) = *ty.kind() {
544 let fn_sig = ty.fn_sig(tcx);
545 if tcx.fn_sig(did).abi() == RustIntrinsic && tcx.item_name(did) == sym::transmute {
546 let from = fn_sig.inputs().skip_binder()[0];
547 let to = fn_sig.output().skip_binder();
548 // We defer the transmute to the end of typeck, once all inference vars have
549 // been resolved or we errored. This is important as we can only check transmute
550 // on concrete types, but the output type may not be known yet (it would only
551 // be known if explicitly specified via turbofish).
552 self.deferred_transmute_checks.borrow_mut().push((from, to, expr.hir_id));
554 if !tcx.features().unsized_fn_params {
555 // We want to remove some Sized bounds from std functions,
556 // but don't want to expose the removal to stable Rust.
557 // i.e., we don't want to allow
563 // to work in stable even if the Sized bound on `drop` is relaxed.
564 for i in 0..fn_sig.inputs().skip_binder().len() {
565 // We just want to check sizedness, so instead of introducing
566 // placeholder lifetimes with probing, we just replace higher lifetimes
568 let span = args.get(i).map(|a| a.span).unwrap_or(expr.span);
569 let input = self.replace_bound_vars_with_fresh_vars(
571 infer::LateBoundRegionConversionTime::FnCall,
574 self.require_type_is_sized_deferred(
577 traits::SizedArgumentType(None),
581 // Here we want to prevent struct constructors from returning unsized types.
582 // There were two cases this happened: fn pointer coercion in stable
583 // and usual function call in presence of unsized_locals.
584 // Also, as we just want to check sizedness, instead of introducing
585 // placeholder lifetimes with probing, we just replace higher lifetimes
587 let output = self.replace_bound_vars_with_fresh_vars(
589 infer::LateBoundRegionConversionTime::FnCall,
592 self.require_type_is_sized_deferred(output, expr.span, traits::SizedReturnType);
595 // We always require that the type provided as the value for
596 // a type parameter outlives the moment of instantiation.
597 let substs = self.typeck_results.borrow().node_substs(expr.hir_id);
598 self.add_wf_bounds(substs, expr);
605 destination: hir::Destination,
606 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
607 expr: &'tcx hir::Expr<'tcx>,
610 if let Ok(target_id) = destination.target_id {
612 if let Some(e) = expr_opt {
613 // If this is a break with a value, we need to type-check
614 // the expression. Get an expected type from the loop context.
615 let opt_coerce_to = {
616 // We should release `enclosing_breakables` before the `check_expr_with_hint`
617 // below, so can't move this block of code to the enclosing scope and share
618 // `ctxt` with the second `enclosing_breakables` borrow below.
619 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
620 match enclosing_breakables.opt_find_breakable(target_id) {
621 Some(ctxt) => ctxt.coerce.as_ref().map(|coerce| coerce.expected_ty()),
623 // Avoid ICE when `break` is inside a closure (#65383).
624 return tcx.ty_error_with_message(
626 "break was outside loop, but no error was emitted",
632 // If the loop context is not a `loop { }`, then break with
633 // a value is illegal, and `opt_coerce_to` will be `None`.
634 // Just set expectation to error in that case.
635 let coerce_to = opt_coerce_to.unwrap_or_else(|| tcx.ty_error());
637 // Recurse without `enclosing_breakables` borrowed.
638 e_ty = self.check_expr_with_hint(e, coerce_to);
639 cause = self.misc(e.span);
641 // Otherwise, this is a break *without* a value. That's
642 // always legal, and is equivalent to `break ()`.
643 e_ty = tcx.mk_unit();
644 cause = self.misc(expr.span);
647 // Now that we have type-checked `expr_opt`, borrow
648 // the `enclosing_loops` field and let's coerce the
649 // type of `expr_opt` into what is expected.
650 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
651 let Some(ctxt) = enclosing_breakables.opt_find_breakable(target_id) else {
652 // Avoid ICE when `break` is inside a closure (#65383).
653 return tcx.ty_error_with_message(
655 "break was outside loop, but no error was emitted",
659 if let Some(ref mut coerce) = ctxt.coerce {
660 if let Some(ref e) = expr_opt {
661 coerce.coerce(self, &cause, e, e_ty);
663 assert!(e_ty.is_unit());
664 let ty = coerce.expected_ty();
665 coerce.coerce_forced_unit(
669 self.suggest_mismatched_types_on_tail(
670 &mut err, expr, ty, e_ty, target_id,
672 if let Some(val) = ty_kind_suggestion(ty) {
673 let label = destination
675 .map(|l| format!(" {}", l.ident))
676 .unwrap_or_else(String::new);
679 "give it a value of the expected type",
680 format!("break{label} {val}"),
681 Applicability::HasPlaceholders,
689 // If `ctxt.coerce` is `None`, we can just ignore
690 // the type of the expression. This is because
691 // either this was a break *without* a value, in
692 // which case it is always a legal type (`()`), or
693 // else an error would have been flagged by the
694 // `loops` pass for using break with an expression
695 // where you are not supposed to.
696 assert!(expr_opt.is_none() || self.tcx.sess.has_errors().is_some());
699 // If we encountered a `break`, then (no surprise) it may be possible to break from the
700 // loop... unless the value being returned from the loop diverges itself, e.g.
701 // `break return 5` or `break loop {}`.
702 ctxt.may_break |= !self.diverges.get().is_always();
704 // the type of a `break` is always `!`, since it diverges
707 // Otherwise, we failed to find the enclosing loop;
708 // this can only happen if the `break` was not
709 // inside a loop at all, which is caught by the
710 // loop-checking pass.
711 let err = self.tcx.ty_error_with_message(
713 "break was outside loop, but no error was emitted",
716 // We still need to assign a type to the inner expression to
717 // prevent the ICE in #43162.
718 if let Some(e) = expr_opt {
719 self.check_expr_with_hint(e, err);
721 // ... except when we try to 'break rust;'.
722 // ICE this expression in particular (see #43162).
723 if let ExprKind::Path(QPath::Resolved(_, path)) = e.kind {
724 if path.segments.len() == 1 && path.segments[0].ident.name == sym::rust {
725 fatally_break_rust(self.tcx.sess);
730 // There was an error; make type-check fail.
735 fn check_expr_return(
737 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
738 expr: &'tcx hir::Expr<'tcx>,
740 if self.ret_coercion.is_none() {
741 let mut err = ReturnStmtOutsideOfFnBody {
743 encl_body_span: None,
747 let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
749 if let Some(hir::Node::Item(hir::Item {
750 kind: hir::ItemKind::Fn(..),
754 | Some(hir::Node::TraitItem(hir::TraitItem {
755 kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),
759 | Some(hir::Node::ImplItem(hir::ImplItem {
760 kind: hir::ImplItemKind::Fn(..),
763 })) = self.tcx.hir().find_by_def_id(encl_item_id.def_id)
765 // We are inside a function body, so reporting "return statement
766 // outside of function body" needs an explanation.
768 let encl_body_owner_id = self.tcx.hir().enclosing_body_owner(expr.hir_id);
770 // If this didn't hold, we would not have to report an error in
772 assert_ne!(encl_item_id.def_id, encl_body_owner_id);
774 let encl_body_id = self.tcx.hir().body_owned_by(encl_body_owner_id);
775 let encl_body = self.tcx.hir().body(encl_body_id);
777 err.encl_body_span = Some(encl_body.value.span);
778 err.encl_fn_span = Some(*encl_fn_span);
781 self.tcx.sess.emit_err(err);
783 if let Some(e) = expr_opt {
784 // We still have to type-check `e` (issue #86188), but calling
785 // `check_return_expr` only works inside fn bodies.
788 } else if let Some(e) = expr_opt {
789 if self.ret_coercion_span.get().is_none() {
790 self.ret_coercion_span.set(Some(e.span));
792 self.check_return_expr(e, true);
794 let mut coercion = self.ret_coercion.as_ref().unwrap().borrow_mut();
795 if self.ret_coercion_span.get().is_none() {
796 self.ret_coercion_span.set(Some(expr.span));
798 let cause = self.cause(expr.span, ObligationCauseCode::ReturnNoExpression);
799 if let Some((fn_decl, _)) = self.get_fn_decl(expr.hir_id) {
800 coercion.coerce_forced_unit(
804 let span = fn_decl.output.span();
805 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
808 format!("expected `{snippet}` because of this return type"),
815 coercion.coerce_forced_unit(self, &cause, &mut |_| (), true);
821 /// `explicit_return` is `true` if we're checking an explicit `return expr`,
822 /// and `false` if we're checking a trailing expression.
823 pub(super) fn check_return_expr(
825 return_expr: &'tcx hir::Expr<'tcx>,
826 explicit_return: bool,
828 let ret_coercion = self.ret_coercion.as_ref().unwrap_or_else(|| {
829 span_bug!(return_expr.span, "check_return_expr called outside fn body")
832 let ret_ty = ret_coercion.borrow().expected_ty();
833 let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty);
834 let mut span = return_expr.span;
835 // Use the span of the trailing expression for our cause,
836 // not the span of the entire function
837 if !explicit_return {
838 if let ExprKind::Block(body, _) = return_expr.kind && let Some(last_expr) = body.expr {
839 span = last_expr.span;
842 ret_coercion.borrow_mut().coerce(
844 &self.cause(span, ObligationCauseCode::ReturnValue(return_expr.hir_id)),
849 if let Some(fn_sig) = self.body_fn_sig()
850 && fn_sig.output().has_opaque_types()
852 // Point any obligations that were registered due to opaque type
853 // inference at the return expression.
854 self.select_obligations_where_possible(|errors| {
855 self.point_at_return_for_opaque_ty_error(errors, span, return_expr_ty);
860 fn point_at_return_for_opaque_ty_error(
862 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
864 return_expr_ty: Ty<'tcx>,
866 // Don't point at the whole block if it's empty
867 if span == self.tcx.hir().span(self.body_id) {
871 let cause = &mut err.obligation.cause;
872 if let ObligationCauseCode::OpaqueReturnType(None) = cause.code() {
873 let new_cause = ObligationCause::new(
876 ObligationCauseCode::OpaqueReturnType(Some((return_expr_ty, span))),
883 pub(crate) fn check_lhs_assignable(
885 lhs: &'tcx hir::Expr<'tcx>,
886 err_code: &'static str,
888 adjust_err: impl FnOnce(&mut Diagnostic),
890 if lhs.is_syntactic_place_expr() {
894 // FIXME: Make this use Diagnostic once error codes can be dynamically set.
895 let mut err = self.tcx.sess.struct_span_err_with_code(
897 "invalid left-hand side of assignment",
898 DiagnosticId::Error(err_code.into()),
900 err.span_label(lhs.span, "cannot assign to this expression");
902 self.comes_from_while_condition(lhs.hir_id, |expr| {
903 err.span_suggestion_verbose(
904 expr.span.shrink_to_lo(),
905 "you might have meant to use pattern destructuring",
907 Applicability::MachineApplicable,
911 adjust_err(&mut err);
916 // Check if an expression `original_expr_id` comes from the condition of a while loop,
917 // as opposed from the body of a while loop, which we can naively check by iterating
918 // parents until we find a loop...
919 pub(super) fn comes_from_while_condition(
921 original_expr_id: HirId,
922 then: impl FnOnce(&hir::Expr<'_>),
924 let mut parent = self.tcx.hir().get_parent_node(original_expr_id);
925 while let Some(node) = self.tcx.hir().find(parent) {
927 hir::Node::Expr(hir::Expr {
934 hir::ExprKind::Match(expr, ..) | hir::ExprKind::If(expr, ..),
940 hir::LoopSource::While,
945 // Check if our original expression is a child of the condition of a while loop
946 let expr_is_ancestor = std::iter::successors(Some(original_expr_id), |id| {
947 self.tcx.hir().find_parent_node(*id)
949 .take_while(|id| *id != parent)
950 .any(|id| id == expr.hir_id);
951 // if it is, then we have a situation like `while Some(0) = value.get(0) {`,
952 // where `while let` was more likely intended.
953 if expr_is_ancestor {
959 | hir::Node::ImplItem(_)
960 | hir::Node::TraitItem(_)
961 | hir::Node::Crate(_) => break,
963 parent = self.tcx.hir().get_parent_node(parent);
969 // A generic function for checking the 'then' and 'else' clauses in an 'if'
970 // or 'if-else' expression.
973 cond_expr: &'tcx hir::Expr<'tcx>,
974 then_expr: &'tcx hir::Expr<'tcx>,
975 opt_else_expr: Option<&'tcx hir::Expr<'tcx>>,
977 orig_expected: Expectation<'tcx>,
979 let cond_ty = self.check_expr_has_type_or_error(cond_expr, self.tcx.types.bool, |_| {});
981 self.warn_if_unreachable(
984 "block in `if` or `while` expression",
987 let cond_diverges = self.diverges.get();
988 self.diverges.set(Diverges::Maybe);
990 let expected = orig_expected.adjust_for_branches(self);
991 let then_ty = self.check_expr_with_expectation(then_expr, expected);
992 let then_diverges = self.diverges.get();
993 self.diverges.set(Diverges::Maybe);
995 // We've already taken the expected type's preferences
996 // into account when typing the `then` branch. To figure
997 // out the initial shot at a LUB, we thus only consider
998 // `expected` if it represents a *hard* constraint
999 // (`only_has_type`); otherwise, we just go with a
1000 // fresh type variable.
1001 let coerce_to_ty = expected.coercion_target_type(self, sp);
1002 let mut coerce: DynamicCoerceMany<'_> = CoerceMany::new(coerce_to_ty);
1004 coerce.coerce(self, &self.misc(sp), then_expr, then_ty);
1006 if let Some(else_expr) = opt_else_expr {
1007 let else_ty = self.check_expr_with_expectation(else_expr, expected);
1008 let else_diverges = self.diverges.get();
1010 let opt_suggest_box_span = self.opt_suggest_box_span(then_ty, else_ty, orig_expected);
1011 let if_cause = self.if_cause(
1018 opt_suggest_box_span,
1021 coerce.coerce(self, &if_cause, else_expr, else_ty);
1023 // We won't diverge unless both branches do (or the condition does).
1024 self.diverges.set(cond_diverges | then_diverges & else_diverges);
1026 self.if_fallback_coercion(sp, then_expr, &mut coerce);
1028 // If the condition is false we can't diverge.
1029 self.diverges.set(cond_diverges);
1032 let result_ty = coerce.complete(self);
1033 if cond_ty.references_error() { self.tcx.ty_error() } else { result_ty }
1036 /// Type check assignment expression `expr` of form `lhs = rhs`.
1037 /// The expected type is `()` and is passed to the function for the purposes of diagnostics.
1038 fn check_expr_assign(
1040 expr: &'tcx hir::Expr<'tcx>,
1041 expected: Expectation<'tcx>,
1042 lhs: &'tcx hir::Expr<'tcx>,
1043 rhs: &'tcx hir::Expr<'tcx>,
1046 let expected_ty = expected.coercion_target_type(self, expr.span);
1047 if expected_ty == self.tcx.types.bool {
1048 // The expected type is `bool` but this will result in `()` so we can reasonably
1049 // say that the user intended to write `lhs == rhs` instead of `lhs = rhs`.
1050 // The likely cause of this is `if foo = bar { .. }`.
1051 let actual_ty = self.tcx.mk_unit();
1052 let mut err = self.demand_suptype_diag(expr.span, expected_ty, actual_ty).unwrap();
1053 let lhs_ty = self.check_expr(&lhs);
1054 let rhs_ty = self.check_expr(&rhs);
1055 let (applicability, eq) = if self.can_coerce(rhs_ty, lhs_ty) {
1056 (Applicability::MachineApplicable, true)
1057 } else if let ExprKind::Binary(
1058 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1063 // if x == 1 && y == 2 { .. }
1065 let actual_lhs_ty = self.check_expr(&rhs_expr);
1066 (Applicability::MaybeIncorrect, self.can_coerce(rhs_ty, actual_lhs_ty))
1067 } else if let ExprKind::Binary(
1068 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1073 // if x == 1 && y == 2 { .. }
1075 let actual_rhs_ty = self.check_expr(&lhs_expr);
1076 (Applicability::MaybeIncorrect, self.can_coerce(actual_rhs_ty, lhs_ty))
1078 (Applicability::MaybeIncorrect, false)
1080 if !lhs.is_syntactic_place_expr()
1081 && lhs.is_approximately_pattern()
1082 && !matches!(lhs.kind, hir::ExprKind::Lit(_))
1084 // Do not suggest `if let x = y` as `==` is way more likely to be the intention.
1085 let hir = self.tcx.hir();
1086 if let hir::Node::Expr(hir::Expr { kind: ExprKind::If { .. }, .. }) =
1087 hir.get(hir.get_parent_node(hir.get_parent_node(expr.hir_id)))
1089 err.span_suggestion_verbose(
1090 expr.span.shrink_to_lo(),
1091 "you might have meant to use pattern matching",
1098 err.span_suggestion_verbose(
1099 span.shrink_to_hi(),
1100 "you might have meant to compare for equality",
1106 // If the assignment expression itself is ill-formed, don't
1107 // bother emitting another error
1108 let reported = err.emit_unless(lhs_ty.references_error() || rhs_ty.references_error());
1109 return self.tcx.ty_error_with_guaranteed(reported);
1112 let lhs_ty = self.check_expr_with_needs(&lhs, Needs::MutPlace);
1114 let suggest_deref_binop = |err: &mut Diagnostic, rhs_ty: Ty<'tcx>| {
1115 if let Some(lhs_deref_ty) = self.deref_once_mutably_for_diagnostic(lhs_ty) {
1116 // Can only assign if the type is sized, so if `DerefMut` yields a type that is
1117 // unsized, do not suggest dereferencing it.
1118 let lhs_deref_ty_is_sized = self
1120 .type_implements_trait(
1121 self.tcx.require_lang_item(LangItem::Sized, None),
1126 if lhs_deref_ty_is_sized && self.can_coerce(rhs_ty, lhs_deref_ty) {
1127 err.span_suggestion_verbose(
1128 lhs.span.shrink_to_lo(),
1129 "consider dereferencing here to assign to the mutably borrowed value",
1131 Applicability::MachineApplicable,
1137 // This is (basically) inlined `check_expr_coercable_to_type`, but we want
1138 // to suggest an additional fixup here in `suggest_deref_binop`.
1139 let rhs_ty = self.check_expr_with_hint(&rhs, lhs_ty);
1140 if let (_, Some(mut diag)) =
1141 self.demand_coerce_diag(rhs, rhs_ty, lhs_ty, Some(lhs), AllowTwoPhase::No)
1143 suggest_deref_binop(&mut diag, rhs_ty);
1147 self.check_lhs_assignable(lhs, "E0070", span, |err| {
1148 if let Some(rhs_ty) = self.typeck_results.borrow().expr_ty_opt(rhs) {
1149 suggest_deref_binop(err, rhs_ty);
1153 self.require_type_is_sized(lhs_ty, lhs.span, traits::AssignmentLhsSized);
1155 if lhs_ty.references_error() || rhs_ty.references_error() {
1162 pub(super) fn check_expr_let(&self, let_expr: &'tcx hir::Let<'tcx>) -> Ty<'tcx> {
1163 // for let statements, this is done in check_stmt
1164 let init = let_expr.init;
1165 self.warn_if_unreachable(init.hir_id, init.span, "block in `let` expression");
1166 // otherwise check exactly as a let statement
1167 self.check_decl(let_expr.into());
1168 // but return a bool, for this is a boolean expression
1174 body: &'tcx hir::Block<'tcx>,
1175 source: hir::LoopSource,
1176 expected: Expectation<'tcx>,
1177 expr: &'tcx hir::Expr<'tcx>,
1179 let coerce = match source {
1180 // you can only use break with a value from a normal `loop { }`
1181 hir::LoopSource::Loop => {
1182 let coerce_to = expected.coercion_target_type(self, body.span);
1183 Some(CoerceMany::new(coerce_to))
1186 hir::LoopSource::While | hir::LoopSource::ForLoop => None,
1189 let ctxt = BreakableCtxt {
1191 may_break: false, // Will get updated if/when we find a `break`.
1194 let (ctxt, ()) = self.with_breakable_ctxt(expr.hir_id, ctxt, || {
1195 self.check_block_no_value(&body);
1199 // No way to know whether it's diverging because
1200 // of a `break` or an outer `break` or `return`.
1201 self.diverges.set(Diverges::Maybe);
1204 // If we permit break with a value, then result type is
1205 // the LUB of the breaks (possibly ! if none); else, it
1206 // is nil. This makes sense because infinite loops
1207 // (which would have type !) are only possible iff we
1208 // permit break with a value [1].
1209 if ctxt.coerce.is_none() && !ctxt.may_break {
1211 self.tcx.sess.delay_span_bug(body.span, "no coercion, but loop may not break");
1213 ctxt.coerce.map(|c| c.complete(self)).unwrap_or_else(|| self.tcx.mk_unit())
1216 /// Checks a method call.
1217 fn check_method_call(
1219 expr: &'tcx hir::Expr<'tcx>,
1220 segment: &hir::PathSegment<'_>,
1221 rcvr: &'tcx hir::Expr<'tcx>,
1222 args: &'tcx [hir::Expr<'tcx>],
1223 expected: Expectation<'tcx>,
1225 let rcvr_t = self.check_expr(&rcvr);
1226 // no need to check for bot/err -- callee does that
1227 let rcvr_t = self.structurally_resolved_type(rcvr.span, rcvr_t);
1228 let span = segment.ident.span;
1230 let method = match self.lookup_method(rcvr_t, segment, span, expr, rcvr, args) {
1232 // We could add a "consider `foo::<params>`" suggestion here, but I wasn't able to
1233 // trigger this codepath causing `structurally_resolved_type` to emit an error.
1235 self.write_method_call(expr.hir_id, method);
1239 if segment.ident.name != kw::Empty {
1240 if let Some(mut err) = self.report_method_error(
1244 SelfSource::MethodCall(rcvr),
1255 // Call the generic checker.
1256 self.check_method_argument_types(span, expr, method, &args, DontTupleArguments, expected)
1261 e: &'tcx hir::Expr<'tcx>,
1262 t: &'tcx hir::Ty<'tcx>,
1263 expr: &'tcx hir::Expr<'tcx>,
1265 // Find the type of `e`. Supply hints based on the type we are casting to,
1267 let t_cast = self.to_ty_saving_user_provided_ty(t);
1268 let t_cast = self.resolve_vars_if_possible(t_cast);
1269 let t_expr = self.check_expr_with_expectation(e, ExpectCastableToType(t_cast));
1270 let t_expr = self.resolve_vars_if_possible(t_expr);
1272 // Eagerly check for some obvious errors.
1273 if t_expr.references_error() || t_cast.references_error() {
1276 // Defer other checks until we're done type checking.
1277 let mut deferred_cast_checks = self.deferred_cast_checks.borrow_mut();
1278 match cast::CastCheck::new(
1285 self.param_env.constness(),
1289 "check_expr_cast: deferring cast from {:?} to {:?}: {:?}",
1290 t_cast, t_expr, cast_check,
1292 deferred_cast_checks.push(cast_check);
1295 Err(_) => self.tcx.ty_error(),
1300 fn check_expr_array(
1302 args: &'tcx [hir::Expr<'tcx>],
1303 expected: Expectation<'tcx>,
1304 expr: &'tcx hir::Expr<'tcx>,
1306 let element_ty = if !args.is_empty() {
1307 let coerce_to = expected
1309 .and_then(|uty| match *uty.kind() {
1310 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1313 .unwrap_or_else(|| {
1314 self.next_ty_var(TypeVariableOrigin {
1315 kind: TypeVariableOriginKind::TypeInference,
1319 let mut coerce = CoerceMany::with_coercion_sites(coerce_to, args);
1320 assert_eq!(self.diverges.get(), Diverges::Maybe);
1322 let e_ty = self.check_expr_with_hint(e, coerce_to);
1323 let cause = self.misc(e.span);
1324 coerce.coerce(self, &cause, e, e_ty);
1326 coerce.complete(self)
1328 self.next_ty_var(TypeVariableOrigin {
1329 kind: TypeVariableOriginKind::TypeInference,
1333 let array_len = args.len() as u64;
1334 self.suggest_array_len(expr, array_len);
1335 self.tcx.mk_array(element_ty, array_len)
1338 fn suggest_array_len(&self, expr: &'tcx hir::Expr<'tcx>, array_len: u64) {
1339 let parent_node = self.tcx.hir().parent_iter(expr.hir_id).find(|(_, node)| {
1340 !matches!(node, hir::Node::Expr(hir::Expr { kind: hir::ExprKind::AddrOf(..), .. }))
1343 hir::Node::Local(hir::Local { ty: Some(ty), .. })
1344 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Const(ty, _), .. }))
1345 ) = parent_node else {
1348 if let hir::TyKind::Array(_, length) = ty.peel_refs().kind
1349 && let hir::ArrayLen::Body(hir::AnonConst { hir_id, .. }) = length
1350 && let Some(span) = self.tcx.hir().opt_span(hir_id)
1352 match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
1354 err.span_suggestion(
1356 "consider specifying the array length",
1358 Applicability::MaybeIncorrect,
1367 fn check_expr_const_block(
1369 anon_const: &'tcx hir::AnonConst,
1370 expected: Expectation<'tcx>,
1371 _expr: &'tcx hir::Expr<'tcx>,
1373 let body = self.tcx.hir().body(anon_const.body);
1375 // Create a new function context.
1376 let fcx = FnCtxt::new(self, self.param_env.with_const(), body.value.hir_id);
1377 crate::GatherLocalsVisitor::new(&fcx).visit_body(body);
1379 let ty = fcx.check_expr_with_expectation(&body.value, expected);
1380 fcx.require_type_is_sized(ty, body.value.span, traits::ConstSized);
1381 fcx.write_ty(anon_const.hir_id, ty);
1385 fn check_expr_repeat(
1387 element: &'tcx hir::Expr<'tcx>,
1388 count: &'tcx hir::ArrayLen,
1389 expected: Expectation<'tcx>,
1390 expr: &'tcx hir::Expr<'tcx>,
1393 let count = self.array_length_to_const(count);
1394 if let Some(count) = count.try_eval_usize(tcx, self.param_env) {
1395 self.suggest_array_len(expr, count);
1398 let uty = match expected {
1399 ExpectHasType(uty) => match *uty.kind() {
1400 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1406 let (element_ty, t) = match uty {
1408 self.check_expr_coercable_to_type(&element, uty, None);
1412 let ty = self.next_ty_var(TypeVariableOrigin {
1413 kind: TypeVariableOriginKind::MiscVariable,
1416 let element_ty = self.check_expr_has_type_or_error(&element, ty, |_| {});
1421 if element_ty.references_error() {
1422 return tcx.ty_error();
1425 self.check_repeat_element_needs_copy_bound(element, count, element_ty);
1427 tcx.mk_ty(ty::Array(t, count))
1430 fn check_repeat_element_needs_copy_bound(
1432 element: &hir::Expr<'_>,
1433 count: ty::Const<'tcx>,
1434 element_ty: Ty<'tcx>,
1437 // Actual constants as the repeat element get inserted repeatedly instead of getting copied via Copy.
1438 match &element.kind {
1439 hir::ExprKind::ConstBlock(..) => return,
1440 hir::ExprKind::Path(qpath) => {
1441 let res = self.typeck_results.borrow().qpath_res(qpath, element.hir_id);
1442 if let Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::AnonConst, _) = res
1449 // If someone calls a const fn, they can extract that call out into a separate constant (or a const
1450 // block in the future), so we check that to tell them that in the diagnostic. Does not affect typeck.
1451 let is_const_fn = match element.kind {
1452 hir::ExprKind::Call(func, _args) => match *self.node_ty(func.hir_id).kind() {
1453 ty::FnDef(def_id, _) => tcx.is_const_fn(def_id),
1459 // If the length is 0, we don't create any elements, so we don't copy any. If the length is 1, we
1460 // don't copy that one element, we move it. Only check for Copy if the length is larger.
1461 if count.try_eval_usize(tcx, self.param_env).map_or(true, |len| len > 1) {
1462 let lang_item = self.tcx.require_lang_item(LangItem::Copy, None);
1463 let code = traits::ObligationCauseCode::RepeatElementCopy { is_const_fn };
1464 self.require_type_meets(element_ty, element.span, code, lang_item);
1468 fn check_expr_tuple(
1470 elts: &'tcx [hir::Expr<'tcx>],
1471 expected: Expectation<'tcx>,
1472 expr: &'tcx hir::Expr<'tcx>,
1474 let flds = expected.only_has_type(self).and_then(|ty| {
1475 let ty = self.resolve_vars_with_obligations(ty);
1477 ty::Tuple(flds) => Some(&flds[..]),
1482 let elt_ts_iter = elts.iter().enumerate().map(|(i, e)| match flds {
1483 Some(fs) if i < fs.len() => {
1485 self.check_expr_coercable_to_type(&e, ety, None);
1488 _ => self.check_expr_with_expectation(&e, NoExpectation),
1490 let tuple = self.tcx.mk_tup(elt_ts_iter);
1491 if tuple.references_error() {
1494 self.require_type_is_sized(tuple, expr.span, traits::TupleInitializerSized);
1499 fn check_expr_struct(
1501 expr: &hir::Expr<'_>,
1502 expected: Expectation<'tcx>,
1504 fields: &'tcx [hir::ExprField<'tcx>],
1505 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1507 // Find the relevant variant
1508 let Some((variant, adt_ty)) = self.check_struct_path(qpath, expr.hir_id) else {
1509 self.check_struct_fields_on_error(fields, base_expr);
1510 return self.tcx.ty_error();
1513 // Prohibit struct expressions when non-exhaustive flag is set.
1514 let adt = adt_ty.ty_adt_def().expect("`check_struct_path` returned non-ADT type");
1515 if !adt.did().is_local() && variant.is_field_list_non_exhaustive() {
1518 .emit_err(StructExprNonExhaustive { span: expr.span, what: adt.variant_descr() });
1521 self.check_expr_struct_fields(
1532 self.require_type_is_sized(adt_ty, expr.span, traits::StructInitializerSized);
1536 fn check_expr_struct_fields(
1539 expected: Expectation<'tcx>,
1540 expr_id: hir::HirId,
1542 variant: &'tcx ty::VariantDef,
1543 ast_fields: &'tcx [hir::ExprField<'tcx>],
1544 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1549 let expected_inputs =
1550 self.expected_inputs_for_expected_output(span, expected, adt_ty, &[adt_ty]);
1551 let adt_ty_hint = if let Some(expected_inputs) = expected_inputs {
1552 expected_inputs.get(0).cloned().unwrap_or(adt_ty)
1556 // re-link the regions that EIfEO can erase.
1557 self.demand_eqtype(span, adt_ty_hint, adt_ty);
1559 let ty::Adt(adt, substs) = adt_ty.kind() else {
1560 span_bug!(span, "non-ADT passed to check_expr_struct_fields");
1562 let adt_kind = adt.adt_kind();
1564 let mut remaining_fields = variant
1568 .map(|(i, field)| (field.ident(tcx).normalize_to_macros_2_0(), (i, field)))
1569 .collect::<FxHashMap<_, _>>();
1571 let mut seen_fields = FxHashMap::default();
1573 let mut error_happened = false;
1575 // Type-check each field.
1576 for (idx, field) in ast_fields.iter().enumerate() {
1577 let ident = tcx.adjust_ident(field.ident, variant.def_id);
1578 let field_type = if let Some((i, v_field)) = remaining_fields.remove(&ident) {
1579 seen_fields.insert(ident, field.span);
1580 self.write_field_index(field.hir_id, i);
1582 // We don't look at stability attributes on
1583 // struct-like enums (yet...), but it's definitely not
1584 // a bug to have constructed one.
1585 if adt_kind != AdtKind::Enum {
1586 tcx.check_stability(v_field.did, Some(expr_id), field.span, None);
1589 self.field_ty(field.span, v_field, substs)
1591 error_happened = true;
1592 if let Some(prev_span) = seen_fields.get(&ident) {
1593 tcx.sess.emit_err(FieldMultiplySpecifiedInInitializer {
1594 span: field.ident.span,
1595 prev_span: *prev_span,
1599 self.report_unknown_field(
1604 adt.variant_descr(),
1612 // Make sure to give a type to the field even if there's
1613 // an error, so we can continue type-checking.
1614 let ty = self.check_expr_with_hint(&field.expr, field_type);
1616 self.demand_coerce_diag(&field.expr, ty, field_type, None, AllowTwoPhase::No);
1618 if let Some(mut diag) = diag {
1619 if idx == ast_fields.len() - 1 {
1620 if remaining_fields.is_empty() {
1621 self.suggest_fru_from_range(field, variant, substs, &mut diag);
1624 diag.stash(field.span, StashKey::MaybeFruTypo);
1632 // Make sure the programmer specified correct number of fields.
1633 if adt_kind == AdtKind::Union {
1634 if ast_fields.len() != 1 {
1639 "union expressions should have exactly one field",
1645 // If check_expr_struct_fields hit an error, do not attempt to populate
1646 // the fields with the base_expr. This could cause us to hit errors later
1647 // when certain fields are assumed to exist that in fact do not.
1652 if let Some(base_expr) = base_expr {
1653 // FIXME: We are currently creating two branches here in order to maintain
1654 // consistency. But they should be merged as much as possible.
1655 let fru_tys = if self.tcx.features().type_changing_struct_update {
1656 if adt.is_struct() {
1657 // Make some fresh substitutions for our ADT type.
1658 let fresh_substs = self.fresh_substs_for_item(base_expr.span, adt.did());
1659 // We do subtyping on the FRU fields first, so we can
1660 // learn exactly what types we expect the base expr
1661 // needs constrained to be compatible with the struct
1662 // type we expect from the expectation value.
1663 let fru_tys = variant
1667 let fru_ty = self.normalize_associated_types_in(
1669 self.field_ty(base_expr.span, f, fresh_substs),
1671 let ident = self.tcx.adjust_ident(f.ident(self.tcx), variant.def_id);
1672 if let Some(_) = remaining_fields.remove(&ident) {
1673 let target_ty = self.field_ty(base_expr.span, f, substs);
1674 let cause = self.misc(base_expr.span);
1675 match self.at(&cause, self.param_env).sup(target_ty, fru_ty) {
1676 Ok(InferOk { obligations, value: () }) => {
1677 self.register_predicates(obligations)
1680 // This should never happen, since we're just subtyping the
1681 // remaining_fields, but it's fine to emit this, I guess.
1683 .report_mismatched_types(
1687 FieldMisMatch(variant.name, ident.name),
1693 self.resolve_vars_if_possible(fru_ty)
1696 // The use of fresh substs that we have subtyped against
1697 // our base ADT type's fields allows us to guide inference
1698 // along so that, e.g.
1700 // MyStruct<'a, F1, F2, const C: usize> {
1702 // // Other fields that reference `'a`, `F2`, and `C`
1705 // let x = MyStruct {
1710 // will have the `other_struct` expression constrained to
1711 // `MyStruct<'a, _, F2, C>`, as opposed to just `_`...
1712 // This is important to allow coercions to happen in
1713 // `other_struct` itself. See `coerce-in-base-expr.rs`.
1714 let fresh_base_ty = self.tcx.mk_adt(*adt, fresh_substs);
1715 self.check_expr_has_type_or_error(
1717 self.resolve_vars_if_possible(fresh_base_ty),
1722 // Check the base_expr, regardless of a bad expected adt_ty, so we can get
1723 // type errors on that expression, too.
1724 self.check_expr(base_expr);
1727 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1731 self.check_expr_has_type_or_error(base_expr, adt_ty, |_| {
1732 let base_ty = self.typeck_results.borrow().expr_ty(*base_expr);
1733 let same_adt = match (adt_ty.kind(), base_ty.kind()) {
1734 (ty::Adt(adt, _), ty::Adt(base_adt, _)) if adt == base_adt => true,
1737 if self.tcx.sess.is_nightly_build() && same_adt {
1739 &self.tcx.sess.parse_sess,
1740 sym::type_changing_struct_update,
1742 "type changing struct updating is experimental",
1747 match adt_ty.kind() {
1748 ty::Adt(adt, substs) if adt.is_struct() => variant
1752 self.normalize_associated_types_in(expr_span, f.ty(self.tcx, substs))
1758 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1763 self.typeck_results.borrow_mut().fru_field_types_mut().insert(expr_id, fru_tys);
1764 } else if adt_kind != AdtKind::Union && !remaining_fields.is_empty() {
1765 debug!(?remaining_fields);
1766 let private_fields: Vec<&ty::FieldDef> = variant
1769 .filter(|field| !field.vis.is_accessible_from(tcx.parent_module(expr_id), tcx))
1772 if !private_fields.is_empty() {
1773 self.report_private_fields(adt_ty, span, private_fields, ast_fields);
1775 self.report_missing_fields(
1787 fn check_struct_fields_on_error(
1789 fields: &'tcx [hir::ExprField<'tcx>],
1790 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1792 for field in fields {
1793 self.check_expr(&field.expr);
1795 if let Some(base) = *base_expr {
1796 self.check_expr(&base);
1800 /// Report an error for a struct field expression when there are fields which aren't provided.
1803 /// error: missing field `you_can_use_this_field` in initializer of `foo::Foo`
1804 /// --> src/main.rs:8:5
1806 /// 8 | foo::Foo {};
1807 /// | ^^^^^^^^ missing `you_can_use_this_field`
1809 /// error: aborting due to previous error
1811 fn report_missing_fields(
1815 remaining_fields: FxHashMap<Ident, (usize, &ty::FieldDef)>,
1816 variant: &'tcx ty::VariantDef,
1817 ast_fields: &'tcx [hir::ExprField<'tcx>],
1818 substs: SubstsRef<'tcx>,
1820 let len = remaining_fields.len();
1822 let mut displayable_field_names: Vec<&str> =
1823 remaining_fields.keys().map(|ident| ident.as_str()).collect();
1824 // sorting &str primitives here, sort_unstable is ok
1825 displayable_field_names.sort_unstable();
1827 let mut truncated_fields_error = String::new();
1828 let remaining_fields_names = match &displayable_field_names[..] {
1829 [field1] => format!("`{}`", field1),
1830 [field1, field2] => format!("`{field1}` and `{field2}`"),
1831 [field1, field2, field3] => format!("`{field1}`, `{field2}` and `{field3}`"),
1833 truncated_fields_error =
1834 format!(" and {} other field{}", len - 3, pluralize!(len - 3));
1835 displayable_field_names
1838 .map(|n| format!("`{n}`"))
1839 .collect::<Vec<_>>()
1844 let mut err = struct_span_err!(
1848 "missing field{} {}{} in initializer of `{}`",
1850 remaining_fields_names,
1851 truncated_fields_error,
1854 err.span_label(span, format!("missing {remaining_fields_names}{truncated_fields_error}"));
1856 if let Some(last) = ast_fields.last() {
1857 self.suggest_fru_from_range(last, variant, substs, &mut err);
1863 /// If the last field is a range literal, but it isn't supposed to be, then they probably
1864 /// meant to use functional update syntax.
1865 fn suggest_fru_from_range(
1867 last_expr_field: &hir::ExprField<'tcx>,
1868 variant: &ty::VariantDef,
1869 substs: SubstsRef<'tcx>,
1870 err: &mut Diagnostic,
1872 // I don't use 'is_range_literal' because only double-sided, half-open ranges count.
1873 if let ExprKind::Struct(
1874 QPath::LangItem(LangItem::Range, ..),
1875 &[ref range_start, ref range_end],
1877 ) = last_expr_field.expr.kind
1878 && let variant_field =
1879 variant.fields.iter().find(|field| field.ident(self.tcx) == last_expr_field.ident)
1880 && let range_def_id = self.tcx.lang_items().range_struct()
1882 .and_then(|field| field.ty(self.tcx, substs).ty_adt_def())
1883 .map(|adt| adt.did())
1886 // Suppress any range expr type mismatches
1887 if let Some(mut diag) = self
1891 .steal_diagnostic(last_expr_field.span, StashKey::MaybeFruTypo)
1893 diag.delay_as_bug();
1896 // Use a (somewhat arbitrary) filtering heuristic to avoid printing
1897 // expressions that are either too long, or have control character
1898 //such as newlines in them.
1903 .span_to_snippet(range_end.expr.span)
1905 .filter(|s| s.len() < 25 && !s.contains(|c: char| c.is_control()));
1911 .span_extend_while(range_start.span, |c| c.is_whitespace())
1912 .unwrap_or(range_start.span).shrink_to_hi().to(range_end.span);
1914 err.subdiagnostic(TypeMismatchFruTypo {
1915 expr_span: range_start.span,
1922 /// Report an error for a struct field expression when there are invisible fields.
1925 /// error: cannot construct `Foo` with struct literal syntax due to private fields
1926 /// --> src/main.rs:8:5
1928 /// 8 | foo::Foo {};
1931 /// error: aborting due to previous error
1933 fn report_private_fields(
1937 private_fields: Vec<&ty::FieldDef>,
1938 used_fields: &'tcx [hir::ExprField<'tcx>],
1940 let mut err = self.tcx.sess.struct_span_err(
1943 "cannot construct `{adt_ty}` with struct literal syntax due to private fields",
1946 let (used_private_fields, remaining_private_fields): (
1947 Vec<(Symbol, Span, bool)>,
1948 Vec<(Symbol, Span, bool)>,
1952 match used_fields.iter().find(|used_field| field.name == used_field.ident.name) {
1953 Some(used_field) => (field.name, used_field.span, true),
1954 None => (field.name, self.tcx.def_span(field.did), false),
1957 .partition(|field| field.2);
1958 err.span_labels(used_private_fields.iter().map(|(_, span, _)| *span), "private field");
1959 if !remaining_private_fields.is_empty() {
1960 let remaining_private_fields_len = remaining_private_fields.len();
1961 let names = match &remaining_private_fields
1963 .map(|(name, _, _)| name)
1964 .collect::<Vec<_>>()[..]
1966 _ if remaining_private_fields_len > 6 => String::new(),
1967 [name] => format!("`{name}` "),
1968 [names @ .., last] => {
1969 let names = names.iter().map(|name| format!("`{name}`")).collect::<Vec<_>>();
1970 format!("{} and `{last}` ", names.join(", "))
1972 [] => unreachable!(),
1975 "... and other private field{s} {names}that {were} not provided",
1976 s = pluralize!(remaining_private_fields_len),
1977 were = pluralize!("was", remaining_private_fields_len),
1983 fn report_unknown_field(
1986 variant: &'tcx ty::VariantDef,
1987 field: &hir::ExprField<'_>,
1988 skip_fields: &[hir::ExprField<'_>],
1992 if variant.is_recovered() {
1993 self.set_tainted_by_errors(
1996 .delay_span_bug(expr_span, "parser recovered but no error was emitted"),
2000 let mut err = self.err_ctxt().type_error_struct_with_diag(
2002 |actual| match ty.kind() {
2003 ty::Adt(adt, ..) if adt.is_enum() => struct_span_err!(
2007 "{} `{}::{}` has no field named `{}`",
2013 _ => struct_span_err!(
2017 "{} `{}` has no field named `{}`",
2026 let variant_ident_span = self.tcx.def_ident_span(variant.def_id).unwrap();
2027 match variant.ctor_kind() {
2028 Some(CtorKind::Fn) => match ty.kind() {
2029 ty::Adt(adt, ..) if adt.is_enum() => {
2033 "`{adt}::{variant}` defined here",
2035 variant = variant.name,
2038 err.span_label(field.ident.span, "field does not exist");
2039 err.span_suggestion_verbose(
2042 "`{adt}::{variant}` is a tuple {kind_name}, use the appropriate syntax",
2044 variant = variant.name,
2047 "{adt}::{variant}(/* fields */)",
2049 variant = variant.name,
2051 Applicability::HasPlaceholders,
2055 err.span_label(variant_ident_span, format!("`{adt}` defined here", adt = ty));
2056 err.span_label(field.ident.span, "field does not exist");
2057 err.span_suggestion_verbose(
2060 "`{adt}` is a tuple {kind_name}, use the appropriate syntax",
2062 kind_name = kind_name,
2064 format!("{adt}(/* fields */)", adt = ty),
2065 Applicability::HasPlaceholders,
2070 // prevent all specified fields from being suggested
2071 let skip_fields = skip_fields.iter().map(|x| x.ident.name);
2072 if let Some(field_name) = self.suggest_field_name(
2075 skip_fields.collect(),
2078 err.span_suggestion(
2080 "a field with a similar name exists",
2082 Applicability::MaybeIncorrect,
2086 ty::Adt(adt, ..) => {
2090 format!("`{}::{}` does not have this field", ty, variant.name),
2095 format!("`{ty}` does not have this field"),
2098 let available_field_names =
2099 self.available_field_names(variant, expr_span);
2100 if !available_field_names.is_empty() {
2102 "available fields are: {}",
2103 self.name_series_display(available_field_names)
2107 _ => bug!("non-ADT passed to report_unknown_field"),
2115 // Return a hint about the closest match in field names
2116 fn suggest_field_name(
2118 variant: &'tcx ty::VariantDef,
2121 // The span where stability will be checked
2123 ) -> Option<Symbol> {
2127 .filter_map(|field| {
2128 // ignore already set fields and private fields from non-local crates
2129 // and unstable fields.
2130 if skip.iter().any(|&x| x == field.name)
2131 || (!variant.def_id.is_local() && !field.vis.is_public())
2133 self.tcx.eval_stability(field.did, None, span, None),
2134 stability::EvalResult::Deny { .. }
2142 .collect::<Vec<Symbol>>();
2144 find_best_match_for_name(&names, field, None)
2147 fn available_field_names(
2149 variant: &'tcx ty::VariantDef,
2156 let def_scope = self
2158 .adjust_ident_and_get_scope(field.ident(self.tcx), variant.def_id, self.body_id)
2160 field.vis.is_accessible_from(def_scope, self.tcx)
2162 self.tcx.eval_stability(field.did, None, access_span, None),
2163 stability::EvalResult::Deny { .. }
2166 .filter(|field| !self.tcx.is_doc_hidden(field.did))
2167 .map(|field| field.name)
2171 fn name_series_display(&self, names: Vec<Symbol>) -> String {
2172 // dynamic limit, to never omit just one field
2173 let limit = if names.len() == 6 { 6 } else { 5 };
2175 names.iter().take(limit).map(|n| format!("`{}`", n)).collect::<Vec<_>>().join(", ");
2176 if names.len() > limit {
2177 display = format!("{} ... and {} others", display, names.len() - limit);
2182 // Check field access expressions
2185 expr: &'tcx hir::Expr<'tcx>,
2186 base: &'tcx hir::Expr<'tcx>,
2189 debug!("check_field(expr: {:?}, base: {:?}, field: {:?})", expr, base, field);
2190 let base_ty = self.check_expr(base);
2191 let base_ty = self.structurally_resolved_type(base.span, base_ty);
2192 let mut private_candidate = None;
2193 let mut autoderef = self.autoderef(expr.span, base_ty);
2194 while let Some((deref_base_ty, _)) = autoderef.next() {
2195 debug!("deref_base_ty: {:?}", deref_base_ty);
2196 match deref_base_ty.kind() {
2197 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2198 debug!("struct named {:?}", deref_base_ty);
2199 let (ident, def_scope) =
2200 self.tcx.adjust_ident_and_get_scope(field, base_def.did(), self.body_id);
2201 let fields = &base_def.non_enum_variant().fields;
2202 if let Some(index) = fields
2204 .position(|f| f.ident(self.tcx).normalize_to_macros_2_0() == ident)
2206 let field = &fields[index];
2207 let field_ty = self.field_ty(expr.span, field, substs);
2208 // Save the index of all fields regardless of their visibility in case
2209 // of error recovery.
2210 self.write_field_index(expr.hir_id, index);
2211 let adjustments = self.adjust_steps(&autoderef);
2212 if field.vis.is_accessible_from(def_scope, self.tcx) {
2213 self.apply_adjustments(base, adjustments);
2214 self.register_predicates(autoderef.into_obligations());
2216 self.tcx.check_stability(field.did, Some(expr.hir_id), expr.span, None);
2219 private_candidate = Some((adjustments, base_def.did(), field_ty));
2223 let fstr = field.as_str();
2224 if let Ok(index) = fstr.parse::<usize>() {
2225 if fstr == index.to_string() {
2226 if let Some(&field_ty) = tys.get(index) {
2227 let adjustments = self.adjust_steps(&autoderef);
2228 self.apply_adjustments(base, adjustments);
2229 self.register_predicates(autoderef.into_obligations());
2231 self.write_field_index(expr.hir_id, index);
2240 self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
2242 if let Some((adjustments, did, field_ty)) = private_candidate {
2243 // (#90483) apply adjustments to avoid ExprUseVisitor from
2244 // creating erroneous projection.
2245 self.apply_adjustments(base, adjustments);
2246 self.ban_private_field_access(expr, base_ty, field, did);
2250 if field.name == kw::Empty {
2251 } else if self.method_exists(field, base_ty, expr.hir_id, true) {
2252 self.ban_take_value_of_method(expr, base_ty, field);
2253 } else if !base_ty.is_primitive_ty() {
2254 self.ban_nonexisting_field(field, base, expr, base_ty);
2256 let field_name = field.to_string();
2257 let mut err = type_error_struct!(
2262 "`{base_ty}` is a primitive type and therefore doesn't have fields",
2264 let is_valid_suffix = |field: &str| {
2265 if field == "f32" || field == "f64" {
2268 let mut chars = field.chars().peekable();
2269 match chars.peek() {
2270 Some('e') | Some('E') => {
2272 if let Some(c) = chars.peek()
2273 && !c.is_numeric() && *c != '-' && *c != '+'
2277 while let Some(c) = chars.peek() {
2278 if !c.is_numeric() {
2286 let suffix = chars.collect::<String>();
2287 suffix.is_empty() || suffix == "f32" || suffix == "f64"
2289 let maybe_partial_suffix = |field: &str| -> Option<&str> {
2290 let first_chars = ['f', 'l'];
2292 && field.to_lowercase().starts_with(first_chars)
2293 && field[1..].chars().all(|c| c.is_ascii_digit())
2295 if field.to_lowercase().starts_with(['f']) { Some("f32") } else { Some("f64") }
2300 if let ty::Infer(ty::IntVar(_)) = base_ty.kind()
2301 && let ExprKind::Lit(Spanned {
2302 node: ast::LitKind::Int(_, ast::LitIntType::Unsuffixed),
2305 && !base.span.from_expansion()
2307 if is_valid_suffix(&field_name) {
2308 err.span_suggestion_verbose(
2309 field.span.shrink_to_lo(),
2310 "if intended to be a floating point literal, consider adding a `0` after the period",
2312 Applicability::MaybeIncorrect,
2314 } else if let Some(correct_suffix) = maybe_partial_suffix(&field_name) {
2315 err.span_suggestion_verbose(
2317 format!("if intended to be a floating point literal, consider adding a `0` after the period and a `{correct_suffix}` suffix"),
2318 format!("0{correct_suffix}"),
2319 Applicability::MaybeIncorrect,
2326 self.tcx().ty_error()
2329 fn suggest_await_on_field_access(
2331 err: &mut Diagnostic,
2333 base: &'tcx hir::Expr<'tcx>,
2336 let output_ty = match self.get_impl_future_output_ty(ty) {
2337 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
2340 let mut add_label = true;
2341 if let ty::Adt(def, _) = output_ty.skip_binder().kind() {
2342 // no field access on enum type
2348 .any(|field| field.ident(self.tcx) == field_ident)
2353 "field not available in `impl Future`, but it is available in its `Output`",
2355 err.span_suggestion_verbose(
2356 base.span.shrink_to_hi(),
2357 "consider `await`ing on the `Future` and access the field of its `Output`",
2359 Applicability::MaybeIncorrect,
2365 err.span_label(field_ident.span, &format!("field not found in `{ty}`"));
2369 fn ban_nonexisting_field(
2372 base: &'tcx hir::Expr<'tcx>,
2373 expr: &'tcx hir::Expr<'tcx>,
2377 "ban_nonexisting_field: field={:?}, base={:?}, expr={:?}, base_ty={:?}",
2378 ident, base, expr, base_ty
2380 let mut err = self.no_such_field_err(ident, base_ty, base.hir_id);
2382 match *base_ty.peel_refs().kind() {
2383 ty::Array(_, len) => {
2384 self.maybe_suggest_array_indexing(&mut err, expr, base, ident, len);
2387 self.suggest_first_deref_field(&mut err, expr, base, ident);
2389 ty::Adt(def, _) if !def.is_enum() => {
2390 self.suggest_fields_on_recordish(&mut err, def, ident, expr.span);
2392 ty::Param(param_ty) => {
2393 self.point_at_param_definition(&mut err, param_ty);
2395 ty::Opaque(_, _) => {
2396 self.suggest_await_on_field_access(&mut err, ident, base, base_ty.peel_refs());
2401 self.suggest_fn_call(&mut err, base, base_ty, |output_ty| {
2402 if let ty::Adt(def, _) = output_ty.kind() && !def.is_enum() {
2403 def.non_enum_variant().fields.iter().any(|field| {
2404 field.ident(self.tcx) == ident
2405 && field.vis.is_accessible_from(expr.hir_id.owner.def_id, self.tcx)
2407 } else if let ty::Tuple(tys) = output_ty.kind()
2408 && let Ok(idx) = ident.as_str().parse::<usize>()
2416 if ident.name == kw::Await {
2417 // We know by construction that `<expr>.await` is either on Rust 2015
2418 // or results in `ExprKind::Await`. Suggest switching the edition to 2018.
2419 err.note("to `.await` a `Future`, switch to Rust 2018 or later");
2420 err.help_use_latest_edition();
2426 fn ban_private_field_access(
2428 expr: &hir::Expr<'_>,
2433 let struct_path = self.tcx().def_path_str(base_did);
2434 let kind_name = self.tcx().def_kind(base_did).descr(base_did);
2435 let mut err = struct_span_err!(
2439 "field `{field}` of {kind_name} `{struct_path}` is private",
2441 err.span_label(field.span, "private field");
2442 // Also check if an accessible method exists, which is often what is meant.
2443 if self.method_exists(field, expr_t, expr.hir_id, false) && !self.expr_in_place(expr.hir_id)
2445 self.suggest_method_call(
2447 &format!("a method `{field}` also exists, call it with parentheses"),
2457 fn ban_take_value_of_method(&self, expr: &hir::Expr<'_>, expr_t: Ty<'tcx>, field: Ident) {
2458 let mut err = type_error_struct!(
2463 "attempted to take value of method `{field}` on type `{expr_t}`",
2465 err.span_label(field.span, "method, not a field");
2467 if let hir::Node::Expr(hir::Expr { kind: ExprKind::Call(callee, _args), .. }) =
2468 self.tcx.hir().get(self.tcx.hir().get_parent_node(expr.hir_id))
2470 expr.hir_id == callee.hir_id
2475 self.tcx.sess.source_map().span_to_snippet(expr.span).unwrap_or_default();
2476 let is_wrapped = expr_snippet.starts_with('(') && expr_snippet.ends_with(')');
2477 let after_open = expr.span.lo() + rustc_span::BytePos(1);
2478 let before_close = expr.span.hi() - rustc_span::BytePos(1);
2480 if expr_is_call && is_wrapped {
2481 err.multipart_suggestion(
2482 "remove wrapping parentheses to call the method",
2484 (expr.span.with_hi(after_open), String::new()),
2485 (expr.span.with_lo(before_close), String::new()),
2487 Applicability::MachineApplicable,
2489 } else if !self.expr_in_place(expr.hir_id) {
2490 // Suggest call parentheses inside the wrapping parentheses
2491 let span = if is_wrapped {
2492 expr.span.with_lo(after_open).with_hi(before_close)
2496 self.suggest_method_call(
2498 "use parentheses to call the method",
2504 } else if let ty::RawPtr(ty_and_mut) = expr_t.kind()
2505 && let ty::Adt(adt_def, _) = ty_and_mut.ty.kind()
2506 && let ExprKind::Field(base_expr, _) = expr.kind
2507 && adt_def.variants().len() == 1
2515 .any(|f| f.ident(self.tcx) == field)
2517 err.multipart_suggestion(
2518 "to access the field, dereference first",
2520 (base_expr.span.shrink_to_lo(), "(*".to_string()),
2521 (base_expr.span.shrink_to_hi(), ")".to_string()),
2523 Applicability::MaybeIncorrect,
2526 err.help("methods are immutable and cannot be assigned to");
2532 fn point_at_param_definition(&self, err: &mut Diagnostic, param: ty::ParamTy) {
2533 let generics = self.tcx.generics_of(self.body_id.owner.to_def_id());
2534 let generic_param = generics.type_param(¶m, self.tcx);
2535 if let ty::GenericParamDefKind::Type { synthetic: true, .. } = generic_param.kind {
2538 let param_def_id = generic_param.def_id;
2539 let param_hir_id = match param_def_id.as_local() {
2540 Some(x) => self.tcx.hir().local_def_id_to_hir_id(x),
2543 let param_span = self.tcx.hir().span(param_hir_id);
2544 let param_name = self.tcx.hir().ty_param_name(param_def_id.expect_local());
2546 err.span_label(param_span, &format!("type parameter '{param_name}' declared here"));
2549 fn suggest_fields_on_recordish(
2551 err: &mut Diagnostic,
2552 def: ty::AdtDef<'tcx>,
2556 if let Some(suggested_field_name) =
2557 self.suggest_field_name(def.non_enum_variant(), field.name, vec![], access_span)
2559 err.span_suggestion(
2561 "a field with a similar name exists",
2562 suggested_field_name,
2563 Applicability::MaybeIncorrect,
2566 err.span_label(field.span, "unknown field");
2567 let struct_variant_def = def.non_enum_variant();
2568 let field_names = self.available_field_names(struct_variant_def, access_span);
2569 if !field_names.is_empty() {
2571 "available fields are: {}",
2572 self.name_series_display(field_names),
2578 fn maybe_suggest_array_indexing(
2580 err: &mut Diagnostic,
2581 expr: &hir::Expr<'_>,
2582 base: &hir::Expr<'_>,
2584 len: ty::Const<'tcx>,
2586 if let (Some(len), Ok(user_index)) =
2587 (len.try_eval_usize(self.tcx, self.param_env), field.as_str().parse::<u64>())
2588 && let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
2590 let help = "instead of using tuple indexing, use array indexing";
2591 let suggestion = format!("{base}[{field}]");
2592 let applicability = if len < user_index {
2593 Applicability::MachineApplicable
2595 Applicability::MaybeIncorrect
2597 err.span_suggestion(expr.span, help, suggestion, applicability);
2601 fn suggest_first_deref_field(
2603 err: &mut Diagnostic,
2604 expr: &hir::Expr<'_>,
2605 base: &hir::Expr<'_>,
2608 if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span) {
2609 let msg = format!("`{base}` is a raw pointer; try dereferencing it");
2610 let suggestion = format!("(*{base}).{field}");
2611 err.span_suggestion(expr.span, &msg, suggestion, Applicability::MaybeIncorrect);
2615 fn no_such_field_err(
2620 ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
2621 let span = field.span;
2622 debug!("no_such_field_err(span: {:?}, field: {:?}, expr_t: {:?})", span, field, expr_t);
2624 let mut err = type_error_struct!(
2629 "no field `{field}` on type `{expr_t}`",
2632 // try to add a suggestion in case the field is a nested field of a field of the Adt
2633 let mod_id = self.tcx.parent_module(id).to_def_id();
2634 if let Some((fields, substs)) =
2635 self.get_field_candidates_considering_privacy(span, expr_t, mod_id)
2637 let candidate_fields: Vec<_> = fields
2638 .filter_map(|candidate_field| {
2639 self.check_for_nested_field_satisfying(
2641 &|candidate_field, _| candidate_field.ident(self.tcx()) == field,
2648 .map(|mut field_path| {
2652 .map(|id| id.name.to_ident_string())
2653 .collect::<Vec<String>>()
2656 .collect::<Vec<_>>();
2658 let len = candidate_fields.len();
2660 err.span_suggestions(
2661 field.span.shrink_to_lo(),
2663 "{} of the expressions' fields {} a field of the same name",
2664 if len > 1 { "some" } else { "one" },
2665 if len > 1 { "have" } else { "has" },
2667 candidate_fields.iter().map(|path| format!("{path}.")),
2668 Applicability::MaybeIncorrect,
2675 pub(crate) fn get_field_candidates_considering_privacy(
2680 ) -> Option<(impl Iterator<Item = &'tcx ty::FieldDef> + 'tcx, SubstsRef<'tcx>)> {
2681 debug!("get_field_candidates(span: {:?}, base_t: {:?}", span, base_ty);
2683 for (base_t, _) in self.autoderef(span, base_ty) {
2684 match base_t.kind() {
2685 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2687 let fields = &base_def.non_enum_variant().fields;
2688 // Some struct, e.g. some that impl `Deref`, have all private fields
2689 // because you're expected to deref them to access the _real_ fields.
2690 // This, for example, will help us suggest accessing a field through a `Box<T>`.
2691 if fields.iter().all(|field| !field.vis.is_accessible_from(mod_id, tcx)) {
2697 .filter(move |field| field.vis.is_accessible_from(mod_id, tcx))
2698 // For compile-time reasons put a limit on number of fields we search
2709 /// This method is called after we have encountered a missing field error to recursively
2710 /// search for the field
2711 pub(crate) fn check_for_nested_field_satisfying(
2714 matches: &impl Fn(&ty::FieldDef, Ty<'tcx>) -> bool,
2715 candidate_field: &ty::FieldDef,
2716 subst: SubstsRef<'tcx>,
2717 mut field_path: Vec<Ident>,
2719 ) -> Option<Vec<Ident>> {
2721 "check_for_nested_field_satisfying(span: {:?}, candidate_field: {:?}, field_path: {:?}",
2722 span, candidate_field, field_path
2725 if field_path.len() > 3 {
2726 // For compile-time reasons and to avoid infinite recursion we only check for fields
2727 // up to a depth of three
2730 field_path.push(candidate_field.ident(self.tcx).normalize_to_macros_2_0());
2731 let field_ty = candidate_field.ty(self.tcx, subst);
2732 if matches(candidate_field, field_ty) {
2733 return Some(field_path);
2734 } else if let Some((nested_fields, subst)) =
2735 self.get_field_candidates_considering_privacy(span, field_ty, mod_id)
2737 // recursively search fields of `candidate_field` if it's a ty::Adt
2738 for field in nested_fields {
2739 if let Some(field_path) = self.check_for_nested_field_satisfying(
2747 return Some(field_path);
2755 fn check_expr_index(
2757 base: &'tcx hir::Expr<'tcx>,
2758 idx: &'tcx hir::Expr<'tcx>,
2759 expr: &'tcx hir::Expr<'tcx>,
2761 let base_t = self.check_expr(&base);
2762 let idx_t = self.check_expr(&idx);
2764 if base_t.references_error() {
2766 } else if idx_t.references_error() {
2769 let base_t = self.structurally_resolved_type(base.span, base_t);
2770 match self.lookup_indexing(expr, base, base_t, idx, idx_t) {
2771 Some((index_ty, element_ty)) => {
2772 // two-phase not needed because index_ty is never mutable
2773 self.demand_coerce(idx, idx_t, index_ty, None, AllowTwoPhase::No);
2774 self.select_obligations_where_possible(|errors| {
2775 self.point_at_index_if_possible(errors, idx.span)
2780 let mut err = type_error_struct!(
2785 "cannot index into a value of type `{base_t}`",
2787 // Try to give some advice about indexing tuples.
2788 if let ty::Tuple(..) = base_t.kind() {
2789 let mut needs_note = true;
2790 // If the index is an integer, we can show the actual
2791 // fixed expression:
2792 if let ExprKind::Lit(ref lit) = idx.kind {
2793 if let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node {
2794 let snip = self.tcx.sess.source_map().span_to_snippet(base.span);
2795 if let Ok(snip) = snip {
2796 err.span_suggestion(
2798 "to access tuple elements, use",
2799 format!("{snip}.{i}"),
2800 Applicability::MachineApplicable,
2808 "to access tuple elements, use tuple indexing \
2809 syntax (e.g., `tuple.0`)",
2813 let reported = err.emit();
2814 self.tcx.ty_error_with_guaranteed(reported)
2820 fn point_at_index_if_possible(
2822 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
2825 for error in errors {
2826 match error.obligation.predicate.kind().skip_binder() {
2827 ty::PredicateKind::Trait(predicate)
2828 if self.tcx.is_diagnostic_item(sym::SliceIndex, predicate.trait_ref.def_id) => {
2832 error.obligation.cause.span = span;
2836 fn check_expr_yield(
2838 value: &'tcx hir::Expr<'tcx>,
2839 expr: &'tcx hir::Expr<'tcx>,
2840 src: &'tcx hir::YieldSource,
2842 match self.resume_yield_tys {
2843 Some((resume_ty, yield_ty)) => {
2844 self.check_expr_coercable_to_type(&value, yield_ty, None);
2848 // Given that this `yield` expression was generated as a result of lowering a `.await`,
2849 // we know that the yield type must be `()`; however, the context won't contain this
2850 // information. Hence, we check the source of the yield expression here and check its
2851 // value's type against `()` (this check should always hold).
2852 None if src.is_await() => {
2853 self.check_expr_coercable_to_type(&value, self.tcx.mk_unit(), None);
2857 self.tcx.sess.emit_err(YieldExprOutsideOfGenerator { span: expr.span });
2858 // Avoid expressions without types during writeback (#78653).
2859 self.check_expr(value);
2865 fn check_expr_asm_operand(&self, expr: &'tcx hir::Expr<'tcx>, is_input: bool) {
2866 let needs = if is_input { Needs::None } else { Needs::MutPlace };
2867 let ty = self.check_expr_with_needs(expr, needs);
2868 self.require_type_is_sized(ty, expr.span, traits::InlineAsmSized);
2870 if !is_input && !expr.is_syntactic_place_expr() {
2871 let mut err = self.tcx.sess.struct_span_err(expr.span, "invalid asm output");
2872 err.span_label(expr.span, "cannot assign to this expression");
2876 // If this is an input value, we require its type to be fully resolved
2877 // at this point. This allows us to provide helpful coercions which help
2878 // pass the type candidate list in a later pass.
2880 // We don't require output types to be resolved at this point, which
2881 // allows them to be inferred based on how they are used later in the
2884 let ty = self.structurally_resolved_type(expr.span, ty);
2887 let fnptr_ty = self.tcx.mk_fn_ptr(ty.fn_sig(self.tcx));
2888 self.demand_coerce(expr, ty, fnptr_ty, None, AllowTwoPhase::No);
2890 ty::Ref(_, base_ty, mutbl) => {
2891 let ptr_ty = self.tcx.mk_ptr(ty::TypeAndMut { ty: base_ty, mutbl });
2892 self.demand_coerce(expr, ty, ptr_ty, None, AllowTwoPhase::No);
2899 fn check_expr_asm(&self, asm: &'tcx hir::InlineAsm<'tcx>) -> Ty<'tcx> {
2900 for (op, _op_sp) in asm.operands {
2902 hir::InlineAsmOperand::In { expr, .. } => {
2903 self.check_expr_asm_operand(expr, true);
2905 hir::InlineAsmOperand::Out { expr: Some(expr), .. }
2906 | hir::InlineAsmOperand::InOut { expr, .. } => {
2907 self.check_expr_asm_operand(expr, false);
2909 hir::InlineAsmOperand::Out { expr: None, .. } => {}
2910 hir::InlineAsmOperand::SplitInOut { in_expr, out_expr, .. } => {
2911 self.check_expr_asm_operand(in_expr, true);
2912 if let Some(out_expr) = out_expr {
2913 self.check_expr_asm_operand(out_expr, false);
2916 // `AnonConst`s have their own body and is type-checked separately.
2917 // As they don't flow into the type system we don't need them to
2919 hir::InlineAsmOperand::Const { .. } | hir::InlineAsmOperand::SymFn { .. } => {}
2920 hir::InlineAsmOperand::SymStatic { .. } => {}
2923 if asm.options.contains(ast::InlineAsmOptions::NORETURN) {
2924 self.tcx.types.never