1 //! Type checking expressions.
3 //! See `mod.rs` for more context on type checking in general.
6 use crate::coercion::CoerceMany;
7 use crate::coercion::DynamicCoerceMany;
8 use crate::errors::{AddressOfTemporaryTaken, ReturnStmtOutsideOfFnBody, StructExprNonExhaustive};
10 FieldMultiplySpecifiedInInitializer, FunctionalRecordUpdateOnNonStruct,
11 YieldExprOutsideOfGenerator,
13 use crate::fatally_break_rust;
14 use crate::method::SelfSource;
15 use crate::type_error_struct;
16 use crate::Expectation::{self, ExpectCastableToType, ExpectHasType, NoExpectation};
18 report_unexpected_variant_res, BreakableCtxt, Diverges, FnCtxt, Needs,
19 TupleArgumentsFlag::DontTupleArguments,
22 use rustc_data_structures::fx::FxHashMap;
23 use rustc_data_structures::stack::ensure_sufficient_stack;
25 pluralize, struct_span_err, Applicability, Diagnostic, DiagnosticBuilder, DiagnosticId,
26 ErrorGuaranteed, StashKey,
29 use rustc_hir::def::{CtorKind, DefKind, Res};
30 use rustc_hir::def_id::DefId;
31 use rustc_hir::intravisit::Visitor;
32 use rustc_hir::lang_items::LangItem;
33 use rustc_hir::{Closure, ExprKind, HirId, QPath};
34 use rustc_hir_analysis::astconv::AstConv as _;
35 use rustc_hir_analysis::check::ty_kind_suggestion;
36 use rustc_infer::infer;
37 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
38 use rustc_infer::infer::InferOk;
39 use rustc_infer::traits::ObligationCause;
40 use rustc_middle::middle::stability;
41 use rustc_middle::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase};
42 use rustc_middle::ty::error::TypeError::FieldMisMatch;
43 use rustc_middle::ty::subst::SubstsRef;
44 use rustc_middle::ty::{self, AdtKind, Ty, TypeVisitable};
45 use rustc_session::errors::ExprParenthesesNeeded;
46 use rustc_session::parse::feature_err;
47 use rustc_span::hygiene::DesugaringKind;
48 use rustc_span::lev_distance::find_best_match_for_name;
49 use rustc_span::source_map::{Span, Spanned};
50 use rustc_span::symbol::{kw, sym, Ident, Symbol};
51 use rustc_target::spec::abi::Abi::RustIntrinsic;
52 use rustc_trait_selection::infer::InferCtxtExt;
53 use rustc_trait_selection::traits::{self, ObligationCauseCode};
55 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
56 fn check_expr_eq_type(&self, expr: &'tcx hir::Expr<'tcx>, expected: Ty<'tcx>) {
57 let ty = self.check_expr_with_hint(expr, expected);
58 self.demand_eqtype(expr.span, expected, ty);
61 pub fn check_expr_has_type_or_error(
63 expr: &'tcx hir::Expr<'tcx>,
65 extend_err: impl FnMut(&mut Diagnostic),
67 self.check_expr_meets_expectation_or_error(expr, ExpectHasType(expected), extend_err)
70 fn check_expr_meets_expectation_or_error(
72 expr: &'tcx hir::Expr<'tcx>,
73 expected: Expectation<'tcx>,
74 mut extend_err: impl FnMut(&mut Diagnostic),
76 let expected_ty = expected.to_option(&self).unwrap_or(self.tcx.types.bool);
77 let mut ty = self.check_expr_with_expectation(expr, expected);
79 // While we don't allow *arbitrary* coercions here, we *do* allow
80 // coercions from ! to `expected`.
82 if let Some(adjustments) = self.typeck_results.borrow().adjustments().get(expr.hir_id) {
83 self.tcx().sess.delay_span_bug(
85 "expression with never type wound up being adjusted",
87 return if let [Adjustment { kind: Adjust::NeverToAny, target }] = &adjustments[..] {
94 let adj_ty = self.next_ty_var(TypeVariableOrigin {
95 kind: TypeVariableOriginKind::AdjustmentType,
98 self.apply_adjustments(
100 vec![Adjustment { kind: Adjust::NeverToAny, target: adj_ty }],
105 if let Some(mut err) = self.demand_suptype_diag(expr.span, expected_ty, ty) {
106 let expr = expr.peel_drop_temps();
107 self.suggest_deref_ref_or_into(&mut err, expr, expected_ty, ty, None);
108 extend_err(&mut err);
114 pub(super) fn check_expr_coercable_to_type(
116 expr: &'tcx hir::Expr<'tcx>,
118 expected_ty_expr: Option<&'tcx hir::Expr<'tcx>>,
120 let ty = self.check_expr_with_hint(expr, expected);
121 // checks don't need two phase
122 self.demand_coerce(expr, ty, expected, expected_ty_expr, AllowTwoPhase::No)
125 pub(super) fn check_expr_with_hint(
127 expr: &'tcx hir::Expr<'tcx>,
130 self.check_expr_with_expectation(expr, ExpectHasType(expected))
133 fn check_expr_with_expectation_and_needs(
135 expr: &'tcx hir::Expr<'tcx>,
136 expected: Expectation<'tcx>,
139 let ty = self.check_expr_with_expectation(expr, expected);
141 // If the expression is used in a place whether mutable place is required
142 // e.g. LHS of assignment, perform the conversion.
143 if let Needs::MutPlace = needs {
144 self.convert_place_derefs_to_mutable(expr);
150 pub(super) fn check_expr(&self, expr: &'tcx hir::Expr<'tcx>) -> Ty<'tcx> {
151 self.check_expr_with_expectation(expr, NoExpectation)
154 pub(super) fn check_expr_with_needs(
156 expr: &'tcx hir::Expr<'tcx>,
159 self.check_expr_with_expectation_and_needs(expr, NoExpectation, needs)
163 /// If an expression has any sub-expressions that result in a type error,
164 /// inspecting that expression's type with `ty.references_error()` will return
165 /// true. Likewise, if an expression is known to diverge, inspecting its
166 /// type with `ty::type_is_bot` will return true (n.b.: since Rust is
167 /// strict, _|_ can appear in the type of an expression that does not,
168 /// itself, diverge: for example, fn() -> _|_.)
169 /// Note that inspecting a type's structure *directly* may expose the fact
170 /// that there are actually multiple representations for `Error`, so avoid
171 /// that when err needs to be handled differently.
172 #[instrument(skip(self, expr), level = "debug")]
173 pub(super) fn check_expr_with_expectation(
175 expr: &'tcx hir::Expr<'tcx>,
176 expected: Expectation<'tcx>,
178 self.check_expr_with_expectation_and_args(expr, expected, &[])
181 /// Same as `check_expr_with_expectation`, but allows us to pass in the arguments of a
182 /// `ExprKind::Call` when evaluating its callee when it is an `ExprKind::Path`.
183 pub(super) fn check_expr_with_expectation_and_args(
185 expr: &'tcx hir::Expr<'tcx>,
186 expected: Expectation<'tcx>,
187 args: &'tcx [hir::Expr<'tcx>],
189 if self.tcx().sess.verbose() {
190 // make this code only run with -Zverbose because it is probably slow
191 if let Ok(lint_str) = self.tcx.sess.source_map().span_to_snippet(expr.span) {
192 if !lint_str.contains('\n') {
193 debug!("expr text: {lint_str}");
195 let mut lines = lint_str.lines();
196 if let Some(line0) = lines.next() {
197 let remaining_lines = lines.count();
198 debug!("expr text: {line0}");
199 debug!("expr text: ...(and {remaining_lines} more lines)");
205 // True if `expr` is a `Try::from_ok(())` that is a result of desugaring a try block
206 // without the final expr (e.g. `try { return; }`). We don't want to generate an
207 // unreachable_code lint for it since warnings for autogenerated code are confusing.
208 let is_try_block_generated_unit_expr = match expr.kind {
209 ExprKind::Call(_, args) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {
210 args.len() == 1 && args[0].span.is_desugaring(DesugaringKind::TryBlock)
216 // Warn for expressions after diverging siblings.
217 if !is_try_block_generated_unit_expr {
218 self.warn_if_unreachable(expr.hir_id, expr.span, "expression");
221 // Hide the outer diverging and has_errors flags.
222 let old_diverges = self.diverges.replace(Diverges::Maybe);
223 let old_has_errors = self.has_errors.replace(false);
225 let ty = ensure_sufficient_stack(|| match &expr.kind {
227 qpath @ hir::QPath::Resolved(..) | qpath @ hir::QPath::TypeRelative(..),
228 ) => self.check_expr_path(qpath, expr, args),
229 _ => self.check_expr_kind(expr, expected),
232 // Warn for non-block expressions with diverging children.
238 | ExprKind::Match(..) => {}
239 // If `expr` is a result of desugaring the try block and is an ok-wrapped
240 // diverging expression (e.g. it arose from desugaring of `try { return }`),
241 // we skip issuing a warning because it is autogenerated code.
242 ExprKind::Call(..) if expr.span.is_desugaring(DesugaringKind::TryBlock) => {}
243 ExprKind::Call(callee, _) => self.warn_if_unreachable(expr.hir_id, callee.span, "call"),
244 ExprKind::MethodCall(segment, ..) => {
245 self.warn_if_unreachable(expr.hir_id, segment.ident.span, "call")
247 _ => self.warn_if_unreachable(expr.hir_id, expr.span, "expression"),
250 // Any expression that produces a value of type `!` must have diverged
252 self.diverges.set(self.diverges.get() | Diverges::always(expr.span));
255 // Record the type, which applies it effects.
256 // We need to do this after the warning above, so that
257 // we don't warn for the diverging expression itself.
258 self.write_ty(expr.hir_id, ty);
260 // Combine the diverging and has_error flags.
261 self.diverges.set(self.diverges.get() | old_diverges);
262 self.has_errors.set(self.has_errors.get() | old_has_errors);
264 debug!("type of {} is...", self.tcx.hir().node_to_string(expr.hir_id));
265 debug!("... {:?}, expected is {:?}", ty, expected);
270 #[instrument(skip(self, expr), level = "debug")]
273 expr: &'tcx hir::Expr<'tcx>,
274 expected: Expectation<'tcx>,
276 trace!("expr={:#?}", expr);
280 ExprKind::Box(subexpr) => self.check_expr_box(subexpr, expected),
281 ExprKind::Lit(ref lit) => self.check_lit(&lit, expected),
282 ExprKind::Binary(op, lhs, rhs) => self.check_binop(expr, op, lhs, rhs, expected),
283 ExprKind::Assign(lhs, rhs, span) => {
284 self.check_expr_assign(expr, expected, lhs, rhs, span)
286 ExprKind::AssignOp(op, lhs, rhs) => {
287 self.check_binop_assign(expr, op, lhs, rhs, expected)
289 ExprKind::Unary(unop, oprnd) => self.check_expr_unary(unop, oprnd, expected, expr),
290 ExprKind::AddrOf(kind, mutbl, oprnd) => {
291 self.check_expr_addr_of(kind, mutbl, oprnd, expected, expr)
293 ExprKind::Path(QPath::LangItem(lang_item, _, hir_id)) => {
294 self.check_lang_item_path(lang_item, expr, hir_id)
296 ExprKind::Path(ref qpath) => self.check_expr_path(qpath, expr, &[]),
297 ExprKind::InlineAsm(asm) => {
298 // We defer some asm checks as we may not have resolved the input and output types yet (they may still be infer vars).
299 self.deferred_asm_checks.borrow_mut().push((asm, expr.hir_id));
300 self.check_expr_asm(asm)
302 ExprKind::Break(destination, ref expr_opt) => {
303 self.check_expr_break(destination, expr_opt.as_deref(), expr)
305 ExprKind::Continue(destination) => {
306 if destination.target_id.is_ok() {
309 // There was an error; make type-check fail.
313 ExprKind::Ret(ref expr_opt) => self.check_expr_return(expr_opt.as_deref(), expr),
314 ExprKind::Let(let_expr) => self.check_expr_let(let_expr),
315 ExprKind::Loop(body, _, source, _) => {
316 self.check_expr_loop(body, source, expected, expr)
318 ExprKind::Match(discrim, arms, match_src) => {
319 self.check_match(expr, &discrim, arms, expected, match_src)
321 ExprKind::Closure(&Closure { capture_clause, fn_decl, body, movability, .. }) => {
322 self.check_expr_closure(expr, capture_clause, &fn_decl, body, movability, expected)
324 ExprKind::Block(body, _) => self.check_block_with_expected(&body, expected),
325 ExprKind::Call(callee, args) => self.check_call(expr, &callee, args, expected),
326 ExprKind::MethodCall(segment, receiver, args, _) => {
327 self.check_method_call(expr, segment, receiver, args, expected)
329 ExprKind::Cast(e, t) => self.check_expr_cast(e, t, expr),
330 ExprKind::Type(e, t) => {
331 let ty = self.to_ty_saving_user_provided_ty(&t);
332 self.check_expr_eq_type(&e, ty);
335 ExprKind::If(cond, then_expr, opt_else_expr) => {
336 self.check_then_else(cond, then_expr, opt_else_expr, expr.span, expected)
338 ExprKind::DropTemps(e) => self.check_expr_with_expectation(e, expected),
339 ExprKind::Array(args) => self.check_expr_array(args, expected, expr),
340 ExprKind::ConstBlock(ref anon_const) => {
341 self.check_expr_const_block(anon_const, expected, expr)
343 ExprKind::Repeat(element, ref count) => {
344 self.check_expr_repeat(element, count, expected, expr)
346 ExprKind::Tup(elts) => self.check_expr_tuple(elts, expected, expr),
347 ExprKind::Struct(qpath, fields, ref base_expr) => {
348 self.check_expr_struct(expr, expected, qpath, fields, base_expr)
350 ExprKind::Field(base, field) => self.check_field(expr, &base, field),
351 ExprKind::Index(base, idx) => self.check_expr_index(base, idx, expr),
352 ExprKind::Yield(value, ref src) => self.check_expr_yield(value, expr, src),
353 hir::ExprKind::Err => tcx.ty_error(),
357 fn check_expr_box(&self, expr: &'tcx hir::Expr<'tcx>, expected: Expectation<'tcx>) -> Ty<'tcx> {
358 let expected_inner = expected.to_option(self).map_or(NoExpectation, |ty| match ty.kind() {
359 ty::Adt(def, _) if def.is_box() => Expectation::rvalue_hint(self, ty.boxed_ty()),
362 let referent_ty = self.check_expr_with_expectation(expr, expected_inner);
363 self.require_type_is_sized(referent_ty, expr.span, traits::SizedBoxType);
364 self.tcx.mk_box(referent_ty)
370 oprnd: &'tcx hir::Expr<'tcx>,
371 expected: Expectation<'tcx>,
372 expr: &'tcx hir::Expr<'tcx>,
375 let expected_inner = match unop {
376 hir::UnOp::Not | hir::UnOp::Neg => expected,
377 hir::UnOp::Deref => NoExpectation,
379 let mut oprnd_t = self.check_expr_with_expectation(&oprnd, expected_inner);
381 if !oprnd_t.references_error() {
382 oprnd_t = self.structurally_resolved_type(expr.span, oprnd_t);
384 hir::UnOp::Deref => {
385 if let Some(ty) = self.lookup_derefing(expr, oprnd, oprnd_t) {
388 let mut err = type_error_struct!(
393 "type `{oprnd_t}` cannot be dereferenced",
395 let sp = tcx.sess.source_map().start_point(expr.span);
397 tcx.sess.parse_sess.ambiguous_block_expr_parse.borrow().get(&sp)
399 err.subdiagnostic(ExprParenthesesNeeded::surrounding(*sp));
402 oprnd_t = tcx.ty_error();
406 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
407 // If it's builtin, we can reuse the type, this helps inference.
408 if !(oprnd_t.is_integral() || *oprnd_t.kind() == ty::Bool) {
413 let result = self.check_user_unop(expr, oprnd_t, unop, expected_inner);
414 // If it's builtin, we can reuse the type, this helps inference.
415 if !oprnd_t.is_numeric() {
424 fn check_expr_addr_of(
426 kind: hir::BorrowKind,
427 mutbl: hir::Mutability,
428 oprnd: &'tcx hir::Expr<'tcx>,
429 expected: Expectation<'tcx>,
430 expr: &'tcx hir::Expr<'tcx>,
432 let hint = expected.only_has_type(self).map_or(NoExpectation, |ty| {
434 ty::Ref(_, ty, _) | ty::RawPtr(ty::TypeAndMut { ty, .. }) => {
435 if oprnd.is_syntactic_place_expr() {
436 // Places may legitimately have unsized types.
437 // For example, dereferences of a fat pointer and
438 // the last field of a struct can be unsized.
441 Expectation::rvalue_hint(self, *ty)
448 self.check_expr_with_expectation_and_needs(&oprnd, hint, Needs::maybe_mut_place(mutbl));
450 let tm = ty::TypeAndMut { ty, mutbl };
452 _ if tm.ty.references_error() => self.tcx.ty_error(),
453 hir::BorrowKind::Raw => {
454 self.check_named_place_expr(oprnd);
457 hir::BorrowKind::Ref => {
458 // Note: at this point, we cannot say what the best lifetime
459 // is to use for resulting pointer. We want to use the
460 // shortest lifetime possible so as to avoid spurious borrowck
461 // errors. Moreover, the longest lifetime will depend on the
462 // precise details of the value whose address is being taken
463 // (and how long it is valid), which we don't know yet until
464 // type inference is complete.
466 // Therefore, here we simply generate a region variable. The
467 // region inferencer will then select a suitable value.
468 // Finally, borrowck will infer the value of the region again,
469 // this time with enough precision to check that the value
470 // whose address was taken can actually be made to live as long
471 // as it needs to live.
472 let region = self.next_region_var(infer::AddrOfRegion(expr.span));
473 self.tcx.mk_ref(region, tm)
478 /// Does this expression refer to a place that either:
479 /// * Is based on a local or static.
480 /// * Contains a dereference
481 /// Note that the adjustments for the children of `expr` should already
482 /// have been resolved.
483 fn check_named_place_expr(&self, oprnd: &'tcx hir::Expr<'tcx>) {
484 let is_named = oprnd.is_place_expr(|base| {
485 // Allow raw borrows if there are any deref adjustments.
487 // const VAL: (i32,) = (0,);
488 // const REF: &(i32,) = &(0,);
490 // &raw const VAL.0; // ERROR
491 // &raw const REF.0; // OK, same as &raw const (*REF).0;
493 // This is maybe too permissive, since it allows
494 // `let u = &raw const Box::new((1,)).0`, which creates an
495 // immediately dangling raw pointer.
500 .map_or(false, |x| x.iter().any(|adj| matches!(adj.kind, Adjust::Deref(_))))
503 self.tcx.sess.emit_err(AddressOfTemporaryTaken { span: oprnd.span });
507 fn check_lang_item_path(
509 lang_item: hir::LangItem,
510 expr: &'tcx hir::Expr<'tcx>,
511 hir_id: Option<hir::HirId>,
513 self.resolve_lang_item_path(lang_item, expr.span, expr.hir_id, hir_id).1
516 pub(crate) fn check_expr_path(
518 qpath: &'tcx hir::QPath<'tcx>,
519 expr: &'tcx hir::Expr<'tcx>,
520 args: &'tcx [hir::Expr<'tcx>],
523 let (res, opt_ty, segs) =
524 self.resolve_ty_and_res_fully_qualified_call(qpath, expr.hir_id, expr.span);
527 self.set_tainted_by_errors();
530 Res::Def(DefKind::Ctor(_, CtorKind::Fictive), _) => {
531 report_unexpected_variant_res(tcx, res, qpath, expr.span);
534 _ => self.instantiate_value_path(segs, opt_ty, res, expr.span, expr.hir_id).0,
537 if let ty::FnDef(did, ..) = *ty.kind() {
538 let fn_sig = ty.fn_sig(tcx);
539 if tcx.fn_sig(did).abi() == RustIntrinsic && tcx.item_name(did) == sym::transmute {
540 let from = fn_sig.inputs().skip_binder()[0];
541 let to = fn_sig.output().skip_binder();
542 // We defer the transmute to the end of typeck, once all inference vars have
543 // been resolved or we errored. This is important as we can only check transmute
544 // on concrete types, but the output type may not be known yet (it would only
545 // be known if explicitly specified via turbofish).
546 self.deferred_transmute_checks.borrow_mut().push((from, to, expr.hir_id));
548 if !tcx.features().unsized_fn_params {
549 // We want to remove some Sized bounds from std functions,
550 // but don't want to expose the removal to stable Rust.
551 // i.e., we don't want to allow
557 // to work in stable even if the Sized bound on `drop` is relaxed.
558 for i in 0..fn_sig.inputs().skip_binder().len() {
559 // We just want to check sizedness, so instead of introducing
560 // placeholder lifetimes with probing, we just replace higher lifetimes
562 let span = args.get(i).map(|a| a.span).unwrap_or(expr.span);
563 let input = self.replace_bound_vars_with_fresh_vars(
565 infer::LateBoundRegionConversionTime::FnCall,
568 self.require_type_is_sized_deferred(
571 traits::SizedArgumentType(None),
575 // Here we want to prevent struct constructors from returning unsized types.
576 // There were two cases this happened: fn pointer coercion in stable
577 // and usual function call in presence of unsized_locals.
578 // Also, as we just want to check sizedness, instead of introducing
579 // placeholder lifetimes with probing, we just replace higher lifetimes
581 let output = self.replace_bound_vars_with_fresh_vars(
583 infer::LateBoundRegionConversionTime::FnCall,
586 self.require_type_is_sized_deferred(output, expr.span, traits::SizedReturnType);
589 // We always require that the type provided as the value for
590 // a type parameter outlives the moment of instantiation.
591 let substs = self.typeck_results.borrow().node_substs(expr.hir_id);
592 self.add_wf_bounds(substs, expr);
599 destination: hir::Destination,
600 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
601 expr: &'tcx hir::Expr<'tcx>,
604 if let Ok(target_id) = destination.target_id {
606 if let Some(e) = expr_opt {
607 // If this is a break with a value, we need to type-check
608 // the expression. Get an expected type from the loop context.
609 let opt_coerce_to = {
610 // We should release `enclosing_breakables` before the `check_expr_with_hint`
611 // below, so can't move this block of code to the enclosing scope and share
612 // `ctxt` with the second `enclosing_breakables` borrow below.
613 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
614 match enclosing_breakables.opt_find_breakable(target_id) {
615 Some(ctxt) => ctxt.coerce.as_ref().map(|coerce| coerce.expected_ty()),
617 // Avoid ICE when `break` is inside a closure (#65383).
618 return tcx.ty_error_with_message(
620 "break was outside loop, but no error was emitted",
626 // If the loop context is not a `loop { }`, then break with
627 // a value is illegal, and `opt_coerce_to` will be `None`.
628 // Just set expectation to error in that case.
629 let coerce_to = opt_coerce_to.unwrap_or_else(|| tcx.ty_error());
631 // Recurse without `enclosing_breakables` borrowed.
632 e_ty = self.check_expr_with_hint(e, coerce_to);
633 cause = self.misc(e.span);
635 // Otherwise, this is a break *without* a value. That's
636 // always legal, and is equivalent to `break ()`.
637 e_ty = tcx.mk_unit();
638 cause = self.misc(expr.span);
641 // Now that we have type-checked `expr_opt`, borrow
642 // the `enclosing_loops` field and let's coerce the
643 // type of `expr_opt` into what is expected.
644 let mut enclosing_breakables = self.enclosing_breakables.borrow_mut();
645 let Some(ctxt) = enclosing_breakables.opt_find_breakable(target_id) else {
646 // Avoid ICE when `break` is inside a closure (#65383).
647 return tcx.ty_error_with_message(
649 "break was outside loop, but no error was emitted",
653 if let Some(ref mut coerce) = ctxt.coerce {
654 if let Some(ref e) = expr_opt {
655 coerce.coerce(self, &cause, e, e_ty);
657 assert!(e_ty.is_unit());
658 let ty = coerce.expected_ty();
659 coerce.coerce_forced_unit(
663 self.suggest_mismatched_types_on_tail(
664 &mut err, expr, ty, e_ty, target_id,
666 if let Some(val) = ty_kind_suggestion(ty) {
667 let label = destination
669 .map(|l| format!(" {}", l.ident))
670 .unwrap_or_else(String::new);
673 "give it a value of the expected type",
674 format!("break{label} {val}"),
675 Applicability::HasPlaceholders,
683 // If `ctxt.coerce` is `None`, we can just ignore
684 // the type of the expression. This is because
685 // either this was a break *without* a value, in
686 // which case it is always a legal type (`()`), or
687 // else an error would have been flagged by the
688 // `loops` pass for using break with an expression
689 // where you are not supposed to.
690 assert!(expr_opt.is_none() || self.tcx.sess.has_errors().is_some());
693 // If we encountered a `break`, then (no surprise) it may be possible to break from the
694 // loop... unless the value being returned from the loop diverges itself, e.g.
695 // `break return 5` or `break loop {}`.
696 ctxt.may_break |= !self.diverges.get().is_always();
698 // the type of a `break` is always `!`, since it diverges
701 // Otherwise, we failed to find the enclosing loop;
702 // this can only happen if the `break` was not
703 // inside a loop at all, which is caught by the
704 // loop-checking pass.
705 let err = self.tcx.ty_error_with_message(
707 "break was outside loop, but no error was emitted",
710 // We still need to assign a type to the inner expression to
711 // prevent the ICE in #43162.
712 if let Some(e) = expr_opt {
713 self.check_expr_with_hint(e, err);
715 // ... except when we try to 'break rust;'.
716 // ICE this expression in particular (see #43162).
717 if let ExprKind::Path(QPath::Resolved(_, path)) = e.kind {
718 if path.segments.len() == 1 && path.segments[0].ident.name == sym::rust {
719 fatally_break_rust(self.tcx.sess);
724 // There was an error; make type-check fail.
729 fn check_expr_return(
731 expr_opt: Option<&'tcx hir::Expr<'tcx>>,
732 expr: &'tcx hir::Expr<'tcx>,
734 if self.ret_coercion.is_none() {
735 let mut err = ReturnStmtOutsideOfFnBody {
737 encl_body_span: None,
741 let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
743 if let Some(hir::Node::Item(hir::Item {
744 kind: hir::ItemKind::Fn(..),
748 | Some(hir::Node::TraitItem(hir::TraitItem {
749 kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),
753 | Some(hir::Node::ImplItem(hir::ImplItem {
754 kind: hir::ImplItemKind::Fn(..),
757 })) = self.tcx.hir().find_by_def_id(encl_item_id.def_id)
759 // We are inside a function body, so reporting "return statement
760 // outside of function body" needs an explanation.
762 let encl_body_owner_id = self.tcx.hir().enclosing_body_owner(expr.hir_id);
764 // If this didn't hold, we would not have to report an error in
766 assert_ne!(encl_item_id.def_id, encl_body_owner_id);
768 let encl_body_id = self.tcx.hir().body_owned_by(encl_body_owner_id);
769 let encl_body = self.tcx.hir().body(encl_body_id);
771 err.encl_body_span = Some(encl_body.value.span);
772 err.encl_fn_span = Some(*encl_fn_span);
775 self.tcx.sess.emit_err(err);
777 if let Some(e) = expr_opt {
778 // We still have to type-check `e` (issue #86188), but calling
779 // `check_return_expr` only works inside fn bodies.
782 } else if let Some(e) = expr_opt {
783 if self.ret_coercion_span.get().is_none() {
784 self.ret_coercion_span.set(Some(e.span));
786 self.check_return_expr(e, true);
788 let mut coercion = self.ret_coercion.as_ref().unwrap().borrow_mut();
789 if self.ret_coercion_span.get().is_none() {
790 self.ret_coercion_span.set(Some(expr.span));
792 let cause = self.cause(expr.span, ObligationCauseCode::ReturnNoExpression);
793 if let Some((fn_decl, _)) = self.get_fn_decl(expr.hir_id) {
794 coercion.coerce_forced_unit(
798 let span = fn_decl.output.span();
799 if let Ok(snippet) = self.tcx.sess.source_map().span_to_snippet(span) {
802 format!("expected `{snippet}` because of this return type"),
809 coercion.coerce_forced_unit(self, &cause, &mut |_| (), true);
815 /// `explicit_return` is `true` if we're checking an explicit `return expr`,
816 /// and `false` if we're checking a trailing expression.
817 pub(super) fn check_return_expr(
819 return_expr: &'tcx hir::Expr<'tcx>,
820 explicit_return: bool,
822 let ret_coercion = self.ret_coercion.as_ref().unwrap_or_else(|| {
823 span_bug!(return_expr.span, "check_return_expr called outside fn body")
826 let ret_ty = ret_coercion.borrow().expected_ty();
827 let return_expr_ty = self.check_expr_with_hint(return_expr, ret_ty);
828 let mut span = return_expr.span;
829 // Use the span of the trailing expression for our cause,
830 // not the span of the entire function
831 if !explicit_return {
832 if let ExprKind::Block(body, _) = return_expr.kind && let Some(last_expr) = body.expr {
833 span = last_expr.span;
836 ret_coercion.borrow_mut().coerce(
838 &self.cause(span, ObligationCauseCode::ReturnValue(return_expr.hir_id)),
843 if self.return_type_has_opaque {
844 // Point any obligations that were registered due to opaque type
845 // inference at the return expression.
846 self.select_obligations_where_possible(false, |errors| {
847 self.point_at_return_for_opaque_ty_error(errors, span, return_expr_ty);
852 fn point_at_return_for_opaque_ty_error(
854 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
856 return_expr_ty: Ty<'tcx>,
858 // Don't point at the whole block if it's empty
859 if span == self.tcx.hir().span(self.body_id) {
863 let cause = &mut err.obligation.cause;
864 if let ObligationCauseCode::OpaqueReturnType(None) = cause.code() {
865 let new_cause = ObligationCause::new(
868 ObligationCauseCode::OpaqueReturnType(Some((return_expr_ty, span))),
875 pub(crate) fn check_lhs_assignable(
877 lhs: &'tcx hir::Expr<'tcx>,
878 err_code: &'static str,
880 adjust_err: impl FnOnce(&mut Diagnostic),
882 if lhs.is_syntactic_place_expr() {
886 // FIXME: Make this use Diagnostic once error codes can be dynamically set.
887 let mut err = self.tcx.sess.struct_span_err_with_code(
889 "invalid left-hand side of assignment",
890 DiagnosticId::Error(err_code.into()),
892 err.span_label(lhs.span, "cannot assign to this expression");
894 self.comes_from_while_condition(lhs.hir_id, |expr| {
895 err.span_suggestion_verbose(
896 expr.span.shrink_to_lo(),
897 "you might have meant to use pattern destructuring",
899 Applicability::MachineApplicable,
903 adjust_err(&mut err);
908 // Check if an expression `original_expr_id` comes from the condition of a while loop,
909 // as opposed from the body of a while loop, which we can naively check by iterating
910 // parents until we find a loop...
911 pub(super) fn comes_from_while_condition(
913 original_expr_id: HirId,
914 then: impl FnOnce(&hir::Expr<'_>),
916 let mut parent = self.tcx.hir().get_parent_node(original_expr_id);
917 while let Some(node) = self.tcx.hir().find(parent) {
919 hir::Node::Expr(hir::Expr {
926 hir::ExprKind::Match(expr, ..) | hir::ExprKind::If(expr, ..),
932 hir::LoopSource::While,
937 // Check if our original expression is a child of the condition of a while loop
938 let expr_is_ancestor = std::iter::successors(Some(original_expr_id), |id| {
939 self.tcx.hir().find_parent_node(*id)
941 .take_while(|id| *id != parent)
942 .any(|id| id == expr.hir_id);
943 // if it is, then we have a situation like `while Some(0) = value.get(0) {`,
944 // where `while let` was more likely intended.
945 if expr_is_ancestor {
951 | hir::Node::ImplItem(_)
952 | hir::Node::TraitItem(_)
953 | hir::Node::Crate(_) => break,
955 parent = self.tcx.hir().get_parent_node(parent);
961 // A generic function for checking the 'then' and 'else' clauses in an 'if'
962 // or 'if-else' expression.
965 cond_expr: &'tcx hir::Expr<'tcx>,
966 then_expr: &'tcx hir::Expr<'tcx>,
967 opt_else_expr: Option<&'tcx hir::Expr<'tcx>>,
969 orig_expected: Expectation<'tcx>,
971 let cond_ty = self.check_expr_has_type_or_error(cond_expr, self.tcx.types.bool, |_| {});
973 self.warn_if_unreachable(
976 "block in `if` or `while` expression",
979 let cond_diverges = self.diverges.get();
980 self.diverges.set(Diverges::Maybe);
982 let expected = orig_expected.adjust_for_branches(self);
983 let then_ty = self.check_expr_with_expectation(then_expr, expected);
984 let then_diverges = self.diverges.get();
985 self.diverges.set(Diverges::Maybe);
987 // We've already taken the expected type's preferences
988 // into account when typing the `then` branch. To figure
989 // out the initial shot at a LUB, we thus only consider
990 // `expected` if it represents a *hard* constraint
991 // (`only_has_type`); otherwise, we just go with a
992 // fresh type variable.
993 let coerce_to_ty = expected.coercion_target_type(self, sp);
994 let mut coerce: DynamicCoerceMany<'_> = CoerceMany::new(coerce_to_ty);
996 coerce.coerce(self, &self.misc(sp), then_expr, then_ty);
998 if let Some(else_expr) = opt_else_expr {
999 let else_ty = self.check_expr_with_expectation(else_expr, expected);
1000 let else_diverges = self.diverges.get();
1002 let opt_suggest_box_span = self.opt_suggest_box_span(then_ty, else_ty, orig_expected);
1003 let if_cause = self.if_cause(
1010 opt_suggest_box_span,
1013 coerce.coerce(self, &if_cause, else_expr, else_ty);
1015 // We won't diverge unless both branches do (or the condition does).
1016 self.diverges.set(cond_diverges | then_diverges & else_diverges);
1018 self.if_fallback_coercion(sp, then_expr, &mut coerce);
1020 // If the condition is false we can't diverge.
1021 self.diverges.set(cond_diverges);
1024 let result_ty = coerce.complete(self);
1025 if cond_ty.references_error() { self.tcx.ty_error() } else { result_ty }
1028 /// Type check assignment expression `expr` of form `lhs = rhs`.
1029 /// The expected type is `()` and is passed to the function for the purposes of diagnostics.
1030 fn check_expr_assign(
1032 expr: &'tcx hir::Expr<'tcx>,
1033 expected: Expectation<'tcx>,
1034 lhs: &'tcx hir::Expr<'tcx>,
1035 rhs: &'tcx hir::Expr<'tcx>,
1038 let expected_ty = expected.coercion_target_type(self, expr.span);
1039 if expected_ty == self.tcx.types.bool {
1040 // The expected type is `bool` but this will result in `()` so we can reasonably
1041 // say that the user intended to write `lhs == rhs` instead of `lhs = rhs`.
1042 // The likely cause of this is `if foo = bar { .. }`.
1043 let actual_ty = self.tcx.mk_unit();
1044 let mut err = self.demand_suptype_diag(expr.span, expected_ty, actual_ty).unwrap();
1045 let lhs_ty = self.check_expr(&lhs);
1046 let rhs_ty = self.check_expr(&rhs);
1047 let (applicability, eq) = if self.can_coerce(rhs_ty, lhs_ty) {
1048 (Applicability::MachineApplicable, true)
1049 } else if let ExprKind::Binary(
1050 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1055 // if x == 1 && y == 2 { .. }
1057 let actual_lhs_ty = self.check_expr(&rhs_expr);
1058 (Applicability::MaybeIncorrect, self.can_coerce(rhs_ty, actual_lhs_ty))
1059 } else if let ExprKind::Binary(
1060 Spanned { node: hir::BinOpKind::And | hir::BinOpKind::Or, .. },
1065 // if x == 1 && y == 2 { .. }
1067 let actual_rhs_ty = self.check_expr(&lhs_expr);
1068 (Applicability::MaybeIncorrect, self.can_coerce(actual_rhs_ty, lhs_ty))
1070 (Applicability::MaybeIncorrect, false)
1072 if !lhs.is_syntactic_place_expr()
1073 && lhs.is_approximately_pattern()
1074 && !matches!(lhs.kind, hir::ExprKind::Lit(_))
1076 // Do not suggest `if let x = y` as `==` is way more likely to be the intention.
1077 let hir = self.tcx.hir();
1078 if let hir::Node::Expr(hir::Expr { kind: ExprKind::If { .. }, .. }) =
1079 hir.get(hir.get_parent_node(hir.get_parent_node(expr.hir_id)))
1081 err.span_suggestion_verbose(
1082 expr.span.shrink_to_lo(),
1083 "you might have meant to use pattern matching",
1090 err.span_suggestion_verbose(
1091 span.shrink_to_hi(),
1092 "you might have meant to compare for equality",
1098 // If the assignment expression itself is ill-formed, don't
1099 // bother emitting another error
1100 if lhs_ty.references_error() || rhs_ty.references_error() {
1105 return self.tcx.ty_error();
1108 let lhs_ty = self.check_expr_with_needs(&lhs, Needs::MutPlace);
1110 let suggest_deref_binop = |err: &mut Diagnostic, rhs_ty: Ty<'tcx>| {
1111 if let Some(lhs_deref_ty) = self.deref_once_mutably_for_diagnostic(lhs_ty) {
1112 // Can only assign if the type is sized, so if `DerefMut` yields a type that is
1113 // unsized, do not suggest dereferencing it.
1114 let lhs_deref_ty_is_sized = self
1116 .type_implements_trait(
1117 self.tcx.lang_items().sized_trait().unwrap(),
1123 if lhs_deref_ty_is_sized && self.can_coerce(rhs_ty, lhs_deref_ty) {
1124 err.span_suggestion_verbose(
1125 lhs.span.shrink_to_lo(),
1126 "consider dereferencing here to assign to the mutably borrowed value",
1128 Applicability::MachineApplicable,
1134 // This is (basically) inlined `check_expr_coercable_to_type`, but we want
1135 // to suggest an additional fixup here in `suggest_deref_binop`.
1136 let rhs_ty = self.check_expr_with_hint(&rhs, lhs_ty);
1137 if let (_, Some(mut diag)) =
1138 self.demand_coerce_diag(rhs, rhs_ty, lhs_ty, Some(lhs), AllowTwoPhase::No)
1140 suggest_deref_binop(&mut diag, rhs_ty);
1144 self.check_lhs_assignable(lhs, "E0070", span, |err| {
1145 if let Some(rhs_ty) = self.typeck_results.borrow().expr_ty_opt(rhs) {
1146 suggest_deref_binop(err, rhs_ty);
1150 self.require_type_is_sized(lhs_ty, lhs.span, traits::AssignmentLhsSized);
1152 if lhs_ty.references_error() || rhs_ty.references_error() {
1159 pub(super) fn check_expr_let(&self, let_expr: &'tcx hir::Let<'tcx>) -> Ty<'tcx> {
1160 // for let statements, this is done in check_stmt
1161 let init = let_expr.init;
1162 self.warn_if_unreachable(init.hir_id, init.span, "block in `let` expression");
1163 // otherwise check exactly as a let statement
1164 self.check_decl(let_expr.into());
1165 // but return a bool, for this is a boolean expression
1171 body: &'tcx hir::Block<'tcx>,
1172 source: hir::LoopSource,
1173 expected: Expectation<'tcx>,
1174 expr: &'tcx hir::Expr<'tcx>,
1176 let coerce = match source {
1177 // you can only use break with a value from a normal `loop { }`
1178 hir::LoopSource::Loop => {
1179 let coerce_to = expected.coercion_target_type(self, body.span);
1180 Some(CoerceMany::new(coerce_to))
1183 hir::LoopSource::While | hir::LoopSource::ForLoop => None,
1186 let ctxt = BreakableCtxt {
1188 may_break: false, // Will get updated if/when we find a `break`.
1191 let (ctxt, ()) = self.with_breakable_ctxt(expr.hir_id, ctxt, || {
1192 self.check_block_no_value(&body);
1196 // No way to know whether it's diverging because
1197 // of a `break` or an outer `break` or `return`.
1198 self.diverges.set(Diverges::Maybe);
1201 // If we permit break with a value, then result type is
1202 // the LUB of the breaks (possibly ! if none); else, it
1203 // is nil. This makes sense because infinite loops
1204 // (which would have type !) are only possible iff we
1205 // permit break with a value [1].
1206 if ctxt.coerce.is_none() && !ctxt.may_break {
1208 self.tcx.sess.delay_span_bug(body.span, "no coercion, but loop may not break");
1210 ctxt.coerce.map(|c| c.complete(self)).unwrap_or_else(|| self.tcx.mk_unit())
1213 /// Checks a method call.
1214 fn check_method_call(
1216 expr: &'tcx hir::Expr<'tcx>,
1217 segment: &hir::PathSegment<'_>,
1218 rcvr: &'tcx hir::Expr<'tcx>,
1219 args: &'tcx [hir::Expr<'tcx>],
1220 expected: Expectation<'tcx>,
1222 let rcvr_t = self.check_expr(&rcvr);
1223 // no need to check for bot/err -- callee does that
1224 let rcvr_t = self.structurally_resolved_type(rcvr.span, rcvr_t);
1225 let span = segment.ident.span;
1227 let method = match self.lookup_method(rcvr_t, segment, span, expr, rcvr, args) {
1229 // We could add a "consider `foo::<params>`" suggestion here, but I wasn't able to
1230 // trigger this codepath causing `structurally_resolved_type` to emit an error.
1232 self.write_method_call(expr.hir_id, method);
1236 if segment.ident.name != kw::Empty {
1237 if let Some(mut err) = self.report_method_error(
1241 SelfSource::MethodCall(rcvr),
1252 // Call the generic checker.
1253 self.check_method_argument_types(span, expr, method, &args, DontTupleArguments, expected)
1258 e: &'tcx hir::Expr<'tcx>,
1259 t: &'tcx hir::Ty<'tcx>,
1260 expr: &'tcx hir::Expr<'tcx>,
1262 // Find the type of `e`. Supply hints based on the type we are casting to,
1264 let t_cast = self.to_ty_saving_user_provided_ty(t);
1265 let t_cast = self.resolve_vars_if_possible(t_cast);
1266 let t_expr = self.check_expr_with_expectation(e, ExpectCastableToType(t_cast));
1267 let t_expr = self.resolve_vars_if_possible(t_expr);
1269 // Eagerly check for some obvious errors.
1270 if t_expr.references_error() || t_cast.references_error() {
1273 // Defer other checks until we're done type checking.
1274 let mut deferred_cast_checks = self.deferred_cast_checks.borrow_mut();
1275 match cast::CastCheck::new(self, e, t_expr, t_cast, t.span, expr.span) {
1278 "check_expr_cast: deferring cast from {:?} to {:?}: {:?}",
1279 t_cast, t_expr, cast_check,
1281 deferred_cast_checks.push(cast_check);
1284 Err(_) => self.tcx.ty_error(),
1289 fn check_expr_array(
1291 args: &'tcx [hir::Expr<'tcx>],
1292 expected: Expectation<'tcx>,
1293 expr: &'tcx hir::Expr<'tcx>,
1295 let element_ty = if !args.is_empty() {
1296 let coerce_to = expected
1298 .and_then(|uty| match *uty.kind() {
1299 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1302 .unwrap_or_else(|| {
1303 self.next_ty_var(TypeVariableOrigin {
1304 kind: TypeVariableOriginKind::TypeInference,
1308 let mut coerce = CoerceMany::with_coercion_sites(coerce_to, args);
1309 assert_eq!(self.diverges.get(), Diverges::Maybe);
1311 let e_ty = self.check_expr_with_hint(e, coerce_to);
1312 let cause = self.misc(e.span);
1313 coerce.coerce(self, &cause, e, e_ty);
1315 coerce.complete(self)
1317 self.next_ty_var(TypeVariableOrigin {
1318 kind: TypeVariableOriginKind::TypeInference,
1322 let array_len = args.len() as u64;
1323 self.suggest_array_len(expr, array_len);
1324 self.tcx.mk_array(element_ty, array_len)
1327 fn suggest_array_len(&self, expr: &'tcx hir::Expr<'tcx>, array_len: u64) {
1328 let parent_node = self.tcx.hir().parent_iter(expr.hir_id).find(|(_, node)| {
1329 !matches!(node, hir::Node::Expr(hir::Expr { kind: hir::ExprKind::AddrOf(..), .. }))
1332 hir::Node::Local(hir::Local { ty: Some(ty), .. })
1333 | hir::Node::Item(hir::Item { kind: hir::ItemKind::Const(ty, _), .. }))
1334 ) = parent_node else {
1337 if let hir::TyKind::Array(_, length) = ty.peel_refs().kind
1338 && let hir::ArrayLen::Body(hir::AnonConst { hir_id, .. }) = length
1339 && let Some(span) = self.tcx.hir().opt_span(hir_id)
1341 match self.tcx.sess.diagnostic().steal_diagnostic(span, StashKey::UnderscoreForArrayLengths) {
1343 err.span_suggestion(
1345 "consider specifying the array length",
1347 Applicability::MaybeIncorrect,
1356 fn check_expr_const_block(
1358 anon_const: &'tcx hir::AnonConst,
1359 expected: Expectation<'tcx>,
1360 _expr: &'tcx hir::Expr<'tcx>,
1362 let body = self.tcx.hir().body(anon_const.body);
1364 // Create a new function context.
1365 let fcx = FnCtxt::new(self, self.param_env.with_const(), body.value.hir_id);
1366 crate::GatherLocalsVisitor::new(&fcx).visit_body(body);
1368 let ty = fcx.check_expr_with_expectation(&body.value, expected);
1369 fcx.require_type_is_sized(ty, body.value.span, traits::ConstSized);
1370 fcx.write_ty(anon_const.hir_id, ty);
1374 fn check_expr_repeat(
1376 element: &'tcx hir::Expr<'tcx>,
1377 count: &'tcx hir::ArrayLen,
1378 expected: Expectation<'tcx>,
1379 expr: &'tcx hir::Expr<'tcx>,
1382 let count = self.array_length_to_const(count);
1383 if let Some(count) = count.try_eval_usize(tcx, self.param_env) {
1384 self.suggest_array_len(expr, count);
1387 let uty = match expected {
1388 ExpectHasType(uty) => match *uty.kind() {
1389 ty::Array(ty, _) | ty::Slice(ty) => Some(ty),
1395 let (element_ty, t) = match uty {
1397 self.check_expr_coercable_to_type(&element, uty, None);
1401 let ty = self.next_ty_var(TypeVariableOrigin {
1402 kind: TypeVariableOriginKind::MiscVariable,
1405 let element_ty = self.check_expr_has_type_or_error(&element, ty, |_| {});
1410 if element_ty.references_error() {
1411 return tcx.ty_error();
1414 self.check_repeat_element_needs_copy_bound(element, count, element_ty);
1416 tcx.mk_ty(ty::Array(t, count))
1419 fn check_repeat_element_needs_copy_bound(
1421 element: &hir::Expr<'_>,
1422 count: ty::Const<'tcx>,
1423 element_ty: Ty<'tcx>,
1426 // Actual constants as the repeat element get inserted repeatedly instead of getting copied via Copy.
1427 match &element.kind {
1428 hir::ExprKind::ConstBlock(..) => return,
1429 hir::ExprKind::Path(qpath) => {
1430 let res = self.typeck_results.borrow().qpath_res(qpath, element.hir_id);
1431 if let Res::Def(DefKind::Const | DefKind::AssocConst | DefKind::AnonConst, _) = res
1438 // If someone calls a const fn, they can extract that call out into a separate constant (or a const
1439 // block in the future), so we check that to tell them that in the diagnostic. Does not affect typeck.
1440 let is_const_fn = match element.kind {
1441 hir::ExprKind::Call(func, _args) => match *self.node_ty(func.hir_id).kind() {
1442 ty::FnDef(def_id, _) => tcx.is_const_fn(def_id),
1448 // If the length is 0, we don't create any elements, so we don't copy any. If the length is 1, we
1449 // don't copy that one element, we move it. Only check for Copy if the length is larger.
1450 if count.try_eval_usize(tcx, self.param_env).map_or(true, |len| len > 1) {
1451 let lang_item = self.tcx.require_lang_item(LangItem::Copy, None);
1452 let code = traits::ObligationCauseCode::RepeatElementCopy { is_const_fn };
1453 self.require_type_meets(element_ty, element.span, code, lang_item);
1457 fn check_expr_tuple(
1459 elts: &'tcx [hir::Expr<'tcx>],
1460 expected: Expectation<'tcx>,
1461 expr: &'tcx hir::Expr<'tcx>,
1463 let flds = expected.only_has_type(self).and_then(|ty| {
1464 let ty = self.resolve_vars_with_obligations(ty);
1466 ty::Tuple(flds) => Some(&flds[..]),
1471 let elt_ts_iter = elts.iter().enumerate().map(|(i, e)| match flds {
1472 Some(fs) if i < fs.len() => {
1474 self.check_expr_coercable_to_type(&e, ety, None);
1477 _ => self.check_expr_with_expectation(&e, NoExpectation),
1479 let tuple = self.tcx.mk_tup(elt_ts_iter);
1480 if tuple.references_error() {
1483 self.require_type_is_sized(tuple, expr.span, traits::TupleInitializerSized);
1488 fn check_expr_struct(
1490 expr: &hir::Expr<'_>,
1491 expected: Expectation<'tcx>,
1493 fields: &'tcx [hir::ExprField<'tcx>],
1494 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1496 // Find the relevant variant
1497 let Some((variant, adt_ty)) = self.check_struct_path(qpath, expr.hir_id) else {
1498 self.check_struct_fields_on_error(fields, base_expr);
1499 return self.tcx.ty_error();
1502 // Prohibit struct expressions when non-exhaustive flag is set.
1503 let adt = adt_ty.ty_adt_def().expect("`check_struct_path` returned non-ADT type");
1504 if !adt.did().is_local() && variant.is_field_list_non_exhaustive() {
1507 .emit_err(StructExprNonExhaustive { span: expr.span, what: adt.variant_descr() });
1510 self.check_expr_struct_fields(
1521 self.require_type_is_sized(adt_ty, expr.span, traits::StructInitializerSized);
1525 fn check_expr_struct_fields(
1528 expected: Expectation<'tcx>,
1529 expr_id: hir::HirId,
1531 variant: &'tcx ty::VariantDef,
1532 ast_fields: &'tcx [hir::ExprField<'tcx>],
1533 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1538 let expected_inputs =
1539 self.expected_inputs_for_expected_output(span, expected, adt_ty, &[adt_ty]);
1540 let adt_ty_hint = if let Some(expected_inputs) = expected_inputs {
1541 expected_inputs.get(0).cloned().unwrap_or(adt_ty)
1545 // re-link the regions that EIfEO can erase.
1546 self.demand_eqtype(span, adt_ty_hint, adt_ty);
1548 let ty::Adt(adt, substs) = adt_ty.kind() else {
1549 span_bug!(span, "non-ADT passed to check_expr_struct_fields");
1551 let adt_kind = adt.adt_kind();
1553 let mut remaining_fields = variant
1557 .map(|(i, field)| (field.ident(tcx).normalize_to_macros_2_0(), (i, field)))
1558 .collect::<FxHashMap<_, _>>();
1560 let mut seen_fields = FxHashMap::default();
1562 let mut error_happened = false;
1564 // Type-check each field.
1565 for (idx, field) in ast_fields.iter().enumerate() {
1566 let ident = tcx.adjust_ident(field.ident, variant.def_id);
1567 let field_type = if let Some((i, v_field)) = remaining_fields.remove(&ident) {
1568 seen_fields.insert(ident, field.span);
1569 self.write_field_index(field.hir_id, i);
1571 // We don't look at stability attributes on
1572 // struct-like enums (yet...), but it's definitely not
1573 // a bug to have constructed one.
1574 if adt_kind != AdtKind::Enum {
1575 tcx.check_stability(v_field.did, Some(expr_id), field.span, None);
1578 self.field_ty(field.span, v_field, substs)
1580 error_happened = true;
1581 if let Some(prev_span) = seen_fields.get(&ident) {
1582 tcx.sess.emit_err(FieldMultiplySpecifiedInInitializer {
1583 span: field.ident.span,
1584 prev_span: *prev_span,
1588 self.report_unknown_field(
1593 adt.variant_descr(),
1601 // Make sure to give a type to the field even if there's
1602 // an error, so we can continue type-checking.
1603 let ty = self.check_expr_with_hint(&field.expr, field_type);
1605 self.demand_coerce_diag(&field.expr, ty, field_type, None, AllowTwoPhase::No);
1607 if let Some(mut diag) = diag {
1608 if idx == ast_fields.len() - 1 && remaining_fields.is_empty() {
1609 self.suggest_fru_from_range(field, variant, substs, &mut diag);
1615 // Make sure the programmer specified correct number of fields.
1616 if adt_kind == AdtKind::Union {
1617 if ast_fields.len() != 1 {
1622 "union expressions should have exactly one field",
1628 // If check_expr_struct_fields hit an error, do not attempt to populate
1629 // the fields with the base_expr. This could cause us to hit errors later
1630 // when certain fields are assumed to exist that in fact do not.
1635 if let Some(base_expr) = base_expr {
1636 // FIXME: We are currently creating two branches here in order to maintain
1637 // consistency. But they should be merged as much as possible.
1638 let fru_tys = if self.tcx.features().type_changing_struct_update {
1639 if adt.is_struct() {
1640 // Make some fresh substitutions for our ADT type.
1641 let fresh_substs = self.fresh_substs_for_item(base_expr.span, adt.did());
1642 // We do subtyping on the FRU fields first, so we can
1643 // learn exactly what types we expect the base expr
1644 // needs constrained to be compatible with the struct
1645 // type we expect from the expectation value.
1646 let fru_tys = variant
1650 let fru_ty = self.normalize_associated_types_in(
1652 self.field_ty(base_expr.span, f, fresh_substs),
1654 let ident = self.tcx.adjust_ident(f.ident(self.tcx), variant.def_id);
1655 if let Some(_) = remaining_fields.remove(&ident) {
1656 let target_ty = self.field_ty(base_expr.span, f, substs);
1657 let cause = self.misc(base_expr.span);
1658 match self.at(&cause, self.param_env).sup(target_ty, fru_ty) {
1659 Ok(InferOk { obligations, value: () }) => {
1660 self.register_predicates(obligations)
1663 // This should never happen, since we're just subtyping the
1664 // remaining_fields, but it's fine to emit this, I guess.
1666 .report_mismatched_types(
1670 FieldMisMatch(variant.name, ident.name),
1676 self.resolve_vars_if_possible(fru_ty)
1679 // The use of fresh substs that we have subtyped against
1680 // our base ADT type's fields allows us to guide inference
1681 // along so that, e.g.
1683 // MyStruct<'a, F1, F2, const C: usize> {
1685 // // Other fields that reference `'a`, `F2`, and `C`
1688 // let x = MyStruct {
1693 // will have the `other_struct` expression constrained to
1694 // `MyStruct<'a, _, F2, C>`, as opposed to just `_`...
1695 // This is important to allow coercions to happen in
1696 // `other_struct` itself. See `coerce-in-base-expr.rs`.
1697 let fresh_base_ty = self.tcx.mk_adt(*adt, fresh_substs);
1698 self.check_expr_has_type_or_error(
1700 self.resolve_vars_if_possible(fresh_base_ty),
1705 // Check the base_expr, regardless of a bad expected adt_ty, so we can get
1706 // type errors on that expression, too.
1707 self.check_expr(base_expr);
1710 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1714 self.check_expr_has_type_or_error(base_expr, adt_ty, |_| {
1715 let base_ty = self.typeck_results.borrow().expr_ty(*base_expr);
1716 let same_adt = match (adt_ty.kind(), base_ty.kind()) {
1717 (ty::Adt(adt, _), ty::Adt(base_adt, _)) if adt == base_adt => true,
1720 if self.tcx.sess.is_nightly_build() && same_adt {
1722 &self.tcx.sess.parse_sess,
1723 sym::type_changing_struct_update,
1725 "type changing struct updating is experimental",
1730 match adt_ty.kind() {
1731 ty::Adt(adt, substs) if adt.is_struct() => variant
1735 self.normalize_associated_types_in(expr_span, f.ty(self.tcx, substs))
1741 .emit_err(FunctionalRecordUpdateOnNonStruct { span: base_expr.span });
1746 self.typeck_results.borrow_mut().fru_field_types_mut().insert(expr_id, fru_tys);
1747 } else if adt_kind != AdtKind::Union && !remaining_fields.is_empty() {
1748 debug!(?remaining_fields);
1749 let private_fields: Vec<&ty::FieldDef> = variant
1752 .filter(|field| !field.vis.is_accessible_from(tcx.parent_module(expr_id), tcx))
1755 if !private_fields.is_empty() {
1756 self.report_private_fields(adt_ty, span, private_fields, ast_fields);
1758 self.report_missing_fields(
1770 fn check_struct_fields_on_error(
1772 fields: &'tcx [hir::ExprField<'tcx>],
1773 base_expr: &'tcx Option<&'tcx hir::Expr<'tcx>>,
1775 for field in fields {
1776 self.check_expr(&field.expr);
1778 if let Some(base) = *base_expr {
1779 self.check_expr(&base);
1783 /// Report an error for a struct field expression when there are fields which aren't provided.
1786 /// error: missing field `you_can_use_this_field` in initializer of `foo::Foo`
1787 /// --> src/main.rs:8:5
1789 /// 8 | foo::Foo {};
1790 /// | ^^^^^^^^ missing `you_can_use_this_field`
1792 /// error: aborting due to previous error
1794 fn report_missing_fields(
1798 remaining_fields: FxHashMap<Ident, (usize, &ty::FieldDef)>,
1799 variant: &'tcx ty::VariantDef,
1800 ast_fields: &'tcx [hir::ExprField<'tcx>],
1801 substs: SubstsRef<'tcx>,
1803 let len = remaining_fields.len();
1805 let mut displayable_field_names: Vec<&str> =
1806 remaining_fields.keys().map(|ident| ident.as_str()).collect();
1807 // sorting &str primitives here, sort_unstable is ok
1808 displayable_field_names.sort_unstable();
1810 let mut truncated_fields_error = String::new();
1811 let remaining_fields_names = match &displayable_field_names[..] {
1812 [field1] => format!("`{}`", field1),
1813 [field1, field2] => format!("`{field1}` and `{field2}`"),
1814 [field1, field2, field3] => format!("`{field1}`, `{field2}` and `{field3}`"),
1816 truncated_fields_error =
1817 format!(" and {} other field{}", len - 3, pluralize!(len - 3));
1818 displayable_field_names
1821 .map(|n| format!("`{n}`"))
1822 .collect::<Vec<_>>()
1827 let mut err = struct_span_err!(
1831 "missing field{} {}{} in initializer of `{}`",
1833 remaining_fields_names,
1834 truncated_fields_error,
1837 err.span_label(span, format!("missing {remaining_fields_names}{truncated_fields_error}"));
1839 if let Some(last) = ast_fields.last() {
1840 self.suggest_fru_from_range(last, variant, substs, &mut err);
1846 /// If the last field is a range literal, but it isn't supposed to be, then they probably
1847 /// meant to use functional update syntax.
1848 fn suggest_fru_from_range(
1850 last_expr_field: &hir::ExprField<'tcx>,
1851 variant: &ty::VariantDef,
1852 substs: SubstsRef<'tcx>,
1853 err: &mut Diagnostic,
1855 // I don't use 'is_range_literal' because only double-sided, half-open ranges count.
1856 if let ExprKind::Struct(
1857 QPath::LangItem(LangItem::Range, ..),
1858 &[ref range_start, ref range_end],
1860 ) = last_expr_field.expr.kind
1861 && let variant_field =
1862 variant.fields.iter().find(|field| field.ident(self.tcx) == last_expr_field.ident)
1863 && let range_def_id = self.tcx.lang_items().range_struct()
1865 .and_then(|field| field.ty(self.tcx, substs).ty_adt_def())
1866 .map(|adt| adt.did())
1873 .span_to_snippet(range_end.expr.span)
1874 .map(|s| format!(" from `{s}`"))
1875 .unwrap_or_default();
1876 err.span_suggestion(
1877 range_start.span.shrink_to_hi(),
1878 &format!("to set the remaining fields{instead}, separate the last named field with a comma"),
1880 Applicability::MaybeIncorrect,
1885 /// Report an error for a struct field expression when there are invisible fields.
1888 /// error: cannot construct `Foo` with struct literal syntax due to private fields
1889 /// --> src/main.rs:8:5
1891 /// 8 | foo::Foo {};
1894 /// error: aborting due to previous error
1896 fn report_private_fields(
1900 private_fields: Vec<&ty::FieldDef>,
1901 used_fields: &'tcx [hir::ExprField<'tcx>],
1903 let mut err = self.tcx.sess.struct_span_err(
1906 "cannot construct `{adt_ty}` with struct literal syntax due to private fields",
1909 let (used_private_fields, remaining_private_fields): (
1910 Vec<(Symbol, Span, bool)>,
1911 Vec<(Symbol, Span, bool)>,
1915 match used_fields.iter().find(|used_field| field.name == used_field.ident.name) {
1916 Some(used_field) => (field.name, used_field.span, true),
1917 None => (field.name, self.tcx.def_span(field.did), false),
1920 .partition(|field| field.2);
1921 err.span_labels(used_private_fields.iter().map(|(_, span, _)| *span), "private field");
1922 if !remaining_private_fields.is_empty() {
1923 let remaining_private_fields_len = remaining_private_fields.len();
1924 let names = match &remaining_private_fields
1926 .map(|(name, _, _)| name)
1927 .collect::<Vec<_>>()[..]
1929 _ if remaining_private_fields_len > 6 => String::new(),
1930 [name] => format!("`{name}` "),
1931 [names @ .., last] => {
1932 let names = names.iter().map(|name| format!("`{name}`")).collect::<Vec<_>>();
1933 format!("{} and `{last}` ", names.join(", "))
1935 [] => unreachable!(),
1938 "... and other private field{s} {names}that {were} not provided",
1939 s = pluralize!(remaining_private_fields_len),
1940 were = pluralize!("was", remaining_private_fields_len),
1946 fn report_unknown_field(
1949 variant: &'tcx ty::VariantDef,
1950 field: &hir::ExprField<'_>,
1951 skip_fields: &[hir::ExprField<'_>],
1955 if variant.is_recovered() {
1956 self.set_tainted_by_errors();
1959 let mut err = self.err_ctxt().type_error_struct_with_diag(
1961 |actual| match ty.kind() {
1962 ty::Adt(adt, ..) if adt.is_enum() => struct_span_err!(
1966 "{} `{}::{}` has no field named `{}`",
1972 _ => struct_span_err!(
1976 "{} `{}` has no field named `{}`",
1985 let variant_ident_span = self.tcx.def_ident_span(variant.def_id).unwrap();
1986 match variant.ctor_kind {
1987 CtorKind::Fn => match ty.kind() {
1988 ty::Adt(adt, ..) if adt.is_enum() => {
1992 "`{adt}::{variant}` defined here",
1994 variant = variant.name,
1997 err.span_label(field.ident.span, "field does not exist");
1998 err.span_suggestion_verbose(
2001 "`{adt}::{variant}` is a tuple {kind_name}, use the appropriate syntax",
2003 variant = variant.name,
2006 "{adt}::{variant}(/* fields */)",
2008 variant = variant.name,
2010 Applicability::HasPlaceholders,
2014 err.span_label(variant_ident_span, format!("`{adt}` defined here", adt = ty));
2015 err.span_label(field.ident.span, "field does not exist");
2016 err.span_suggestion_verbose(
2019 "`{adt}` is a tuple {kind_name}, use the appropriate syntax",
2021 kind_name = kind_name,
2023 format!("{adt}(/* fields */)", adt = ty),
2024 Applicability::HasPlaceholders,
2029 // prevent all specified fields from being suggested
2030 let skip_fields = skip_fields.iter().map(|x| x.ident.name);
2031 if let Some(field_name) = self.suggest_field_name(
2034 skip_fields.collect(),
2037 err.span_suggestion(
2039 "a field with a similar name exists",
2041 Applicability::MaybeIncorrect,
2045 ty::Adt(adt, ..) => {
2049 format!("`{}::{}` does not have this field", ty, variant.name),
2054 format!("`{ty}` does not have this field"),
2057 let available_field_names =
2058 self.available_field_names(variant, expr_span);
2059 if !available_field_names.is_empty() {
2061 "available fields are: {}",
2062 self.name_series_display(available_field_names)
2066 _ => bug!("non-ADT passed to report_unknown_field"),
2074 // Return a hint about the closest match in field names
2075 fn suggest_field_name(
2077 variant: &'tcx ty::VariantDef,
2080 // The span where stability will be checked
2082 ) -> Option<Symbol> {
2086 .filter_map(|field| {
2087 // ignore already set fields and private fields from non-local crates
2088 // and unstable fields.
2089 if skip.iter().any(|&x| x == field.name)
2090 || (!variant.def_id.is_local() && !field.vis.is_public())
2092 self.tcx.eval_stability(field.did, None, span, None),
2093 stability::EvalResult::Deny { .. }
2101 .collect::<Vec<Symbol>>();
2103 find_best_match_for_name(&names, field, None)
2106 fn available_field_names(
2108 variant: &'tcx ty::VariantDef,
2115 let def_scope = self
2117 .adjust_ident_and_get_scope(field.ident(self.tcx), variant.def_id, self.body_id)
2119 field.vis.is_accessible_from(def_scope, self.tcx)
2121 self.tcx.eval_stability(field.did, None, access_span, None),
2122 stability::EvalResult::Deny { .. }
2125 .filter(|field| !self.tcx.is_doc_hidden(field.did))
2126 .map(|field| field.name)
2130 fn name_series_display(&self, names: Vec<Symbol>) -> String {
2131 // dynamic limit, to never omit just one field
2132 let limit = if names.len() == 6 { 6 } else { 5 };
2134 names.iter().take(limit).map(|n| format!("`{}`", n)).collect::<Vec<_>>().join(", ");
2135 if names.len() > limit {
2136 display = format!("{} ... and {} others", display, names.len() - limit);
2141 // Check field access expressions
2144 expr: &'tcx hir::Expr<'tcx>,
2145 base: &'tcx hir::Expr<'tcx>,
2148 debug!("check_field(expr: {:?}, base: {:?}, field: {:?})", expr, base, field);
2149 let base_ty = self.check_expr(base);
2150 let base_ty = self.structurally_resolved_type(base.span, base_ty);
2151 let mut private_candidate = None;
2152 let mut autoderef = self.autoderef(expr.span, base_ty);
2153 while let Some((deref_base_ty, _)) = autoderef.next() {
2154 debug!("deref_base_ty: {:?}", deref_base_ty);
2155 match deref_base_ty.kind() {
2156 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2157 debug!("struct named {:?}", deref_base_ty);
2158 let (ident, def_scope) =
2159 self.tcx.adjust_ident_and_get_scope(field, base_def.did(), self.body_id);
2160 let fields = &base_def.non_enum_variant().fields;
2161 if let Some(index) = fields
2163 .position(|f| f.ident(self.tcx).normalize_to_macros_2_0() == ident)
2165 let field = &fields[index];
2166 let field_ty = self.field_ty(expr.span, field, substs);
2167 // Save the index of all fields regardless of their visibility in case
2168 // of error recovery.
2169 self.write_field_index(expr.hir_id, index);
2170 let adjustments = self.adjust_steps(&autoderef);
2171 if field.vis.is_accessible_from(def_scope, self.tcx) {
2172 self.apply_adjustments(base, adjustments);
2173 self.register_predicates(autoderef.into_obligations());
2175 self.tcx.check_stability(field.did, Some(expr.hir_id), expr.span, None);
2178 private_candidate = Some((adjustments, base_def.did(), field_ty));
2182 let fstr = field.as_str();
2183 if let Ok(index) = fstr.parse::<usize>() {
2184 if fstr == index.to_string() {
2185 if let Some(&field_ty) = tys.get(index) {
2186 let adjustments = self.adjust_steps(&autoderef);
2187 self.apply_adjustments(base, adjustments);
2188 self.register_predicates(autoderef.into_obligations());
2190 self.write_field_index(expr.hir_id, index);
2199 self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
2201 if let Some((adjustments, did, field_ty)) = private_candidate {
2202 // (#90483) apply adjustments to avoid ExprUseVisitor from
2203 // creating erroneous projection.
2204 self.apply_adjustments(base, adjustments);
2205 self.ban_private_field_access(expr, base_ty, field, did);
2209 if field.name == kw::Empty {
2210 } else if self.method_exists(field, base_ty, expr.hir_id, true) {
2211 self.ban_take_value_of_method(expr, base_ty, field);
2212 } else if !base_ty.is_primitive_ty() {
2213 self.ban_nonexisting_field(field, base, expr, base_ty);
2215 let field_name = field.to_string();
2216 let mut err = type_error_struct!(
2221 "`{base_ty}` is a primitive type and therefore doesn't have fields",
2223 let is_valid_suffix = |field: &str| {
2224 if field == "f32" || field == "f64" {
2227 let mut chars = field.chars().peekable();
2228 match chars.peek() {
2229 Some('e') | Some('E') => {
2231 if let Some(c) = chars.peek()
2232 && !c.is_numeric() && *c != '-' && *c != '+'
2236 while let Some(c) = chars.peek() {
2237 if !c.is_numeric() {
2245 let suffix = chars.collect::<String>();
2246 suffix.is_empty() || suffix == "f32" || suffix == "f64"
2248 let maybe_partial_suffix = |field: &str| -> Option<&str> {
2249 let first_chars = ['f', 'l'];
2251 && field.to_lowercase().starts_with(first_chars)
2252 && field[1..].chars().all(|c| c.is_ascii_digit())
2254 if field.to_lowercase().starts_with(['f']) { Some("f32") } else { Some("f64") }
2259 if let ty::Infer(ty::IntVar(_)) = base_ty.kind()
2260 && let ExprKind::Lit(Spanned {
2261 node: ast::LitKind::Int(_, ast::LitIntType::Unsuffixed),
2264 && !base.span.from_expansion()
2266 if is_valid_suffix(&field_name) {
2267 err.span_suggestion_verbose(
2268 field.span.shrink_to_lo(),
2269 "if intended to be a floating point literal, consider adding a `0` after the period",
2271 Applicability::MaybeIncorrect,
2273 } else if let Some(correct_suffix) = maybe_partial_suffix(&field_name) {
2274 err.span_suggestion_verbose(
2276 format!("if intended to be a floating point literal, consider adding a `0` after the period and a `{correct_suffix}` suffix"),
2277 format!("0{correct_suffix}"),
2278 Applicability::MaybeIncorrect,
2285 self.tcx().ty_error()
2288 fn suggest_await_on_field_access(
2290 err: &mut Diagnostic,
2292 base: &'tcx hir::Expr<'tcx>,
2295 let output_ty = match self.get_impl_future_output_ty(ty) {
2296 Some(output_ty) => self.resolve_vars_if_possible(output_ty),
2299 let mut add_label = true;
2300 if let ty::Adt(def, _) = output_ty.skip_binder().kind() {
2301 // no field access on enum type
2307 .any(|field| field.ident(self.tcx) == field_ident)
2312 "field not available in `impl Future`, but it is available in its `Output`",
2314 err.span_suggestion_verbose(
2315 base.span.shrink_to_hi(),
2316 "consider `await`ing on the `Future` and access the field of its `Output`",
2318 Applicability::MaybeIncorrect,
2324 err.span_label(field_ident.span, &format!("field not found in `{ty}`"));
2328 fn ban_nonexisting_field(
2331 base: &'tcx hir::Expr<'tcx>,
2332 expr: &'tcx hir::Expr<'tcx>,
2336 "ban_nonexisting_field: field={:?}, base={:?}, expr={:?}, base_ty={:?}",
2337 ident, base, expr, base_ty
2339 let mut err = self.no_such_field_err(ident, base_ty, base.hir_id);
2341 match *base_ty.peel_refs().kind() {
2342 ty::Array(_, len) => {
2343 self.maybe_suggest_array_indexing(&mut err, expr, base, ident, len);
2346 self.suggest_first_deref_field(&mut err, expr, base, ident);
2348 ty::Adt(def, _) if !def.is_enum() => {
2349 self.suggest_fields_on_recordish(&mut err, def, ident, expr.span);
2351 ty::Param(param_ty) => {
2352 self.point_at_param_definition(&mut err, param_ty);
2354 ty::Opaque(_, _) => {
2355 self.suggest_await_on_field_access(&mut err, ident, base, base_ty.peel_refs());
2360 self.suggest_fn_call(&mut err, base, base_ty, |output_ty| {
2361 if let ty::Adt(def, _) = output_ty.kind() && !def.is_enum() {
2362 def.non_enum_variant().fields.iter().any(|field| {
2363 field.ident(self.tcx) == ident
2364 && field.vis.is_accessible_from(expr.hir_id.owner.def_id, self.tcx)
2366 } else if let ty::Tuple(tys) = output_ty.kind()
2367 && let Ok(idx) = ident.as_str().parse::<usize>()
2375 if ident.name == kw::Await {
2376 // We know by construction that `<expr>.await` is either on Rust 2015
2377 // or results in `ExprKind::Await`. Suggest switching the edition to 2018.
2378 err.note("to `.await` a `Future`, switch to Rust 2018 or later");
2379 err.help_use_latest_edition();
2385 fn ban_private_field_access(
2387 expr: &hir::Expr<'_>,
2392 let struct_path = self.tcx().def_path_str(base_did);
2393 let kind_name = self.tcx().def_kind(base_did).descr(base_did);
2394 let mut err = struct_span_err!(
2398 "field `{field}` of {kind_name} `{struct_path}` is private",
2400 err.span_label(field.span, "private field");
2401 // Also check if an accessible method exists, which is often what is meant.
2402 if self.method_exists(field, expr_t, expr.hir_id, false) && !self.expr_in_place(expr.hir_id)
2404 self.suggest_method_call(
2406 &format!("a method `{field}` also exists, call it with parentheses"),
2416 fn ban_take_value_of_method(&self, expr: &hir::Expr<'_>, expr_t: Ty<'tcx>, field: Ident) {
2417 let mut err = type_error_struct!(
2422 "attempted to take value of method `{field}` on type `{expr_t}`",
2424 err.span_label(field.span, "method, not a field");
2426 if let hir::Node::Expr(hir::Expr { kind: ExprKind::Call(callee, _args), .. }) =
2427 self.tcx.hir().get(self.tcx.hir().get_parent_node(expr.hir_id))
2429 expr.hir_id == callee.hir_id
2434 self.tcx.sess.source_map().span_to_snippet(expr.span).unwrap_or_default();
2435 let is_wrapped = expr_snippet.starts_with('(') && expr_snippet.ends_with(')');
2436 let after_open = expr.span.lo() + rustc_span::BytePos(1);
2437 let before_close = expr.span.hi() - rustc_span::BytePos(1);
2439 if expr_is_call && is_wrapped {
2440 err.multipart_suggestion(
2441 "remove wrapping parentheses to call the method",
2443 (expr.span.with_hi(after_open), String::new()),
2444 (expr.span.with_lo(before_close), String::new()),
2446 Applicability::MachineApplicable,
2448 } else if !self.expr_in_place(expr.hir_id) {
2449 // Suggest call parentheses inside the wrapping parentheses
2450 let span = if is_wrapped {
2451 expr.span.with_lo(after_open).with_hi(before_close)
2455 self.suggest_method_call(
2457 "use parentheses to call the method",
2463 } else if let ty::RawPtr(ty_and_mut) = expr_t.kind()
2464 && let ty::Adt(adt_def, _) = ty_and_mut.ty.kind()
2465 && let ExprKind::Field(base_expr, _) = expr.kind
2466 && adt_def.variants().len() == 1
2474 .any(|f| f.ident(self.tcx) == field)
2476 err.multipart_suggestion(
2477 "to access the field, dereference first",
2479 (base_expr.span.shrink_to_lo(), "(*".to_string()),
2480 (base_expr.span.shrink_to_hi(), ")".to_string()),
2482 Applicability::MaybeIncorrect,
2485 err.help("methods are immutable and cannot be assigned to");
2491 fn point_at_param_definition(&self, err: &mut Diagnostic, param: ty::ParamTy) {
2492 let generics = self.tcx.generics_of(self.body_id.owner.to_def_id());
2493 let generic_param = generics.type_param(¶m, self.tcx);
2494 if let ty::GenericParamDefKind::Type { synthetic: true, .. } = generic_param.kind {
2497 let param_def_id = generic_param.def_id;
2498 let param_hir_id = match param_def_id.as_local() {
2499 Some(x) => self.tcx.hir().local_def_id_to_hir_id(x),
2502 let param_span = self.tcx.hir().span(param_hir_id);
2503 let param_name = self.tcx.hir().ty_param_name(param_def_id.expect_local());
2505 err.span_label(param_span, &format!("type parameter '{param_name}' declared here"));
2508 fn suggest_fields_on_recordish(
2510 err: &mut Diagnostic,
2511 def: ty::AdtDef<'tcx>,
2515 if let Some(suggested_field_name) =
2516 self.suggest_field_name(def.non_enum_variant(), field.name, vec![], access_span)
2518 err.span_suggestion(
2520 "a field with a similar name exists",
2521 suggested_field_name,
2522 Applicability::MaybeIncorrect,
2525 err.span_label(field.span, "unknown field");
2526 let struct_variant_def = def.non_enum_variant();
2527 let field_names = self.available_field_names(struct_variant_def, access_span);
2528 if !field_names.is_empty() {
2530 "available fields are: {}",
2531 self.name_series_display(field_names),
2537 fn maybe_suggest_array_indexing(
2539 err: &mut Diagnostic,
2540 expr: &hir::Expr<'_>,
2541 base: &hir::Expr<'_>,
2543 len: ty::Const<'tcx>,
2545 if let (Some(len), Ok(user_index)) =
2546 (len.try_eval_usize(self.tcx, self.param_env), field.as_str().parse::<u64>())
2547 && let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span)
2549 let help = "instead of using tuple indexing, use array indexing";
2550 let suggestion = format!("{base}[{field}]");
2551 let applicability = if len < user_index {
2552 Applicability::MachineApplicable
2554 Applicability::MaybeIncorrect
2556 err.span_suggestion(expr.span, help, suggestion, applicability);
2560 fn suggest_first_deref_field(
2562 err: &mut Diagnostic,
2563 expr: &hir::Expr<'_>,
2564 base: &hir::Expr<'_>,
2567 if let Ok(base) = self.tcx.sess.source_map().span_to_snippet(base.span) {
2568 let msg = format!("`{base}` is a raw pointer; try dereferencing it");
2569 let suggestion = format!("(*{base}).{field}");
2570 err.span_suggestion(expr.span, &msg, suggestion, Applicability::MaybeIncorrect);
2574 fn no_such_field_err(
2579 ) -> DiagnosticBuilder<'_, ErrorGuaranteed> {
2580 let span = field.span;
2581 debug!("no_such_field_err(span: {:?}, field: {:?}, expr_t: {:?})", span, field, expr_t);
2583 let mut err = type_error_struct!(
2588 "no field `{field}` on type `{expr_t}`",
2591 // try to add a suggestion in case the field is a nested field of a field of the Adt
2592 let mod_id = self.tcx.parent_module(id).to_def_id();
2593 if let Some((fields, substs)) =
2594 self.get_field_candidates_considering_privacy(span, expr_t, mod_id)
2596 let candidate_fields: Vec<_> = fields
2597 .filter_map(|candidate_field| {
2598 self.check_for_nested_field_satisfying(
2600 &|candidate_field, _| candidate_field.ident(self.tcx()) == field,
2607 .map(|mut field_path| {
2611 .map(|id| id.name.to_ident_string())
2612 .collect::<Vec<String>>()
2615 .collect::<Vec<_>>();
2617 let len = candidate_fields.len();
2619 err.span_suggestions(
2620 field.span.shrink_to_lo(),
2622 "{} of the expressions' fields {} a field of the same name",
2623 if len > 1 { "some" } else { "one" },
2624 if len > 1 { "have" } else { "has" },
2626 candidate_fields.iter().map(|path| format!("{path}.")),
2627 Applicability::MaybeIncorrect,
2634 pub(crate) fn get_field_candidates_considering_privacy(
2639 ) -> Option<(impl Iterator<Item = &'tcx ty::FieldDef> + 'tcx, SubstsRef<'tcx>)> {
2640 debug!("get_field_candidates(span: {:?}, base_t: {:?}", span, base_ty);
2642 for (base_t, _) in self.autoderef(span, base_ty) {
2643 match base_t.kind() {
2644 ty::Adt(base_def, substs) if !base_def.is_enum() => {
2646 let fields = &base_def.non_enum_variant().fields;
2647 // Some struct, e.g. some that impl `Deref`, have all private fields
2648 // because you're expected to deref them to access the _real_ fields.
2649 // This, for example, will help us suggest accessing a field through a `Box<T>`.
2650 if fields.iter().all(|field| !field.vis.is_accessible_from(mod_id, tcx)) {
2656 .filter(move |field| field.vis.is_accessible_from(mod_id, tcx))
2657 // For compile-time reasons put a limit on number of fields we search
2668 /// This method is called after we have encountered a missing field error to recursively
2669 /// search for the field
2670 pub(crate) fn check_for_nested_field_satisfying(
2673 matches: &impl Fn(&ty::FieldDef, Ty<'tcx>) -> bool,
2674 candidate_field: &ty::FieldDef,
2675 subst: SubstsRef<'tcx>,
2676 mut field_path: Vec<Ident>,
2678 ) -> Option<Vec<Ident>> {
2680 "check_for_nested_field_satisfying(span: {:?}, candidate_field: {:?}, field_path: {:?}",
2681 span, candidate_field, field_path
2684 if field_path.len() > 3 {
2685 // For compile-time reasons and to avoid infinite recursion we only check for fields
2686 // up to a depth of three
2689 field_path.push(candidate_field.ident(self.tcx).normalize_to_macros_2_0());
2690 let field_ty = candidate_field.ty(self.tcx, subst);
2691 if matches(candidate_field, field_ty) {
2692 return Some(field_path);
2693 } else if let Some((nested_fields, subst)) =
2694 self.get_field_candidates_considering_privacy(span, field_ty, mod_id)
2696 // recursively search fields of `candidate_field` if it's a ty::Adt
2697 for field in nested_fields {
2698 if let Some(field_path) = self.check_for_nested_field_satisfying(
2706 return Some(field_path);
2714 fn check_expr_index(
2716 base: &'tcx hir::Expr<'tcx>,
2717 idx: &'tcx hir::Expr<'tcx>,
2718 expr: &'tcx hir::Expr<'tcx>,
2720 let base_t = self.check_expr(&base);
2721 let idx_t = self.check_expr(&idx);
2723 if base_t.references_error() {
2725 } else if idx_t.references_error() {
2728 let base_t = self.structurally_resolved_type(base.span, base_t);
2729 match self.lookup_indexing(expr, base, base_t, idx, idx_t) {
2730 Some((index_ty, element_ty)) => {
2731 // two-phase not needed because index_ty is never mutable
2732 self.demand_coerce(idx, idx_t, index_ty, None, AllowTwoPhase::No);
2733 self.select_obligations_where_possible(false, |errors| {
2734 self.point_at_index_if_possible(errors, idx.span)
2739 let mut err = type_error_struct!(
2744 "cannot index into a value of type `{base_t}`",
2746 // Try to give some advice about indexing tuples.
2747 if let ty::Tuple(..) = base_t.kind() {
2748 let mut needs_note = true;
2749 // If the index is an integer, we can show the actual
2750 // fixed expression:
2751 if let ExprKind::Lit(ref lit) = idx.kind {
2752 if let ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) = lit.node {
2753 let snip = self.tcx.sess.source_map().span_to_snippet(base.span);
2754 if let Ok(snip) = snip {
2755 err.span_suggestion(
2757 "to access tuple elements, use",
2758 format!("{snip}.{i}"),
2759 Applicability::MachineApplicable,
2767 "to access tuple elements, use tuple indexing \
2768 syntax (e.g., `tuple.0`)",
2779 fn point_at_index_if_possible(
2781 errors: &mut Vec<traits::FulfillmentError<'tcx>>,
2784 for error in errors {
2785 match error.obligation.predicate.kind().skip_binder() {
2786 ty::PredicateKind::Trait(predicate)
2787 if self.tcx.is_diagnostic_item(sym::SliceIndex, predicate.trait_ref.def_id) => {
2791 error.obligation.cause.span = span;
2795 fn check_expr_yield(
2797 value: &'tcx hir::Expr<'tcx>,
2798 expr: &'tcx hir::Expr<'tcx>,
2799 src: &'tcx hir::YieldSource,
2801 match self.resume_yield_tys {
2802 Some((resume_ty, yield_ty)) => {
2803 self.check_expr_coercable_to_type(&value, yield_ty, None);
2807 // Given that this `yield` expression was generated as a result of lowering a `.await`,
2808 // we know that the yield type must be `()`; however, the context won't contain this
2809 // information. Hence, we check the source of the yield expression here and check its
2810 // value's type against `()` (this check should always hold).
2811 None if src.is_await() => {
2812 self.check_expr_coercable_to_type(&value, self.tcx.mk_unit(), None);
2816 self.tcx.sess.emit_err(YieldExprOutsideOfGenerator { span: expr.span });
2817 // Avoid expressions without types during writeback (#78653).
2818 self.check_expr(value);
2824 fn check_expr_asm_operand(&self, expr: &'tcx hir::Expr<'tcx>, is_input: bool) {
2825 let needs = if is_input { Needs::None } else { Needs::MutPlace };
2826 let ty = self.check_expr_with_needs(expr, needs);
2827 self.require_type_is_sized(ty, expr.span, traits::InlineAsmSized);
2829 if !is_input && !expr.is_syntactic_place_expr() {
2830 let mut err = self.tcx.sess.struct_span_err(expr.span, "invalid asm output");
2831 err.span_label(expr.span, "cannot assign to this expression");
2835 // If this is an input value, we require its type to be fully resolved
2836 // at this point. This allows us to provide helpful coercions which help
2837 // pass the type candidate list in a later pass.
2839 // We don't require output types to be resolved at this point, which
2840 // allows them to be inferred based on how they are used later in the
2843 let ty = self.structurally_resolved_type(expr.span, ty);
2846 let fnptr_ty = self.tcx.mk_fn_ptr(ty.fn_sig(self.tcx));
2847 self.demand_coerce(expr, ty, fnptr_ty, None, AllowTwoPhase::No);
2849 ty::Ref(_, base_ty, mutbl) => {
2850 let ptr_ty = self.tcx.mk_ptr(ty::TypeAndMut { ty: base_ty, mutbl });
2851 self.demand_coerce(expr, ty, ptr_ty, None, AllowTwoPhase::No);
2858 fn check_expr_asm(&self, asm: &'tcx hir::InlineAsm<'tcx>) -> Ty<'tcx> {
2859 for (op, _op_sp) in asm.operands {
2861 hir::InlineAsmOperand::In { expr, .. } => {
2862 self.check_expr_asm_operand(expr, true);
2864 hir::InlineAsmOperand::Out { expr: Some(expr), .. }
2865 | hir::InlineAsmOperand::InOut { expr, .. } => {
2866 self.check_expr_asm_operand(expr, false);
2868 hir::InlineAsmOperand::Out { expr: None, .. } => {}
2869 hir::InlineAsmOperand::SplitInOut { in_expr, out_expr, .. } => {
2870 self.check_expr_asm_operand(in_expr, true);
2871 if let Some(out_expr) = out_expr {
2872 self.check_expr_asm_operand(out_expr, false);
2875 // `AnonConst`s have their own body and is type-checked separately.
2876 // As they don't flow into the type system we don't need them to
2878 hir::InlineAsmOperand::Const { .. } | hir::InlineAsmOperand::SymFn { .. } => {}
2879 hir::InlineAsmOperand::SymStatic { .. } => {}
2882 if asm.options.contains(ast::InlineAsmOptions::NORETURN) {
2883 self.tcx.types.never