compiler/rustc_hir_typeck/src/callee.rs

   1 use super::method::probe::{IsSuggestion, Mode, ProbeScope};
   2 use super::method::MethodCallee;
   3 use super::{Expectation, FnCtxt, TupleArgumentsFlag};
   4
   5 use crate::type_error_struct;
   6 use rustc_ast::util::parser::PREC_POSTFIX;
   7 use rustc_errors::{struct_span_err, Applicability, Diagnostic, StashKey};
   8 use rustc_hir as hir;
   9 use rustc_hir::def::{self, CtorKind, Namespace, Res};
  10 use rustc_hir::def_id::DefId;
  11 use rustc_infer::{
  12     infer,
  13     traits::{self, Obligation},
  14 };
  15 use rustc_infer::{
  16     infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind},
  17     traits::ObligationCause,
  18 };
  19 use rustc_middle::ty::adjustment::{
  20     Adjust, Adjustment, AllowTwoPhase, AutoBorrow, AutoBorrowMutability,
  21 };
  22 use rustc_middle::ty::SubstsRef;
  23 use rustc_middle::ty::{self, Ty, TyCtxt, TypeVisitable};
  24 use rustc_span::def_id::LocalDefId;
  25 use rustc_span::symbol::{sym, Ident};
  26 use rustc_span::Span;
  27 use rustc_target::spec::abi;
  28 use rustc_trait_selection::autoderef::Autoderef;
  29 use rustc_trait_selection::infer::InferCtxtExt as _;
  30 use rustc_trait_selection::traits::error_reporting::DefIdOrName;
  31 use rustc_trait_selection::traits::query::evaluate_obligation::InferCtxtExt as _;
  32
  33 use std::{iter, slice};
  34
  35 /// Checks that it is legal to call methods of the trait corresponding
  36 /// to `trait_id` (this only cares about the trait, not the specific
  37 /// method that is called).
  38 pub fn check_legal_trait_for_method_call(
  39     tcx: TyCtxt<'_>,
  40     span: Span,
  41     receiver: Option<Span>,
  42     expr_span: Span,
  43     trait_id: DefId,
  44 ) {
  45     if tcx.lang_items().drop_trait() == Some(trait_id) {
  46         let mut err = struct_span_err!(tcx.sess, span, E0040, "explicit use of destructor method");
  47         err.span_label(span, "explicit destructor calls not allowed");
  48
  49         let (sp, suggestion) = receiver
  50             .and_then(|s| tcx.sess.source_map().span_to_snippet(s).ok())
  51             .filter(|snippet| !snippet.is_empty())
  52             .map(|snippet| (expr_span, format!("drop({snippet})")))
  53             .unwrap_or_else(|| (span, "drop".to_string()));
  54
  55         err.span_suggestion(
  56             sp,
  57             "consider using `drop` function",
  58             suggestion,
  59             Applicability::MaybeIncorrect,
  60         );
  61
  62         err.emit();
  63     }
  64 }
  65
  66 #[derive(Debug)]
  67 enum CallStep<'tcx> {
  68     Builtin(Ty<'tcx>),
  69     DeferredClosure(LocalDefId, ty::FnSig<'tcx>),
  70     /// E.g., enum variant constructors.
  71     Overloaded(MethodCallee<'tcx>),
  72 }
  73
  74 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
  75     pub fn check_call(
  76         &self,
  77         call_expr: &'tcx hir::Expr<'tcx>,
  78         callee_expr: &'tcx hir::Expr<'tcx>,
  79         arg_exprs: &'tcx [hir::Expr<'tcx>],
  80         expected: Expectation<'tcx>,
  81     ) -> Ty<'tcx> {
  82         let original_callee_ty = match &callee_expr.kind {
  83             hir::ExprKind::Path(hir::QPath::Resolved(..) | hir::QPath::TypeRelative(..)) => self
  84                 .check_expr_with_expectation_and_args(
  85                     callee_expr,
  86                     Expectation::NoExpectation,
  87                     arg_exprs,
  88                 ),
  89             _ => self.check_expr(callee_expr),
  90         };
  91
  92         let expr_ty = self.structurally_resolved_type(call_expr.span, original_callee_ty);
  93
  94         let mut autoderef = self.autoderef(callee_expr.span, expr_ty);
  95         let mut result = None;
  96         while result.is_none() && autoderef.next().is_some() {
  97             result = self.try_overloaded_call_step(call_expr, callee_expr, arg_exprs, &autoderef);
  98         }
  99         self.register_predicates(autoderef.into_obligations());
 100
 101         let output = match result {
 102             None => {
 103                 // this will report an error since original_callee_ty is not a fn
 104                 self.confirm_builtin_call(
 105                     call_expr,
 106                     callee_expr,
 107                     original_callee_ty,
 108                     arg_exprs,
 109                     expected,
 110                 )
 111             }
 112
 113             Some(CallStep::Builtin(callee_ty)) => {
 114                 self.confirm_builtin_call(call_expr, callee_expr, callee_ty, arg_exprs, expected)
 115             }
 116
 117             Some(CallStep::DeferredClosure(def_id, fn_sig)) => {
 118                 self.confirm_deferred_closure_call(call_expr, arg_exprs, expected, def_id, fn_sig)
 119             }
 120
 121             Some(CallStep::Overloaded(method_callee)) => {
 122                 self.confirm_overloaded_call(call_expr, arg_exprs, expected, method_callee)
 123             }
 124         };
 125
 126         // we must check that return type of called functions is WF:
 127         self.register_wf_obligation(output.into(), call_expr.span, traits::WellFormed(None));
 128
 129         output
 130     }
 131
 132     #[instrument(level = "debug", skip(self, call_expr, callee_expr, arg_exprs, autoderef), ret)]
 133     fn try_overloaded_call_step(
 134         &self,
 135         call_expr: &'tcx hir::Expr<'tcx>,
 136         callee_expr: &'tcx hir::Expr<'tcx>,
 137         arg_exprs: &'tcx [hir::Expr<'tcx>],
 138         autoderef: &Autoderef<'a, 'tcx>,
 139     ) -> Option<CallStep<'tcx>> {
 140         let adjusted_ty =
 141             self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
 142
 143         // If the callee is a bare function or a closure, then we're all set.
 144         match *adjusted_ty.kind() {
 145             ty::FnDef(..) | ty::FnPtr(_) => {
 146                 let adjustments = self.adjust_steps(autoderef);
 147                 self.apply_adjustments(callee_expr, adjustments);
 148                 return Some(CallStep::Builtin(adjusted_ty));
 149             }
 150
 151             ty::Closure(def_id, substs) => {
 152                 let def_id = def_id.expect_local();
 153
 154                 // Check whether this is a call to a closure where we
 155                 // haven't yet decided on whether the closure is fn vs
 156                 // fnmut vs fnonce. If so, we have to defer further processing.
 157                 if self.closure_kind(substs).is_none() {
 158                     let closure_sig = substs.as_closure().sig();
 159                     let closure_sig = self.replace_bound_vars_with_fresh_vars(
 160                         call_expr.span,
 161                         infer::FnCall,
 162                         closure_sig,
 163                     );
 164                     let adjustments = self.adjust_steps(autoderef);
 165                     self.record_deferred_call_resolution(
 166                         def_id,
 167                         DeferredCallResolution {
 168                             call_expr,
 169                             callee_expr,
 170                             adjusted_ty,
 171                             adjustments,
 172                             fn_sig: closure_sig,
 173                             closure_substs: substs,
 174                         },
 175                     );
 176                     return Some(CallStep::DeferredClosure(def_id, closure_sig));
 177                 }
 178             }
 179
 180             // Hack: we know that there are traits implementing Fn for &F
 181             // where F:Fn and so forth. In the particular case of types
 182             // like `f: &mut FnMut()`, if there is a call `f()`, we would
 183             // normally translate to `FnMut::call_mut(&mut f, ())`, but
 184             // that winds up potentially requiring the user to mark their
 185             // variable as `mut` which feels unnecessary and unexpected.
 186             //
 187             //     fn foo(f: &mut impl FnMut()) { f() }
 188             //            ^ without this hack `f` would have to be declared as mutable
 189             //
 190             // The simplest fix by far is to just ignore this case and deref again,
 191             // so we wind up with `FnMut::call_mut(&mut *f, ())`.
 192             ty::Ref(..) if autoderef.step_count() == 0 => {
 193                 return None;
 194             }
 195
 196             ty::Error(_) => {
 197                 return None;
 198             }
 199
 200             _ => {}
 201         }
 202
 203         // Now, we look for the implementation of a Fn trait on the object's type.
 204         // We first do it with the explicit instruction to look for an impl of
 205         // `Fn<Tuple>`, with the tuple `Tuple` having an arity corresponding
 206         // to the number of call parameters.
 207         // If that fails (or_else branch), we try again without specifying the
 208         // shape of the tuple (hence the None). This allows to detect an Fn trait
 209         // is implemented, and use this information for diagnostic.
 210         self.try_overloaded_call_traits(call_expr, adjusted_ty, Some(arg_exprs))
 211             .or_else(|| self.try_overloaded_call_traits(call_expr, adjusted_ty, None))
 212             .map(|(autoref, method)| {
 213                 let mut adjustments = self.adjust_steps(autoderef);
 214                 adjustments.extend(autoref);
 215                 self.apply_adjustments(callee_expr, adjustments);
 216                 CallStep::Overloaded(method)
 217             })
 218     }
 219
 220     fn try_overloaded_call_traits(
 221         &self,
 222         call_expr: &hir::Expr<'_>,
 223         adjusted_ty: Ty<'tcx>,
 224         opt_arg_exprs: Option<&'tcx [hir::Expr<'tcx>]>,
 225     ) -> Option<(Option<Adjustment<'tcx>>, MethodCallee<'tcx>)> {
 226         // Try the options that are least restrictive on the caller first.
 227         for (opt_trait_def_id, method_name, borrow) in [
 228             (self.tcx.lang_items().fn_trait(), Ident::with_dummy_span(sym::call), true),
 229             (self.tcx.lang_items().fn_mut_trait(), Ident::with_dummy_span(sym::call_mut), true),
 230             (self.tcx.lang_items().fn_once_trait(), Ident::with_dummy_span(sym::call_once), false),
 231         ] {
 232             let Some(trait_def_id) = opt_trait_def_id else { continue };
 233
 234             let opt_input_type = opt_arg_exprs.map(|arg_exprs| {
 235                 self.tcx.mk_tup(arg_exprs.iter().map(|e| {
 236                     self.next_ty_var(TypeVariableOrigin {
 237                         kind: TypeVariableOriginKind::TypeInference,
 238                         span: e.span,
 239                     })
 240                 }))
 241             });
 242
 243             if let Some(ok) = self.lookup_method_in_trait(
 244                 call_expr.span,
 245                 method_name,
 246                 trait_def_id,
 247                 adjusted_ty,
 248                 opt_input_type.as_ref().map(slice::from_ref),
 249             ) {
 250                 let method = self.register_infer_ok_obligations(ok);
 251                 let mut autoref = None;
 252                 if borrow {
 253                     // Check for &self vs &mut self in the method signature. Since this is either
 254                     // the Fn or FnMut trait, it should be one of those.
 255                     let ty::Ref(region, _, mutbl) = method.sig.inputs()[0].kind() else {
 256                         // The `fn`/`fn_mut` lang item is ill-formed, which should have
 257                         // caused an error elsewhere.
 258                         self.tcx
 259                             .sess
 260                             .delay_span_bug(call_expr.span, "input to call/call_mut is not a ref?");
 261                         return None;
 262                     };
 263
 264                     // For initial two-phase borrow
 265                     // deployment, conservatively omit
 266                     // overloaded function call ops.
 267                     let mutbl = AutoBorrowMutability::new(*mutbl, AllowTwoPhase::No);
 268
 269                     autoref = Some(Adjustment {
 270                         kind: Adjust::Borrow(AutoBorrow::Ref(*region, mutbl)),
 271                         target: method.sig.inputs()[0],
 272                     });
 273                 }
 274                 return Some((autoref, method));
 275             }
 276         }
 277
 278         None
 279     }
 280
 281     /// Give appropriate suggestion when encountering `||{/* not callable */}()`, where the
 282     /// likely intention is to call the closure, suggest `(||{})()`. (#55851)
 283     fn identify_bad_closure_def_and_call(
 284         &self,
 285         err: &mut Diagnostic,
 286         hir_id: hir::HirId,
 287         callee_node: &hir::ExprKind<'_>,
 288         callee_span: Span,
 289     ) {
 290         let hir = self.tcx.hir();
 291         let parent_hir_id = hir.get_parent_node(hir_id);
 292         let parent_node = hir.get(parent_hir_id);
 293         if let (
 294             hir::Node::Expr(hir::Expr {
 295                 kind: hir::ExprKind::Closure(&hir::Closure { fn_decl_span, body, .. }),
 296                 ..
 297             }),
 298             hir::ExprKind::Block(..),
 299         ) = (parent_node, callee_node)
 300         {
 301             let fn_decl_span = if hir.body(body).generator_kind
 302                 == Some(hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Closure))
 303             {
 304                 // Actually need to unwrap a few more layers of HIR to get to
 305                 // the _real_ closure...
 306                 let async_closure = hir.get_parent_node(hir.get_parent_node(parent_hir_id));
 307                 if let hir::Node::Expr(hir::Expr {
 308                     kind: hir::ExprKind::Closure(&hir::Closure { fn_decl_span, .. }),
 309                     ..
 310                 }) = hir.get(async_closure)
 311                 {
 312                     fn_decl_span
 313                 } else {
 314                     return;
 315                 }
 316             } else {
 317                 fn_decl_span
 318             };
 319
 320             let start = fn_decl_span.shrink_to_lo();
 321             let end = callee_span.shrink_to_hi();
 322             err.multipart_suggestion(
 323                 "if you meant to create this closure and immediately call it, surround the \
 324                 closure with parentheses",
 325                 vec![(start, "(".to_string()), (end, ")".to_string())],
 326                 Applicability::MaybeIncorrect,
 327             );
 328         }
 329     }
 330
 331     /// Give appropriate suggestion when encountering `[("a", 0) ("b", 1)]`, where the
 332     /// likely intention is to create an array containing tuples.
 333     fn maybe_suggest_bad_array_definition(
 334         &self,
 335         err: &mut Diagnostic,
 336         call_expr: &'tcx hir::Expr<'tcx>,
 337         callee_expr: &'tcx hir::Expr<'tcx>,
 338     ) -> bool {
 339         let hir_id = self.tcx.hir().get_parent_node(call_expr.hir_id);
 340         let parent_node = self.tcx.hir().get(hir_id);
 341         if let (
 342             hir::Node::Expr(hir::Expr { kind: hir::ExprKind::Array(_), .. }),
 343             hir::ExprKind::Tup(exp),
 344             hir::ExprKind::Call(_, args),
 345         ) = (parent_node, &callee_expr.kind, &call_expr.kind)
 346             && args.len() == exp.len()
 347         {
 348             let start = callee_expr.span.shrink_to_hi();
 349             err.span_suggestion(
 350                 start,
 351                 "consider separating array elements with a comma",
 352                 ",",
 353                 Applicability::MaybeIncorrect,
 354             );
 355             return true;
 356         }
 357         false
 358     }
 359
 360     fn confirm_builtin_call(
 361         &self,
 362         call_expr: &'tcx hir::Expr<'tcx>,
 363         callee_expr: &'tcx hir::Expr<'tcx>,
 364         callee_ty: Ty<'tcx>,
 365         arg_exprs: &'tcx [hir::Expr<'tcx>],
 366         expected: Expectation<'tcx>,
 367     ) -> Ty<'tcx> {
 368         let (fn_sig, def_id) = match *callee_ty.kind() {
 369             ty::FnDef(def_id, subst) => {
 370                 let fn_sig = self.tcx.bound_fn_sig(def_id).subst(self.tcx, subst);
 371
 372                 // Unit testing: function items annotated with
 373                 // `#[rustc_evaluate_where_clauses]` trigger special output
 374                 // to let us test the trait evaluation system.
 375                 if self.tcx.has_attr(def_id, sym::rustc_evaluate_where_clauses) {
 376                     let predicates = self.tcx.predicates_of(def_id);
 377                     let predicates = predicates.instantiate(self.tcx, subst);
 378                     for (predicate, predicate_span) in
 379                         predicates.predicates.iter().zip(&predicates.spans)
 380                     {
 381                         let obligation = Obligation::new(
 382                             self.tcx,
 383                             ObligationCause::dummy_with_span(callee_expr.span),
 384                             self.param_env,
 385                             *predicate,
 386                         );
 387                         let result = self.evaluate_obligation(&obligation);
 388                         self.tcx
 389                             .sess
 390                             .struct_span_err(
 391                                 callee_expr.span,
 392                                 &format!("evaluate({:?}) = {:?}", predicate, result),
 393                             )
 394                             .span_label(*predicate_span, "predicate")
 395                             .emit();
 396                     }
 397                 }
 398                 (fn_sig, Some(def_id))
 399             }
 400             ty::FnPtr(sig) => (sig, None),
 401             _ => {
 402                 if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = &callee_expr.kind
 403                     && let [segment] = path.segments
 404                     && let Some(mut diag) = self
 405                         .tcx
 406                         .sess
 407                         .diagnostic()
 408                         .steal_diagnostic(segment.ident.span, StashKey::CallIntoMethod)
 409                 {
 410                     // Try suggesting `foo(a)` -> `a.foo()` if possible.
 411                     if let Some(ty) =
 412                         self.suggest_call_as_method(
 413                             &mut diag,
 414                             segment,
 415                             arg_exprs,
 416                             call_expr,
 417                             expected
 418                         )
 419                     {
 420                         diag.emit();
 421                         return ty;
 422                     } else {
 423                         diag.emit();
 424                     }
 425                 }
 426
 427                 self.report_invalid_callee(call_expr, callee_expr, callee_ty, arg_exprs);
 428
 429                 // This is the "default" function signature, used in case of error.
 430                 // In that case, we check each argument against "error" in order to
 431                 // set up all the node type bindings.
 432                 (
 433                     ty::Binder::dummy(self.tcx.mk_fn_sig(
 434                         self.err_args(arg_exprs.len()).into_iter(),
 435                         self.tcx.ty_error(),
 436                         false,
 437                         hir::Unsafety::Normal,
 438                         abi::Abi::Rust,
 439                     )),
 440                     None,
 441                 )
 442             }
 443         };
 444
 445         // Replace any late-bound regions that appear in the function
 446         // signature with region variables. We also have to
 447         // renormalize the associated types at this point, since they
 448         // previously appeared within a `Binder<>` and hence would not
 449         // have been normalized before.
 450         let fn_sig = self.replace_bound_vars_with_fresh_vars(call_expr.span, infer::FnCall, fn_sig);
 451         let fn_sig = self.normalize(call_expr.span, fn_sig);
 452
 453         // Call the generic checker.
 454         let expected_arg_tys = self.expected_inputs_for_expected_output(
 455             call_expr.span,
 456             expected,
 457             fn_sig.output(),
 458             fn_sig.inputs(),
 459         );
 460         self.check_argument_types(
 461             call_expr.span,
 462             call_expr,
 463             fn_sig.inputs(),
 464             expected_arg_tys,
 465             arg_exprs,
 466             fn_sig.c_variadic,
 467             TupleArgumentsFlag::DontTupleArguments,
 468             def_id,
 469         );
 470
 471         if fn_sig.abi == abi::Abi::RustCall {
 472             let sp = arg_exprs.last().map_or(call_expr.span, |expr| expr.span);
 473             if let Some(ty) = fn_sig.inputs().last().copied() {
 474                 self.register_bound(
 475                     ty,
 476                     self.tcx.require_lang_item(hir::LangItem::Tuple, Some(sp)),
 477                     traits::ObligationCause::new(sp, self.body_id, traits::RustCall),
 478                 );
 479             } else {
 480                 self.tcx.sess.span_err(
 481                         sp,
 482                         "functions with the \"rust-call\" ABI must take a single non-self tuple argument",
 483                     );
 484             }
 485         }
 486
 487         fn_sig.output()
 488     }
 489
 490     /// Attempts to reinterpret `method(rcvr, args...)` as `rcvr.method(args...)`
 491     /// and suggesting the fix if the method probe is successful.
 492     fn suggest_call_as_method(
 493         &self,
 494         diag: &mut Diagnostic,
 495         segment: &'tcx hir::PathSegment<'tcx>,
 496         arg_exprs: &'tcx [hir::Expr<'tcx>],
 497         call_expr: &'tcx hir::Expr<'tcx>,
 498         expected: Expectation<'tcx>,
 499     ) -> Option<Ty<'tcx>> {
 500         if let [callee_expr, rest @ ..] = arg_exprs {
 501             let callee_ty = self.check_expr(callee_expr);
 502             // First, do a probe with `IsSuggestion(true)` to avoid emitting
 503             // any strange errors. If it's successful, then we'll do a true
 504             // method lookup.
 505             let Ok(pick) = self
 506             .probe_for_name(
 507                 Mode::MethodCall,
 508                 segment.ident,
 509                 IsSuggestion(true),
 510                 callee_ty,
 511                 call_expr.hir_id,
 512                 // We didn't record the in scope traits during late resolution
 513                 // so we need to probe AllTraits unfortunately
 514                 ProbeScope::AllTraits,
 515             ) else {
 516                 return None;
 517             };
 518
 519             let pick = self.confirm_method(
 520                 call_expr.span,
 521                 callee_expr,
 522                 call_expr,
 523                 callee_ty,
 524                 pick,
 525                 segment,
 526             );
 527             if pick.illegal_sized_bound.is_some() {
 528                 return None;
 529             }
 530
 531             let up_to_rcvr_span = segment.ident.span.until(callee_expr.span);
 532             let rest_span = callee_expr.span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
 533             let rest_snippet = if let Some(first) = rest.first() {
 534                 self.tcx
 535                     .sess
 536                     .source_map()
 537                     .span_to_snippet(first.span.to(call_expr.span.shrink_to_hi()))
 538             } else {
 539                 Ok(")".to_string())
 540             };
 541
 542             if let Ok(rest_snippet) = rest_snippet {
 543                 let sugg = if callee_expr.precedence().order() >= PREC_POSTFIX {
 544                     vec![
 545                         (up_to_rcvr_span, "".to_string()),
 546                         (rest_span, format!(".{}({rest_snippet}", segment.ident)),
 547                     ]
 548                 } else {
 549                     vec![
 550                         (up_to_rcvr_span, "(".to_string()),
 551                         (rest_span, format!(").{}({rest_snippet}", segment.ident)),
 552                     ]
 553                 };
 554                 let self_ty = self.resolve_vars_if_possible(pick.callee.sig.inputs()[0]);
 555                 diag.multipart_suggestion(
 556                     format!(
 557                         "use the `.` operator to call the method `{}{}` on `{self_ty}`",
 558                         self.tcx
 559                             .associated_item(pick.callee.def_id)
 560                             .trait_container(self.tcx)
 561                             .map_or_else(
 562                                 || String::new(),
 563                                 |trait_def_id| self.tcx.def_path_str(trait_def_id) + "::"
 564                             ),
 565                         segment.ident
 566                     ),
 567                     sugg,
 568                     Applicability::MaybeIncorrect,
 569                 );
 570
 571                 // Let's check the method fully now
 572                 let return_ty = self.check_method_argument_types(
 573                     segment.ident.span,
 574                     call_expr,
 575                     Ok(pick.callee),
 576                     rest,
 577                     TupleArgumentsFlag::DontTupleArguments,
 578                     expected,
 579                 );
 580
 581                 return Some(return_ty);
 582             }
 583         }
 584
 585         None
 586     }
 587
 588     fn report_invalid_callee(
 589         &self,
 590         call_expr: &'tcx hir::Expr<'tcx>,
 591         callee_expr: &'tcx hir::Expr<'tcx>,
 592         callee_ty: Ty<'tcx>,
 593         arg_exprs: &'tcx [hir::Expr<'tcx>],
 594     ) {
 595         let mut unit_variant = None;
 596         if let hir::ExprKind::Path(qpath) = &callee_expr.kind
 597             && let Res::Def(def::DefKind::Ctor(kind, CtorKind::Const), _)
 598                 = self.typeck_results.borrow().qpath_res(qpath, callee_expr.hir_id)
 599             // Only suggest removing parens if there are no arguments
 600             && arg_exprs.is_empty()
 601         {
 602             let descr = match kind {
 603                 def::CtorOf::Struct => "struct",
 604                 def::CtorOf::Variant => "enum variant",
 605             };
 606             let removal_span = callee_expr.span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
 607             unit_variant = Some((removal_span, descr, rustc_hir_pretty::qpath_to_string(qpath)));
 608         }
 609
 610         let callee_ty = self.resolve_vars_if_possible(callee_ty);
 611         let mut err = type_error_struct!(
 612             self.tcx.sess,
 613             callee_expr.span,
 614             callee_ty,
 615             E0618,
 616             "expected function, found {}",
 617             match &unit_variant {
 618                 Some((_, kind, path)) => format!("{kind} `{path}`"),
 619                 None => format!("`{callee_ty}`"),
 620             }
 621         );
 622
 623         self.identify_bad_closure_def_and_call(
 624             &mut err,
 625             call_expr.hir_id,
 626             &callee_expr.kind,
 627             callee_expr.span,
 628         );
 629
 630         if let Some((removal_span, kind, path)) = &unit_variant {
 631             err.span_suggestion_verbose(
 632                 *removal_span,
 633                 &format!(
 634                     "`{path}` is a unit {kind}, and does not take parentheses to be constructed",
 635                 ),
 636                 "",
 637                 Applicability::MachineApplicable,
 638             );
 639         }
 640
 641         let mut inner_callee_path = None;
 642         let def = match callee_expr.kind {
 643             hir::ExprKind::Path(ref qpath) => {
 644                 self.typeck_results.borrow().qpath_res(qpath, callee_expr.hir_id)
 645             }
 646             hir::ExprKind::Call(ref inner_callee, _) => {
 647                 // If the call spans more than one line and the callee kind is
 648                 // itself another `ExprCall`, that's a clue that we might just be
 649                 // missing a semicolon (Issue #51055)
 650                 let call_is_multiline = self.tcx.sess.source_map().is_multiline(call_expr.span);
 651                 if call_is_multiline {
 652                     err.span_suggestion(
 653                         callee_expr.span.shrink_to_hi(),
 654                         "consider using a semicolon here",
 655                         ";",
 656                         Applicability::MaybeIncorrect,
 657                     );
 658                 }
 659                 if let hir::ExprKind::Path(ref inner_qpath) = inner_callee.kind {
 660                     inner_callee_path = Some(inner_qpath);
 661                     self.typeck_results.borrow().qpath_res(inner_qpath, inner_callee.hir_id)
 662                 } else {
 663                     Res::Err
 664                 }
 665             }
 666             _ => Res::Err,
 667         };
 668
 669         if !self.maybe_suggest_bad_array_definition(&mut err, call_expr, callee_expr) {
 670             if let Some((maybe_def, output_ty, _)) =
 671                 self.extract_callable_info(callee_expr, callee_ty)
 672                 && !self.type_is_sized_modulo_regions(self.param_env, output_ty, callee_expr.span)
 673             {
 674                 let descr = match maybe_def {
 675                     DefIdOrName::DefId(def_id) => self.tcx.def_kind(def_id).descr(def_id),
 676                     DefIdOrName::Name(name) => name,
 677                 };
 678                 err.span_label(
 679                     callee_expr.span,
 680                     format!("this {descr} returns an unsized value `{output_ty}`, so it cannot be called")
 681                 );
 682                 if let DefIdOrName::DefId(def_id) = maybe_def
 683                     && let Some(def_span) = self.tcx.hir().span_if_local(def_id)
 684                 {
 685                     err.span_label(def_span, "the callable type is defined here");
 686                 }
 687             } else {
 688                 err.span_label(call_expr.span, "call expression requires function");
 689             }
 690         }
 691
 692         if let Some(span) = self.tcx.hir().res_span(def) {
 693             let callee_ty = callee_ty.to_string();
 694             let label = match (unit_variant, inner_callee_path) {
 695                 (Some((_, kind, path)), _) => Some(format!("{kind} `{path}` defined here")),
 696                 (_, Some(hir::QPath::Resolved(_, path))) => self
 697                     .tcx
 698                     .sess
 699                     .source_map()
 700                     .span_to_snippet(path.span)
 701                     .ok()
 702                     .map(|p| format!("`{p}` defined here returns `{callee_ty}`")),
 703                 _ => {
 704                     match def {
 705                         // Emit a different diagnostic for local variables, as they are not
 706                         // type definitions themselves, but rather variables *of* that type.
 707                         Res::Local(hir_id) => Some(format!(
 708                             "`{}` has type `{}`",
 709                             self.tcx.hir().name(hir_id),
 710                             callee_ty
 711                         )),
 712                         Res::Def(kind, def_id) if kind.ns() == Some(Namespace::ValueNS) => {
 713                             Some(format!("`{}` defined here", self.tcx.def_path_str(def_id),))
 714                         }
 715                         _ => Some(format!("`{callee_ty}` defined here")),
 716                     }
 717                 }
 718             };
 719             if let Some(label) = label {
 720                 err.span_label(span, label);
 721             }
 722         }
 723         err.emit();
 724     }
 725
 726     fn confirm_deferred_closure_call(
 727         &self,
 728         call_expr: &'tcx hir::Expr<'tcx>,
 729         arg_exprs: &'tcx [hir::Expr<'tcx>],
 730         expected: Expectation<'tcx>,
 731         closure_def_id: LocalDefId,
 732         fn_sig: ty::FnSig<'tcx>,
 733     ) -> Ty<'tcx> {
 734         // `fn_sig` is the *signature* of the closure being called. We
 735         // don't know the full details yet (`Fn` vs `FnMut` etc), but we
 736         // do know the types expected for each argument and the return
 737         // type.
 738
 739         let expected_arg_tys = self.expected_inputs_for_expected_output(
 740             call_expr.span,
 741             expected,
 742             fn_sig.output(),
 743             fn_sig.inputs(),
 744         );
 745
 746         self.check_argument_types(
 747             call_expr.span,
 748             call_expr,
 749             fn_sig.inputs(),
 750             expected_arg_tys,
 751             arg_exprs,
 752             fn_sig.c_variadic,
 753             TupleArgumentsFlag::TupleArguments,
 754             Some(closure_def_id.to_def_id()),
 755         );
 756
 757         fn_sig.output()
 758     }
 759
 760     fn confirm_overloaded_call(
 761         &self,
 762         call_expr: &'tcx hir::Expr<'tcx>,
 763         arg_exprs: &'tcx [hir::Expr<'tcx>],
 764         expected: Expectation<'tcx>,
 765         method_callee: MethodCallee<'tcx>,
 766     ) -> Ty<'tcx> {
 767         let output_type = self.check_method_argument_types(
 768             call_expr.span,
 769             call_expr,
 770             Ok(method_callee),
 771             arg_exprs,
 772             TupleArgumentsFlag::TupleArguments,
 773             expected,
 774         );
 775
 776         self.write_method_call(call_expr.hir_id, method_callee);
 777         output_type
 778     }
 779 }
 780
 781 #[derive(Debug)]
 782 pub struct DeferredCallResolution<'tcx> {
 783     call_expr: &'tcx hir::Expr<'tcx>,
 784     callee_expr: &'tcx hir::Expr<'tcx>,
 785     adjusted_ty: Ty<'tcx>,
 786     adjustments: Vec<Adjustment<'tcx>>,
 787     fn_sig: ty::FnSig<'tcx>,
 788     closure_substs: SubstsRef<'tcx>,
 789 }
 790
 791 impl<'a, 'tcx> DeferredCallResolution<'tcx> {
 792     pub fn resolve(self, fcx: &FnCtxt<'a, 'tcx>) {
 793         debug!("DeferredCallResolution::resolve() {:?}", self);
 794
 795         // we should not be invoked until the closure kind has been
 796         // determined by upvar inference
 797         assert!(fcx.closure_kind(self.closure_substs).is_some());
 798
 799         // We may now know enough to figure out fn vs fnmut etc.
 800         match fcx.try_overloaded_call_traits(self.call_expr, self.adjusted_ty, None) {
 801             Some((autoref, method_callee)) => {
 802                 // One problem is that when we get here, we are going
 803                 // to have a newly instantiated function signature
 804                 // from the call trait. This has to be reconciled with
 805                 // the older function signature we had before. In
 806                 // principle we *should* be able to fn_sigs(), but we
 807                 // can't because of the annoying need for a TypeTrace.
 808                 // (This always bites me, should find a way to
 809                 // refactor it.)
 810                 let method_sig = method_callee.sig;
 811
 812                 debug!("attempt_resolution: method_callee={:?}", method_callee);
 813
 814                 for (method_arg_ty, self_arg_ty) in
 815                     iter::zip(method_sig.inputs().iter().skip(1), self.fn_sig.inputs())
 816                 {
 817                     fcx.demand_eqtype(self.call_expr.span, *self_arg_ty, *method_arg_ty);
 818                 }
 819
 820                 fcx.demand_eqtype(self.call_expr.span, method_sig.output(), self.fn_sig.output());
 821
 822                 let mut adjustments = self.adjustments;
 823                 adjustments.extend(autoref);
 824                 fcx.apply_adjustments(self.callee_expr, adjustments);
 825
 826                 fcx.write_method_call(self.call_expr.hir_id, method_callee);
 827             }
 828             None => {
 829                 // This can happen if `#![no_core]` is used and the `fn/fn_mut/fn_once`
 830                 // lang items are not defined (issue #86238).
 831                 let mut err = fcx.inh.tcx.sess.struct_span_err(
 832                     self.call_expr.span,
 833                     "failed to find an overloaded call trait for closure call",
 834                 );
 835                 err.help(
 836                     "make sure the `fn`/`fn_mut`/`fn_once` lang items are defined \
 837                      and have associated `call`/`call_mut`/`call_once` functions",
 838                 );
 839                 err.emit();
 840             }
 841         }
 842     }
 843 }