]> git.lizzy.rs Git - rust.git/blob - compiler/rustc_hir_typeck/src/callee.rs
c220956a2012e15620f124c86c5942b479587759
[rust.git] / compiler / rustc_hir_typeck / src / callee.rs
1 use super::method::probe::ProbeScope;
2 use super::method::MethodCallee;
3 use super::{Expectation, FnCtxt, TupleArgumentsFlag};
4
5 use crate::type_error_struct;
6 use rustc_ast::util::parser::PREC_POSTFIX;
7 use rustc_errors::{struct_span_err, Applicability, Diagnostic, ErrorGuaranteed, StashKey};
8 use rustc_hir as hir;
9 use rustc_hir::def::{self, CtorKind, Namespace, Res};
10 use rustc_hir::def_id::DefId;
11 use rustc_hir_analysis::autoderef::Autoderef;
12 use rustc_infer::{
13     infer,
14     traits::{self, Obligation},
15 };
16 use rustc_infer::{
17     infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind},
18     traits::ObligationCause,
19 };
20 use rustc_middle::ty::adjustment::{
21     Adjust, Adjustment, AllowTwoPhase, AutoBorrow, AutoBorrowMutability,
22 };
23 use rustc_middle::ty::SubstsRef;
24 use rustc_middle::ty::{self, Ty, TyCtxt, TypeVisitable};
25 use rustc_span::def_id::LocalDefId;
26 use rustc_span::symbol::{sym, Ident};
27 use rustc_span::Span;
28 use rustc_target::spec::abi;
29 use rustc_trait_selection::infer::InferCtxtExt as _;
30 use rustc_trait_selection::traits::error_reporting::DefIdOrName;
31 use rustc_trait_selection::traits::query::evaluate_obligation::InferCtxtExt as _;
32
33 use std::{iter, slice};
34
35 /// Checks that it is legal to call methods of the trait corresponding
36 /// to `trait_id` (this only cares about the trait, not the specific
37 /// method that is called).
38 pub fn check_legal_trait_for_method_call(
39     tcx: TyCtxt<'_>,
40     span: Span,
41     receiver: Option<Span>,
42     expr_span: Span,
43     trait_id: DefId,
44 ) {
45     if tcx.lang_items().drop_trait() == Some(trait_id) {
46         let mut err = struct_span_err!(tcx.sess, span, E0040, "explicit use of destructor method");
47         err.span_label(span, "explicit destructor calls not allowed");
48
49         let (sp, suggestion) = receiver
50             .and_then(|s| tcx.sess.source_map().span_to_snippet(s).ok())
51             .filter(|snippet| !snippet.is_empty())
52             .map(|snippet| (expr_span, format!("drop({snippet})")))
53             .unwrap_or_else(|| (span, "drop".to_string()));
54
55         err.span_suggestion(
56             sp,
57             "consider using `drop` function",
58             suggestion,
59             Applicability::MaybeIncorrect,
60         );
61
62         err.emit();
63     }
64 }
65
66 #[derive(Debug)]
67 enum CallStep<'tcx> {
68     Builtin(Ty<'tcx>),
69     DeferredClosure(LocalDefId, ty::FnSig<'tcx>),
70     /// E.g., enum variant constructors.
71     Overloaded(MethodCallee<'tcx>),
72 }
73
74 impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
75     pub fn check_call(
76         &self,
77         call_expr: &'tcx hir::Expr<'tcx>,
78         callee_expr: &'tcx hir::Expr<'tcx>,
79         arg_exprs: &'tcx [hir::Expr<'tcx>],
80         expected: Expectation<'tcx>,
81     ) -> Ty<'tcx> {
82         let original_callee_ty = match &callee_expr.kind {
83             hir::ExprKind::Path(hir::QPath::Resolved(..) | hir::QPath::TypeRelative(..)) => self
84                 .check_expr_with_expectation_and_args(
85                     callee_expr,
86                     Expectation::NoExpectation,
87                     arg_exprs,
88                 ),
89             _ => self.check_expr(callee_expr),
90         };
91
92         let expr_ty = self.structurally_resolved_type(call_expr.span, original_callee_ty);
93
94         let mut autoderef = self.autoderef(callee_expr.span, expr_ty);
95         let mut result = None;
96         while result.is_none() && autoderef.next().is_some() {
97             result = self.try_overloaded_call_step(call_expr, callee_expr, arg_exprs, &autoderef);
98         }
99         self.register_predicates(autoderef.into_obligations());
100
101         let output = match result {
102             None => {
103                 // this will report an error since original_callee_ty is not a fn
104                 self.confirm_builtin_call(
105                     call_expr,
106                     callee_expr,
107                     original_callee_ty,
108                     arg_exprs,
109                     expected,
110                 )
111             }
112
113             Some(CallStep::Builtin(callee_ty)) => {
114                 self.confirm_builtin_call(call_expr, callee_expr, callee_ty, arg_exprs, expected)
115             }
116
117             Some(CallStep::DeferredClosure(def_id, fn_sig)) => {
118                 self.confirm_deferred_closure_call(call_expr, arg_exprs, expected, def_id, fn_sig)
119             }
120
121             Some(CallStep::Overloaded(method_callee)) => {
122                 self.confirm_overloaded_call(call_expr, arg_exprs, expected, method_callee)
123             }
124         };
125
126         // we must check that return type of called functions is WF:
127         self.register_wf_obligation(output.into(), call_expr.span, traits::WellFormed(None));
128
129         output
130     }
131
132     #[instrument(level = "debug", skip(self, call_expr, callee_expr, arg_exprs, autoderef), ret)]
133     fn try_overloaded_call_step(
134         &self,
135         call_expr: &'tcx hir::Expr<'tcx>,
136         callee_expr: &'tcx hir::Expr<'tcx>,
137         arg_exprs: &'tcx [hir::Expr<'tcx>],
138         autoderef: &Autoderef<'a, 'tcx>,
139     ) -> Option<CallStep<'tcx>> {
140         let adjusted_ty =
141             self.structurally_resolved_type(autoderef.span(), autoderef.final_ty(false));
142
143         // If the callee is a bare function or a closure, then we're all set.
144         match *adjusted_ty.kind() {
145             ty::FnDef(..) | ty::FnPtr(_) => {
146                 let adjustments = self.adjust_steps(autoderef);
147                 self.apply_adjustments(callee_expr, adjustments);
148                 return Some(CallStep::Builtin(adjusted_ty));
149             }
150
151             ty::Closure(def_id, substs) => {
152                 let def_id = def_id.expect_local();
153
154                 // Check whether this is a call to a closure where we
155                 // haven't yet decided on whether the closure is fn vs
156                 // fnmut vs fnonce. If so, we have to defer further processing.
157                 if self.closure_kind(substs).is_none() {
158                     let closure_sig = substs.as_closure().sig();
159                     let closure_sig = self.replace_bound_vars_with_fresh_vars(
160                         call_expr.span,
161                         infer::FnCall,
162                         closure_sig,
163                     );
164                     let adjustments = self.adjust_steps(autoderef);
165                     self.record_deferred_call_resolution(
166                         def_id,
167                         DeferredCallResolution {
168                             call_expr,
169                             callee_expr,
170                             adjusted_ty,
171                             adjustments,
172                             fn_sig: closure_sig,
173                             closure_substs: substs,
174                         },
175                     );
176                     return Some(CallStep::DeferredClosure(def_id, closure_sig));
177                 }
178             }
179
180             // Hack: we know that there are traits implementing Fn for &F
181             // where F:Fn and so forth. In the particular case of types
182             // like `f: &mut FnMut()`, if there is a call `f()`, we would
183             // normally translate to `FnMut::call_mut(&mut f, ())`, but
184             // that winds up potentially requiring the user to mark their
185             // variable as `mut` which feels unnecessary and unexpected.
186             //
187             //     fn foo(f: &mut impl FnMut()) { f() }
188             //            ^ without this hack `f` would have to be declared as mutable
189             //
190             // The simplest fix by far is to just ignore this case and deref again,
191             // so we wind up with `FnMut::call_mut(&mut *f, ())`.
192             ty::Ref(..) if autoderef.step_count() == 0 => {
193                 return None;
194             }
195
196             ty::Error(_) => {
197                 return None;
198             }
199
200             _ => {}
201         }
202
203         // Now, we look for the implementation of a Fn trait on the object's type.
204         // We first do it with the explicit instruction to look for an impl of
205         // `Fn<Tuple>`, with the tuple `Tuple` having an arity corresponding
206         // to the number of call parameters.
207         // If that fails (or_else branch), we try again without specifying the
208         // shape of the tuple (hence the None). This allows to detect an Fn trait
209         // is implemented, and use this information for diagnostic.
210         self.try_overloaded_call_traits(call_expr, adjusted_ty, Some(arg_exprs))
211             .or_else(|| self.try_overloaded_call_traits(call_expr, adjusted_ty, None))
212             .map(|(autoref, method)| {
213                 let mut adjustments = self.adjust_steps(autoderef);
214                 adjustments.extend(autoref);
215                 self.apply_adjustments(callee_expr, adjustments);
216                 CallStep::Overloaded(method)
217             })
218     }
219
220     fn try_overloaded_call_traits(
221         &self,
222         call_expr: &hir::Expr<'_>,
223         adjusted_ty: Ty<'tcx>,
224         opt_arg_exprs: Option<&'tcx [hir::Expr<'tcx>]>,
225     ) -> Option<(Option<Adjustment<'tcx>>, MethodCallee<'tcx>)> {
226         // Try the options that are least restrictive on the caller first.
227         for (opt_trait_def_id, method_name, borrow) in [
228             (self.tcx.lang_items().fn_trait(), Ident::with_dummy_span(sym::call), true),
229             (self.tcx.lang_items().fn_mut_trait(), Ident::with_dummy_span(sym::call_mut), true),
230             (self.tcx.lang_items().fn_once_trait(), Ident::with_dummy_span(sym::call_once), false),
231         ] {
232             let Some(trait_def_id) = opt_trait_def_id else { continue };
233
234             let opt_input_type = opt_arg_exprs.map(|arg_exprs| {
235                 self.tcx.mk_tup(arg_exprs.iter().map(|e| {
236                     self.next_ty_var(TypeVariableOrigin {
237                         kind: TypeVariableOriginKind::TypeInference,
238                         span: e.span,
239                     })
240                 }))
241             });
242
243             if let Some(ok) = self.lookup_method_in_trait(
244                 self.misc(call_expr.span),
245                 method_name,
246                 trait_def_id,
247                 adjusted_ty,
248                 opt_input_type.as_ref().map(slice::from_ref),
249             ) {
250                 let method = self.register_infer_ok_obligations(ok);
251                 let mut autoref = None;
252                 if borrow {
253                     // Check for &self vs &mut self in the method signature. Since this is either
254                     // the Fn or FnMut trait, it should be one of those.
255                     let ty::Ref(region, _, mutbl) = method.sig.inputs()[0].kind() else {
256                         // The `fn`/`fn_mut` lang item is ill-formed, which should have
257                         // caused an error elsewhere.
258                         self.tcx
259                             .sess
260                             .delay_span_bug(call_expr.span, "input to call/call_mut is not a ref?");
261                         return None;
262                     };
263
264                     // For initial two-phase borrow
265                     // deployment, conservatively omit
266                     // overloaded function call ops.
267                     let mutbl = AutoBorrowMutability::new(*mutbl, AllowTwoPhase::No);
268
269                     autoref = Some(Adjustment {
270                         kind: Adjust::Borrow(AutoBorrow::Ref(*region, mutbl)),
271                         target: method.sig.inputs()[0],
272                     });
273                 }
274                 return Some((autoref, method));
275             }
276         }
277
278         None
279     }
280
281     /// Give appropriate suggestion when encountering `||{/* not callable */}()`, where the
282     /// likely intention is to call the closure, suggest `(||{})()`. (#55851)
283     fn identify_bad_closure_def_and_call(
284         &self,
285         err: &mut Diagnostic,
286         hir_id: hir::HirId,
287         callee_node: &hir::ExprKind<'_>,
288         callee_span: Span,
289     ) {
290         let hir = self.tcx.hir();
291         let parent_hir_id = hir.parent_id(hir_id);
292         let parent_node = hir.get(parent_hir_id);
293         if let (
294             hir::Node::Expr(hir::Expr {
295                 kind: hir::ExprKind::Closure(&hir::Closure { fn_decl_span, body, .. }),
296                 ..
297             }),
298             hir::ExprKind::Block(..),
299         ) = (parent_node, callee_node)
300         {
301             let fn_decl_span = if hir.body(body).generator_kind
302                 == Some(hir::GeneratorKind::Async(hir::AsyncGeneratorKind::Closure))
303             {
304                 // Actually need to unwrap a few more layers of HIR to get to
305                 // the _real_ closure...
306                 let async_closure = hir.parent_id(hir.parent_id(parent_hir_id));
307                 if let hir::Node::Expr(hir::Expr {
308                     kind: hir::ExprKind::Closure(&hir::Closure { fn_decl_span, .. }),
309                     ..
310                 }) = hir.get(async_closure)
311                 {
312                     fn_decl_span
313                 } else {
314                     return;
315                 }
316             } else {
317                 fn_decl_span
318             };
319
320             let start = fn_decl_span.shrink_to_lo();
321             let end = callee_span.shrink_to_hi();
322             err.multipart_suggestion(
323                 "if you meant to create this closure and immediately call it, surround the \
324                 closure with parentheses",
325                 vec![(start, "(".to_string()), (end, ")".to_string())],
326                 Applicability::MaybeIncorrect,
327             );
328         }
329     }
330
331     /// Give appropriate suggestion when encountering `[("a", 0) ("b", 1)]`, where the
332     /// likely intention is to create an array containing tuples.
333     fn maybe_suggest_bad_array_definition(
334         &self,
335         err: &mut Diagnostic,
336         call_expr: &'tcx hir::Expr<'tcx>,
337         callee_expr: &'tcx hir::Expr<'tcx>,
338     ) -> bool {
339         let hir_id = self.tcx.hir().parent_id(call_expr.hir_id);
340         let parent_node = self.tcx.hir().get(hir_id);
341         if let (
342             hir::Node::Expr(hir::Expr { kind: hir::ExprKind::Array(_), .. }),
343             hir::ExprKind::Tup(exp),
344             hir::ExprKind::Call(_, args),
345         ) = (parent_node, &callee_expr.kind, &call_expr.kind)
346             && args.len() == exp.len()
347         {
348             let start = callee_expr.span.shrink_to_hi();
349             err.span_suggestion(
350                 start,
351                 "consider separating array elements with a comma",
352                 ",",
353                 Applicability::MaybeIncorrect,
354             );
355             return true;
356         }
357         false
358     }
359
360     fn confirm_builtin_call(
361         &self,
362         call_expr: &'tcx hir::Expr<'tcx>,
363         callee_expr: &'tcx hir::Expr<'tcx>,
364         callee_ty: Ty<'tcx>,
365         arg_exprs: &'tcx [hir::Expr<'tcx>],
366         expected: Expectation<'tcx>,
367     ) -> Ty<'tcx> {
368         let (fn_sig, def_id) = match *callee_ty.kind() {
369             ty::FnDef(def_id, subst) => {
370                 let fn_sig = self.tcx.fn_sig(def_id).subst(self.tcx, subst);
371
372                 // Unit testing: function items annotated with
373                 // `#[rustc_evaluate_where_clauses]` trigger special output
374                 // to let us test the trait evaluation system.
375                 if self.tcx.has_attr(def_id, sym::rustc_evaluate_where_clauses) {
376                     let predicates = self.tcx.predicates_of(def_id);
377                     let predicates = predicates.instantiate(self.tcx, subst);
378                     for (predicate, predicate_span) in predicates {
379                         let obligation = Obligation::new(
380                             self.tcx,
381                             ObligationCause::dummy_with_span(callee_expr.span),
382                             self.param_env,
383                             predicate,
384                         );
385                         let result = self.evaluate_obligation(&obligation);
386                         self.tcx
387                             .sess
388                             .struct_span_err(
389                                 callee_expr.span,
390                                 &format!("evaluate({:?}) = {:?}", predicate, result),
391                             )
392                             .span_label(predicate_span, "predicate")
393                             .emit();
394                     }
395                 }
396                 (fn_sig, Some(def_id))
397             }
398             ty::FnPtr(sig) => (sig, None),
399             _ => {
400                 for arg in arg_exprs {
401                     self.check_expr(arg);
402                 }
403
404                 if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = &callee_expr.kind
405                     && let [segment] = path.segments
406                     && let Some(mut diag) = self
407                         .tcx
408                         .sess
409                         .diagnostic()
410                         .steal_diagnostic(segment.ident.span, StashKey::CallIntoMethod)
411                 {
412                     // Try suggesting `foo(a)` -> `a.foo()` if possible.
413                     if let Some(ty) =
414                         self.suggest_call_as_method(
415                             &mut diag,
416                             segment,
417                             arg_exprs,
418                             call_expr,
419                             expected
420                         )
421                     {
422                         diag.emit();
423                         return ty;
424                     } else {
425                         diag.emit();
426                     }
427                 }
428
429                 let err = self.report_invalid_callee(call_expr, callee_expr, callee_ty, arg_exprs);
430
431                 return self.tcx.ty_error_with_guaranteed(err);
432             }
433         };
434
435         // Replace any late-bound regions that appear in the function
436         // signature with region variables. We also have to
437         // renormalize the associated types at this point, since they
438         // previously appeared within a `Binder<>` and hence would not
439         // have been normalized before.
440         let fn_sig = self.replace_bound_vars_with_fresh_vars(call_expr.span, infer::FnCall, fn_sig);
441         let fn_sig = self.normalize(call_expr.span, fn_sig);
442
443         // Call the generic checker.
444         let expected_arg_tys = self.expected_inputs_for_expected_output(
445             call_expr.span,
446             expected,
447             fn_sig.output(),
448             fn_sig.inputs(),
449         );
450         self.check_argument_types(
451             call_expr.span,
452             call_expr,
453             fn_sig.inputs(),
454             expected_arg_tys,
455             arg_exprs,
456             fn_sig.c_variadic,
457             TupleArgumentsFlag::DontTupleArguments,
458             def_id,
459         );
460
461         if fn_sig.abi == abi::Abi::RustCall {
462             let sp = arg_exprs.last().map_or(call_expr.span, |expr| expr.span);
463             if let Some(ty) = fn_sig.inputs().last().copied() {
464                 self.register_bound(
465                     ty,
466                     self.tcx.require_lang_item(hir::LangItem::Tuple, Some(sp)),
467                     traits::ObligationCause::new(sp, self.body_id, traits::RustCall),
468                 );
469             } else {
470                 self.tcx.sess.span_err(
471                         sp,
472                         "functions with the \"rust-call\" ABI must take a single non-self tuple argument",
473                     );
474             }
475         }
476
477         fn_sig.output()
478     }
479
480     /// Attempts to reinterpret `method(rcvr, args...)` as `rcvr.method(args...)`
481     /// and suggesting the fix if the method probe is successful.
482     fn suggest_call_as_method(
483         &self,
484         diag: &mut Diagnostic,
485         segment: &'tcx hir::PathSegment<'tcx>,
486         arg_exprs: &'tcx [hir::Expr<'tcx>],
487         call_expr: &'tcx hir::Expr<'tcx>,
488         expected: Expectation<'tcx>,
489     ) -> Option<Ty<'tcx>> {
490         if let [callee_expr, rest @ ..] = arg_exprs {
491             let callee_ty = self.typeck_results.borrow().expr_ty_adjusted_opt(callee_expr)?;
492
493             // First, do a probe with `IsSuggestion(true)` to avoid emitting
494             // any strange errors. If it's successful, then we'll do a true
495             // method lookup.
496             let Ok(pick) = self
497             .lookup_probe_for_diagnostic(
498                 segment.ident,
499                 callee_ty,
500                 call_expr,
501                 // We didn't record the in scope traits during late resolution
502                 // so we need to probe AllTraits unfortunately
503                 ProbeScope::AllTraits,
504                 expected.only_has_type(self),
505             ) else {
506                 return None;
507             };
508
509             let pick = self.confirm_method(
510                 call_expr.span,
511                 callee_expr,
512                 call_expr,
513                 callee_ty,
514                 &pick,
515                 segment,
516             );
517             if pick.illegal_sized_bound.is_some() {
518                 return None;
519             }
520
521             let up_to_rcvr_span = segment.ident.span.until(callee_expr.span);
522             let rest_span = callee_expr.span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
523             let rest_snippet = if let Some(first) = rest.first() {
524                 self.tcx
525                     .sess
526                     .source_map()
527                     .span_to_snippet(first.span.to(call_expr.span.shrink_to_hi()))
528             } else {
529                 Ok(")".to_string())
530             };
531
532             if let Ok(rest_snippet) = rest_snippet {
533                 let sugg = if callee_expr.precedence().order() >= PREC_POSTFIX {
534                     vec![
535                         (up_to_rcvr_span, "".to_string()),
536                         (rest_span, format!(".{}({rest_snippet}", segment.ident)),
537                     ]
538                 } else {
539                     vec![
540                         (up_to_rcvr_span, "(".to_string()),
541                         (rest_span, format!(").{}({rest_snippet}", segment.ident)),
542                     ]
543                 };
544                 let self_ty = self.resolve_vars_if_possible(pick.callee.sig.inputs()[0]);
545                 diag.multipart_suggestion(
546                     format!(
547                         "use the `.` operator to call the method `{}{}` on `{self_ty}`",
548                         self.tcx
549                             .associated_item(pick.callee.def_id)
550                             .trait_container(self.tcx)
551                             .map_or_else(
552                                 || String::new(),
553                                 |trait_def_id| self.tcx.def_path_str(trait_def_id) + "::"
554                             ),
555                         segment.ident
556                     ),
557                     sugg,
558                     Applicability::MaybeIncorrect,
559                 );
560
561                 // Let's check the method fully now
562                 let return_ty = self.check_method_argument_types(
563                     segment.ident.span,
564                     call_expr,
565                     Ok(pick.callee),
566                     rest,
567                     TupleArgumentsFlag::DontTupleArguments,
568                     expected,
569                 );
570
571                 return Some(return_ty);
572             }
573         }
574
575         None
576     }
577
578     fn report_invalid_callee(
579         &self,
580         call_expr: &'tcx hir::Expr<'tcx>,
581         callee_expr: &'tcx hir::Expr<'tcx>,
582         callee_ty: Ty<'tcx>,
583         arg_exprs: &'tcx [hir::Expr<'tcx>],
584     ) -> ErrorGuaranteed {
585         let mut unit_variant = None;
586         if let hir::ExprKind::Path(qpath) = &callee_expr.kind
587             && let Res::Def(def::DefKind::Ctor(kind, CtorKind::Const), _)
588                 = self.typeck_results.borrow().qpath_res(qpath, callee_expr.hir_id)
589             // Only suggest removing parens if there are no arguments
590             && arg_exprs.is_empty()
591         {
592             let descr = match kind {
593                 def::CtorOf::Struct => "struct",
594                 def::CtorOf::Variant => "enum variant",
595             };
596             let removal_span = callee_expr.span.shrink_to_hi().to(call_expr.span.shrink_to_hi());
597             unit_variant = Some((removal_span, descr, rustc_hir_pretty::qpath_to_string(qpath)));
598         }
599
600         let callee_ty = self.resolve_vars_if_possible(callee_ty);
601         let mut err = type_error_struct!(
602             self.tcx.sess,
603             callee_expr.span,
604             callee_ty,
605             E0618,
606             "expected function, found {}",
607             match &unit_variant {
608                 Some((_, kind, path)) => format!("{kind} `{path}`"),
609                 None => format!("`{callee_ty}`"),
610             }
611         );
612
613         self.identify_bad_closure_def_and_call(
614             &mut err,
615             call_expr.hir_id,
616             &callee_expr.kind,
617             callee_expr.span,
618         );
619
620         if let Some((removal_span, kind, path)) = &unit_variant {
621             err.span_suggestion_verbose(
622                 *removal_span,
623                 &format!(
624                     "`{path}` is a unit {kind}, and does not take parentheses to be constructed",
625                 ),
626                 "",
627                 Applicability::MachineApplicable,
628             );
629         }
630
631         let mut inner_callee_path = None;
632         let def = match callee_expr.kind {
633             hir::ExprKind::Path(ref qpath) => {
634                 self.typeck_results.borrow().qpath_res(qpath, callee_expr.hir_id)
635             }
636             hir::ExprKind::Call(ref inner_callee, _) => {
637                 // If the call spans more than one line and the callee kind is
638                 // itself another `ExprCall`, that's a clue that we might just be
639                 // missing a semicolon (Issue #51055)
640                 let call_is_multiline = self.tcx.sess.source_map().is_multiline(call_expr.span);
641                 if call_is_multiline {
642                     err.span_suggestion(
643                         callee_expr.span.shrink_to_hi(),
644                         "consider using a semicolon here",
645                         ";",
646                         Applicability::MaybeIncorrect,
647                     );
648                 }
649                 if let hir::ExprKind::Path(ref inner_qpath) = inner_callee.kind {
650                     inner_callee_path = Some(inner_qpath);
651                     self.typeck_results.borrow().qpath_res(inner_qpath, inner_callee.hir_id)
652                 } else {
653                     Res::Err
654                 }
655             }
656             _ => Res::Err,
657         };
658
659         if !self.maybe_suggest_bad_array_definition(&mut err, call_expr, callee_expr) {
660             if let Some((maybe_def, output_ty, _)) = self.extract_callable_info(callee_ty)
661                 && !self.type_is_sized_modulo_regions(self.param_env, output_ty, callee_expr.span)
662             {
663                 let descr = match maybe_def {
664                     DefIdOrName::DefId(def_id) => self.tcx.def_kind(def_id).descr(def_id),
665                     DefIdOrName::Name(name) => name,
666                 };
667                 err.span_label(
668                     callee_expr.span,
669                     format!("this {descr} returns an unsized value `{output_ty}`, so it cannot be called")
670                 );
671                 if let DefIdOrName::DefId(def_id) = maybe_def
672                     && let Some(def_span) = self.tcx.hir().span_if_local(def_id)
673                 {
674                     err.span_label(def_span, "the callable type is defined here");
675                 }
676             } else {
677                 err.span_label(call_expr.span, "call expression requires function");
678             }
679         }
680
681         if let Some(span) = self.tcx.hir().res_span(def) {
682             let callee_ty = callee_ty.to_string();
683             let label = match (unit_variant, inner_callee_path) {
684                 (Some((_, kind, path)), _) => Some(format!("{kind} `{path}` defined here")),
685                 (_, Some(hir::QPath::Resolved(_, path))) => self
686                     .tcx
687                     .sess
688                     .source_map()
689                     .span_to_snippet(path.span)
690                     .ok()
691                     .map(|p| format!("`{p}` defined here returns `{callee_ty}`")),
692                 _ => {
693                     match def {
694                         // Emit a different diagnostic for local variables, as they are not
695                         // type definitions themselves, but rather variables *of* that type.
696                         Res::Local(hir_id) => Some(format!(
697                             "`{}` has type `{}`",
698                             self.tcx.hir().name(hir_id),
699                             callee_ty
700                         )),
701                         Res::Def(kind, def_id) if kind.ns() == Some(Namespace::ValueNS) => {
702                             Some(format!("`{}` defined here", self.tcx.def_path_str(def_id),))
703                         }
704                         _ => Some(format!("`{callee_ty}` defined here")),
705                     }
706                 }
707             };
708             if let Some(label) = label {
709                 err.span_label(span, label);
710             }
711         }
712         err.emit()
713     }
714
715     fn confirm_deferred_closure_call(
716         &self,
717         call_expr: &'tcx hir::Expr<'tcx>,
718         arg_exprs: &'tcx [hir::Expr<'tcx>],
719         expected: Expectation<'tcx>,
720         closure_def_id: LocalDefId,
721         fn_sig: ty::FnSig<'tcx>,
722     ) -> Ty<'tcx> {
723         // `fn_sig` is the *signature* of the closure being called. We
724         // don't know the full details yet (`Fn` vs `FnMut` etc), but we
725         // do know the types expected for each argument and the return
726         // type.
727
728         let expected_arg_tys = self.expected_inputs_for_expected_output(
729             call_expr.span,
730             expected,
731             fn_sig.output(),
732             fn_sig.inputs(),
733         );
734
735         self.check_argument_types(
736             call_expr.span,
737             call_expr,
738             fn_sig.inputs(),
739             expected_arg_tys,
740             arg_exprs,
741             fn_sig.c_variadic,
742             TupleArgumentsFlag::TupleArguments,
743             Some(closure_def_id.to_def_id()),
744         );
745
746         fn_sig.output()
747     }
748
749     fn confirm_overloaded_call(
750         &self,
751         call_expr: &'tcx hir::Expr<'tcx>,
752         arg_exprs: &'tcx [hir::Expr<'tcx>],
753         expected: Expectation<'tcx>,
754         method_callee: MethodCallee<'tcx>,
755     ) -> Ty<'tcx> {
756         let output_type = self.check_method_argument_types(
757             call_expr.span,
758             call_expr,
759             Ok(method_callee),
760             arg_exprs,
761             TupleArgumentsFlag::TupleArguments,
762             expected,
763         );
764
765         self.write_method_call(call_expr.hir_id, method_callee);
766         output_type
767     }
768 }
769
770 #[derive(Debug)]
771 pub struct DeferredCallResolution<'tcx> {
772     call_expr: &'tcx hir::Expr<'tcx>,
773     callee_expr: &'tcx hir::Expr<'tcx>,
774     adjusted_ty: Ty<'tcx>,
775     adjustments: Vec<Adjustment<'tcx>>,
776     fn_sig: ty::FnSig<'tcx>,
777     closure_substs: SubstsRef<'tcx>,
778 }
779
780 impl<'a, 'tcx> DeferredCallResolution<'tcx> {
781     pub fn resolve(self, fcx: &FnCtxt<'a, 'tcx>) {
782         debug!("DeferredCallResolution::resolve() {:?}", self);
783
784         // we should not be invoked until the closure kind has been
785         // determined by upvar inference
786         assert!(fcx.closure_kind(self.closure_substs).is_some());
787
788         // We may now know enough to figure out fn vs fnmut etc.
789         match fcx.try_overloaded_call_traits(self.call_expr, self.adjusted_ty, None) {
790             Some((autoref, method_callee)) => {
791                 // One problem is that when we get here, we are going
792                 // to have a newly instantiated function signature
793                 // from the call trait. This has to be reconciled with
794                 // the older function signature we had before. In
795                 // principle we *should* be able to fn_sigs(), but we
796                 // can't because of the annoying need for a TypeTrace.
797                 // (This always bites me, should find a way to
798                 // refactor it.)
799                 let method_sig = method_callee.sig;
800
801                 debug!("attempt_resolution: method_callee={:?}", method_callee);
802
803                 for (method_arg_ty, self_arg_ty) in
804                     iter::zip(method_sig.inputs().iter().skip(1), self.fn_sig.inputs())
805                 {
806                     fcx.demand_eqtype(self.call_expr.span, *self_arg_ty, *method_arg_ty);
807                 }
808
809                 fcx.demand_eqtype(self.call_expr.span, method_sig.output(), self.fn_sig.output());
810
811                 let mut adjustments = self.adjustments;
812                 adjustments.extend(autoref);
813                 fcx.apply_adjustments(self.callee_expr, adjustments);
814
815                 fcx.write_method_call(self.call_expr.hir_id, method_callee);
816             }
817             None => {
818                 // This can happen if `#![no_core]` is used and the `fn/fn_mut/fn_once`
819                 // lang items are not defined (issue #86238).
820                 let mut err = fcx.inh.tcx.sess.struct_span_err(
821                     self.call_expr.span,
822                     "failed to find an overloaded call trait for closure call",
823                 );
824                 err.help(
825                     "make sure the `fn`/`fn_mut`/`fn_once` lang items are defined \
826                      and have associated `call`/`call_mut`/`call_once` functions",
827                 );
828                 err.emit();
829             }
830         }
831     }
832 }