]> git.lizzy.rs Git - rust.git/blob - compiler/rustc_builtin_macros/src/test.rs
Auto merge of #104757 - camelid:consolidate-lints, r=GuillaumeGomez,jyn514,Manishearth
[rust.git] / compiler / rustc_builtin_macros / src / test.rs
1 /// The expansion from a test function to the appropriate test struct for libtest
2 /// Ideally, this code would be in libtest but for efficiency and error messages it lives here.
3 use crate::util::{check_builtin_macro_attribute, warn_on_duplicate_attribute};
4 use rustc_ast as ast;
5 use rustc_ast::ptr::P;
6 use rustc_ast_pretty::pprust;
7 use rustc_errors::Applicability;
8 use rustc_expand::base::*;
9 use rustc_session::Session;
10 use rustc_span::symbol::{sym, Ident, Symbol};
11 use rustc_span::Span;
12 use std::iter;
13 use thin_vec::thin_vec;
14
15 /// #[test_case] is used by custom test authors to mark tests
16 /// When building for test, it needs to make the item public and gensym the name
17 /// Otherwise, we'll omit the item. This behavior means that any item annotated
18 /// with #[test_case] is never addressable.
19 ///
20 /// We mark item with an inert attribute "rustc_test_marker" which the test generation
21 /// logic will pick up on.
22 pub fn expand_test_case(
23     ecx: &mut ExtCtxt<'_>,
24     attr_sp: Span,
25     meta_item: &ast::MetaItem,
26     anno_item: Annotatable,
27 ) -> Vec<Annotatable> {
28     check_builtin_macro_attribute(ecx, meta_item, sym::test_case);
29     warn_on_duplicate_attribute(&ecx, &anno_item, sym::test_case);
30
31     if !ecx.ecfg.should_test {
32         return vec![];
33     }
34
35     let sp = ecx.with_def_site_ctxt(attr_sp);
36     let mut item = anno_item.expect_item();
37     item = item.map(|mut item| {
38         let test_path_symbol = Symbol::intern(&item_path(
39             // skip the name of the root module
40             &ecx.current_expansion.module.mod_path[1..],
41             &item.ident,
42         ));
43         item.vis = ast::Visibility {
44             span: item.vis.span,
45             kind: ast::VisibilityKind::Public,
46             tokens: None,
47         };
48         item.ident.span = item.ident.span.with_ctxt(sp.ctxt());
49         item.attrs.push(ecx.attr_name_value_str(sym::rustc_test_marker, test_path_symbol, sp));
50         item
51     });
52
53     return vec![Annotatable::Item(item)];
54 }
55
56 pub fn expand_test(
57     cx: &mut ExtCtxt<'_>,
58     attr_sp: Span,
59     meta_item: &ast::MetaItem,
60     item: Annotatable,
61 ) -> Vec<Annotatable> {
62     check_builtin_macro_attribute(cx, meta_item, sym::test);
63     warn_on_duplicate_attribute(&cx, &item, sym::test);
64     expand_test_or_bench(cx, attr_sp, item, false)
65 }
66
67 pub fn expand_bench(
68     cx: &mut ExtCtxt<'_>,
69     attr_sp: Span,
70     meta_item: &ast::MetaItem,
71     item: Annotatable,
72 ) -> Vec<Annotatable> {
73     check_builtin_macro_attribute(cx, meta_item, sym::bench);
74     warn_on_duplicate_attribute(&cx, &item, sym::bench);
75     expand_test_or_bench(cx, attr_sp, item, true)
76 }
77
78 pub fn expand_test_or_bench(
79     cx: &mut ExtCtxt<'_>,
80     attr_sp: Span,
81     item: Annotatable,
82     is_bench: bool,
83 ) -> Vec<Annotatable> {
84     // If we're not in test configuration, remove the annotated item
85     if !cx.ecfg.should_test {
86         return vec![];
87     }
88
89     let (item, is_stmt) = match item {
90         Annotatable::Item(i) => (i, false),
91         Annotatable::Stmt(stmt) if matches!(stmt.kind, ast::StmtKind::Item(_)) => {
92             // FIXME: Use an 'if let' guard once they are implemented
93             if let ast::StmtKind::Item(i) = stmt.into_inner().kind {
94                 (i, true)
95             } else {
96                 unreachable!()
97             }
98         }
99         other => {
100             cx.struct_span_err(
101                 other.span(),
102                 "`#[test]` attribute is only allowed on non associated functions",
103             )
104             .emit();
105             return vec![other];
106         }
107     };
108
109     // Note: non-associated fn items are already handled by `expand_test_or_bench`
110     let ast::ItemKind::Fn(fn_) = &item.kind else {
111         let diag = &cx.sess.parse_sess.span_diagnostic;
112         let msg = "the `#[test]` attribute may only be used on a non-associated function";
113         let mut err = match item.kind {
114             // These were a warning before #92959 and need to continue being that to avoid breaking
115             // stable user code (#94508).
116             ast::ItemKind::MacCall(_) => diag.struct_span_warn(attr_sp, msg),
117             // `.forget_guarantee()` needed to get these two arms to match types. Because of how
118             // locally close the `.emit()` call is I'm comfortable with it, but if it can be
119             // reworked in the future to not need it, it'd be nice.
120             _ => diag.struct_span_err(attr_sp, msg).forget_guarantee(),
121         };
122         err.span_label(attr_sp, "the `#[test]` macro causes a function to be run on a test and has no effect on non-functions")
123             .span_label(item.span, format!("expected a non-associated function, found {} {}", item.kind.article(), item.kind.descr()))
124             .span_suggestion(attr_sp, "replace with conditional compilation to make the item only exist when tests are being run", "#[cfg(test)]", Applicability::MaybeIncorrect)
125             .emit();
126
127         return vec![Annotatable::Item(item)];
128     };
129
130     // has_*_signature will report any errors in the type so compilation
131     // will fail. We shouldn't try to expand in this case because the errors
132     // would be spurious.
133     if (!is_bench && !has_test_signature(cx, &item))
134         || (is_bench && !has_bench_signature(cx, &item))
135     {
136         return vec![Annotatable::Item(item)];
137     }
138
139     let sp = cx.with_def_site_ctxt(item.span);
140     let ret_ty_sp = cx.with_def_site_ctxt(fn_.sig.decl.output.span());
141     let attr_sp = cx.with_def_site_ctxt(attr_sp);
142
143     let test_id = Ident::new(sym::test, attr_sp);
144
145     // creates test::$name
146     let test_path = |name| cx.path(ret_ty_sp, vec![test_id, Ident::from_str_and_span(name, sp)]);
147
148     // creates test::ShouldPanic::$name
149     let should_panic_path = |name| {
150         cx.path(
151             sp,
152             vec![
153                 test_id,
154                 Ident::from_str_and_span("ShouldPanic", sp),
155                 Ident::from_str_and_span(name, sp),
156             ],
157         )
158     };
159
160     // creates test::TestType::$name
161     let test_type_path = |name| {
162         cx.path(
163             sp,
164             vec![
165                 test_id,
166                 Ident::from_str_and_span("TestType", sp),
167                 Ident::from_str_and_span(name, sp),
168             ],
169         )
170     };
171
172     // creates $name: $expr
173     let field = |name, expr| cx.field_imm(sp, Ident::from_str_and_span(name, sp), expr);
174
175     let test_fn = if is_bench {
176         // A simple ident for a lambda
177         let b = Ident::from_str_and_span("b", attr_sp);
178
179         cx.expr_call(
180             sp,
181             cx.expr_path(test_path("StaticBenchFn")),
182             vec![
183                 // |b| self::test::assert_test_result(
184                 cx.lambda1(
185                     sp,
186                     cx.expr_call(
187                         sp,
188                         cx.expr_path(test_path("assert_test_result")),
189                         vec![
190                             // super::$test_fn(b)
191                             cx.expr_call(
192                                 ret_ty_sp,
193                                 cx.expr_path(cx.path(sp, vec![item.ident])),
194                                 vec![cx.expr_ident(sp, b)],
195                             ),
196                         ],
197                     ),
198                     b,
199                 ), // )
200             ],
201         )
202     } else {
203         cx.expr_call(
204             sp,
205             cx.expr_path(test_path("StaticTestFn")),
206             vec![
207                 // || {
208                 cx.lambda0(
209                     sp,
210                     // test::assert_test_result(
211                     cx.expr_call(
212                         sp,
213                         cx.expr_path(test_path("assert_test_result")),
214                         vec![
215                             // $test_fn()
216                             cx.expr_call(
217                                 ret_ty_sp,
218                                 cx.expr_path(cx.path(sp, vec![item.ident])),
219                                 vec![],
220                             ), // )
221                         ],
222                     ), // }
223                 ), // )
224             ],
225         )
226     };
227
228     let test_path_symbol = Symbol::intern(&item_path(
229         // skip the name of the root module
230         &cx.current_expansion.module.mod_path[1..],
231         &item.ident,
232     ));
233
234     let mut test_const = cx.item(
235         sp,
236         Ident::new(item.ident.name, sp),
237         thin_vec![
238             // #[cfg(test)]
239             cx.attr_nested_word(sym::cfg, sym::test, attr_sp),
240             // #[rustc_test_marker = "test_case_sort_key"]
241             cx.attr_name_value_str(sym::rustc_test_marker, test_path_symbol, attr_sp),
242         ]
243         .into(),
244         // const $ident: test::TestDescAndFn =
245         ast::ItemKind::Const(
246             ast::Defaultness::Final,
247             cx.ty(sp, ast::TyKind::Path(None, test_path("TestDescAndFn"))),
248             // test::TestDescAndFn {
249             Some(
250                 cx.expr_struct(
251                     sp,
252                     test_path("TestDescAndFn"),
253                     vec![
254                         // desc: test::TestDesc {
255                         field(
256                             "desc",
257                             cx.expr_struct(
258                                 sp,
259                                 test_path("TestDesc"),
260                                 vec![
261                                     // name: "path::to::test"
262                                     field(
263                                         "name",
264                                         cx.expr_call(
265                                             sp,
266                                             cx.expr_path(test_path("StaticTestName")),
267                                             vec![cx.expr_str(sp, test_path_symbol)],
268                                         ),
269                                     ),
270                                     // ignore: true | false
271                                     field(
272                                         "ignore",
273                                         cx.expr_bool(sp, should_ignore(&cx.sess, &item)),
274                                     ),
275                                     // ignore_message: Some("...") | None
276                                     field(
277                                         "ignore_message",
278                                         if let Some(msg) = should_ignore_message(cx, &item) {
279                                             cx.expr_some(sp, cx.expr_str(sp, msg))
280                                         } else {
281                                             cx.expr_none(sp)
282                                         },
283                                     ),
284                                     // compile_fail: true | false
285                                     field("compile_fail", cx.expr_bool(sp, false)),
286                                     // no_run: true | false
287                                     field("no_run", cx.expr_bool(sp, false)),
288                                     // should_panic: ...
289                                     field(
290                                         "should_panic",
291                                         match should_panic(cx, &item) {
292                                             // test::ShouldPanic::No
293                                             ShouldPanic::No => {
294                                                 cx.expr_path(should_panic_path("No"))
295                                             }
296                                             // test::ShouldPanic::Yes
297                                             ShouldPanic::Yes(None) => {
298                                                 cx.expr_path(should_panic_path("Yes"))
299                                             }
300                                             // test::ShouldPanic::YesWithMessage("...")
301                                             ShouldPanic::Yes(Some(sym)) => cx.expr_call(
302                                                 sp,
303                                                 cx.expr_path(should_panic_path("YesWithMessage")),
304                                                 vec![cx.expr_str(sp, sym)],
305                                             ),
306                                         },
307                                     ),
308                                     // test_type: ...
309                                     field(
310                                         "test_type",
311                                         match test_type(cx) {
312                                             // test::TestType::UnitTest
313                                             TestType::UnitTest => {
314                                                 cx.expr_path(test_type_path("UnitTest"))
315                                             }
316                                             // test::TestType::IntegrationTest
317                                             TestType::IntegrationTest => {
318                                                 cx.expr_path(test_type_path("IntegrationTest"))
319                                             }
320                                             // test::TestPath::Unknown
321                                             TestType::Unknown => {
322                                                 cx.expr_path(test_type_path("Unknown"))
323                                             }
324                                         },
325                                     ),
326                                     // },
327                                 ],
328                             ),
329                         ),
330                         // testfn: test::StaticTestFn(...) | test::StaticBenchFn(...)
331                         field("testfn", test_fn), // }
332                     ],
333                 ), // }
334             ),
335         ),
336     );
337     test_const = test_const.map(|mut tc| {
338         tc.vis.kind = ast::VisibilityKind::Public;
339         tc
340     });
341
342     // extern crate test
343     let test_extern = cx.item(sp, test_id, ast::AttrVec::new(), ast::ItemKind::ExternCrate(None));
344
345     debug!("synthetic test item:\n{}\n", pprust::item_to_string(&test_const));
346
347     if is_stmt {
348         vec![
349             // Access to libtest under a hygienic name
350             Annotatable::Stmt(P(cx.stmt_item(sp, test_extern))),
351             // The generated test case
352             Annotatable::Stmt(P(cx.stmt_item(sp, test_const))),
353             // The original item
354             Annotatable::Stmt(P(cx.stmt_item(sp, item))),
355         ]
356     } else {
357         vec![
358             // Access to libtest under a hygienic name
359             Annotatable::Item(test_extern),
360             // The generated test case
361             Annotatable::Item(test_const),
362             // The original item
363             Annotatable::Item(item),
364         ]
365     }
366 }
367
368 fn item_path(mod_path: &[Ident], item_ident: &Ident) -> String {
369     mod_path
370         .iter()
371         .chain(iter::once(item_ident))
372         .map(|x| x.to_string())
373         .collect::<Vec<String>>()
374         .join("::")
375 }
376
377 enum ShouldPanic {
378     No,
379     Yes(Option<Symbol>),
380 }
381
382 fn should_ignore(sess: &Session, i: &ast::Item) -> bool {
383     sess.contains_name(&i.attrs, sym::ignore)
384 }
385
386 fn should_ignore_message(cx: &ExtCtxt<'_>, i: &ast::Item) -> Option<Symbol> {
387     match cx.sess.find_by_name(&i.attrs, sym::ignore) {
388         Some(attr) => {
389             match attr.meta_item_list() {
390                 // Handle #[ignore(bar = "foo")]
391                 Some(_) => None,
392                 // Handle #[ignore] and #[ignore = "message"]
393                 None => attr.value_str(),
394             }
395         }
396         None => None,
397     }
398 }
399
400 fn should_panic(cx: &ExtCtxt<'_>, i: &ast::Item) -> ShouldPanic {
401     match cx.sess.find_by_name(&i.attrs, sym::should_panic) {
402         Some(attr) => {
403             let sd = &cx.sess.parse_sess.span_diagnostic;
404
405             match attr.meta_item_list() {
406                 // Handle #[should_panic(expected = "foo")]
407                 Some(list) => {
408                     let msg = list
409                         .iter()
410                         .find(|mi| mi.has_name(sym::expected))
411                         .and_then(|mi| mi.meta_item())
412                         .and_then(|mi| mi.value_str());
413                     if list.len() != 1 || msg.is_none() {
414                         sd.struct_span_warn(
415                             attr.span,
416                             "argument must be of the form: \
417                              `expected = \"error message\"`",
418                         )
419                         .note(
420                             "errors in this attribute were erroneously \
421                                 allowed and will become a hard error in a \
422                                 future release",
423                         )
424                         .emit();
425                         ShouldPanic::Yes(None)
426                     } else {
427                         ShouldPanic::Yes(msg)
428                     }
429                 }
430                 // Handle #[should_panic] and #[should_panic = "expected"]
431                 None => ShouldPanic::Yes(attr.value_str()),
432             }
433         }
434         None => ShouldPanic::No,
435     }
436 }
437
438 enum TestType {
439     UnitTest,
440     IntegrationTest,
441     Unknown,
442 }
443
444 /// Attempts to determine the type of test.
445 /// Since doctests are created without macro expanding, only possible variants here
446 /// are `UnitTest`, `IntegrationTest` or `Unknown`.
447 fn test_type(cx: &ExtCtxt<'_>) -> TestType {
448     // Root path from context contains the topmost sources directory of the crate.
449     // I.e., for `project` with sources in `src` and tests in `tests` folders
450     // (no matter how many nested folders lie inside),
451     // there will be two different root paths: `/project/src` and `/project/tests`.
452     let crate_path = cx.root_path.as_path();
453
454     if crate_path.ends_with("src") {
455         // `/src` folder contains unit-tests.
456         TestType::UnitTest
457     } else if crate_path.ends_with("tests") {
458         // `/tests` folder contains integration tests.
459         TestType::IntegrationTest
460     } else {
461         // Crate layout doesn't match expected one, test type is unknown.
462         TestType::Unknown
463     }
464 }
465
466 fn has_test_signature(cx: &ExtCtxt<'_>, i: &ast::Item) -> bool {
467     let has_should_panic_attr = cx.sess.contains_name(&i.attrs, sym::should_panic);
468     let sd = &cx.sess.parse_sess.span_diagnostic;
469     if let ast::ItemKind::Fn(box ast::Fn { ref sig, ref generics, .. }) = i.kind {
470         if let ast::Unsafe::Yes(span) = sig.header.unsafety {
471             sd.struct_span_err(i.span, "unsafe functions cannot be used for tests")
472                 .span_label(span, "`unsafe` because of this")
473                 .emit();
474             return false;
475         }
476         if let ast::Async::Yes { span, .. } = sig.header.asyncness {
477             sd.struct_span_err(i.span, "async functions cannot be used for tests")
478                 .span_label(span, "`async` because of this")
479                 .emit();
480             return false;
481         }
482
483         // If the termination trait is active, the compiler will check that the output
484         // type implements the `Termination` trait as `libtest` enforces that.
485         let has_output = match sig.decl.output {
486             ast::FnRetTy::Default(..) => false,
487             ast::FnRetTy::Ty(ref t) if t.kind.is_unit() => false,
488             _ => true,
489         };
490
491         if !sig.decl.inputs.is_empty() {
492             sd.span_err(i.span, "functions used as tests can not have any arguments");
493             return false;
494         }
495
496         match (has_output, has_should_panic_attr) {
497             (true, true) => {
498                 sd.span_err(i.span, "functions using `#[should_panic]` must return `()`");
499                 false
500             }
501             (true, false) => {
502                 if !generics.params.is_empty() {
503                     sd.span_err(i.span, "functions used as tests must have signature fn() -> ()");
504                     false
505                 } else {
506                     true
507                 }
508             }
509             (false, _) => true,
510         }
511     } else {
512         // should be unreachable because `is_test_fn_item` should catch all non-fn items
513         false
514     }
515 }
516
517 fn has_bench_signature(cx: &ExtCtxt<'_>, i: &ast::Item) -> bool {
518     let has_sig = if let ast::ItemKind::Fn(box ast::Fn { ref sig, .. }) = i.kind {
519         // N.B., inadequate check, but we're running
520         // well before resolve, can't get too deep.
521         sig.decl.inputs.len() == 1
522     } else {
523         false
524     };
525
526     if !has_sig {
527         cx.sess.parse_sess.span_diagnostic.span_err(
528             i.span,
529             "functions used as benches must have \
530             signature `fn(&mut Bencher) -> impl Termination`",
531         );
532     }
533
534     has_sig
535 }