compiler/rustc_ast_passes/src/feature_gate.rs

   1 use rustc_ast as ast;
   2 use rustc_ast::visit::{self, AssocCtxt, FnCtxt, FnKind, Visitor};
   3 use rustc_ast::{AssocTyConstraint, AssocTyConstraintKind, NodeId};
   4 use rustc_ast::{PatKind, RangeEnd, VariantData};
   5 use rustc_errors::struct_span_err;
   6 use rustc_feature::{AttributeGate, BuiltinAttribute, BUILTIN_ATTRIBUTE_MAP};
   7 use rustc_feature::{Features, GateIssue};
   8 use rustc_session::parse::{feature_err, feature_err_issue};
   9 use rustc_session::Session;
  10 use rustc_span::source_map::Spanned;
  11 use rustc_span::symbol::sym;
  12 use rustc_span::Span;
  13
  14 use tracing::debug;
  15
  16 macro_rules! gate_feature_fn {
  17     ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr, $help: expr) => {{
  18         let (visitor, has_feature, span, name, explain, help) =
  19             (&*$visitor, $has_feature, $span, $name, $explain, $help);
  20         let has_feature: bool = has_feature(visitor.features);
  21         debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
  22         if !has_feature && !span.allows_unstable($name) {
  23             feature_err_issue(&visitor.sess.parse_sess, name, span, GateIssue::Language, explain)
  24                 .help(help)
  25                 .emit();
  26         }
  27     }};
  28     ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
  29         let (visitor, has_feature, span, name, explain) =
  30             (&*$visitor, $has_feature, $span, $name, $explain);
  31         let has_feature: bool = has_feature(visitor.features);
  32         debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
  33         if !has_feature && !span.allows_unstable($name) {
  34             feature_err_issue(&visitor.sess.parse_sess, name, span, GateIssue::Language, explain)
  35                 .emit();
  36         }
  37     }};
  38 }
  39
  40 macro_rules! gate_feature_post {
  41     ($visitor: expr, $feature: ident, $span: expr, $explain: expr, $help: expr) => {
  42         gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain, $help)
  43     };
  44     ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => {
  45         gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain)
  46     };
  47 }
  48
  49 pub fn check_attribute(attr: &ast::Attribute, sess: &Session, features: &Features) {
  50     PostExpansionVisitor { sess, features }.visit_attribute(attr)
  51 }
  52
  53 struct PostExpansionVisitor<'a> {
  54     sess: &'a Session,
  55
  56     // `sess` contains a `Features`, but this might not be that one.
  57     features: &'a Features,
  58 }
  59
  60 impl<'a> PostExpansionVisitor<'a> {
  61     fn check_abi(&self, abi: ast::StrLit) {
  62         let ast::StrLit { symbol_unescaped, span, .. } = abi;
  63
  64         match &*symbol_unescaped.as_str() {
  65             // Stable
  66             "Rust" | "C" | "cdecl" | "stdcall" | "fastcall" | "aapcs" | "win64" | "sysv64"
  67             | "system" => {}
  68             "rust-intrinsic" => {
  69                 gate_feature_post!(&self, intrinsics, span, "intrinsics are subject to change");
  70             }
  71             "platform-intrinsic" => {
  72                 gate_feature_post!(
  73                     &self,
  74                     platform_intrinsics,
  75                     span,
  76                     "platform intrinsics are experimental and possibly buggy"
  77                 );
  78             }
  79             "vectorcall" => {
  80                 gate_feature_post!(
  81                     &self,
  82                     abi_vectorcall,
  83                     span,
  84                     "vectorcall is experimental and subject to change"
  85                 );
  86             }
  87             "thiscall" => {
  88                 gate_feature_post!(
  89                     &self,
  90                     abi_thiscall,
  91                     span,
  92                     "thiscall is experimental and subject to change"
  93                 );
  94             }
  95             "rust-call" => {
  96                 gate_feature_post!(
  97                     &self,
  98                     unboxed_closures,
  99                     span,
 100                     "rust-call ABI is subject to change"
 101                 );
 102             }
 103             "ptx-kernel" => {
 104                 gate_feature_post!(
 105                     &self,
 106                     abi_ptx,
 107                     span,
 108                     "PTX ABIs are experimental and subject to change"
 109                 );
 110             }
 111             "unadjusted" => {
 112                 gate_feature_post!(
 113                     &self,
 114                     abi_unadjusted,
 115                     span,
 116                     "unadjusted ABI is an implementation detail and perma-unstable"
 117                 );
 118             }
 119             "msp430-interrupt" => {
 120                 gate_feature_post!(
 121                     &self,
 122                     abi_msp430_interrupt,
 123                     span,
 124                     "msp430-interrupt ABI is experimental and subject to change"
 125                 );
 126             }
 127             "x86-interrupt" => {
 128                 gate_feature_post!(
 129                     &self,
 130                     abi_x86_interrupt,
 131                     span,
 132                     "x86-interrupt ABI is experimental and subject to change"
 133                 );
 134             }
 135             "amdgpu-kernel" => {
 136                 gate_feature_post!(
 137                     &self,
 138                     abi_amdgpu_kernel,
 139                     span,
 140                     "amdgpu-kernel ABI is experimental and subject to change"
 141                 );
 142             }
 143             "avr-interrupt" | "avr-non-blocking-interrupt" => {
 144                 gate_feature_post!(
 145                     &self,
 146                     abi_avr_interrupt,
 147                     span,
 148                     "avr-interrupt and avr-non-blocking-interrupt ABIs are experimental and subject to change"
 149                 );
 150             }
 151             "efiapi" => {
 152                 gate_feature_post!(
 153                     &self,
 154                     abi_efiapi,
 155                     span,
 156                     "efiapi ABI is experimental and subject to change"
 157                 );
 158             }
 159             "C-cmse-nonsecure-call" => {
 160                 gate_feature_post!(
 161                     &self,
 162                     abi_c_cmse_nonsecure_call,
 163                     span,
 164                     "C-cmse-nonsecure-call ABI is experimental and subject to change"
 165                 );
 166             }
 167             "C-unwind" => {
 168                 gate_feature_post!(
 169                     &self,
 170                     c_unwind,
 171                     span,
 172                     "C-unwind ABI is experimental and subject to change"
 173                 );
 174             }
 175             "stdcall-unwind" => {
 176                 gate_feature_post!(
 177                     &self,
 178                     c_unwind,
 179                     span,
 180                     "stdcall-unwind ABI is experimental and subject to change"
 181                 );
 182             }
 183             "system-unwind" => {
 184                 gate_feature_post!(
 185                     &self,
 186                     c_unwind,
 187                     span,
 188                     "system-unwind ABI is experimental and subject to change"
 189                 );
 190             }
 191             "thiscall-unwind" => {
 192                 gate_feature_post!(
 193                     &self,
 194                     c_unwind,
 195                     span,
 196                     "thiscall-unwind ABI is experimental and subject to change"
 197                 );
 198             }
 199             "wasm" => {
 200                 gate_feature_post!(
 201                     &self,
 202                     wasm_abi,
 203                     span,
 204                     "wasm ABI is experimental and subject to change"
 205                 );
 206             }
 207             abi => self
 208                 .sess
 209                 .parse_sess
 210                 .span_diagnostic
 211                 .delay_span_bug(span, &format!("unrecognized ABI not caught in lowering: {}", abi)),
 212         }
 213     }
 214
 215     fn check_extern(&self, ext: ast::Extern) {
 216         if let ast::Extern::Explicit(abi) = ext {
 217             self.check_abi(abi);
 218         }
 219     }
 220
 221     fn maybe_report_invalid_custom_discriminants(&self, variants: &[ast::Variant]) {
 222         let has_fields = variants.iter().any(|variant| match variant.data {
 223             VariantData::Tuple(..) | VariantData::Struct(..) => true,
 224             VariantData::Unit(..) => false,
 225         });
 226
 227         let discriminant_spans = variants
 228             .iter()
 229             .filter(|variant| match variant.data {
 230                 VariantData::Tuple(..) | VariantData::Struct(..) => false,
 231                 VariantData::Unit(..) => true,
 232             })
 233             .filter_map(|variant| variant.disr_expr.as_ref().map(|c| c.value.span))
 234             .collect::<Vec<_>>();
 235
 236         if !discriminant_spans.is_empty() && has_fields {
 237             let mut err = feature_err(
 238                 &self.sess.parse_sess,
 239                 sym::arbitrary_enum_discriminant,
 240                 discriminant_spans.clone(),
 241                 "custom discriminant values are not allowed in enums with tuple or struct variants",
 242             );
 243             for sp in discriminant_spans {
 244                 err.span_label(sp, "disallowed custom discriminant");
 245             }
 246             for variant in variants.iter() {
 247                 match &variant.data {
 248                     VariantData::Struct(..) => {
 249                         err.span_label(variant.span, "struct variant defined here");
 250                     }
 251                     VariantData::Tuple(..) => {
 252                         err.span_label(variant.span, "tuple variant defined here");
 253                     }
 254                     VariantData::Unit(..) => {}
 255                 }
 256             }
 257             err.emit();
 258         }
 259     }
 260
 261     fn check_gat(&self, generics: &ast::Generics, span: Span) {
 262         if !generics.params.is_empty() {
 263             gate_feature_post!(
 264                 &self,
 265                 generic_associated_types,
 266                 span,
 267                 "generic associated types are unstable"
 268             );
 269         }
 270         if !generics.where_clause.predicates.is_empty() {
 271             gate_feature_post!(
 272                 &self,
 273                 generic_associated_types,
 274                 span,
 275                 "where clauses on associated types are unstable"
 276             );
 277         }
 278     }
 279
 280     /// Feature gate `impl Trait` inside `type Alias = $type_expr;`.
 281     fn check_impl_trait(&self, ty: &ast::Ty) {
 282         struct ImplTraitVisitor<'a> {
 283             vis: &'a PostExpansionVisitor<'a>,
 284         }
 285         impl Visitor<'_> for ImplTraitVisitor<'_> {
 286             fn visit_ty(&mut self, ty: &ast::Ty) {
 287                 if let ast::TyKind::ImplTrait(..) = ty.kind {
 288                     gate_feature_post!(
 289                         &self.vis,
 290                         type_alias_impl_trait,
 291                         ty.span,
 292                         "`impl Trait` in type aliases is unstable"
 293                     );
 294                 }
 295                 visit::walk_ty(self, ty);
 296             }
 297         }
 298         ImplTraitVisitor { vis: self }.visit_ty(ty);
 299     }
 300 }
 301
 302 impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
 303     fn visit_attribute(&mut self, attr: &ast::Attribute) {
 304         let attr_info = attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name));
 305         // Check feature gates for built-in attributes.
 306         if let Some(BuiltinAttribute {
 307             gate: AttributeGate::Gated(_, name, descr, has_feature),
 308             ..
 309         }) = attr_info
 310         {
 311             gate_feature_fn!(self, has_feature, attr.span, *name, descr);
 312         }
 313         // Check unstable flavors of the `#[doc]` attribute.
 314         if attr.has_name(sym::doc) {
 315             for nested_meta in attr.meta_item_list().unwrap_or_default() {
 316                 macro_rules! gate_doc { ($($name:ident => $feature:ident)*) => {
 317                     $(if nested_meta.has_name(sym::$name) {
 318                         let msg = concat!("`#[doc(", stringify!($name), ")]` is experimental");
 319                         gate_feature_post!(self, $feature, attr.span, msg);
 320                     })*
 321                 }}
 322
 323                 gate_doc!(
 324                     cfg => doc_cfg
 325                     cfg_hide => doc_cfg_hide
 326                     masked => doc_masked
 327                     notable_trait => doc_notable_trait
 328                     keyword => doc_keyword
 329                 );
 330             }
 331         }
 332
 333         // Check for unstable modifiers on `#[link(..)]` attribute
 334         if attr.has_name(sym::link) {
 335             for nested_meta in attr.meta_item_list().unwrap_or_default() {
 336                 if nested_meta.has_name(sym::modifiers) {
 337                     gate_feature_post!(
 338                         self,
 339                         native_link_modifiers,
 340                         nested_meta.span(),
 341                         "native link modifiers are experimental"
 342                     );
 343
 344                     if let Some(modifiers) = nested_meta.value_str() {
 345                         for modifier in modifiers.as_str().split(',') {
 346                             if let Some(modifier) = modifier.strip_prefix(&['+', '-'][..]) {
 347                                 macro_rules! gate_modifier { ($($name:literal => $feature:ident)*) => {
 348                                     $(if modifier == $name {
 349                                         let msg = concat!("`#[link(modifiers=\"", $name, "\")]` is unstable");
 350                                         gate_feature_post!(
 351                                             self,
 352                                             $feature,
 353                                             nested_meta.name_value_literal_span().unwrap(),
 354                                             msg
 355                                         );
 356                                     })*
 357                                 }}
 358
 359                                 gate_modifier!(
 360                                     "bundle" => native_link_modifiers_bundle
 361                                     "verbatim" => native_link_modifiers_verbatim
 362                                     "whole-archive" => native_link_modifiers_whole_archive
 363                                     "as-needed" => native_link_modifiers_as_needed
 364                                 );
 365                             }
 366                         }
 367                     }
 368                 }
 369             }
 370         }
 371     }
 372
 373     fn visit_item(&mut self, i: &'a ast::Item) {
 374         match i.kind {
 375             ast::ItemKind::ForeignMod(ref foreign_module) => {
 376                 if let Some(abi) = foreign_module.abi {
 377                     self.check_abi(abi);
 378                 }
 379             }
 380
 381             ast::ItemKind::Fn(..) => {
 382                 if self.sess.contains_name(&i.attrs[..], sym::start) {
 383                     gate_feature_post!(
 384                         &self,
 385                         start,
 386                         i.span,
 387                         "`#[start]` functions are experimental \
 388                          and their signature may change \
 389                          over time"
 390                     );
 391                 }
 392             }
 393
 394             ast::ItemKind::Struct(..) => {
 395                 for attr in self.sess.filter_by_name(&i.attrs[..], sym::repr) {
 396                     for item in attr.meta_item_list().unwrap_or_else(Vec::new) {
 397                         if item.has_name(sym::simd) {
 398                             gate_feature_post!(
 399                                 &self,
 400                                 repr_simd,
 401                                 attr.span,
 402                                 "SIMD types are experimental and possibly buggy"
 403                             );
 404                         }
 405                     }
 406                 }
 407             }
 408
 409             ast::ItemKind::Enum(ast::EnumDef { ref variants, .. }, ..) => {
 410                 for variant in variants {
 411                     match (&variant.data, &variant.disr_expr) {
 412                         (ast::VariantData::Unit(..), _) => {}
 413                         (_, Some(disr_expr)) => gate_feature_post!(
 414                             &self,
 415                             arbitrary_enum_discriminant,
 416                             disr_expr.value.span,
 417                             "discriminants on non-unit variants are experimental"
 418                         ),
 419                         _ => {}
 420                     }
 421                 }
 422
 423                 let has_feature = self.features.arbitrary_enum_discriminant;
 424                 if !has_feature && !i.span.allows_unstable(sym::arbitrary_enum_discriminant) {
 425                     self.maybe_report_invalid_custom_discriminants(&variants);
 426                 }
 427             }
 428
 429             ast::ItemKind::Impl(box ast::Impl { polarity, defaultness, ref of_trait, .. }) => {
 430                 if let ast::ImplPolarity::Negative(span) = polarity {
 431                     gate_feature_post!(
 432                         &self,
 433                         negative_impls,
 434                         span.to(of_trait.as_ref().map_or(span, |t| t.path.span)),
 435                         "negative trait bounds are not yet fully implemented; \
 436                          use marker types for now"
 437                     );
 438                 }
 439
 440                 if let ast::Defaultness::Default(_) = defaultness {
 441                     gate_feature_post!(&self, specialization, i.span, "specialization is unstable");
 442                 }
 443             }
 444
 445             ast::ItemKind::Trait(box ast::Trait { is_auto: ast::IsAuto::Yes, .. }) => {
 446                 gate_feature_post!(
 447                     &self,
 448                     auto_traits,
 449                     i.span,
 450                     "auto traits are experimental and possibly buggy"
 451                 );
 452             }
 453
 454             ast::ItemKind::TraitAlias(..) => {
 455                 gate_feature_post!(&self, trait_alias, i.span, "trait aliases are experimental");
 456             }
 457
 458             ast::ItemKind::MacroDef(ast::MacroDef { macro_rules: false, .. }) => {
 459                 let msg = "`macro` is experimental";
 460                 gate_feature_post!(&self, decl_macro, i.span, msg);
 461             }
 462
 463             ast::ItemKind::TyAlias(box ast::TyAlias { ty: Some(ref ty), .. }) => {
 464                 self.check_impl_trait(&ty)
 465             }
 466
 467             _ => {}
 468         }
 469
 470         visit::walk_item(self, i);
 471     }
 472
 473     fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
 474         match i.kind {
 475             ast::ForeignItemKind::Fn(..) | ast::ForeignItemKind::Static(..) => {
 476                 let link_name = self.sess.first_attr_value_str_by_name(&i.attrs, sym::link_name);
 477                 let links_to_llvm =
 478                     link_name.map_or(false, |val| val.as_str().starts_with("llvm."));
 479                 if links_to_llvm {
 480                     gate_feature_post!(
 481                         &self,
 482                         link_llvm_intrinsics,
 483                         i.span,
 484                         "linking to LLVM intrinsics is experimental"
 485                     );
 486                 }
 487             }
 488             ast::ForeignItemKind::TyAlias(..) => {
 489                 gate_feature_post!(&self, extern_types, i.span, "extern types are experimental");
 490             }
 491             ast::ForeignItemKind::MacCall(..) => {}
 492         }
 493
 494         visit::walk_foreign_item(self, i)
 495     }
 496
 497     fn visit_ty(&mut self, ty: &'a ast::Ty) {
 498         match ty.kind {
 499             ast::TyKind::BareFn(ref bare_fn_ty) => {
 500                 self.check_extern(bare_fn_ty.ext);
 501             }
 502             ast::TyKind::Never => {
 503                 gate_feature_post!(&self, never_type, ty.span, "the `!` type is experimental");
 504             }
 505             _ => {}
 506         }
 507         visit::walk_ty(self, ty)
 508     }
 509
 510     fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FnRetTy) {
 511         if let ast::FnRetTy::Ty(ref output_ty) = *ret_ty {
 512             if let ast::TyKind::Never = output_ty.kind {
 513                 // Do nothing.
 514             } else {
 515                 self.visit_ty(output_ty)
 516             }
 517         }
 518     }
 519
 520     fn visit_expr(&mut self, e: &'a ast::Expr) {
 521         match e.kind {
 522             ast::ExprKind::Box(_) => {
 523                 gate_feature_post!(
 524                     &self,
 525                     box_syntax,
 526                     e.span,
 527                     "box expression syntax is experimental; you can call `Box::new` instead"
 528                 );
 529             }
 530             ast::ExprKind::Type(..) => {
 531                 // To avoid noise about type ascription in common syntax errors, only emit if it
 532                 // is the *only* error.
 533                 if self.sess.parse_sess.span_diagnostic.err_count() == 0 {
 534                     gate_feature_post!(
 535                         &self,
 536                         type_ascription,
 537                         e.span,
 538                         "type ascription is experimental"
 539                     );
 540                 }
 541             }
 542             ast::ExprKind::TryBlock(_) => {
 543                 gate_feature_post!(&self, try_blocks, e.span, "`try` expression is experimental");
 544             }
 545             ast::ExprKind::Block(_, Some(label)) => {
 546                 gate_feature_post!(
 547                     &self,
 548                     label_break_value,
 549                     label.ident.span,
 550                     "labels on blocks are unstable"
 551                 );
 552             }
 553             _ => {}
 554         }
 555         visit::walk_expr(self, e)
 556     }
 557
 558     fn visit_pat(&mut self, pattern: &'a ast::Pat) {
 559         match &pattern.kind {
 560             PatKind::Slice(pats) => {
 561                 for pat in pats {
 562                     let inner_pat = match &pat.kind {
 563                         PatKind::Ident(.., Some(pat)) => pat,
 564                         _ => pat,
 565                     };
 566                     if let PatKind::Range(Some(_), None, Spanned { .. }) = inner_pat.kind {
 567                         gate_feature_post!(
 568                             &self,
 569                             half_open_range_patterns,
 570                             pat.span,
 571                             "`X..` patterns in slices are experimental"
 572                         );
 573                     }
 574                 }
 575             }
 576             PatKind::Box(..) => {
 577                 gate_feature_post!(
 578                     &self,
 579                     box_patterns,
 580                     pattern.span,
 581                     "box pattern syntax is experimental"
 582                 );
 583             }
 584             PatKind::Range(_, Some(_), Spanned { node: RangeEnd::Excluded, .. }) => {
 585                 gate_feature_post!(
 586                     &self,
 587                     exclusive_range_pattern,
 588                     pattern.span,
 589                     "exclusive range pattern syntax is experimental"
 590                 );
 591             }
 592             _ => {}
 593         }
 594         visit::walk_pat(self, pattern)
 595     }
 596
 597     fn visit_fn(&mut self, fn_kind: FnKind<'a>, span: Span, _: NodeId) {
 598         if let Some(header) = fn_kind.header() {
 599             // Stability of const fn methods are covered in `visit_assoc_item` below.
 600             self.check_extern(header.ext);
 601
 602             if let (ast::Const::Yes(_), ast::Extern::Implicit)
 603             | (ast::Const::Yes(_), ast::Extern::Explicit(_)) = (header.constness, header.ext)
 604             {
 605                 gate_feature_post!(
 606                     &self,
 607                     const_extern_fn,
 608                     span,
 609                     "`const extern fn` definitions are unstable"
 610                 );
 611             }
 612         }
 613
 614         if fn_kind.ctxt() != Some(FnCtxt::Foreign) && fn_kind.decl().c_variadic() {
 615             gate_feature_post!(&self, c_variadic, span, "C-variadic functions are unstable");
 616         }
 617
 618         visit::walk_fn(self, fn_kind, span)
 619     }
 620
 621     fn visit_assoc_ty_constraint(&mut self, constraint: &'a AssocTyConstraint) {
 622         if let AssocTyConstraintKind::Bound { .. } = constraint.kind {
 623             gate_feature_post!(
 624                 &self,
 625                 associated_type_bounds,
 626                 constraint.span,
 627                 "associated type bounds are unstable"
 628             )
 629         }
 630         visit::walk_assoc_ty_constraint(self, constraint)
 631     }
 632
 633     fn visit_assoc_item(&mut self, i: &'a ast::AssocItem, ctxt: AssocCtxt) {
 634         let is_fn = match i.kind {
 635             ast::AssocItemKind::Fn(_) => true,
 636             ast::AssocItemKind::TyAlias(box ast::TyAlias { ref generics, ref ty, .. }) => {
 637                 if let (Some(_), AssocCtxt::Trait) = (ty, ctxt) {
 638                     gate_feature_post!(
 639                         &self,
 640                         associated_type_defaults,
 641                         i.span,
 642                         "associated type defaults are unstable"
 643                     );
 644                 }
 645                 if let Some(ty) = ty {
 646                     self.check_impl_trait(ty);
 647                 }
 648                 self.check_gat(generics, i.span);
 649                 false
 650             }
 651             _ => false,
 652         };
 653         if let ast::Defaultness::Default(_) = i.kind.defaultness() {
 654             // Limit `min_specialization` to only specializing functions.
 655             gate_feature_fn!(
 656                 &self,
 657                 |x: &Features| x.specialization || (is_fn && x.min_specialization),
 658                 i.span,
 659                 sym::specialization,
 660                 "specialization is unstable"
 661             );
 662         }
 663         visit::walk_assoc_item(self, i, ctxt)
 664     }
 665
 666     fn visit_vis(&mut self, vis: &'a ast::Visibility) {
 667         if let ast::VisibilityKind::Crate(ast::CrateSugar::JustCrate) = vis.kind {
 668             gate_feature_post!(
 669                 &self,
 670                 crate_visibility_modifier,
 671                 vis.span,
 672                 "`crate` visibility modifier is experimental"
 673             );
 674         }
 675         visit::walk_vis(self, vis)
 676     }
 677 }
 678
 679 pub fn check_crate(krate: &ast::Crate, sess: &Session) {
 680     maybe_stage_features(sess, krate);
 681     check_incompatible_features(sess);
 682     let mut visitor = PostExpansionVisitor { sess, features: &sess.features_untracked() };
 683
 684     let spans = sess.parse_sess.gated_spans.spans.borrow();
 685     macro_rules! gate_all {
 686         ($gate:ident, $msg:literal, $help:literal) => {
 687             if let Some(spans) = spans.get(&sym::$gate) {
 688                 for span in spans {
 689                     gate_feature_post!(&visitor, $gate, *span, $msg, $help);
 690                 }
 691             }
 692         };
 693         ($gate:ident, $msg:literal) => {
 694             if let Some(spans) = spans.get(&sym::$gate) {
 695                 for span in spans {
 696                     gate_feature_post!(&visitor, $gate, *span, $msg);
 697                 }
 698             }
 699         };
 700     }
 701     gate_all!(
 702         if_let_guard,
 703         "`if let` guards are experimental",
 704         "you can write `if matches!(<expr>, <pattern>)` instead of `if let <pattern> = <expr>`"
 705     );
 706     gate_all!(
 707         let_chains,
 708         "`let` expressions in this position are experimental",
 709         "you can write `matches!(<expr>, <pattern>)` instead of `let <pattern> = <expr>`"
 710     );
 711     gate_all!(
 712         async_closure,
 713         "async closures are unstable",
 714         "to use an async block, remove the `||`: `async {`"
 715     );
 716     gate_all!(more_qualified_paths, "usage of qualified paths in this context is experimental");
 717     gate_all!(generators, "yield syntax is experimental");
 718     gate_all!(raw_ref_op, "raw address of syntax is experimental");
 719     gate_all!(const_trait_impl, "const trait impls are experimental");
 720     gate_all!(half_open_range_patterns, "half-open range patterns are unstable");
 721     gate_all!(inline_const, "inline-const is experimental");
 722     gate_all!(
 723         const_generics_defaults,
 724         "default values for const generic parameters are experimental"
 725     );
 726     if sess.parse_sess.span_diagnostic.err_count() == 0 {
 727         // Errors for `destructuring_assignment` can get quite noisy, especially where `_` is
 728         // involved, so we only emit errors where there are no other parsing errors.
 729         gate_all!(destructuring_assignment, "destructuring assignments are unstable");
 730     }
 731
 732     // All uses of `gate_all!` below this point were added in #65742,
 733     // and subsequently disabled (with the non-early gating readded).
 734     macro_rules! gate_all {
 735         ($gate:ident, $msg:literal) => {
 736             // FIXME(eddyb) do something more useful than always
 737             // disabling these uses of early feature-gatings.
 738             if false {
 739                 for span in spans.get(&sym::$gate).unwrap_or(&vec![]) {
 740                     gate_feature_post!(&visitor, $gate, *span, $msg);
 741                 }
 742             }
 743         };
 744     }
 745
 746     gate_all!(trait_alias, "trait aliases are experimental");
 747     gate_all!(associated_type_bounds, "associated type bounds are unstable");
 748     gate_all!(crate_visibility_modifier, "`crate` visibility modifier is experimental");
 749     gate_all!(decl_macro, "`macro` is experimental");
 750     gate_all!(box_patterns, "box pattern syntax is experimental");
 751     gate_all!(exclusive_range_pattern, "exclusive range pattern syntax is experimental");
 752     gate_all!(try_blocks, "`try` blocks are unstable");
 753     gate_all!(label_break_value, "labels on blocks are unstable");
 754     gate_all!(box_syntax, "box expression syntax is experimental; you can call `Box::new` instead");
 755     // To avoid noise about type ascription in common syntax errors,
 756     // only emit if it is the *only* error. (Also check it last.)
 757     if sess.parse_sess.span_diagnostic.err_count() == 0 {
 758         gate_all!(type_ascription, "type ascription is experimental");
 759     }
 760
 761     visit::walk_crate(&mut visitor, krate);
 762 }
 763
 764 fn maybe_stage_features(sess: &Session, krate: &ast::Crate) {
 765     // checks if `#![feature]` has been used to enable any lang feature
 766     // does not check the same for lib features unless there's at least one
 767     // declared lang feature
 768     use rustc_errors::Applicability;
 769
 770     if !sess.opts.unstable_features.is_nightly_build() {
 771         let lang_features = &sess.features_untracked().declared_lang_features;
 772         if lang_features.len() == 0 {
 773             return;
 774         }
 775         for attr in krate.attrs.iter().filter(|attr| attr.has_name(sym::feature)) {
 776             let mut err = struct_span_err!(
 777                 sess.parse_sess.span_diagnostic,
 778                 attr.span,
 779                 E0554,
 780                 "`#![feature]` may not be used on the {} release channel",
 781                 option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)")
 782             );
 783             let mut all_stable = true;
 784             for ident in
 785                 attr.meta_item_list().into_iter().flatten().map(|nested| nested.ident()).flatten()
 786             {
 787                 let name = ident.name;
 788                 let stable_since = lang_features
 789                     .iter()
 790                     .flat_map(|&(feature, _, since)| if feature == name { since } else { None })
 791                     .next();
 792                 if let Some(since) = stable_since {
 793                     err.help(&format!(
 794                         "the feature `{}` has been stable since {} and no longer requires \
 795                                   an attribute to enable",
 796                         name, since
 797                     ));
 798                 } else {
 799                     all_stable = false;
 800                 }
 801             }
 802             if all_stable {
 803                 err.span_suggestion(
 804                     attr.span,
 805                     "remove the attribute",
 806                     String::new(),
 807                     Applicability::MachineApplicable,
 808                 );
 809             }
 810             err.emit();
 811         }
 812     }
 813 }
 814
 815 fn check_incompatible_features(sess: &Session) {
 816     let features = sess.features_untracked();
 817
 818     let declared_features = features
 819         .declared_lang_features
 820         .iter()
 821         .copied()
 822         .map(|(name, span, _)| (name, span))
 823         .chain(features.declared_lib_features.iter().copied());
 824
 825     for (f1, f2) in rustc_feature::INCOMPATIBLE_FEATURES
 826         .iter()
 827         .filter(|&&(f1, f2)| features.enabled(f1) && features.enabled(f2))
 828     {
 829         if let Some((f1_name, f1_span)) = declared_features.clone().find(|(name, _)| name == f1) {
 830             if let Some((f2_name, f2_span)) = declared_features.clone().find(|(name, _)| name == f2)
 831             {
 832                 let spans = vec![f1_span, f2_span];
 833                 sess.struct_span_err(
 834                     spans.clone(),
 835                     &format!(
 836                         "features `{}` and `{}` are incompatible, using them at the same time \
 837                         is not allowed",
 838                         f1_name, f2_name
 839                     ),
 840                 )
 841                 .help("remove one of these features")
 842                 .emit();
 843             }
 844         }
 845     }
 846 }