2 use rustc_ast::visit::{self, AssocCtxt, FnCtxt, FnKind, Visitor};
3 use rustc_ast::{AssocConstraint, AssocConstraintKind, NodeId};
4 use rustc_ast::{PatKind, RangeEnd, VariantData};
5 use rustc_errors::struct_span_err;
6 use rustc_feature::{AttributeGate, BuiltinAttribute, BUILTIN_ATTRIBUTE_MAP};
7 use rustc_feature::{Features, GateIssue};
8 use rustc_session::parse::{feature_err, feature_err_issue};
9 use rustc_session::Session;
10 use rustc_span::source_map::Spanned;
11 use rustc_span::symbol::sym;
16 macro_rules! gate_feature_fn {
17 ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr, $help: expr) => {{
18 let (visitor, has_feature, span, name, explain, help) =
19 (&*$visitor, $has_feature, $span, $name, $explain, $help);
20 let has_feature: bool = has_feature(visitor.features);
21 debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
22 if !has_feature && !span.allows_unstable($name) {
23 feature_err_issue(&visitor.sess.parse_sess, name, span, GateIssue::Language, explain)
28 ($visitor: expr, $has_feature: expr, $span: expr, $name: expr, $explain: expr) => {{
29 let (visitor, has_feature, span, name, explain) =
30 (&*$visitor, $has_feature, $span, $name, $explain);
31 let has_feature: bool = has_feature(visitor.features);
32 debug!("gate_feature(feature = {:?}, span = {:?}); has? {}", name, span, has_feature);
33 if !has_feature && !span.allows_unstable($name) {
34 feature_err_issue(&visitor.sess.parse_sess, name, span, GateIssue::Language, explain)
40 macro_rules! gate_feature_post {
41 ($visitor: expr, $feature: ident, $span: expr, $explain: expr, $help: expr) => {
42 gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain, $help)
44 ($visitor: expr, $feature: ident, $span: expr, $explain: expr) => {
45 gate_feature_fn!($visitor, |x: &Features| x.$feature, $span, sym::$feature, $explain)
49 pub fn check_attribute(attr: &ast::Attribute, sess: &Session, features: &Features) {
50 PostExpansionVisitor { sess, features }.visit_attribute(attr)
53 struct PostExpansionVisitor<'a> {
56 // `sess` contains a `Features`, but this might not be that one.
57 features: &'a Features,
60 impl<'a> PostExpansionVisitor<'a> {
61 fn check_abi(&self, abi: ast::StrLit) {
62 let ast::StrLit { symbol_unescaped, span, .. } = abi;
64 match symbol_unescaped.as_str() {
66 "Rust" | "C" | "cdecl" | "stdcall" | "fastcall" | "aapcs" | "win64" | "sysv64"
69 gate_feature_post!(&self, intrinsics, span, "intrinsics are subject to change");
71 "platform-intrinsic" => {
76 "platform intrinsics are experimental and possibly buggy"
84 "vectorcall is experimental and subject to change"
92 "thiscall is experimental and subject to change"
100 "rust-call ABI is subject to change"
108 "PTX ABIs are experimental and subject to change"
116 "unadjusted ABI is an implementation detail and perma-unstable"
119 "msp430-interrupt" => {
122 abi_msp430_interrupt,
124 "msp430-interrupt ABI is experimental and subject to change"
132 "x86-interrupt ABI is experimental and subject to change"
140 "amdgpu-kernel ABI is experimental and subject to change"
143 "avr-interrupt" | "avr-non-blocking-interrupt" => {
148 "avr-interrupt and avr-non-blocking-interrupt ABIs are experimental and subject to change"
156 "efiapi ABI is experimental and subject to change"
159 "C-cmse-nonsecure-call" => {
162 abi_c_cmse_nonsecure_call,
164 "C-cmse-nonsecure-call ABI is experimental and subject to change"
172 "C-unwind ABI is experimental and subject to change"
175 "stdcall-unwind" => {
180 "stdcall-unwind ABI is experimental and subject to change"
188 "system-unwind ABI is experimental and subject to change"
191 "thiscall-unwind" => {
196 "thiscall-unwind ABI is experimental and subject to change"
204 "wasm ABI is experimental and subject to change"
211 .delay_span_bug(span, &format!("unrecognized ABI not caught in lowering: {}", abi)),
215 fn check_extern(&self, ext: ast::Extern) {
216 if let ast::Extern::Explicit(abi) = ext {
221 fn maybe_report_invalid_custom_discriminants(&self, variants: &[ast::Variant]) {
222 let has_fields = variants.iter().any(|variant| match variant.data {
223 VariantData::Tuple(..) | VariantData::Struct(..) => true,
224 VariantData::Unit(..) => false,
227 let discriminant_spans = variants
229 .filter(|variant| match variant.data {
230 VariantData::Tuple(..) | VariantData::Struct(..) => false,
231 VariantData::Unit(..) => true,
233 .filter_map(|variant| variant.disr_expr.as_ref().map(|c| c.value.span))
234 .collect::<Vec<_>>();
236 if !discriminant_spans.is_empty() && has_fields {
237 let mut err = feature_err(
238 &self.sess.parse_sess,
239 sym::arbitrary_enum_discriminant,
240 discriminant_spans.clone(),
241 "custom discriminant values are not allowed in enums with tuple or struct variants",
243 for sp in discriminant_spans {
244 err.span_label(sp, "disallowed custom discriminant");
246 for variant in variants.iter() {
247 match &variant.data {
248 VariantData::Struct(..) => {
249 err.span_label(variant.span, "struct variant defined here");
251 VariantData::Tuple(..) => {
252 err.span_label(variant.span, "tuple variant defined here");
254 VariantData::Unit(..) => {}
261 fn check_gat(&self, generics: &ast::Generics, span: Span) {
262 if !generics.params.is_empty() {
265 generic_associated_types,
267 "generic associated types are unstable"
270 if !generics.where_clause.predicates.is_empty() {
273 generic_associated_types,
275 "where clauses on associated types are unstable"
280 /// Feature gate `impl Trait` inside `type Alias = $type_expr;`.
281 fn check_impl_trait(&self, ty: &ast::Ty) {
282 struct ImplTraitVisitor<'a> {
283 vis: &'a PostExpansionVisitor<'a>,
285 impl Visitor<'_> for ImplTraitVisitor<'_> {
286 fn visit_ty(&mut self, ty: &ast::Ty) {
287 if let ast::TyKind::ImplTrait(..) = ty.kind {
290 type_alias_impl_trait,
292 "`impl Trait` in type aliases is unstable"
295 visit::walk_ty(self, ty);
298 ImplTraitVisitor { vis: self }.visit_ty(ty);
302 impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
303 fn visit_attribute(&mut self, attr: &ast::Attribute) {
304 let attr_info = attr.ident().and_then(|ident| BUILTIN_ATTRIBUTE_MAP.get(&ident.name));
305 // Check feature gates for built-in attributes.
306 if let Some(BuiltinAttribute {
307 gate: AttributeGate::Gated(_, name, descr, has_feature),
311 gate_feature_fn!(self, has_feature, attr.span, *name, descr);
313 // Check unstable flavors of the `#[doc]` attribute.
314 if attr.has_name(sym::doc) {
315 for nested_meta in attr.meta_item_list().unwrap_or_default() {
316 macro_rules! gate_doc { ($($name:ident => $feature:ident)*) => {
317 $(if nested_meta.has_name(sym::$name) {
318 let msg = concat!("`#[doc(", stringify!($name), ")]` is experimental");
319 gate_feature_post!(self, $feature, attr.span, msg);
325 cfg_hide => doc_cfg_hide
327 notable_trait => doc_notable_trait
330 if nested_meta.has_name(sym::keyword) {
331 let msg = "`#[doc(keyword)]` is meant for internal use only";
332 gate_feature_post!(self, rustdoc_internals, attr.span, msg);
337 // Check for unstable modifiers on `#[link(..)]` attribute
338 if attr.has_name(sym::link) {
339 for nested_meta in attr.meta_item_list().unwrap_or_default() {
340 if nested_meta.has_name(sym::modifiers) {
343 native_link_modifiers,
345 "native link modifiers are experimental"
348 if let Some(modifiers) = nested_meta.value_str() {
349 for modifier in modifiers.as_str().split(',') {
350 if let Some(modifier) = modifier.strip_prefix(&['+', '-']) {
351 macro_rules! gate_modifier { ($($name:literal => $feature:ident)*) => {
352 $(if modifier == $name {
353 let msg = concat!("`#[link(modifiers=\"", $name, "\")]` is unstable");
357 nested_meta.name_value_literal_span().unwrap(),
364 "bundle" => native_link_modifiers_bundle
365 "verbatim" => native_link_modifiers_verbatim
366 "whole-archive" => native_link_modifiers_whole_archive
367 "as-needed" => native_link_modifiers_as_needed
377 fn visit_item(&mut self, i: &'a ast::Item) {
379 ast::ItemKind::ForeignMod(ref foreign_module) => {
380 if let Some(abi) = foreign_module.abi {
385 ast::ItemKind::Fn(..) => {
386 if self.sess.contains_name(&i.attrs, sym::start) {
391 "`#[start]` functions are experimental \
392 and their signature may change \
398 ast::ItemKind::Struct(..) => {
399 for attr in self.sess.filter_by_name(&i.attrs, sym::repr) {
400 for item in attr.meta_item_list().unwrap_or_else(Vec::new) {
401 if item.has_name(sym::simd) {
406 "SIMD types are experimental and possibly buggy"
413 ast::ItemKind::Enum(ast::EnumDef { ref variants, .. }, ..) => {
414 for variant in variants {
415 match (&variant.data, &variant.disr_expr) {
416 (ast::VariantData::Unit(..), _) => {}
417 (_, Some(disr_expr)) => gate_feature_post!(
419 arbitrary_enum_discriminant,
420 disr_expr.value.span,
421 "discriminants on non-unit variants are experimental"
427 let has_feature = self.features.arbitrary_enum_discriminant;
428 if !has_feature && !i.span.allows_unstable(sym::arbitrary_enum_discriminant) {
429 self.maybe_report_invalid_custom_discriminants(&variants);
433 ast::ItemKind::Impl(box ast::Impl { polarity, defaultness, ref of_trait, .. }) => {
434 if let ast::ImplPolarity::Negative(span) = polarity {
438 span.to(of_trait.as_ref().map_or(span, |t| t.path.span)),
439 "negative trait bounds are not yet fully implemented; \
440 use marker types for now"
444 if let ast::Defaultness::Default(_) = defaultness {
445 gate_feature_post!(&self, specialization, i.span, "specialization is unstable");
449 ast::ItemKind::Trait(box ast::Trait { is_auto: ast::IsAuto::Yes, .. }) => {
454 "auto traits are experimental and possibly buggy"
458 ast::ItemKind::TraitAlias(..) => {
459 gate_feature_post!(&self, trait_alias, i.span, "trait aliases are experimental");
462 ast::ItemKind::MacroDef(ast::MacroDef { macro_rules: false, .. }) => {
463 let msg = "`macro` is experimental";
464 gate_feature_post!(&self, decl_macro, i.span, msg);
467 ast::ItemKind::TyAlias(box ast::TyAlias { ty: Some(ref ty), .. }) => {
468 self.check_impl_trait(&ty)
474 visit::walk_item(self, i);
477 fn visit_foreign_item(&mut self, i: &'a ast::ForeignItem) {
479 ast::ForeignItemKind::Fn(..) | ast::ForeignItemKind::Static(..) => {
480 let link_name = self.sess.first_attr_value_str_by_name(&i.attrs, sym::link_name);
482 link_name.map_or(false, |val| val.as_str().starts_with("llvm."));
486 link_llvm_intrinsics,
488 "linking to LLVM intrinsics is experimental"
492 ast::ForeignItemKind::TyAlias(..) => {
493 gate_feature_post!(&self, extern_types, i.span, "extern types are experimental");
495 ast::ForeignItemKind::MacCall(..) => {}
498 visit::walk_foreign_item(self, i)
501 fn visit_ty(&mut self, ty: &'a ast::Ty) {
503 ast::TyKind::BareFn(ref bare_fn_ty) => {
504 self.check_extern(bare_fn_ty.ext);
506 ast::TyKind::Never => {
507 gate_feature_post!(&self, never_type, ty.span, "the `!` type is experimental");
511 visit::walk_ty(self, ty)
514 fn visit_fn_ret_ty(&mut self, ret_ty: &'a ast::FnRetTy) {
515 if let ast::FnRetTy::Ty(ref output_ty) = *ret_ty {
516 if let ast::TyKind::Never = output_ty.kind {
519 self.visit_ty(output_ty)
524 fn visit_expr(&mut self, e: &'a ast::Expr) {
526 ast::ExprKind::Box(_) => {
531 "box expression syntax is experimental; you can call `Box::new` instead"
534 ast::ExprKind::Type(..) => {
535 // To avoid noise about type ascription in common syntax errors, only emit if it
536 // is the *only* error.
537 if self.sess.parse_sess.span_diagnostic.err_count() == 0 {
542 "type ascription is experimental"
546 ast::ExprKind::TryBlock(_) => {
547 gate_feature_post!(&self, try_blocks, e.span, "`try` expression is experimental");
549 ast::ExprKind::Block(_, Some(label)) => {
554 "labels on blocks are unstable"
559 visit::walk_expr(self, e)
562 fn visit_pat(&mut self, pattern: &'a ast::Pat) {
563 match &pattern.kind {
564 PatKind::Slice(pats) => {
566 let inner_pat = match &pat.kind {
567 PatKind::Ident(.., Some(pat)) => pat,
570 if let PatKind::Range(Some(_), None, Spanned { .. }) = inner_pat.kind {
573 half_open_range_patterns,
575 "`X..` patterns in slices are experimental"
580 PatKind::Box(..) => {
585 "box pattern syntax is experimental"
588 PatKind::Range(_, Some(_), Spanned { node: RangeEnd::Excluded, .. }) => {
591 exclusive_range_pattern,
593 "exclusive range pattern syntax is experimental"
598 visit::walk_pat(self, pattern)
601 fn visit_fn(&mut self, fn_kind: FnKind<'a>, span: Span, _: NodeId) {
602 if let Some(header) = fn_kind.header() {
603 // Stability of const fn methods are covered in `visit_assoc_item` below.
604 self.check_extern(header.ext);
606 if let (ast::Const::Yes(_), ast::Extern::Implicit)
607 | (ast::Const::Yes(_), ast::Extern::Explicit(_)) = (header.constness, header.ext)
613 "`const extern fn` definitions are unstable"
618 if fn_kind.ctxt() != Some(FnCtxt::Foreign) && fn_kind.decl().c_variadic() {
619 gate_feature_post!(&self, c_variadic, span, "C-variadic functions are unstable");
622 visit::walk_fn(self, fn_kind, span)
625 fn visit_assoc_constraint(&mut self, constraint: &'a AssocConstraint) {
626 if let AssocConstraintKind::Bound { .. } = constraint.kind {
629 associated_type_bounds,
631 "associated type bounds are unstable"
634 visit::walk_assoc_constraint(self, constraint)
637 fn visit_assoc_item(&mut self, i: &'a ast::AssocItem, ctxt: AssocCtxt) {
638 let is_fn = match i.kind {
639 ast::AssocItemKind::Fn(_) => true,
640 ast::AssocItemKind::TyAlias(box ast::TyAlias { ref generics, ref ty, .. }) => {
641 if let (Some(_), AssocCtxt::Trait) = (ty, ctxt) {
644 associated_type_defaults,
646 "associated type defaults are unstable"
649 if let Some(ty) = ty {
650 self.check_impl_trait(ty);
652 self.check_gat(generics, i.span);
657 if let ast::Defaultness::Default(_) = i.kind.defaultness() {
658 // Limit `min_specialization` to only specializing functions.
661 |x: &Features| x.specialization || (is_fn && x.min_specialization),
664 "specialization is unstable"
667 visit::walk_assoc_item(self, i, ctxt)
670 fn visit_vis(&mut self, vis: &'a ast::Visibility) {
671 if let ast::VisibilityKind::Crate(ast::CrateSugar::JustCrate) = vis.kind {
674 crate_visibility_modifier,
676 "`crate` visibility modifier is experimental"
679 visit::walk_vis(self, vis)
683 pub fn check_crate(krate: &ast::Crate, sess: &Session) {
684 maybe_stage_features(sess, krate);
685 check_incompatible_features(sess);
686 let mut visitor = PostExpansionVisitor { sess, features: &sess.features_untracked() };
688 let spans = sess.parse_sess.gated_spans.spans.borrow();
689 macro_rules! gate_all {
690 ($gate:ident, $msg:literal, $help:literal) => {
691 if let Some(spans) = spans.get(&sym::$gate) {
693 gate_feature_post!(&visitor, $gate, *span, $msg, $help);
697 ($gate:ident, $msg:literal) => {
698 if let Some(spans) = spans.get(&sym::$gate) {
700 gate_feature_post!(&visitor, $gate, *span, $msg);
707 "`if let` guards are experimental",
708 "you can write `if matches!(<expr>, <pattern>)` instead of `if let <pattern> = <expr>`"
710 gate_all!(let_chains, "`let` expressions in this position are unstable");
713 "async closures are unstable",
714 "to use an async block, remove the `||`: `async {`"
716 gate_all!(more_qualified_paths, "usage of qualified paths in this context is experimental");
717 gate_all!(generators, "yield syntax is experimental");
718 gate_all!(raw_ref_op, "raw address of syntax is experimental");
719 gate_all!(const_trait_impl, "const trait impls are experimental");
720 gate_all!(half_open_range_patterns, "half-open range patterns are unstable");
721 gate_all!(inline_const, "inline-const is experimental");
722 gate_all!(inline_const_pat, "inline-const in pattern position is experimental");
723 gate_all!(associated_const_equality, "associated const equality is incomplete");
725 // All uses of `gate_all!` below this point were added in #65742,
726 // and subsequently disabled (with the non-early gating readded).
727 macro_rules! gate_all {
728 ($gate:ident, $msg:literal) => {
729 // FIXME(eddyb) do something more useful than always
730 // disabling these uses of early feature-gatings.
732 for span in spans.get(&sym::$gate).unwrap_or(&vec![]) {
733 gate_feature_post!(&visitor, $gate, *span, $msg);
739 gate_all!(trait_alias, "trait aliases are experimental");
740 gate_all!(associated_type_bounds, "associated type bounds are unstable");
741 gate_all!(crate_visibility_modifier, "`crate` visibility modifier is experimental");
742 gate_all!(decl_macro, "`macro` is experimental");
743 gate_all!(box_patterns, "box pattern syntax is experimental");
744 gate_all!(exclusive_range_pattern, "exclusive range pattern syntax is experimental");
745 gate_all!(try_blocks, "`try` blocks are unstable");
746 gate_all!(label_break_value, "labels on blocks are unstable");
747 gate_all!(box_syntax, "box expression syntax is experimental; you can call `Box::new` instead");
748 // To avoid noise about type ascription in common syntax errors,
749 // only emit if it is the *only* error. (Also check it last.)
750 if sess.parse_sess.span_diagnostic.err_count() == 0 {
751 gate_all!(type_ascription, "type ascription is experimental");
754 visit::walk_crate(&mut visitor, krate);
757 fn maybe_stage_features(sess: &Session, krate: &ast::Crate) {
758 // checks if `#![feature]` has been used to enable any lang feature
759 // does not check the same for lib features unless there's at least one
760 // declared lang feature
761 use rustc_errors::Applicability;
763 if !sess.opts.unstable_features.is_nightly_build() {
764 let lang_features = &sess.features_untracked().declared_lang_features;
765 if lang_features.len() == 0 {
768 for attr in krate.attrs.iter().filter(|attr| attr.has_name(sym::feature)) {
769 let mut err = struct_span_err!(
770 sess.parse_sess.span_diagnostic,
773 "`#![feature]` may not be used on the {} release channel",
774 option_env!("CFG_RELEASE_CHANNEL").unwrap_or("(unknown)")
776 let mut all_stable = true;
778 attr.meta_item_list().into_iter().flatten().map(|nested| nested.ident()).flatten()
780 let name = ident.name;
781 let stable_since = lang_features
783 .flat_map(|&(feature, _, since)| if feature == name { since } else { None })
785 if let Some(since) = stable_since {
787 "the feature `{}` has been stable since {} and no longer requires \
788 an attribute to enable",
798 "remove the attribute",
800 Applicability::MachineApplicable,
808 fn check_incompatible_features(sess: &Session) {
809 let features = sess.features_untracked();
811 let declared_features = features
812 .declared_lang_features
815 .map(|(name, span, _)| (name, span))
816 .chain(features.declared_lib_features.iter().copied());
818 for (f1, f2) in rustc_feature::INCOMPATIBLE_FEATURES
820 .filter(|&&(f1, f2)| features.enabled(f1) && features.enabled(f2))
822 if let Some((f1_name, f1_span)) = declared_features.clone().find(|(name, _)| name == f1) {
823 if let Some((f2_name, f2_span)) = declared_features.clone().find(|(name, _)| name == f2)
825 let spans = vec![f1_span, f2_span];
826 sess.struct_span_err(
829 "features `{}` and `{}` are incompatible, using them at the same time \
834 .help("remove one of these features")