1 #![feature(box_patterns)]
2 #![feature(in_band_lifetimes)]
3 #![feature(or_patterns)]
4 #![feature(rustc_private)]
5 #![recursion_limit = "512"]
6 #![allow(clippy::missing_errors_doc, clippy::missing_panics_doc, clippy::must_use_candidate)]
8 // FIXME: switch to something more ergonomic here, once available.
9 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
10 extern crate rustc_ast;
11 extern crate rustc_ast_pretty;
12 extern crate rustc_data_structures;
13 extern crate rustc_errors;
14 extern crate rustc_hir;
15 extern crate rustc_hir_pretty;
16 extern crate rustc_infer;
17 extern crate rustc_lint;
18 extern crate rustc_middle;
19 extern crate rustc_mir;
20 extern crate rustc_session;
21 extern crate rustc_span;
22 extern crate rustc_target;
23 extern crate rustc_trait_selection;
24 extern crate rustc_typeck;
29 #[allow(clippy::module_name_repetitions)]
36 pub mod eager_or_lazy;
39 pub mod numeric_literal;
42 pub mod qualify_min_const_fn;
47 pub use self::attrs::*;
48 pub use self::diagnostics::*;
49 pub use self::hir_utils::{both, eq_expr_value, over, SpanlessEq, SpanlessHash};
52 use std::collections::hash_map::Entry;
53 use std::hash::BuildHasherDefault;
55 use if_chain::if_chain;
56 use rustc_ast::ast::{self, Attribute, BorrowKind, LitKind, Mutability};
57 use rustc_data_structures::fx::FxHashMap;
58 use rustc_errors::Applicability;
60 use rustc_hir::def::{CtorKind, CtorOf, DefKind, Res};
61 use rustc_hir::def_id::{DefId, LOCAL_CRATE};
62 use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
65 def, Arm, Block, Body, Constness, Crate, Expr, ExprKind, FnDecl, HirId, ImplItem, ImplItemKind, Item, ItemKind,
66 MatchSource, Param, Pat, PatKind, Path, PathSegment, QPath, TraitItem, TraitItemKind, TraitRef, TyKind, Unsafety,
68 use rustc_infer::infer::TyCtxtInferExt;
69 use rustc_lint::{LateContext, Level, Lint, LintContext};
70 use rustc_middle::hir::exports::Export;
71 use rustc_middle::hir::map::Map;
72 use rustc_middle::ty::subst::{GenericArg, GenericArgKind};
73 use rustc_middle::ty::{self, layout::IntegerExt, DefIdTree, Ty, TyCtxt, TypeFoldable};
74 use rustc_semver::RustcVersion;
75 use rustc_session::Session;
76 use rustc_span::hygiene::{ExpnKind, MacroKind};
77 use rustc_span::source_map::original_sp;
79 use rustc_span::symbol::{kw, Symbol};
80 use rustc_span::{BytePos, Pos, Span, DUMMY_SP};
81 use rustc_target::abi::Integer;
82 use rustc_trait_selection::traits::query::normalize::AtExt;
83 use smallvec::SmallVec;
85 use crate::consts::{constant, Constant};
87 pub fn parse_msrv(msrv: &str, sess: Option<&Session>, span: Option<Span>) -> Option<RustcVersion> {
88 if let Ok(version) = RustcVersion::parse(msrv) {
90 } else if let Some(sess) = sess {
91 if let Some(span) = span {
92 sess.span_err(span, &format!("`{}` is not a valid Rust version", msrv));
98 pub fn meets_msrv(msrv: Option<&RustcVersion>, lint_msrv: &RustcVersion) -> bool {
99 msrv.map_or(true, |msrv| msrv.meets(*lint_msrv))
103 macro_rules! extract_msrv_attr {
105 extract_msrv_attr!(@LateContext, ());
108 extract_msrv_attr!(@EarlyContext);
110 (@$context:ident$(, $call:tt)?) => {
111 fn enter_lint_attrs(&mut self, cx: &rustc_lint::$context<'tcx>, attrs: &'tcx [rustc_ast::ast::Attribute]) {
112 use $crate::get_unique_inner_attr;
113 match get_unique_inner_attr(cx.sess$($call)?, attrs, "msrv") {
115 if let Some(msrv) = msrv_attr.value_str() {
116 self.msrv = $crate::parse_msrv(
118 Some(cx.sess$($call)?),
119 Some(msrv_attr.span),
122 cx.sess$($call)?.span_err(msrv_attr.span, "bad clippy attribute");
131 /// Returns `true` if the two spans come from differing expansions (i.e., one is
132 /// from a macro and one isn't).
134 pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
135 rhs.ctxt() != lhs.ctxt()
138 /// Returns `true` if the given `NodeId` is inside a constant context
143 /// if in_constant(cx, expr.hir_id) {
147 pub fn in_constant(cx: &LateContext<'_>, id: HirId) -> bool {
148 let parent_id = cx.tcx.hir().get_parent_item(id);
149 match cx.tcx.hir().get(parent_id) {
151 kind: ItemKind::Const(..) | ItemKind::Static(..),
154 | Node::TraitItem(&TraitItem {
155 kind: TraitItemKind::Const(..),
158 | Node::ImplItem(&ImplItem {
159 kind: ImplItemKind::Const(..),
162 | Node::AnonConst(_) => true,
164 kind: ItemKind::Fn(ref sig, ..),
167 | Node::ImplItem(&ImplItem {
168 kind: ImplItemKind::Fn(ref sig, _),
170 }) => sig.header.constness == Constness::Const,
175 /// Returns `true` if this `span` was expanded by any macro.
177 pub fn in_macro(span: Span) -> bool {
178 if span.from_expansion() {
179 !matches!(span.ctxt().outer_expn_data().kind, ExpnKind::Desugaring(..))
185 // If the snippet is empty, it's an attribute that was inserted during macro
186 // expansion and we want to ignore those, because they could come from external
187 // sources that the user has no control over.
188 // For some reason these attributes don't have any expansion info on them, so
189 // we have to check it this way until there is a better way.
190 pub fn is_present_in_source<T: LintContext>(cx: &T, span: Span) -> bool {
191 if let Some(snippet) = snippet_opt(cx, span) {
192 if snippet.is_empty() {
199 /// Checks if given pattern is a wildcard (`_`)
200 pub fn is_wild<'tcx>(pat: &impl std::ops::Deref<Target = Pat<'tcx>>) -> bool {
201 matches!(pat.kind, PatKind::Wild)
204 /// Checks if type is struct, enum or union type with the given def path.
206 /// If the type is a diagnostic item, use `is_type_diagnostic_item` instead.
207 /// If you change the signature, remember to update the internal lint `MatchTypeOnDiagItem`
208 pub fn match_type(cx: &LateContext<'_>, ty: Ty<'_>, path: &[&str]) -> bool {
210 ty::Adt(adt, _) => match_def_path(cx, adt.did, path),
215 /// Checks if the type is equal to a diagnostic item
217 /// If you change the signature, remember to update the internal lint `MatchTypeOnDiagItem`
218 pub fn is_type_diagnostic_item(cx: &LateContext<'_>, ty: Ty<'_>, diag_item: Symbol) -> bool {
220 ty::Adt(adt, _) => cx.tcx.is_diagnostic_item(diag_item, adt.did),
225 /// Checks if the type is equal to a lang item
226 pub fn is_type_lang_item(cx: &LateContext<'_>, ty: Ty<'_>, lang_item: hir::LangItem) -> bool {
228 ty::Adt(adt, _) => cx.tcx.lang_items().require(lang_item).unwrap() == adt.did,
233 /// Checks if the method call given in `expr` belongs to the given trait.
234 pub fn match_trait_method(cx: &LateContext<'_>, expr: &Expr<'_>, path: &[&str]) -> bool {
235 let def_id = cx.typeck_results().type_dependent_def_id(expr.hir_id).unwrap();
236 let trt_id = cx.tcx.trait_of_item(def_id);
237 trt_id.map_or(false, |trt_id| match_def_path(cx, trt_id, path))
240 /// Checks if an expression references a variable of the given name.
241 pub fn match_var(expr: &Expr<'_>, var: Symbol) -> bool {
242 if let ExprKind::Path(QPath::Resolved(None, ref path)) = expr.kind {
243 if let [p] = path.segments {
244 return p.ident.name == var;
250 pub fn last_path_segment<'tcx>(path: &QPath<'tcx>) -> &'tcx PathSegment<'tcx> {
252 QPath::Resolved(_, ref path) => path.segments.last().expect("A path must have at least one segment"),
253 QPath::TypeRelative(_, ref seg) => seg,
254 QPath::LangItem(..) => panic!("last_path_segment: lang item has no path segments"),
258 pub fn single_segment_path<'tcx>(path: &QPath<'tcx>) -> Option<&'tcx PathSegment<'tcx>> {
260 QPath::Resolved(_, ref path) => path.segments.get(0),
261 QPath::TypeRelative(_, ref seg) => Some(seg),
262 QPath::LangItem(..) => None,
266 /// Matches a `QPath` against a slice of segment string literals.
268 /// There is also `match_path` if you are dealing with a `rustc_hir::Path` instead of a
269 /// `rustc_hir::QPath`.
273 /// match_qpath(path, &["std", "rt", "begin_unwind"])
275 pub fn match_qpath(path: &QPath<'_>, segments: &[&str]) -> bool {
277 QPath::Resolved(_, ref path) => match_path(path, segments),
278 QPath::TypeRelative(ref ty, ref segment) => match ty.kind {
279 TyKind::Path(ref inner_path) => {
280 if let [prefix @ .., end] = segments {
281 if match_qpath(inner_path, prefix) {
282 return segment.ident.name.as_str() == *end;
289 QPath::LangItem(..) => false,
293 /// Matches a `Path` against a slice of segment string literals.
295 /// There is also `match_qpath` if you are dealing with a `rustc_hir::QPath` instead of a
296 /// `rustc_hir::Path`.
301 /// if match_path(&trait_ref.path, &paths::HASH) {
302 /// // This is the `std::hash::Hash` trait.
305 /// if match_path(ty_path, &["rustc", "lint", "Lint"]) {
306 /// // This is a `rustc_middle::lint::Lint`.
309 pub fn match_path(path: &Path<'_>, segments: &[&str]) -> bool {
313 .zip(segments.iter().rev())
314 .all(|(a, b)| a.ident.name.as_str() == *b)
317 /// Matches a `Path` against a slice of segment string literals, e.g.
321 /// match_path_ast(path, &["std", "rt", "begin_unwind"])
323 pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool {
327 .zip(segments.iter().rev())
328 .all(|(a, b)| a.ident.name.as_str() == *b)
331 /// If the expression is a path to a local, returns the canonical `HirId` of the local.
332 pub fn path_to_local(expr: &Expr<'_>) -> Option<HirId> {
333 if let ExprKind::Path(QPath::Resolved(None, ref path)) = expr.kind {
334 if let Res::Local(id) = path.res {
341 /// Returns true if the expression is a path to a local with the specified `HirId`.
342 /// Use this function to see if an expression matches a function argument or a match binding.
343 pub fn path_to_local_id(expr: &Expr<'_>, id: HirId) -> bool {
344 path_to_local(expr) == Some(id)
347 /// Gets the definition associated to a path.
348 #[allow(clippy::shadow_unrelated)] // false positive #6563
349 pub fn path_to_res(cx: &LateContext<'_>, path: &[&str]) -> Res {
350 macro_rules! try_res {
354 None => return Res::Err,
358 fn item_child_by_name<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId, name: &str) -> Option<&'tcx Export<HirId>> {
359 tcx.item_children(def_id)
361 .find(|item| item.ident.name.as_str() == name)
364 let (krate, first, path) = match *path {
365 [krate, first, ref path @ ..] => (krate, first, path),
366 _ => return Res::Err,
369 let crates = tcx.crates();
370 let krate = try_res!(crates.iter().find(|&&num| tcx.crate_name(num).as_str() == krate));
371 let first = try_res!(item_child_by_name(tcx, krate.as_def_id(), first));
375 // `get_def_path` seems to generate these empty segments for extern blocks.
376 // We can just ignore them.
377 .filter(|segment| !segment.is_empty())
378 // for each segment, find the child item
379 .try_fold(first, |item, segment| {
380 let def_id = item.res.def_id();
381 if let Some(item) = item_child_by_name(tcx, def_id, segment) {
383 } else if matches!(item.res, Res::Def(DefKind::Enum | DefKind::Struct, _)) {
384 // it is not a child item so check inherent impl items
385 tcx.inherent_impls(def_id)
387 .find_map(|&impl_def_id| item_child_by_name(tcx, impl_def_id, segment))
395 /// Convenience function to get the `DefId` of a trait by path.
396 /// It could be a trait or trait alias.
397 pub fn get_trait_def_id(cx: &LateContext<'_>, path: &[&str]) -> Option<DefId> {
398 match path_to_res(cx, path) {
399 Res::Def(DefKind::Trait | DefKind::TraitAlias, trait_id) => Some(trait_id),
404 /// Checks whether a type implements a trait.
405 /// See also `get_trait_def_id`.
406 pub fn implements_trait<'tcx>(
407 cx: &LateContext<'tcx>,
410 ty_params: &[GenericArg<'tcx>],
412 // Do not check on infer_types to avoid panic in evaluate_obligation.
413 if ty.has_infer_types() {
416 let ty = cx.tcx.erase_regions(ty);
417 if ty.has_escaping_bound_vars() {
420 let ty_params = cx.tcx.mk_substs(ty_params.iter());
421 cx.tcx.type_implements_trait((trait_id, ty, ty_params, cx.param_env))
424 /// Gets the `hir::TraitRef` of the trait the given method is implemented for.
426 /// Use this if you want to find the `TraitRef` of the `Add` trait in this example:
429 /// struct Point(isize, isize);
431 /// impl std::ops::Add for Point {
432 /// type Output = Self;
434 /// fn add(self, other: Self) -> Self {
439 pub fn trait_ref_of_method<'tcx>(cx: &LateContext<'tcx>, hir_id: HirId) -> Option<&'tcx TraitRef<'tcx>> {
440 // Get the implemented trait for the current function
441 let parent_impl = cx.tcx.hir().get_parent_item(hir_id);
443 if parent_impl != hir::CRATE_HIR_ID;
444 if let hir::Node::Item(item) = cx.tcx.hir().get(parent_impl);
445 if let hir::ItemKind::Impl(impl_) = &item.kind;
446 then { return impl_.of_trait.as_ref(); }
451 /// Checks whether this type implements `Drop`.
452 pub fn has_drop<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
453 match ty.ty_adt_def() {
454 Some(def) => def.has_dtor(cx.tcx),
459 /// Returns the method names and argument list of nested method call expressions that make up
460 /// `expr`. method/span lists are sorted with the most recent call first.
461 pub fn method_calls<'tcx>(
462 expr: &'tcx Expr<'tcx>,
464 ) -> (Vec<Symbol>, Vec<&'tcx [Expr<'tcx>]>, Vec<Span>) {
465 let mut method_names = Vec::with_capacity(max_depth);
466 let mut arg_lists = Vec::with_capacity(max_depth);
467 let mut spans = Vec::with_capacity(max_depth);
469 let mut current = expr;
470 for _ in 0..max_depth {
471 if let ExprKind::MethodCall(path, span, args, _) = ¤t.kind {
472 if args.iter().any(|e| e.span.from_expansion()) {
475 method_names.push(path.ident.name);
476 arg_lists.push(&**args);
484 (method_names, arg_lists, spans)
487 /// Matches an `Expr` against a chain of methods, and return the matched `Expr`s.
489 /// For example, if `expr` represents the `.baz()` in `foo.bar().baz()`,
490 /// `method_chain_args(expr, &["bar", "baz"])` will return a `Vec`
491 /// containing the `Expr`s for
492 /// `.bar()` and `.baz()`
493 pub fn method_chain_args<'a>(expr: &'a Expr<'_>, methods: &[&str]) -> Option<Vec<&'a [Expr<'a>]>> {
494 let mut current = expr;
495 let mut matched = Vec::with_capacity(methods.len());
496 for method_name in methods.iter().rev() {
497 // method chains are stored last -> first
498 if let ExprKind::MethodCall(ref path, _, ref args, _) = current.kind {
499 if path.ident.name.as_str() == *method_name {
500 if args.iter().any(|e| e.span.from_expansion()) {
503 matched.push(&**args); // build up `matched` backwards
504 current = &args[0] // go to parent expression
512 // Reverse `matched` so that it is in the same order as `methods`.
517 /// Returns `true` if the provided `def_id` is an entrypoint to a program.
518 pub fn is_entrypoint_fn(cx: &LateContext<'_>, def_id: DefId) -> bool {
520 .entry_fn(LOCAL_CRATE)
521 .map_or(false, |(entry_fn_def_id, _)| def_id == entry_fn_def_id.to_def_id())
524 /// Returns `true` if the expression is in the program's `#[panic_handler]`.
525 pub fn is_in_panic_handler(cx: &LateContext<'_>, e: &Expr<'_>) -> bool {
526 let parent = cx.tcx.hir().get_parent_item(e.hir_id);
527 let def_id = cx.tcx.hir().local_def_id(parent).to_def_id();
528 Some(def_id) == cx.tcx.lang_items().panic_impl()
531 /// Gets the name of the item the expression is in, if available.
532 pub fn get_item_name(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<Symbol> {
533 let parent_id = cx.tcx.hir().get_parent_item(expr.hir_id);
534 match cx.tcx.hir().find(parent_id) {
536 Node::Item(Item { ident, .. })
537 | Node::TraitItem(TraitItem { ident, .. })
538 | Node::ImplItem(ImplItem { ident, .. }),
539 ) => Some(ident.name),
544 /// Gets the name of a `Pat`, if any.
545 pub fn get_pat_name(pat: &Pat<'_>) -> Option<Symbol> {
547 PatKind::Binding(.., ref spname, _) => Some(spname.name),
548 PatKind::Path(ref qpath) => single_segment_path(qpath).map(|ps| ps.ident.name),
549 PatKind::Box(ref p) | PatKind::Ref(ref p, _) => get_pat_name(&*p),
554 struct ContainsName {
559 impl<'tcx> Visitor<'tcx> for ContainsName {
560 type Map = Map<'tcx>;
562 fn visit_name(&mut self, _: Span, name: Symbol) {
563 if self.name == name {
567 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
568 NestedVisitorMap::None
572 /// Checks if an `Expr` contains a certain name.
573 pub fn contains_name(name: Symbol, expr: &Expr<'_>) -> bool {
574 let mut cn = ContainsName { name, result: false };
579 /// Returns `true` if `expr` contains a return expression
580 pub fn contains_return(expr: &hir::Expr<'_>) -> bool {
581 struct RetCallFinder {
585 impl<'tcx> hir::intravisit::Visitor<'tcx> for RetCallFinder {
586 type Map = Map<'tcx>;
588 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
592 if let hir::ExprKind::Ret(..) = &expr.kind {
595 hir::intravisit::walk_expr(self, expr);
599 fn nested_visit_map(&mut self) -> hir::intravisit::NestedVisitorMap<Self::Map> {
600 hir::intravisit::NestedVisitorMap::None
604 let mut visitor = RetCallFinder { found: false };
605 visitor.visit_expr(expr);
609 struct FindMacroCalls<'a, 'b> {
610 names: &'a [&'b str],
614 impl<'a, 'b, 'tcx> Visitor<'tcx> for FindMacroCalls<'a, 'b> {
615 type Map = Map<'tcx>;
617 fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
618 if self.names.iter().any(|fun| is_expn_of(expr.span, fun).is_some()) {
619 self.result.push(expr.span);
621 // and check sub-expressions
622 intravisit::walk_expr(self, expr);
625 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
626 NestedVisitorMap::None
630 /// Finds calls of the specified macros in a function body.
631 pub fn find_macro_calls(names: &[&str], body: &Body<'_>) -> Vec<Span> {
632 let mut fmc = FindMacroCalls {
636 fmc.visit_expr(&body.value);
640 /// Converts a span to a code snippet if available, otherwise use default.
642 /// This is useful if you want to provide suggestions for your lint or more generally, if you want
643 /// to convert a given `Span` to a `str`.
647 /// snippet(cx, expr.span, "..")
649 pub fn snippet<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
650 snippet_opt(cx, span).map_or_else(|| Cow::Borrowed(default), From::from)
653 /// Same as `snippet`, but it adapts the applicability level by following rules:
655 /// - Applicability level `Unspecified` will never be changed.
656 /// - If the span is inside a macro, change the applicability level to `MaybeIncorrect`.
657 /// - If the default value is used and the applicability level is `MachineApplicable`, change it to
658 /// `HasPlaceholders`
659 pub fn snippet_with_applicability<'a, T: LintContext>(
663 applicability: &mut Applicability,
665 if *applicability != Applicability::Unspecified && span.from_expansion() {
666 *applicability = Applicability::MaybeIncorrect;
668 snippet_opt(cx, span).map_or_else(
670 if *applicability == Applicability::MachineApplicable {
671 *applicability = Applicability::HasPlaceholders;
673 Cow::Borrowed(default)
679 /// Same as `snippet`, but should only be used when it's clear that the input span is
680 /// not a macro argument.
681 pub fn snippet_with_macro_callsite<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
682 snippet(cx, span.source_callsite(), default)
685 /// Converts a span to a code snippet. Returns `None` if not available.
686 pub fn snippet_opt<T: LintContext>(cx: &T, span: Span) -> Option<String> {
687 cx.sess().source_map().span_to_snippet(span).ok()
690 /// Converts a span (from a block) to a code snippet if available, otherwise use default.
692 /// This trims the code of indentation, except for the first line. Use it for blocks or block-like
693 /// things which need to be printed as such.
695 /// The `indent_relative_to` arg can be used, to provide a span, where the indentation of the
696 /// resulting snippet of the given span.
701 /// snippet_block(cx, block.span, "..", None)
702 /// // where, `block` is the block of the if expr
706 /// // will return the snippet
713 /// snippet_block(cx, block.span, "..", Some(if_expr.span))
714 /// // where, `block` is the block of the if expr
718 /// // will return the snippet
721 /// } // aligned with `if`
723 /// Note that the first line of the snippet always has 0 indentation.
724 pub fn snippet_block<'a, T: LintContext>(
728 indent_relative_to: Option<Span>,
730 let snip = snippet(cx, span, default);
731 let indent = indent_relative_to.and_then(|s| indent_of(cx, s));
732 reindent_multiline(snip, true, indent)
735 /// Same as `snippet_block`, but adapts the applicability level by the rules of
736 /// `snippet_with_applicability`.
737 pub fn snippet_block_with_applicability<'a, T: LintContext>(
741 indent_relative_to: Option<Span>,
742 applicability: &mut Applicability,
744 let snip = snippet_with_applicability(cx, span, default, applicability);
745 let indent = indent_relative_to.and_then(|s| indent_of(cx, s));
746 reindent_multiline(snip, true, indent)
749 /// Returns a new Span that extends the original Span to the first non-whitespace char of the first
755 /// // will be converted to
759 pub fn first_line_of_span<T: LintContext>(cx: &T, span: Span) -> Span {
760 first_char_in_first_line(cx, span).map_or(span, |first_char_pos| span.with_lo(first_char_pos))
763 fn first_char_in_first_line<T: LintContext>(cx: &T, span: Span) -> Option<BytePos> {
764 let line_span = line_span(cx, span);
765 snippet_opt(cx, line_span).and_then(|snip| {
766 snip.find(|c: char| !c.is_whitespace())
767 .map(|pos| line_span.lo() + BytePos::from_usize(pos))
771 /// Returns the indentation of the line of a span
775 /// // ^^ -- will return 0
777 /// // ^^ -- will return 4
779 pub fn indent_of<T: LintContext>(cx: &T, span: Span) -> Option<usize> {
780 snippet_opt(cx, line_span(cx, span)).and_then(|snip| snip.find(|c: char| !c.is_whitespace()))
783 /// Returns the positon just before rarrow
786 /// fn into(self) -> () {}
788 /// // in case of unformatted code
789 /// fn into2(self)-> () {}
791 /// fn into3(self) -> () {}
794 pub fn position_before_rarrow(s: &str) -> Option<usize> {
795 s.rfind("->").map(|rpos| {
797 let chars: Vec<char> = s.chars().collect();
799 if let Some(c) = chars.get(rpos - 1) {
800 if c.is_whitespace() {
811 /// Extends the span to the beginning of the spans line, incl. whitespaces.
816 /// // will be converted to
818 /// // ^^^^^^^^^^^^^^
820 fn line_span<T: LintContext>(cx: &T, span: Span) -> Span {
821 let span = original_sp(span, DUMMY_SP);
822 let source_map_and_line = cx.sess().source_map().lookup_line(span.lo()).unwrap();
823 let line_no = source_map_and_line.line;
824 let line_start = source_map_and_line.sf.lines[line_no];
825 Span::new(line_start, span.hi(), span.ctxt())
828 /// Like `snippet_block`, but add braces if the expr is not an `ExprKind::Block`.
829 /// Also takes an `Option<String>` which can be put inside the braces.
830 pub fn expr_block<'a, T: LintContext>(
833 option: Option<String>,
835 indent_relative_to: Option<Span>,
837 let code = snippet_block(cx, expr.span, default, indent_relative_to);
838 let string = option.unwrap_or_default();
839 if expr.span.from_expansion() {
840 Cow::Owned(format!("{{ {} }}", snippet_with_macro_callsite(cx, expr.span, default)))
841 } else if let ExprKind::Block(_, _) = expr.kind {
842 Cow::Owned(format!("{}{}", code, string))
843 } else if string.is_empty() {
844 Cow::Owned(format!("{{ {} }}", code))
846 Cow::Owned(format!("{{\n{};\n{}\n}}", code, string))
850 /// Reindent a multiline string with possibility of ignoring the first line.
851 #[allow(clippy::needless_pass_by_value)]
852 pub fn reindent_multiline(s: Cow<'_, str>, ignore_first: bool, indent: Option<usize>) -> Cow<'_, str> {
853 let s_space = reindent_multiline_inner(&s, ignore_first, indent, ' ');
854 let s_tab = reindent_multiline_inner(&s_space, ignore_first, indent, '\t');
855 reindent_multiline_inner(&s_tab, ignore_first, indent, ' ').into()
858 fn reindent_multiline_inner(s: &str, ignore_first: bool, indent: Option<usize>, ch: char) -> String {
861 .skip(ignore_first as usize)
866 // ignore empty lines
867 Some(l.char_indices().find(|&(_, x)| x != ch).unwrap_or((l.len(), ch)).0)
872 let indent = indent.unwrap_or(0);
876 if (ignore_first && i == 0) || l.is_empty() {
878 } else if x > indent {
879 l.split_at(x - indent).1.to_owned()
881 " ".repeat(indent - x) + l
884 .collect::<Vec<String>>()
888 /// Gets the parent expression, if any –- this is useful to constrain a lint.
889 pub fn get_parent_expr<'tcx>(cx: &LateContext<'tcx>, e: &Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
890 let map = &cx.tcx.hir();
891 let hir_id = e.hir_id;
892 let parent_id = map.get_parent_node(hir_id);
893 if hir_id == parent_id {
896 map.find(parent_id).and_then(|node| {
897 if let Node::Expr(parent) = node {
905 pub fn get_enclosing_block<'tcx>(cx: &LateContext<'tcx>, hir_id: HirId) -> Option<&'tcx Block<'tcx>> {
906 let map = &cx.tcx.hir();
907 let enclosing_node = map
908 .get_enclosing_scope(hir_id)
909 .and_then(|enclosing_id| map.find(enclosing_id));
910 enclosing_node.and_then(|node| match node {
911 Node::Block(block) => Some(block),
913 kind: ItemKind::Fn(_, _, eid),
916 | Node::ImplItem(&ImplItem {
917 kind: ImplItemKind::Fn(_, eid),
919 }) => match cx.tcx.hir().body(eid).value.kind {
920 ExprKind::Block(ref block, _) => Some(block),
927 /// Returns the base type for HIR references and pointers.
928 pub fn walk_ptrs_hir_ty<'tcx>(ty: &'tcx hir::Ty<'tcx>) -> &'tcx hir::Ty<'tcx> {
930 TyKind::Ptr(ref mut_ty) | TyKind::Rptr(_, ref mut_ty) => walk_ptrs_hir_ty(&mut_ty.ty),
935 /// Returns the base type for references and raw pointers, and count reference
937 pub fn walk_ptrs_ty_depth(ty: Ty<'_>) -> (Ty<'_>, usize) {
938 fn inner(ty: Ty<'_>, depth: usize) -> (Ty<'_>, usize) {
940 ty::Ref(_, ty, _) => inner(ty, depth + 1),
947 /// Checks whether the given expression is a constant integer of the given value.
948 /// unlike `is_integer_literal`, this version does const folding
949 pub fn is_integer_const(cx: &LateContext<'_>, e: &Expr<'_>, value: u128) -> bool {
950 if is_integer_literal(e, value) {
953 let map = cx.tcx.hir();
954 let parent_item = map.get_parent_item(e.hir_id);
955 if let Some((Constant::Int(v), _)) = map
956 .maybe_body_owned_by(parent_item)
957 .and_then(|body_id| constant(cx, cx.tcx.typeck_body(body_id), e))
965 /// Checks whether the given expression is a constant literal of the given value.
966 pub fn is_integer_literal(expr: &Expr<'_>, value: u128) -> bool {
967 // FIXME: use constant folding
968 if let ExprKind::Lit(ref spanned) = expr.kind {
969 if let LitKind::Int(v, _) = spanned.node {
976 /// Returns `true` if the given `Expr` has been coerced before.
978 /// Examples of coercions can be found in the Nomicon at
979 /// <https://doc.rust-lang.org/nomicon/coercions.html>.
981 /// See `rustc_middle::ty::adjustment::Adjustment` and `rustc_typeck::check::coercion` for more
982 /// information on adjustments and coercions.
983 pub fn is_adjusted(cx: &LateContext<'_>, e: &Expr<'_>) -> bool {
984 cx.typeck_results().adjustments().get(e.hir_id).is_some()
987 /// Returns the pre-expansion span if is this comes from an expansion of the
989 /// See also `is_direct_expn_of`.
991 pub fn is_expn_of(mut span: Span, name: &str) -> Option<Span> {
993 if span.from_expansion() {
994 let data = span.ctxt().outer_expn_data();
995 let new_span = data.call_site;
997 if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind {
998 if mac_name.as_str() == name {
999 return Some(new_span);
1010 /// Returns the pre-expansion span if the span directly comes from an expansion
1011 /// of the macro `name`.
1012 /// The difference with `is_expn_of` is that in
1016 /// `42` is considered expanded from `foo!` and `bar!` by `is_expn_of` but only
1018 /// `is_direct_expn_of`.
1020 pub fn is_direct_expn_of(span: Span, name: &str) -> Option<Span> {
1021 if span.from_expansion() {
1022 let data = span.ctxt().outer_expn_data();
1023 let new_span = data.call_site;
1025 if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind {
1026 if mac_name.as_str() == name {
1027 return Some(new_span);
1035 /// Convenience function to get the return type of a function.
1036 pub fn return_ty<'tcx>(cx: &LateContext<'tcx>, fn_item: hir::HirId) -> Ty<'tcx> {
1037 let fn_def_id = cx.tcx.hir().local_def_id(fn_item);
1038 let ret_ty = cx.tcx.fn_sig(fn_def_id).output();
1039 cx.tcx.erase_late_bound_regions(ret_ty)
1042 /// Walks into `ty` and returns `true` if any inner type is the same as `other_ty`
1043 pub fn contains_ty(ty: Ty<'_>, other_ty: Ty<'_>) -> bool {
1044 ty.walk().any(|inner| match inner.unpack() {
1045 GenericArgKind::Type(inner_ty) => ty::TyS::same_type(other_ty, inner_ty),
1046 GenericArgKind::Lifetime(_) | GenericArgKind::Const(_) => false,
1050 /// Returns `true` if the given type is an `unsafe` function.
1051 pub fn type_is_unsafe_function<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1053 ty::FnDef(..) | ty::FnPtr(_) => ty.fn_sig(cx.tcx).unsafety() == Unsafety::Unsafe,
1058 pub fn is_copy<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1059 ty.is_copy_modulo_regions(cx.tcx.at(DUMMY_SP), cx.param_env)
1062 /// Checks if an expression is constructing a tuple-like enum variant or struct
1063 pub fn is_ctor_or_promotable_const_function(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
1064 if let ExprKind::Call(ref fun, _) = expr.kind {
1065 if let ExprKind::Path(ref qp) = fun.kind {
1066 let res = cx.qpath_res(qp, fun.hir_id);
1068 def::Res::Def(DefKind::Variant | DefKind::Ctor(..), ..) => true,
1069 def::Res::Def(_, def_id) => cx.tcx.is_promotable_const_fn(def_id),
1077 /// Returns `true` if a pattern is refutable.
1078 // TODO: should be implemented using rustc/mir_build/thir machinery
1079 pub fn is_refutable(cx: &LateContext<'_>, pat: &Pat<'_>) -> bool {
1080 fn is_enum_variant(cx: &LateContext<'_>, qpath: &QPath<'_>, id: HirId) -> bool {
1082 cx.qpath_res(qpath, id),
1083 def::Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(def::CtorOf::Variant, _), _)
1087 fn are_refutable<'a, I: Iterator<Item = &'a Pat<'a>>>(cx: &LateContext<'_>, mut i: I) -> bool {
1088 i.any(|pat| is_refutable(cx, pat))
1092 PatKind::Wild => false,
1093 PatKind::Binding(_, _, _, pat) => pat.map_or(false, |pat| is_refutable(cx, pat)),
1094 PatKind::Box(ref pat) | PatKind::Ref(ref pat, _) => is_refutable(cx, pat),
1095 PatKind::Lit(..) | PatKind::Range(..) => true,
1096 PatKind::Path(ref qpath) => is_enum_variant(cx, qpath, pat.hir_id),
1097 PatKind::Or(ref pats) => {
1098 // TODO: should be the honest check, that pats is exhaustive set
1099 are_refutable(cx, pats.iter().map(|pat| &**pat))
1101 PatKind::Tuple(ref pats, _) => are_refutable(cx, pats.iter().map(|pat| &**pat)),
1102 PatKind::Struct(ref qpath, ref fields, _) => {
1103 is_enum_variant(cx, qpath, pat.hir_id) || are_refutable(cx, fields.iter().map(|field| &*field.pat))
1105 PatKind::TupleStruct(ref qpath, ref pats, _) => {
1106 is_enum_variant(cx, qpath, pat.hir_id) || are_refutable(cx, pats.iter().map(|pat| &**pat))
1108 PatKind::Slice(ref head, ref middle, ref tail) => {
1109 match &cx.typeck_results().node_type(pat.hir_id).kind() {
1111 // [..] is the only irrefutable slice pattern.
1112 !head.is_empty() || middle.is_none() || !tail.is_empty()
1114 ty::Array(..) => are_refutable(cx, head.iter().chain(middle).chain(tail.iter()).map(|pat| &**pat)),
1124 /// Checks for the `#[automatically_derived]` attribute all `#[derive]`d
1125 /// implementations have.
1126 pub fn is_automatically_derived(attrs: &[ast::Attribute]) -> bool {
1127 attrs.iter().any(|attr| attr.has_name(sym::automatically_derived))
1130 /// Remove blocks around an expression.
1132 /// Ie. `x`, `{ x }` and `{{{{ x }}}}` all give `x`. `{ x; y }` and `{}` return
1134 pub fn remove_blocks<'tcx>(mut expr: &'tcx Expr<'tcx>) -> &'tcx Expr<'tcx> {
1135 while let ExprKind::Block(ref block, ..) = expr.kind {
1136 match (block.stmts.is_empty(), block.expr.as_ref()) {
1137 (true, Some(e)) => expr = e,
1144 pub fn is_self(slf: &Param<'_>) -> bool {
1145 if let PatKind::Binding(.., name, _) = slf.pat.kind {
1146 name.name == kw::SelfLower
1152 pub fn is_self_ty(slf: &hir::Ty<'_>) -> bool {
1154 if let TyKind::Path(QPath::Resolved(None, ref path)) = slf.kind;
1155 if let Res::SelfTy(..) = path.res;
1163 pub fn iter_input_pats<'tcx>(decl: &FnDecl<'_>, body: &'tcx Body<'_>) -> impl Iterator<Item = &'tcx Param<'tcx>> {
1164 (0..decl.inputs.len()).map(move |i| &body.params[i])
1167 /// Checks if a given expression is a match expression expanded from the `?`
1168 /// operator or the `try` macro.
1169 pub fn is_try<'tcx>(expr: &'tcx Expr<'tcx>) -> Option<&'tcx Expr<'tcx>> {
1170 fn is_ok(arm: &Arm<'_>) -> bool {
1172 if let PatKind::TupleStruct(ref path, ref pat, None) = arm.pat.kind;
1173 if match_qpath(path, &paths::RESULT_OK[1..]);
1174 if let PatKind::Binding(_, hir_id, _, None) = pat[0].kind;
1175 if path_to_local_id(arm.body, hir_id);
1183 fn is_err(arm: &Arm<'_>) -> bool {
1184 if let PatKind::TupleStruct(ref path, _, _) = arm.pat.kind {
1185 match_qpath(path, &paths::RESULT_ERR[1..])
1191 if let ExprKind::Match(_, ref arms, ref source) = expr.kind {
1192 // desugared from a `?` operator
1193 if let MatchSource::TryDesugar = *source {
1199 if arms[0].guard.is_none();
1200 if arms[1].guard.is_none();
1201 if (is_ok(&arms[0]) && is_err(&arms[1])) ||
1202 (is_ok(&arms[1]) && is_err(&arms[0]));
1212 /// Returns `true` if the lint is allowed in the current context
1214 /// Useful for skipping long running code when it's unnecessary
1215 pub fn is_allowed(cx: &LateContext<'_>, lint: &'static Lint, id: HirId) -> bool {
1216 cx.tcx.lint_level_at_node(lint, id).0 == Level::Allow
1219 pub fn strip_pat_refs<'hir>(mut pat: &'hir Pat<'hir>) -> &'hir Pat<'hir> {
1220 while let PatKind::Ref(subpat, _) = pat.kind {
1226 pub fn int_bits(tcx: TyCtxt<'_>, ity: ty::IntTy) -> u64 {
1227 Integer::from_int_ty(&tcx, ity).size().bits()
1230 #[allow(clippy::cast_possible_wrap)]
1231 /// Turn a constant int byte representation into an i128
1232 pub fn sext(tcx: TyCtxt<'_>, u: u128, ity: ty::IntTy) -> i128 {
1233 let amt = 128 - int_bits(tcx, ity);
1234 ((u as i128) << amt) >> amt
1237 #[allow(clippy::cast_sign_loss)]
1238 /// clip unused bytes
1239 pub fn unsext(tcx: TyCtxt<'_>, u: i128, ity: ty::IntTy) -> u128 {
1240 let amt = 128 - int_bits(tcx, ity);
1241 ((u as u128) << amt) >> amt
1244 /// clip unused bytes
1245 pub fn clip(tcx: TyCtxt<'_>, u: u128, ity: ty::UintTy) -> u128 {
1246 let bits = Integer::from_uint_ty(&tcx, ity).size().bits();
1247 let amt = 128 - bits;
1251 /// Removes block comments from the given `Vec` of lines.
1256 /// without_block_comments(vec!["/*", "foo", "*/"]);
1259 /// without_block_comments(vec!["bar", "/*", "foo", "*/"]);
1260 /// // => vec!["bar"]
1262 pub fn without_block_comments(lines: Vec<&str>) -> Vec<&str> {
1263 let mut without = vec![];
1265 let mut nest_level = 0;
1268 if line.contains("/*") {
1271 } else if line.contains("*/") {
1276 if nest_level == 0 {
1284 pub fn any_parent_is_automatically_derived(tcx: TyCtxt<'_>, node: HirId) -> bool {
1285 let map = &tcx.hir();
1286 let mut prev_enclosing_node = None;
1287 let mut enclosing_node = node;
1288 while Some(enclosing_node) != prev_enclosing_node {
1289 if is_automatically_derived(map.attrs(enclosing_node)) {
1292 prev_enclosing_node = Some(enclosing_node);
1293 enclosing_node = map.get_parent_item(enclosing_node);
1298 /// Returns true if ty has `iter` or `iter_mut` methods
1299 pub fn has_iter_method(cx: &LateContext<'_>, probably_ref_ty: Ty<'_>) -> Option<&'static str> {
1300 // FIXME: instead of this hard-coded list, we should check if `<adt>::iter`
1301 // exists and has the desired signature. Unfortunately FnCtxt is not exported
1302 // so we can't use its `lookup_method` method.
1303 let into_iter_collections: [&[&str]; 13] = [
1310 &paths::LINKED_LIST,
1311 &paths::BINARY_HEAP,
1319 let ty_to_check = match probably_ref_ty.kind() {
1320 ty::Ref(_, ty_to_check, _) => ty_to_check,
1321 _ => probably_ref_ty,
1324 let def_id = match ty_to_check.kind() {
1325 ty::Array(..) => return Some("array"),
1326 ty::Slice(..) => return Some("slice"),
1327 ty::Adt(adt, _) => adt.did,
1331 for path in &into_iter_collections {
1332 if match_def_path(cx, def_id, path) {
1333 return Some(*path.last().unwrap());
1339 /// Matches a function call with the given path and returns the arguments.
1344 /// if let Some(args) = match_function_call(cx, cmp_max_call, &paths::CMP_MAX);
1346 pub fn match_function_call<'tcx>(
1347 cx: &LateContext<'tcx>,
1348 expr: &'tcx Expr<'_>,
1350 ) -> Option<&'tcx [Expr<'tcx>]> {
1352 if let ExprKind::Call(ref fun, ref args) = expr.kind;
1353 if let ExprKind::Path(ref qpath) = fun.kind;
1354 if let Some(fun_def_id) = cx.qpath_res(qpath, fun.hir_id).opt_def_id();
1355 if match_def_path(cx, fun_def_id, path);
1363 /// Checks if `Ty` is normalizable. This function is useful
1364 /// to avoid crashes on `layout_of`.
1365 pub fn is_normalizable<'tcx>(cx: &LateContext<'tcx>, param_env: ty::ParamEnv<'tcx>, ty: Ty<'tcx>) -> bool {
1366 cx.tcx.infer_ctxt().enter(|infcx| {
1367 let cause = rustc_middle::traits::ObligationCause::dummy();
1368 infcx.at(&cause, param_env).normalize(ty).is_ok()
1372 pub fn match_def_path<'tcx>(cx: &LateContext<'tcx>, did: DefId, syms: &[&str]) -> bool {
1373 // We have to convert `syms` to `&[Symbol]` here because rustc's `match_def_path`
1374 // accepts only that. We should probably move to Symbols in Clippy as well.
1375 let syms = syms.iter().map(|p| Symbol::intern(p)).collect::<Vec<Symbol>>();
1376 cx.match_def_path(did, &syms)
1379 pub fn match_panic_call<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<&'tcx [Expr<'tcx>]> {
1380 match_function_call(cx, expr, &paths::BEGIN_PANIC)
1381 .or_else(|| match_function_call(cx, expr, &paths::BEGIN_PANIC_FMT))
1382 .or_else(|| match_function_call(cx, expr, &paths::PANIC_ANY))
1383 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC))
1384 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC_FMT))
1385 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC_STR))
1388 pub fn match_panic_def_id(cx: &LateContext<'_>, did: DefId) -> bool {
1389 match_def_path(cx, did, &paths::BEGIN_PANIC)
1390 || match_def_path(cx, did, &paths::BEGIN_PANIC_FMT)
1391 || match_def_path(cx, did, &paths::PANIC_ANY)
1392 || match_def_path(cx, did, &paths::PANICKING_PANIC)
1393 || match_def_path(cx, did, &paths::PANICKING_PANIC_FMT)
1394 || match_def_path(cx, did, &paths::PANICKING_PANIC_STR)
1397 /// Returns the list of condition expressions and the list of blocks in a
1398 /// sequence of `if/else`.
1399 /// E.g., this returns `([a, b], [c, d, e])` for the expression
1400 /// `if a { c } else if b { d } else { e }`.
1401 pub fn if_sequence<'tcx>(
1402 mut expr: &'tcx Expr<'tcx>,
1403 ) -> (SmallVec<[&'tcx Expr<'tcx>; 1]>, SmallVec<[&'tcx Block<'tcx>; 1]>) {
1404 let mut conds = SmallVec::new();
1405 let mut blocks: SmallVec<[&Block<'_>; 1]> = SmallVec::new();
1407 while let ExprKind::If(ref cond, ref then_expr, ref else_expr) = expr.kind {
1408 conds.push(&**cond);
1409 if let ExprKind::Block(ref block, _) = then_expr.kind {
1412 panic!("ExprKind::If node is not an ExprKind::Block");
1415 if let Some(ref else_expr) = *else_expr {
1422 // final `else {..}`
1423 if !blocks.is_empty() {
1424 if let ExprKind::Block(ref block, _) = expr.kind {
1425 blocks.push(&**block);
1432 pub fn parent_node_is_if_expr(expr: &Expr<'_>, cx: &LateContext<'_>) -> bool {
1433 let map = cx.tcx.hir();
1434 let parent_id = map.get_parent_node(expr.hir_id);
1435 let parent_node = map.get(parent_id);
1439 kind: ExprKind::If(_, _, _),
1445 // Finds the attribute with the given name, if any
1446 pub fn attr_by_name<'a>(attrs: &'a [Attribute], name: &'_ str) -> Option<&'a Attribute> {
1449 .find(|attr| attr.ident().map_or(false, |ident| ident.as_str() == name))
1452 // Finds the `#[must_use]` attribute, if any
1453 pub fn must_use_attr(attrs: &[Attribute]) -> Option<&Attribute> {
1454 attr_by_name(attrs, "must_use")
1457 // Returns whether the type has #[must_use] attribute
1458 pub fn is_must_use_ty<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1460 ty::Adt(ref adt, _) => must_use_attr(&cx.tcx.get_attrs(adt.did)).is_some(),
1461 ty::Foreign(ref did) => must_use_attr(&cx.tcx.get_attrs(*did)).is_some(),
1463 | ty::Array(ref ty, _)
1464 | ty::RawPtr(ty::TypeAndMut { ref ty, .. })
1465 | ty::Ref(_, ref ty, _) => {
1466 // for the Array case we don't need to care for the len == 0 case
1467 // because we don't want to lint functions returning empty arrays
1468 is_must_use_ty(cx, *ty)
1470 ty::Tuple(ref substs) => substs.types().any(|ty| is_must_use_ty(cx, ty)),
1471 ty::Opaque(ref def_id, _) => {
1472 for (predicate, _) in cx.tcx.explicit_item_bounds(*def_id) {
1473 if let ty::PredicateKind::Trait(trait_predicate, _) = predicate.kind().skip_binder() {
1474 if must_use_attr(&cx.tcx.get_attrs(trait_predicate.trait_ref.def_id)).is_some() {
1481 ty::Dynamic(binder, _) => {
1482 for predicate in binder.iter() {
1483 if let ty::ExistentialPredicate::Trait(ref trait_ref) = predicate.skip_binder() {
1484 if must_use_attr(&cx.tcx.get_attrs(trait_ref.def_id)).is_some() {
1495 // check if expr is calling method or function with #[must_use] attribute
1496 pub fn is_must_use_func_call(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
1497 let did = match expr.kind {
1498 ExprKind::Call(ref path, _) => if_chain! {
1499 if let ExprKind::Path(ref qpath) = path.kind;
1500 if let def::Res::Def(_, did) = cx.qpath_res(qpath, path.hir_id);
1507 ExprKind::MethodCall(_, _, _, _) => cx.typeck_results().type_dependent_def_id(expr.hir_id),
1511 did.map_or(false, |did| must_use_attr(&cx.tcx.get_attrs(did)).is_some())
1514 pub fn is_no_std_crate(krate: &Crate<'_>) -> bool {
1515 krate.item.attrs.iter().any(|attr| {
1516 if let ast::AttrKind::Normal(ref attr, _) = attr.kind {
1517 attr.path == sym::no_std
1524 /// Check if parent of a hir node is a trait implementation block.
1525 /// For example, `f` in
1527 /// impl Trait for S {
1531 pub fn is_trait_impl_item(cx: &LateContext<'_>, hir_id: HirId) -> bool {
1532 if let Some(Node::Item(item)) = cx.tcx.hir().find(cx.tcx.hir().get_parent_node(hir_id)) {
1533 matches!(item.kind, ItemKind::Impl(hir::Impl { of_trait: Some(_), .. }))
1539 /// Check if it's even possible to satisfy the `where` clause for the item.
1541 /// `trivial_bounds` feature allows functions with unsatisfiable bounds, for example:
1544 /// fn foo() where i32: Iterator {
1545 /// for _ in 2i32 {}
1548 pub fn fn_has_unsatisfiable_preds(cx: &LateContext<'_>, did: DefId) -> bool {
1549 use rustc_trait_selection::traits;
1555 .filter_map(|(p, _)| if p.is_global() { Some(*p) } else { None });
1556 traits::impossible_predicates(
1558 traits::elaborate_predicates(cx.tcx, predicates)
1559 .map(|o| o.predicate)
1560 .collect::<Vec<_>>(),
1564 /// Returns the `DefId` of the callee if the given expression is a function or method call.
1565 pub fn fn_def_id(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<DefId> {
1567 ExprKind::MethodCall(..) => cx.typeck_results().type_dependent_def_id(expr.hir_id),
1570 kind: ExprKind::Path(qpath),
1571 hir_id: path_hir_id,
1575 ) => cx.typeck_results().qpath_res(qpath, *path_hir_id).opt_def_id(),
1580 pub fn run_lints(cx: &LateContext<'_>, lints: &[&'static Lint], id: HirId) -> bool {
1581 lints.iter().any(|lint| {
1583 cx.tcx.lint_level_at_node(lint, id),
1584 (Level::Forbid | Level::Deny | Level::Warn, _)
1589 /// Returns true iff the given type is a primitive (a bool or char, any integer or floating-point
1590 /// number type, a str, or an array, slice, or tuple of those types).
1591 pub fn is_recursively_primitive_type(ty: Ty<'_>) -> bool {
1593 ty::Bool | ty::Char | ty::Int(_) | ty::Uint(_) | ty::Float(_) | ty::Str => true,
1594 ty::Ref(_, inner, _) if *inner.kind() == ty::Str => true,
1595 ty::Array(inner_type, _) | ty::Slice(inner_type) => is_recursively_primitive_type(inner_type),
1596 ty::Tuple(inner_types) => inner_types.types().all(is_recursively_primitive_type),
1601 /// Returns Option<String> where String is a textual representation of the type encapsulated in the
1602 /// slice iff the given expression is a slice of primitives (as defined in the
1603 /// `is_recursively_primitive_type` function) and None otherwise.
1604 pub fn is_slice_of_primitives(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<String> {
1605 let expr_type = cx.typeck_results().expr_ty_adjusted(expr);
1606 let expr_kind = expr_type.kind();
1607 let is_primitive = match expr_kind {
1608 ty::Slice(element_type) => is_recursively_primitive_type(element_type),
1609 ty::Ref(_, inner_ty, _) if matches!(inner_ty.kind(), &ty::Slice(_)) => {
1610 if let ty::Slice(element_type) = inner_ty.kind() {
1611 is_recursively_primitive_type(element_type)
1620 // if we have wrappers like Array, Slice or Tuple, print these
1621 // and get the type enclosed in the slice ref
1622 match expr_type.peel_refs().walk().nth(1).unwrap().expect_ty().kind() {
1623 ty::Slice(..) => return Some("slice".into()),
1624 ty::Array(..) => return Some("array".into()),
1625 ty::Tuple(..) => return Some("tuple".into()),
1627 // is_recursively_primitive_type() should have taken care
1628 // of the rest and we can rely on the type that is found
1629 let refs_peeled = expr_type.peel_refs();
1630 return Some(refs_peeled.walk().last().unwrap().to_string());
1637 /// returns list of all pairs (a, b) from `exprs` such that `eq(a, b)`
1638 /// `hash` must be comformed with `eq`
1639 pub fn search_same<T, Hash, Eq>(exprs: &[T], hash: Hash, eq: Eq) -> Vec<(&T, &T)>
1641 Hash: Fn(&T) -> u64,
1642 Eq: Fn(&T, &T) -> bool,
1644 if exprs.len() == 2 && eq(&exprs[0], &exprs[1]) {
1645 return vec![(&exprs[0], &exprs[1])];
1648 let mut match_expr_list: Vec<(&T, &T)> = Vec::new();
1650 let mut map: FxHashMap<_, Vec<&_>> =
1651 FxHashMap::with_capacity_and_hasher(exprs.len(), BuildHasherDefault::default());
1654 match map.entry(hash(expr)) {
1655 Entry::Occupied(mut o) => {
1658 match_expr_list.push((o, expr));
1661 o.get_mut().push(expr);
1663 Entry::Vacant(v) => {
1664 v.insert(vec![expr]);
1672 /// Peels off all references on the pattern. Returns the underlying pattern and the number of
1673 /// references removed.
1674 pub fn peel_hir_pat_refs(pat: &'a Pat<'a>) -> (&'a Pat<'a>, usize) {
1675 fn peel(pat: &'a Pat<'a>, count: usize) -> (&'a Pat<'a>, usize) {
1676 if let PatKind::Ref(pat, _) = pat.kind {
1677 peel(pat, count + 1)
1685 /// Peels off up to the given number of references on the expression. Returns the underlying
1686 /// expression and the number of references removed.
1687 pub fn peel_n_hir_expr_refs(expr: &'a Expr<'a>, count: usize) -> (&'a Expr<'a>, usize) {
1688 fn f(expr: &'a Expr<'a>, count: usize, target: usize) -> (&'a Expr<'a>, usize) {
1690 ExprKind::AddrOf(_, _, expr) if count != target => f(expr, count + 1, target),
1697 /// Peels off all references on the expression. Returns the underlying expression and the number of
1698 /// references removed.
1699 pub fn peel_hir_expr_refs(expr: &'a Expr<'a>) -> (&'a Expr<'a>, usize) {
1700 fn f(expr: &'a Expr<'a>, count: usize) -> (&'a Expr<'a>, usize) {
1702 ExprKind::AddrOf(BorrowKind::Ref, _, expr) => f(expr, count + 1),
1709 /// Peels off all references on the type. Returns the underlying type and the number of references
1711 pub fn peel_mid_ty_refs(ty: Ty<'_>) -> (Ty<'_>, usize) {
1712 fn peel(ty: Ty<'_>, count: usize) -> (Ty<'_>, usize) {
1713 if let ty::Ref(_, ty, _) = ty.kind() {
1722 /// Peels off all references on the type.Returns the underlying type, the number of references
1723 /// removed, and whether the pointer is ultimately mutable or not.
1724 pub fn peel_mid_ty_refs_is_mutable(ty: Ty<'_>) -> (Ty<'_>, usize, Mutability) {
1725 fn f(ty: Ty<'_>, count: usize, mutability: Mutability) -> (Ty<'_>, usize, Mutability) {
1727 ty::Ref(_, ty, Mutability::Mut) => f(ty, count + 1, mutability),
1728 ty::Ref(_, ty, Mutability::Not) => f(ty, count + 1, Mutability::Not),
1729 _ => (ty, count, mutability),
1732 f(ty, 0, Mutability::Mut)
1736 macro_rules! unwrap_cargo_metadata {
1737 ($cx: ident, $lint: ident, $deps: expr) => {{
1738 let mut command = cargo_metadata::MetadataCommand::new();
1743 match command.exec() {
1744 Ok(metadata) => metadata,
1746 span_lint($cx, $lint, DUMMY_SP, &format!("could not read cargo metadata: {}", err));
1753 pub fn is_hir_ty_cfg_dependant(cx: &LateContext<'_>, ty: &hir::Ty<'_>) -> bool {
1755 if let TyKind::Path(QPath::Resolved(_, path)) = ty.kind;
1756 if let Res::Def(_, def_id) = path.res;
1758 cx.tcx.has_attr(def_id, sym::cfg) || cx.tcx.has_attr(def_id, sym::cfg_attr)
1765 /// Check if the resolution of a given path is an `Ok` variant of `Result`.
1766 pub fn is_ok_ctor(cx: &LateContext<'_>, res: Res) -> bool {
1767 if let Some(ok_id) = cx.tcx.lang_items().result_ok_variant() {
1768 if let Res::Def(DefKind::Ctor(CtorOf::Variant, CtorKind::Fn), id) = res {
1769 if let Some(variant_id) = cx.tcx.parent(id) {
1770 return variant_id == ok_id;
1777 /// Check if the resolution of a given path is a `Some` variant of `Option`.
1778 pub fn is_some_ctor(cx: &LateContext<'_>, res: Res) -> bool {
1779 if let Some(some_id) = cx.tcx.lang_items().option_some_variant() {
1780 if let Res::Def(DefKind::Ctor(CtorOf::Variant, CtorKind::Fn), id) = res {
1781 if let Some(variant_id) = cx.tcx.parent(id) {
1782 return variant_id == some_id;
1791 use super::{reindent_multiline, without_block_comments};
1794 fn test_reindent_multiline_single_line() {
1795 assert_eq!("", reindent_multiline("".into(), false, None));
1796 assert_eq!("...", reindent_multiline("...".into(), false, None));
1797 assert_eq!("...", reindent_multiline(" ...".into(), false, None));
1798 assert_eq!("...", reindent_multiline("\t...".into(), false, None));
1799 assert_eq!("...", reindent_multiline("\t\t...".into(), false, None));
1804 fn test_reindent_multiline_block() {
1810 }", reindent_multiline(" if x {
1814 }".into(), false, None));
1820 }", reindent_multiline(" if x {
1824 }".into(), false, None));
1829 fn test_reindent_multiline_empty_line() {
1836 }", reindent_multiline(" if x {
1841 }".into(), false, None));
1846 fn test_reindent_multiline_lines_deeper() {
1852 }", reindent_multiline("\
1857 }".into(), true, Some(8)));
1861 fn test_without_block_comments_lines_without_block_comments() {
1862 let result = without_block_comments(vec!["/*", "", "*/"]);
1863 println!("result: {:?}", result);
1864 assert!(result.is_empty());
1866 let result = without_block_comments(vec!["", "/*", "", "*/", "#[crate_type = \"lib\"]", "/*", "", "*/", ""]);
1867 assert_eq!(result, vec!["", "#[crate_type = \"lib\"]", ""]);
1869 let result = without_block_comments(vec!["/* rust", "", "*/"]);
1870 assert!(result.is_empty());
1872 let result = without_block_comments(vec!["/* one-line comment */"]);
1873 assert!(result.is_empty());
1875 let result = without_block_comments(vec!["/* nested", "/* multi-line", "comment", "*/", "test", "*/"]);
1876 assert!(result.is_empty());
1878 let result = without_block_comments(vec!["/* nested /* inline /* comment */ test */ */"]);
1879 assert!(result.is_empty());
1881 let result = without_block_comments(vec!["foo", "bar", "baz"]);
1882 assert_eq!(result, vec!["foo", "bar", "baz"]);