1 // Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution.
4 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
5 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
7 // option. This file may not be copied, modified, or distributed
8 // except according to those terms.
10 use crate::rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
11 use crate::rustc::{declare_tool_lint, lint_array};
12 use crate::syntax::{ast::*, source_map::DUMMY_SP};
13 use crate::utils::span_lint;
16 use if_chain::if_chain;
19 /// **What it does:** Checks for wildcard dependencies in the `Cargo.toml`.
21 /// **Why is this bad?** [As the edition guide says](https://rust-lang-nursery.github.io/edition-guide/rust-2018/cargo-and-crates-io/crates-io-disallows-wildcard-dependencies.html),
22 /// it is highly unlikely that you work with any possible version of your dependency,
23 /// and wildcard dependencies would cause unnecessary breakage in the ecosystem.
25 /// **Known problems:** None.
33 declare_clippy_lint! {
34 pub WILDCARD_DEPENDENCIES,
36 "wildcard dependencies being used"
41 impl LintPass for Pass {
42 fn get_lints(&self) -> LintArray {
43 lint_array!(WILDCARD_DEPENDENCIES)
47 impl EarlyLintPass for Pass {
48 fn check_crate(&mut self, cx: &EarlyContext<'_>, _: &Crate) {
49 let metadata = if let Ok(metadata) = cargo_metadata::metadata(None) {
52 span_lint(cx, WILDCARD_DEPENDENCIES, DUMMY_SP, "could not read cargo metadata");
56 for dep in &metadata.packages[0].dependencies {
57 // VersionReq::any() does not work
59 if let Ok(wildcard_ver) = semver::VersionReq::parse("*");
60 if let Some(ref source) = dep.source;
61 if !source.starts_with("git");
62 if dep.req == wildcard_ver;
66 WILDCARD_DEPENDENCIES,
68 &format!("wildcard dependency for `{}`", dep.name),