1 use crate::utils::span_lint_and_then;
2 use if_chain::if_chain;
3 use rustc_errors::Applicability;
4 use rustc_hir::{Expr, ExprKind};
5 use rustc_lint::{LateContext, LateLintPass};
6 use rustc_session::{declare_lint_pass, declare_tool_lint};
7 use rustc_span::source_map::Spanned;
9 use crate::utils::{match_def_path, paths};
10 use rustc_ast::LitKind;
13 declare_clippy_lint! {
14 /// **What it does:** Finds occurrences of `Vec::resize(0, an_int)`
16 /// **Why is this bad?** This is probably an argument inversion mistake.
18 /// **Known problems:** None.
22 /// vec!(1, 2, 3, 4, 5).resize(0, 5)
24 pub VEC_RESIZE_TO_ZERO,
26 "emptying a vector with `resize(0, an_int)` instead of `clear()` is probably an argument inversion mistake"
29 declare_lint_pass!(VecResizeToZero => [VEC_RESIZE_TO_ZERO]);
31 impl<'tcx> LateLintPass<'tcx> for VecResizeToZero {
32 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
34 if let hir::ExprKind::MethodCall(path_segment, _, ref args, _) = expr.kind;
35 if let Some(method_def_id) = cx.typeck_results().type_dependent_def_id(expr.hir_id);
36 if match_def_path(cx, method_def_id, &paths::VEC_RESIZE) && args.len() == 3;
37 if let ExprKind::Lit(Spanned { node: LitKind::Int(0, _), .. }) = args[1].kind;
38 if let ExprKind::Lit(Spanned { node: LitKind::Int(..), .. }) = args[2].kind;
40 let method_call_span = expr.span.with_lo(path_segment.ident.span.lo());
45 "emptying a vector with `resize`",
47 db.help("the arguments may be inverted...");
50 "...or you can empty the vector with",
51 "clear()".to_string(),
52 Applicability::MaybeIncorrect,