4 #[allow(clippy::module_name_repetitions)]
12 pub mod eager_or_lazy;
16 #[cfg(feature = "internal-lints")]
17 pub mod internal_lints;
18 pub mod numeric_literal;
21 pub mod qualify_min_const_fn;
26 pub use self::attrs::*;
27 pub use self::diagnostics::*;
28 pub use self::hir_utils::{both, eq_expr_value, over, SpanlessEq, SpanlessHash};
31 use std::collections::hash_map::Entry;
32 use std::hash::BuildHasherDefault;
34 use if_chain::if_chain;
35 use rustc_ast::ast::{self, Attribute, LitKind};
36 use rustc_data_structures::fx::FxHashMap;
37 use rustc_errors::Applicability;
39 use rustc_hir::def::{CtorKind, CtorOf, DefKind, Res};
40 use rustc_hir::def_id::{DefId, LOCAL_CRATE};
41 use rustc_hir::intravisit::{self, NestedVisitorMap, Visitor};
44 def, Arm, Block, Body, Constness, Crate, Expr, ExprKind, FnDecl, HirId, ImplItem, ImplItemKind, Item, ItemKind,
45 MatchSource, Param, Pat, PatKind, Path, PathSegment, QPath, TraitItem, TraitItemKind, TraitRef, TyKind, Unsafety,
47 use rustc_infer::infer::TyCtxtInferExt;
48 use rustc_lint::{LateContext, Level, Lint, LintContext};
49 use rustc_middle::hir::exports::Export;
50 use rustc_middle::hir::map::Map;
51 use rustc_middle::ty::subst::{GenericArg, GenericArgKind};
52 use rustc_middle::ty::{self, layout::IntegerExt, DefIdTree, Ty, TyCtxt, TypeFoldable};
53 use rustc_semver::RustcVersion;
54 use rustc_session::Session;
55 use rustc_span::hygiene::{ExpnKind, MacroKind};
56 use rustc_span::source_map::original_sp;
58 use rustc_span::symbol::{kw, Symbol};
59 use rustc_span::{BytePos, Pos, Span, DUMMY_SP};
60 use rustc_target::abi::Integer;
61 use rustc_trait_selection::traits::query::normalize::AtExt;
62 use smallvec::SmallVec;
64 use crate::consts::{constant, Constant};
66 pub fn parse_msrv(msrv: &str, sess: Option<&Session>, span: Option<Span>) -> Option<RustcVersion> {
67 if let Ok(version) = RustcVersion::parse(msrv) {
69 } else if let Some(sess) = sess {
70 if let Some(span) = span {
71 sess.span_err(span, &format!("`{}` is not a valid Rust version", msrv));
77 pub fn meets_msrv(msrv: Option<&RustcVersion>, lint_msrv: &RustcVersion) -> bool {
78 msrv.map_or(true, |msrv| msrv.meets(*lint_msrv))
81 macro_rules! extract_msrv_attr {
83 extract_msrv_attr!(@LateContext, ());
86 extract_msrv_attr!(@EarlyContext);
88 (@$context:ident$(, $call:tt)?) => {
89 fn enter_lint_attrs(&mut self, cx: &rustc_lint::$context<'tcx>, attrs: &'tcx [rustc_ast::ast::Attribute]) {
90 use $crate::utils::get_unique_inner_attr;
91 match get_unique_inner_attr(cx.sess$($call)?, attrs, "msrv") {
93 if let Some(msrv) = msrv_attr.value_str() {
94 self.msrv = $crate::utils::parse_msrv(
96 Some(cx.sess$($call)?),
100 cx.sess$($call)?.span_err(msrv_attr.span, "bad clippy attribute");
109 /// Returns `true` if the two spans come from differing expansions (i.e., one is
110 /// from a macro and one isn't).
112 pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
113 rhs.ctxt() != lhs.ctxt()
116 /// Returns `true` if the given `NodeId` is inside a constant context
121 /// if in_constant(cx, expr.hir_id) {
125 pub fn in_constant(cx: &LateContext<'_>, id: HirId) -> bool {
126 let parent_id = cx.tcx.hir().get_parent_item(id);
127 match cx.tcx.hir().get(parent_id) {
129 kind: ItemKind::Const(..) | ItemKind::Static(..),
132 | Node::TraitItem(&TraitItem {
133 kind: TraitItemKind::Const(..),
136 | Node::ImplItem(&ImplItem {
137 kind: ImplItemKind::Const(..),
140 | Node::AnonConst(_) => true,
142 kind: ItemKind::Fn(ref sig, ..),
145 | Node::ImplItem(&ImplItem {
146 kind: ImplItemKind::Fn(ref sig, _),
148 }) => sig.header.constness == Constness::Const,
153 /// Returns `true` if this `span` was expanded by any macro.
155 pub fn in_macro(span: Span) -> bool {
156 if span.from_expansion() {
157 !matches!(span.ctxt().outer_expn_data().kind, ExpnKind::Desugaring(..))
163 // If the snippet is empty, it's an attribute that was inserted during macro
164 // expansion and we want to ignore those, because they could come from external
165 // sources that the user has no control over.
166 // For some reason these attributes don't have any expansion info on them, so
167 // we have to check it this way until there is a better way.
168 pub fn is_present_in_source<T: LintContext>(cx: &T, span: Span) -> bool {
169 if let Some(snippet) = snippet_opt(cx, span) {
170 if snippet.is_empty() {
177 /// Checks if given pattern is a wildcard (`_`)
178 pub fn is_wild<'tcx>(pat: &impl std::ops::Deref<Target = Pat<'tcx>>) -> bool {
179 matches!(pat.kind, PatKind::Wild)
182 /// Checks if type is struct, enum or union type with the given def path.
184 /// If the type is a diagnostic item, use `is_type_diagnostic_item` instead.
185 /// If you change the signature, remember to update the internal lint `MatchTypeOnDiagItem`
186 pub fn match_type(cx: &LateContext<'_>, ty: Ty<'_>, path: &[&str]) -> bool {
188 ty::Adt(adt, _) => match_def_path(cx, adt.did, path),
193 /// Checks if the type is equal to a diagnostic item
195 /// If you change the signature, remember to update the internal lint `MatchTypeOnDiagItem`
196 pub fn is_type_diagnostic_item(cx: &LateContext<'_>, ty: Ty<'_>, diag_item: Symbol) -> bool {
198 ty::Adt(adt, _) => cx.tcx.is_diagnostic_item(diag_item, adt.did),
203 /// Checks if the type is equal to a lang item
204 pub fn is_type_lang_item(cx: &LateContext<'_>, ty: Ty<'_>, lang_item: hir::LangItem) -> bool {
206 ty::Adt(adt, _) => cx.tcx.lang_items().require(lang_item).unwrap() == adt.did,
211 /// Checks if the method call given in `expr` belongs to the given trait.
212 pub fn match_trait_method(cx: &LateContext<'_>, expr: &Expr<'_>, path: &[&str]) -> bool {
213 let def_id = cx.typeck_results().type_dependent_def_id(expr.hir_id).unwrap();
214 let trt_id = cx.tcx.trait_of_item(def_id);
215 trt_id.map_or(false, |trt_id| match_def_path(cx, trt_id, path))
218 /// Checks if an expression references a variable of the given name.
219 pub fn match_var(expr: &Expr<'_>, var: Symbol) -> bool {
220 if let ExprKind::Path(QPath::Resolved(None, ref path)) = expr.kind {
221 if let [p] = path.segments {
222 return p.ident.name == var;
228 pub fn last_path_segment<'tcx>(path: &QPath<'tcx>) -> &'tcx PathSegment<'tcx> {
230 QPath::Resolved(_, ref path) => path.segments.last().expect("A path must have at least one segment"),
231 QPath::TypeRelative(_, ref seg) => seg,
232 QPath::LangItem(..) => panic!("last_path_segment: lang item has no path segments"),
236 pub fn single_segment_path<'tcx>(path: &QPath<'tcx>) -> Option<&'tcx PathSegment<'tcx>> {
238 QPath::Resolved(_, ref path) => path.segments.get(0),
239 QPath::TypeRelative(_, ref seg) => Some(seg),
240 QPath::LangItem(..) => None,
244 /// Matches a `QPath` against a slice of segment string literals.
246 /// There is also `match_path` if you are dealing with a `rustc_hir::Path` instead of a
247 /// `rustc_hir::QPath`.
251 /// match_qpath(path, &["std", "rt", "begin_unwind"])
253 pub fn match_qpath(path: &QPath<'_>, segments: &[&str]) -> bool {
255 QPath::Resolved(_, ref path) => match_path(path, segments),
256 QPath::TypeRelative(ref ty, ref segment) => match ty.kind {
257 TyKind::Path(ref inner_path) => {
258 if let [prefix @ .., end] = segments {
259 if match_qpath(inner_path, prefix) {
260 return segment.ident.name.as_str() == *end;
267 QPath::LangItem(..) => false,
271 /// Matches a `Path` against a slice of segment string literals.
273 /// There is also `match_qpath` if you are dealing with a `rustc_hir::QPath` instead of a
274 /// `rustc_hir::Path`.
279 /// if match_path(&trait_ref.path, &paths::HASH) {
280 /// // This is the `std::hash::Hash` trait.
283 /// if match_path(ty_path, &["rustc", "lint", "Lint"]) {
284 /// // This is a `rustc_middle::lint::Lint`.
287 pub fn match_path(path: &Path<'_>, segments: &[&str]) -> bool {
291 .zip(segments.iter().rev())
292 .all(|(a, b)| a.ident.name.as_str() == *b)
295 /// Matches a `Path` against a slice of segment string literals, e.g.
299 /// match_path_ast(path, &["std", "rt", "begin_unwind"])
301 pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool {
305 .zip(segments.iter().rev())
306 .all(|(a, b)| a.ident.name.as_str() == *b)
309 /// If the expression is a path to a local, returns the canonical `HirId` of the local.
310 pub fn path_to_local(expr: &Expr<'_>) -> Option<HirId> {
311 if let ExprKind::Path(QPath::Resolved(None, ref path)) = expr.kind {
312 if let Res::Local(id) = path.res {
319 /// Returns true if the expression is a path to a local with the specified `HirId`.
320 /// Use this function to see if an expression matches a function argument or a match binding.
321 pub fn path_to_local_id(expr: &Expr<'_>, id: HirId) -> bool {
322 path_to_local(expr) == Some(id)
325 /// Gets the definition associated to a path.
326 #[allow(clippy::shadow_unrelated)] // false positive #6563
327 pub fn path_to_res(cx: &LateContext<'_>, path: &[&str]) -> Res {
328 macro_rules! try_res {
332 None => return Res::Err,
336 fn item_child_by_name<'tcx>(tcx: TyCtxt<'tcx>, def_id: DefId, name: &str) -> Option<&'tcx Export<HirId>> {
337 tcx.item_children(def_id)
339 .find(|item| item.ident.name.as_str() == name)
342 let (krate, first, path) = match *path {
343 [krate, first, ref path @ ..] => (krate, first, path),
344 _ => return Res::Err,
347 let crates = tcx.crates();
348 let krate = try_res!(crates.iter().find(|&&num| tcx.crate_name(num).as_str() == krate));
349 let first = try_res!(item_child_by_name(tcx, krate.as_def_id(), first));
353 // `get_def_path` seems to generate these empty segments for extern blocks.
354 // We can just ignore them.
355 .filter(|segment| !segment.is_empty())
356 // for each segment, find the child item
357 .try_fold(first, |item, segment| {
358 let def_id = item.res.def_id();
359 if let Some(item) = item_child_by_name(tcx, def_id, segment) {
361 } else if matches!(item.res, Res::Def(DefKind::Enum | DefKind::Struct, _)) {
362 // it is not a child item so check inherent impl items
363 tcx.inherent_impls(def_id)
365 .find_map(|&impl_def_id| item_child_by_name(tcx, impl_def_id, segment))
373 /// Convenience function to get the `DefId` of a trait by path.
374 /// It could be a trait or trait alias.
375 pub fn get_trait_def_id(cx: &LateContext<'_>, path: &[&str]) -> Option<DefId> {
376 match path_to_res(cx, path) {
377 Res::Def(DefKind::Trait | DefKind::TraitAlias, trait_id) => Some(trait_id),
382 /// Checks whether a type implements a trait.
383 /// See also `get_trait_def_id`.
384 pub fn implements_trait<'tcx>(
385 cx: &LateContext<'tcx>,
388 ty_params: &[GenericArg<'tcx>],
390 // Do not check on infer_types to avoid panic in evaluate_obligation.
391 if ty.has_infer_types() {
394 let ty = cx.tcx.erase_regions(ty);
395 if ty.has_escaping_bound_vars() {
398 let ty_params = cx.tcx.mk_substs(ty_params.iter());
399 cx.tcx.type_implements_trait((trait_id, ty, ty_params, cx.param_env))
402 /// Gets the `hir::TraitRef` of the trait the given method is implemented for.
404 /// Use this if you want to find the `TraitRef` of the `Add` trait in this example:
407 /// struct Point(isize, isize);
409 /// impl std::ops::Add for Point {
410 /// type Output = Self;
412 /// fn add(self, other: Self) -> Self {
417 pub fn trait_ref_of_method<'tcx>(cx: &LateContext<'tcx>, hir_id: HirId) -> Option<&'tcx TraitRef<'tcx>> {
418 // Get the implemented trait for the current function
419 let parent_impl = cx.tcx.hir().get_parent_item(hir_id);
421 if parent_impl != hir::CRATE_HIR_ID;
422 if let hir::Node::Item(item) = cx.tcx.hir().get(parent_impl);
423 if let hir::ItemKind::Impl(impl_) = &item.kind;
424 then { return impl_.of_trait.as_ref(); }
429 /// Checks whether this type implements `Drop`.
430 pub fn has_drop<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
431 match ty.ty_adt_def() {
432 Some(def) => def.has_dtor(cx.tcx),
437 /// Returns the method names and argument list of nested method call expressions that make up
438 /// `expr`. method/span lists are sorted with the most recent call first.
439 pub fn method_calls<'tcx>(
440 expr: &'tcx Expr<'tcx>,
442 ) -> (Vec<Symbol>, Vec<&'tcx [Expr<'tcx>]>, Vec<Span>) {
443 let mut method_names = Vec::with_capacity(max_depth);
444 let mut arg_lists = Vec::with_capacity(max_depth);
445 let mut spans = Vec::with_capacity(max_depth);
447 let mut current = expr;
448 for _ in 0..max_depth {
449 if let ExprKind::MethodCall(path, span, args, _) = ¤t.kind {
450 if args.iter().any(|e| e.span.from_expansion()) {
453 method_names.push(path.ident.name);
454 arg_lists.push(&**args);
462 (method_names, arg_lists, spans)
465 /// Matches an `Expr` against a chain of methods, and return the matched `Expr`s.
467 /// For example, if `expr` represents the `.baz()` in `foo.bar().baz()`,
468 /// `method_chain_args(expr, &["bar", "baz"])` will return a `Vec`
469 /// containing the `Expr`s for
470 /// `.bar()` and `.baz()`
471 pub fn method_chain_args<'a>(expr: &'a Expr<'_>, methods: &[&str]) -> Option<Vec<&'a [Expr<'a>]>> {
472 let mut current = expr;
473 let mut matched = Vec::with_capacity(methods.len());
474 for method_name in methods.iter().rev() {
475 // method chains are stored last -> first
476 if let ExprKind::MethodCall(ref path, _, ref args, _) = current.kind {
477 if path.ident.name.as_str() == *method_name {
478 if args.iter().any(|e| e.span.from_expansion()) {
481 matched.push(&**args); // build up `matched` backwards
482 current = &args[0] // go to parent expression
490 // Reverse `matched` so that it is in the same order as `methods`.
495 /// Returns `true` if the provided `def_id` is an entrypoint to a program.
496 pub fn is_entrypoint_fn(cx: &LateContext<'_>, def_id: DefId) -> bool {
498 .entry_fn(LOCAL_CRATE)
499 .map_or(false, |(entry_fn_def_id, _)| def_id == entry_fn_def_id.to_def_id())
502 /// Returns `true` if the expression is in the program's `#[panic_handler]`.
503 pub fn is_in_panic_handler(cx: &LateContext<'_>, e: &Expr<'_>) -> bool {
504 let parent = cx.tcx.hir().get_parent_item(e.hir_id);
505 let def_id = cx.tcx.hir().local_def_id(parent).to_def_id();
506 Some(def_id) == cx.tcx.lang_items().panic_impl()
509 /// Gets the name of the item the expression is in, if available.
510 pub fn get_item_name(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<Symbol> {
511 let parent_id = cx.tcx.hir().get_parent_item(expr.hir_id);
512 match cx.tcx.hir().find(parent_id) {
514 Node::Item(Item { ident, .. })
515 | Node::TraitItem(TraitItem { ident, .. })
516 | Node::ImplItem(ImplItem { ident, .. }),
517 ) => Some(ident.name),
522 /// Gets the name of a `Pat`, if any.
523 pub fn get_pat_name(pat: &Pat<'_>) -> Option<Symbol> {
525 PatKind::Binding(.., ref spname, _) => Some(spname.name),
526 PatKind::Path(ref qpath) => single_segment_path(qpath).map(|ps| ps.ident.name),
527 PatKind::Box(ref p) | PatKind::Ref(ref p, _) => get_pat_name(&*p),
532 struct ContainsName {
537 impl<'tcx> Visitor<'tcx> for ContainsName {
538 type Map = Map<'tcx>;
540 fn visit_name(&mut self, _: Span, name: Symbol) {
541 if self.name == name {
545 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
546 NestedVisitorMap::None
550 /// Checks if an `Expr` contains a certain name.
551 pub fn contains_name(name: Symbol, expr: &Expr<'_>) -> bool {
552 let mut cn = ContainsName { name, result: false };
557 /// Returns `true` if `expr` contains a return expression
558 pub fn contains_return(expr: &hir::Expr<'_>) -> bool {
559 struct RetCallFinder {
563 impl<'tcx> hir::intravisit::Visitor<'tcx> for RetCallFinder {
564 type Map = Map<'tcx>;
566 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'_>) {
570 if let hir::ExprKind::Ret(..) = &expr.kind {
573 hir::intravisit::walk_expr(self, expr);
577 fn nested_visit_map(&mut self) -> hir::intravisit::NestedVisitorMap<Self::Map> {
578 hir::intravisit::NestedVisitorMap::None
582 let mut visitor = RetCallFinder { found: false };
583 visitor.visit_expr(expr);
587 struct FindMacroCalls<'a, 'b> {
588 names: &'a [&'b str],
592 impl<'a, 'b, 'tcx> Visitor<'tcx> for FindMacroCalls<'a, 'b> {
593 type Map = Map<'tcx>;
595 fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
596 if self.names.iter().any(|fun| is_expn_of(expr.span, fun).is_some()) {
597 self.result.push(expr.span);
599 // and check sub-expressions
600 intravisit::walk_expr(self, expr);
603 fn nested_visit_map(&mut self) -> NestedVisitorMap<Self::Map> {
604 NestedVisitorMap::None
608 /// Finds calls of the specified macros in a function body.
609 pub fn find_macro_calls(names: &[&str], body: &Body<'_>) -> Vec<Span> {
610 let mut fmc = FindMacroCalls {
614 fmc.visit_expr(&body.value);
618 /// Converts a span to a code snippet if available, otherwise use default.
620 /// This is useful if you want to provide suggestions for your lint or more generally, if you want
621 /// to convert a given `Span` to a `str`.
625 /// snippet(cx, expr.span, "..")
627 pub fn snippet<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
628 snippet_opt(cx, span).map_or_else(|| Cow::Borrowed(default), From::from)
631 /// Same as `snippet`, but it adapts the applicability level by following rules:
633 /// - Applicability level `Unspecified` will never be changed.
634 /// - If the span is inside a macro, change the applicability level to `MaybeIncorrect`.
635 /// - If the default value is used and the applicability level is `MachineApplicable`, change it to
636 /// `HasPlaceholders`
637 pub fn snippet_with_applicability<'a, T: LintContext>(
641 applicability: &mut Applicability,
643 if *applicability != Applicability::Unspecified && span.from_expansion() {
644 *applicability = Applicability::MaybeIncorrect;
646 snippet_opt(cx, span).map_or_else(
648 if *applicability == Applicability::MachineApplicable {
649 *applicability = Applicability::HasPlaceholders;
651 Cow::Borrowed(default)
657 /// Same as `snippet`, but should only be used when it's clear that the input span is
658 /// not a macro argument.
659 pub fn snippet_with_macro_callsite<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
660 snippet(cx, span.source_callsite(), default)
663 /// Converts a span to a code snippet. Returns `None` if not available.
664 pub fn snippet_opt<T: LintContext>(cx: &T, span: Span) -> Option<String> {
665 cx.sess().source_map().span_to_snippet(span).ok()
668 /// Converts a span (from a block) to a code snippet if available, otherwise use default.
670 /// This trims the code of indentation, except for the first line. Use it for blocks or block-like
671 /// things which need to be printed as such.
673 /// The `indent_relative_to` arg can be used, to provide a span, where the indentation of the
674 /// resulting snippet of the given span.
679 /// snippet_block(cx, block.span, "..", None)
680 /// // where, `block` is the block of the if expr
684 /// // will return the snippet
691 /// snippet_block(cx, block.span, "..", Some(if_expr.span))
692 /// // where, `block` is the block of the if expr
696 /// // will return the snippet
699 /// } // aligned with `if`
701 /// Note that the first line of the snippet always has 0 indentation.
702 pub fn snippet_block<'a, T: LintContext>(
706 indent_relative_to: Option<Span>,
708 let snip = snippet(cx, span, default);
709 let indent = indent_relative_to.and_then(|s| indent_of(cx, s));
710 reindent_multiline(snip, true, indent)
713 /// Same as `snippet_block`, but adapts the applicability level by the rules of
714 /// `snippet_with_applicability`.
715 pub fn snippet_block_with_applicability<'a, T: LintContext>(
719 indent_relative_to: Option<Span>,
720 applicability: &mut Applicability,
722 let snip = snippet_with_applicability(cx, span, default, applicability);
723 let indent = indent_relative_to.and_then(|s| indent_of(cx, s));
724 reindent_multiline(snip, true, indent)
727 /// Returns a new Span that extends the original Span to the first non-whitespace char of the first
733 /// // will be converted to
737 pub fn first_line_of_span<T: LintContext>(cx: &T, span: Span) -> Span {
738 first_char_in_first_line(cx, span).map_or(span, |first_char_pos| span.with_lo(first_char_pos))
741 fn first_char_in_first_line<T: LintContext>(cx: &T, span: Span) -> Option<BytePos> {
742 let line_span = line_span(cx, span);
743 snippet_opt(cx, line_span).and_then(|snip| {
744 snip.find(|c: char| !c.is_whitespace())
745 .map(|pos| line_span.lo() + BytePos::from_usize(pos))
749 /// Returns the indentation of the line of a span
753 /// // ^^ -- will return 0
755 /// // ^^ -- will return 4
757 pub fn indent_of<T: LintContext>(cx: &T, span: Span) -> Option<usize> {
758 snippet_opt(cx, line_span(cx, span)).and_then(|snip| snip.find(|c: char| !c.is_whitespace()))
761 /// Returns the positon just before rarrow
764 /// fn into(self) -> () {}
766 /// // in case of unformatted code
767 /// fn into2(self)-> () {}
769 /// fn into3(self) -> () {}
772 pub fn position_before_rarrow(s: &str) -> Option<usize> {
773 s.rfind("->").map(|rpos| {
775 let chars: Vec<char> = s.chars().collect();
777 if let Some(c) = chars.get(rpos - 1) {
778 if c.is_whitespace() {
789 /// Extends the span to the beginning of the spans line, incl. whitespaces.
794 /// // will be converted to
796 /// // ^^^^^^^^^^^^^^
798 fn line_span<T: LintContext>(cx: &T, span: Span) -> Span {
799 let span = original_sp(span, DUMMY_SP);
800 let source_map_and_line = cx.sess().source_map().lookup_line(span.lo()).unwrap();
801 let line_no = source_map_and_line.line;
802 let line_start = source_map_and_line.sf.lines[line_no];
803 Span::new(line_start, span.hi(), span.ctxt())
806 /// Like `snippet_block`, but add braces if the expr is not an `ExprKind::Block`.
807 /// Also takes an `Option<String>` which can be put inside the braces.
808 pub fn expr_block<'a, T: LintContext>(
811 option: Option<String>,
813 indent_relative_to: Option<Span>,
815 let code = snippet_block(cx, expr.span, default, indent_relative_to);
816 let string = option.unwrap_or_default();
817 if expr.span.from_expansion() {
818 Cow::Owned(format!("{{ {} }}", snippet_with_macro_callsite(cx, expr.span, default)))
819 } else if let ExprKind::Block(_, _) = expr.kind {
820 Cow::Owned(format!("{}{}", code, string))
821 } else if string.is_empty() {
822 Cow::Owned(format!("{{ {} }}", code))
824 Cow::Owned(format!("{{\n{};\n{}\n}}", code, string))
828 /// Reindent a multiline string with possibility of ignoring the first line.
829 #[allow(clippy::needless_pass_by_value)]
830 pub fn reindent_multiline(s: Cow<'_, str>, ignore_first: bool, indent: Option<usize>) -> Cow<'_, str> {
831 let s_space = reindent_multiline_inner(&s, ignore_first, indent, ' ');
832 let s_tab = reindent_multiline_inner(&s_space, ignore_first, indent, '\t');
833 reindent_multiline_inner(&s_tab, ignore_first, indent, ' ').into()
836 fn reindent_multiline_inner(s: &str, ignore_first: bool, indent: Option<usize>, ch: char) -> String {
839 .skip(ignore_first as usize)
844 // ignore empty lines
845 Some(l.char_indices().find(|&(_, x)| x != ch).unwrap_or((l.len(), ch)).0)
850 let indent = indent.unwrap_or(0);
854 if (ignore_first && i == 0) || l.is_empty() {
856 } else if x > indent {
857 l.split_at(x - indent).1.to_owned()
859 " ".repeat(indent - x) + l
862 .collect::<Vec<String>>()
866 /// Gets the parent expression, if any –- this is useful to constrain a lint.
867 pub fn get_parent_expr<'tcx>(cx: &LateContext<'tcx>, e: &Expr<'_>) -> Option<&'tcx Expr<'tcx>> {
868 let map = &cx.tcx.hir();
869 let hir_id = e.hir_id;
870 let parent_id = map.get_parent_node(hir_id);
871 if hir_id == parent_id {
874 map.find(parent_id).and_then(|node| {
875 if let Node::Expr(parent) = node {
883 pub fn get_enclosing_block<'tcx>(cx: &LateContext<'tcx>, hir_id: HirId) -> Option<&'tcx Block<'tcx>> {
884 let map = &cx.tcx.hir();
885 let enclosing_node = map
886 .get_enclosing_scope(hir_id)
887 .and_then(|enclosing_id| map.find(enclosing_id));
888 enclosing_node.and_then(|node| match node {
889 Node::Block(block) => Some(block),
891 kind: ItemKind::Fn(_, _, eid),
894 | Node::ImplItem(&ImplItem {
895 kind: ImplItemKind::Fn(_, eid),
897 }) => match cx.tcx.hir().body(eid).value.kind {
898 ExprKind::Block(ref block, _) => Some(block),
905 /// Returns the base type for HIR references and pointers.
906 pub fn walk_ptrs_hir_ty<'tcx>(ty: &'tcx hir::Ty<'tcx>) -> &'tcx hir::Ty<'tcx> {
908 TyKind::Ptr(ref mut_ty) | TyKind::Rptr(_, ref mut_ty) => walk_ptrs_hir_ty(&mut_ty.ty),
913 /// Returns the base type for references and raw pointers, and count reference
915 pub fn walk_ptrs_ty_depth(ty: Ty<'_>) -> (Ty<'_>, usize) {
916 fn inner(ty: Ty<'_>, depth: usize) -> (Ty<'_>, usize) {
918 ty::Ref(_, ty, _) => inner(ty, depth + 1),
925 /// Checks whether the given expression is a constant integer of the given value.
926 /// unlike `is_integer_literal`, this version does const folding
927 pub fn is_integer_const(cx: &LateContext<'_>, e: &Expr<'_>, value: u128) -> bool {
928 if is_integer_literal(e, value) {
931 let map = cx.tcx.hir();
932 let parent_item = map.get_parent_item(e.hir_id);
933 if let Some((Constant::Int(v), _)) = map
934 .maybe_body_owned_by(parent_item)
935 .and_then(|body_id| constant(cx, cx.tcx.typeck_body(body_id), e))
943 /// Checks whether the given expression is a constant literal of the given value.
944 pub fn is_integer_literal(expr: &Expr<'_>, value: u128) -> bool {
945 // FIXME: use constant folding
946 if let ExprKind::Lit(ref spanned) = expr.kind {
947 if let LitKind::Int(v, _) = spanned.node {
954 /// Returns `true` if the given `Expr` has been coerced before.
956 /// Examples of coercions can be found in the Nomicon at
957 /// <https://doc.rust-lang.org/nomicon/coercions.html>.
959 /// See `rustc_middle::ty::adjustment::Adjustment` and `rustc_typeck::check::coercion` for more
960 /// information on adjustments and coercions.
961 pub fn is_adjusted(cx: &LateContext<'_>, e: &Expr<'_>) -> bool {
962 cx.typeck_results().adjustments().get(e.hir_id).is_some()
965 /// Returns the pre-expansion span if is this comes from an expansion of the
967 /// See also `is_direct_expn_of`.
969 pub fn is_expn_of(mut span: Span, name: &str) -> Option<Span> {
971 if span.from_expansion() {
972 let data = span.ctxt().outer_expn_data();
973 let new_span = data.call_site;
975 if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind {
976 if mac_name.as_str() == name {
977 return Some(new_span);
988 /// Returns the pre-expansion span if the span directly comes from an expansion
989 /// of the macro `name`.
990 /// The difference with `is_expn_of` is that in
994 /// `42` is considered expanded from `foo!` and `bar!` by `is_expn_of` but only
996 /// `is_direct_expn_of`.
998 pub fn is_direct_expn_of(span: Span, name: &str) -> Option<Span> {
999 if span.from_expansion() {
1000 let data = span.ctxt().outer_expn_data();
1001 let new_span = data.call_site;
1003 if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind {
1004 if mac_name.as_str() == name {
1005 return Some(new_span);
1013 /// Convenience function to get the return type of a function.
1014 pub fn return_ty<'tcx>(cx: &LateContext<'tcx>, fn_item: hir::HirId) -> Ty<'tcx> {
1015 let fn_def_id = cx.tcx.hir().local_def_id(fn_item);
1016 let ret_ty = cx.tcx.fn_sig(fn_def_id).output();
1017 cx.tcx.erase_late_bound_regions(ret_ty)
1020 /// Walks into `ty` and returns `true` if any inner type is the same as `other_ty`
1021 pub fn contains_ty(ty: Ty<'_>, other_ty: Ty<'_>) -> bool {
1022 ty.walk().any(|inner| match inner.unpack() {
1023 GenericArgKind::Type(inner_ty) => ty::TyS::same_type(other_ty, inner_ty),
1024 GenericArgKind::Lifetime(_) | GenericArgKind::Const(_) => false,
1028 /// Returns `true` if the given type is an `unsafe` function.
1029 pub fn type_is_unsafe_function<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1031 ty::FnDef(..) | ty::FnPtr(_) => ty.fn_sig(cx.tcx).unsafety() == Unsafety::Unsafe,
1036 pub fn is_copy<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1037 ty.is_copy_modulo_regions(cx.tcx.at(DUMMY_SP), cx.param_env)
1040 /// Checks if an expression is constructing a tuple-like enum variant or struct
1041 pub fn is_ctor_or_promotable_const_function(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
1042 if let ExprKind::Call(ref fun, _) = expr.kind {
1043 if let ExprKind::Path(ref qp) = fun.kind {
1044 let res = cx.qpath_res(qp, fun.hir_id);
1046 def::Res::Def(DefKind::Variant | DefKind::Ctor(..), ..) => true,
1047 def::Res::Def(_, def_id) => cx.tcx.is_promotable_const_fn(def_id),
1055 /// Returns `true` if a pattern is refutable.
1056 // TODO: should be implemented using rustc/mir_build/thir machinery
1057 pub fn is_refutable(cx: &LateContext<'_>, pat: &Pat<'_>) -> bool {
1058 fn is_enum_variant(cx: &LateContext<'_>, qpath: &QPath<'_>, id: HirId) -> bool {
1060 cx.qpath_res(qpath, id),
1061 def::Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(def::CtorOf::Variant, _), _)
1065 fn are_refutable<'a, I: Iterator<Item = &'a Pat<'a>>>(cx: &LateContext<'_>, mut i: I) -> bool {
1066 i.any(|pat| is_refutable(cx, pat))
1070 PatKind::Wild => false,
1071 PatKind::Binding(_, _, _, pat) => pat.map_or(false, |pat| is_refutable(cx, pat)),
1072 PatKind::Box(ref pat) | PatKind::Ref(ref pat, _) => is_refutable(cx, pat),
1073 PatKind::Lit(..) | PatKind::Range(..) => true,
1074 PatKind::Path(ref qpath) => is_enum_variant(cx, qpath, pat.hir_id),
1075 PatKind::Or(ref pats) => {
1076 // TODO: should be the honest check, that pats is exhaustive set
1077 are_refutable(cx, pats.iter().map(|pat| &**pat))
1079 PatKind::Tuple(ref pats, _) => are_refutable(cx, pats.iter().map(|pat| &**pat)),
1080 PatKind::Struct(ref qpath, ref fields, _) => {
1081 is_enum_variant(cx, qpath, pat.hir_id) || are_refutable(cx, fields.iter().map(|field| &*field.pat))
1083 PatKind::TupleStruct(ref qpath, ref pats, _) => {
1084 is_enum_variant(cx, qpath, pat.hir_id) || are_refutable(cx, pats.iter().map(|pat| &**pat))
1086 PatKind::Slice(ref head, ref middle, ref tail) => {
1087 match &cx.typeck_results().node_type(pat.hir_id).kind() {
1089 // [..] is the only irrefutable slice pattern.
1090 !head.is_empty() || middle.is_none() || !tail.is_empty()
1092 ty::Array(..) => are_refutable(cx, head.iter().chain(middle).chain(tail.iter()).map(|pat| &**pat)),
1102 /// Checks for the `#[automatically_derived]` attribute all `#[derive]`d
1103 /// implementations have.
1104 pub fn is_automatically_derived(attrs: &[ast::Attribute]) -> bool {
1105 attrs.iter().any(|attr| attr.has_name(sym::automatically_derived))
1108 /// Remove blocks around an expression.
1110 /// Ie. `x`, `{ x }` and `{{{{ x }}}}` all give `x`. `{ x; y }` and `{}` return
1112 pub fn remove_blocks<'tcx>(mut expr: &'tcx Expr<'tcx>) -> &'tcx Expr<'tcx> {
1113 while let ExprKind::Block(ref block, ..) = expr.kind {
1114 match (block.stmts.is_empty(), block.expr.as_ref()) {
1115 (true, Some(e)) => expr = e,
1122 pub fn is_self(slf: &Param<'_>) -> bool {
1123 if let PatKind::Binding(.., name, _) = slf.pat.kind {
1124 name.name == kw::SelfLower
1130 pub fn is_self_ty(slf: &hir::Ty<'_>) -> bool {
1132 if let TyKind::Path(QPath::Resolved(None, ref path)) = slf.kind;
1133 if let Res::SelfTy(..) = path.res;
1141 pub fn iter_input_pats<'tcx>(decl: &FnDecl<'_>, body: &'tcx Body<'_>) -> impl Iterator<Item = &'tcx Param<'tcx>> {
1142 (0..decl.inputs.len()).map(move |i| &body.params[i])
1145 /// Checks if a given expression is a match expression expanded from the `?`
1146 /// operator or the `try` macro.
1147 pub fn is_try<'tcx>(expr: &'tcx Expr<'tcx>) -> Option<&'tcx Expr<'tcx>> {
1148 fn is_ok(arm: &Arm<'_>) -> bool {
1150 if let PatKind::TupleStruct(ref path, ref pat, None) = arm.pat.kind;
1151 if match_qpath(path, &paths::RESULT_OK[1..]);
1152 if let PatKind::Binding(_, hir_id, _, None) = pat[0].kind;
1153 if path_to_local_id(arm.body, hir_id);
1161 fn is_err(arm: &Arm<'_>) -> bool {
1162 if let PatKind::TupleStruct(ref path, _, _) = arm.pat.kind {
1163 match_qpath(path, &paths::RESULT_ERR[1..])
1169 if let ExprKind::Match(_, ref arms, ref source) = expr.kind {
1170 // desugared from a `?` operator
1171 if let MatchSource::TryDesugar = *source {
1177 if arms[0].guard.is_none();
1178 if arms[1].guard.is_none();
1179 if (is_ok(&arms[0]) && is_err(&arms[1])) ||
1180 (is_ok(&arms[1]) && is_err(&arms[0]));
1190 /// Returns `true` if the lint is allowed in the current context
1192 /// Useful for skipping long running code when it's unnecessary
1193 pub fn is_allowed(cx: &LateContext<'_>, lint: &'static Lint, id: HirId) -> bool {
1194 cx.tcx.lint_level_at_node(lint, id).0 == Level::Allow
1197 pub fn strip_pat_refs<'hir>(mut pat: &'hir Pat<'hir>) -> &'hir Pat<'hir> {
1198 while let PatKind::Ref(subpat, _) = pat.kind {
1204 pub fn int_bits(tcx: TyCtxt<'_>, ity: ty::IntTy) -> u64 {
1205 Integer::from_int_ty(&tcx, ity).size().bits()
1208 #[allow(clippy::cast_possible_wrap)]
1209 /// Turn a constant int byte representation into an i128
1210 pub fn sext(tcx: TyCtxt<'_>, u: u128, ity: ty::IntTy) -> i128 {
1211 let amt = 128 - int_bits(tcx, ity);
1212 ((u as i128) << amt) >> amt
1215 #[allow(clippy::cast_sign_loss)]
1216 /// clip unused bytes
1217 pub fn unsext(tcx: TyCtxt<'_>, u: i128, ity: ty::IntTy) -> u128 {
1218 let amt = 128 - int_bits(tcx, ity);
1219 ((u as u128) << amt) >> amt
1222 /// clip unused bytes
1223 pub fn clip(tcx: TyCtxt<'_>, u: u128, ity: ty::UintTy) -> u128 {
1224 let bits = Integer::from_uint_ty(&tcx, ity).size().bits();
1225 let amt = 128 - bits;
1229 /// Removes block comments from the given `Vec` of lines.
1234 /// without_block_comments(vec!["/*", "foo", "*/"]);
1237 /// without_block_comments(vec!["bar", "/*", "foo", "*/"]);
1238 /// // => vec!["bar"]
1240 pub fn without_block_comments(lines: Vec<&str>) -> Vec<&str> {
1241 let mut without = vec![];
1243 let mut nest_level = 0;
1246 if line.contains("/*") {
1249 } else if line.contains("*/") {
1254 if nest_level == 0 {
1262 pub fn any_parent_is_automatically_derived(tcx: TyCtxt<'_>, node: HirId) -> bool {
1263 let map = &tcx.hir();
1264 let mut prev_enclosing_node = None;
1265 let mut enclosing_node = node;
1266 while Some(enclosing_node) != prev_enclosing_node {
1267 if is_automatically_derived(map.attrs(enclosing_node)) {
1270 prev_enclosing_node = Some(enclosing_node);
1271 enclosing_node = map.get_parent_item(enclosing_node);
1276 /// Returns true if ty has `iter` or `iter_mut` methods
1277 pub fn has_iter_method(cx: &LateContext<'_>, probably_ref_ty: Ty<'_>) -> Option<&'static str> {
1278 // FIXME: instead of this hard-coded list, we should check if `<adt>::iter`
1279 // exists and has the desired signature. Unfortunately FnCtxt is not exported
1280 // so we can't use its `lookup_method` method.
1281 let into_iter_collections: [&[&str]; 13] = [
1288 &paths::LINKED_LIST,
1289 &paths::BINARY_HEAP,
1297 let ty_to_check = match probably_ref_ty.kind() {
1298 ty::Ref(_, ty_to_check, _) => ty_to_check,
1299 _ => probably_ref_ty,
1302 let def_id = match ty_to_check.kind() {
1303 ty::Array(..) => return Some("array"),
1304 ty::Slice(..) => return Some("slice"),
1305 ty::Adt(adt, _) => adt.did,
1309 for path in &into_iter_collections {
1310 if match_def_path(cx, def_id, path) {
1311 return Some(*path.last().unwrap());
1317 /// Matches a function call with the given path and returns the arguments.
1322 /// if let Some(args) = match_function_call(cx, cmp_max_call, &paths::CMP_MAX);
1324 pub fn match_function_call<'tcx>(
1325 cx: &LateContext<'tcx>,
1326 expr: &'tcx Expr<'_>,
1328 ) -> Option<&'tcx [Expr<'tcx>]> {
1330 if let ExprKind::Call(ref fun, ref args) = expr.kind;
1331 if let ExprKind::Path(ref qpath) = fun.kind;
1332 if let Some(fun_def_id) = cx.qpath_res(qpath, fun.hir_id).opt_def_id();
1333 if match_def_path(cx, fun_def_id, path);
1341 /// Checks if `Ty` is normalizable. This function is useful
1342 /// to avoid crashes on `layout_of`.
1343 pub fn is_normalizable<'tcx>(cx: &LateContext<'tcx>, param_env: ty::ParamEnv<'tcx>, ty: Ty<'tcx>) -> bool {
1344 cx.tcx.infer_ctxt().enter(|infcx| {
1345 let cause = rustc_middle::traits::ObligationCause::dummy();
1346 infcx.at(&cause, param_env).normalize(ty).is_ok()
1350 pub fn match_def_path<'tcx>(cx: &LateContext<'tcx>, did: DefId, syms: &[&str]) -> bool {
1351 // We have to convert `syms` to `&[Symbol]` here because rustc's `match_def_path`
1352 // accepts only that. We should probably move to Symbols in Clippy as well.
1353 let syms = syms.iter().map(|p| Symbol::intern(p)).collect::<Vec<Symbol>>();
1354 cx.match_def_path(did, &syms)
1357 pub fn match_panic_call<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) -> Option<&'tcx [Expr<'tcx>]> {
1358 match_function_call(cx, expr, &paths::BEGIN_PANIC)
1359 .or_else(|| match_function_call(cx, expr, &paths::BEGIN_PANIC_FMT))
1360 .or_else(|| match_function_call(cx, expr, &paths::PANIC_ANY))
1361 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC))
1362 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC_FMT))
1363 .or_else(|| match_function_call(cx, expr, &paths::PANICKING_PANIC_STR))
1366 pub fn match_panic_def_id(cx: &LateContext<'_>, did: DefId) -> bool {
1367 match_def_path(cx, did, &paths::BEGIN_PANIC)
1368 || match_def_path(cx, did, &paths::BEGIN_PANIC_FMT)
1369 || match_def_path(cx, did, &paths::PANIC_ANY)
1370 || match_def_path(cx, did, &paths::PANICKING_PANIC)
1371 || match_def_path(cx, did, &paths::PANICKING_PANIC_FMT)
1372 || match_def_path(cx, did, &paths::PANICKING_PANIC_STR)
1375 /// Returns the list of condition expressions and the list of blocks in a
1376 /// sequence of `if/else`.
1377 /// E.g., this returns `([a, b], [c, d, e])` for the expression
1378 /// `if a { c } else if b { d } else { e }`.
1379 pub fn if_sequence<'tcx>(
1380 mut expr: &'tcx Expr<'tcx>,
1381 ) -> (SmallVec<[&'tcx Expr<'tcx>; 1]>, SmallVec<[&'tcx Block<'tcx>; 1]>) {
1382 let mut conds = SmallVec::new();
1383 let mut blocks: SmallVec<[&Block<'_>; 1]> = SmallVec::new();
1385 while let ExprKind::If(ref cond, ref then_expr, ref else_expr) = expr.kind {
1386 conds.push(&**cond);
1387 if let ExprKind::Block(ref block, _) = then_expr.kind {
1390 panic!("ExprKind::If node is not an ExprKind::Block");
1393 if let Some(ref else_expr) = *else_expr {
1400 // final `else {..}`
1401 if !blocks.is_empty() {
1402 if let ExprKind::Block(ref block, _) = expr.kind {
1403 blocks.push(&**block);
1410 pub fn parent_node_is_if_expr(expr: &Expr<'_>, cx: &LateContext<'_>) -> bool {
1411 let map = cx.tcx.hir();
1412 let parent_id = map.get_parent_node(expr.hir_id);
1413 let parent_node = map.get(parent_id);
1417 kind: ExprKind::If(_, _, _),
1423 // Finds the attribute with the given name, if any
1424 pub fn attr_by_name<'a>(attrs: &'a [Attribute], name: &'_ str) -> Option<&'a Attribute> {
1427 .find(|attr| attr.ident().map_or(false, |ident| ident.as_str() == name))
1430 // Finds the `#[must_use]` attribute, if any
1431 pub fn must_use_attr(attrs: &[Attribute]) -> Option<&Attribute> {
1432 attr_by_name(attrs, "must_use")
1435 // Returns whether the type has #[must_use] attribute
1436 pub fn is_must_use_ty<'tcx>(cx: &LateContext<'tcx>, ty: Ty<'tcx>) -> bool {
1438 ty::Adt(ref adt, _) => must_use_attr(&cx.tcx.get_attrs(adt.did)).is_some(),
1439 ty::Foreign(ref did) => must_use_attr(&cx.tcx.get_attrs(*did)).is_some(),
1441 | ty::Array(ref ty, _)
1442 | ty::RawPtr(ty::TypeAndMut { ref ty, .. })
1443 | ty::Ref(_, ref ty, _) => {
1444 // for the Array case we don't need to care for the len == 0 case
1445 // because we don't want to lint functions returning empty arrays
1446 is_must_use_ty(cx, *ty)
1448 ty::Tuple(ref substs) => substs.types().any(|ty| is_must_use_ty(cx, ty)),
1449 ty::Opaque(ref def_id, _) => {
1450 for (predicate, _) in cx.tcx.explicit_item_bounds(*def_id) {
1451 if let ty::PredicateKind::Trait(trait_predicate, _) = predicate.kind().skip_binder() {
1452 if must_use_attr(&cx.tcx.get_attrs(trait_predicate.trait_ref.def_id)).is_some() {
1459 ty::Dynamic(binder, _) => {
1460 for predicate in binder.iter() {
1461 if let ty::ExistentialPredicate::Trait(ref trait_ref) = predicate.skip_binder() {
1462 if must_use_attr(&cx.tcx.get_attrs(trait_ref.def_id)).is_some() {
1473 // check if expr is calling method or function with #[must_use] attribute
1474 pub fn is_must_use_func_call(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
1475 let did = match expr.kind {
1476 ExprKind::Call(ref path, _) => if_chain! {
1477 if let ExprKind::Path(ref qpath) = path.kind;
1478 if let def::Res::Def(_, did) = cx.qpath_res(qpath, path.hir_id);
1485 ExprKind::MethodCall(_, _, _, _) => cx.typeck_results().type_dependent_def_id(expr.hir_id),
1489 did.map_or(false, |did| must_use_attr(&cx.tcx.get_attrs(did)).is_some())
1492 pub fn is_no_std_crate(krate: &Crate<'_>) -> bool {
1493 krate.item.attrs.iter().any(|attr| {
1494 if let ast::AttrKind::Normal(ref attr, _) = attr.kind {
1495 attr.path == sym::no_std
1502 /// Check if parent of a hir node is a trait implementation block.
1503 /// For example, `f` in
1505 /// impl Trait for S {
1509 pub fn is_trait_impl_item(cx: &LateContext<'_>, hir_id: HirId) -> bool {
1510 if let Some(Node::Item(item)) = cx.tcx.hir().find(cx.tcx.hir().get_parent_node(hir_id)) {
1511 matches!(item.kind, ItemKind::Impl(hir::Impl { of_trait: Some(_), .. }))
1517 /// Check if it's even possible to satisfy the `where` clause for the item.
1519 /// `trivial_bounds` feature allows functions with unsatisfiable bounds, for example:
1522 /// fn foo() where i32: Iterator {
1523 /// for _ in 2i32 {}
1526 pub fn fn_has_unsatisfiable_preds(cx: &LateContext<'_>, did: DefId) -> bool {
1527 use rustc_trait_selection::traits;
1533 .filter_map(|(p, _)| if p.is_global() { Some(*p) } else { None });
1534 traits::impossible_predicates(
1536 traits::elaborate_predicates(cx.tcx, predicates)
1537 .map(|o| o.predicate)
1538 .collect::<Vec<_>>(),
1542 /// Returns the `DefId` of the callee if the given expression is a function or method call.
1543 pub fn fn_def_id(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<DefId> {
1545 ExprKind::MethodCall(..) => cx.typeck_results().type_dependent_def_id(expr.hir_id),
1548 kind: ExprKind::Path(qpath),
1549 hir_id: path_hir_id,
1553 ) => cx.typeck_results().qpath_res(qpath, *path_hir_id).opt_def_id(),
1558 pub fn run_lints(cx: &LateContext<'_>, lints: &[&'static Lint], id: HirId) -> bool {
1559 lints.iter().any(|lint| {
1561 cx.tcx.lint_level_at_node(lint, id),
1562 (Level::Forbid | Level::Deny | Level::Warn, _)
1567 /// Returns true iff the given type is a primitive (a bool or char, any integer or floating-point
1568 /// number type, a str, or an array, slice, or tuple of those types).
1569 pub fn is_recursively_primitive_type(ty: Ty<'_>) -> bool {
1571 ty::Bool | ty::Char | ty::Int(_) | ty::Uint(_) | ty::Float(_) | ty::Str => true,
1572 ty::Ref(_, inner, _) if *inner.kind() == ty::Str => true,
1573 ty::Array(inner_type, _) | ty::Slice(inner_type) => is_recursively_primitive_type(inner_type),
1574 ty::Tuple(inner_types) => inner_types.types().all(is_recursively_primitive_type),
1579 /// Returns Option<String> where String is a textual representation of the type encapsulated in the
1580 /// slice iff the given expression is a slice of primitives (as defined in the
1581 /// `is_recursively_primitive_type` function) and None otherwise.
1582 pub fn is_slice_of_primitives(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<String> {
1583 let expr_type = cx.typeck_results().expr_ty_adjusted(expr);
1584 let expr_kind = expr_type.kind();
1585 let is_primitive = match expr_kind {
1586 ty::Slice(element_type) => is_recursively_primitive_type(element_type),
1587 ty::Ref(_, inner_ty, _) if matches!(inner_ty.kind(), &ty::Slice(_)) => {
1588 if let ty::Slice(element_type) = inner_ty.kind() {
1589 is_recursively_primitive_type(element_type)
1598 // if we have wrappers like Array, Slice or Tuple, print these
1599 // and get the type enclosed in the slice ref
1600 match expr_type.peel_refs().walk().nth(1).unwrap().expect_ty().kind() {
1601 ty::Slice(..) => return Some("slice".into()),
1602 ty::Array(..) => return Some("array".into()),
1603 ty::Tuple(..) => return Some("tuple".into()),
1605 // is_recursively_primitive_type() should have taken care
1606 // of the rest and we can rely on the type that is found
1607 let refs_peeled = expr_type.peel_refs();
1608 return Some(refs_peeled.walk().last().unwrap().to_string());
1615 /// returns list of all pairs (a, b) from `exprs` such that `eq(a, b)`
1616 /// `hash` must be comformed with `eq`
1617 pub fn search_same<T, Hash, Eq>(exprs: &[T], hash: Hash, eq: Eq) -> Vec<(&T, &T)>
1619 Hash: Fn(&T) -> u64,
1620 Eq: Fn(&T, &T) -> bool,
1622 if exprs.len() == 2 && eq(&exprs[0], &exprs[1]) {
1623 return vec![(&exprs[0], &exprs[1])];
1626 let mut match_expr_list: Vec<(&T, &T)> = Vec::new();
1628 let mut map: FxHashMap<_, Vec<&_>> =
1629 FxHashMap::with_capacity_and_hasher(exprs.len(), BuildHasherDefault::default());
1632 match map.entry(hash(expr)) {
1633 Entry::Occupied(mut o) => {
1636 match_expr_list.push((o, expr));
1639 o.get_mut().push(expr);
1641 Entry::Vacant(v) => {
1642 v.insert(vec![expr]);
1650 /// Peels off all references on the pattern. Returns the underlying pattern and the number of
1651 /// references removed.
1652 pub fn peel_hir_pat_refs(pat: &'a Pat<'a>) -> (&'a Pat<'a>, usize) {
1653 fn peel(pat: &'a Pat<'a>, count: usize) -> (&'a Pat<'a>, usize) {
1654 if let PatKind::Ref(pat, _) = pat.kind {
1655 peel(pat, count + 1)
1663 /// Peels off up to the given number of references on the expression. Returns the underlying
1664 /// expression and the number of references removed.
1665 pub fn peel_n_hir_expr_refs(expr: &'a Expr<'a>, count: usize) -> (&'a Expr<'a>, usize) {
1666 fn f(expr: &'a Expr<'a>, count: usize, target: usize) -> (&'a Expr<'a>, usize) {
1668 ExprKind::AddrOf(_, _, expr) if count != target => f(expr, count + 1, target),
1675 /// Peels off all references on the type. Returns the underlying type and the number of references
1677 pub fn peel_mid_ty_refs(ty: Ty<'_>) -> (Ty<'_>, usize) {
1678 fn peel(ty: Ty<'_>, count: usize) -> (Ty<'_>, usize) {
1679 if let ty::Ref(_, ty, _) = ty.kind() {
1689 macro_rules! unwrap_cargo_metadata {
1690 ($cx: ident, $lint: ident, $deps: expr) => {{
1691 let mut command = cargo_metadata::MetadataCommand::new();
1696 match command.exec() {
1697 Ok(metadata) => metadata,
1699 span_lint($cx, $lint, DUMMY_SP, &format!("could not read cargo metadata: {}", err));
1706 pub fn is_hir_ty_cfg_dependant(cx: &LateContext<'_>, ty: &hir::Ty<'_>) -> bool {
1708 if let TyKind::Path(QPath::Resolved(_, path)) = ty.kind;
1709 if let Res::Def(_, def_id) = path.res;
1711 cx.tcx.has_attr(def_id, sym::cfg) || cx.tcx.has_attr(def_id, sym::cfg_attr)
1718 /// Check if the resolution of a given path is an `Ok` variant of `Result`.
1719 pub fn is_ok_ctor(cx: &LateContext<'_>, res: Res) -> bool {
1720 if let Some(ok_id) = cx.tcx.lang_items().result_ok_variant() {
1721 if let Res::Def(DefKind::Ctor(CtorOf::Variant, CtorKind::Fn), id) = res {
1722 if let Some(variant_id) = cx.tcx.parent(id) {
1723 return variant_id == ok_id;
1730 /// Check if the resolution of a given path is a `Some` variant of `Option`.
1731 pub fn is_some_ctor(cx: &LateContext<'_>, res: Res) -> bool {
1732 if let Some(some_id) = cx.tcx.lang_items().option_some_variant() {
1733 if let Res::Def(DefKind::Ctor(CtorOf::Variant, CtorKind::Fn), id) = res {
1734 if let Some(variant_id) = cx.tcx.parent(id) {
1735 return variant_id == some_id;
1744 use super::{reindent_multiline, without_block_comments};
1747 fn test_reindent_multiline_single_line() {
1748 assert_eq!("", reindent_multiline("".into(), false, None));
1749 assert_eq!("...", reindent_multiline("...".into(), false, None));
1750 assert_eq!("...", reindent_multiline(" ...".into(), false, None));
1751 assert_eq!("...", reindent_multiline("\t...".into(), false, None));
1752 assert_eq!("...", reindent_multiline("\t\t...".into(), false, None));
1757 fn test_reindent_multiline_block() {
1763 }", reindent_multiline(" if x {
1767 }".into(), false, None));
1773 }", reindent_multiline(" if x {
1777 }".into(), false, None));
1782 fn test_reindent_multiline_empty_line() {
1789 }", reindent_multiline(" if x {
1794 }".into(), false, None));
1799 fn test_reindent_multiline_lines_deeper() {
1805 }", reindent_multiline("\
1810 }".into(), true, Some(8)));
1814 fn test_without_block_comments_lines_without_block_comments() {
1815 let result = without_block_comments(vec!["/*", "", "*/"]);
1816 println!("result: {:?}", result);
1817 assert!(result.is_empty());
1819 let result = without_block_comments(vec!["", "/*", "", "*/", "#[crate_type = \"lib\"]", "/*", "", "*/", ""]);
1820 assert_eq!(result, vec!["", "#[crate_type = \"lib\"]", ""]);
1822 let result = without_block_comments(vec!["/* rust", "", "*/"]);
1823 assert!(result.is_empty());
1825 let result = without_block_comments(vec!["/* one-line comment */"]);
1826 assert!(result.is_empty());
1828 let result = without_block_comments(vec!["/* nested", "/* multi-line", "comment", "*/", "test", "*/"]);
1829 assert!(result.is_empty());
1831 let result = without_block_comments(vec!["/* nested /* inline /* comment */ test */ */"]);
1832 assert!(result.is_empty());
1834 let result = without_block_comments(vec!["foo", "bar", "baz"]);
1835 assert_eq!(result, vec!["foo", "bar", "baz"]);