1 //! A group of attributes that can be attached to Rust code in order
2 //! to generate a clippy lint detecting said code automatically.
4 #![allow(print_stdout, use_debug)]
8 use rustc::hir::{Expr, Expr_, QPath};
9 use rustc::hir::intravisit::{NestedVisitorMap, Visitor};
10 use syntax::ast::{self, Attribute, LitKind, NodeId, DUMMY_NODE_ID};
11 use syntax::codemap::Span;
12 use std::collections::HashMap;
14 /// **What it does:** Generates clippy code that detects the offending pattern
19 /// // detect the following pattern
22 /// // but ignore everything from here on
23 /// #![clippy(author = "ignore")]
32 /// if let Expr_::ExprIf(ref cond, ref then, None) = item.node,
33 /// if let Expr_::ExprBinary(BinOp::Eq, ref left, ref right) = cond.node,
34 /// if let Expr_::ExprPath(ref path) = left.node,
35 /// if let Expr_::ExprLit(ref lit) = right.node,
36 /// if let LitKind::Int(42, _) = lit.node,
38 /// // report your lint here
45 "helper for writing lints"
50 impl LintPass for Pass {
51 fn get_lints(&self) -> LintArray {
52 lint_array!(LINT_AUTHOR)
57 println!("if_chain! {{");
62 println!(" // report your lint here");
67 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
68 fn check_item(&mut self, _cx: &LateContext<'a, 'tcx>, item: &'tcx hir::Item) {
69 if !has_attr(&item.attrs) {
73 PrintVisitor::new("item").visit_item(item);
77 fn check_impl_item(&mut self, _cx: &LateContext<'a, 'tcx>, item: &'tcx hir::ImplItem) {
78 if !has_attr(&item.attrs) {
82 PrintVisitor::new("item").visit_impl_item(item);
86 fn check_trait_item(&mut self, _cx: &LateContext<'a, 'tcx>, item: &'tcx hir::TraitItem) {
87 if !has_attr(&item.attrs) {
91 PrintVisitor::new("item").visit_trait_item(item);
95 fn check_variant(&mut self, _cx: &LateContext<'a, 'tcx>, var: &'tcx hir::Variant, generics: &hir::Generics) {
96 if !has_attr(&var.node.attrs) {
100 PrintVisitor::new("var").visit_variant(var, generics, DUMMY_NODE_ID);
104 fn check_struct_field(&mut self, _cx: &LateContext<'a, 'tcx>, field: &'tcx hir::StructField) {
105 if !has_attr(&field.attrs) {
109 PrintVisitor::new("field").visit_struct_field(field);
113 fn check_expr(&mut self, _cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) {
114 if !has_attr(&expr.attrs) {
118 PrintVisitor::new("expr").visit_expr(expr);
122 fn check_arm(&mut self, _cx: &LateContext<'a, 'tcx>, arm: &'tcx hir::Arm) {
123 if !has_attr(&arm.attrs) {
127 PrintVisitor::new("arm").visit_arm(arm);
131 fn check_stmt(&mut self, _cx: &LateContext<'a, 'tcx>, stmt: &'tcx hir::Stmt) {
132 if !has_attr(stmt.node.attrs()) {
136 PrintVisitor::new("stmt").visit_stmt(stmt);
140 fn check_foreign_item(&mut self, _cx: &LateContext<'a, 'tcx>, item: &'tcx hir::ForeignItem) {
141 if !has_attr(&item.attrs) {
145 PrintVisitor::new("item").visit_foreign_item(item);
151 fn new(s: &'static str) -> Self {
154 current: s.to_owned(),
158 fn next(&mut self, s: &'static str) -> String {
159 use std::collections::hash_map::Entry::*;
160 match self.ids.entry(s) {
161 // already there: start numbering from `1`
162 Occupied(mut occ) => {
163 let val = occ.get_mut();
165 format!("{}{}", s, *val)
167 // not there: insert and return name as given
176 struct PrintVisitor {
177 /// Fields are the current index that needs to be appended to pattern
179 ids: HashMap<&'static str, usize>,
180 /// the name that needs to be destructured
184 impl<'tcx> Visitor<'tcx> for PrintVisitor {
185 fn visit_expr(&mut self, expr: &Expr) {
186 print!(" if let Expr_::Expr");
187 let current = format!("{}.node", self.current);
189 Expr_::ExprBox(ref inner) => {
190 let inner_pat = self.next("inner");
191 println!("Box(ref {}) = {};", inner_pat, current);
192 self.current = inner_pat;
193 self.visit_expr(inner);
195 Expr_::ExprArray(ref elements) => {
196 let elements_pat = self.next("elements");
197 println!("Array(ref {}) = {};", elements_pat, current);
198 println!(" if {}.len() == {};", elements_pat, elements.len());
199 for (i, element) in elements.iter().enumerate() {
200 self.current = format!("{}[{}]", elements_pat, i);
201 self.visit_expr(element);
204 Expr_::ExprCall(ref _func, ref _args) => {
205 println!("Call(ref func, ref args) = {};", current);
206 println!(" // unimplemented: `ExprCall` is not further destructured at the moment");
208 Expr_::ExprMethodCall(ref _method_name, ref _generics, ref _args) => {
209 println!("MethodCall(ref method_name, ref generics, ref args) = {};", current);
210 println!(" // unimplemented: `ExprMethodCall` is not further destructured at the moment");
212 Expr_::ExprTup(ref elements) => {
213 let elements_pat = self.next("elements");
214 println!("Tup(ref {}) = {};", elements_pat, current);
215 println!(" if {}.len() == {};", elements_pat, elements.len());
216 for (i, element) in elements.iter().enumerate() {
217 self.current = format!("{}[{}]", elements_pat, i);
218 self.visit_expr(element);
221 Expr_::ExprBinary(ref op, ref left, ref right) => {
222 let op_pat = self.next("op");
223 let left_pat = self.next("left");
224 let right_pat = self.next("right");
225 println!("Binary(ref {}, ref {}, ref {}) = {};", op_pat, left_pat, right_pat, current);
226 println!(" if BinOp_::{:?} == {}.node;", op.node, op_pat);
227 self.current = left_pat;
228 self.visit_expr(left);
229 self.current = right_pat;
230 self.visit_expr(right);
232 Expr_::ExprUnary(ref op, ref inner) => {
233 let inner_pat = self.next("inner");
234 println!("Unary(UnOp::{:?}, ref {}) = {};", op, inner_pat, current);
235 self.current = inner_pat;
236 self.visit_expr(inner);
238 Expr_::ExprLit(ref lit) => {
239 let lit_pat = self.next("lit");
240 println!("Lit(ref {}) = {};", lit_pat, current);
242 LitKind::Bool(val) => println!(" if let LitKind::Bool({:?}) = {}.node;", val, lit_pat),
243 LitKind::Char(c) => println!(" if let LitKind::Char({:?}) = {}.node;", c, lit_pat),
244 LitKind::Byte(b) => println!(" if let LitKind::Byte({}) = {}.node;", b, lit_pat),
245 // FIXME: also check int type
246 LitKind::Int(i, _) => println!(" if let LitKind::Int({}, _) = {}.node;", i, lit_pat),
247 LitKind::Float(..) => println!(" if let LitKind::Float(..) = {}.node;", lit_pat),
248 LitKind::FloatUnsuffixed(_) => {
249 println!(" if let LitKind::FloatUnsuffixed(_) = {}.node;", lit_pat)
251 LitKind::ByteStr(ref vec) => {
252 let vec_pat = self.next("vec");
253 println!(" if let LitKind::ByteStr(ref {}) = {}.node;", vec_pat, lit_pat);
254 println!(" if let [{:?}] = **{};", vec, vec_pat);
256 LitKind::Str(ref text, _) => {
257 let str_pat = self.next("s");
258 println!(" if let LitKind::Str(ref {}) = {}.node;", str_pat, lit_pat);
259 println!(" if {}.as_str() == {:?}", str_pat, &*text.as_str())
263 Expr_::ExprCast(ref expr, ref _ty) => {
264 let cast_pat = self.next("expr");
265 println!("Cast(ref {}, _) = {};", cast_pat, current);
266 self.current = cast_pat;
267 self.visit_expr(expr);
269 Expr_::ExprType(ref expr, ref _ty) => {
270 let cast_pat = self.next("expr");
271 println!("Type(ref {}, _) = {};", cast_pat, current);
272 self.current = cast_pat;
273 self.visit_expr(expr);
275 Expr_::ExprIf(ref cond, ref then, ref opt_else) => {
276 let cond_pat = self.next("cond");
277 let then_pat = self.next("then");
278 if let Some(ref else_) = *opt_else {
279 let else_pat = self.next("else_");
280 println!("If(ref {}, ref {}, Some(ref {})) = {};", cond_pat, then_pat, else_pat, current);
281 self.current = else_pat;
282 self.visit_expr(else_);
284 println!("If(ref {}, ref {}, None) = {};", cond_pat, then_pat, current);
286 self.current = cond_pat;
287 self.visit_expr(cond);
288 self.current = then_pat;
289 self.visit_expr(then);
291 Expr_::ExprWhile(ref _cond, ref _body, ref _opt_label) => {
292 println!("While(ref cond, ref body, ref opt_label) = {};", current);
293 println!(" // unimplemented: `ExprWhile` is not further destructured at the moment");
295 Expr_::ExprLoop(ref _body, ref _opt_label, ref _desuraging) => {
296 println!("Loop(ref body, ref opt_label, ref desugaring) = {};", current);
297 println!(" // unimplemented: `ExprLoop` is not further destructured at the moment");
299 Expr_::ExprMatch(ref _expr, ref _arms, ref _desugaring) => {
300 println!("Match(ref expr, ref arms, ref desugaring) = {};", current);
301 println!(" // unimplemented: `ExprMatch` is not further destructured at the moment");
303 Expr_::ExprClosure(ref _capture_clause, ref _func, _, _, _) => {
304 println!("Closure(ref capture_clause, ref func, _, _, _) = {};", current);
305 println!(" // unimplemented: `ExprClosure` is not further destructured at the moment");
307 Expr_::ExprYield(ref sub) => {
308 let sub_pat = self.next("sub");
309 println!("Yield(ref sub) = {};", current);
310 self.current = sub_pat;
311 self.visit_expr(sub);
313 Expr_::ExprBlock(ref block) => {
314 let block_pat = self.next("block");
315 println!("Block(ref {}) = {};", block_pat, current);
316 self.current = block_pat;
317 self.visit_block(block);
319 Expr_::ExprAssign(ref target, ref value) => {
320 let target_pat = self.next("target");
321 let value_pat = self.next("value");
322 println!("Assign(ref {}, ref {}) = {};", target_pat, value_pat, current);
323 self.current = target_pat;
324 self.visit_expr(target);
325 self.current = value_pat;
326 self.visit_expr(value);
328 Expr_::ExprAssignOp(ref op, ref target, ref value) => {
329 let op_pat = self.next("op");
330 let target_pat = self.next("target");
331 let value_pat = self.next("value");
332 println!("AssignOp(ref {}, ref {}, ref {}) = {};", op_pat, target_pat, value_pat, current);
333 println!(" if BinOp_::{:?} == {}.node;", op.node, op_pat);
334 self.current = target_pat;
335 self.visit_expr(target);
336 self.current = value_pat;
337 self.visit_expr(value);
339 Expr_::ExprField(ref object, ref field_name) => {
340 let obj_pat = self.next("object");
341 let field_name_pat = self.next("field_name");
342 println!("Field(ref {}, ref {}) = {};", obj_pat, field_name_pat, current);
343 println!(" if {}.node.as_str() == {:?}", field_name_pat, field_name.node.as_str());
344 self.current = obj_pat;
345 self.visit_expr(object);
347 Expr_::ExprTupField(ref object, ref field_id) => {
348 let obj_pat = self.next("object");
349 let field_id_pat = self.next("field_id");
350 println!("TupField(ref {}, ref {}) = {};", obj_pat, field_id_pat, current);
351 println!(" if {}.node == {}", field_id_pat, field_id.node);
352 self.current = obj_pat;
353 self.visit_expr(object);
355 Expr_::ExprIndex(ref object, ref index) => {
356 let object_pat = self.next("object");
357 let index_pat = self.next("index");
358 println!("Index(ref {}, ref {}) = {};", object_pat, index_pat, current);
359 self.current = object_pat;
360 self.visit_expr(object);
361 self.current = index_pat;
362 self.visit_expr(index);
364 Expr_::ExprPath(ref path) => {
365 let path_pat = self.next("path");
366 println!("Path(ref {}) = {};", path_pat, current);
367 self.current = path_pat;
368 self.visit_qpath(path, expr.id, expr.span);
370 Expr_::ExprAddrOf(mutability, ref inner) => {
371 let inner_pat = self.next("inner");
372 println!("AddrOf({:?}, ref {}) = {};", mutability, inner_pat, current);
373 self.current = inner_pat;
374 self.visit_expr(inner);
376 Expr_::ExprBreak(ref _destination, ref opt_value) => {
377 let destination_pat = self.next("destination");
378 if let Some(ref value) = *opt_value {
379 let value_pat = self.next("value");
380 println!("Break(ref {}, Some(ref {})) = {};", destination_pat, value_pat, current);
381 self.current = value_pat;
382 self.visit_expr(value);
384 println!("Break(ref {}, None) = {};", destination_pat, current);
386 // FIXME: implement label printing
388 Expr_::ExprAgain(ref _destination) => {
389 let destination_pat = self.next("destination");
390 println!("Again(ref {}) = {};", destination_pat, current);
391 // FIXME: implement label printing
393 Expr_::ExprRet(ref opt_value) => if let Some(ref value) = *opt_value {
394 let value_pat = self.next("value");
395 println!("Ret(Some(ref {})) = {};", value_pat, current);
396 self.current = value_pat;
397 self.visit_expr(value);
399 println!("Ret(None) = {};", current);
401 Expr_::ExprInlineAsm(_, ref _input, ref _output) => {
402 println!("InlineAsm(_, ref input, ref output) = {};", current);
403 println!(" // unimplemented: `ExprInlineAsm` is not further destructured at the moment");
405 Expr_::ExprStruct(ref path, ref fields, ref opt_base) => {
406 let path_pat = self.next("path");
407 let fields_pat = self.next("fields");
408 if let Some(ref base) = *opt_base {
409 let base_pat = self.next("base");
411 "Struct(ref {}, ref {}, Some(ref {})) = {};",
417 self.current = base_pat;
418 self.visit_expr(base);
420 println!("Struct(ref {}, ref {}, None) = {};", path_pat, fields_pat, current);
422 self.current = path_pat;
423 self.visit_qpath(path, expr.id, expr.span);
424 println!(" if {}.len() == {};", fields_pat, fields.len());
425 println!(" // unimplemented: field checks");
427 // FIXME: compute length (needs type info)
428 Expr_::ExprRepeat(ref value, _) => {
429 let value_pat = self.next("value");
430 println!("Repeat(ref {}, _) = {};", value_pat, current);
431 println!("// unimplemented: repeat count check");
432 self.current = value_pat;
433 self.visit_expr(value);
438 fn visit_qpath(&mut self, path: &QPath, _: NodeId, _: Span) {
439 print!(" if match_qpath({}, &[", self.current);
440 print_path(path, &mut true);
443 fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
444 NestedVisitorMap::None
448 fn has_attr(attrs: &[Attribute]) -> bool {
449 attrs.iter().any(|attr| {
450 attr.check_name("clippy") && attr.meta_item_list().map_or(false, |list| {
451 list.len() == 1 && match list[0].node {
452 ast::NestedMetaItemKind::MetaItem(ref it) => it.name == "author",
453 ast::NestedMetaItemKind::Literal(_) => false,
459 fn print_path(path: &QPath, first: &mut bool) {
461 QPath::Resolved(_, ref path) => for segment in &path.segments {
467 print!("{:?}", segment.name.as_str());
469 QPath::TypeRelative(ref ty, ref segment) => match ty.node {
470 hir::Ty_::TyPath(ref inner_path) => {
471 print_path(inner_path, first);
477 print!("{:?}", segment.name.as_str());
479 ref other => print!("/* unimplemented: {:?}*/", other),