1 use clippy_utils::source::position_before_rarrow;
2 use if_chain::if_chain;
4 use rustc_ast::visit::FnKind;
5 use rustc_errors::Applicability;
6 use rustc_lint::{EarlyContext, EarlyLintPass, LintContext};
7 use rustc_session::{declare_lint_pass, declare_tool_lint};
8 use rustc_span::source_map::Span;
9 use rustc_span::BytePos;
11 use clippy_utils::diagnostics::span_lint_and_sugg;
13 declare_clippy_lint! {
14 /// **What it does:** Checks for unit (`()`) expressions that can be removed.
16 /// **Why is this bad?** Such expressions add no value, but can make the code
17 /// less readable. Depending on formatting they can make a `break` or `return`
18 /// statement look like a function call.
20 /// **Known problems:** None.
24 /// fn return_unit() -> () {
30 "needless unit expression"
33 declare_lint_pass!(UnusedUnit => [UNUSED_UNIT]);
35 impl EarlyLintPass for UnusedUnit {
36 fn check_fn(&mut self, cx: &EarlyContext<'_>, kind: FnKind<'_>, span: Span, _: ast::NodeId) {
38 if let ast::FnRetTy::Ty(ref ty) = kind.decl().output;
39 if let ast::TyKind::Tup(ref vals) = ty.kind;
40 if vals.is_empty() && !ty.span.from_expansion() && get_def(span) == get_def(ty.span);
42 lint_unneeded_unit_return(cx, ty, span);
47 fn check_block(&mut self, cx: &EarlyContext<'_>, block: &ast::Block) {
49 if let Some(ref stmt) = block.stmts.last();
50 if let ast::StmtKind::Expr(ref expr) = stmt.kind;
51 if is_unit_expr(expr) && !stmt.span.from_expansion();
58 "unneeded unit expression",
59 "remove the final `()`",
61 Applicability::MachineApplicable,
67 fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &ast::Expr) {
69 ast::ExprKind::Ret(Some(ref expr)) | ast::ExprKind::Break(_, Some(ref expr)) => {
70 if is_unit_expr(expr) && !expr.span.from_expansion() {
78 Applicability::MachineApplicable,
86 fn check_poly_trait_ref(&mut self, cx: &EarlyContext<'_>, poly: &ast::PolyTraitRef, _: &ast::TraitBoundModifier) {
87 let segments = &poly.trait_ref.path.segments;
90 if segments.len() == 1;
91 if ["Fn", "FnMut", "FnOnce"].contains(&&*segments[0].ident.name.as_str());
92 if let Some(args) = &segments[0].args;
93 if let ast::GenericArgs::Parenthesized(generic_args) = &**args;
94 if let ast::FnRetTy::Ty(ty) = &generic_args.output;
97 lint_unneeded_unit_return(cx, ty, generic_args.span);
105 fn get_def(span: Span) -> Option<Span> {
106 if span.from_expansion() {
107 Some(span.ctxt().outer_expn_data().def_site)
113 // is this expr a `()` unit?
114 fn is_unit_expr(expr: &ast::Expr) -> bool {
115 if let ast::ExprKind::Tup(ref vals) = expr.kind {
122 fn lint_unneeded_unit_return(cx: &EarlyContext<'_>, ty: &ast::Ty, span: Span) {
123 let (ret_span, appl) = if let Ok(fn_source) = cx.sess().source_map().span_to_snippet(span.with_hi(ty.span.hi())) {
124 position_before_rarrow(&fn_source).map_or((ty.span, Applicability::MaybeIncorrect), |rpos| {
126 #[allow(clippy::cast_possible_truncation)]
127 ty.span.with_lo(BytePos(span.lo().0 + rpos as u32)),
128 Applicability::MachineApplicable,
132 (ty.span, Applicability::MaybeIncorrect)
138 "unneeded unit return type",
139 "remove the `-> ()`",