3 use rustc::hir::intravisit::{FnKind, Visitor, walk_ty};
6 use std::cmp::Ordering;
7 use syntax::ast::{IntTy, UintTy, FloatTy};
8 use syntax::codemap::Span;
9 use utils::{comparisons, higher, in_external_macro, in_macro, match_def_path, snippet,
10 span_help_and_lint, span_lint, opt_def_id};
13 /// Handles all the linting of funky types
14 #[allow(missing_copy_implementations)]
17 /// **What it does:** Checks for use of `Box<Vec<_>>` anywhere in the code.
19 /// **Why is this bad?** `Vec` already keeps its contents in a separate area on
20 /// the heap. So if you `Box` it, you just add another level of indirection
21 /// without any benefit whatsoever.
23 /// **Known problems:** None.
28 /// values: Box<Vec<Foo>>,
34 "usage of `Box<Vec<T>>`, vector elements are already on the heap"
37 /// **What it does:** Checks for usage of any `LinkedList`, suggesting to use a
38 /// `Vec` or a `VecDeque` (formerly called `RingBuf`).
40 /// **Why is this bad?** Gankro says:
42 /// > The TL;DR of `LinkedList` is that it's built on a massive amount of pointers and indirection.
43 /// > It wastes memory, it has terrible cache locality, and is all-around slow. `RingBuf`, while
44 /// > "only" amortized for push/pop, should be faster in the general case for almost every possible
45 /// > workload, and isn't even amortized at all if you can predict the capacity you need.
47 /// > `LinkedList`s are only really good if you're doing a lot of merging or splitting of lists.
48 /// > This is because they can just mangle some pointers instead of actually copying the data. Even
49 /// > if you're doing a lot of insertion in the middle of the list, `RingBuf` can still be better
50 /// > because of how expensive it is to seek to the middle of a `LinkedList`.
52 /// **Known problems:** False positives – the instances where using a
53 /// `LinkedList` makes sense are few and far between, but they can still happen.
57 /// let x = LinkedList::new();
62 "usage of LinkedList, usually a vector is faster, or a more specialized data \
63 structure like a VecDeque"
66 impl LintPass for TypePass {
67 fn get_lints(&self) -> LintArray {
68 lint_array!(BOX_VEC, LINKEDLIST)
72 impl LateLintPass for TypePass {
73 fn check_ty(&mut self, cx: &LateContext, ast_ty: &Ty) {
74 if in_macro(cx, ast_ty.span) {
77 if let TyPath(ref qpath) = ast_ty.node {
78 let def = cx.tcx.tables().qpath_def(qpath, ast_ty.id);
79 if let Some(def_id) = opt_def_id(def) {
80 if def_id == cx.tcx.lang_items.owned_box().unwrap() {
82 let QPath::Resolved(_, ref path) = *qpath,
83 let Some(ref last) = path.segments.last(),
84 let PathParameters::AngleBracketedParameters(ref ag) = last.parameters,
85 let Some(ref vec) = ag.types.get(0),
86 let TyPath(ref qpath) = vec.node,
87 let def::Def::Struct(..) = cx.tcx.tables().qpath_def(qpath, vec.id),
88 let Some(did) = opt_def_id(cx.tcx.tables().qpath_def(qpath, vec.id)),
89 match_def_path(cx, did, &paths::VEC),
91 span_help_and_lint(cx,
94 "you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`",
95 "`Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.");
97 } else if match_def_path(cx, def_id, &paths::LINKED_LIST) {
98 span_help_and_lint(cx,
101 "I see you're using a LinkedList! Perhaps you meant some other data structure?",
102 "a VecDeque might work");
109 #[allow(missing_copy_implementations)]
112 /// **What it does:** Checks for binding a unit value.
114 /// **Why is this bad?** A unit value cannot usefully be used anywhere. So
115 /// binding one is kind of pointless.
117 /// **Known problems:** None.
126 "creating a let binding to a value of unit type, which usually can't be used afterwards"
129 fn check_let_unit(cx: &LateContext, decl: &Decl) {
130 if let DeclLocal(ref local) = decl.node {
131 let bindtype = &cx.tcx.tables().pat_ty(&local.pat).sty;
133 ty::TyTuple(slice) if slice.is_empty() => {
134 if in_external_macro(cx, decl.span) || in_macro(cx, local.pat.span) {
137 if higher::is_from_for_desugar(decl) {
143 &format!("this let-binding has unit value. Consider omitting `let {} =`",
144 snippet(cx, local.pat.span, "..")));
151 impl LintPass for LetPass {
152 fn get_lints(&self) -> LintArray {
153 lint_array!(LET_UNIT_VALUE)
157 impl LateLintPass for LetPass {
158 fn check_decl(&mut self, cx: &LateContext, decl: &Decl) {
159 check_let_unit(cx, decl)
163 /// **What it does:** Checks for comparisons to unit.
165 /// **Why is this bad?** Unit is always equal to itself, and thus is just a
166 /// clumsily written constant. Mostly this happens when someone accidentally
167 /// adds semicolons at the end of the operands.
169 /// **Known problems:** None.
173 /// if { foo(); } == { bar(); } { baz(); }
177 /// { foo(); bar(); baz(); }
182 "comparing unit values"
185 #[allow(missing_copy_implementations)]
188 impl LintPass for UnitCmp {
189 fn get_lints(&self) -> LintArray {
190 lint_array!(UNIT_CMP)
194 impl LateLintPass for UnitCmp {
195 fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
196 if in_macro(cx, expr.span) {
199 if let ExprBinary(ref cmp, ref left, _) = expr.node {
201 if op.is_comparison() {
202 let sty = &cx.tcx.tables().expr_ty(left).sty;
204 ty::TyTuple(slice) if slice.is_empty() => {
205 let result = match op {
206 BiEq | BiLe | BiGe => "true",
212 &format!("{}-comparison of unit values detected. This will always be {}",
225 /// **What it does:** Checks for casts from any numerical to a float type where
226 /// the receiving type cannot store all values from the original type without
227 /// rounding errors. This possible rounding is to be expected, so this lint is
228 /// `Allow` by default.
230 /// Basically, this warns on casting any integer with 32 or more bits to `f32`
231 /// or any 64-bit integer to `f64`.
233 /// **Why is this bad?** It's not bad at all. But in some applications it can be
234 /// helpful to know where precision loss can take place. This lint can help find
235 /// those places in the code.
237 /// **Known problems:** None.
241 /// let x = u64::MAX; x as f64
244 pub CAST_PRECISION_LOSS,
246 "casts that cause loss of precision, e.g `x as f32` where `x: u64`"
249 /// **What it does:** Checks for casts from a signed to an unsigned numerical
250 /// type. In this case, negative values wrap around to large positive values,
251 /// which can be quite surprising in practice. However, as the cast works as
252 /// defined, this lint is `Allow` by default.
254 /// **Why is this bad?** Possibly surprising results. You can activate this lint
255 /// as a one-time check to see where numerical wrapping can arise.
257 /// **Known problems:** None.
262 /// y as u64 // will return 18446744073709551615
267 "casts from signed types to unsigned types, e.g `x as u32` where `x: i32`"
270 /// **What it does:** Checks for on casts between numerical types that may
271 /// truncate large values. This is expected behavior, so the cast is `Allow` by
274 /// **Why is this bad?** In some problem domains, it is good practice to avoid
275 /// truncation. This lint can be activated to help assess where additional
276 /// checks could be beneficial.
278 /// **Known problems:** None.
282 /// fn as_u8(x: u64) -> u8 { x as u8 }
285 pub CAST_POSSIBLE_TRUNCATION,
287 "casts that may cause truncation of the value, e.g `x as u8` where `x: u32`, \
288 or `x as i32` where `x: f32`"
291 /// **What it does:** Checks for casts from an unsigned type to a signed type of
292 /// the same size. Performing such a cast is a 'no-op' for the compiler,
293 /// i.e. nothing is changed at the bit level, and the binary representation of
294 /// the value is reinterpreted. This can cause wrapping if the value is too big
295 /// for the target signed type. However, the cast works as defined, so this lint
296 /// is `Allow` by default.
298 /// **Why is this bad?** While such a cast is not bad in itself, the results can
299 /// be surprising when this is not the intended behavior, as demonstrated by the
302 /// **Known problems:** None.
306 /// u32::MAX as i32 // will yield a value of `-1`
309 pub CAST_POSSIBLE_WRAP,
311 "casts that may cause wrapping around the value, e.g `x as i32` where `x: u32` \
315 /// Returns the size in bits of an integral type.
316 /// Will return 0 if the type is not an int or uint variant
317 fn int_ty_to_nbits(typ: &ty::TyS) -> usize {
318 let n = match typ.sty {
319 ty::TyInt(i) => 4 << (i as usize),
320 ty::TyUint(u) => 4 << (u as usize),
323 // n == 4 is the usize/isize case
325 ::std::mem::size_of::<usize>() * 8
331 fn is_isize_or_usize(typ: &ty::TyS) -> bool {
333 ty::TyInt(IntTy::Is) |
334 ty::TyUint(UintTy::Us) => true,
339 fn span_precision_loss_lint(cx: &LateContext, expr: &Expr, cast_from: &ty::TyS, cast_to_f64: bool) {
340 let mantissa_nbits = if cast_to_f64 {
345 let arch_dependent = is_isize_or_usize(cast_from) && cast_to_f64;
346 let arch_dependent_str = "on targets with 64-bit wide pointers ";
347 let from_nbits_str = if arch_dependent {
349 } else if is_isize_or_usize(cast_from) {
350 "32 or 64".to_owned()
352 int_ty_to_nbits(cast_from).to_string()
357 &format!("casting {0} to {1} causes a loss of precision {2}({0} is {3} bits wide, but {1}'s mantissa \
358 is only {4} bits wide)",
380 fn check_truncation_and_wrapping(cx: &LateContext, expr: &Expr, cast_from: &ty::TyS, cast_to: &ty::TyS) {
381 let arch_64_suffix = " on targets with 64-bit wide pointers";
382 let arch_32_suffix = " on targets with 32-bit wide pointers";
383 let cast_unsigned_to_signed = !cast_from.is_signed() && cast_to.is_signed();
384 let (from_nbits, to_nbits) = (int_ty_to_nbits(cast_from), int_ty_to_nbits(cast_to));
385 let (span_truncation, suffix_truncation, span_wrap, suffix_wrap) = match (is_isize_or_usize(cast_from),
386 is_isize_or_usize(cast_to)) {
387 (true, true) | (false, false) => {
388 (to_nbits < from_nbits,
390 to_nbits == from_nbits && cast_unsigned_to_signed,
400 to_nbits <= 32 && cast_unsigned_to_signed,
406 cast_unsigned_to_signed,
407 if from_nbits == 64 {
416 CAST_POSSIBLE_TRUNCATION,
418 &format!("casting {} to {} may truncate the value{}",
421 match suffix_truncation {
422 ArchSuffix::_32 => arch_32_suffix,
423 ArchSuffix::_64 => arch_64_suffix,
424 ArchSuffix::None => "",
431 &format!("casting {} to {} may wrap around the value{}",
435 ArchSuffix::_32 => arch_32_suffix,
436 ArchSuffix::_64 => arch_64_suffix,
437 ArchSuffix::None => "",
442 impl LintPass for CastPass {
443 fn get_lints(&self) -> LintArray {
444 lint_array!(CAST_PRECISION_LOSS,
446 CAST_POSSIBLE_TRUNCATION,
451 impl LateLintPass for CastPass {
452 fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
453 if let ExprCast(ref ex, _) = expr.node {
454 let (cast_from, cast_to) = (cx.tcx.tables().expr_ty(ex), cx.tcx.tables().expr_ty(expr));
455 if cast_from.is_numeric() && cast_to.is_numeric() && !in_external_macro(cx, expr.span) {
456 match (cast_from.is_integral(), cast_to.is_integral()) {
458 let from_nbits = int_ty_to_nbits(cast_from);
459 let to_nbits = if let ty::TyFloat(FloatTy::F32) = cast_to.sty {
464 if is_isize_or_usize(cast_from) || from_nbits >= to_nbits {
465 span_precision_loss_lint(cx, expr, cast_from, to_nbits == 64);
470 CAST_POSSIBLE_TRUNCATION,
472 &format!("casting {} to {} may truncate the value", cast_from, cast_to));
473 if !cast_to.is_signed() {
477 &format!("casting {} to {} may lose the sign of the value", cast_from, cast_to));
481 if cast_from.is_signed() && !cast_to.is_signed() {
485 &format!("casting {} to {} may lose the sign of the value", cast_from, cast_to));
487 check_truncation_and_wrapping(cx, expr, cast_from, cast_to);
490 if let (&ty::TyFloat(FloatTy::F64), &ty::TyFloat(FloatTy::F32)) = (&cast_from.sty,
493 CAST_POSSIBLE_TRUNCATION,
495 "casting f64 to f32 may truncate the value");
504 /// **What it does:** Checks for types used in structs, parameters and `let`
505 /// declarations above a certain complexity threshold.
507 /// **Why is this bad?** Too complex types make the code less readable. Consider
508 /// using a `type` definition to simplify them.
510 /// **Known problems:** None.
514 /// struct Foo { inner: Rc<Vec<Vec<Box<(u32, u32, u32, u32)>>>> }
519 "usage of very complex types that might be better factored into `type` definitions"
522 #[allow(missing_copy_implementations)]
523 pub struct TypeComplexityPass {
527 impl TypeComplexityPass {
528 pub fn new(threshold: u64) -> Self {
529 TypeComplexityPass { threshold: threshold }
533 impl LintPass for TypeComplexityPass {
534 fn get_lints(&self) -> LintArray {
535 lint_array!(TYPE_COMPLEXITY)
539 impl LateLintPass for TypeComplexityPass {
540 fn check_fn(&mut self, cx: &LateContext, _: FnKind, decl: &FnDecl, _: &Expr, _: Span, _: NodeId) {
541 self.check_fndecl(cx, decl);
544 fn check_struct_field(&mut self, cx: &LateContext, field: &StructField) {
545 // enum variants are also struct fields now
546 self.check_type(cx, &field.ty);
549 fn check_item(&mut self, cx: &LateContext, item: &Item) {
551 ItemStatic(ref ty, _, _) |
552 ItemConst(ref ty, _) => self.check_type(cx, ty),
553 // functions, enums, structs, impls and traits are covered
558 fn check_trait_item(&mut self, cx: &LateContext, item: &TraitItem) {
560 ConstTraitItem(ref ty, _) |
561 TypeTraitItem(_, Some(ref ty)) => self.check_type(cx, ty),
562 MethodTraitItem(MethodSig { ref decl, .. }, None) => self.check_fndecl(cx, decl),
563 // methods with default impl are covered by check_fn
568 fn check_impl_item(&mut self, cx: &LateContext, item: &ImplItem) {
570 ImplItemKind::Const(ref ty, _) |
571 ImplItemKind::Type(ref ty) => self.check_type(cx, ty),
572 // methods are covered by check_fn
577 fn check_local(&mut self, cx: &LateContext, local: &Local) {
578 if let Some(ref ty) = local.ty {
579 self.check_type(cx, ty);
584 impl TypeComplexityPass {
585 fn check_fndecl(&self, cx: &LateContext, decl: &FnDecl) {
586 for arg in &decl.inputs {
587 self.check_type(cx, &arg.ty);
589 if let Return(ref ty) = decl.output {
590 self.check_type(cx, ty);
594 fn check_type(&self, cx: &LateContext, ty: &Ty) {
595 if in_macro(cx, ty.span) {
599 let mut visitor = TypeComplexityVisitor {
603 visitor.visit_ty(ty);
607 if score > self.threshold {
611 "very complex type used. Consider factoring parts into `type` definitions");
616 /// Walks a type and assigns a complexity score to it.
617 struct TypeComplexityVisitor {
618 /// total complexity score of the type
620 /// current nesting level
624 impl<'v> Visitor<'v> for TypeComplexityVisitor {
625 fn visit_ty(&mut self, ty: &'v Ty) {
626 let (add_score, sub_nest) = match ty.node {
627 // _, &x and *x have only small overhead; don't mess with nesting level
628 TyInfer | TyPtr(..) | TyRptr(..) => (1, 0),
630 // the "normal" components of a type: named types, arrays/tuples
634 TyArray(..) => (10 * self.nest, 1),
636 // "Sum" of trait bounds
637 TyObjectSum(..) => (20 * self.nest, 0),
639 // function types and "for<...>" bring a lot of overhead
641 TyPolyTraitRef(..) => (50 * self.nest, 1),
645 self.score += add_score;
646 self.nest += sub_nest;
648 self.nest -= sub_nest;
652 /// **What it does:** Checks for expressions where a character literal is cast
653 /// to `u8` and suggests using a byte literal instead.
655 /// **Why is this bad?** In general, casting values to smaller types is
656 /// error-prone and should be avoided where possible. In the particular case of
657 /// converting a character literal to u8, it is easy to avoid by just using a
658 /// byte literal instead. As an added bonus, `b'a'` is even slightly shorter
659 /// than `'a' as u8`.
661 /// **Known problems:** None.
670 "casting a character literal to u8"
673 pub struct CharLitAsU8;
675 impl LintPass for CharLitAsU8 {
676 fn get_lints(&self) -> LintArray {
677 lint_array!(CHAR_LIT_AS_U8)
681 impl LateLintPass for CharLitAsU8 {
682 fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
683 use syntax::ast::{LitKind, UintTy};
685 if let ExprCast(ref e, _) = expr.node {
686 if let ExprLit(ref l) = e.node {
687 if let LitKind::Char(_) = l.node {
688 if ty::TyUint(UintTy::U8) == cx.tcx.tables().expr_ty(expr).sty && !in_macro(cx, expr.span) {
689 let msg = "casting character literal to u8. `char`s \
690 are 4 bytes wide in rust, so casting to u8 \
692 let help = format!("Consider using a byte literal \
694 snippet(cx, e.span, "'x'"));
695 span_help_and_lint(cx, CHAR_LIT_AS_U8, expr.span, msg, &help);
703 /// **What it does:** Checks for comparisons where one side of the relation is
704 /// either the minimum or maximum value for its type and warns if it involves a
705 /// case that is always true or always false. Only integer and boolean types are
708 /// **Why is this bad?** An expression like `min <= x` may misleadingly imply
709 /// that is is possible for `x` to be less than the minimum. Expressions like
710 /// `max < x` are probably mistakes.
712 /// **Known problems:** None.
717 /// 100 > std::i32::MAX
720 pub ABSURD_EXTREME_COMPARISONS,
722 "a comparison with a maximum or minimum value that is always true or false"
725 pub struct AbsurdExtremeComparisons;
727 impl LintPass for AbsurdExtremeComparisons {
728 fn get_lints(&self) -> LintArray {
729 lint_array!(ABSURD_EXTREME_COMPARISONS)
738 struct ExtremeExpr<'a> {
743 enum AbsurdComparisonResult {
746 InequalityImpossible,
751 fn detect_absurd_comparison<'a>(cx: &LateContext, op: BinOp_, lhs: &'a Expr, rhs: &'a Expr)
752 -> Option<(ExtremeExpr<'a>, AbsurdComparisonResult)> {
753 use types::ExtremeType::*;
754 use types::AbsurdComparisonResult::*;
755 use utils::comparisons::*;
756 type Extr<'a> = ExtremeExpr<'a>;
758 let normalized = normalize_comparison(op, lhs, rhs);
759 let (rel, normalized_lhs, normalized_rhs) = if let Some(val) = normalized {
765 let lx = detect_extreme_expr(cx, normalized_lhs);
766 let rx = detect_extreme_expr(cx, normalized_rhs);
771 (Some(l @ Extr { which: Maximum, .. }), _) => (l, AlwaysFalse), // max < x
772 (_, Some(r @ Extr { which: Minimum, .. })) => (r, AlwaysFalse), // x < min
778 (Some(l @ Extr { which: Minimum, .. }), _) => (l, AlwaysTrue), // min <= x
779 (Some(l @ Extr { which: Maximum, .. }), _) => (l, InequalityImpossible), //max <= x
780 (_, Some(r @ Extr { which: Minimum, .. })) => (r, InequalityImpossible), // x <= min
781 (_, Some(r @ Extr { which: Maximum, .. })) => (r, AlwaysTrue), // x <= max
785 Rel::Ne | Rel::Eq => return None,
789 fn detect_extreme_expr<'a>(cx: &LateContext, expr: &'a Expr) -> Option<ExtremeExpr<'a>> {
790 use rustc::middle::const_val::ConstVal::*;
791 use rustc_const_math::*;
792 use rustc_const_eval::EvalHint::ExprTypeChecked;
793 use rustc_const_eval::*;
794 use types::ExtremeType::*;
796 let ty = &cx.tcx.tables().expr_ty(expr).sty;
799 ty::TyBool | ty::TyInt(_) | ty::TyUint(_) => (),
803 let cv = match eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None) {
805 Err(_) => return None,
808 let which = match (ty, cv) {
809 (&ty::TyBool, Bool(false)) |
810 (&ty::TyInt(IntTy::Is), Integral(Isize(Is32(::std::i32::MIN)))) |
811 (&ty::TyInt(IntTy::Is), Integral(Isize(Is64(::std::i64::MIN)))) |
812 (&ty::TyInt(IntTy::I8), Integral(I8(::std::i8::MIN))) |
813 (&ty::TyInt(IntTy::I16), Integral(I16(::std::i16::MIN))) |
814 (&ty::TyInt(IntTy::I32), Integral(I32(::std::i32::MIN))) |
815 (&ty::TyInt(IntTy::I64), Integral(I64(::std::i64::MIN))) |
816 (&ty::TyUint(UintTy::Us), Integral(Usize(Us32(::std::u32::MIN)))) |
817 (&ty::TyUint(UintTy::Us), Integral(Usize(Us64(::std::u64::MIN)))) |
818 (&ty::TyUint(UintTy::U8), Integral(U8(::std::u8::MIN))) |
819 (&ty::TyUint(UintTy::U16), Integral(U16(::std::u16::MIN))) |
820 (&ty::TyUint(UintTy::U32), Integral(U32(::std::u32::MIN))) |
821 (&ty::TyUint(UintTy::U64), Integral(U64(::std::u64::MIN))) => Minimum,
823 (&ty::TyBool, Bool(true)) |
824 (&ty::TyInt(IntTy::Is), Integral(Isize(Is32(::std::i32::MAX)))) |
825 (&ty::TyInt(IntTy::Is), Integral(Isize(Is64(::std::i64::MAX)))) |
826 (&ty::TyInt(IntTy::I8), Integral(I8(::std::i8::MAX))) |
827 (&ty::TyInt(IntTy::I16), Integral(I16(::std::i16::MAX))) |
828 (&ty::TyInt(IntTy::I32), Integral(I32(::std::i32::MAX))) |
829 (&ty::TyInt(IntTy::I64), Integral(I64(::std::i64::MAX))) |
830 (&ty::TyUint(UintTy::Us), Integral(Usize(Us32(::std::u32::MAX)))) |
831 (&ty::TyUint(UintTy::Us), Integral(Usize(Us64(::std::u64::MAX)))) |
832 (&ty::TyUint(UintTy::U8), Integral(U8(::std::u8::MAX))) |
833 (&ty::TyUint(UintTy::U16), Integral(U16(::std::u16::MAX))) |
834 (&ty::TyUint(UintTy::U32), Integral(U32(::std::u32::MAX))) |
835 (&ty::TyUint(UintTy::U64), Integral(U64(::std::u64::MAX))) => Maximum,
845 impl LateLintPass for AbsurdExtremeComparisons {
846 fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
847 use types::ExtremeType::*;
848 use types::AbsurdComparisonResult::*;
850 if let ExprBinary(ref cmp, ref lhs, ref rhs) = expr.node {
851 if let Some((culprit, result)) = detect_absurd_comparison(cx, cmp.node, lhs, rhs) {
852 if !in_macro(cx, expr.span) {
853 let msg = "this comparison involving the minimum or maximum element for this \
854 type contains a case that is always true or always false";
856 let conclusion = match result {
857 AlwaysFalse => "this comparison is always false".to_owned(),
858 AlwaysTrue => "this comparison is always true".to_owned(),
859 InequalityImpossible => {
860 format!("the case where the two sides are not equal never occurs, consider using {} == {} \
862 snippet(cx, lhs.span, "lhs"),
863 snippet(cx, rhs.span, "rhs"))
867 let help = format!("because {} is the {} value for this type, {}",
868 snippet(cx, culprit.expr.span, "x"),
869 match culprit.which {
870 Minimum => "minimum",
871 Maximum => "maximum",
875 span_help_and_lint(cx, ABSURD_EXTREME_COMPARISONS, expr.span, msg, &help);
882 /// **What it does:** Checks for comparisons where the relation is always either
883 /// true or false, but where one side has been upcast so that the comparison is
884 /// necessary. Only integer types are checked.
886 /// **Why is this bad?** An expression like `let x : u8 = ...; (x as u32) > 300`
887 /// will mistakenly imply that it is possible for `x` to be outside the range of
890 /// **Known problems:** https://github.com/Manishearth/rust-clippy/issues/886
894 /// let x : u8 = ...; (x as u32) > 300
897 pub INVALID_UPCAST_COMPARISONS,
899 "a comparison involving an upcast which is always true or false"
902 pub struct InvalidUpcastComparisons;
904 impl LintPass for InvalidUpcastComparisons {
905 fn get_lints(&self) -> LintArray {
906 lint_array!(INVALID_UPCAST_COMPARISONS)
910 #[derive(Copy, Clone, Debug, Eq)]
917 #[allow(cast_sign_loss)]
918 fn cmp_s_u(s: i64, u: u64) -> Ordering {
921 } else if u > (i64::max_value() as u64) {
929 impl PartialEq for FullInt {
930 fn eq(&self, other: &Self) -> bool {
931 self.partial_cmp(other).expect("partial_cmp only returns Some(_)") == Ordering::Equal
935 impl PartialOrd for FullInt {
936 fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
937 Some(match (self, other) {
938 (&FullInt::S(s), &FullInt::S(o)) => s.cmp(&o),
939 (&FullInt::U(s), &FullInt::U(o)) => s.cmp(&o),
940 (&FullInt::S(s), &FullInt::U(o)) => Self::cmp_s_u(s, o),
941 (&FullInt::U(s), &FullInt::S(o)) => Self::cmp_s_u(o, s).reverse(),
945 impl Ord for FullInt {
946 fn cmp(&self, other: &Self) -> Ordering {
947 self.partial_cmp(other).expect("partial_cmp for FullInt can never return None")
952 fn numeric_cast_precast_bounds<'a>(cx: &LateContext, expr: &'a Expr) -> Option<(FullInt, FullInt)> {
953 use rustc::ty::TypeVariants::{TyInt, TyUint};
954 use syntax::ast::{IntTy, UintTy};
957 if let ExprCast(ref cast_exp, _) = expr.node {
958 match cx.tcx.tables().expr_ty(cast_exp).sty {
961 IntTy::I8 => (FullInt::S(i8::min_value() as i64), FullInt::S(i8::max_value() as i64)),
962 IntTy::I16 => (FullInt::S(i16::min_value() as i64), FullInt::S(i16::max_value() as i64)),
963 IntTy::I32 => (FullInt::S(i32::min_value() as i64), FullInt::S(i32::max_value() as i64)),
964 IntTy::I64 => (FullInt::S(i64::min_value() as i64), FullInt::S(i64::max_value() as i64)),
965 IntTy::Is => (FullInt::S(isize::min_value() as i64), FullInt::S(isize::max_value() as i64)),
970 UintTy::U8 => (FullInt::U(u8::min_value() as u64), FullInt::U(u8::max_value() as u64)),
971 UintTy::U16 => (FullInt::U(u16::min_value() as u64), FullInt::U(u16::max_value() as u64)),
972 UintTy::U32 => (FullInt::U(u32::min_value() as u64), FullInt::U(u32::max_value() as u64)),
973 UintTy::U64 => (FullInt::U(u64::min_value() as u64), FullInt::U(u64::max_value() as u64)),
974 UintTy::Us => (FullInt::U(usize::min_value() as u64), FullInt::U(usize::max_value() as u64)),
984 fn node_as_const_fullint(cx: &LateContext, expr: &Expr) -> Option<FullInt> {
985 use rustc::middle::const_val::ConstVal::*;
986 use rustc_const_eval::EvalHint::ExprTypeChecked;
987 use rustc_const_eval::eval_const_expr_partial;
988 use rustc_const_math::ConstInt;
990 match eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None) {
992 if let Integral(const_int) = val {
993 Some(match const_int.erase_type() {
994 ConstInt::InferSigned(x) => FullInt::S(x as i64),
995 ConstInt::Infer(x) => FullInt::U(x as u64),
1006 fn err_upcast_comparison(cx: &LateContext, span: &Span, expr: &Expr, always: bool) {
1007 if let ExprCast(ref cast_val, _) = expr.node {
1009 INVALID_UPCAST_COMPARISONS,
1012 "because of the numeric bounds on `{}` prior to casting, this expression is always {}",
1013 snippet(cx, cast_val.span, "the expression"),
1014 if always { "true" } else { "false" },
1019 fn upcast_comparison_bounds_err(cx: &LateContext, span: &Span, rel: comparisons::Rel,
1020 lhs_bounds: Option<(FullInt, FullInt)>, lhs: &Expr, rhs: &Expr, invert: bool) {
1021 use utils::comparisons::*;
1023 if let Some((lb, ub)) = lhs_bounds {
1024 if let Some(norm_rhs_val) = node_as_const_fullint(cx, rhs) {
1025 if rel == Rel::Eq || rel == Rel::Ne {
1026 if norm_rhs_val < lb || norm_rhs_val > ub {
1027 err_upcast_comparison(cx, span, lhs, rel == Rel::Ne);
1029 } else if match rel {
1044 Rel::Eq | Rel::Ne => unreachable!(),
1046 err_upcast_comparison(cx, span, lhs, true)
1047 } else if match rel {
1062 Rel::Eq | Rel::Ne => unreachable!(),
1064 err_upcast_comparison(cx, span, lhs, false)
1070 impl LateLintPass for InvalidUpcastComparisons {
1071 fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
1072 if let ExprBinary(ref cmp, ref lhs, ref rhs) = expr.node {
1074 let normalized = comparisons::normalize_comparison(cmp.node, lhs, rhs);
1075 let (rel, normalized_lhs, normalized_rhs) = if let Some(val) = normalized {
1081 let lhs_bounds = numeric_cast_precast_bounds(cx, normalized_lhs);
1082 let rhs_bounds = numeric_cast_precast_bounds(cx, normalized_rhs);
1084 upcast_comparison_bounds_err(cx, &expr.span, rel, lhs_bounds, normalized_lhs, normalized_rhs, false);
1085 upcast_comparison_bounds_err(cx, &expr.span, rel, rhs_bounds, normalized_rhs, normalized_lhs, true);