1 // Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
2 // file at the top-level directory of this distribution.
4 // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
5 // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
6 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
7 // option. This file may not be copied, modified, or distributed
8 // except according to those terms.
11 #![allow(clippy::default_hash_types)]
13 use crate::consts::{constant, Constant};
14 use crate::reexport::*;
15 use crate::rustc::hir;
16 use crate::rustc::hir::intravisit::{walk_body, walk_expr, walk_ty, FnKind, NestedVisitorMap, Visitor};
17 use crate::rustc::hir::*;
18 use crate::rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
19 use crate::rustc::ty::layout::LayoutOf;
20 use crate::rustc::ty::{self, Ty, TyCtxt, TypeckTables};
21 use crate::rustc::{declare_tool_lint, lint_array};
22 use crate::rustc_errors::Applicability;
23 use crate::rustc_target::spec::abi::Abi;
24 use crate::rustc_typeck::hir_ty_to_ty;
25 use crate::syntax::ast::{FloatTy, IntTy, UintTy};
26 use crate::syntax::errors::DiagnosticBuilder;
27 use crate::syntax::source_map::Span;
28 use crate::utils::paths;
30 clip, comparisons, differing_macro_contexts, higher, in_constant, in_macro, int_bits, last_path_segment,
31 match_def_path, match_path, match_type, multispan_sugg, opt_def_id, same_tys, sext, snippet, snippet_opt,
32 snippet_with_applicability, span_help_and_lint, span_lint, span_lint_and_sugg, span_lint_and_then, unsext,
34 use if_chain::if_chain;
36 use std::cmp::Ordering;
37 use std::collections::BTreeMap;
39 /// Handles all the linting of funky types
42 /// **What it does:** Checks for use of `Box<Vec<_>>` anywhere in the code.
44 /// **Why is this bad?** `Vec` already keeps its contents in a separate area on
45 /// the heap. So if you `Box` it, you just add another level of indirection
46 /// without any benefit whatsoever.
48 /// **Known problems:** None.
53 /// values: Box<Vec<Foo>>,
64 declare_clippy_lint! {
67 "usage of `Box<Vec<T>>`, vector elements are already on the heap"
70 /// **What it does:** Checks for use of `Option<Option<_>>` in function signatures and type
73 /// **Why is this bad?** `Option<_>` represents an optional value. `Option<Option<_>>`
74 /// represents an optional optional value which is logically the same thing as an optional
75 /// value but has an unneeded extra level of wrapping.
77 /// **Known problems:** None.
81 /// fn x() -> Option<Option<u32>> {
84 declare_clippy_lint! {
87 "usage of `Option<Option<T>>`"
90 /// **What it does:** Checks for usage of any `LinkedList`, suggesting to use a
91 /// `Vec` or a `VecDeque` (formerly called `RingBuf`).
93 /// **Why is this bad?** Gankro says:
95 /// > The TL;DR of `LinkedList` is that it's built on a massive amount of
96 /// pointers and indirection.
97 /// > It wastes memory, it has terrible cache locality, and is all-around slow.
99 /// > "only" amortized for push/pop, should be faster in the general case for
100 /// almost every possible
101 /// > workload, and isn't even amortized at all if you can predict the capacity
104 /// > `LinkedList`s are only really good if you're doing a lot of merging or
105 /// splitting of lists.
106 /// > This is because they can just mangle some pointers instead of actually
107 /// copying the data. Even
108 /// > if you're doing a lot of insertion in the middle of the list, `RingBuf`
109 /// can still be better
110 /// > because of how expensive it is to seek to the middle of a `LinkedList`.
112 /// **Known problems:** False positives – the instances where using a
113 /// `LinkedList` makes sense are few and far between, but they can still happen.
117 /// let x = LinkedList::new();
119 declare_clippy_lint! {
122 "usage of LinkedList, usually a vector is faster, or a more specialized data \
123 structure like a VecDeque"
126 /// **What it does:** Checks for use of `&Box<T>` anywhere in the code.
128 /// **Why is this bad?** Any `&Box<T>` can also be a `&T`, which is more
131 /// **Known problems:** None.
135 /// fn foo(bar: &Box<T>) { ... }
141 /// fn foo(bar: &T) { ... }
143 declare_clippy_lint! {
146 "a borrow of a boxed type"
149 impl LintPass for TypePass {
150 fn get_lints(&self) -> LintArray {
151 lint_array!(BOX_VEC, OPTION_OPTION, LINKEDLIST, BORROWED_BOX)
155 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for TypePass {
156 fn check_fn(&mut self, cx: &LateContext<'_, '_>, _: FnKind<'_>, decl: &FnDecl, _: &Body, _: Span, id: NodeId) {
157 // skip trait implementations, see #605
158 if let Some(hir::Node::Item(item)) = cx.tcx.hir.find(cx.tcx.hir.get_parent(id)) {
159 if let ItemKind::Impl(_, _, _, _, Some(..), _, _) = item.node {
164 check_fn_decl(cx, decl);
167 fn check_struct_field(&mut self, cx: &LateContext<'_, '_>, field: &StructField) {
168 check_ty(cx, &field.ty, false);
171 fn check_trait_item(&mut self, cx: &LateContext<'_, '_>, item: &TraitItem) {
173 TraitItemKind::Const(ref ty, _) | TraitItemKind::Type(_, Some(ref ty)) => check_ty(cx, ty, false),
174 TraitItemKind::Method(ref sig, _) => check_fn_decl(cx, &sig.decl),
179 fn check_local(&mut self, cx: &LateContext<'_, '_>, local: &Local) {
180 if let Some(ref ty) = local.ty {
181 check_ty(cx, ty, true);
186 fn check_fn_decl(cx: &LateContext<'_, '_>, decl: &FnDecl) {
187 for input in &decl.inputs {
188 check_ty(cx, input, false);
191 if let FunctionRetTy::Return(ref ty) = decl.output {
192 check_ty(cx, ty, false);
196 /// Check if `qpath` has last segment with type parameter matching `path`
197 fn match_type_parameter(cx: &LateContext<'_, '_>, qpath: &QPath, path: &[&str]) -> bool {
198 let last = last_path_segment(qpath);
200 if let Some(ref params) = last.args;
201 if !params.parenthesized;
202 if let Some(ty) = params.args.iter().find_map(|arg| match arg {
203 GenericArg::Type(ty) => Some(ty),
204 GenericArg::Lifetime(_) => None,
206 if let TyKind::Path(ref qpath) = ty.node;
207 if let Some(did) = opt_def_id(cx.tables.qpath_def(qpath, cx.tcx.hir.node_to_hir_id(ty.id)));
208 if match_def_path(cx.tcx, did, path);
216 /// Recursively check for `TypePass` lints in the given type. Stop at the first
219 /// The parameter `is_local` distinguishes the context of the type; types from
220 /// local bindings should only be checked for the `BORROWED_BOX` lint.
221 fn check_ty(cx: &LateContext<'_, '_>, ast_ty: &hir::Ty, is_local: bool) {
222 if in_macro(ast_ty.span) {
226 TyKind::Path(ref qpath) if !is_local => {
227 let hir_id = cx.tcx.hir.node_to_hir_id(ast_ty.id);
228 let def = cx.tables.qpath_def(qpath, hir_id);
229 if let Some(def_id) = opt_def_id(def) {
230 if Some(def_id) == cx.tcx.lang_items().owned_box() {
231 if match_type_parameter(cx, qpath, &paths::VEC) {
236 "you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`",
237 "`Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.",
239 return; // don't recurse into the type
241 } else if match_def_path(cx.tcx, def_id, &paths::OPTION) {
242 if match_type_parameter(cx, qpath, &paths::OPTION) {
247 "consider using `Option<T>` instead of `Option<Option<T>>` or a custom \
248 enum if you need to distinguish all 3 cases",
250 return; // don't recurse into the type
252 } else if match_def_path(cx.tcx, def_id, &paths::LINKED_LIST) {
257 "I see you're using a LinkedList! Perhaps you meant some other data structure?",
258 "a VecDeque might work",
260 return; // don't recurse into the type
264 QPath::Resolved(Some(ref ty), ref p) => {
265 check_ty(cx, ty, is_local);
266 for ty in p.segments.iter().flat_map(|seg| {
269 .map_or_else(|| [].iter(), |params| params.args.iter())
270 .filter_map(|arg| match arg {
271 GenericArg::Type(ty) => Some(ty),
272 GenericArg::Lifetime(_) => None,
275 check_ty(cx, ty, is_local);
278 QPath::Resolved(None, ref p) => {
279 for ty in p.segments.iter().flat_map(|seg| {
282 .map_or_else(|| [].iter(), |params| params.args.iter())
283 .filter_map(|arg| match arg {
284 GenericArg::Type(ty) => Some(ty),
285 GenericArg::Lifetime(_) => None,
288 check_ty(cx, ty, is_local);
291 QPath::TypeRelative(ref ty, ref seg) => {
292 check_ty(cx, ty, is_local);
293 if let Some(ref params) = seg.args {
294 for ty in params.args.iter().filter_map(|arg| match arg {
295 GenericArg::Type(ty) => Some(ty),
296 GenericArg::Lifetime(_) => None,
298 check_ty(cx, ty, is_local);
304 TyKind::Rptr(ref lt, ref mut_ty) => check_ty_rptr(cx, ast_ty, is_local, lt, mut_ty),
306 TyKind::Slice(ref ty) | TyKind::Array(ref ty, _) | TyKind::Ptr(MutTy { ref ty, .. }) => {
307 check_ty(cx, ty, is_local)
309 TyKind::Tup(ref tys) => {
311 check_ty(cx, ty, is_local);
318 fn check_ty_rptr(cx: &LateContext<'_, '_>, ast_ty: &hir::Ty, is_local: bool, lt: &Lifetime, mut_ty: &MutTy) {
319 match mut_ty.ty.node {
320 TyKind::Path(ref qpath) => {
321 let hir_id = cx.tcx.hir.node_to_hir_id(mut_ty.ty.id);
322 let def = cx.tables.qpath_def(qpath, hir_id);
324 if let Some(def_id) = opt_def_id(def);
325 if Some(def_id) == cx.tcx.lang_items().owned_box();
326 if let QPath::Resolved(None, ref path) = *qpath;
327 if let [ref bx] = *path.segments;
328 if let Some(ref params) = bx.args;
329 if !params.parenthesized;
330 if let Some(inner) = params.args.iter().find_map(|arg| match arg {
331 GenericArg::Type(ty) => Some(ty),
332 GenericArg::Lifetime(_) => None,
335 if is_any_trait(inner) {
336 // Ignore `Box<Any>` types, see #1884 for details.
340 let ltopt = if lt.is_elided() {
343 format!("{} ", lt.name.ident().as_str())
345 let mutopt = if mut_ty.mutbl == Mutability::MutMutable {
350 let mut applicability = Applicability::MachineApplicable;
355 "you seem to be trying to use `&Box<T>`. Consider using just `&T`",
361 &snippet_with_applicability(cx, inner.span, "..", &mut applicability)
363 Applicability::Unspecified,
365 return; // don't recurse into the type
368 check_ty(cx, &mut_ty.ty, is_local);
370 _ => check_ty(cx, &mut_ty.ty, is_local),
374 // Returns true if given type is `Any` trait.
375 fn is_any_trait(t: &hir::Ty) -> bool {
377 if let TyKind::TraitObject(ref traits, _) = t.node;
378 if traits.len() >= 1;
379 // Only Send/Sync can be used as additional traits, so it is enough to
380 // check only the first trait.
381 if match_path(&traits[0].trait_ref.path, &paths::ANY_TRAIT);
392 /// **What it does:** Checks for binding a unit value.
394 /// **Why is this bad?** A unit value cannot usefully be used anywhere. So
395 /// binding one is kind of pointless.
397 /// **Known problems:** None.
405 declare_clippy_lint! {
408 "creating a let binding to a value of unit type, which usually can't be used afterwards"
411 fn check_let_unit(cx: &LateContext<'_, '_>, decl: &Decl) {
412 if let DeclKind::Local(ref local) = decl.node {
413 if is_unit(cx.tables.pat_ty(&local.pat)) {
414 if in_external_macro(cx.sess(), decl.span) || in_macro(local.pat.span) {
417 if higher::is_from_for_desugar(decl) {
425 "this let-binding has unit value. Consider omitting `let {} =`",
426 snippet(cx, local.pat.span, "..")
433 impl LintPass for LetPass {
434 fn get_lints(&self) -> LintArray {
435 lint_array!(LET_UNIT_VALUE)
439 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for LetPass {
440 fn check_decl(&mut self, cx: &LateContext<'a, 'tcx>, decl: &'tcx Decl) {
441 check_let_unit(cx, decl)
445 /// **What it does:** Checks for comparisons to unit.
447 /// **Why is this bad?** Unit is always equal to itself, and thus is just a
448 /// clumsily written constant. Mostly this happens when someone accidentally
449 /// adds semicolons at the end of the operands.
451 /// **Known problems:** None.
471 declare_clippy_lint! {
474 "comparing unit values"
479 impl LintPass for UnitCmp {
480 fn get_lints(&self) -> LintArray {
481 lint_array!(UNIT_CMP)
485 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnitCmp {
486 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
487 if in_macro(expr.span) {
490 if let ExprKind::Binary(ref cmp, ref left, _) = expr.node {
492 if op.is_comparison() && is_unit(cx.tables.expr_ty(left)) {
493 let result = match op {
494 BinOpKind::Eq | BinOpKind::Le | BinOpKind::Ge => "true",
502 "{}-comparison of unit values detected. This will always be {}",
512 /// **What it does:** Checks for passing a unit value as an argument to a function without using a
513 /// unit literal (`()`).
515 /// **Why is this bad?** This is likely the result of an accidental semicolon.
517 /// **Known problems:** None.
526 declare_clippy_lint! {
529 "passing unit to a function"
534 impl LintPass for UnitArg {
535 fn get_lints(&self) -> LintArray {
536 lint_array!(UNIT_ARG)
540 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnitArg {
541 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
542 if in_macro(expr.span) {
546 ExprKind::Call(_, ref args) | ExprKind::MethodCall(_, _, ref args) => {
548 if is_unit(cx.tables.expr_ty(arg)) && !is_unit_literal(arg) {
549 let map = &cx.tcx.hir;
550 // apparently stuff in the desugaring of `?` can trigger this
551 // so check for that here
552 // only the calls to `Try::from_error` is marked as desugared,
553 // so we need to check both the current Expr and its parent.
554 if !is_questionmark_desugar_marked_call(expr) {
556 let opt_parent_node = map.find(map.get_parent_node(expr.id));
557 if let Some(hir::Node::Expr(parent_expr)) = opt_parent_node;
558 if is_questionmark_desugar_marked_call(parent_expr);
561 // `expr` and `parent_expr` where _both_ not from
562 // desugaring `?`, so lint
567 "passing a unit value to a function",
568 "if you intended to pass a unit value, use a unit literal instead",
570 Applicability::MachineApplicable,
583 fn is_questionmark_desugar_marked_call(expr: &Expr) -> bool {
584 use crate::syntax_pos::hygiene::CompilerDesugaringKind;
585 if let ExprKind::Call(ref callee, _) = expr.node {
586 callee.span.is_compiler_desugaring(CompilerDesugaringKind::QuestionMark)
592 fn is_unit(ty: Ty<'_>) -> bool {
594 ty::Tuple(slice) if slice.is_empty() => true,
599 fn is_unit_literal(expr: &Expr) -> bool {
601 ExprKind::Tup(ref slice) if slice.is_empty() => true,
608 /// **What it does:** Checks for casts from any numerical to a float type where
609 /// the receiving type cannot store all values from the original type without
610 /// rounding errors. This possible rounding is to be expected, so this lint is
611 /// `Allow` by default.
613 /// Basically, this warns on casting any integer with 32 or more bits to `f32`
614 /// or any 64-bit integer to `f64`.
616 /// **Why is this bad?** It's not bad at all. But in some applications it can be
617 /// helpful to know where precision loss can take place. This lint can help find
618 /// those places in the code.
620 /// **Known problems:** None.
624 /// let x = u64::MAX;
627 declare_clippy_lint! {
628 pub CAST_PRECISION_LOSS,
630 "casts that cause loss of precision, e.g. `x as f32` where `x: u64`"
633 /// **What it does:** Checks for casts from a signed to an unsigned numerical
634 /// type. In this case, negative values wrap around to large positive values,
635 /// which can be quite surprising in practice. However, as the cast works as
636 /// defined, this lint is `Allow` by default.
638 /// **Why is this bad?** Possibly surprising results. You can activate this lint
639 /// as a one-time check to see where numerical wrapping can arise.
641 /// **Known problems:** None.
646 /// y as u128 // will return 18446744073709551615
648 declare_clippy_lint! {
651 "casts from signed types to unsigned types, e.g. `x as u32` where `x: i32`"
654 /// **What it does:** Checks for on casts between numerical types that may
655 /// truncate large values. This is expected behavior, so the cast is `Allow` by
658 /// **Why is this bad?** In some problem domains, it is good practice to avoid
659 /// truncation. This lint can be activated to help assess where additional
660 /// checks could be beneficial.
662 /// **Known problems:** None.
666 /// fn as_u8(x: u64) -> u8 {
670 declare_clippy_lint! {
671 pub CAST_POSSIBLE_TRUNCATION,
673 "casts that may cause truncation of the value, e.g. `x as u8` where `x: u32`, \
674 or `x as i32` where `x: f32`"
677 /// **What it does:** Checks for casts from an unsigned type to a signed type of
678 /// the same size. Performing such a cast is a 'no-op' for the compiler,
679 /// i.e. nothing is changed at the bit level, and the binary representation of
680 /// the value is reinterpreted. This can cause wrapping if the value is too big
681 /// for the target signed type. However, the cast works as defined, so this lint
682 /// is `Allow` by default.
684 /// **Why is this bad?** While such a cast is not bad in itself, the results can
685 /// be surprising when this is not the intended behavior, as demonstrated by the
688 /// **Known problems:** None.
692 /// u32::MAX as i32 // will yield a value of `-1`
694 declare_clippy_lint! {
695 pub CAST_POSSIBLE_WRAP,
697 "casts that may cause wrapping around the value, e.g. `x as i32` where `x: u32` \
701 /// **What it does:** Checks for on casts between numerical types that may
702 /// be replaced by safe conversion functions.
704 /// **Why is this bad?** Rust's `as` keyword will perform many kinds of
705 /// conversions, including silently lossy conversions. Conversion functions such
706 /// as `i32::from` will only perform lossless conversions. Using the conversion
707 /// functions prevents conversions from turning into silent lossy conversions if
708 /// the types of the input expressions ever change, and make it easier for
709 /// people reading the code to know that the conversion is lossless.
711 /// **Known problems:** None.
715 /// fn as_u64(x: u8) -> u64 {
720 /// Using `::from` would look like this:
723 /// fn as_u64(x: u8) -> u64 {
727 declare_clippy_lint! {
730 "casts using `as` that are known to be lossless, e.g. `x as u64` where `x: u8`"
733 /// **What it does:** Checks for casts to the same type.
735 /// **Why is this bad?** It's just unnecessary.
737 /// **Known problems:** None.
741 /// let _ = 2i32 as i32
743 declare_clippy_lint! {
744 pub UNNECESSARY_CAST,
746 "cast to the same type, e.g. `x as i32` where `x: i32`"
749 /// **What it does:** Checks for casts from a less-strictly-aligned pointer to a
750 /// more-strictly-aligned pointer
752 /// **Why is this bad?** Dereferencing the resulting pointer may be undefined
755 /// **Known problems:** None.
759 /// let _ = (&1u8 as *const u8) as *const u16;
760 /// let _ = (&mut 1u8 as *mut u8) as *mut u16;
762 declare_clippy_lint! {
763 pub CAST_PTR_ALIGNMENT,
765 "cast from a pointer to a more-strictly-aligned pointer"
768 /// **What it does:** Checks for casts of function pointers to something other than usize
770 /// **Why is this bad?**
771 /// Casting a function pointer to anything other than usize/isize is not portable across
772 /// architectures, because you end up losing bits if the target type is too small or end up with a
773 /// bunch of extra bits that waste space and add more instructions to the final binary than
774 /// strictly necessary for the problem
776 /// Casting to isize also doesn't make sense since there are no signed addresses.
782 /// fn fun() -> i32 {}
783 /// let a = fun as i64;
786 /// fn fun2() -> i32 {}
787 /// let a = fun2 as usize;
789 declare_clippy_lint! {
790 pub FN_TO_NUMERIC_CAST,
792 "casting a function pointer to a numeric type other than usize"
795 /// **What it does:** Checks for casts of a function pointer to a numeric type not wide enough to
798 /// **Why is this bad?**
799 /// Such a cast discards some bits of the function's address. If this is intended, it would be more
800 /// clearly expressed by casting to usize first, then casting the usize to the intended type (with
801 /// a comment) to perform the truncation.
807 /// fn fn1() -> i16 {
810 /// let _ = fn1 as i32;
812 /// // Better: Cast to usize first, then comment with the reason for the truncation
813 /// fn fn2() -> i16 {
816 /// let fn_ptr = fn2 as usize;
817 /// let fn_ptr_truncated = fn_ptr as i32;
819 declare_clippy_lint! {
820 pub FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
822 "casting a function pointer to a numeric type not wide enough to store the address"
825 /// Returns the size in bits of an integral type.
826 /// Will return 0 if the type is not an int or uint variant
827 fn int_ty_to_nbits(typ: Ty<'_>, tcx: TyCtxt<'_, '_, '_>) -> u64 {
829 ty::Int(i) => match i {
830 IntTy::Isize => tcx.data_layout.pointer_size.bits(),
837 ty::Uint(i) => match i {
838 UintTy::Usize => tcx.data_layout.pointer_size.bits(),
849 fn is_isize_or_usize(typ: Ty<'_>) -> bool {
851 ty::Int(IntTy::Isize) | ty::Uint(UintTy::Usize) => true,
856 fn span_precision_loss_lint(cx: &LateContext<'_, '_>, expr: &Expr, cast_from: Ty<'_>, cast_to_f64: bool) {
857 let mantissa_nbits = if cast_to_f64 { 52 } else { 23 };
858 let arch_dependent = is_isize_or_usize(cast_from) && cast_to_f64;
859 let arch_dependent_str = "on targets with 64-bit wide pointers ";
860 let from_nbits_str = if arch_dependent {
862 } else if is_isize_or_usize(cast_from) {
863 "32 or 64".to_owned()
865 int_ty_to_nbits(cast_from, cx.tcx).to_string()
872 "casting {0} to {1} causes a loss of precision {2}({0} is {3} bits wide, but {1}'s mantissa \
873 is only {4} bits wide)",
875 if cast_to_f64 { "f64" } else { "f32" },
876 if arch_dependent { arch_dependent_str } else { "" },
883 fn should_strip_parens(op: &Expr, snip: &str) -> bool {
884 if let ExprKind::Binary(_, _, _) = op.node {
885 if snip.starts_with('(') && snip.ends_with(')') {
892 fn span_lossless_lint(cx: &LateContext<'_, '_>, expr: &Expr, op: &Expr, cast_from: Ty<'_>, cast_to: Ty<'_>) {
893 // Do not suggest using From in consts/statics until it is valid to do so (see #2267).
894 if in_constant(cx, expr.id) {
897 // The suggestion is to use a function call, so if the original expression
898 // has parens on the outside, they are no longer needed.
899 let mut applicability = Applicability::MachineApplicable;
900 let opt = snippet_opt(cx, op.span);
901 let sugg = if let Some(ref snip) = opt {
902 if should_strip_parens(op, snip) {
903 &snip[1..snip.len() - 1]
908 applicability = Applicability::HasPlaceholders;
917 "casting {} to {} may become silently lossy if types change",
921 format!("{}::from({})", cast_to, sugg),
932 fn check_truncation_and_wrapping(cx: &LateContext<'_, '_>, expr: &Expr, cast_from: Ty<'_>, cast_to: Ty<'_>) {
933 let arch_64_suffix = " on targets with 64-bit wide pointers";
934 let arch_32_suffix = " on targets with 32-bit wide pointers";
935 let cast_unsigned_to_signed = !cast_from.is_signed() && cast_to.is_signed();
936 let from_nbits = int_ty_to_nbits(cast_from, cx.tcx);
937 let to_nbits = int_ty_to_nbits(cast_to, cx.tcx);
938 let (span_truncation, suffix_truncation, span_wrap, suffix_wrap) =
939 match (is_isize_or_usize(cast_from), is_isize_or_usize(cast_to)) {
940 (true, true) | (false, false) => (
941 to_nbits < from_nbits,
943 to_nbits == from_nbits && cast_unsigned_to_signed,
953 to_nbits <= 32 && cast_unsigned_to_signed,
959 cast_unsigned_to_signed,
960 if from_nbits == 64 {
970 CAST_POSSIBLE_TRUNCATION,
973 "casting {} to {} may truncate the value{}",
976 match suffix_truncation {
977 ArchSuffix::_32 => arch_32_suffix,
978 ArchSuffix::_64 => arch_64_suffix,
979 ArchSuffix::None => "",
990 "casting {} to {} may wrap around the value{}",
994 ArchSuffix::_32 => arch_32_suffix,
995 ArchSuffix::_64 => arch_64_suffix,
996 ArchSuffix::None => "",
1003 fn check_lossless(cx: &LateContext<'_, '_>, expr: &Expr, op: &Expr, cast_from: Ty<'_>, cast_to: Ty<'_>) {
1004 let cast_signed_to_unsigned = cast_from.is_signed() && !cast_to.is_signed();
1005 let from_nbits = int_ty_to_nbits(cast_from, cx.tcx);
1006 let to_nbits = int_ty_to_nbits(cast_to, cx.tcx);
1007 if !is_isize_or_usize(cast_from) && !is_isize_or_usize(cast_to) && from_nbits < to_nbits && !cast_signed_to_unsigned
1009 span_lossless_lint(cx, expr, op, cast_from, cast_to);
1013 impl LintPass for CastPass {
1014 fn get_lints(&self) -> LintArray {
1016 CAST_PRECISION_LOSS,
1018 CAST_POSSIBLE_TRUNCATION,
1024 FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
1029 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for CastPass {
1030 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
1031 if let ExprKind::Cast(ref ex, _) = expr.node {
1032 let (cast_from, cast_to) = (cx.tables.expr_ty(ex), cx.tables.expr_ty(expr));
1033 lint_fn_to_numeric_cast(cx, expr, ex, cast_from, cast_to);
1034 if let ExprKind::Lit(ref lit) = ex.node {
1035 use crate::syntax::ast::{LitIntType, LitKind};
1037 LitKind::Int(_, LitIntType::Unsuffixed) | LitKind::FloatUnsuffixed(_) => {},
1039 if cast_from.sty == cast_to.sty && !in_external_macro(cx.sess(), expr.span) {
1045 "casting to the same type is unnecessary (`{}` -> `{}`)",
1053 if cast_from.is_numeric() && cast_to.is_numeric() && !in_external_macro(cx.sess(), expr.span) {
1054 match (cast_from.is_integral(), cast_to.is_integral()) {
1056 let from_nbits = int_ty_to_nbits(cast_from, cx.tcx);
1057 let to_nbits = if let ty::Float(FloatTy::F32) = cast_to.sty {
1062 if is_isize_or_usize(cast_from) || from_nbits >= to_nbits {
1063 span_precision_loss_lint(cx, expr, cast_from, to_nbits == 64);
1065 if from_nbits < to_nbits {
1066 span_lossless_lint(cx, expr, ex, cast_from, cast_to);
1072 CAST_POSSIBLE_TRUNCATION,
1074 &format!("casting {} to {} may truncate the value", cast_from, cast_to),
1076 if !cast_to.is_signed() {
1081 &format!("casting {} to {} may lose the sign of the value", cast_from, cast_to),
1086 if cast_from.is_signed() && !cast_to.is_signed() {
1091 &format!("casting {} to {} may lose the sign of the value", cast_from, cast_to),
1094 check_truncation_and_wrapping(cx, expr, cast_from, cast_to);
1095 check_lossless(cx, expr, ex, cast_from, cast_to);
1098 if let (&ty::Float(FloatTy::F64), &ty::Float(FloatTy::F32)) = (&cast_from.sty, &cast_to.sty) {
1101 CAST_POSSIBLE_TRUNCATION,
1103 "casting f64 to f32 may truncate the value",
1106 if let (&ty::Float(FloatTy::F32), &ty::Float(FloatTy::F64)) = (&cast_from.sty, &cast_to.sty) {
1107 span_lossless_lint(cx, expr, ex, cast_from, cast_to);
1114 if let ty::RawPtr(from_ptr_ty) = &cast_from.sty;
1115 if let ty::RawPtr(to_ptr_ty) = &cast_to.sty;
1116 if let Some(from_align) = cx.layout_of(from_ptr_ty.ty).ok().map(|a| a.align.abi);
1117 if let Some(to_align) = cx.layout_of(to_ptr_ty.ty).ok().map(|a| a.align.abi);
1118 if from_align < to_align;
1119 // with c_void, we inherently need to trust the user
1121 match_type(cx, from_ptr_ty.ty, &paths::C_VOID)
1122 || match_type(cx, from_ptr_ty.ty, &paths::C_VOID_LIBC)
1129 &format!("casting from `{}` to a more-strictly-aligned pointer (`{}`)", cast_from, cast_to)
1137 fn lint_fn_to_numeric_cast(
1138 cx: &LateContext<'_, '_>,
1144 // We only want to check casts to `ty::Uint` or `ty::Int`
1146 ty::Uint(_) | ty::Int(..) => { /* continue on */ },
1149 match cast_from.sty {
1150 ty::FnDef(..) | ty::FnPtr(_) => {
1151 let mut applicability = Applicability::MachineApplicable;
1152 let from_snippet = snippet_with_applicability(cx, cast_expr.span, "x", &mut applicability);
1154 let to_nbits = int_ty_to_nbits(cast_to, cx.tcx);
1155 if to_nbits < cx.tcx.data_layout.pointer_size.bits() {
1158 FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
1161 "casting function pointer `{}` to `{}`, which truncates the value",
1162 from_snippet, cast_to
1165 format!("{} as usize", from_snippet),
1168 } else if cast_to.sty != ty::Uint(UintTy::Usize) {
1173 &format!("casting function pointer `{}` to `{}`", from_snippet, cast_to),
1175 format!("{} as usize", from_snippet),
1184 /// **What it does:** Checks for types used in structs, parameters and `let`
1185 /// declarations above a certain complexity threshold.
1187 /// **Why is this bad?** Too complex types make the code less readable. Consider
1188 /// using a `type` definition to simplify them.
1190 /// **Known problems:** None.
1195 /// inner: Rc<Vec<Vec<Box<(u32, u32, u32, u32)>>>>,
1198 declare_clippy_lint! {
1199 pub TYPE_COMPLEXITY,
1201 "usage of very complex types that might be better factored into `type` definitions"
1204 pub struct TypeComplexityPass {
1208 impl TypeComplexityPass {
1209 pub fn new(threshold: u64) -> Self {
1214 impl LintPass for TypeComplexityPass {
1215 fn get_lints(&self) -> LintArray {
1216 lint_array!(TYPE_COMPLEXITY)
1220 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for TypeComplexityPass {
1223 cx: &LateContext<'a, 'tcx>,
1230 self.check_fndecl(cx, decl);
1233 fn check_struct_field(&mut self, cx: &LateContext<'a, 'tcx>, field: &'tcx StructField) {
1234 // enum variants are also struct fields now
1235 self.check_type(cx, &field.ty);
1238 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
1240 ItemKind::Static(ref ty, _, _) | ItemKind::Const(ref ty, _) => self.check_type(cx, ty),
1241 // functions, enums, structs, impls and traits are covered
1246 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem) {
1248 TraitItemKind::Const(ref ty, _) | TraitItemKind::Type(_, Some(ref ty)) => self.check_type(cx, ty),
1249 TraitItemKind::Method(MethodSig { ref decl, .. }, TraitMethod::Required(_)) => self.check_fndecl(cx, decl),
1250 // methods with default impl are covered by check_fn
1255 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx ImplItem) {
1257 ImplItemKind::Const(ref ty, _) | ImplItemKind::Type(ref ty) => self.check_type(cx, ty),
1258 // methods are covered by check_fn
1263 fn check_local(&mut self, cx: &LateContext<'a, 'tcx>, local: &'tcx Local) {
1264 if let Some(ref ty) = local.ty {
1265 self.check_type(cx, ty);
1270 impl<'a, 'tcx> TypeComplexityPass {
1271 fn check_fndecl(&self, cx: &LateContext<'a, 'tcx>, decl: &'tcx FnDecl) {
1272 for arg in &decl.inputs {
1273 self.check_type(cx, arg);
1275 if let Return(ref ty) = decl.output {
1276 self.check_type(cx, ty);
1280 fn check_type(&self, cx: &LateContext<'_, '_>, ty: &hir::Ty) {
1281 if in_macro(ty.span) {
1285 let mut visitor = TypeComplexityVisitor { score: 0, nest: 1 };
1286 visitor.visit_ty(ty);
1290 if score > self.threshold {
1295 "very complex type used. Consider factoring parts into `type` definitions",
1301 /// Walks a type and assigns a complexity score to it.
1302 struct TypeComplexityVisitor {
1303 /// total complexity score of the type
1305 /// current nesting level
1309 impl<'tcx> Visitor<'tcx> for TypeComplexityVisitor {
1310 fn visit_ty(&mut self, ty: &'tcx hir::Ty) {
1311 let (add_score, sub_nest) = match ty.node {
1312 // _, &x and *x have only small overhead; don't mess with nesting level
1313 TyKind::Infer | TyKind::Ptr(..) | TyKind::Rptr(..) => (1, 0),
1315 // the "normal" components of a type: named types, arrays/tuples
1316 TyKind::Path(..) | TyKind::Slice(..) | TyKind::Tup(..) | TyKind::Array(..) => (10 * self.nest, 1),
1318 // function types bring a lot of overhead
1319 TyKind::BareFn(ref bare) if bare.abi == Abi::Rust => (50 * self.nest, 1),
1321 TyKind::TraitObject(ref param_bounds, _) => {
1322 let has_lifetime_parameters = param_bounds.iter().any(|bound| {
1323 bound.bound_generic_params.iter().any(|gen| match gen.kind {
1324 GenericParamKind::Lifetime { .. } => true,
1328 if has_lifetime_parameters {
1329 // complex trait bounds like A<'a, 'b>
1332 // simple trait bounds like A + B
1339 self.score += add_score;
1340 self.nest += sub_nest;
1342 self.nest -= sub_nest;
1344 fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
1345 NestedVisitorMap::None
1349 /// **What it does:** Checks for expressions where a character literal is cast
1350 /// to `u8` and suggests using a byte literal instead.
1352 /// **Why is this bad?** In general, casting values to smaller types is
1353 /// error-prone and should be avoided where possible. In the particular case of
1354 /// converting a character literal to u8, it is easy to avoid by just using a
1355 /// byte literal instead. As an added bonus, `b'a'` is even slightly shorter
1356 /// than `'a' as u8`.
1358 /// **Known problems:** None.
1365 /// A better version, using the byte literal:
1370 declare_clippy_lint! {
1373 "casting a character literal to u8"
1376 pub struct CharLitAsU8;
1378 impl LintPass for CharLitAsU8 {
1379 fn get_lints(&self) -> LintArray {
1380 lint_array!(CHAR_LIT_AS_U8)
1384 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for CharLitAsU8 {
1385 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
1386 use crate::syntax::ast::{LitKind, UintTy};
1388 if let ExprKind::Cast(ref e, _) = expr.node {
1389 if let ExprKind::Lit(ref l) = e.node {
1390 if let LitKind::Char(_) = l.node {
1391 if ty::Uint(UintTy::U8) == cx.tables.expr_ty(expr).sty && !in_macro(expr.span) {
1392 let msg = "casting character literal to u8. `char`s \
1393 are 4 bytes wide in rust, so casting to u8 \
1396 "Consider using a byte literal instead:\nb{}",
1397 snippet(cx, e.span, "'x'")
1399 span_help_and_lint(cx, CHAR_LIT_AS_U8, expr.span, msg, &help);
1407 /// **What it does:** Checks for comparisons where one side of the relation is
1408 /// either the minimum or maximum value for its type and warns if it involves a
1409 /// case that is always true or always false. Only integer and boolean types are
1412 /// **Why is this bad?** An expression like `min <= x` may misleadingly imply
1413 /// that is is possible for `x` to be less than the minimum. Expressions like
1414 /// `max < x` are probably mistakes.
1416 /// **Known problems:** For `usize` the size of the current compile target will
1417 /// be assumed (e.g. 64 bits on 64 bit systems). This means code that uses such
1418 /// a comparison to detect target pointer width will trigger this lint. One can
1419 /// use `mem::sizeof` and compare its value or conditional compilation
1421 /// like `#[cfg(target_pointer_width = "64")] ..` instead.
1426 /// 100 > std::i32::MAX
1428 declare_clippy_lint! {
1429 pub ABSURD_EXTREME_COMPARISONS,
1431 "a comparison with a maximum or minimum value that is always true or false"
1434 pub struct AbsurdExtremeComparisons;
1436 impl LintPass for AbsurdExtremeComparisons {
1437 fn get_lints(&self) -> LintArray {
1438 lint_array!(ABSURD_EXTREME_COMPARISONS)
1447 struct ExtremeExpr<'a> {
1452 enum AbsurdComparisonResult {
1455 InequalityImpossible,
1458 fn is_cast_between_fixed_and_target<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) -> bool {
1459 if let ExprKind::Cast(ref cast_exp, _) = expr.node {
1460 let precast_ty = cx.tables.expr_ty(cast_exp);
1461 let cast_ty = cx.tables.expr_ty(expr);
1463 return is_isize_or_usize(precast_ty) != is_isize_or_usize(cast_ty);
1469 fn detect_absurd_comparison<'a, 'tcx>(
1470 cx: &LateContext<'a, 'tcx>,
1474 ) -> Option<(ExtremeExpr<'tcx>, AbsurdComparisonResult)> {
1475 use crate::types::AbsurdComparisonResult::*;
1476 use crate::types::ExtremeType::*;
1477 use crate::utils::comparisons::*;
1479 // absurd comparison only makes sense on primitive types
1480 // primitive types don't implement comparison operators with each other
1481 if cx.tables.expr_ty(lhs) != cx.tables.expr_ty(rhs) {
1485 // comparisons between fix sized types and target sized types are considered unanalyzable
1486 if is_cast_between_fixed_and_target(cx, lhs) || is_cast_between_fixed_and_target(cx, rhs) {
1490 let normalized = normalize_comparison(op, lhs, rhs);
1491 let (rel, normalized_lhs, normalized_rhs) = if let Some(val) = normalized {
1497 let lx = detect_extreme_expr(cx, normalized_lhs);
1498 let rx = detect_extreme_expr(cx, normalized_rhs);
1503 (Some(l @ ExtremeExpr { which: Maximum, .. }), _) => (l, AlwaysFalse), // max < x
1504 (_, Some(r @ ExtremeExpr { which: Minimum, .. })) => (r, AlwaysFalse), // x < min
1510 (Some(l @ ExtremeExpr { which: Minimum, .. }), _) => (l, AlwaysTrue), // min <= x
1511 (Some(l @ ExtremeExpr { which: Maximum, .. }), _) => (l, InequalityImpossible), // max <= x
1512 (_, Some(r @ ExtremeExpr { which: Minimum, .. })) => (r, InequalityImpossible), // x <= min
1513 (_, Some(r @ ExtremeExpr { which: Maximum, .. })) => (r, AlwaysTrue), // x <= max
1517 Rel::Ne | Rel::Eq => return None,
1521 fn detect_extreme_expr<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) -> Option<ExtremeExpr<'tcx>> {
1522 use crate::types::ExtremeType::*;
1524 let ty = cx.tables.expr_ty(expr);
1526 let cv = constant(cx, cx.tables, expr)?.0;
1528 let which = match (&ty.sty, cv) {
1529 (&ty::Bool, Constant::Bool(false)) | (&ty::Uint(_), Constant::Int(0)) => Minimum,
1530 (&ty::Int(ity), Constant::Int(i))
1531 if i == unsext(cx.tcx, i128::min_value() >> (128 - int_bits(cx.tcx, ity)), ity) =>
1536 (&ty::Bool, Constant::Bool(true)) => Maximum,
1537 (&ty::Int(ity), Constant::Int(i))
1538 if i == unsext(cx.tcx, i128::max_value() >> (128 - int_bits(cx.tcx, ity)), ity) =>
1542 (&ty::Uint(uty), Constant::Int(i)) if clip(cx.tcx, u128::max_value(), uty) == i => Maximum,
1546 Some(ExtremeExpr { which, expr })
1549 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AbsurdExtremeComparisons {
1550 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
1551 use crate::types::AbsurdComparisonResult::*;
1552 use crate::types::ExtremeType::*;
1554 if let ExprKind::Binary(ref cmp, ref lhs, ref rhs) = expr.node {
1555 if let Some((culprit, result)) = detect_absurd_comparison(cx, cmp.node, lhs, rhs) {
1556 if !in_macro(expr.span) {
1557 let msg = "this comparison involving the minimum or maximum element for this \
1558 type contains a case that is always true or always false";
1560 let conclusion = match result {
1561 AlwaysFalse => "this comparison is always false".to_owned(),
1562 AlwaysTrue => "this comparison is always true".to_owned(),
1563 InequalityImpossible => format!(
1564 "the case where the two sides are not equal never occurs, consider using {} == {} \
1566 snippet(cx, lhs.span, "lhs"),
1567 snippet(cx, rhs.span, "rhs")
1572 "because {} is the {} value for this type, {}",
1573 snippet(cx, culprit.expr.span, "x"),
1574 match culprit.which {
1575 Minimum => "minimum",
1576 Maximum => "maximum",
1581 span_help_and_lint(cx, ABSURD_EXTREME_COMPARISONS, expr.span, msg, &help);
1588 /// **What it does:** Checks for comparisons where the relation is always either
1589 /// true or false, but where one side has been upcast so that the comparison is
1590 /// necessary. Only integer types are checked.
1592 /// **Why is this bad?** An expression like `let x : u8 = ...; (x as u32) > 300`
1593 /// will mistakenly imply that it is possible for `x` to be outside the range of
1596 /// **Known problems:**
1597 /// https://github.com/rust-lang/rust-clippy/issues/886
1601 /// let x : u8 = ...; (x as u32) > 300
1603 declare_clippy_lint! {
1604 pub INVALID_UPCAST_COMPARISONS,
1606 "a comparison involving an upcast which is always true or false"
1609 pub struct InvalidUpcastComparisons;
1611 impl LintPass for InvalidUpcastComparisons {
1612 fn get_lints(&self) -> LintArray {
1613 lint_array!(INVALID_UPCAST_COMPARISONS)
1617 #[derive(Copy, Clone, Debug, Eq)]
1624 #[allow(clippy::cast_sign_loss)]
1625 fn cmp_s_u(s: i128, u: u128) -> Ordering {
1628 } else if u > (i128::max_value() as u128) {
1636 impl PartialEq for FullInt {
1637 fn eq(&self, other: &Self) -> bool {
1638 self.partial_cmp(other).expect("partial_cmp only returns Some(_)") == Ordering::Equal
1642 impl PartialOrd for FullInt {
1643 fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
1644 Some(match (self, other) {
1645 (&FullInt::S(s), &FullInt::S(o)) => s.cmp(&o),
1646 (&FullInt::U(s), &FullInt::U(o)) => s.cmp(&o),
1647 (&FullInt::S(s), &FullInt::U(o)) => Self::cmp_s_u(s, o),
1648 (&FullInt::U(s), &FullInt::S(o)) => Self::cmp_s_u(o, s).reverse(),
1652 impl Ord for FullInt {
1653 fn cmp(&self, other: &Self) -> Ordering {
1654 self.partial_cmp(other)
1655 .expect("partial_cmp for FullInt can never return None")
1659 fn numeric_cast_precast_bounds<'a>(cx: &LateContext<'_, '_>, expr: &'a Expr) -> Option<(FullInt, FullInt)> {
1660 use crate::syntax::ast::{IntTy, UintTy};
1663 if let ExprKind::Cast(ref cast_exp, _) = expr.node {
1664 let pre_cast_ty = cx.tables.expr_ty(cast_exp);
1665 let cast_ty = cx.tables.expr_ty(expr);
1666 // if it's a cast from i32 to u32 wrapping will invalidate all these checks
1667 if cx.layout_of(pre_cast_ty).ok().map(|l| l.size) == cx.layout_of(cast_ty).ok().map(|l| l.size) {
1670 match pre_cast_ty.sty {
1671 ty::Int(int_ty) => Some(match int_ty {
1673 FullInt::S(i128::from(i8::min_value())),
1674 FullInt::S(i128::from(i8::max_value())),
1677 FullInt::S(i128::from(i16::min_value())),
1678 FullInt::S(i128::from(i16::max_value())),
1681 FullInt::S(i128::from(i32::min_value())),
1682 FullInt::S(i128::from(i32::max_value())),
1685 FullInt::S(i128::from(i64::min_value())),
1686 FullInt::S(i128::from(i64::max_value())),
1688 IntTy::I128 => (FullInt::S(i128::min_value()), FullInt::S(i128::max_value())),
1690 FullInt::S(isize::min_value() as i128),
1691 FullInt::S(isize::max_value() as i128),
1694 ty::Uint(uint_ty) => Some(match uint_ty {
1696 FullInt::U(u128::from(u8::min_value())),
1697 FullInt::U(u128::from(u8::max_value())),
1700 FullInt::U(u128::from(u16::min_value())),
1701 FullInt::U(u128::from(u16::max_value())),
1704 FullInt::U(u128::from(u32::min_value())),
1705 FullInt::U(u128::from(u32::max_value())),
1708 FullInt::U(u128::from(u64::min_value())),
1709 FullInt::U(u128::from(u64::max_value())),
1711 UintTy::U128 => (FullInt::U(u128::min_value()), FullInt::U(u128::max_value())),
1713 FullInt::U(usize::min_value() as u128),
1714 FullInt::U(usize::max_value() as u128),
1724 fn node_as_const_fullint<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) -> Option<FullInt> {
1725 let val = constant(cx, cx.tables, expr)?.0;
1726 if let Constant::Int(const_int) = val {
1727 match cx.tables.expr_ty(expr).sty {
1728 ty::Int(ity) => Some(FullInt::S(sext(cx.tcx, const_int, ity))),
1729 ty::Uint(_) => Some(FullInt::U(const_int)),
1737 fn err_upcast_comparison(cx: &LateContext<'_, '_>, span: Span, expr: &Expr, always: bool) {
1738 if let ExprKind::Cast(ref cast_val, _) = expr.node {
1741 INVALID_UPCAST_COMPARISONS,
1744 "because of the numeric bounds on `{}` prior to casting, this expression is always {}",
1745 snippet(cx, cast_val.span, "the expression"),
1746 if always { "true" } else { "false" },
1752 fn upcast_comparison_bounds_err<'a, 'tcx>(
1753 cx: &LateContext<'a, 'tcx>,
1755 rel: comparisons::Rel,
1756 lhs_bounds: Option<(FullInt, FullInt)>,
1761 use crate::utils::comparisons::*;
1763 if let Some((lb, ub)) = lhs_bounds {
1764 if let Some(norm_rhs_val) = node_as_const_fullint(cx, rhs) {
1765 if rel == Rel::Eq || rel == Rel::Ne {
1766 if norm_rhs_val < lb || norm_rhs_val > ub {
1767 err_upcast_comparison(cx, span, lhs, rel == Rel::Ne);
1769 } else if match rel {
1784 Rel::Eq | Rel::Ne => unreachable!(),
1786 err_upcast_comparison(cx, span, lhs, true)
1787 } else if match rel {
1802 Rel::Eq | Rel::Ne => unreachable!(),
1804 err_upcast_comparison(cx, span, lhs, false)
1810 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for InvalidUpcastComparisons {
1811 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
1812 if let ExprKind::Binary(ref cmp, ref lhs, ref rhs) = expr.node {
1813 let normalized = comparisons::normalize_comparison(cmp.node, lhs, rhs);
1814 let (rel, normalized_lhs, normalized_rhs) = if let Some(val) = normalized {
1820 let lhs_bounds = numeric_cast_precast_bounds(cx, normalized_lhs);
1821 let rhs_bounds = numeric_cast_precast_bounds(cx, normalized_rhs);
1823 upcast_comparison_bounds_err(cx, expr.span, rel, lhs_bounds, normalized_lhs, normalized_rhs, false);
1824 upcast_comparison_bounds_err(cx, expr.span, rel, rhs_bounds, normalized_rhs, normalized_lhs, true);
1829 /// **What it does:** Checks for public `impl` or `fn` missing generalization
1830 /// over different hashers and implicitly defaulting to the default hashing
1831 /// algorithm (SipHash).
1833 /// **Why is this bad?** `HashMap` or `HashSet` with custom hashers cannot be
1836 /// **Known problems:** Suggestions for replacing constructors can contain
1837 /// false-positives. Also applying suggestions can require modification of other
1838 /// pieces of code, possibly including external crates.
1842 /// impl<K: Hash + Eq, V> Serialize for HashMap<K, V> { ... }
1844 /// pub foo(map: &mut HashMap<i32, i32>) { .. }
1846 declare_clippy_lint! {
1847 pub IMPLICIT_HASHER,
1849 "missing generalization over different hashers"
1852 pub struct ImplicitHasher;
1854 impl LintPass for ImplicitHasher {
1855 fn get_lints(&self) -> LintArray {
1856 lint_array!(IMPLICIT_HASHER)
1860 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for ImplicitHasher {
1861 #[allow(clippy::cast_possible_truncation)]
1862 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
1863 use crate::syntax_pos::BytePos;
1865 fn suggestion<'a, 'tcx>(
1866 cx: &LateContext<'a, 'tcx>,
1867 db: &mut DiagnosticBuilder<'_>,
1868 generics_span: Span,
1869 generics_suggestion_span: Span,
1870 target: &ImplicitHasherType<'_>,
1871 vis: ImplicitHasherConstructorVisitor<'_, '_, '_>,
1873 let generics_snip = snippet(cx, generics_span, "");
1875 let generics_snip = if generics_snip.is_empty() {
1878 &generics_snip[1..generics_snip.len() - 1]
1883 "consider adding a type parameter".to_string(),
1886 generics_suggestion_span,
1888 "<{}{}S: ::std::hash::BuildHasher{}>",
1890 if generics_snip.is_empty() { "" } else { ", " },
1891 if vis.suggestions.is_empty() {
1894 // request users to add `Default` bound so that generic constructors can be used
1901 format!("{}<{}, S>", target.type_name(), target.type_arguments(),),
1906 if !vis.suggestions.is_empty() {
1907 multispan_sugg(db, "...and use generic constructor".into(), vis.suggestions);
1911 if !cx.access_levels.is_exported(item.id) {
1916 ItemKind::Impl(_, _, _, ref generics, _, ref ty, ref items) => {
1917 let mut vis = ImplicitHasherTypeVisitor::new(cx);
1920 for target in &vis.found {
1921 if differing_macro_contexts(item.span, target.span()) {
1925 let generics_suggestion_span = generics.span.substitute_dummy({
1926 let pos = snippet_opt(cx, item.span.until(target.span()))
1927 .and_then(|snip| Some(item.span.lo() + BytePos(snip.find("impl")? as u32 + 4)));
1928 if let Some(pos) = pos {
1929 Span::new(pos, pos, item.span.data().ctxt)
1935 let mut ctr_vis = ImplicitHasherConstructorVisitor::new(cx, target);
1936 for item in items.iter().map(|item| cx.tcx.hir.impl_item(item.id)) {
1937 ctr_vis.visit_impl_item(item);
1945 "impl for `{}` should be generalized over different hashers",
1949 suggestion(cx, db, generics.span, generics_suggestion_span, target, ctr_vis);
1954 ItemKind::Fn(ref decl, .., ref generics, body_id) => {
1955 let body = cx.tcx.hir.body(body_id);
1957 for ty in &decl.inputs {
1958 let mut vis = ImplicitHasherTypeVisitor::new(cx);
1961 for target in &vis.found {
1962 let generics_suggestion_span = generics.span.substitute_dummy({
1963 let pos = snippet_opt(cx, item.span.until(body.arguments[0].pat.span))
1965 let i = snip.find("fn")?;
1966 Some(item.span.lo() + BytePos((i + (&snip[i..]).find('(')?) as u32))
1968 .expect("failed to create span for type parameters");
1969 Span::new(pos, pos, item.span.data().ctxt)
1972 let mut ctr_vis = ImplicitHasherConstructorVisitor::new(cx, target);
1973 ctr_vis.visit_body(body);
1980 "parameter of type `{}` should be generalized over different hashers",
1984 suggestion(cx, db, generics.span, generics_suggestion_span, target, ctr_vis);
1995 enum ImplicitHasherType<'tcx> {
1996 HashMap(Span, Ty<'tcx>, Cow<'static, str>, Cow<'static, str>),
1997 HashSet(Span, Ty<'tcx>, Cow<'static, str>),
2000 impl<'tcx> ImplicitHasherType<'tcx> {
2001 /// Checks that `ty` is a target type without a BuildHasher.
2002 fn new<'a>(cx: &LateContext<'a, 'tcx>, hir_ty: &hir::Ty) -> Option<Self> {
2003 if let TyKind::Path(QPath::Resolved(None, ref path)) = hir_ty.node {
2004 let params: Vec<_> = path
2012 .filter_map(|arg| match arg {
2013 GenericArg::Type(ty) => Some(ty),
2014 GenericArg::Lifetime(_) => None,
2017 let params_len = params.len();
2019 let ty = hir_ty_to_ty(cx.tcx, hir_ty);
2021 if match_path(path, &paths::HASHMAP) && params_len == 2 {
2022 Some(ImplicitHasherType::HashMap(
2025 snippet(cx, params[0].span, "K"),
2026 snippet(cx, params[1].span, "V"),
2028 } else if match_path(path, &paths::HASHSET) && params_len == 1 {
2029 Some(ImplicitHasherType::HashSet(
2032 snippet(cx, params[0].span, "T"),
2042 fn type_name(&self) -> &'static str {
2044 ImplicitHasherType::HashMap(..) => "HashMap",
2045 ImplicitHasherType::HashSet(..) => "HashSet",
2049 fn type_arguments(&self) -> String {
2051 ImplicitHasherType::HashMap(.., ref k, ref v) => format!("{}, {}", k, v),
2052 ImplicitHasherType::HashSet(.., ref t) => format!("{}", t),
2056 fn ty(&self) -> Ty<'tcx> {
2058 ImplicitHasherType::HashMap(_, ty, ..) | ImplicitHasherType::HashSet(_, ty, ..) => ty,
2062 fn span(&self) -> Span {
2064 ImplicitHasherType::HashMap(span, ..) | ImplicitHasherType::HashSet(span, ..) => span,
2069 struct ImplicitHasherTypeVisitor<'a, 'tcx: 'a> {
2070 cx: &'a LateContext<'a, 'tcx>,
2071 found: Vec<ImplicitHasherType<'tcx>>,
2074 impl<'a, 'tcx: 'a> ImplicitHasherTypeVisitor<'a, 'tcx> {
2075 fn new(cx: &'a LateContext<'a, 'tcx>) -> Self {
2076 Self { cx, found: vec![] }
2080 impl<'a, 'tcx: 'a> Visitor<'tcx> for ImplicitHasherTypeVisitor<'a, 'tcx> {
2081 fn visit_ty(&mut self, t: &'tcx hir::Ty) {
2082 if let Some(target) = ImplicitHasherType::new(self.cx, t) {
2083 self.found.push(target);
2089 fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
2090 NestedVisitorMap::None
2094 /// Looks for default-hasher-dependent constructors like `HashMap::new`.
2095 struct ImplicitHasherConstructorVisitor<'a, 'b, 'tcx: 'a + 'b> {
2096 cx: &'a LateContext<'a, 'tcx>,
2097 body: &'a TypeckTables<'tcx>,
2098 target: &'b ImplicitHasherType<'tcx>,
2099 suggestions: BTreeMap<Span, String>,
2102 impl<'a, 'b, 'tcx: 'a + 'b> ImplicitHasherConstructorVisitor<'a, 'b, 'tcx> {
2103 fn new(cx: &'a LateContext<'a, 'tcx>, target: &'b ImplicitHasherType<'tcx>) -> Self {
2108 suggestions: BTreeMap::new(),
2113 impl<'a, 'b, 'tcx: 'a + 'b> Visitor<'tcx> for ImplicitHasherConstructorVisitor<'a, 'b, 'tcx> {
2114 fn visit_body(&mut self, body: &'tcx Body) {
2115 self.body = self.cx.tcx.body_tables(body.id());
2116 walk_body(self, body);
2119 fn visit_expr(&mut self, e: &'tcx Expr) {
2121 if let ExprKind::Call(ref fun, ref args) = e.node;
2122 if let ExprKind::Path(QPath::TypeRelative(ref ty, ref method)) = fun.node;
2123 if let TyKind::Path(QPath::Resolved(None, ref ty_path)) = ty.node;
2125 if !same_tys(self.cx, self.target.ty(), self.body.expr_ty(e)) {
2129 if match_path(ty_path, &paths::HASHMAP) {
2130 if method.ident.name == "new" {
2132 .insert(e.span, "HashMap::default()".to_string());
2133 } else if method.ident.name == "with_capacity" {
2134 self.suggestions.insert(
2137 "HashMap::with_capacity_and_hasher({}, Default::default())",
2138 snippet(self.cx, args[0].span, "capacity"),
2142 } else if match_path(ty_path, &paths::HASHSET) {
2143 if method.ident.name == "new" {
2145 .insert(e.span, "HashSet::default()".to_string());
2146 } else if method.ident.name == "with_capacity" {
2147 self.suggestions.insert(
2150 "HashSet::with_capacity_and_hasher({}, Default::default())",
2151 snippet(self.cx, args[0].span, "capacity"),
2162 fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
2163 NestedVisitorMap::OnlyBodies(&self.cx.tcx.hir)