1 use clippy_utils::diagnostics::span_lint_and_note;
2 use clippy_utils::source::snippet;
3 use clippy_utils::visitors::is_local_used;
4 use rustc_data_structures::fx::FxHashMap;
5 use rustc_hir::def::Res;
6 use rustc_hir::def_id::LocalDefId;
7 use rustc_hir::hir_id::ItemLocalId;
8 use rustc_hir::{Block, Body, BodyOwnerKind, Expr, ExprKind, HirId, Let, Node, Pat, PatKind, QPath, UnOp};
9 use rustc_lint::{LateContext, LateLintPass};
10 use rustc_session::{declare_tool_lint, impl_lint_pass};
11 use rustc_span::{Span, Symbol};
13 declare_clippy_lint! {
15 /// Checks for bindings that shadow other bindings already in
16 /// scope, while just changing reference level or mutability.
18 /// ### Why is this bad?
19 /// Not much, in fact it's a very common pattern in Rust
20 /// code. Still, some may opt to avoid it in their code base, they can set this
32 /// let y = &x; // use different variable name
34 #[clippy::version = "pre 1.29.0"]
37 "rebinding a name to itself, e.g., `let mut x = &mut x`"
40 declare_clippy_lint! {
42 /// Checks for bindings that shadow other bindings already in
43 /// scope, while reusing the original value.
45 /// ### Why is this bad?
46 /// Not too much, in fact it's a common pattern in Rust
47 /// code. Still, some argue that name shadowing like this hurts readability,
48 /// because a value may be bound to different things depending on position in
56 /// use different variable name:
61 #[clippy::version = "pre 1.29.0"]
64 "rebinding a name to an expression that re-uses the original value, e.g., `let x = x + 1`"
67 declare_clippy_lint! {
69 /// Checks for bindings that shadow other bindings already in
70 /// scope, either without an initialization or with one that does not even use
71 /// the original value.
73 /// ### Why is this bad?
74 /// Name shadowing can hurt readability, especially in
75 /// large code bases, because it is easy to lose track of the active binding at
76 /// any place in the code. This can be alleviated by either giving more specific
77 /// names to bindings or introducing more scopes to contain the bindings.
84 /// let x = z; // shadows the earlier binding
92 /// let w = z; // use different variable name
94 #[clippy::version = "pre 1.29.0"]
97 "rebinding a name without even using the original value"
101 pub(crate) struct Shadow {
102 bindings: Vec<FxHashMap<Symbol, Vec<ItemLocalId>>>,
105 impl_lint_pass!(Shadow => [SHADOW_SAME, SHADOW_REUSE, SHADOW_UNRELATED]);
107 impl<'tcx> LateLintPass<'tcx> for Shadow {
108 fn check_pat(&mut self, cx: &LateContext<'tcx>, pat: &'tcx Pat<'_>) {
109 let (id, ident) = match pat.kind {
110 PatKind::Binding(_, hir_id, ident, _) => (hir_id, ident),
114 if pat.span.desugaring_kind().is_some() {
118 if ident.span.from_expansion() || ident.span.is_dummy() {
122 let HirId { owner, local_id } = id;
123 // get (or insert) the list of items for this owner and symbol
124 let data = self.bindings.last_mut().unwrap();
125 let items_with_name = data.entry(ident.name).or_default();
127 // check other bindings with the same name, most recently seen first
128 for &prev in items_with_name.iter().rev() {
129 if prev == local_id {
130 // repeated binding in an `Or` pattern
134 if is_shadow(cx, owner, prev, local_id) {
135 let prev_hir_id = HirId { owner, local_id: prev };
136 lint_shadow(cx, pat, prev_hir_id, ident.span);
137 // only lint against the "nearest" shadowed binding
142 items_with_name.push(local_id);
145 fn check_body(&mut self, cx: &LateContext<'_>, body: &Body<'_>) {
146 let hir = cx.tcx.hir();
148 hir.body_owner_kind(hir.body_owner_def_id(body.id())),
149 BodyOwnerKind::Closure
151 self.bindings.push(FxHashMap::default());
155 fn check_body_post(&mut self, cx: &LateContext<'_>, body: &Body<'_>) {
156 let hir = cx.tcx.hir();
158 hir.body_owner_kind(hir.body_owner_def_id(body.id())),
159 BodyOwnerKind::Closure
166 fn is_shadow(cx: &LateContext<'_>, owner: LocalDefId, first: ItemLocalId, second: ItemLocalId) -> bool {
167 let scope_tree = cx.tcx.region_scope_tree(owner.to_def_id());
168 if let Some(first_scope) = scope_tree.var_scope(first) {
169 if let Some(second_scope) = scope_tree.var_scope(second) {
170 return scope_tree.is_subscope_of(second_scope, first_scope);
177 fn lint_shadow(cx: &LateContext<'_>, pat: &Pat<'_>, shadowed: HirId, span: Span) {
178 let (lint, msg) = match find_init(cx, pat.hir_id) {
179 Some(expr) if is_self_shadow(cx, pat, expr, shadowed) => {
181 "`{}` is shadowed by itself in `{}`",
182 snippet(cx, pat.span, "_"),
183 snippet(cx, expr.span, "..")
187 Some(expr) if is_local_used(cx, expr, shadowed) => {
188 let msg = format!("`{}` is shadowed", snippet(cx, pat.span, "_"));
192 let msg = format!("`{}` shadows a previous, unrelated binding", snippet(cx, pat.span, "_"));
193 (SHADOW_UNRELATED, msg)
201 Some(cx.tcx.hir().span(shadowed)),
202 "previous binding is here",
206 /// Returns true if the expression is a simple transformation of a local binding such as `&x`
207 fn is_self_shadow(cx: &LateContext<'_>, pat: &Pat<'_>, mut expr: &Expr<'_>, hir_id: HirId) -> bool {
208 let hir = cx.tcx.hir();
209 let is_direct_binding = hir
210 .parent_iter(pat.hir_id)
211 .map_while(|(_id, node)| match node {
212 Node::Pat(pat) => Some(pat),
215 .all(|pat| matches!(pat.kind, PatKind::Ref(..) | PatKind::Or(_)));
216 if !is_direct_binding {
220 expr = match expr.kind {
222 | ExprKind::AddrOf(_, _, e)
231 | ExprKind::Unary(UnOp::Deref, e) => e,
232 ExprKind::Path(QPath::Resolved(None, path)) => break path.res == Res::Local(hir_id),
238 /// Finds the "init" expression for a pattern: `let <pat> = <init>;` (or `if let`) or
239 /// `match <init> { .., <pat> => .., .. }`
240 fn find_init<'tcx>(cx: &LateContext<'tcx>, hir_id: HirId) -> Option<&'tcx Expr<'tcx>> {
241 for (_, node) in cx.tcx.hir().parent_iter(hir_id) {
242 let init = match node {
243 Node::Arm(_) | Node::Pat(_) => continue,
244 Node::Expr(expr) => match expr.kind {
245 ExprKind::Match(e, _, _) | ExprKind::Let(&Let { init: e, .. }) => Some(e),
248 Node::Local(local) => local.init,