1 use clippy_utils::diagnostics::span_lint;
2 use clippy_utils::{get_trait_def_id, paths};
3 use rustc_hir::{Impl, Item, ItemKind};
4 use rustc_lint::{LateContext, LateLintPass};
5 use rustc_session::{declare_lint_pass, declare_tool_lint};
9 /// Checks for mis-uses of the serde API.
11 /// ### Why is this bad?
12 /// Serde is very finnicky about how its API should be
13 /// used, but the type system can't be used to enforce it (yet?).
16 /// Implementing `Visitor::visit_string` but not
17 /// `Visitor::visit_str`.
18 #[clippy::version = "pre 1.29.0"]
21 "various things that will negatively affect your serde experience"
24 declare_lint_pass!(SerdeApi => [SERDE_API_MISUSE]);
26 impl<'tcx> LateLintPass<'tcx> for SerdeApi {
27 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx Item<'_>) {
28 if let ItemKind::Impl(Impl {
29 of_trait: Some(ref trait_ref),
34 let did = trait_ref.path.res.def_id();
35 if let Some(visit_did) = get_trait_def_id(cx, &paths::SERDE_DE_VISITOR) {
37 let mut seen_str = None;
38 let mut seen_string = None;
40 match item.ident.as_str() {
41 "visit_str" => seen_str = Some(item.span),
42 "visit_string" => seen_string = Some(item.span),
46 if let Some(span) = seen_string {
47 if seen_str.is_none() {
52 "you should not implement `visit_string` without also implementing `visit_str`",