1 use clippy_utils::diagnostics::span_lint_and_help;
2 use rustc_ast::ast::{Block, Expr, ExprKind, Stmt, StmtKind};
3 use rustc_ast::visit::{walk_expr, Visitor};
4 use rustc_lint::{EarlyContext, EarlyLintPass};
5 use rustc_middle::lint::in_external_macro;
6 use rustc_session::{declare_lint_pass, declare_tool_lint};
10 /// Checks for `else` blocks that can be removed without changing semantics.
12 /// ### Why is this bad?
13 /// The `else` block adds unnecessary indentation and verbosity.
15 /// ### Known problems
16 /// Some may prefer to keep the `else` block for clarity.
20 /// fn my_func(count: u32) {
22 /// print!("Nothing to do");
25 /// print!("Moving on...");
31 /// fn my_func(count: u32) {
33 /// print!("Nothing to do");
36 /// print!("Moving on...");
41 "`else` branch that can be removed without changing semantics"
44 declare_lint_pass!(RedundantElse => [REDUNDANT_ELSE]);
46 impl EarlyLintPass for RedundantElse {
47 fn check_stmt(&mut self, cx: &EarlyContext<'_>, stmt: &Stmt) {
48 if in_external_macro(cx.sess, stmt.span) {
51 // Only look at expressions that are a whole statement
52 let expr: &Expr = match &stmt.kind {
53 StmtKind::Expr(expr) | StmtKind::Semi(expr) => expr,
57 let (mut then, mut els): (&Block, &Expr) = match &expr.kind {
58 ExprKind::If(_, then, Some(els)) => (then, els),
62 if !BreakVisitor::default().check_block(then) {
63 // then block does not always break
68 ExprKind::If(_, next_then, Some(next_els)) => {
73 // else if without else
74 ExprKind::If(..) => return,
83 "redundant else block",
85 "remove the `else` block and move the contents out",
90 /// Call `check` functions to check if an expression always breaks control flow
96 impl<'ast> Visitor<'ast> for BreakVisitor {
97 fn visit_block(&mut self, block: &'ast Block) {
98 self.is_break = match block.stmts.as_slice() {
99 [.., last] => self.check_stmt(last),
104 fn visit_expr(&mut self, expr: &'ast Expr) {
105 self.is_break = match expr.kind {
106 ExprKind::Break(..) | ExprKind::Continue(..) | ExprKind::Ret(..) => true,
107 ExprKind::Match(_, ref arms) => arms.iter().all(|arm| self.check_expr(&arm.body)),
108 ExprKind::If(_, ref then, Some(ref els)) => self.check_block(then) && self.check_expr(els),
109 ExprKind::If(_, _, None)
110 // ignore loops for simplicity
111 | ExprKind::While(..) | ExprKind::ForLoop(..) | ExprKind::Loop(..) => false,
113 walk_expr(self, expr);
121 fn check<T>(&mut self, item: T, visit: fn(&mut Self, T)) -> bool {
123 std::mem::replace(&mut self.is_break, false)
126 fn check_block(&mut self, block: &Block) -> bool {
127 self.check(block, Self::visit_block)
130 fn check_expr(&mut self, expr: &Expr) -> bool {
131 self.check(expr, Self::visit_expr)
134 fn check_stmt(&mut self, stmt: &Stmt) -> bool {
135 self.check(stmt, Self::visit_stmt)