clippy_lints/src/redundant_closure_call.rs

   1 use clippy_utils::diagnostics::{span_lint, span_lint_and_then};
   2 use clippy_utils::source::snippet_with_applicability;
   3 use if_chain::if_chain;
   4 use rustc_ast::ast;
   5 use rustc_ast::visit as ast_visit;
   6 use rustc_ast::visit::Visitor as AstVisitor;
   7 use rustc_errors::Applicability;
   8 use rustc_hir as hir;
   9 use rustc_hir::intravisit as hir_visit;
  10 use rustc_hir::intravisit::Visitor as HirVisitor;
  11 use rustc_lint::{EarlyContext, EarlyLintPass, LateContext, LateLintPass};
  12 use rustc_middle::hir::nested_filter;
  13 use rustc_middle::lint::in_external_macro;
  14 use rustc_session::{declare_lint_pass, declare_tool_lint};
  15
  16 declare_clippy_lint! {
  17     /// ### What it does
  18     /// Detects closures called in the same expression where they
  19     /// are defined.
  20     ///
  21     /// ### Why is this bad?
  22     /// It is unnecessarily adding to the expression's
  23     /// complexity.
  24     ///
  25     /// ### Example
  26     /// ```rust,ignore
  27     /// // Bad
  28     /// let a = (|| 42)()
  29     ///
  30     /// // Good
  31     /// let a = 42
  32     /// ```
  33     #[clippy::version = "pre 1.29.0"]
  34     pub REDUNDANT_CLOSURE_CALL,
  35     complexity,
  36     "throwaway closures called in the expression they are defined"
  37 }
  38
  39 declare_lint_pass!(RedundantClosureCall => [REDUNDANT_CLOSURE_CALL]);
  40
  41 // Used to find `return` statements or equivalents e.g., `?`
  42 struct ReturnVisitor {
  43     found_return: bool,
  44 }
  45
  46 impl ReturnVisitor {
  47     #[must_use]
  48     fn new() -> Self {
  49         Self { found_return: false }
  50     }
  51 }
  52
  53 impl<'ast> ast_visit::Visitor<'ast> for ReturnVisitor {
  54     fn visit_expr(&mut self, ex: &'ast ast::Expr) {
  55         if let ast::ExprKind::Ret(_) | ast::ExprKind::Try(_) = ex.kind {
  56             self.found_return = true;
  57         }
  58
  59         ast_visit::walk_expr(self, ex);
  60     }
  61 }
  62
  63 impl EarlyLintPass for RedundantClosureCall {
  64     fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &ast::Expr) {
  65         if in_external_macro(cx.sess, expr.span) {
  66             return;
  67         }
  68         if_chain! {
  69             if let ast::ExprKind::Call(ref paren, _) = expr.kind;
  70             if let ast::ExprKind::Paren(ref closure) = paren.kind;
  71             if let ast::ExprKind::Closure(_, _, _, ref decl, ref block, _) = closure.kind;
  72             then {
  73                 let mut visitor = ReturnVisitor::new();
  74                 visitor.visit_expr(block);
  75                 if !visitor.found_return {
  76                     span_lint_and_then(
  77                         cx,
  78                         REDUNDANT_CLOSURE_CALL,
  79                         expr.span,
  80                         "try not to call a closure in the expression where it is declared",
  81                         |diag| {
  82                             if decl.inputs.is_empty() {
  83                                 let mut app = Applicability::MachineApplicable;
  84                                 let hint =
  85                                     snippet_with_applicability(cx, block.span, "..", &mut app).into_owned();
  86                                 diag.span_suggestion(expr.span, "try doing something like", hint, app);
  87                             }
  88                         },
  89                     );
  90                 }
  91             }
  92         }
  93     }
  94 }
  95
  96 impl<'tcx> LateLintPass<'tcx> for RedundantClosureCall {
  97     fn check_block(&mut self, cx: &LateContext<'tcx>, block: &'tcx hir::Block<'_>) {
  98         fn count_closure_usage<'a, 'tcx>(
  99             cx: &'a LateContext<'tcx>,
 100             block: &'tcx hir::Block<'_>,
 101             path: &'tcx hir::Path<'tcx>,
 102         ) -> usize {
 103             struct ClosureUsageCount<'a, 'tcx> {
 104                 cx: &'a LateContext<'tcx>,
 105                 path: &'tcx hir::Path<'tcx>,
 106                 count: usize,
 107             }
 108             impl<'a, 'tcx> hir_visit::Visitor<'tcx> for ClosureUsageCount<'a, 'tcx> {
 109                 type NestedFilter = nested_filter::OnlyBodies;
 110
 111                 fn visit_expr(&mut self, expr: &'tcx hir::Expr<'tcx>) {
 112                     if_chain! {
 113                         if let hir::ExprKind::Call(closure, _) = expr.kind;
 114                         if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = closure.kind;
 115                         if self.path.segments[0].ident == path.segments[0].ident;
 116                         if self.path.res == path.res;
 117                         then {
 118                             self.count += 1;
 119                         }
 120                     }
 121                     hir_visit::walk_expr(self, expr);
 122                 }
 123
 124                 fn nested_visit_map(&mut self) -> Self::Map {
 125                     self.cx.tcx.hir()
 126                 }
 127             }
 128             let mut closure_usage_count = ClosureUsageCount { cx, path, count: 0 };
 129             closure_usage_count.visit_block(block);
 130             closure_usage_count.count
 131         }
 132
 133         for w in block.stmts.windows(2) {
 134             if_chain! {
 135                 if let hir::StmtKind::Local(local) = w[0].kind;
 136                 if let Option::Some(t) = local.init;
 137                 if let hir::ExprKind::Closure(..) = t.kind;
 138                 if let hir::PatKind::Binding(_, _, ident, _) = local.pat.kind;
 139                 if let hir::StmtKind::Semi(second) = w[1].kind;
 140                 if let hir::ExprKind::Assign(_, call, _) = second.kind;
 141                 if let hir::ExprKind::Call(closure, _) = call.kind;
 142                 if let hir::ExprKind::Path(hir::QPath::Resolved(_, path)) = closure.kind;
 143                 if ident == path.segments[0].ident;
 144                 if count_closure_usage(cx, block, path) == 1;
 145                 then {
 146                     span_lint(
 147                         cx,
 148                         REDUNDANT_CLOSURE_CALL,
 149                         second.span,
 150                         "closure called just once immediately after it was declared",
 151                     );
 152                 }
 153             }
 154         }
 155     }
 156 }