2 fn_has_unsatisfiable_preds, has_drop, is_copy, match_def_path, match_type, paths, snippet_opt, span_lint_hir,
3 span_lint_hir_and_then, walk_ptrs_ty_depth,
5 use if_chain::if_chain;
9 visit::{MutatingUseContext, PlaceContext, Visitor as _},
11 use rustc::ty::{self, fold::TypeVisitor, Ty};
12 use rustc_data_structures::{fx::FxHashMap, transitive_relation::TransitiveRelation};
13 use rustc_errors::Applicability;
14 use rustc_hir::intravisit::FnKind;
15 use rustc_hir::{def_id, Body, FnDecl, HirId};
16 use rustc_index::bit_set::{BitSet, HybridBitSet};
17 use rustc_lint::{LateContext, LateLintPass};
18 use rustc_mir::dataflow::generic::{Analysis, AnalysisDomain, GenKill, GenKillAnalysis, ResultsCursor};
19 use rustc_mir::dataflow::BottomValue;
20 use rustc_session::{declare_lint_pass, declare_tool_lint};
21 use rustc_span::source_map::{BytePos, Span};
22 use std::convert::TryFrom;
24 macro_rules! unwrap_or_continue {
33 declare_clippy_lint! {
34 /// **What it does:** Checks for a redundant `clone()` (and its relatives) which clones an owned
35 /// value that is going to be dropped without further use.
37 /// **Why is this bad?** It is not always possible for the compiler to eliminate useless
38 /// allocations and deallocations generated by redundant `clone()`s.
40 /// **Known problems:**
42 /// False-negatives: analysis performed by this lint is conservative and limited.
46 /// # use std::path::Path;
47 /// # #[derive(Clone)]
50 /// # fn new() -> Self { Foo {} }
52 /// # fn call(x: Foo) {}
54 /// let x = Foo::new();
56 /// call(x.clone()); // this can just pass `x`
59 /// ["lorem", "ipsum"].join(" ").to_string();
61 /// Path::new("/a/b").join("c").to_path_buf();
65 "`clone()` of an owned value that is going to be dropped immediately"
68 declare_lint_pass!(RedundantClone => [REDUNDANT_CLONE]);
70 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for RedundantClone {
71 #[allow(clippy::too_many_lines)]
74 cx: &LateContext<'a, 'tcx>,
81 let def_id = cx.tcx.hir().body_owner_def_id(body.id());
83 // Building MIR for `fn`s with unsatisfiable preds results in ICE.
84 if fn_has_unsatisfiable_preds(cx, def_id) {
88 let mir = cx.tcx.optimized_mir(def_id);
89 let mir_read_only = mir.unwrap_read_only();
91 let maybe_storage_live_result = MaybeStorageLive
92 .into_engine(cx.tcx, mir, def_id)
93 .iterate_to_fixpoint()
94 .into_results_cursor(mir);
95 let mut possible_borrower = {
96 let mut vis = PossibleBorrowerVisitor::new(cx, mir);
97 vis.visit_body(mir_read_only);
98 vis.into_map(cx, maybe_storage_live_result)
101 for (bb, bbdata) in mir.basic_blocks().iter_enumerated() {
102 let terminator = bbdata.terminator();
104 if terminator.source_info.span.from_expansion() {
109 if terminator.successors().any(|s| *s == bb) {
113 let (fn_def_id, arg, arg_ty, _) = unwrap_or_continue!(is_call_with_ref_arg(cx, mir, &terminator.kind));
115 let from_borrow = match_def_path(cx, fn_def_id, &paths::CLONE_TRAIT_METHOD)
116 || match_def_path(cx, fn_def_id, &paths::TO_OWNED_METHOD)
117 || (match_def_path(cx, fn_def_id, &paths::TO_STRING_METHOD) && match_type(cx, arg_ty, &paths::STRING));
119 let from_deref = !from_borrow
120 && (match_def_path(cx, fn_def_id, &paths::PATH_TO_PATH_BUF)
121 || match_def_path(cx, fn_def_id, &paths::OS_STR_TO_OS_STRING));
123 if !from_borrow && !from_deref {
127 // `{ cloned = &arg; clone(move cloned); }` or `{ cloned = &arg; to_path_buf(cloned); }`
128 let (cloned, cannot_move_out) = unwrap_or_continue!(find_stmt_assigns_to(cx, mir, arg, from_borrow, bb));
130 let loc = mir::Location {
132 statement_index: bbdata.statements.len(),
136 let local = if from_borrow {
137 // `res = clone(arg)` can be turned into `res = move arg;`
138 // if `arg` is the only borrow of `cloned` at this point.
140 if cannot_move_out || !possible_borrower.only_borrowers(&[arg], cloned, loc) {
146 // `arg` is a reference as it is `.deref()`ed in the previous block.
147 // Look into the predecessor block and find out the source of deref.
149 let ps = mir_read_only.predecessors_for(bb);
153 let pred_terminator = mir[ps[0]].terminator();
155 // receiver of the `deref()` call
156 let pred_arg = if_chain! {
157 if let Some((pred_fn_def_id, pred_arg, pred_arg_ty, Some(res))) =
158 is_call_with_ref_arg(cx, mir, &pred_terminator.kind);
159 if res.local == cloned;
160 if match_def_path(cx, pred_fn_def_id, &paths::DEREF_TRAIT_METHOD);
161 if match_type(cx, pred_arg_ty, &paths::PATH_BUF)
162 || match_type(cx, pred_arg_ty, &paths::OS_STRING);
170 let (local, cannot_move_out) =
171 unwrap_or_continue!(find_stmt_assigns_to(cx, mir, pred_arg, true, ps[0]));
172 let loc = mir::Location {
174 statement_index: mir.basic_blocks()[bb].statements.len(),
177 // This can be turned into `res = move local` if `arg` and `cloned` are not borrowed
178 // at the last statement:
181 // pred_arg = &local;
182 // cloned = deref(pred_arg);
184 // StorageDead(pred_arg);
185 // res = to_path_buf(cloned);
187 if cannot_move_out || !possible_borrower.only_borrowers(&[arg, cloned], local, loc) {
194 // `local` cannot be moved out if it is used later
195 let used_later = traversal::ReversePostorder::new(&mir, bb).skip(1).any(|(tbb, tdata)| {
197 if tdata.terminator().successors().any(|s| *s == bb) {
201 let mut vis = LocalUseVisitor {
203 used_other_than_drop: false,
205 vis.visit_basic_block_data(tbb, tdata);
206 vis.used_other_than_drop
210 let span = terminator.source_info.span;
211 let scope = terminator.source_info.scope;
212 let node = mir.source_scopes[scope]
215 .assert_crate_local()
219 if let Some(snip) = snippet_opt(cx, span);
220 if let Some(dot) = snip.rfind('.');
222 let sugg_span = span.with_lo(
223 span.lo() + BytePos(u32::try_from(dot).unwrap())
225 let mut app = Applicability::MaybeIncorrect;
227 let mut call_snip = &snip[dot + 1..];
228 // Machine applicable when `call_snip` looks like `foobar()`
229 if call_snip.ends_with("()") {
230 call_snip = call_snip[..call_snip.len()-2].trim();
231 if call_snip.as_bytes().iter().all(|b| b.is_ascii_alphabetic() || *b == b'_') {
232 app = Applicability::MachineApplicable;
236 span_lint_hir_and_then(cx, REDUNDANT_CLONE, node, sugg_span, "redundant clone", |db| {
244 span.with_hi(span.lo() + BytePos(u32::try_from(dot).unwrap())),
245 "this value is dropped without further use",
249 span_lint_hir(cx, REDUNDANT_CLONE, node, span, "redundant clone");
257 /// If `kind` is `y = func(x: &T)` where `T: !Copy`, returns `(DefId of func, x, T, y)`.
258 fn is_call_with_ref_arg<'tcx>(
259 cx: &LateContext<'_, 'tcx>,
260 mir: &'tcx mir::Body<'tcx>,
261 kind: &'tcx mir::TerminatorKind<'tcx>,
262 ) -> Option<(def_id::DefId, mir::Local, Ty<'tcx>, Option<&'tcx mir::Place<'tcx>>)> {
264 if let mir::TerminatorKind::Call { func, args, destination, .. } = kind;
266 if let mir::Operand::Move(mir::Place { local, .. }) = &args[0];
267 if let ty::FnDef(def_id, _) = func.ty(&*mir, cx.tcx).kind;
268 if let (inner_ty, 1) = walk_ptrs_ty_depth(args[0].ty(&*mir, cx.tcx));
269 if !is_copy(cx, inner_ty);
271 Some((def_id, *local, inner_ty, destination.as_ref().map(|(dest, _)| dest)))
278 type CannotMoveOut = bool;
280 /// Finds the first `to = (&)from`, and returns
281 /// ``Some((from, whether `from` cannot be moved out))``.
282 fn find_stmt_assigns_to<'tcx>(
283 cx: &LateContext<'_, 'tcx>,
284 mir: &mir::Body<'tcx>,
285 to_local: mir::Local,
288 ) -> Option<(mir::Local, CannotMoveOut)> {
289 let rvalue = mir.basic_blocks()[bb].statements.iter().rev().find_map(|stmt| {
290 if let mir::StatementKind::Assign(box (mir::Place { local, .. }, v)) = &stmt.kind {
291 return if *local == to_local { Some(v) } else { None };
297 match (by_ref, &*rvalue) {
298 (true, mir::Rvalue::Ref(_, _, place)) | (false, mir::Rvalue::Use(mir::Operand::Copy(place))) => {
299 base_local_and_movability(cx, mir, *place)
301 (false, mir::Rvalue::Ref(_, _, place)) => {
302 if let [mir::ProjectionElem::Deref] = place.as_ref().projection {
303 base_local_and_movability(cx, mir, *place)
312 /// Extracts and returns the undermost base `Local` of given `place`. Returns `place` itself
313 /// if it is already a `Local`.
315 /// Also reports whether given `place` cannot be moved out.
316 fn base_local_and_movability<'tcx>(
317 cx: &LateContext<'_, 'tcx>,
318 mir: &mir::Body<'tcx>,
319 place: mir::Place<'tcx>,
320 ) -> Option<(mir::Local, CannotMoveOut)> {
321 use rustc::mir::PlaceRef;
323 // Dereference. You cannot move things out from a borrowed value.
324 let mut deref = false;
325 // Accessing a field of an ADT that has `Drop`. Moving the field out will cause E0509.
326 let mut field = false;
328 let PlaceRef { local, mut projection } = place.as_ref();
329 while let [base @ .., elem] = projection {
331 deref |= matches!(elem, mir::ProjectionElem::Deref);
332 field |= matches!(elem, mir::ProjectionElem::Field(..))
333 && has_drop(cx, mir::Place::ty_from(local, projection, &mir.local_decls, cx.tcx).ty);
336 Some((local, deref || field))
339 struct LocalUseVisitor {
341 used_other_than_drop: bool,
344 impl<'tcx> mir::visit::Visitor<'tcx> for LocalUseVisitor {
345 fn visit_basic_block_data(&mut self, block: mir::BasicBlock, data: &mir::BasicBlockData<'tcx>) {
346 let statements = &data.statements;
347 for (statement_index, statement) in statements.iter().enumerate() {
348 self.visit_statement(statement, mir::Location { block, statement_index });
350 // Once flagged, skip remaining statements
351 if self.used_other_than_drop {
356 self.visit_terminator(
360 statement_index: statements.len(),
365 fn visit_local(&mut self, local: &mir::Local, ctx: PlaceContext, _: mir::Location) {
367 PlaceContext::MutatingUse(MutatingUseContext::Drop) | PlaceContext::NonUse(_) => return,
371 if *local == self.local {
372 self.used_other_than_drop = true;
377 /// Determines liveness of each local purely based on `StorageLive`/`Dead`.
378 #[derive(Copy, Clone)]
379 struct MaybeStorageLive;
381 impl<'tcx> AnalysisDomain<'tcx> for MaybeStorageLive {
382 type Idx = mir::Local;
383 const NAME: &'static str = "maybe_storage_live";
385 fn bits_per_block(&self, body: &mir::Body<'tcx>) -> usize {
386 body.local_decls.len()
389 fn initialize_start_block(&self, body: &mir::Body<'tcx>, state: &mut BitSet<Self::Idx>) {
390 for arg in body.args_iter() {
396 impl<'tcx> GenKillAnalysis<'tcx> for MaybeStorageLive {
397 fn statement_effect(&self, trans: &mut impl GenKill<Self::Idx>, stmt: &mir::Statement<'tcx>, _: mir::Location) {
399 mir::StatementKind::StorageLive(l) => trans.gen(l),
400 mir::StatementKind::StorageDead(l) => trans.kill(l),
405 fn terminator_effect(
407 _trans: &mut impl GenKill<Self::Idx>,
408 _terminator: &mir::Terminator<'tcx>,
413 fn call_return_effect(
415 _in_out: &mut impl GenKill<Self::Idx>,
416 _block: mir::BasicBlock,
417 _func: &mir::Operand<'tcx>,
418 _args: &[mir::Operand<'tcx>],
419 _return_place: &mir::Place<'tcx>,
421 // Nothing to do when a call returns successfully
425 impl BottomValue for MaybeStorageLive {
427 const BOTTOM_VALUE: bool = false;
430 /// Collects the possible borrowers of each local.
431 /// For example, `b = &a; c = &a;` will make `b` and (transitively) `c`
432 /// possible borrowers of `a`.
433 struct PossibleBorrowerVisitor<'a, 'tcx> {
434 possible_borrower: TransitiveRelation<mir::Local>,
435 body: &'a mir::Body<'tcx>,
436 cx: &'a LateContext<'a, 'tcx>,
439 impl<'a, 'tcx> PossibleBorrowerVisitor<'a, 'tcx> {
440 fn new(cx: &'a LateContext<'a, 'tcx>, body: &'a mir::Body<'tcx>) -> Self {
442 possible_borrower: TransitiveRelation::default(),
450 cx: &LateContext<'a, 'tcx>,
451 maybe_live: ResultsCursor<'tcx, 'tcx, MaybeStorageLive>,
452 ) -> PossibleBorrowerMap<'a, 'tcx> {
453 let mut map = FxHashMap::default();
454 for row in (1..self.body.local_decls.len()).map(mir::Local::from_usize) {
455 if is_copy(cx, self.body.local_decls[row].ty) {
459 let borrowers = self.possible_borrower.reachable_from(&row);
460 if !borrowers.is_empty() {
461 let mut bs = HybridBitSet::new_empty(self.body.local_decls.len());
462 for &c in borrowers {
463 if c != mir::Local::from_usize(0) {
474 let bs = BitSet::new_empty(self.body.local_decls.len());
475 PossibleBorrowerMap {
478 bitset: (bs.clone(), bs),
483 impl<'a, 'tcx> mir::visit::Visitor<'tcx> for PossibleBorrowerVisitor<'a, 'tcx> {
484 fn visit_assign(&mut self, place: &mir::Place<'tcx>, rvalue: &mir::Rvalue<'_>, _location: mir::Location) {
485 let lhs = place.local;
487 mir::Rvalue::Ref(_, _, borrowed) => {
488 self.possible_borrower.add(borrowed.local, lhs);
491 if !ContainsRegion.visit_ty(place.ty(&self.body.local_decls, self.cx.tcx).ty) {
494 rvalue_locals(other, |rhs| {
496 self.possible_borrower.add(rhs, lhs);
503 fn visit_terminator(&mut self, terminator: &mir::Terminator<'_>, _loc: mir::Location) {
504 if let mir::TerminatorKind::Call {
506 destination: Some((mir::Place { local: dest, .. }, _)),
510 // If the call returns something with lifetimes,
511 // let's conservatively assume the returned value contains lifetime of all the arguments.
512 // For example, given `let y: Foo<'a> = foo(x)`, `y` is considered to be a possible borrower of `x`.
513 if !ContainsRegion.visit_ty(&self.body.local_decls[*dest].ty) {
519 mir::Operand::Copy(p) | mir::Operand::Move(p) => {
520 self.possible_borrower.add(p.local, *dest);
529 struct ContainsRegion;
531 impl TypeVisitor<'_> for ContainsRegion {
532 fn visit_region(&mut self, _: ty::Region<'_>) -> bool {
537 fn rvalue_locals(rvalue: &mir::Rvalue<'_>, mut visit: impl FnMut(mir::Local)) {
538 use rustc::mir::Rvalue::{Aggregate, BinaryOp, Cast, CheckedBinaryOp, Repeat, UnaryOp, Use};
540 let mut visit_op = |op: &mir::Operand<'_>| match op {
541 mir::Operand::Copy(p) | mir::Operand::Move(p) => visit(p.local),
546 Use(op) | Repeat(op, _) | Cast(_, op, _) | UnaryOp(_, op) => visit_op(op),
547 Aggregate(_, ops) => ops.iter().for_each(visit_op),
548 BinaryOp(_, lhs, rhs) | CheckedBinaryOp(_, lhs, rhs) => {
556 /// Result of `PossibleBorrowerVisitor`.
557 struct PossibleBorrowerMap<'a, 'tcx> {
558 /// Mapping `Local -> its possible borrowers`
559 map: FxHashMap<mir::Local, HybridBitSet<mir::Local>>,
560 maybe_live: ResultsCursor<'a, 'tcx, MaybeStorageLive>,
561 // Caches to avoid allocation of `BitSet` on every query
562 bitset: (BitSet<mir::Local>, BitSet<mir::Local>),
565 impl PossibleBorrowerMap<'_, '_> {
566 /// Returns true if the set of borrowers of `borrowed` living at `at` matches with `borrowers`.
567 fn only_borrowers(&mut self, borrowers: &[mir::Local], borrowed: mir::Local, at: mir::Location) -> bool {
568 self.maybe_live.seek_after(at);
570 self.bitset.0.clear();
571 let maybe_live = &mut self.maybe_live;
572 if let Some(bitset) = self.map.get(&borrowed) {
573 for b in bitset.iter().filter(move |b| maybe_live.contains(*b)) {
574 self.bitset.0.insert(b);
580 self.bitset.1.clear();
582 self.bitset.1.insert(*b);
585 self.bitset.0 == self.bitset.1