1 use crate::consts::{constant, Constant};
2 use clippy_utils::diagnostics::{span_lint, span_lint_and_sugg, span_lint_and_then};
3 use clippy_utils::source::{snippet, snippet_opt, snippet_with_applicability};
4 use if_chain::if_chain;
5 use rustc_ast::ast::RangeLimits;
6 use rustc_errors::Applicability;
7 use rustc_hir::{BinOpKind, Expr, ExprKind, PathSegment, QPath};
8 use rustc_lint::{LateContext, LateLintPass, LintContext};
10 use rustc_semver::RustcVersion;
11 use rustc_session::{declare_tool_lint, impl_lint_pass};
12 use rustc_span::source_map::{Span, Spanned};
14 use rustc_span::symbol::Ident;
15 use std::cmp::Ordering;
17 use crate::utils::sugg::Sugg;
18 use crate::utils::{get_parent_expr, in_constant, is_integer_const, meets_msrv, single_segment_path};
19 use crate::utils::{higher, SpanlessEq};
21 declare_clippy_lint! {
22 /// **What it does:** Checks for zipping a collection with the range of
25 /// **Why is this bad?** The code is better expressed with `.enumerate()`.
27 /// **Known problems:** None.
31 /// # let x = vec![1];
32 /// x.iter().zip(0..x.len());
34 /// Could be written as
36 /// # let x = vec![1];
37 /// x.iter().enumerate();
39 pub RANGE_ZIP_WITH_LEN,
41 "zipping iterator with a range when `enumerate()` would do"
44 declare_clippy_lint! {
45 /// **What it does:** Checks for exclusive ranges where 1 is added to the
46 /// upper bound, e.g., `x..(y+1)`.
48 /// **Why is this bad?** The code is more readable with an inclusive range
51 /// **Known problems:** Will add unnecessary pair of parentheses when the
52 /// expression is not wrapped in a pair but starts with a opening parenthesis
53 /// and ends with a closing one.
54 /// I.e., `let _ = (f()+1)..(f()+1)` results in `let _ = ((f()+1)..=f())`.
56 /// Also in many cases, inclusive ranges are still slower to run than
57 /// exclusive ranges, because they essentially add an extra branch that
58 /// LLVM may fail to hoist out of the loop.
60 /// This will cause a warning that cannot be fixed if the consumer of the
61 /// range only accepts a specific range type, instead of the generic
62 /// `RangeBounds` trait
63 /// ([#3307](https://github.com/rust-lang/rust-clippy/issues/3307)).
67 /// for x..(y+1) { .. }
69 /// Could be written as
75 "`x..(y+1)` reads better as `x..=y`"
78 declare_clippy_lint! {
79 /// **What it does:** Checks for inclusive ranges where 1 is subtracted from
80 /// the upper bound, e.g., `x..=(y-1)`.
82 /// **Why is this bad?** The code is more readable with an exclusive range
85 /// **Known problems:** This will cause a warning that cannot be fixed if
86 /// the consumer of the range only accepts a specific range type, instead of
87 /// the generic `RangeBounds` trait
88 /// ([#3307](https://github.com/rust-lang/rust-clippy/issues/3307)).
92 /// for x..=(y-1) { .. }
94 /// Could be written as
100 "`x..=(y-1)` reads better as `x..y`"
103 declare_clippy_lint! {
104 /// **What it does:** Checks for range expressions `x..y` where both `x` and `y`
105 /// are constant and `x` is greater or equal to `y`.
107 /// **Why is this bad?** Empty ranges yield no values so iterating them is a no-op.
108 /// Moreover, trying to use a reversed range to index a slice will panic at run-time.
110 /// **Known problems:** None.
116 /// (10..=0).for_each(|x| println!("{}", x));
118 /// let arr = [1, 2, 3, 4, 5];
119 /// let sub = &arr[3..1];
125 /// (0..=10).rev().for_each(|x| println!("{}", x));
127 /// let arr = [1, 2, 3, 4, 5];
128 /// let sub = &arr[1..3];
131 pub REVERSED_EMPTY_RANGES,
133 "reversing the limits of range expressions, resulting in empty ranges"
136 declare_clippy_lint! {
137 /// **What it does:** Checks for expressions like `x >= 3 && x < 8` that could
138 /// be more readably expressed as `(3..8).contains(x)`.
140 /// **Why is this bad?** `contains` expresses the intent better and has less
141 /// failure modes (such as fencepost errors or using `||` instead of `&&`).
143 /// **Known problems:** None.
151 /// assert!(x >= 3 && x < 8);
156 /// assert!((3..8).contains(&x));
158 pub MANUAL_RANGE_CONTAINS,
160 "manually reimplementing {`Range`, `RangeInclusive`}`::contains`"
163 const MANUAL_RANGE_CONTAINS_MSRV: RustcVersion = RustcVersion::new(1, 35, 0);
166 msrv: Option<RustcVersion>,
171 pub fn new(msrv: Option<RustcVersion>) -> Self {
176 impl_lint_pass!(Ranges => [
180 REVERSED_EMPTY_RANGES,
181 MANUAL_RANGE_CONTAINS,
184 impl<'tcx> LateLintPass<'tcx> for Ranges {
185 fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
187 ExprKind::MethodCall(ref path, _, ref args, _) => {
188 check_range_zip_with_len(cx, path, args, expr.span);
190 ExprKind::Binary(ref op, ref l, ref r) => {
191 if meets_msrv(self.msrv.as_ref(), &MANUAL_RANGE_CONTAINS_MSRV) {
192 check_possible_range_contains(cx, op.node, l, r, expr);
198 check_exclusive_range_plus_one(cx, expr);
199 check_inclusive_range_minus_one(cx, expr);
200 check_reversed_empty_range(cx, expr);
202 extract_msrv_attr!(LateContext);
205 fn check_possible_range_contains(cx: &LateContext<'_>, op: BinOpKind, l: &Expr<'_>, r: &Expr<'_>, expr: &Expr<'_>) {
206 if in_constant(cx, expr.hir_id) {
210 let span = expr.span;
211 let combine_and = match op {
212 BinOpKind::And | BinOpKind::BitAnd => true,
213 BinOpKind::Or | BinOpKind::BitOr => false,
216 // value, name, order (higher/lower), inclusiveness
217 if let (Some((lval, lname, name_span, lval_span, lord, linc)), Some((rval, rname, _, rval_span, rord, rinc))) =
218 (check_range_bounds(cx, l), check_range_bounds(cx, r))
220 // we only lint comparisons on the same name and with different
222 if lname != rname || lord == rord {
225 let ord = Constant::partial_cmp(cx.tcx, cx.typeck_results().expr_ty(l), &lval, &rval);
226 if combine_and && ord == Some(rord) {
227 // order lower bound and upper bound
228 let (l_span, u_span, l_inc, u_inc) = if rord == Ordering::Less {
229 (lval_span, rval_span, linc, rinc)
231 (rval_span, lval_span, rinc, linc)
233 // we only lint inclusive lower bounds
237 let (range_type, range_op) = if u_inc {
238 ("RangeInclusive", "..=")
242 let mut applicability = Applicability::MachineApplicable;
243 let name = snippet_with_applicability(cx, name_span, "_", &mut applicability);
244 let lo = snippet_with_applicability(cx, l_span, "_", &mut applicability);
245 let hi = snippet_with_applicability(cx, u_span, "_", &mut applicability);
246 let space = if lo.ends_with('.') { " " } else { "" };
249 MANUAL_RANGE_CONTAINS,
251 &format!("manual `{}::contains` implementation", range_type),
253 format!("({}{}{}{}).contains(&{})", lo, space, range_op, hi, name),
256 } else if !combine_and && ord == Some(lord) {
258 // order lower bound and upper bound
259 let (l_span, u_span, l_inc, u_inc) = if lord == Ordering::Less {
260 (lval_span, rval_span, linc, rinc)
262 (rval_span, lval_span, rinc, linc)
267 let (range_type, range_op) = if u_inc {
270 ("RangeInclusive", "..=")
272 let mut applicability = Applicability::MachineApplicable;
273 let name = snippet_with_applicability(cx, name_span, "_", &mut applicability);
274 let lo = snippet_with_applicability(cx, l_span, "_", &mut applicability);
275 let hi = snippet_with_applicability(cx, u_span, "_", &mut applicability);
276 let space = if lo.ends_with('.') { " " } else { "" };
279 MANUAL_RANGE_CONTAINS,
281 &format!("manual `!{}::contains` implementation", range_type),
283 format!("!({}{}{}{}).contains(&{})", lo, space, range_op, hi, name),
290 fn check_range_bounds(cx: &LateContext<'_>, ex: &Expr<'_>) -> Option<(Constant, Ident, Span, Span, Ordering, bool)> {
291 if let ExprKind::Binary(ref op, ref l, ref r) = ex.kind {
292 let (inclusive, ordering) = match op.node {
293 BinOpKind::Gt => (false, Ordering::Greater),
294 BinOpKind::Ge => (true, Ordering::Greater),
295 BinOpKind::Lt => (false, Ordering::Less),
296 BinOpKind::Le => (true, Ordering::Less),
299 if let Some(id) = match_ident(l) {
300 if let Some((c, _)) = constant(cx, cx.typeck_results(), r) {
301 return Some((c, id, l.span, r.span, ordering, inclusive));
303 } else if let Some(id) = match_ident(r) {
304 if let Some((c, _)) = constant(cx, cx.typeck_results(), l) {
305 return Some((c, id, r.span, l.span, ordering.reverse(), inclusive));
312 fn match_ident(e: &Expr<'_>) -> Option<Ident> {
313 if let ExprKind::Path(ref qpath) = e.kind {
314 if let Some(seg) = single_segment_path(qpath) {
315 if seg.args.is_none() {
316 return Some(seg.ident);
323 fn check_range_zip_with_len(cx: &LateContext<'_>, path: &PathSegment<'_>, args: &[Expr<'_>], span: Span) {
324 let name = path.ident.as_str();
325 if name == "zip" && args.len() == 2 {
326 let iter = &args[0].kind;
327 let zip_arg = &args[1];
330 if let ExprKind::MethodCall(ref iter_path, _, ref iter_args, _) = *iter;
331 if iter_path.ident.name == sym::iter;
332 // range expression in `.zip()` call: `0..x.len()`
333 if let Some(higher::Range { start: Some(start), end: Some(end), .. }) = higher::range(zip_arg);
334 if is_integer_const(cx, start, 0);
336 if let ExprKind::MethodCall(ref len_path, _, ref len_args, _) = end.kind;
337 if len_path.ident.name == sym!(len) && len_args.len() == 1;
338 // `.iter()` and `.len()` called on same `Path`
339 if let ExprKind::Path(QPath::Resolved(_, ref iter_path)) = iter_args[0].kind;
340 if let ExprKind::Path(QPath::Resolved(_, ref len_path)) = len_args[0].kind;
341 if SpanlessEq::new(cx).eq_path_segments(&iter_path.segments, &len_path.segments);
346 &format!("it is more idiomatic to use `{}.iter().enumerate()`",
347 snippet(cx, iter_args[0].span, "_"))
354 // exclusive range plus one: `x..(y+1)`
355 fn check_exclusive_range_plus_one(cx: &LateContext<'_>, expr: &Expr<'_>) {
357 if let Some(higher::Range {
360 limits: RangeLimits::HalfOpen
361 }) = higher::range(expr);
362 if let Some(y) = y_plus_one(cx, end);
364 let span = if expr.span.from_expansion() {
376 "an inclusive range would be more readable",
378 let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
379 let end = Sugg::hir(cx, y, "y");
380 if let Some(is_wrapped) = &snippet_opt(cx, span) {
381 if is_wrapped.starts_with('(') && is_wrapped.ends_with(')') {
382 diag.span_suggestion(
385 format!("({}..={})", start, end),
386 Applicability::MaybeIncorrect,
389 diag.span_suggestion(
392 format!("{}..={}", start, end),
393 Applicability::MachineApplicable, // snippet
403 // inclusive range minus one: `x..=(y-1)`
404 fn check_inclusive_range_minus_one(cx: &LateContext<'_>, expr: &Expr<'_>) {
406 if let Some(higher::Range { start, end: Some(end), limits: RangeLimits::Closed }) = higher::range(expr);
407 if let Some(y) = y_minus_one(cx, end);
413 "an exclusive range would be more readable",
415 let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
416 let end = Sugg::hir(cx, y, "y");
417 diag.span_suggestion(
420 format!("{}..{}", start, end),
421 Applicability::MachineApplicable, // snippet
429 fn check_reversed_empty_range(cx: &LateContext<'_>, expr: &Expr<'_>) {
430 fn inside_indexing_expr(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
432 get_parent_expr(cx, expr),
434 kind: ExprKind::Index(..),
440 fn is_for_loop_arg(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
441 let mut cur_expr = expr;
442 while let Some(parent_expr) = get_parent_expr(cx, cur_expr) {
443 match higher::for_loop(parent_expr) {
444 Some((_, args, _, _)) if args.hir_id == expr.hir_id => return true,
445 _ => cur_expr = parent_expr,
452 fn is_empty_range(limits: RangeLimits, ordering: Ordering) -> bool {
454 RangeLimits::HalfOpen => ordering != Ordering::Less,
455 RangeLimits::Closed => ordering == Ordering::Greater,
460 if let Some(higher::Range { start: Some(start), end: Some(end), limits }) = higher::range(expr);
461 let ty = cx.typeck_results().expr_ty(start);
462 if let ty::Int(_) | ty::Uint(_) = ty.kind();
463 if let Some((start_idx, _)) = constant(cx, cx.typeck_results(), start);
464 if let Some((end_idx, _)) = constant(cx, cx.typeck_results(), end);
465 if let Some(ordering) = Constant::partial_cmp(cx.tcx, ty, &start_idx, &end_idx);
466 if is_empty_range(limits, ordering);
468 if inside_indexing_expr(cx, expr) {
469 // Avoid linting `N..N` as it has proven to be useful, see #5689 and #5628 ...
470 if ordering != Ordering::Equal {
473 REVERSED_EMPTY_RANGES,
475 "this range is reversed and using it to index a slice will panic at run-time",
478 // ... except in for loop arguments for backwards compatibility with `reverse_range_loop`
479 } else if ordering != Ordering::Equal || is_for_loop_arg(cx, expr) {
482 REVERSED_EMPTY_RANGES,
484 "this range is empty so it will yield no values",
486 if ordering != Ordering::Equal {
487 let start_snippet = snippet(cx, start.span, "_");
488 let end_snippet = snippet(cx, end.span, "_");
489 let dots = match limits {
490 RangeLimits::HalfOpen => "..",
491 RangeLimits::Closed => "..="
494 diag.span_suggestion(
496 "consider using the following if you are attempting to iterate over this \
498 format!("({}{}{}).rev()", end_snippet, dots, start_snippet),
499 Applicability::MaybeIncorrect,
509 fn y_plus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<'t>> {
513 node: BinOpKind::Add, ..
518 if is_integer_const(cx, lhs, 1) {
520 } else if is_integer_const(cx, rhs, 1) {
530 fn y_minus_one<'t>(cx: &LateContext<'_>, expr: &'t Expr<'_>) -> Option<&'t Expr<'t>> {
534 node: BinOpKind::Sub, ..
538 ) if is_integer_const(cx, rhs, 1) => Some(lhs),