1 //! Checks for usage of `&Vec[_]` and `&String`.
5 use rustc::hir::map::NodeItem;
9 use syntax::ast::NodeId;
10 use syntax::codemap::Span;
11 use syntax_pos::MultiSpan;
12 use crate::utils::{match_qpath, match_type, paths, snippet_opt, span_lint, span_lint_and_then, walk_ptrs_hir_ty};
13 use crate::utils::ptr::get_spans;
15 /// **What it does:** This lint checks for function arguments of type `&String`
16 /// or `&Vec` unless the references are mutable. It will also suggest you
17 /// replace `.clone()` calls with the appropriate `.to_owned()`/`to_string()`
20 /// **Why is this bad?** Requiring the argument to be of the specific size
21 /// makes the function less useful for no benefit; slices in the form of `&[T]`
22 /// or `&str` usually suffice and can be obtained from other types, too.
24 /// **Known problems:** The lint does not follow data. So if you have an
25 /// argument `x` and write `let y = x; y.clone()` the lint will not suggest
26 /// changing that `.clone()` to `.to_owned()`.
28 /// Other functions called from this function taking a `&String` or `&Vec`
29 /// argument may also fail to compile if you change the argument. Applying
30 /// this lint on them will fix the problem, but they may be in other crates.
32 /// Also there may be `fn(&Vec)`-typed references pointing to your function.
33 /// If you have them, you will get a compiler error after applying this lint's
34 /// suggestions. You then have the choice to undo your changes or change the
35 /// type of the reference.
37 /// Note that if the function is part of your public interface, there may be
38 /// other crates referencing it you may not be aware. Carefully deprecate the
39 /// function before applying the lint suggestions in this case.
43 /// fn foo(&Vec<u32>) { .. }
45 declare_clippy_lint! {
48 "fn arguments of the type `&Vec<...>` or `&String`, suggesting to use `&[...]` or `&str` \
49 instead, respectively"
52 /// **What it does:** This lint checks for equality comparisons with `ptr::null`
54 /// **Why is this bad?** It's easier and more readable to use the inherent
58 /// **Known problems:** None.
62 /// if x == ptr::null { .. }
64 declare_clippy_lint! {
67 "comparing a pointer to a null pointer, suggesting to use `.is_null()` instead."
70 /// **What it does:** This lint checks for functions that take immutable
71 /// references and return
74 /// **Why is this bad?** This is trivially unsound, as one can create two
75 /// mutable references
76 /// from the same (immutable!) source. This
77 /// [error](https://github.com/rust-lang/rust/issues/39465)
78 /// actually lead to an interim Rust release 1.15.1.
80 /// **Known problems:** To be on the conservative side, if there's at least one
82 /// with the output lifetime, this lint will not trigger. In practice, this
83 /// case is unlikely anyway.
87 /// fn foo(&Foo) -> &mut Bar { .. }
89 declare_clippy_lint! {
92 "fns that create mutable refs from immutable ref args"
95 #[derive(Copy, Clone)]
96 pub struct PointerPass;
98 impl LintPass for PointerPass {
99 fn get_lints(&self) -> LintArray {
100 lint_array!(PTR_ARG, CMP_NULL, MUT_FROM_REF)
104 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for PointerPass {
105 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
106 if let ItemFn(ref decl, _, _, body_id) = item.node {
107 check_fn(cx, decl, item.id, Some(body_id));
111 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx ImplItem) {
112 if let ImplItemKind::Method(ref sig, body_id) = item.node {
113 if let Some(NodeItem(it)) = cx.tcx.hir.find(cx.tcx.hir.get_parent(item.id)) {
114 if let ItemImpl(_, _, _, _, Some(_), _, _) = it.node {
115 return; // ignore trait impls
118 check_fn(cx, &sig.decl, item.id, Some(body_id));
122 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx TraitItem) {
123 if let TraitItemKind::Method(ref sig, ref trait_method) = item.node {
124 let body_id = if let TraitMethod::Provided(b) = *trait_method {
129 check_fn(cx, &sig.decl, item.id, body_id);
133 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
134 if let ExprBinary(ref op, ref l, ref r) = expr.node {
135 if (op.node == BiEq || op.node == BiNe) && (is_null_path(l) || is_null_path(r)) {
140 "Comparing with null is better expressed by the .is_null() method",
147 fn check_fn(cx: &LateContext, decl: &FnDecl, fn_id: NodeId, opt_body_id: Option<BodyId>) {
148 let fn_def_id = cx.tcx.hir.local_def_id(fn_id);
149 let sig = cx.tcx.fn_sig(fn_def_id);
150 let fn_ty = sig.skip_binder();
152 for (idx, (arg, ty)) in decl.inputs.iter().zip(fn_ty.inputs()).enumerate() {
159 if match_type(cx, ty, &paths::VEC) {
160 let mut ty_snippet = None;
162 if let TyPath(QPath::Resolved(_, ref path)) = walk_ptrs_hir_ty(arg).node;
163 if let Some(&PathSegment{args: Some(ref parameters), ..}) = path.segments.last();
164 if parameters.types.len() == 1;
166 ty_snippet = snippet_opt(cx, parameters.types[0].span);
169 if let Some(spans) = get_spans(cx, opt_body_id, idx, &[("clone", ".to_owned()")]) {
174 "writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used \
175 with non-Vec-based slices.",
177 if let Some(ref snippet) = ty_snippet {
178 db.span_suggestion(arg.span, "change this to", format!("&[{}]", snippet));
180 for (clonespan, suggestion) in spans {
183 &snippet_opt(cx, clonespan).map_or(
184 "change the call to".into(),
185 |x| Cow::Owned(format!("change `{}` to", x)),
193 } else if match_type(cx, ty, &paths::STRING) {
194 if let Some(spans) = get_spans(cx, opt_body_id, idx, &[("clone", ".to_string()"), ("as_str", "")]) {
199 "writing `&String` instead of `&str` involves a new object where a slice will do.",
201 db.span_suggestion(arg.span, "change this to", "&str".into());
202 for (clonespan, suggestion) in spans {
203 db.span_suggestion_short(
205 &snippet_opt(cx, clonespan).map_or(
206 "change the call to".into(),
207 |x| Cow::Owned(format!("change `{}` to", x)),
215 } else if match_type(cx, ty, &paths::COW) {
217 if let TyRptr(_, MutTy { ref ty, ..} ) = arg.node;
218 if let TyPath(ref path) = ty.node;
219 if let QPath::Resolved(None, ref pp) = *path;
220 if let [ref bx] = *pp.segments;
221 if let Some(ref params) = bx.args;
222 if !params.parenthesized;
223 if let [ref inner] = *params.types;
225 let replacement = snippet_opt(cx, inner.span);
226 if let Some(r) = replacement {
231 "using a reference to `Cow` is not recommended.",
233 db.span_suggestion(arg.span, "change this to", "&".to_owned() + &r);
243 if let FunctionRetTy::Return(ref ty) = decl.output {
244 if let Some((out, MutMutable, _)) = get_rptr_lm(ty) {
245 let mut immutables = vec![];
246 for (_, ref mutbl, ref argspan) in decl.inputs
248 .filter_map(|ty| get_rptr_lm(ty))
249 .filter(|&(lt, _, _)| lt.name == out.name)
251 if *mutbl == MutMutable {
254 immutables.push(*argspan);
256 if immutables.is_empty() {
259 span_lint_and_then(cx, MUT_FROM_REF, ty.span, "mutable borrow from immutable input(s)", |db| {
260 let ms = MultiSpan::from_spans(immutables);
261 db.span_note(ms, "immutable borrow here");
267 fn get_rptr_lm(ty: &Ty) -> Option<(&Lifetime, Mutability, Span)> {
268 if let Ty_::TyRptr(ref lt, ref m) = ty.node {
269 Some((lt, m.mutbl, ty.span))
275 fn is_null_path(expr: &Expr) -> bool {
276 if let ExprCall(ref pathexp, ref args) = expr.node {
278 if let ExprPath(ref path) = pathexp.node {
279 return match_qpath(path, &paths::PTR_NULL) || match_qpath(path, &paths::PTR_NULL_MUT);