6 use clippy_utils::{diagnostics::span_lint_and_help, in_macro, is_direct_expn_of, source::snippet_opt};
7 use if_chain::if_chain;
9 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
10 use rustc_lint::{EarlyContext, EarlyLintPass};
11 use rustc_session::{declare_tool_lint, impl_lint_pass};
13 use serde::{de, Deserialize};
15 declare_clippy_lint! {
16 /// **What it does:** Checks that common macros are used with consistent bracing.
18 /// **Why is this bad?** This is mostly a consistency lint although using () or []
19 /// doesn't give you a semicolon in item position, which can be unexpected.
21 /// **Known problems:**
33 pub NONSTANDARD_MACRO_BRACES,
35 "check consistent use of braces in macro"
38 const BRACES: &[(&str, &str)] = &[("(", ")"), ("{", "}"), ("[", "]")];
40 /// The (name, (open brace, close brace), source snippet)
41 type MacroInfo<'a> = (&'a str, &'a (String, String), String);
43 #[derive(Clone, Debug, Default)]
44 pub struct MacroBraces {
45 macro_braces: FxHashMap<String, (String, String)>,
46 done: FxHashSet<Span>,
50 pub fn new(conf: &FxHashSet<MacroMatcher>) -> Self {
51 let macro_braces = macro_braces(conf.clone());
54 done: FxHashSet::default(),
59 impl_lint_pass!(MacroBraces => [NONSTANDARD_MACRO_BRACES]);
61 impl EarlyLintPass for MacroBraces {
62 fn check_item(&mut self, cx: &EarlyContext<'_>, item: &ast::Item) {
63 if let Some((name, braces, snip)) = is_offending_macro(cx, item.span, self) {
64 let span = item.span.ctxt().outer_expn_data().call_site;
65 emit_help(cx, snip, braces, name, span);
66 self.done.insert(span);
70 fn check_stmt(&mut self, cx: &EarlyContext<'_>, stmt: &ast::Stmt) {
71 if let Some((name, braces, snip)) = is_offending_macro(cx, stmt.span, self) {
72 let span = stmt.span.ctxt().outer_expn_data().call_site;
73 emit_help(cx, snip, braces, name, span);
74 self.done.insert(span);
78 fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &ast::Expr) {
79 if let Some((name, braces, snip)) = is_offending_macro(cx, expr.span, self) {
80 let span = expr.span.ctxt().outer_expn_data().call_site;
81 emit_help(cx, snip, braces, name, span);
82 self.done.insert(span);
86 fn check_ty(&mut self, cx: &EarlyContext<'_>, ty: &ast::Ty) {
87 if let Some((name, braces, snip)) = is_offending_macro(cx, ty.span, self) {
88 let span = ty.span.ctxt().outer_expn_data().call_site;
89 emit_help(cx, snip, braces, name, span);
90 self.done.insert(span);
95 fn is_offending_macro<'a>(cx: &EarlyContext<'_>, span: Span, mac_braces: &'a MacroBraces) -> Option<MacroInfo<'a>> {
97 // Make sure we are only one level deep otherwise there are to many FP's
98 if in_macro(span) && !in_macro(span.ctxt().outer_expn_data().call_site);
99 if let Some((name, braces)) = find_matching_macro(span, &mac_braces.macro_braces);
100 if let Some(snip) = snippet_opt(cx, span.ctxt().outer_expn_data().call_site);
101 // we must check only invocation sites
102 // https://github.com/rust-lang/rust-clippy/issues/7422
103 if snip.starts_with(&format!("{}!", name));
104 // make formatting consistent
105 let c = snip.replace(" ", "");
106 if !c.starts_with(&format!("{}!{}", name, braces.0));
107 if !mac_braces.done.contains(&span.ctxt().outer_expn_data().call_site);
109 Some((name, braces, snip))
116 fn emit_help(cx: &EarlyContext<'_>, snip: String, braces: &(String, String), name: &str, span: Span) {
117 let with_space = &format!("! {}", braces.0);
118 let without_space = &format!("!{}", braces.0);
120 for b in BRACES.iter().filter(|b| b.0 != braces.0) {
121 help = help.replace(b.0, &braces.0).replace(b.1, &braces.1);
122 // Only `{` traditionally has space before the brace
123 if braces.0 != "{" && help.contains(with_space) {
124 help = help.replace(with_space, without_space);
125 } else if braces.0 == "{" && help.contains(without_space) {
126 help = help.replace(without_space, with_space);
131 NONSTANDARD_MACRO_BRACES,
133 &format!("use of irregular braces for `{}!` macro", name),
135 &format!("consider writing `{}`", help),
139 fn find_matching_macro(
141 braces: &FxHashMap<String, (String, String)>,
142 ) -> Option<(&String, &(String, String))> {
145 .find(|(macro_name, _)| is_direct_expn_of(span, macro_name).is_some())
148 fn macro_braces(conf: FxHashSet<MacroMatcher>) -> FxHashMap<String, (String, String)> {
149 let mut braces = vec![
188 .collect::<FxHashMap<_, _>>();
189 // We want users items to override any existing items
191 braces.insert(it.name, it.braces);
196 macro_rules! macro_matcher {
197 (name: $name:expr, braces: ($open:expr, $close:expr) $(,)?) => {
198 ($name.to_owned(), ($open.to_owned(), $close.to_owned()))
201 pub(crate) use macro_matcher;
203 #[derive(Clone, Debug)]
204 pub struct MacroMatcher {
206 braces: (String, String),
209 impl Hash for MacroMatcher {
210 fn hash<H: Hasher>(&self, state: &mut H) {
211 self.name.hash(state);
215 impl PartialEq for MacroMatcher {
216 fn eq(&self, other: &Self) -> bool {
217 self.name == other.name
220 impl Eq for MacroMatcher {}
222 impl<'de> Deserialize<'de> for MacroMatcher {
223 fn deserialize<D>(deser: D) -> Result<Self, D::Error>
225 D: de::Deserializer<'de>,
227 #[derive(Deserialize)]
228 #[serde(field_identifier, rename_all = "lowercase")]
234 impl<'de> de::Visitor<'de> for MacVisitor {
235 type Value = MacroMatcher;
237 fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
238 formatter.write_str("struct MacroMatcher")
241 fn visit_map<V>(self, mut map: V) -> Result<Self::Value, V::Error>
243 V: de::MapAccess<'de>,
246 let mut brace: Option<&str> = None;
247 while let Some(key) = map.next_key()? {
251 return Err(de::Error::duplicate_field("name"));
253 name = Some(map.next_value()?);
257 return Err(de::Error::duplicate_field("brace"));
259 brace = Some(map.next_value()?);
263 let name = name.ok_or_else(|| de::Error::missing_field("name"))?;
264 let brace = brace.ok_or_else(|| de::Error::missing_field("brace"))?;
269 .find(|b| b.0 == brace)
270 .map(|(o, c)| ((*o).to_owned(), (*c).to_owned()))
272 de::Error::custom(&format!("expected one of `(`, `{{`, `[` found `{}`", brace))
278 const FIELDS: &[&str] = &["name", "brace"];
279 deser.deserialize_struct("MacroMatcher", FIELDS, MacVisitor)