2 use syntax::codemap::Span;
3 use syntax::parse::token::InternedString;
6 use syntax::visit::{Visitor, walk_block, walk_pat, walk_expr};
7 use utils::{span_lint_and_then, in_macro, span_lint};
9 /// **What it does:** This lint warns about names that are very similar and thus confusing
11 /// **Why is this bad?** It's hard to distinguish between names that differ only by a single character
13 /// **Known problems:** None?
15 /// **Example:** `checked_exp` and `checked_expr`
19 "similarly named items and bindings"
22 /// **What it does:** This lint warns about having too many variables whose name consists of a single character
24 /// **Why is this bad?** It's hard to memorize what a variable means without a descriptive name.
26 /// **Known problems:** None?
28 /// **Example:** let (a, b, c, d, e, f, g) = (...);
30 pub MANY_SINGLE_CHAR_NAMES,
32 "too many single character bindings"
35 pub struct NonExpressiveNames {
36 pub max_single_char_names: u64,
39 impl LintPass for NonExpressiveNames {
40 fn get_lints(&self) -> LintArray {
41 lint_array!(SIMILAR_NAMES, MANY_SINGLE_CHAR_NAMES)
46 interned: InternedString,
49 whitelist: &'static [&'static str],
52 struct SimilarNamesLocalVisitor<'a, 'b: 'a> {
53 names: Vec<ExistingName>,
54 cx: &'a EarlyContext<'b>,
55 lint: &'a NonExpressiveNames,
56 single_char_names: Vec<char>,
59 // this list contains lists of names that are allowed to be similar
60 // the assumption is that no name is ever contained in multiple lists.
61 #[cfg_attr(rustfmt, rustfmt_skip)]
62 const WHITELIST: &'static [&'static [&'static str]] = &[
63 &["parsed", "parser"],
69 struct SimilarNamesNameVisitor<'a, 'b: 'a, 'c: 'b>(&'a mut SimilarNamesLocalVisitor<'b, 'c>);
71 impl<'v, 'a, 'b, 'c> Visitor<'v> for SimilarNamesNameVisitor<'a, 'b, 'c> {
72 fn visit_pat(&mut self, pat: &'v Pat) {
74 PatKind::Ident(_, id, _) => self.check_name(id.span, id.node.name),
75 PatKind::Struct(_, ref fields, _) => {
77 if !field.node.is_shorthand {
78 self.visit_pat(&field.node.pat);
82 _ => walk_pat(self, pat),
87 fn get_whitelist(interned_name: &str) -> Option<&'static [&'static str]> {
88 for &allow in WHITELIST {
89 if whitelisted(interned_name, allow) {
96 fn whitelisted(interned_name: &str, list: &[&str]) -> bool {
97 if list.iter().any(|&name| interned_name == name) {
102 if interned_name.chars().zip(name.chars()).all(|(l, r)| l == r) {
106 if interned_name.chars().rev().zip(name.chars().rev()).all(|(l, r)| l == r) {
113 impl<'a, 'b, 'c> SimilarNamesNameVisitor<'a, 'b, 'c> {
114 fn check_short_name(&mut self, c: char, span: Span) {
115 // make sure we ignore shadowing
116 if self.0.single_char_names.contains(&c) {
119 self.0.single_char_names.push(c);
120 if self.0.single_char_names.len() as u64 >= self.0.lint.max_single_char_names {
122 MANY_SINGLE_CHAR_NAMES,
124 &format!("{}th binding whose name is just one char", self.0.single_char_names.len()));
127 fn check_name(&mut self, span: Span, name: Name) {
128 if in_macro(self.0.cx, span) {
131 let interned_name = name.as_str();
132 if interned_name.chars().any(char::is_uppercase) {
135 let count = interned_name.chars().count();
138 let c = interned_name.chars().next().expect("already checked");
139 self.check_short_name(c, span);
143 for existing_name in &self.0.names {
144 if whitelisted(&interned_name, existing_name.whitelist) {
147 let mut split_at = None;
148 if existing_name.len > count {
149 if existing_name.len - count != 1 || levenstein_not_1(&interned_name, &existing_name.interned) {
152 } else if existing_name.len < count {
153 if count - existing_name.len != 1 || levenstein_not_1(&existing_name.interned, &interned_name) {
157 let mut interned_chars = interned_name.chars();
158 let mut existing_chars = existing_name.interned.chars();
159 let first_i = interned_chars.next().expect("we know we have at least one char");
160 let first_e = existing_chars.next().expect("we know we have at least one char");
161 let eq_or_numeric = |a: char, b: char| a == b || a.is_numeric() && b.is_numeric();
163 if eq_or_numeric(first_i, first_e) {
164 let last_i = interned_chars.next_back().expect("we know we have at least two chars");
165 let last_e = existing_chars.next_back().expect("we know we have at least two chars");
166 if eq_or_numeric(last_i, last_e) {
167 if interned_chars.zip(existing_chars).filter(|&(i, e)| !eq_or_numeric(i, e)).count() != 1 {
171 let second_last_i = interned_chars.next_back().expect("we know we have at least three chars");
172 let second_last_e = existing_chars.next_back().expect("we know we have at least three chars");
173 if !eq_or_numeric(second_last_i, second_last_e) || second_last_i == '_' ||
174 !interned_chars.zip(existing_chars).all(|(i, e)| eq_or_numeric(i, e)) {
175 // allowed similarity foo_x, foo_y
176 // or too many chars differ (foo_x, boo_y) or (foox, booy)
179 split_at = interned_name.char_indices().rev().next().map(|(i, _)| i);
182 let second_i = interned_chars.next().expect("we know we have at least two chars");
183 let second_e = existing_chars.next().expect("we know we have at least two chars");
184 if !eq_or_numeric(second_i, second_e) || second_i == '_' ||
185 !interned_chars.zip(existing_chars).all(|(i, e)| eq_or_numeric(i, e)) {
186 // allowed similarity x_foo, y_foo
187 // or too many chars differ (x_foo, y_boo) or (xfoo, yboo)
190 split_at = interned_name.chars().next().map(|c| c.len_utf8());
193 span_lint_and_then(self.0.cx,
196 "binding's name is too similar to existing binding",
198 diag.span_note(existing_name.span, "existing binding defined here");
199 if let Some(split) = split_at {
201 &format!("separate the discriminating character by an \
202 underscore like: `{}_{}`",
203 &interned_name[..split],
204 &interned_name[split..]));
209 self.0.names.push(ExistingName {
210 whitelist: get_whitelist(&interned_name).unwrap_or(&[]),
211 interned: interned_name,
218 impl<'a, 'b> SimilarNamesLocalVisitor<'a, 'b> {
219 /// ensure scoping rules work
220 fn apply<F: for<'c> Fn(&'c mut Self)>(&mut self, f: F) {
221 let n = self.names.len();
222 let single_char_count = self.single_char_names.len();
224 self.names.truncate(n);
225 self.single_char_names.truncate(single_char_count);
229 impl<'v, 'a, 'b> Visitor<'v> for SimilarNamesLocalVisitor<'a, 'b> {
230 fn visit_local(&mut self, local: &'v Local) {
231 if let Some(ref init) = local.init {
232 self.apply(|this| walk_expr(this, &**init));
234 // add the pattern after the expression because the bindings aren't available yet in the init expression
235 SimilarNamesNameVisitor(self).visit_pat(&*local.pat);
237 fn visit_block(&mut self, blk: &'v Block) {
238 self.apply(|this| walk_block(this, blk));
240 fn visit_arm(&mut self, arm: &'v Arm) {
242 // just go through the first pattern, as either all patterns bind the same bindings or rustc would have errored much earlier
243 SimilarNamesNameVisitor(this).visit_pat(&arm.pats[0]);
244 this.apply(|this| walk_expr(this, &arm.body));
247 fn visit_item(&mut self, _: &'v Item) {
248 // do not recurse into inner items
252 impl EarlyLintPass for NonExpressiveNames {
253 fn check_item(&mut self, cx: &EarlyContext, item: &Item) {
254 if let ItemKind::Fn(ref decl, _, _, _, _, ref blk) = item.node {
255 if !attr::contains_name(&item.attrs, "test") {
256 let mut visitor = SimilarNamesLocalVisitor {
260 single_char_names: Vec::new(),
262 // initialize with function arguments
263 for arg in &decl.inputs {
264 SimilarNamesNameVisitor(&mut visitor).visit_pat(&arg.pat);
266 // walk all other bindings
267 walk_block(&mut visitor, blk);
273 /// Precondition: `a_name.chars().count() < b_name.chars().count()`.
274 fn levenstein_not_1(a_name: &str, b_name: &str) -> bool {
275 debug_assert!(a_name.chars().count() < b_name.chars().count());
276 let mut a_chars = a_name.chars();
277 let mut b_chars = b_name.chars();
278 while let (Some(a), Some(b)) = (a_chars.next(), b_chars.next()) {
282 if let Some(b2) = b_chars.next() {
283 // check if there's just one character inserted
284 return a != b2 || a_chars.ne(b_chars);