clippy_lints/src/no_effect.rs

   1 use crate::utils::{has_drop, qpath_res, snippet_opt, span_lint, span_lint_and_sugg};
   2 use rustc::declare_lint_pass;
   3 use rustc::hir::def::{DefKind, Res};
   4 use rustc::hir::{BinOpKind, BlockCheckMode, Expr, ExprKind, Stmt, StmtKind, UnsafeSource};
   5 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
   6 use rustc_errors::Applicability;
   7 use rustc_session::declare_tool_lint;
   8 use std::ops::Deref;
   9
  10 declare_clippy_lint! {
  11     /// **What it does:** Checks for statements which have no effect.
  12     ///
  13     /// **Why is this bad?** Similar to dead code, these statements are actually
  14     /// executed. However, as they have no effect, all they do is make the code less
  15     /// readable.
  16     ///
  17     /// **Known problems:** None.
  18     ///
  19     /// **Example:**
  20     /// ```rust
  21     /// 0;
  22     /// ```
  23     pub NO_EFFECT,
  24     complexity,
  25     "statements with no effect"
  26 }
  27
  28 declare_clippy_lint! {
  29     /// **What it does:** Checks for expression statements that can be reduced to a
  30     /// sub-expression.
  31     ///
  32     /// **Why is this bad?** Expressions by themselves often have no side-effects.
  33     /// Having such expressions reduces readability.
  34     ///
  35     /// **Known problems:** None.
  36     ///
  37     /// **Example:**
  38     /// ```rust,ignore
  39     /// compute_array()[0];
  40     /// ```
  41     pub UNNECESSARY_OPERATION,
  42     complexity,
  43     "outer expressions with no effect"
  44 }
  45
  46 fn has_no_effect(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
  47     if expr.span.from_expansion() {
  48         return false;
  49     }
  50     match expr.kind {
  51         ExprKind::Lit(..) | ExprKind::Closure(..) => true,
  52         ExprKind::Path(..) => !has_drop(cx, cx.tables.expr_ty(expr)),
  53         ExprKind::Index(ref a, ref b) | ExprKind::Binary(_, ref a, ref b) => {
  54             has_no_effect(cx, a) && has_no_effect(cx, b)
  55         },
  56         ExprKind::Array(ref v) | ExprKind::Tup(ref v) => v.iter().all(|val| has_no_effect(cx, val)),
  57         ExprKind::Repeat(ref inner, _)
  58         | ExprKind::Cast(ref inner, _)
  59         | ExprKind::Type(ref inner, _)
  60         | ExprKind::Unary(_, ref inner)
  61         | ExprKind::Field(ref inner, _)
  62         | ExprKind::AddrOf(_, _, ref inner)
  63         | ExprKind::Box(ref inner) => has_no_effect(cx, inner),
  64         ExprKind::Struct(_, ref fields, ref base) => {
  65             !has_drop(cx, cx.tables.expr_ty(expr))
  66                 && fields.iter().all(|field| has_no_effect(cx, &field.expr))
  67                 && base.as_ref().map_or(true, |base| has_no_effect(cx, base))
  68         },
  69         ExprKind::Call(ref callee, ref args) => {
  70             if let ExprKind::Path(ref qpath) = callee.kind {
  71                 let res = qpath_res(cx, qpath, callee.hir_id);
  72                 match res {
  73                     Res::Def(DefKind::Struct, ..) | Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(..), _) => {
  74                         !has_drop(cx, cx.tables.expr_ty(expr)) && args.iter().all(|arg| has_no_effect(cx, arg))
  75                     },
  76                     _ => false,
  77                 }
  78             } else {
  79                 false
  80             }
  81         },
  82         ExprKind::Block(ref block, _) => {
  83             block.stmts.is_empty() && block.expr.as_ref().map_or(false, |expr| has_no_effect(cx, expr))
  84         },
  85         _ => false,
  86     }
  87 }
  88
  89 declare_lint_pass!(NoEffect => [NO_EFFECT, UNNECESSARY_OPERATION]);
  90
  91 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NoEffect {
  92     fn check_stmt(&mut self, cx: &LateContext<'a, 'tcx>, stmt: &'tcx Stmt) {
  93         if let StmtKind::Semi(ref expr) = stmt.kind {
  94             if has_no_effect(cx, expr) {
  95                 span_lint(cx, NO_EFFECT, stmt.span, "statement with no effect");
  96             } else if let Some(reduced) = reduce_expression(cx, expr) {
  97                 let mut snippet = String::new();
  98                 for e in reduced {
  99                     if e.span.from_expansion() {
 100                         return;
 101                     }
 102                     if let Some(snip) = snippet_opt(cx, e.span) {
 103                         snippet.push_str(&snip);
 104                         snippet.push(';');
 105                     } else {
 106                         return;
 107                     }
 108                 }
 109                 span_lint_and_sugg(
 110                     cx,
 111                     UNNECESSARY_OPERATION,
 112                     stmt.span,
 113                     "statement can be reduced",
 114                     "replace it with",
 115                     snippet,
 116                     Applicability::MachineApplicable,
 117                 );
 118             }
 119         }
 120     }
 121 }
 122
 123 fn reduce_expression<'a>(cx: &LateContext<'_, '_>, expr: &'a Expr) -> Option<Vec<&'a Expr>> {
 124     if expr.span.from_expansion() {
 125         return None;
 126     }
 127     match expr.kind {
 128         ExprKind::Index(ref a, ref b) => Some(vec![&**a, &**b]),
 129         ExprKind::Binary(ref binop, ref a, ref b) if binop.node != BinOpKind::And && binop.node != BinOpKind::Or => {
 130             Some(vec![&**a, &**b])
 131         },
 132         ExprKind::Array(ref v) | ExprKind::Tup(ref v) => Some(v.iter().collect()),
 133         ExprKind::Repeat(ref inner, _)
 134         | ExprKind::Cast(ref inner, _)
 135         | ExprKind::Type(ref inner, _)
 136         | ExprKind::Unary(_, ref inner)
 137         | ExprKind::Field(ref inner, _)
 138         | ExprKind::AddrOf(_, _, ref inner)
 139         | ExprKind::Box(ref inner) => reduce_expression(cx, inner).or_else(|| Some(vec![inner])),
 140         ExprKind::Struct(_, ref fields, ref base) => {
 141             if has_drop(cx, cx.tables.expr_ty(expr)) {
 142                 None
 143             } else {
 144                 Some(fields.iter().map(|f| &f.expr).chain(base).map(Deref::deref).collect())
 145             }
 146         },
 147         ExprKind::Call(ref callee, ref args) => {
 148             if let ExprKind::Path(ref qpath) = callee.kind {
 149                 let res = qpath_res(cx, qpath, callee.hir_id);
 150                 match res {
 151                     Res::Def(DefKind::Struct, ..) | Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(..), _)
 152                         if !has_drop(cx, cx.tables.expr_ty(expr)) =>
 153                     {
 154                         Some(args.iter().collect())
 155                     },
 156                     _ => None,
 157                 }
 158             } else {
 159                 None
 160             }
 161         },
 162         ExprKind::Block(ref block, _) => {
 163             if block.stmts.is_empty() {
 164                 block.expr.as_ref().and_then(|e| {
 165                     match block.rules {
 166                         BlockCheckMode::UnsafeBlock(UnsafeSource::UserProvided) => None,
 167                         BlockCheckMode::DefaultBlock => Some(vec![&**e]),
 168                         // in case of compiler-inserted signaling blocks
 169                         _ => reduce_expression(cx, e),
 170                     }
 171                 })
 172             } else {
 173                 None
 174             }
 175         },
 176         _ => None,
 177     }
 178 }