1 use clippy_utils::diagnostics::span_lint_hir_and_then;
2 use clippy_utils::return_ty;
3 use clippy_utils::source::snippet;
4 use clippy_utils::sugg::DiagnosticBuilderExt;
5 use if_chain::if_chain;
6 use rustc_errors::Applicability;
8 use rustc_hir::HirIdSet;
9 use rustc_lint::{LateContext, LateLintPass, LintContext};
10 use rustc_middle::lint::in_external_macro;
11 use rustc_session::{declare_tool_lint, impl_lint_pass};
14 declare_clippy_lint! {
16 /// Checks for public types with a `pub fn new() -> Self` method and no
18 /// [`Default`](https://doc.rust-lang.org/std/default/trait.Default.html).
20 /// ### Why is this bad?
21 /// The user might expect to be able to use
22 /// [`Default`](https://doc.rust-lang.org/std/default/trait.Default.html) as the
23 /// type can be constructed without arguments.
27 /// pub struct Foo(Bar);
30 /// pub fn new() -> Self {
36 /// To fix the lint, add a `Default` implementation that delegates to `new`:
39 /// pub struct Foo(Bar);
41 /// impl Default for Foo {
42 /// fn default() -> Self {
47 #[clippy::version = "pre 1.29.0"]
48 pub NEW_WITHOUT_DEFAULT,
50 "`pub fn new() -> Self` method without `Default` implementation"
53 #[derive(Clone, Default)]
54 pub struct NewWithoutDefault {
55 impling_types: Option<HirIdSet>,
58 impl_lint_pass!(NewWithoutDefault => [NEW_WITHOUT_DEFAULT]);
60 impl<'tcx> LateLintPass<'tcx> for NewWithoutDefault {
61 #[allow(clippy::too_many_lines)]
62 fn check_item(&mut self, cx: &LateContext<'tcx>, item: &'tcx hir::Item<'_>) {
63 if let hir::ItemKind::Impl(hir::Impl {
66 self_ty: impl_self_ty,
71 for assoc_item in items {
72 if assoc_item.kind == (hir::AssocItemKind::Fn { has_self: false }) {
73 let impl_item = cx.tcx.hir().impl_item(assoc_item.id);
74 if in_external_macro(cx.sess(), impl_item.span) {
77 if let hir::ImplItemKind::Fn(ref sig, _) = impl_item.kind {
78 let name = impl_item.ident.name;
79 let id = impl_item.hir_id();
80 if sig.header.constness == hir::Constness::Const {
81 // can't be implemented by default
84 if sig.header.unsafety == hir::Unsafety::Unsafe {
85 // can't be implemented for unsafe new
92 .any(|gen| matches!(gen.kind, hir::GenericParamKind::Type { .. }))
94 // when the result of `new()` depends on a type parameter we should not require
100 if sig.decl.inputs.is_empty();
102 if cx.access_levels.is_reachable(impl_item.def_id);
103 let self_def_id = cx.tcx.hir().get_parent_item(id);
104 let self_ty = cx.tcx.type_of(self_def_id);
105 if self_ty == return_ty(cx, id);
106 if let Some(default_trait_id) = cx.tcx.get_diagnostic_item(sym::Default);
108 if self.impling_types.is_none() {
109 let mut impls = HirIdSet::default();
110 cx.tcx.for_each_impl(default_trait_id, |d| {
111 if let Some(ty_def) = cx.tcx.type_of(d).ty_adt_def() {
112 if let Some(local_def_id) = ty_def.did.as_local() {
113 impls.insert(cx.tcx.hir().local_def_id_to_hir_id(local_def_id));
117 self.impling_types = Some(impls);
120 // Check if a Default implementation exists for the Self type, regardless of
123 if let Some(ref impling_types) = self.impling_types;
124 if let Some(self_def) = cx.tcx.type_of(self_def_id).ty_adt_def();
125 if let Some(self_local_did) = self_def.did.as_local();
126 let self_id = cx.tcx.hir().local_def_id_to_hir_id(self_local_did);
127 if impling_types.contains(&self_id);
133 let generics_sugg = snippet(cx, generics.span, "");
134 let self_ty_fmt = self_ty.to_string();
135 let self_type_snip = snippet(cx, impl_self_ty.span, &self_ty_fmt);
136 span_lint_hir_and_then(
142 "you should consider adding a `Default` implementation for `{}`",
146 diag.suggest_prepend_item(
150 &create_new_without_default_suggest_msg(&self_type_snip, &generics_sugg),
151 Applicability::MaybeIncorrect,
164 fn create_new_without_default_suggest_msg(self_type_snip: &str, generics_sugg: &str) -> String {
167 "impl{} Default for {} {{
168 fn default() -> Self {{
171 }}", generics_sugg, self_type_snip)