3 use rustc::{declare_lint, lint_array};
5 use crate::utils::{self, paths, span_lint, in_external_macro};
8 /// Checks for the usage of negated comparision operators on types which only implement
9 /// `PartialOrd` (e.g. `f64`).
11 /// **Why is this bad?**
12 /// These operators make it easy to forget that the underlying types actually allow not only three
13 /// potential Orderings (Less, Equal, Greater) but also a forth one (Uncomparable). Escpeccially if
14 /// the operator based comparision result is negated it is easy to miss that fact.
16 /// **Known problems:** None.
21 /// use core::cmp::Ordering;
25 /// let b = std::f64::NAN;
27 /// let _not_less_or_equal = !(a <= b);
31 /// let b = std::f64::NAN;
33 /// let _not_less_or_equal = match a.partial_cmp(&b) {
34 /// None | Some(Ordering::Greater) => true,
38 declare_clippy_lint! {
39 pub NEG_CMP_OP_ON_PARTIAL_ORD,
41 "The use of negated comparision operators on partially orded types may produce confusing code."
44 pub struct NoNegCompOpForPartialOrd;
46 impl LintPass for NoNegCompOpForPartialOrd {
47 fn get_lints(&self) -> LintArray {
48 lint_array!(NEG_CMP_OP_ON_PARTIAL_ORD)
52 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NoNegCompOpForPartialOrd {
54 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
57 if !in_external_macro(cx, expr.span);
58 if let ExprKind::Unary(UnOp::UnNot, ref inner) = expr.node;
59 if let ExprKind::Binary(ref op, ref left, _) = inner.node;
60 if let BinOpKind::Le | BinOpKind::Ge | BinOpKind::Lt | BinOpKind::Gt = op.node;
64 let ty = cx.tables.expr_ty(left);
66 let implements_ord = {
67 if let Some(id) = utils::get_trait_def_id(cx, &paths::ORD) {
68 utils::implements_trait(cx, ty, id, &[])
74 let implements_partial_ord = {
75 if let Some(id) = utils::get_trait_def_id(cx, &paths::PARTIAL_ORD) {
76 utils::implements_trait(cx, ty, id, &[])
82 if implements_partial_ord && !implements_ord {
85 NEG_CMP_OP_ON_PARTIAL_ORD,
87 "The use of negated comparision operators on partially orded \
88 types produces code that is hard to read and refactor. Please \
89 consider to use the `partial_cmp` instead, to make it clear \
90 that the two values could be incomparable."