clippy_lints/src/needless_pass_by_value.rs

   1 use crate::utils::ptr::get_spans;
   2 use crate::utils::{
   3     get_trait_def_id, implements_trait, is_copy, is_self, is_type_diagnostic_item, multispan_sugg, paths,
   4     snippet, snippet_opt, span_lint_and_then,
   5 };
   6 use if_chain::if_chain;
   7 use rustc_ast::ast::Attribute;
   8 use rustc_data_structures::fx::{FxHashMap, FxHashSet};
   9 use rustc_errors::{Applicability, DiagnosticBuilder};
  10 use rustc_hir::intravisit::FnKind;
  11 use rustc_hir::{BindingAnnotation, Body, FnDecl, GenericArg, HirId, ItemKind, Node, PatKind, QPath, TyKind};
  12 use rustc_infer::infer::TyCtxtInferExt;
  13 use rustc_lint::{LateContext, LateLintPass};
  14 use rustc_middle::ty::{self, TypeFoldable};
  15 use rustc_session::{declare_lint_pass, declare_tool_lint};
  16 use rustc_span::Span;
  17 use rustc_target::spec::abi::Abi;
  18 use rustc_trait_selection::traits;
  19 use rustc_trait_selection::traits::misc::can_type_implement_copy;
  20 use rustc_typeck::expr_use_visitor as euv;
  21 use std::borrow::Cow;
  22
  23 declare_clippy_lint! {
  24     /// **What it does:** Checks for functions taking arguments by value, but not
  25     /// consuming them in its
  26     /// body.
  27     ///
  28     /// **Why is this bad?** Taking arguments by reference is more flexible and can
  29     /// sometimes avoid
  30     /// unnecessary allocations.
  31     ///
  32     /// **Known problems:**
  33     /// * This lint suggests taking an argument by reference,
  34     /// however sometimes it is better to let users decide the argument type
  35     /// (by using `Borrow` trait, for example), depending on how the function is used.
  36     ///
  37     /// **Example:**
  38     /// ```rust
  39     /// fn foo(v: Vec<i32>) {
  40     ///     assert_eq!(v.len(), 42);
  41     /// }
  42     /// ```
  43     ///
  44     /// ```rust
  45     /// // should be
  46     /// fn foo(v: &[i32]) {
  47     ///     assert_eq!(v.len(), 42);
  48     /// }
  49     /// ```
  50     pub NEEDLESS_PASS_BY_VALUE,
  51     pedantic,
  52     "functions taking arguments by value, but not consuming them in its body"
  53 }
  54
  55 declare_lint_pass!(NeedlessPassByValue => [NEEDLESS_PASS_BY_VALUE]);
  56
  57 macro_rules! need {
  58     ($e: expr) => {
  59         if let Some(x) = $e {
  60             x
  61         } else {
  62             return;
  63         }
  64     };
  65 }
  66
  67 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
  68     #[allow(clippy::too_many_lines)]
  69     fn check_fn(
  70         &mut self,
  71         cx: &LateContext<'a, 'tcx>,
  72         kind: FnKind<'tcx>,
  73         decl: &'tcx FnDecl<'_>,
  74         body: &'tcx Body<'_>,
  75         span: Span,
  76         hir_id: HirId,
  77     ) {
  78         if span.from_expansion() {
  79             return;
  80         }
  81
  82         match kind {
  83             FnKind::ItemFn(.., header, _, attrs) => {
  84                 if header.abi != Abi::Rust || requires_exact_signature(attrs) {
  85                     return;
  86                 }
  87             },
  88             FnKind::Method(..) => (),
  89             _ => return,
  90         }
  91
  92         // Exclude non-inherent impls
  93         if let Some(Node::Item(item)) = cx.tcx.hir().find(cx.tcx.hir().get_parent_node(hir_id)) {
  94             if matches!(item.kind, ItemKind::Impl{ of_trait: Some(_), .. } |
  95                 ItemKind::Trait(..))
  96             {
  97                 return;
  98             }
  99         }
 100
 101         // Allow `Borrow` or functions to be taken by value
 102         let borrow_trait = need!(get_trait_def_id(cx, &paths::BORROW_TRAIT));
 103         let whitelisted_traits = [
 104             need!(cx.tcx.lang_items().fn_trait()),
 105             need!(cx.tcx.lang_items().fn_once_trait()),
 106             need!(cx.tcx.lang_items().fn_mut_trait()),
 107             need!(get_trait_def_id(cx, &paths::RANGE_ARGUMENT_TRAIT)),
 108         ];
 109
 110         let sized_trait = need!(cx.tcx.lang_items().sized_trait());
 111
 112         let fn_def_id = cx.tcx.hir().local_def_id(hir_id);
 113
 114         let preds = traits::elaborate_predicates(cx.tcx, cx.param_env.caller_bounds.to_vec())
 115             .filter(|p| !p.is_global())
 116             .filter_map(|obligation| {
 117                 if let ty::Predicate::Trait(poly_trait_ref, _) = obligation.predicate {
 118                     if poly_trait_ref.def_id() == sized_trait || poly_trait_ref.skip_binder().has_escaping_bound_vars()
 119                     {
 120                         return None;
 121                     }
 122                     Some(poly_trait_ref)
 123                 } else {
 124                     None
 125                 }
 126             })
 127             .collect::<Vec<_>>();
 128
 129         // Collect moved variables and spans which will need dereferencings from the
 130         // function body.
 131         let MovedVariablesCtxt {
 132             moved_vars,
 133             spans_need_deref,
 134             ..
 135         } = {
 136             let mut ctx = MovedVariablesCtxt::default();
 137             cx.tcx.infer_ctxt().enter(|infcx| {
 138                 euv::ExprUseVisitor::new(&mut ctx, &infcx, fn_def_id.to_def_id(), cx.param_env, cx.tables)
 139                     .consume_body(body);
 140             });
 141             ctx
 142         };
 143
 144         let fn_sig = cx.tcx.fn_sig(fn_def_id);
 145         let fn_sig = cx.tcx.erase_late_bound_regions(&fn_sig);
 146
 147         for (idx, ((input, &ty), arg)) in decl.inputs.iter().zip(fn_sig.inputs()).zip(body.params).enumerate() {
 148             // All spans generated from a proc-macro invocation are the same...
 149             if span == input.span {
 150                 return;
 151             }
 152
 153             // Ignore `self`s.
 154             if idx == 0 {
 155                 if let PatKind::Binding(.., ident, _) = arg.pat.kind {
 156                     if ident.as_str() == "self" {
 157                         continue;
 158                     }
 159                 }
 160             }
 161
 162             //
 163             // * Exclude a type that is specifically bounded by `Borrow`.
 164             // * Exclude a type whose reference also fulfills its bound. (e.g., `std::convert::AsRef`,
 165             //   `serde::Serialize`)
 166             let (implements_borrow_trait, all_borrowable_trait) = {
 167                 let preds = preds
 168                     .iter()
 169                     .filter(|t| t.skip_binder().self_ty() == ty)
 170                     .collect::<Vec<_>>();
 171
 172                 (
 173                     preds.iter().any(|t| t.def_id() == borrow_trait),
 174                     !preds.is_empty() && {
 175                         let ty_empty_region = cx.tcx.mk_imm_ref(cx.tcx.lifetimes.re_root_empty, ty);
 176                         preds.iter().all(|t| {
 177                             let ty_params = &t
 178                                 .skip_binder()
 179                                 .trait_ref
 180                                 .substs
 181                                 .iter()
 182                                 .skip(1)
 183                                 .cloned()
 184                                 .collect::<Vec<_>>();
 185                             implements_trait(cx, ty_empty_region, t.def_id(), ty_params)
 186                         })
 187                     },
 188                 )
 189             };
 190
 191             if_chain! {
 192                 if !is_self(arg);
 193                 if !ty.is_mutable_ptr();
 194                 if !is_copy(cx, ty);
 195                 if !whitelisted_traits.iter().any(|&t| implements_trait(cx, ty, t, &[]));
 196                 if !implements_borrow_trait;
 197                 if !all_borrowable_trait;
 198
 199                 if let PatKind::Binding(mode, canonical_id, ..) = arg.pat.kind;
 200                 if !moved_vars.contains(&canonical_id);
 201                 then {
 202                     if mode == BindingAnnotation::Mutable || mode == BindingAnnotation::RefMut {
 203                         continue;
 204                     }
 205
 206                     // Dereference suggestion
 207                     let sugg = |diag: &mut DiagnosticBuilder<'_>| {
 208                         if let ty::Adt(def, ..) = ty.kind {
 209                             if let Some(span) = cx.tcx.hir().span_if_local(def.did) {
 210                                 if can_type_implement_copy(cx.tcx, cx.param_env, ty).is_ok() {
 211                                     diag.span_help(span, "consider marking this type as `Copy`");
 212                                 }
 213                             }
 214                         }
 215
 216                         let deref_span = spans_need_deref.get(&canonical_id);
 217                         if_chain! {
 218                             if is_type_diagnostic_item(cx, ty, sym!(vec_type));
 219                             if let Some(clone_spans) =
 220                                 get_spans(cx, Some(body.id()), idx, &[("clone", ".to_owned()")]);
 221                             if let TyKind::Path(QPath::Resolved(_, ref path)) = input.kind;
 222                             if let Some(elem_ty) = path.segments.iter()
 223                                 .find(|seg| seg.ident.name == sym!(Vec))
 224                                 .and_then(|ps| ps.args.as_ref())
 225                                 .map(|params| params.args.iter().find_map(|arg| match arg {
 226                                     GenericArg::Type(ty) => Some(ty),
 227                                     _ => None,
 228                                 }).unwrap());
 229                             then {
 230                                 let slice_ty = format!("&[{}]", snippet(cx, elem_ty.span, "_"));
 231                                 diag.span_suggestion(
 232                                     input.span,
 233                                     "consider changing the type to",
 234                                     slice_ty,
 235                                     Applicability::Unspecified,
 236                                 );
 237
 238                                 for (span, suggestion) in clone_spans {
 239                                     diag.span_suggestion(
 240                                         span,
 241                                         &snippet_opt(cx, span)
 242                                             .map_or(
 243                                                 "change the call to".into(),
 244                                                 |x| Cow::from(format!("change `{}` to", x)),
 245                                             ),
 246                                         suggestion.into(),
 247                                         Applicability::Unspecified,
 248                                     );
 249                                 }
 250
 251                                 // cannot be destructured, no need for `*` suggestion
 252                                 assert!(deref_span.is_none());
 253                                 return;
 254                             }
 255                         }
 256
 257                         if is_type_diagnostic_item(cx, ty, sym!(string_type)) {
 258                             if let Some(clone_spans) =
 259                                 get_spans(cx, Some(body.id()), idx, &[("clone", ".to_string()"), ("as_str", "")]) {
 260                                 diag.span_suggestion(
 261                                     input.span,
 262                                     "consider changing the type to",
 263                                     "&str".to_string(),
 264                                     Applicability::Unspecified,
 265                                 );
 266
 267                                 for (span, suggestion) in clone_spans {
 268                                     diag.span_suggestion(
 269                                         span,
 270                                         &snippet_opt(cx, span)
 271                                             .map_or(
 272                                                 "change the call to".into(),
 273                                                 |x| Cow::from(format!("change `{}` to", x))
 274                                             ),
 275                                         suggestion.into(),
 276                                         Applicability::Unspecified,
 277                                     );
 278                                 }
 279
 280                                 assert!(deref_span.is_none());
 281                                 return;
 282                             }
 283                         }
 284
 285                         let mut spans = vec![(input.span, format!("&{}", snippet(cx, input.span, "_")))];
 286
 287                         // Suggests adding `*` to dereference the added reference.
 288                         if let Some(deref_span) = deref_span {
 289                             spans.extend(
 290                                 deref_span
 291                                     .iter()
 292                                     .cloned()
 293                                     .map(|span| (span, format!("*{}", snippet(cx, span, "<expr>")))),
 294                             );
 295                             spans.sort_by_key(|&(span, _)| span);
 296                         }
 297                         multispan_sugg(diag, "consider taking a reference instead".to_string(), spans);
 298                     };
 299
 300                     span_lint_and_then(
 301                         cx,
 302                         NEEDLESS_PASS_BY_VALUE,
 303                         input.span,
 304                         "this argument is passed by value, but not consumed in the function body",
 305                         sugg,
 306                     );
 307                 }
 308             }
 309         }
 310     }
 311 }
 312
 313 /// Functions marked with these attributes must have the exact signature.
 314 fn requires_exact_signature(attrs: &[Attribute]) -> bool {
 315     attrs.iter().any(|attr| {
 316         [sym!(proc_macro), sym!(proc_macro_attribute), sym!(proc_macro_derive)]
 317             .iter()
 318             .any(|&allow| attr.check_name(allow))
 319     })
 320 }
 321
 322 #[derive(Default)]
 323 struct MovedVariablesCtxt {
 324     moved_vars: FxHashSet<HirId>,
 325     /// Spans which need to be prefixed with `*` for dereferencing the
 326     /// suggested additional reference.
 327     spans_need_deref: FxHashMap<HirId, FxHashSet<Span>>,
 328 }
 329
 330 impl MovedVariablesCtxt {
 331     fn move_common(&mut self, cmt: &euv::Place<'_>) {
 332         if let euv::PlaceBase::Local(vid) = cmt.base {
 333             self.moved_vars.insert(vid);
 334         }
 335     }
 336 }
 337
 338 impl<'tcx> euv::Delegate<'tcx> for MovedVariablesCtxt {
 339     fn consume(&mut self, cmt: &euv::Place<'tcx>, mode: euv::ConsumeMode) {
 340         if let euv::ConsumeMode::Move = mode {
 341             self.move_common(cmt);
 342         }
 343     }
 344
 345     fn borrow(&mut self, _: &euv::Place<'tcx>, _: ty::BorrowKind) {}
 346
 347     fn mutate(&mut self, _: &euv::Place<'tcx>) {}
 348 }