1 //! Checks for needless address of operations (`&`)
3 //! This lint is **warn** by default
5 use crate::utils::{snippet_opt, span_lint_and_then};
6 use if_chain::if_chain;
8 use rustc::ty::adjustment::{Adjust, Adjustment};
9 use rustc_errors::Applicability;
10 use rustc_hir::{BindingAnnotation, BorrowKind, Expr, ExprKind, HirId, Item, Mutability, Pat, PatKind};
11 use rustc_lint::{LateContext, LateLintPass};
12 use rustc_session::{declare_tool_lint, impl_lint_pass};
14 declare_clippy_lint! {
15 /// **What it does:** Checks for address of operations (`&`) that are going to
16 /// be dereferenced immediately by the compiler.
18 /// **Why is this bad?** Suggests that the receiver of the expression borrows
23 /// let x: &i32 = &&&&&&5;
26 /// **Known problems:** None.
29 "taking a reference that is going to be automatically dereferenced"
33 pub struct NeedlessBorrow {
34 derived_item: Option<HirId>,
37 impl_lint_pass!(NeedlessBorrow => [NEEDLESS_BORROW]);
39 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessBorrow {
40 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr<'_>) {
41 if e.span.from_expansion() || self.derived_item.is_some() {
44 if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, ref inner) = e.kind {
45 if let ty::Ref(..) = cx.tables.expr_ty(inner).kind {
46 for adj3 in cx.tables.expr_adjustments(e).windows(3) {
48 kind: Adjust::Deref(_), ..
50 kind: Adjust::Deref(_), ..
52 kind: Adjust::Borrow(_),
60 "this expression borrows a reference that is immediately dereferenced \
63 if let Some(snippet) = snippet_opt(cx, inner.span) {
68 Applicability::MachineApplicable,
78 fn check_pat(&mut self, cx: &LateContext<'a, 'tcx>, pat: &'tcx Pat<'_>) {
79 if pat.span.from_expansion() || self.derived_item.is_some() {
83 if let PatKind::Binding(BindingAnnotation::Ref, .., name, _) = pat.kind;
84 if let ty::Ref(_, tam, mutbl) = cx.tables.pat_ty(pat).kind;
85 if mutbl == Mutability::Not;
86 if let ty::Ref(_, _, mutbl) = tam.kind;
87 // only lint immutable refs, because borrowed `&mut T` cannot be moved out
88 if mutbl == Mutability::Not;
94 "this pattern creates a reference to a reference",
96 if let Some(snippet) = snippet_opt(cx, name.span) {
101 Applicability::MachineApplicable,
110 fn check_item(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item<'_>) {
111 if item.attrs.iter().any(|a| a.check_name(sym!(automatically_derived))) {
112 debug_assert!(self.derived_item.is_none());
113 self.derived_item = Some(item.hir_id);
117 fn check_item_post(&mut self, _: &LateContext<'a, 'tcx>, item: &'tcx Item<'_>) {
118 if let Some(id) = self.derived_item {
119 if item.hir_id == id {
120 self.derived_item = None;