1 //! Checks for needless boolean results of if-else expressions
3 //! This lint is **warn** by default
5 use crate::utils::sugg::Sugg;
6 use crate::utils::{in_macro, span_lint, span_lint_and_sugg};
8 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
9 use rustc::{declare_tool_lint, lint_array};
10 use rustc_errors::Applicability;
11 use syntax::ast::LitKind;
12 use syntax::source_map::Spanned;
14 /// **What it does:** Checks for expressions of the form `if c { true } else {
16 /// (or vice versa) and suggest using the condition directly.
18 /// **Why is this bad?** Redundant code.
20 /// **Known problems:** Maybe false positives: Sometimes, the two branches are
21 /// painstakingly documented (which we of course do not detect), so they *may*
22 /// have some value. Even then, the documentation can be rewritten to match the
33 declare_clippy_lint! {
36 "if-statements with plain booleans in the then- and else-clause, e.g. `if p { true } else { false }`"
39 /// **What it does:** Checks for expressions of the form `x == true`,
40 /// `x != true` and order comparisons such as `x < true` (or vice versa) and
41 /// suggest using the variable directly.
43 /// **Why is this bad?** Unnecessary code.
45 /// **Known problems:** None.
49 /// if x == true {} // could be `if x { }`
51 declare_clippy_lint! {
54 "comparing a variable to a boolean, e.g. `if x == true` or `if x != true`"
57 #[derive(Copy, Clone)]
58 pub struct NeedlessBool;
60 impl LintPass for NeedlessBool {
61 fn get_lints(&self) -> LintArray {
62 lint_array!(NEEDLESS_BOOL)
66 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessBool {
67 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
68 use self::Expression::*;
69 if let ExprKind::If(ref pred, ref then_block, Some(ref else_expr)) = e.node {
70 let reduce = |ret, not| {
71 let mut applicability = Applicability::MachineApplicable;
72 let snip = Sugg::hir_with_applicability(cx, pred, "<predicate>", &mut applicability);
73 let mut snip = if not { !snip } else { snip };
76 snip = snip.make_return();
79 if parent_node_is_if_expr(&e, &cx) {
80 snip = snip.blockify()
87 "this if-then-else expression returns a bool literal",
88 "you can reduce it to",
93 if let ExprKind::Block(ref then_block, _) = then_block.node {
94 match (fetch_bool_block(then_block), fetch_bool_expr(else_expr)) {
95 (RetBool(true), RetBool(true)) | (Bool(true), Bool(true)) => {
100 "this if-then-else expression will always return true",
103 (RetBool(false), RetBool(false)) | (Bool(false), Bool(false)) => {
108 "this if-then-else expression will always return false",
111 (RetBool(true), RetBool(false)) => reduce(true, false),
112 (Bool(true), Bool(false)) => reduce(false, false),
113 (RetBool(false), RetBool(true)) => reduce(true, true),
114 (Bool(false), Bool(true)) => reduce(false, true),
118 panic!("IfExpr 'then' node is not an ExprKind::Block");
124 fn parent_node_is_if_expr<'a, 'b>(expr: &Expr, cx: &LateContext<'a, 'b>) -> bool {
125 let parent_id = cx.tcx.hir().get_parent_node(expr.id);
126 let parent_node = cx.tcx.hir().get(parent_id);
128 if let rustc::hir::Node::Expr(e) = parent_node {
129 if let ExprKind::If(_, _, _) = e.node {
137 #[derive(Copy, Clone)]
138 pub struct BoolComparison;
140 impl LintPass for BoolComparison {
141 fn get_lints(&self) -> LintArray {
142 lint_array!(BOOL_COMPARISON)
146 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BoolComparison {
147 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
148 if in_macro(e.span) {
152 if let ExprKind::Binary(Spanned { node, .. }, ..) = e.node {
153 let ignore_case = None::<(fn(_) -> _, &str)>;
154 let ignore_no_literal = None::<(fn(_, _) -> _, &str)>;
157 let true_case = Some((|h| h, "equality checks against true are unnecessary"));
158 let false_case = Some((
160 "equality checks against false can be replaced by a negation",
162 check_comparison(cx, e, true_case, false_case, true_case, false_case, ignore_no_literal)
165 let true_case = Some((
167 "inequality checks against true can be replaced by a negation",
169 let false_case = Some((|h| h, "inequality checks against false are unnecessary"));
170 check_comparison(cx, e, true_case, false_case, true_case, false_case, ignore_no_literal)
172 BinOpKind::Lt => check_comparison(
176 Some((|h| h, "greater than checks against false are unnecessary")),
179 "less than comparison against true can be replaced by a negation",
183 |l: Sugg<'_>, r: Sugg<'_>| (!l).bit_and(&r),
184 "order comparisons between booleans can be simplified",
187 BinOpKind::Gt => check_comparison(
192 "less than comparison against true can be replaced by a negation",
196 Some((|h| h, "greater than checks against false are unnecessary")),
198 |l: Sugg<'_>, r: Sugg<'_>| l.bit_and(&(!r)),
199 "order comparisons between booleans can be simplified",
208 fn check_comparison<'a, 'tcx>(
209 cx: &LateContext<'a, 'tcx>,
211 left_true: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
212 left_false: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
213 right_true: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
214 right_false: Option<(impl FnOnce(Sugg<'a>) -> Sugg<'a>, &str)>,
215 no_literal: Option<(impl FnOnce(Sugg<'a>, Sugg<'a>) -> Sugg<'a>, &str)>,
217 use self::Expression::*;
219 if let ExprKind::Binary(_, ref left_side, ref right_side) = e.node {
220 let mut applicability = Applicability::MachineApplicable;
221 match (fetch_bool_expr(left_side), fetch_bool_expr(right_side)) {
222 (Bool(true), Other) => left_true.map_or((), |(h, m)| {
223 suggest_bool_comparison(cx, e, right_side, applicability, m, h)
225 (Other, Bool(true)) => right_true.map_or((), |(h, m)| {
226 suggest_bool_comparison(cx, e, left_side, applicability, m, h)
228 (Bool(false), Other) => left_false.map_or((), |(h, m)| {
229 suggest_bool_comparison(cx, e, right_side, applicability, m, h)
231 (Other, Bool(false)) => right_false.map_or((), |(h, m)| {
232 suggest_bool_comparison(cx, e, left_side, applicability, m, h)
234 (Other, Other) => no_literal.map_or((), |(h, m)| {
235 let (l_ty, r_ty) = (cx.tables.expr_ty(left_side), cx.tables.expr_ty(right_side));
236 if l_ty.is_bool() && r_ty.is_bool() {
237 let left_side = Sugg::hir_with_applicability(cx, left_side, "..", &mut applicability);
238 let right_side = Sugg::hir_with_applicability(cx, right_side, "..", &mut applicability);
244 "try simplifying it as shown",
245 h(left_side, right_side).to_string(),
255 fn suggest_bool_comparison<'a, 'tcx>(
256 cx: &LateContext<'a, 'tcx>,
259 mut applicability: Applicability,
261 conv_hint: impl FnOnce(Sugg<'a>) -> Sugg<'a>,
263 let hint = Sugg::hir_with_applicability(cx, expr, "..", &mut applicability);
269 "try simplifying it as shown",
270 conv_hint(hint).to_string(),
281 fn fetch_bool_block(block: &Block) -> Expression {
282 match (&*block.stmts, block.expr.as_ref()) {
283 (&[], Some(e)) => fetch_bool_expr(&**e),
284 (&[ref e], None) => {
285 if let StmtKind::Semi(ref e) = e.node {
286 if let ExprKind::Ret(_) = e.node {
287 fetch_bool_expr(&**e)
295 _ => Expression::Other,
299 fn fetch_bool_expr(expr: &Expr) -> Expression {
301 ExprKind::Block(ref block, _) => fetch_bool_block(block),
302 ExprKind::Lit(ref lit_ptr) => {
303 if let LitKind::Bool(value) = lit_ptr.node {
304 Expression::Bool(value)
309 ExprKind::Ret(Some(ref expr)) => match fetch_bool_expr(expr) {
310 Expression::Bool(value) => Expression::RetBool(value),
311 _ => Expression::Other,
313 _ => Expression::Other,