1 //! lint on multiple versions of a crate being used
4 use rustc::{declare_lint, lint_array};
8 use itertools::Itertools;
10 /// **What it does:** Checks to see if multiple versions of a crate are being
13 /// **Why is this bad?** This bloats the size of targets, and can lead to
14 /// confusing error messages when structs or traits are used interchangeably
15 /// between different versions of a crate.
17 /// **Known problems:** Because this can be caused purely by the dependencies
18 /// themselves, it's not always possible to fix this issue.
22 /// # This will pull in both winapi v0.3.4 and v0.2.8, triggering a warning.
25 /// ansi_term = "0.11.0"
27 declare_clippy_lint! {
28 pub MULTIPLE_CRATE_VERSIONS,
30 "multiple versions of the same crate being used"
35 impl LintPass for Pass {
36 fn get_lints(&self) -> LintArray {
37 lint_array!(MULTIPLE_CRATE_VERSIONS)
41 impl EarlyLintPass for Pass {
42 fn check_crate(&mut self, cx: &EarlyContext, krate: &Crate) {
43 let metadata = match cargo_metadata::metadata_deps(None, true) {
44 Ok(metadata) => metadata,
47 MULTIPLE_CRATE_VERSIONS,
49 "could not read cargo metadata"
56 let mut packages = metadata.packages;
57 packages.sort_by(|a, b| a.name.cmp(&b.name));
59 for (name, group) in &packages.into_iter().group_by(|p| p.name.clone()) {
60 let group: Vec<cargo_metadata::Package> = group.collect();
63 let versions = group.into_iter().map(|p| p.version).join(", ");
66 MULTIPLE_CRATE_VERSIONS,
68 &format!("multiple versions for dependency `{}`: {}", name, versions),