1 // Note: More specifically this lint is largely inspired (aka copied) from
5 // [`missing_doc`]: https://github.com/rust-lang/rust/blob/d6d05904697d89099b55da3331155392f1db9c00/src/librustc_lint/builtin.rs#L246
8 use crate::utils::{in_macro, span_lint};
9 use if_chain::if_chain;
11 use rustc::lint::{LateContext, LateLintPass, LintArray, LintContext, LintPass};
13 use rustc::{declare_tool_lint, lint_array};
14 use syntax::ast::{self, MetaItem, MetaItemKind};
16 use syntax::source_map::Span;
18 declare_clippy_lint! {
19 /// **What it does:** Warns if there is missing doc for any documentable item
20 /// (public or private).
22 /// **Why is this bad?** Doc is good. *rustc* has a `MISSING_DOCS`
23 /// allowed-by-default lint for
24 /// public members, but has no way to enforce documentation of private items.
25 /// This lint fixes that.
27 /// **Known problems:** None.
28 pub MISSING_DOCS_IN_PRIVATE_ITEMS,
30 "detects missing documentation for public and private members"
33 pub struct MissingDoc {
34 /// Stack of whether #[doc(hidden)] is set
35 /// at each level which has lint attributes.
36 doc_hidden_stack: Vec<bool>,
39 impl ::std::default::Default for MissingDoc {
40 fn default() -> Self {
46 pub fn new() -> Self {
48 doc_hidden_stack: vec![false],
52 fn doc_hidden(&self) -> bool {
53 *self.doc_hidden_stack.last().expect("empty doc_hidden_stack")
56 fn has_include(meta: Option<MetaItem>) -> bool {
58 if let Some(meta) = meta;
59 if let MetaItemKind::List(list) = meta.node;
60 if let Some(meta) = list.get(0);
61 if let Some(name) = meta.name();
70 fn check_missing_docs_attrs(
72 cx: &LateContext<'_, '_>,
73 attrs: &[ast::Attribute],
77 // If we're building a test harness, then warning about
78 // documentation is probably not really relevant right now.
79 if cx.sess().opts.test {
83 // `#[doc(hidden)]` disables missing_docs check.
84 if self.doc_hidden() {
94 .any(|a| a.name() == "doc" && (a.is_value_str() || Self::has_include(a.meta())));
98 MISSING_DOCS_IN_PRIVATE_ITEMS,
100 &format!("missing documentation for {}", desc),
106 impl LintPass for MissingDoc {
107 fn get_lints(&self) -> LintArray {
108 lint_array![MISSING_DOCS_IN_PRIVATE_ITEMS]
111 fn name(&self) -> &'static str {
116 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingDoc {
117 fn enter_lint_attrs(&mut self, _: &LateContext<'a, 'tcx>, attrs: &'tcx [ast::Attribute]) {
118 let doc_hidden = self.doc_hidden()
119 || attrs.iter().any(|attr| {
120 attr.check_name("doc")
121 && match attr.meta_item_list() {
123 Some(l) => attr::list_contains_name(&l[..], "hidden"),
126 self.doc_hidden_stack.push(doc_hidden);
129 fn exit_lint_attrs(&mut self, _: &LateContext<'a, 'tcx>, _: &'tcx [ast::Attribute]) {
130 self.doc_hidden_stack.pop().expect("empty doc_hidden_stack");
133 fn check_crate(&mut self, cx: &LateContext<'a, 'tcx>, krate: &'tcx hir::Crate) {
134 self.check_missing_docs_attrs(cx, &krate.attrs, krate.span, "crate");
137 fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, it: &'tcx hir::Item) {
138 let desc = match it.node {
139 hir::ItemKind::Const(..) => "a constant",
140 hir::ItemKind::Enum(..) => "an enum",
141 hir::ItemKind::Fn(..) => {
143 if it.ident.name == "main" {
144 let def_id = cx.tcx.hir().local_def_id_from_hir_id(it.hir_id);
145 let def_key = cx.tcx.hir().def_key(def_id);
146 if def_key.parent == Some(hir::def_id::CRATE_DEF_INDEX) {
152 hir::ItemKind::Mod(..) => "a module",
153 hir::ItemKind::Static(..) => "a static",
154 hir::ItemKind::Struct(..) => "a struct",
155 hir::ItemKind::Trait(..) => "a trait",
156 hir::ItemKind::TraitAlias(..) => "a trait alias",
157 hir::ItemKind::Ty(..) => "a type alias",
158 hir::ItemKind::Union(..) => "a union",
159 hir::ItemKind::Existential(..) => "an existential type",
160 hir::ItemKind::ExternCrate(..)
161 | hir::ItemKind::ForeignMod(..)
162 | hir::ItemKind::GlobalAsm(..)
163 | hir::ItemKind::Impl(..)
164 | hir::ItemKind::Use(..) => return,
167 self.check_missing_docs_attrs(cx, &it.attrs, it.span, desc);
170 fn check_trait_item(&mut self, cx: &LateContext<'a, 'tcx>, trait_item: &'tcx hir::TraitItem) {
171 let desc = match trait_item.node {
172 hir::TraitItemKind::Const(..) => "an associated constant",
173 hir::TraitItemKind::Method(..) => "a trait method",
174 hir::TraitItemKind::Type(..) => "an associated type",
177 self.check_missing_docs_attrs(cx, &trait_item.attrs, trait_item.span, desc);
180 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, impl_item: &'tcx hir::ImplItem) {
181 // If the method is an impl for a trait, don't doc.
182 let def_id = cx.tcx.hir().local_def_id_from_hir_id(impl_item.hir_id);
183 match cx.tcx.associated_item(def_id).container {
184 ty::TraitContainer(_) => return,
185 ty::ImplContainer(cid) => {
186 if cx.tcx.impl_trait_ref(cid).is_some() {
192 let desc = match impl_item.node {
193 hir::ImplItemKind::Const(..) => "an associated constant",
194 hir::ImplItemKind::Method(..) => "a method",
195 hir::ImplItemKind::Type(_) => "an associated type",
196 hir::ImplItemKind::Existential(_) => "an existential type",
198 self.check_missing_docs_attrs(cx, &impl_item.attrs, impl_item.span, desc);
201 fn check_struct_field(&mut self, cx: &LateContext<'a, 'tcx>, sf: &'tcx hir::StructField) {
202 if !sf.is_positional() {
203 self.check_missing_docs_attrs(cx, &sf.attrs, sf.span, "a struct field");
207 fn check_variant(&mut self, cx: &LateContext<'a, 'tcx>, v: &'tcx hir::Variant, _: &hir::Generics) {
208 self.check_missing_docs_attrs(cx, &v.node.attrs, v.span, "a variant");