1 // Note: More specifically this lint is largely inspired (aka copied) from
5 // [`missing_doc`]: https://github.com/rust-lang/rust/blob/cf9cf7c923eb01146971429044f216a3ca905e06/compiler/rustc_lint/src/builtin.rs#L415
8 use clippy_utils::attrs::is_doc_hidden;
9 use clippy_utils::diagnostics::span_lint;
10 use if_chain::if_chain;
11 use rustc_ast::ast::{self, MetaItem, MetaItemKind};
13 use rustc_lint::{LateContext, LateLintPass, LintContext};
15 use rustc_session::{declare_tool_lint, impl_lint_pass};
16 use rustc_span::def_id::CRATE_DEF_ID;
17 use rustc_span::source_map::Span;
20 declare_clippy_lint! {
22 /// Warns if there is missing doc for any documentable item
23 /// (public or private).
25 /// ### Why is this bad?
26 /// Doc is good. *rustc* has a `MISSING_DOCS`
27 /// allowed-by-default lint for
28 /// public members, but has no way to enforce documentation of private items.
29 /// This lint fixes that.
30 pub MISSING_DOCS_IN_PRIVATE_ITEMS,
32 "detects missing documentation for public and private members"
35 pub struct MissingDoc {
36 /// Stack of whether #[doc(hidden)] is set
37 /// at each level which has lint attributes.
38 doc_hidden_stack: Vec<bool>,
41 impl Default for MissingDoc {
43 fn default() -> Self {
50 pub fn new() -> Self {
52 doc_hidden_stack: vec![false],
56 fn doc_hidden(&self) -> bool {
57 *self.doc_hidden_stack.last().expect("empty doc_hidden_stack")
60 fn has_include(meta: Option<MetaItem>) -> bool {
62 if let Some(meta) = meta;
63 if let MetaItemKind::List(list) = meta.kind;
64 if let Some(meta) = list.get(0);
65 if let Some(name) = meta.ident();
67 name.name == sym::include
74 fn check_missing_docs_attrs(
77 attrs: &[ast::Attribute],
79 article: &'static str,
82 // If we're building a test harness, then warning about
83 // documentation is probably not really relevant right now.
84 if cx.sess().opts.test {
88 // `#[doc(hidden)]` disables missing_docs check.
89 if self.doc_hidden() {
93 if sp.from_expansion() {
99 .any(|a| a.doc_str().is_some() || Self::has_include(a.meta()));
103 MISSING_DOCS_IN_PRIVATE_ITEMS,
105 &format!("missing documentation for {} {}", article, desc),
111 impl_lint_pass!(MissingDoc => [MISSING_DOCS_IN_PRIVATE_ITEMS]);
113 impl<'tcx> LateLintPass<'tcx> for MissingDoc {
114 fn enter_lint_attrs(&mut self, _: &LateContext<'tcx>, attrs: &'tcx [ast::Attribute]) {
115 let doc_hidden = self.doc_hidden() || is_doc_hidden(attrs);
116 self.doc_hidden_stack.push(doc_hidden);
119 fn exit_lint_attrs(&mut self, _: &LateContext<'tcx>, _: &'tcx [ast::Attribute]) {
120 self.doc_hidden_stack.pop().expect("empty doc_hidden_stack");
123 fn check_crate(&mut self, cx: &LateContext<'tcx>) {
124 let attrs = cx.tcx.hir().attrs(hir::CRATE_HIR_ID);
125 self.check_missing_docs_attrs(cx, attrs, cx.tcx.def_span(CRATE_DEF_ID), "the", "crate");
128 fn check_item(&mut self, cx: &LateContext<'tcx>, it: &'tcx hir::Item<'_>) {
130 hir::ItemKind::Fn(..) => {
132 if it.ident.name == sym::main {
133 let def_key = cx.tcx.hir().def_key(it.def_id);
134 if def_key.parent == Some(hir::def_id::CRATE_DEF_INDEX) {
139 hir::ItemKind::Const(..)
140 | hir::ItemKind::Enum(..)
141 | hir::ItemKind::Macro(..)
142 | hir::ItemKind::Mod(..)
143 | hir::ItemKind::Static(..)
144 | hir::ItemKind::Struct(..)
145 | hir::ItemKind::Trait(..)
146 | hir::ItemKind::TraitAlias(..)
147 | hir::ItemKind::TyAlias(..)
148 | hir::ItemKind::Union(..)
149 | hir::ItemKind::OpaqueTy(..) => {},
150 hir::ItemKind::ExternCrate(..)
151 | hir::ItemKind::ForeignMod { .. }
152 | hir::ItemKind::GlobalAsm(..)
153 | hir::ItemKind::Impl { .. }
154 | hir::ItemKind::Use(..) => return,
157 let (article, desc) = cx.tcx.article_and_description(it.def_id.to_def_id());
159 let attrs = cx.tcx.hir().attrs(it.hir_id());
160 self.check_missing_docs_attrs(cx, attrs, it.span, article, desc);
163 fn check_trait_item(&mut self, cx: &LateContext<'tcx>, trait_item: &'tcx hir::TraitItem<'_>) {
164 let (article, desc) = cx.tcx.article_and_description(trait_item.def_id.to_def_id());
166 let attrs = cx.tcx.hir().attrs(trait_item.hir_id());
167 self.check_missing_docs_attrs(cx, attrs, trait_item.span, article, desc);
170 fn check_impl_item(&mut self, cx: &LateContext<'tcx>, impl_item: &'tcx hir::ImplItem<'_>) {
171 // If the method is an impl for a trait, don't doc.
172 match cx.tcx.associated_item(impl_item.def_id).container {
173 ty::TraitContainer(_) => return,
174 ty::ImplContainer(cid) => {
175 if cx.tcx.impl_trait_ref(cid).is_some() {
181 let (article, desc) = cx.tcx.article_and_description(impl_item.def_id.to_def_id());
182 let attrs = cx.tcx.hir().attrs(impl_item.hir_id());
183 self.check_missing_docs_attrs(cx, attrs, impl_item.span, article, desc);
186 fn check_field_def(&mut self, cx: &LateContext<'tcx>, sf: &'tcx hir::FieldDef<'_>) {
187 if !sf.is_positional() {
188 let attrs = cx.tcx.hir().attrs(sf.hir_id);
189 self.check_missing_docs_attrs(cx, attrs, sf.span, "a", "struct field");
193 fn check_variant(&mut self, cx: &LateContext<'tcx>, v: &'tcx hir::Variant<'_>) {
194 let attrs = cx.tcx.hir().attrs(v.id);
195 self.check_missing_docs_attrs(cx, attrs, v.span, "a", "variant");