1 use crate::utils::{is_entrypoint_fn, span_lint, trait_ref_of_method};
3 use rustc::hir::intravisit::FnKind;
4 use rustc::hir::{Body, Constness, FnDecl, HirId};
5 use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintPass};
6 use rustc::{declare_lint_pass, declare_tool_lint};
7 use rustc_mir::transform::qualify_min_const_fn::is_min_const_fn;
10 declare_clippy_lint! {
13 /// Suggests the use of `const` in functions and methods where possible.
15 /// **Why is this bad?**
17 /// Not having the function const prevents callers of the function from being const as well.
19 /// **Known problems:**
21 /// Const functions are currently still being worked on, with some features only being available
22 /// on nightly. This lint does not consider all edge cases currently and the suggestions may be
23 /// incorrect if you are using this lint on stable.
25 /// Also, the lint only runs one pass over the code. Consider these two non-const functions:
36 /// When running Clippy, the lint will only suggest to make `a` const, because `b` at this time
37 /// can't be const as it calls a non-const function. Making `a` const and running Clippy again,
38 /// will suggest to make `b` const, too.
44 /// # random_number: usize,
47 /// fn new() -> Self {
48 /// Self { random_number: 42 }
53 /// Could be a const fn:
57 /// # random_number: usize,
60 /// const fn new() -> Self {
61 /// Self { random_number: 42 }
65 pub MISSING_CONST_FOR_FN,
67 "Lint functions definitions that could be made `const fn`"
70 declare_lint_pass!(MissingConstForFn => [MISSING_CONST_FOR_FN]);
72 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingConstForFn {
75 cx: &LateContext<'_, '_>,
82 let def_id = cx.tcx.hir().local_def_id(hir_id);
84 if in_external_macro(cx.tcx.sess, span) || is_entrypoint_fn(cx, def_id) {
88 // Perform some preliminary checks that rule out constness on the Clippy side. This way we
89 // can skip the actual const check and return early.
91 FnKind::ItemFn(_, _, header, ..) => {
92 if already_const(header) {
96 FnKind::Method(_, sig, ..) => {
97 if trait_ref_of_method(cx, hir_id).is_some() || already_const(sig.header) {
104 let mir = cx.tcx.optimized_mir(def_id);
106 if let Err((span, err)) = is_min_const_fn(cx.tcx, def_id, &mir) {
107 if cx.tcx.is_min_const_fn(def_id) {
108 cx.tcx.sess.span_err(span, &err);
111 span_lint(cx, MISSING_CONST_FOR_FN, span, "this could be a const_fn");
116 // We don't have to lint on something that's already `const`
117 fn already_const(header: hir::FnHeader) -> bool {
118 header.constness == Constness::Const