3 use rustc::hir::intravisit::FnKind;
5 use rustc::middle::const_val::ConstVal;
7 use rustc_const_eval::EvalHint::ExprTypeChecked;
8 use rustc_const_eval::eval_const_expr_partial;
9 use rustc_const_math::ConstFloat;
10 use syntax::codemap::{Span, Spanned, ExpnFormat};
12 get_item_name, get_parent_expr, implements_trait, in_macro, is_integer_literal, match_path,
13 snippet, span_lint, span_lint_and_then, walk_ptrs_ty, last_path_segment
15 use utils::sugg::Sugg;
17 /// **What it does:** Checks for function arguments and let bindings denoted as `ref`.
19 /// **Why is this bad?** The `ref` declaration makes the function take an owned
20 /// value, but turns the argument into a reference (which means that the value
21 /// is destroyed when exiting the function). This adds not much value: either
22 /// take a reference type, or take an owned value and create references in the
25 /// For let bindings, `let x = &foo;` is preferred over `let ref x = foo`. The
26 /// type of `x` is more obvious with the former.
28 /// **Known problems:** If the argument is dereferenced within the function,
29 /// removing the `ref` will lead to errors. This can be fixed by removing the
30 /// dereferences, e.g. changing `*x` to `x` within the function.
34 /// fn foo(ref x: u8) -> bool { .. }
39 "an entire binding declared as `ref`, in a function argument or a `let` statement"
42 /// **What it does:** Checks for comparisons to NaN.
44 /// **Why is this bad?** NaN does not compare meaningfully to anything – not
45 /// even itself – so those comparisons are simply wrong.
47 /// **Known problems:** None.
56 "comparisons to NAN, which will always return false, probably not intended"
59 /// **What it does:** Checks for (in-)equality comparisons on floating-point
60 /// values (apart from zero), except in functions called `*eq*` (which probably
61 /// implement equality for a type involving floats).
63 /// **Why is this bad?** Floating point calculations are usually imprecise, so
64 /// asking if two values are *exactly* equal is asking for trouble. For a good
65 /// guide on what to do, see [the floating point
66 /// guide](http://www.floating-point-gui.de/errors/comparison).
68 /// **Known problems:** None.
73 /// y != x // where both are floats
78 "using `==` or `!=` on float values instead of comparing difference with an epsilon"
81 /// **What it does:** Checks for conversions to owned values just for the sake
84 /// **Why is this bad?** The comparison can operate on a reference, so creating
85 /// an owned value effectively throws it away directly afterwards, which is
86 /// needlessly consuming code and heap space.
88 /// **Known problems:** None.
97 "creating owned instances for comparing with others, e.g. `x == \"foo\".to_string()`"
100 /// **What it does:** Checks for getting the remainder of a division by one.
102 /// **Why is this bad?** The result can only ever be zero. No one will write
103 /// such code deliberately, unless trying to win an Underhanded Rust
104 /// Contest. Even for that contest, it's probably a bad idea. Use something more
107 /// **Known problems:** None.
116 "taking a number modulo 1, which always returns 0"
119 /// **What it does:** Checks for patterns in the form `name @ _`.
121 /// **Why is this bad?** It's almost always more readable to just use direct bindings.
123 /// **Known problems:** None.
129 /// y @ _ => (), // easier written as `y`,
133 pub REDUNDANT_PATTERN,
135 "using `name @ _` in a pattern"
138 /// **What it does:** Checks for the use of bindings with a single leading underscore.
140 /// **Why is this bad?** A single leading underscore is usually used to indicate
141 /// that a binding will not be used. Using such a binding breaks this
144 /// **Known problems:** The lint does not work properly with desugaring and
145 /// macro, it has been allowed in the mean time.
150 /// let y = _x + 1; // Here we are using `_x`, even though it has a leading underscore.
151 /// // We should rename `_x` to `x`
154 pub USED_UNDERSCORE_BINDING,
156 "using a binding which is prefixed with an underscore"
159 #[derive(Copy, Clone)]
162 impl LintPass for Pass {
163 fn get_lints(&self) -> LintArray {
164 lint_array!(TOPLEVEL_REF_ARG, CMP_NAN, FLOAT_CMP, CMP_OWNED, MODULO_ONE, REDUNDANT_PATTERN,
165 USED_UNDERSCORE_BINDING)
169 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
170 fn check_fn(&mut self, cx: &LateContext<'a, 'tcx>, k: FnKind<'tcx>, decl: &'tcx FnDecl, _: &'tcx Expr, _: Span, _: NodeId) {
171 if let FnKind::Closure(_) = k {
172 // Does not apply to closures
175 for arg in &decl.inputs {
176 if let PatKind::Binding(BindByRef(_), _, _, _) = arg.pat.node {
180 "`ref` directly on a function argument is ignored. Consider using a reference type instead.");
185 fn check_stmt(&mut self, cx: &LateContext<'a, 'tcx>, s: &'tcx Stmt) {
187 let StmtDecl(ref d, _) = s.node,
188 let DeclLocal(ref l) = d.node,
189 let PatKind::Binding(BindByRef(mt), _, i, None) = l.pat.node,
190 let Some(ref init) = l.init
192 let init = Sugg::hir(cx, init, "..");
193 let (mutopt,initref) = if mt == Mutability::MutMutable {
194 ("mut ", init.mut_addr())
198 let tyopt = if let Some(ref ty) = l.ty {
199 format!(": &{mutopt}{ty}", mutopt=mutopt, ty=snippet(cx, ty.span, "_"))
203 span_lint_and_then(cx,
206 "`ref` on an entire `let` pattern is discouraged, take a reference with `&` instead",
208 db.span_suggestion(s.span,
210 format!("let {name}{tyopt} = {initref};",
211 name=snippet(cx, i.span, "_"),
219 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
220 if let ExprBinary(ref cmp, ref left, ref right) = expr.node {
222 if op.is_comparison() {
223 if let ExprPath(QPath::Resolved(_, ref path)) = left.node {
224 check_nan(cx, path, expr.span);
226 if let ExprPath(QPath::Resolved(_, ref path)) = right.node {
227 check_nan(cx, path, expr.span);
229 check_to_owned(cx, left, right, true, cmp.span);
230 check_to_owned(cx, right, left, false, cmp.span)
232 if (op == BiEq || op == BiNe) && (is_float(cx, left) || is_float(cx, right)) {
233 if is_allowed(cx, left) || is_allowed(cx, right) {
236 if let Some(name) = get_item_name(cx, expr) {
237 let name = &*name.as_str();
238 if name == "eq" || name == "ne" || name == "is_nan" || name.starts_with("eq_") ||
239 name.ends_with("_eq") {
243 span_lint_and_then(cx,
246 "strict comparison of f32 or f64",
248 let lhs = Sugg::hir(cx, left, "..");
249 let rhs = Sugg::hir(cx, right, "..");
251 db.span_suggestion(expr.span,
252 "consider comparing them within some error",
253 format!("({}).abs() < error", lhs - rhs));
254 db.span_note(expr.span, "std::f32::EPSILON and std::f64::EPSILON are available.");
256 } else if op == BiRem && is_integer_literal(right, 1) {
257 span_lint(cx, MODULO_ONE, expr.span, "any number modulo 1 will be 0");
260 if in_attributes_expansion(cx, expr) {
261 // Don't lint things expanded by #[derive(...)], etc
264 let binding = match expr.node {
265 ExprPath(ref qpath) => {
266 let binding = last_path_segment(qpath).name.as_str();
267 if binding.starts_with('_') &&
268 !binding.starts_with("__") &&
269 &*binding != "_result" && // FIXME: #944
271 // don't lint if the declaration is in a macro
272 non_macro_local(cx, &cx.tcx.tables().qpath_def(qpath, expr.id)) {
278 ExprField(_, spanned) => {
279 let name = spanned.node.as_str();
280 if name.starts_with('_') && !name.starts_with("__") {
288 if let Some(binding) = binding {
290 USED_UNDERSCORE_BINDING,
292 &format!("used binding `{}` which is prefixed with an underscore. A leading \
293 underscore signals that a binding will not be used.", binding));
297 fn check_pat(&mut self, cx: &LateContext<'a, 'tcx>, pat: &'tcx Pat) {
298 if let PatKind::Binding(_, _, ref ident, Some(ref right)) = pat.node {
299 if right.node == PatKind::Wild {
303 &format!("the `{} @ _` pattern can be written as just `{}`",
311 fn check_nan(cx: &LateContext, path: &Path, span: Span) {
312 path.segments.last().map(|seg| {
313 if &*seg.name.as_str() == "NAN" {
317 "doomed comparison with NAN, use `std::{f32,f64}::is_nan()` instead");
322 fn is_allowed(cx: &LateContext, expr: &Expr) -> bool {
323 let res = eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None);
324 if let Ok(ConstVal::Float(val)) = res {
325 use std::cmp::Ordering;
327 let zero = ConstFloat::FInfer {
332 let infinity = ConstFloat::FInfer {
333 f32: ::std::f32::INFINITY,
334 f64: ::std::f64::INFINITY,
337 let neg_infinity = ConstFloat::FInfer {
338 f32: ::std::f32::NEG_INFINITY,
339 f64: ::std::f64::NEG_INFINITY,
342 val.try_cmp(zero) == Ok(Ordering::Equal)
343 || val.try_cmp(infinity) == Ok(Ordering::Equal)
344 || val.try_cmp(neg_infinity) == Ok(Ordering::Equal)
350 fn is_float(cx: &LateContext, expr: &Expr) -> bool {
351 matches!(walk_ptrs_ty(cx.tcx.tables().expr_ty(expr)).sty, ty::TyFloat(_))
354 fn check_to_owned(cx: &LateContext, expr: &Expr, other: &Expr, left: bool, op: Span) {
355 let (arg_ty, snip) = match expr.node {
356 ExprMethodCall(Spanned { node: ref name, .. }, _, ref args) if args.len() == 1 => {
357 let name = &*name.as_str();
358 if name == "to_string" || name == "to_owned" && is_str_arg(cx, args) {
359 (cx.tcx.tables().expr_ty(&args[0]), snippet(cx, args[0].span, ".."))
364 ExprCall(ref path, ref v) if v.len() == 1 => {
365 if let ExprPath(ref path) = path.node {
366 if match_path(path, &["String", "from_str"]) || match_path(path, &["String", "from"]) {
367 (cx.tcx.tables().expr_ty(&v[0]), snippet(cx, v[0].span, ".."))
378 let other_ty = cx.tcx.tables().expr_ty(other);
379 let partial_eq_trait_id = match cx.tcx.lang_items.eq_trait() {
384 if !implements_trait(cx, arg_ty, partial_eq_trait_id, vec![other_ty]) {
392 &format!("this creates an owned instance just for comparison. Consider using `{} {} {}` to \
393 compare without allocation",
395 snippet(cx, op, "=="),
396 snippet(cx, other.span, "..")));
401 &format!("this creates an owned instance just for comparison. Consider using `{} {} {}` to \
402 compare without allocation",
403 snippet(cx, other.span, ".."),
404 snippet(cx, op, "=="),
410 fn is_str_arg(cx: &LateContext, args: &[Expr]) -> bool {
412 matches!(walk_ptrs_ty(cx.tcx.tables().expr_ty(&args[0])).sty, ty::TyStr)
415 /// Heuristic to see if an expression is used. Should be compatible with `unused_variables`'s idea
416 /// of what it means for an expression to be "used".
417 fn is_used(cx: &LateContext, expr: &Expr) -> bool {
418 if let Some(parent) = get_parent_expr(cx, expr) {
420 ExprAssign(_, ref rhs) |
421 ExprAssignOp(_, _, ref rhs) => **rhs == *expr,
422 _ => is_used(cx, parent),
429 /// Test whether an expression is in a macro expansion (e.g. something generated by
430 /// `#[derive(...)`] or the like).
431 fn in_attributes_expansion(cx: &LateContext, expr: &Expr) -> bool {
432 cx.sess().codemap().with_expn_info(expr.span.expn_id, |info_opt| {
433 info_opt.map_or(false, |info| {
434 matches!(info.callee.format, ExpnFormat::MacroAttribute(_))
439 /// Test whether `def` is a variable defined outside a macro.
440 fn non_macro_local(cx: &LateContext, def: &def::Def) -> bool {
442 def::Def::Local(id) | def::Def::Upvar(id, _, _) => {
443 if let Some(span) = cx.tcx.map.span_if_local(id) {