1 mod option_map_unwrap_or;
2 mod unnecessary_filter_map;
8 use if_chain::if_chain;
11 use rustc::hir::intravisit::{self, Visitor};
12 use rustc::lint::{in_external_macro, LateContext, LateLintPass, Lint, LintArray, LintContext, LintPass};
13 use rustc::ty::{self, Predicate, Ty};
14 use rustc::{declare_lint_pass, declare_tool_lint};
15 use rustc_errors::Applicability;
17 use syntax::source_map::Span;
18 use syntax::symbol::{sym, LocalInternedString};
20 use crate::utils::sugg;
21 use crate::utils::usage::mutated_variables;
23 get_arg_name, get_parent_expr, get_trait_def_id, has_iter_method, implements_trait, in_macro, is_copy,
24 is_ctor_function, is_expn_of, iter_input_pats, last_path_segment, match_def_path, match_qpath, match_trait_method,
25 match_type, match_var, method_calls, method_chain_args, remove_blocks, return_ty, same_tys, single_segment_path,
26 snippet, snippet_with_applicability, snippet_with_macro_callsite, span_lint, span_lint_and_sugg,
27 span_lint_and_then, span_note_and_lint, walk_ptrs_ty, walk_ptrs_ty_depth, SpanlessEq,
29 use crate::utils::{paths, span_help_and_lint};
31 declare_clippy_lint! {
32 /// **What it does:** Checks for `.unwrap()` calls on `Option`s.
34 /// **Why is this bad?** Usually it is better to handle the `None` case, or to
35 /// at least call `.expect(_)` with a more helpful message. Still, for a lot of
36 /// quick-and-dirty code, `unwrap` is a good choice, which is why this lint is
37 /// `Allow` by default.
39 /// **Known problems:** None.
43 /// Using unwrap on an `Option`:
46 /// let opt = Some(1);
53 /// let opt = Some(1);
54 /// opt.expect("more helpful message");
56 pub OPTION_UNWRAP_USED,
58 "using `Option.unwrap()`, which should at least get a better message using `expect()`"
61 declare_clippy_lint! {
62 /// **What it does:** Checks for `.unwrap()` calls on `Result`s.
64 /// **Why is this bad?** `result.unwrap()` will let the thread panic on `Err`
65 /// values. Normally, you want to implement more sophisticated error handling,
66 /// and propagate errors upwards with `try!`.
68 /// Even if you want to panic on errors, not all `Error`s implement good
69 /// messages on display. Therefore, it may be beneficial to look at the places
70 /// where they may get displayed. Activate this lint to do just that.
72 /// **Known problems:** None.
75 /// Using unwrap on an `Option`:
78 /// let res: Result<usize, ()> = Ok(1);
85 /// let res: Result<usize, ()> = Ok(1);
86 /// res.expect("more helpful message");
88 pub RESULT_UNWRAP_USED,
90 "using `Result.unwrap()`, which might be better handled"
93 declare_clippy_lint! {
94 /// **What it does:** Checks for methods that should live in a trait
95 /// implementation of a `std` trait (see [llogiq's blog
96 /// post](http://llogiq.github.io/2015/07/30/traits.html) for further
97 /// information) instead of an inherent implementation.
99 /// **Why is this bad?** Implementing the traits improve ergonomics for users of
100 /// the code, often with very little cost. Also people seeing a `mul(...)`
102 /// may expect `*` to work equally, so you should have good reason to disappoint
105 /// **Known problems:** None.
111 /// fn add(&self, other: &X) -> X {
116 pub SHOULD_IMPLEMENT_TRAIT,
118 "defining a method that should be implementing a std trait"
121 declare_clippy_lint! {
122 /// **What it does:** Checks for methods with certain name prefixes and which
123 /// doesn't match how self is taken. The actual rules are:
125 /// |Prefix |`self` taken |
126 /// |-------|----------------------|
127 /// |`as_` |`&self` or `&mut self`|
129 /// |`into_`|`self` |
130 /// |`is_` |`&self` or none |
131 /// |`to_` |`&self` |
133 /// **Why is this bad?** Consistency breeds readability. If you follow the
134 /// conventions, your users won't be surprised that they, e.g., need to supply a
135 /// mutable reference to a `as_..` function.
137 /// **Known problems:** None.
142 /// fn as_str(self) -> &str {
147 pub WRONG_SELF_CONVENTION,
149 "defining a method named with an established prefix (like \"into_\") that takes `self` with the wrong convention"
152 declare_clippy_lint! {
153 /// **What it does:** This is the same as
154 /// [`wrong_self_convention`](#wrong_self_convention), but for public items.
156 /// **Why is this bad?** See [`wrong_self_convention`](#wrong_self_convention).
158 /// **Known problems:** Actually *renaming* the function may break clients if
159 /// the function is part of the public interface. In that case, be mindful of
160 /// the stability guarantees you've given your users.
166 /// pub fn as_str(self) -> &'a str {
171 pub WRONG_PUB_SELF_CONVENTION,
173 "defining a public method named with an established prefix (like \"into_\") that takes `self` with the wrong convention"
176 declare_clippy_lint! {
177 /// **What it does:** Checks for usage of `ok().expect(..)`.
179 /// **Why is this bad?** Because you usually call `expect()` on the `Result`
180 /// directly to get a better error message.
182 /// **Known problems:** The error type needs to implement `Debug`
186 /// x.ok().expect("why did I do this again?")
190 "using `ok().expect()`, which gives worse error messages than calling `expect` directly on the Result"
193 declare_clippy_lint! {
194 /// **What it does:** Checks for usage of `_.map(_).unwrap_or(_)`.
196 /// **Why is this bad?** Readability, this can be written more concisely as
197 /// `_.map_or(_, _)`.
199 /// **Known problems:** The order of the arguments is not in execution order
203 /// # let x = Some(1);
204 /// x.map(|a| a + 1).unwrap_or(0);
206 pub OPTION_MAP_UNWRAP_OR,
208 "using `Option.map(f).unwrap_or(a)`, which is more succinctly expressed as `map_or(a, f)`"
211 declare_clippy_lint! {
212 /// **What it does:** Checks for usage of `_.map(_).unwrap_or_else(_)`.
214 /// **Why is this bad?** Readability, this can be written more concisely as
215 /// `_.map_or_else(_, _)`.
217 /// **Known problems:** The order of the arguments is not in execution order.
221 /// # let x = Some(1);
222 /// # fn some_function() -> usize { 1 }
223 /// x.map(|a| a + 1).unwrap_or_else(some_function);
225 pub OPTION_MAP_UNWRAP_OR_ELSE,
227 "using `Option.map(f).unwrap_or_else(g)`, which is more succinctly expressed as `map_or_else(g, f)`"
230 declare_clippy_lint! {
231 /// **What it does:** Checks for usage of `result.map(_).unwrap_or_else(_)`.
233 /// **Why is this bad?** Readability, this can be written more concisely as
234 /// `result.ok().map_or_else(_, _)`.
236 /// **Known problems:** None.
240 /// # let x: Result<usize, ()> = Ok(1);
241 /// # fn some_function(foo: ()) -> usize { 1 }
242 /// x.map(|a| a + 1).unwrap_or_else(some_function);
244 pub RESULT_MAP_UNWRAP_OR_ELSE,
246 "using `Result.map(f).unwrap_or_else(g)`, which is more succinctly expressed as `.ok().map_or_else(g, f)`"
249 declare_clippy_lint! {
250 /// **What it does:** Checks for usage of `_.map_or(None, _)`.
252 /// **Why is this bad?** Readability, this can be written more concisely as
255 /// **Known problems:** The order of the arguments is not in execution order.
259 /// opt.map_or(None, |a| a + 1)
261 pub OPTION_MAP_OR_NONE,
263 "using `Option.map_or(None, f)`, which is more succinctly expressed as `and_then(f)`"
266 declare_clippy_lint! {
267 /// **What it does:** Checks for usage of `_.and_then(|x| Some(y))`.
269 /// **Why is this bad?** Readability, this can be written more concisely as
272 /// **Known problems:** None
277 /// let x = Some("foo");
278 /// let _ = x.and_then(|s| Some(s.len()));
281 /// The correct use would be:
284 /// let x = Some("foo");
285 /// let _ = x.map(|s| s.len());
287 pub OPTION_AND_THEN_SOME,
289 "using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`"
292 declare_clippy_lint! {
293 /// **What it does:** Checks for usage of `_.filter(_).next()`.
295 /// **Why is this bad?** Readability, this can be written more concisely as
298 /// **Known problems:** None.
302 /// # let vec = vec![1];
303 /// vec.iter().filter(|x| **x == 0).next();
305 /// Could be written as
307 /// # let vec = vec![1];
308 /// vec.iter().find(|x| **x == 0);
312 "using `filter(p).next()`, which is more succinctly expressed as `.find(p)`"
315 declare_clippy_lint! {
316 /// **What it does:** Checks for usage of `_.map(_).flatten(_)`,
318 /// **Why is this bad?** Readability, this can be written more concisely as a
319 /// single method call.
321 /// **Known problems:**
325 /// let vec = vec![vec![1]];
326 /// vec.iter().map(|x| x.iter()).flatten();
330 "using combinations of `flatten` and `map` which can usually be written as a single method call"
333 declare_clippy_lint! {
334 /// **What it does:** Checks for usage of `_.filter(_).map(_)`,
335 /// `_.filter(_).flat_map(_)`, `_.filter_map(_).flat_map(_)` and similar.
337 /// **Why is this bad?** Readability, this can be written more concisely as a
338 /// single method call.
340 /// **Known problems:** Often requires a condition + Option/Iterator creation
341 /// inside the closure.
345 /// let vec = vec![1];
346 /// vec.iter().filter(|x| **x == 0).map(|x| *x * 2);
350 "using combinations of `filter`, `map`, `filter_map` and `flat_map` which can usually be written as a single method call"
353 declare_clippy_lint! {
354 /// **What it does:** Checks for usage of `_.filter_map(_).next()`.
356 /// **Why is this bad?** Readability, this can be written more concisely as a
357 /// single method call.
359 /// **Known problems:** None
363 /// (0..3).filter_map(|x| if x == 2 { Some(x) } else { None }).next();
365 /// Can be written as
368 /// (0..3).find_map(|x| if x == 2 { Some(x) } else { None });
372 "using combination of `filter_map` and `next` which can usually be written as a single method call"
375 declare_clippy_lint! {
376 /// **What it does:** Checks for usage of `flat_map(|x| x)`.
378 /// **Why is this bad?** Readability, this can be written more concisely by using `flatten`.
380 /// **Known problems:** None
384 /// # let iter = vec![vec![0]].into_iter();
385 /// iter.flat_map(|x| x);
387 /// Can be written as
389 /// # let iter = vec![vec![0]].into_iter();
392 pub FLAT_MAP_IDENTITY,
394 "call to `flat_map` where `flatten` is sufficient"
397 declare_clippy_lint! {
398 /// **What it does:** Checks for usage of `_.find(_).map(_)`.
400 /// **Why is this bad?** Readability, this can be written more concisely as a
401 /// single method call.
403 /// **Known problems:** Often requires a condition + Option/Iterator creation
404 /// inside the closure.
408 /// (0..3).find(|x| *x == 2).map(|x| x * 2);
410 /// Can be written as
412 /// (0..3).find_map(|x| if x == 2 { Some(x * 2) } else { None });
416 "using a combination of `find` and `map` can usually be written as a single method call"
419 declare_clippy_lint! {
420 /// **What it does:** Checks for an iterator search (such as `find()`,
421 /// `position()`, or `rposition()`) followed by a call to `is_some()`.
423 /// **Why is this bad?** Readability, this can be written more concisely as
426 /// **Known problems:** None.
430 /// # let vec = vec![1];
431 /// vec.iter().find(|x| **x == 0).is_some();
433 /// Could be written as
435 /// # let vec = vec![1];
436 /// vec.iter().any(|x| *x == 0);
440 "using an iterator search followed by `is_some()`, which is more succinctly expressed as a call to `any()`"
443 declare_clippy_lint! {
444 /// **What it does:** Checks for usage of `.chars().next()` on a `str` to check
445 /// if it starts with a given char.
447 /// **Why is this bad?** Readability, this can be written more concisely as
448 /// `_.starts_with(_)`.
450 /// **Known problems:** None.
454 /// let name = "foo";
455 /// if name.chars().next() == Some('_') {};
457 /// Could be written as
459 /// let name = "foo";
460 /// if name.starts_with('_') {};
464 "using `.chars().next()` to check if a string starts with a char"
467 declare_clippy_lint! {
468 /// **What it does:** Checks for calls to `.or(foo(..))`, `.unwrap_or(foo(..))`,
469 /// etc., and suggests to use `or_else`, `unwrap_or_else`, etc., or
470 /// `unwrap_or_default` instead.
472 /// **Why is this bad?** The function will always be called and potentially
473 /// allocate an object acting as the default.
475 /// **Known problems:** If the function has side-effects, not calling it will
476 /// change the semantic of the program, but you shouldn't rely on that anyway.
480 /// # let foo = Some(String::new());
481 /// foo.unwrap_or(String::new());
483 /// this can instead be written:
485 /// # let foo = Some(String::new());
486 /// foo.unwrap_or_else(String::new);
490 /// # let foo = Some(String::new());
491 /// foo.unwrap_or_default();
495 "using any `*or` method with a function call, which suggests `*or_else`"
498 declare_clippy_lint! {
499 /// **What it does:** Checks for calls to `.expect(&format!(...))`, `.expect(foo(..))`,
500 /// etc., and suggests to use `unwrap_or_else` instead
502 /// **Why is this bad?** The function will always be called.
504 /// **Known problems:** If the function has side-effects, not calling it will
505 /// change the semantics of the program, but you shouldn't rely on that anyway.
509 /// # let foo = Some(String::new());
510 /// # let err_code = "418";
511 /// # let err_msg = "I'm a teapot";
512 /// foo.expect(&format!("Err {}: {}", err_code, err_msg));
516 /// # let foo = Some(String::new());
517 /// # let err_code = "418";
518 /// # let err_msg = "I'm a teapot";
519 /// foo.expect(format!("Err {}: {}", err_code, err_msg).as_str());
521 /// this can instead be written:
523 /// # let foo = Some(String::new());
524 /// # let err_code = "418";
525 /// # let err_msg = "I'm a teapot";
526 /// foo.unwrap_or_else(|| panic!("Err {}: {}", err_code, err_msg));
530 "using any `expect` method with a function call"
533 declare_clippy_lint! {
534 /// **What it does:** Checks for usage of `.clone()` on a `Copy` type.
536 /// **Why is this bad?** The only reason `Copy` types implement `Clone` is for
537 /// generics, not for using the `clone` method on a concrete type.
539 /// **Known problems:** None.
547 "using `clone` on a `Copy` type"
550 declare_clippy_lint! {
551 /// **What it does:** Checks for usage of `.clone()` on a ref-counted pointer,
552 /// (`Rc`, `Arc`, `rc::Weak`, or `sync::Weak`), and suggests calling Clone via unified
553 /// function syntax instead (e.g., `Rc::clone(foo)`).
555 /// **Why is this bad?** Calling '.clone()' on an Rc, Arc, or Weak
556 /// can obscure the fact that only the pointer is being cloned, not the underlying
561 /// # use std::rc::Rc;
562 /// let x = Rc::new(1);
565 pub CLONE_ON_REF_PTR,
567 "using 'clone' on a ref-counted pointer"
570 declare_clippy_lint! {
571 /// **What it does:** Checks for usage of `.clone()` on an `&&T`.
573 /// **Why is this bad?** Cloning an `&&T` copies the inner `&T`, instead of
574 /// cloning the underlying `T`.
576 /// **Known problems:** None.
583 /// let z = y.clone();
584 /// println!("{:p} {:p}", *y, z); // prints out the same pointer
587 pub CLONE_DOUBLE_REF,
589 "using `clone` on `&&T`"
592 declare_clippy_lint! {
593 /// **What it does:** Checks for `new` not returning `Self`.
595 /// **Why is this bad?** As a convention, `new` methods are used to make a new
596 /// instance of a type.
598 /// **Known problems:** None.
603 /// fn new(..) -> NotAFoo {
609 "not returning `Self` in a `new` method"
612 declare_clippy_lint! {
613 /// **What it does:** Checks for string methods that receive a single-character
614 /// `str` as an argument, e.g., `_.split("x")`.
616 /// **Why is this bad?** Performing these methods using a `char` is faster than
619 /// **Known problems:** Does not catch multi-byte unicode characters.
622 /// `_.split("x")` could be `_.split('x')`
623 pub SINGLE_CHAR_PATTERN,
625 "using a single-character str where a char could be used, e.g., `_.split(\"x\")`"
628 declare_clippy_lint! {
629 /// **What it does:** Checks for getting the inner pointer of a temporary
632 /// **Why is this bad?** The inner pointer of a `CString` is only valid as long
633 /// as the `CString` is alive.
635 /// **Known problems:** None.
639 /// let c_str = CString::new("foo").unwrap().as_ptr();
641 /// call_some_ffi_func(c_str);
644 /// Here `c_str` point to a freed address. The correct use would be:
646 /// let c_str = CString::new("foo").unwrap();
648 /// call_some_ffi_func(c_str.as_ptr());
651 pub TEMPORARY_CSTRING_AS_PTR,
653 "getting the inner pointer of a temporary `CString`"
656 declare_clippy_lint! {
657 /// **What it does:** Checks for use of `.iter().nth()` (and the related
658 /// `.iter_mut().nth()`) on standard library types with O(1) element access.
660 /// **Why is this bad?** `.get()` and `.get_mut()` are more efficient and more
663 /// **Known problems:** None.
667 /// let some_vec = vec![0, 1, 2, 3];
668 /// let bad_vec = some_vec.iter().nth(3);
669 /// let bad_slice = &some_vec[..].iter().nth(3);
671 /// The correct use would be:
673 /// let some_vec = vec![0, 1, 2, 3];
674 /// let bad_vec = some_vec.get(3);
675 /// let bad_slice = &some_vec[..].get(3);
679 "using `.iter().nth()` on a standard library type with O(1) element access"
682 declare_clippy_lint! {
683 /// **What it does:** Checks for use of `.skip(x).next()` on iterators.
685 /// **Why is this bad?** `.nth(x)` is cleaner
687 /// **Known problems:** None.
691 /// let some_vec = vec![0, 1, 2, 3];
692 /// let bad_vec = some_vec.iter().skip(3).next();
693 /// let bad_slice = &some_vec[..].iter().skip(3).next();
695 /// The correct use would be:
697 /// let some_vec = vec![0, 1, 2, 3];
698 /// let bad_vec = some_vec.iter().nth(3);
699 /// let bad_slice = &some_vec[..].iter().nth(3);
703 "using `.skip(x).next()` on an iterator"
706 declare_clippy_lint! {
707 /// **What it does:** Checks for use of `.get().unwrap()` (or
708 /// `.get_mut().unwrap`) on a standard library type which implements `Index`
710 /// **Why is this bad?** Using the Index trait (`[]`) is more clear and more
713 /// **Known problems:** Not a replacement for error handling: Using either
714 /// `.unwrap()` or the Index trait (`[]`) carries the risk of causing a `panic`
715 /// if the value being accessed is `None`. If the use of `.get().unwrap()` is a
716 /// temporary placeholder for dealing with the `Option` type, then this does
717 /// not mitigate the need for error handling. If there is a chance that `.get()`
718 /// will be `None` in your program, then it is advisable that the `None` case
719 /// is handled in a future refactor instead of using `.unwrap()` or the Index
724 /// let mut some_vec = vec![0, 1, 2, 3];
725 /// let last = some_vec.get(3).unwrap();
726 /// *some_vec.get_mut(0).unwrap() = 1;
728 /// The correct use would be:
730 /// let mut some_vec = vec![0, 1, 2, 3];
731 /// let last = some_vec[3];
736 "using `.get().unwrap()` or `.get_mut().unwrap()` when using `[]` would work instead"
739 declare_clippy_lint! {
740 /// **What it does:** Checks for the use of `.extend(s.chars())` where s is a
741 /// `&str` or `String`.
743 /// **Why is this bad?** `.push_str(s)` is clearer
745 /// **Known problems:** None.
750 /// let def = String::from("def");
751 /// let mut s = String::new();
752 /// s.extend(abc.chars());
753 /// s.extend(def.chars());
755 /// The correct use would be:
758 /// let def = String::from("def");
759 /// let mut s = String::new();
761 /// s.push_str(&def);
763 pub STRING_EXTEND_CHARS,
765 "using `x.extend(s.chars())` where s is a `&str` or `String`"
768 declare_clippy_lint! {
769 /// **What it does:** Checks for the use of `.cloned().collect()` on slice to
772 /// **Why is this bad?** `.to_vec()` is clearer
774 /// **Known problems:** None.
778 /// let s = [1, 2, 3, 4, 5];
779 /// let s2: Vec<isize> = s[..].iter().cloned().collect();
781 /// The better use would be:
783 /// let s = [1, 2, 3, 4, 5];
784 /// let s2: Vec<isize> = s.to_vec();
786 pub ITER_CLONED_COLLECT,
788 "using `.cloned().collect()` on slice to create a `Vec`"
791 declare_clippy_lint! {
792 /// **What it does:** Checks for usage of `.chars().last()` or
793 /// `.chars().next_back()` on a `str` to check if it ends with a given char.
795 /// **Why is this bad?** Readability, this can be written more concisely as
796 /// `_.ends_with(_)`.
798 /// **Known problems:** None.
802 /// name.chars().last() == Some('_') || name.chars().next_back() == Some('-')
806 "using `.chars().last()` or `.chars().next_back()` to check if a string ends with a char"
809 declare_clippy_lint! {
810 /// **What it does:** Checks for usage of `.as_ref()` or `.as_mut()` where the
811 /// types before and after the call are the same.
813 /// **Why is this bad?** The call is unnecessary.
815 /// **Known problems:** None.
819 /// # fn do_stuff(x: &[i32]) {}
820 /// let x: &[i32] = &[1, 2, 3, 4, 5];
821 /// do_stuff(x.as_ref());
823 /// The correct use would be:
825 /// # fn do_stuff(x: &[i32]) {}
826 /// let x: &[i32] = &[1, 2, 3, 4, 5];
831 "using `as_ref` where the types before and after the call are the same"
834 declare_clippy_lint! {
835 /// **What it does:** Checks for using `fold` when a more succinct alternative exists.
836 /// Specifically, this checks for `fold`s which could be replaced by `any`, `all`,
837 /// `sum` or `product`.
839 /// **Why is this bad?** Readability.
841 /// **Known problems:** False positive in pattern guards. Will be resolved once
842 /// non-lexical lifetimes are stable.
846 /// let _ = (0..3).fold(false, |acc, x| acc || x > 2);
848 /// This could be written as:
850 /// let _ = (0..3).any(|x| x > 2);
852 pub UNNECESSARY_FOLD,
854 "using `fold` when a more succinct alternative exists"
857 declare_clippy_lint! {
858 /// **What it does:** Checks for `filter_map` calls which could be replaced by `filter` or `map`.
859 /// More specifically it checks if the closure provided is only performing one of the
860 /// filter or map operations and suggests the appropriate option.
862 /// **Why is this bad?** Complexity. The intent is also clearer if only a single
863 /// operation is being performed.
865 /// **Known problems:** None
869 /// let _ = (0..3).filter_map(|x| if x > 2 { Some(x) } else { None });
871 /// As there is no transformation of the argument this could be written as:
873 /// let _ = (0..3).filter(|&x| x > 2);
877 /// let _ = (0..4).filter_map(i32::checked_abs);
879 /// As there is no conditional check on the argument this could be written as:
881 /// let _ = (0..4).map(i32::checked_abs);
883 pub UNNECESSARY_FILTER_MAP,
885 "using `filter_map` when a more succinct alternative exists"
888 declare_clippy_lint! {
889 /// **What it does:** Checks for `into_iter` calls on types which should be replaced by `iter` or
892 /// **Why is this bad?** Arrays and `PathBuf` do not yet have an `into_iter` method which move out
893 /// their content into an iterator. Auto-referencing resolves the `into_iter` call to its reference
894 /// instead, like `<&[T; N] as IntoIterator>::into_iter`, which just iterates over item references
895 /// like calling `iter` would. Furthermore, when the standard library actually
896 /// [implements the `into_iter` method](https://github.com/rust-lang/rust/issues/25725) which moves
897 /// the content out of the array, the original use of `into_iter` got inferred with the wrong type
898 /// and the code will be broken.
900 /// **Known problems:** None
905 /// let _ = [1, 2, 3].into_iter().map(|x| *x).collect::<Vec<u32>>();
907 /// Could be written as:
909 /// let _ = [1, 2, 3].iter().map(|x| *x).collect::<Vec<u32>>();
911 pub INTO_ITER_ON_ARRAY,
913 "using `.into_iter()` on an array"
916 declare_clippy_lint! {
917 /// **What it does:** Checks for `into_iter` calls on references which should be replaced by `iter`
920 /// **Why is this bad?** Readability. Calling `into_iter` on a reference will not move out its
921 /// content into the resulting iterator, which is confusing. It is better just call `iter` or
922 /// `iter_mut` directly.
924 /// **Known problems:** None
929 /// let _ = (&vec![3, 4, 5]).into_iter();
931 pub INTO_ITER_ON_REF,
933 "using `.into_iter()` on a reference"
936 declare_clippy_lint! {
937 /// **What it does:** Checks for calls to `map` followed by a `count`.
939 /// **Why is this bad?** It looks suspicious. Maybe `map` was confused with `filter`.
940 /// If the `map` call is intentional, this should be rewritten.
942 /// **Known problems:** None
947 /// let _ = (0..3).map(|x| x + 2).count();
951 "suspicious usage of map"
954 declare_clippy_lint! {
955 /// **What it does:** Checks for `MaybeUninit::uninit().assume_init()`.
957 /// **Why is this bad?** For most types, this is undefined behavior.
959 /// **Known problems:** For now, we accept empty tuples and tuples / arrays
960 /// of `MaybeUninit`. There may be other types that allow uninitialized
961 /// data, but those are not yet rigorously defined.
967 /// use std::mem::MaybeUninit;
969 /// let _: usize = unsafe { MaybeUninit::uninit().assume_init() };
972 /// Note that the following is OK:
975 /// use std::mem::MaybeUninit;
977 /// let _: [MaybeUninit<bool>; 5] = unsafe {
978 /// MaybeUninit::uninit().assume_init()
981 pub UNINIT_ASSUMED_INIT,
983 "`MaybeUninit::uninit().assume_init()`"
986 declare_lint_pass!(Methods => [
989 SHOULD_IMPLEMENT_TRAIT,
990 WRONG_SELF_CONVENTION,
991 WRONG_PUB_SELF_CONVENTION,
993 OPTION_MAP_UNWRAP_OR,
994 OPTION_MAP_UNWRAP_OR_ELSE,
995 RESULT_MAP_UNWRAP_OR_ELSE,
997 OPTION_AND_THEN_SOME,
1006 SINGLE_CHAR_PATTERN,
1008 TEMPORARY_CSTRING_AS_PTR,
1018 STRING_EXTEND_CHARS,
1019 ITER_CLONED_COLLECT,
1022 UNNECESSARY_FILTER_MAP,
1026 UNINIT_ASSUMED_INIT,
1029 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Methods {
1030 #[allow(clippy::cognitive_complexity)]
1031 fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) {
1032 if in_macro(expr.span) {
1036 let (method_names, arg_lists, method_spans) = method_calls(expr, 2);
1037 let method_names: Vec<LocalInternedString> = method_names.iter().map(|s| s.as_str()).collect();
1038 let method_names: Vec<&str> = method_names.iter().map(std::convert::AsRef::as_ref).collect();
1040 match method_names.as_slice() {
1041 ["unwrap", "get"] => lint_get_unwrap(cx, expr, arg_lists[1], false),
1042 ["unwrap", "get_mut"] => lint_get_unwrap(cx, expr, arg_lists[1], true),
1043 ["unwrap", ..] => lint_unwrap(cx, expr, arg_lists[0]),
1044 ["expect", "ok"] => lint_ok_expect(cx, expr, arg_lists[1]),
1045 ["unwrap_or", "map"] => option_map_unwrap_or::lint(cx, expr, arg_lists[1], arg_lists[0]),
1046 ["unwrap_or_else", "map"] => lint_map_unwrap_or_else(cx, expr, arg_lists[1], arg_lists[0]),
1047 ["map_or", ..] => lint_map_or_none(cx, expr, arg_lists[0]),
1048 ["and_then", ..] => lint_option_and_then_some(cx, expr, arg_lists[0]),
1049 ["next", "filter"] => lint_filter_next(cx, expr, arg_lists[1]),
1050 ["map", "filter"] => lint_filter_map(cx, expr, arg_lists[1], arg_lists[0]),
1051 ["map", "filter_map"] => lint_filter_map_map(cx, expr, arg_lists[1], arg_lists[0]),
1052 ["next", "filter_map"] => lint_filter_map_next(cx, expr, arg_lists[1]),
1053 ["map", "find"] => lint_find_map(cx, expr, arg_lists[1], arg_lists[0]),
1054 ["flat_map", "filter"] => lint_filter_flat_map(cx, expr, arg_lists[1], arg_lists[0]),
1055 ["flat_map", "filter_map"] => lint_filter_map_flat_map(cx, expr, arg_lists[1], arg_lists[0]),
1056 ["flat_map", ..] => lint_flat_map_identity(cx, expr, arg_lists[0], method_spans[0]),
1057 ["flatten", "map"] => lint_map_flatten(cx, expr, arg_lists[1]),
1058 ["is_some", "find"] => lint_search_is_some(cx, expr, "find", arg_lists[1], arg_lists[0], method_spans[1]),
1059 ["is_some", "position"] => {
1060 lint_search_is_some(cx, expr, "position", arg_lists[1], arg_lists[0], method_spans[1])
1062 ["is_some", "rposition"] => {
1063 lint_search_is_some(cx, expr, "rposition", arg_lists[1], arg_lists[0], method_spans[1])
1065 ["extend", ..] => lint_extend(cx, expr, arg_lists[0]),
1066 ["as_ptr", "unwrap"] | ["as_ptr", "expect"] => {
1067 lint_cstring_as_ptr(cx, expr, &arg_lists[1][0], &arg_lists[0][0])
1069 ["nth", "iter"] => lint_iter_nth(cx, expr, arg_lists[1], false),
1070 ["nth", "iter_mut"] => lint_iter_nth(cx, expr, arg_lists[1], true),
1071 ["next", "skip"] => lint_iter_skip_next(cx, expr),
1072 ["collect", "cloned"] => lint_iter_cloned_collect(cx, expr, arg_lists[1]),
1073 ["as_ref"] => lint_asref(cx, expr, "as_ref", arg_lists[0]),
1074 ["as_mut"] => lint_asref(cx, expr, "as_mut", arg_lists[0]),
1075 ["fold", ..] => lint_unnecessary_fold(cx, expr, arg_lists[0], method_spans[0]),
1076 ["filter_map", ..] => unnecessary_filter_map::lint(cx, expr, arg_lists[0]),
1077 ["count", "map"] => lint_suspicious_map(cx, expr),
1078 ["assume_init"] => lint_maybe_uninit(cx, &arg_lists[0][0], expr),
1083 hir::ExprKind::MethodCall(ref method_call, ref method_span, ref args) => {
1084 lint_or_fun_call(cx, expr, *method_span, &method_call.ident.as_str(), args);
1085 lint_expect_fun_call(cx, expr, *method_span, &method_call.ident.as_str(), args);
1087 let self_ty = cx.tables.expr_ty_adjusted(&args[0]);
1088 if args.len() == 1 && method_call.ident.name == sym!(clone) {
1089 lint_clone_on_copy(cx, expr, &args[0], self_ty);
1090 lint_clone_on_ref_ptr(cx, expr, &args[0]);
1094 ty::Ref(_, ty, _) if ty.sty == ty::Str => {
1095 for &(method, pos) in &PATTERN_METHODS {
1096 if method_call.ident.name.as_str() == method && args.len() > pos {
1097 lint_single_char_pattern(cx, expr, &args[pos]);
1101 ty::Ref(..) if method_call.ident.name == sym!(into_iter) => {
1102 lint_into_iter(cx, expr, self_ty, *method_span);
1107 hir::ExprKind::Binary(op, ref lhs, ref rhs)
1108 if op.node == hir::BinOpKind::Eq || op.node == hir::BinOpKind::Ne =>
1110 let mut info = BinaryExprInfo {
1114 eq: op.node == hir::BinOpKind::Eq,
1116 lint_binary_expr_with_method_call(cx, &mut info);
1122 fn check_impl_item(&mut self, cx: &LateContext<'a, 'tcx>, impl_item: &'tcx hir::ImplItem) {
1123 if in_external_macro(cx.sess(), impl_item.span) {
1126 let name = impl_item.ident.name.as_str();
1127 let parent = cx.tcx.hir().get_parent_item(impl_item.hir_id);
1128 let item = cx.tcx.hir().expect_item(parent);
1129 let def_id = cx.tcx.hir().local_def_id(item.hir_id);
1130 let ty = cx.tcx.type_of(def_id);
1132 if let hir::ImplItemKind::Method(ref sig, id) = impl_item.node;
1133 if let Some(first_arg) = iter_input_pats(&sig.decl, cx.tcx.hir().body(id)).next();
1134 if let hir::ItemKind::Impl(_, _, _, _, None, _, _) = item.node;
1136 let method_def_id = cx.tcx.hir().local_def_id(impl_item.hir_id);
1137 let method_sig = cx.tcx.fn_sig(method_def_id);
1138 let method_sig = cx.tcx.erase_late_bound_regions(&method_sig);
1140 let first_arg_ty = &method_sig.inputs().iter().next();
1142 // check conventions w.r.t. conversion method names and predicates
1143 if let Some(first_arg_ty) = first_arg_ty;
1146 if cx.access_levels.is_exported(impl_item.hir_id) {
1147 // check missing trait implementations
1148 for &(method_name, n_args, self_kind, out_type, trait_name) in &TRAIT_METHODS {
1149 if name == method_name &&
1150 sig.decl.inputs.len() == n_args &&
1151 out_type.matches(cx, &sig.decl.output) &&
1152 self_kind.matches(cx, ty, first_arg_ty) {
1153 span_lint(cx, SHOULD_IMPLEMENT_TRAIT, impl_item.span, &format!(
1154 "defining a method called `{}` on this type; consider implementing \
1155 the `{}` trait or choosing a less ambiguous name", name, trait_name));
1160 if let Some((ref conv, self_kinds)) = &CONVENTIONS
1162 .find(|(ref conv, _)| conv.check(&name))
1164 if !self_kinds.iter().any(|k| k.matches(cx, ty, first_arg_ty)) {
1165 let lint = if item.vis.node.is_pub() {
1166 WRONG_PUB_SELF_CONVENTION
1168 WRONG_SELF_CONVENTION
1176 "methods called `{}` usually take {}; consider choosing a less \
1181 .map(|k| k.description())
1182 .collect::<Vec<_>>()
1191 if let hir::ImplItemKind::Method(_, _) = impl_item.node {
1192 let ret_ty = return_ty(cx, impl_item.hir_id);
1194 // walk the return type and check for Self (this does not check associated types)
1195 if ret_ty.walk().any(|inner_type| same_tys(cx, ty, inner_type)) {
1199 // if return type is impl trait, check the associated types
1200 if let ty::Opaque(def_id, _) = ret_ty.sty {
1201 // one of the associated types must be Self
1202 for predicate in &cx.tcx.predicates_of(def_id).predicates {
1204 (Predicate::Projection(poly_projection_predicate), _) => {
1205 let binder = poly_projection_predicate.ty();
1206 let associated_type = binder.skip_binder();
1208 // walk the associated type and check for Self
1209 for inner_type in associated_type.walk() {
1210 if same_tys(cx, ty, inner_type) {
1220 if name == "new" && !same_tys(cx, ret_ty, ty) {
1225 "methods called `new` usually return `Self`",
1232 /// Checks for the `OR_FUN_CALL` lint.
1233 #[allow(clippy::too_many_lines)]
1234 fn lint_or_fun_call<'a, 'tcx>(
1235 cx: &LateContext<'a, 'tcx>,
1239 args: &'tcx [hir::Expr],
1241 // Searches an expression for method calls or function calls that aren't ctors
1242 struct FunCallFinder<'a, 'tcx> {
1243 cx: &'a LateContext<'a, 'tcx>,
1247 impl<'a, 'tcx> intravisit::Visitor<'tcx> for FunCallFinder<'a, 'tcx> {
1248 fn visit_expr(&mut self, expr: &'tcx hir::Expr) {
1249 let call_found = match &expr.node {
1250 // ignore enum and struct constructors
1251 hir::ExprKind::Call(..) => !is_ctor_function(self.cx, expr),
1252 hir::ExprKind::MethodCall(..) => true,
1257 // don't lint for constant values
1258 let owner_def = self.cx.tcx.hir().get_parent_did(expr.hir_id);
1259 let promotable = self
1262 .rvalue_promotable_map(owner_def)
1263 .contains(&expr.hir_id.local_id);
1270 intravisit::walk_expr(self, expr);
1274 fn nested_visit_map<'this>(&'this mut self) -> intravisit::NestedVisitorMap<'this, 'tcx> {
1275 intravisit::NestedVisitorMap::None
1279 /// Checks for `unwrap_or(T::new())` or `unwrap_or(T::default())`.
1280 fn check_unwrap_or_default(
1281 cx: &LateContext<'_, '_>,
1284 self_expr: &hir::Expr,
1291 if name == "unwrap_or";
1292 if let hir::ExprKind::Path(ref qpath) = fun.node;
1293 let path = &*last_path_segment(qpath).ident.as_str();
1294 if ["default", "new"].contains(&path);
1295 let arg_ty = cx.tables.expr_ty(arg);
1296 if let Some(default_trait_id) = get_trait_def_id(cx, &paths::DEFAULT_TRAIT);
1297 if implements_trait(cx, arg_ty, default_trait_id, &[]);
1300 let mut applicability = Applicability::MachineApplicable;
1305 &format!("use of `{}` followed by a call to `{}`", name, path),
1308 "{}.unwrap_or_default()",
1309 snippet_with_applicability(cx, self_expr.span, "_", &mut applicability)
1321 /// Checks for `*or(foo())`.
1322 #[allow(clippy::too_many_arguments)]
1323 fn check_general_case<'a, 'tcx>(
1324 cx: &LateContext<'a, 'tcx>,
1328 self_expr: &hir::Expr,
1329 arg: &'tcx hir::Expr,
1333 // (path, fn_has_argument, methods, suffix)
1334 let know_types: &[(&[_], _, &[_], _)] = &[
1335 (&paths::BTREEMAP_ENTRY, false, &["or_insert"], "with"),
1336 (&paths::HASHMAP_ENTRY, false, &["or_insert"], "with"),
1337 (&paths::OPTION, false, &["map_or", "ok_or", "or", "unwrap_or"], "else"),
1338 (&paths::RESULT, true, &["or", "unwrap_or"], "else"),
1342 if know_types.iter().any(|k| k.2.contains(&name));
1344 let mut finder = FunCallFinder { cx: &cx, found: false };
1345 if { finder.visit_expr(&arg); finder.found };
1347 let self_ty = cx.tables.expr_ty(self_expr);
1349 if let Some(&(_, fn_has_arguments, poss, suffix)) =
1350 know_types.iter().find(|&&i| match_type(cx, self_ty, i.0));
1352 if poss.contains(&name);
1355 let sugg: Cow<'_, _> = match (fn_has_arguments, !or_has_args) {
1356 (true, _) => format!("|_| {}", snippet_with_macro_callsite(cx, arg.span, "..")).into(),
1357 (false, false) => format!("|| {}", snippet_with_macro_callsite(cx, arg.span, "..")).into(),
1358 (false, true) => snippet_with_macro_callsite(cx, fun_span, ".."),
1360 let span_replace_word = method_span.with_hi(span.hi());
1365 &format!("use of `{}` followed by a function call", name),
1367 format!("{}_{}({})", name, suffix, sugg),
1368 Applicability::HasPlaceholders,
1374 if args.len() == 2 {
1375 match args[1].node {
1376 hir::ExprKind::Call(ref fun, ref or_args) => {
1377 let or_has_args = !or_args.is_empty();
1378 if !check_unwrap_or_default(cx, name, fun, &args[0], &args[1], or_has_args, expr.span) {
1391 hir::ExprKind::MethodCall(_, span, ref or_args) => check_general_case(
1398 !or_args.is_empty(),
1406 /// Checks for the `EXPECT_FUN_CALL` lint.
1407 #[allow(clippy::too_many_lines)]
1408 fn lint_expect_fun_call(cx: &LateContext<'_, '_>, expr: &hir::Expr, method_span: Span, name: &str, args: &[hir::Expr]) {
1409 // Strip `&`, `as_ref()` and `as_str()` off `arg` until we're left with either a `String` or
1411 fn get_arg_root<'a>(cx: &LateContext<'_, '_>, arg: &'a hir::Expr) -> &'a hir::Expr {
1412 let mut arg_root = arg;
1414 arg_root = match &arg_root.node {
1415 hir::ExprKind::AddrOf(_, expr) => expr,
1416 hir::ExprKind::MethodCall(method_name, _, call_args) => {
1417 if call_args.len() == 1
1418 && (method_name.ident.name == sym!(as_str) || method_name.ident.name == sym!(as_ref))
1420 let arg_type = cx.tables.expr_ty(&call_args[0]);
1421 let base_type = walk_ptrs_ty(arg_type);
1422 base_type.sty == ty::Str || match_type(cx, base_type, &paths::STRING)
1436 // Only `&'static str` or `String` can be used directly in the `panic!`. Other types should be
1437 // converted to string.
1438 fn requires_to_string(cx: &LateContext<'_, '_>, arg: &hir::Expr) -> bool {
1439 let arg_ty = cx.tables.expr_ty(arg);
1440 if match_type(cx, arg_ty, &paths::STRING) {
1443 if let ty::Ref(ty::ReStatic, ty, ..) = arg_ty.sty {
1444 if ty.sty == ty::Str {
1451 fn generate_format_arg_snippet(
1452 cx: &LateContext<'_, '_>,
1454 applicability: &mut Applicability,
1457 if let hir::ExprKind::AddrOf(_, ref format_arg) = a.node;
1458 if let hir::ExprKind::Match(ref format_arg_expr, _, _) = format_arg.node;
1459 if let hir::ExprKind::Tup(ref format_arg_expr_tup) = format_arg_expr.node;
1464 .map(|a| snippet_with_applicability(cx, a.span, "..", applicability).into_owned())
1472 fn is_call(node: &hir::ExprKind) -> bool {
1474 hir::ExprKind::AddrOf(_, expr) => {
1477 hir::ExprKind::Call(..)
1478 | hir::ExprKind::MethodCall(..)
1479 // These variants are debatable or require further examination
1480 | hir::ExprKind::Match(..)
1481 | hir::ExprKind::Block{ .. } => true,
1486 if args.len() != 2 || name != "expect" || !is_call(&args[1].node) {
1490 let receiver_type = cx.tables.expr_ty(&args[0]);
1491 let closure_args = if match_type(cx, receiver_type, &paths::OPTION) {
1493 } else if match_type(cx, receiver_type, &paths::RESULT) {
1499 let arg_root = get_arg_root(cx, &args[1]);
1501 let span_replace_word = method_span.with_hi(expr.span.hi());
1503 let mut applicability = Applicability::MachineApplicable;
1505 //Special handling for `format!` as arg_root
1506 if let hir::ExprKind::Call(ref inner_fun, ref inner_args) = arg_root.node {
1507 if is_expn_of(inner_fun.span, "format").is_some() && inner_args.len() == 1 {
1508 if let hir::ExprKind::Call(_, format_args) = &inner_args[0].node {
1509 let fmt_spec = &format_args[0];
1510 let fmt_args = &format_args[1];
1512 let mut args = vec![snippet(cx, fmt_spec.span, "..").into_owned()];
1514 args.extend(generate_format_arg_snippet(cx, fmt_args, &mut applicability));
1516 let sugg = args.join(", ");
1522 &format!("use of `{}` followed by a function call", name),
1524 format!("unwrap_or_else({} panic!({}))", closure_args, sugg),
1533 let mut arg_root_snippet: Cow<'_, _> = snippet_with_applicability(cx, arg_root.span, "..", &mut applicability);
1534 if requires_to_string(cx, arg_root) {
1535 arg_root_snippet.to_mut().push_str(".to_string()");
1542 &format!("use of `{}` followed by a function call", name),
1544 format!("unwrap_or_else({} {{ panic!({}) }})", closure_args, arg_root_snippet),
1549 /// Checks for the `CLONE_ON_COPY` lint.
1550 fn lint_clone_on_copy(cx: &LateContext<'_, '_>, expr: &hir::Expr, arg: &hir::Expr, arg_ty: Ty<'_>) {
1551 let ty = cx.tables.expr_ty(expr);
1552 if let ty::Ref(_, inner, _) = arg_ty.sty {
1553 if let ty::Ref(_, innermost, _) = inner.sty {
1558 "using `clone` on a double-reference; \
1559 this will copy the reference instead of cloning the inner type",
1561 if let Some(snip) = sugg::Sugg::hir_opt(cx, arg) {
1562 let mut ty = innermost;
1564 while let ty::Ref(_, inner, _) = ty.sty {
1568 let refs: String = iter::repeat('&').take(n + 1).collect();
1569 let derefs: String = iter::repeat('*').take(n).collect();
1570 let explicit = format!("{}{}::clone({})", refs, ty, snip);
1573 "try dereferencing it",
1574 format!("{}({}{}).clone()", refs, derefs, snip.deref()),
1575 Applicability::MaybeIncorrect,
1579 "or try being explicit about what type to clone",
1581 Applicability::MaybeIncorrect,
1586 return; // don't report clone_on_copy
1590 if is_copy(cx, ty) {
1592 if let Some(snippet) = sugg::Sugg::hir_opt(cx, arg) {
1593 let parent = cx.tcx.hir().get_parent_node(expr.hir_id);
1594 match &cx.tcx.hir().get(parent) {
1595 hir::Node::Expr(parent) => match parent.node {
1596 // &*x is a nop, &x.clone() is not
1597 hir::ExprKind::AddrOf(..) |
1598 // (*x).func() is useless, x.clone().func() can work in case func borrows mutably
1599 hir::ExprKind::MethodCall(..) => return,
1602 hir::Node::Stmt(stmt) => {
1603 if let hir::StmtKind::Local(ref loc) = stmt.node {
1604 if let hir::PatKind::Ref(..) = loc.pat.node {
1605 // let ref y = *x borrows x, let ref y = x.clone() does not
1613 // x.clone() might have dereferenced x, possibly through Deref impls
1614 if cx.tables.expr_ty(arg) == ty {
1615 snip = Some(("try removing the `clone` call", format!("{}", snippet)));
1617 let deref_count = cx
1619 .expr_adjustments(arg)
1622 if let ty::adjustment::Adjust::Deref(_) = adj.kind {
1629 let derefs: String = iter::repeat('*').take(deref_count).collect();
1630 snip = Some(("try dereferencing it", format!("{}{}", derefs, snippet)));
1635 span_lint_and_then(cx, CLONE_ON_COPY, expr.span, "using `clone` on a `Copy` type", |db| {
1636 if let Some((text, snip)) = snip {
1637 db.span_suggestion(expr.span, text, snip, Applicability::Unspecified);
1643 fn lint_clone_on_ref_ptr(cx: &LateContext<'_, '_>, expr: &hir::Expr, arg: &hir::Expr) {
1644 let obj_ty = walk_ptrs_ty(cx.tables.expr_ty(arg));
1646 if let ty::Adt(_, subst) = obj_ty.sty {
1647 let caller_type = if match_type(cx, obj_ty, &paths::RC) {
1649 } else if match_type(cx, obj_ty, &paths::ARC) {
1651 } else if match_type(cx, obj_ty, &paths::WEAK_RC) || match_type(cx, obj_ty, &paths::WEAK_ARC) {
1661 "using '.clone()' on a ref-counted pointer",
1664 "{}::<{}>::clone(&{})",
1667 snippet(cx, arg.span, "_")
1669 Applicability::Unspecified, // Sometimes unnecessary ::<_> after Rc/Arc/Weak
1674 fn lint_string_extend(cx: &LateContext<'_, '_>, expr: &hir::Expr, args: &[hir::Expr]) {
1676 if let Some(arglists) = method_chain_args(arg, &["chars"]) {
1677 let target = &arglists[0][0];
1678 let self_ty = walk_ptrs_ty(cx.tables.expr_ty(target));
1679 let ref_str = if self_ty.sty == ty::Str {
1681 } else if match_type(cx, self_ty, &paths::STRING) {
1687 let mut applicability = Applicability::MachineApplicable;
1690 STRING_EXTEND_CHARS,
1692 "calling `.extend(_.chars())`",
1695 "{}.push_str({}{})",
1696 snippet_with_applicability(cx, args[0].span, "_", &mut applicability),
1698 snippet_with_applicability(cx, target.span, "_", &mut applicability)
1705 fn lint_extend(cx: &LateContext<'_, '_>, expr: &hir::Expr, args: &[hir::Expr]) {
1706 let obj_ty = walk_ptrs_ty(cx.tables.expr_ty(&args[0]));
1707 if match_type(cx, obj_ty, &paths::STRING) {
1708 lint_string_extend(cx, expr, args);
1712 fn lint_cstring_as_ptr(cx: &LateContext<'_, '_>, expr: &hir::Expr, source: &hir::Expr, unwrap: &hir::Expr) {
1714 let source_type = cx.tables.expr_ty(source);
1715 if let ty::Adt(def, substs) = source_type.sty;
1716 if match_def_path(cx, def.did, &paths::RESULT);
1717 if match_type(cx, substs.type_at(0), &paths::CSTRING);
1721 TEMPORARY_CSTRING_AS_PTR,
1723 "you are getting the inner pointer of a temporary `CString`",
1725 db.note("that pointer will be invalid outside this expression");
1726 db.span_help(unwrap.span, "assign the `CString` to a variable to extend its lifetime");
1732 fn lint_iter_cloned_collect<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &hir::Expr, iter_args: &'tcx [hir::Expr]) {
1734 if match_type(cx, cx.tables.expr_ty(expr), &paths::VEC);
1735 if let Some(slice) = derefs_to_slice(cx, &iter_args[0], cx.tables.expr_ty(&iter_args[0]));
1736 if let Some(to_replace) = expr.span.trim_start(slice.span.source_callsite());
1741 ITER_CLONED_COLLECT,
1743 "called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and \
1746 ".to_vec()".to_string(),
1747 Applicability::MachineApplicable,
1753 fn lint_unnecessary_fold(cx: &LateContext<'_, '_>, expr: &hir::Expr, fold_args: &[hir::Expr], fold_span: Span) {
1754 fn check_fold_with_op(
1755 cx: &LateContext<'_, '_>,
1757 fold_args: &[hir::Expr],
1760 replacement_method_name: &str,
1761 replacement_has_args: bool,
1764 // Extract the body of the closure passed to fold
1765 if let hir::ExprKind::Closure(_, _, body_id, _, _) = fold_args[2].node;
1766 let closure_body = cx.tcx.hir().body(body_id);
1767 let closure_expr = remove_blocks(&closure_body.value);
1769 // Check if the closure body is of the form `acc <op> some_expr(x)`
1770 if let hir::ExprKind::Binary(ref bin_op, ref left_expr, ref right_expr) = closure_expr.node;
1771 if bin_op.node == op;
1773 // Extract the names of the two arguments to the closure
1774 if let Some(first_arg_ident) = get_arg_name(&closure_body.params[0].pat);
1775 if let Some(second_arg_ident) = get_arg_name(&closure_body.params[1].pat);
1777 if match_var(&*left_expr, first_arg_ident);
1778 if replacement_has_args || match_var(&*right_expr, second_arg_ident);
1781 let mut applicability = Applicability::MachineApplicable;
1782 let sugg = if replacement_has_args {
1784 "{replacement}(|{s}| {r})",
1785 replacement = replacement_method_name,
1786 s = second_arg_ident,
1787 r = snippet_with_applicability(cx, right_expr.span, "EXPR", &mut applicability),
1792 replacement = replacement_method_name,
1799 fold_span.with_hi(expr.span.hi()),
1800 // TODO #2371 don't suggest e.g., .any(|x| f(x)) if we can suggest .any(f)
1801 "this `.fold` can be written more succinctly using another method",
1810 // Check that this is a call to Iterator::fold rather than just some function called fold
1811 if !match_trait_method(cx, expr, &paths::ITERATOR) {
1816 fold_args.len() == 3,
1817 "Expected fold_args to have three entries - the receiver, the initial value and the closure"
1820 // Check if the first argument to .fold is a suitable literal
1821 if let hir::ExprKind::Lit(ref lit) = fold_args[1].node {
1823 ast::LitKind::Bool(false) => {
1824 check_fold_with_op(cx, expr, fold_args, fold_span, hir::BinOpKind::Or, "any", true)
1826 ast::LitKind::Bool(true) => {
1827 check_fold_with_op(cx, expr, fold_args, fold_span, hir::BinOpKind::And, "all", true)
1829 ast::LitKind::Int(0, _) => {
1830 check_fold_with_op(cx, expr, fold_args, fold_span, hir::BinOpKind::Add, "sum", false)
1832 ast::LitKind::Int(1, _) => {
1833 check_fold_with_op(cx, expr, fold_args, fold_span, hir::BinOpKind::Mul, "product", false)
1840 fn lint_iter_nth<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &hir::Expr, iter_args: &'tcx [hir::Expr], is_mut: bool) {
1841 let mut_str = if is_mut { "_mut" } else { "" };
1842 let caller_type = if derefs_to_slice(cx, &iter_args[0], cx.tables.expr_ty(&iter_args[0])).is_some() {
1844 } else if match_type(cx, cx.tables.expr_ty(&iter_args[0]), &paths::VEC) {
1846 } else if match_type(cx, cx.tables.expr_ty(&iter_args[0]), &paths::VEC_DEQUE) {
1849 return; // caller is not a type that we want to lint
1857 "called `.iter{0}().nth()` on a {1}. Calling `.get{0}()` is both faster and more readable",
1858 mut_str, caller_type
1863 fn lint_get_unwrap<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &hir::Expr, get_args: &'tcx [hir::Expr], is_mut: bool) {
1864 // Note: we don't want to lint `get_mut().unwrap` for HashMap or BTreeMap,
1865 // because they do not implement `IndexMut`
1866 let mut applicability = Applicability::MachineApplicable;
1867 let expr_ty = cx.tables.expr_ty(&get_args[0]);
1868 let get_args_str = if get_args.len() > 1 {
1869 snippet_with_applicability(cx, get_args[1].span, "_", &mut applicability)
1871 return; // not linting on a .get().unwrap() chain or variant
1874 let caller_type = if derefs_to_slice(cx, &get_args[0], expr_ty).is_some() {
1875 needs_ref = get_args_str.parse::<usize>().is_ok();
1877 } else if match_type(cx, expr_ty, &paths::VEC) {
1878 needs_ref = get_args_str.parse::<usize>().is_ok();
1880 } else if match_type(cx, expr_ty, &paths::VEC_DEQUE) {
1881 needs_ref = get_args_str.parse::<usize>().is_ok();
1883 } else if !is_mut && match_type(cx, expr_ty, &paths::HASHMAP) {
1886 } else if !is_mut && match_type(cx, expr_ty, &paths::BTREEMAP) {
1890 return; // caller is not a type that we want to lint
1893 let mut span = expr.span;
1895 // Handle the case where the result is immediately dereferenced
1896 // by not requiring ref and pulling the dereference into the
1900 if let Some(parent) = get_parent_expr(cx, expr);
1901 if let hir::ExprKind::Unary(hir::UnOp::UnDeref, _) = parent.node;
1908 let mut_str = if is_mut { "_mut" } else { "" };
1909 let borrow_str = if !needs_ref {
1922 "called `.get{0}().unwrap()` on a {1}. Using `[]` is more clear and more concise",
1923 mut_str, caller_type
1929 snippet_with_applicability(cx, get_args[0].span, "_", &mut applicability),
1936 fn lint_iter_skip_next(cx: &LateContext<'_, '_>, expr: &hir::Expr) {
1937 // lint if caller of skip is an Iterator
1938 if match_trait_method(cx, expr, &paths::ITERATOR) {
1943 "called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`",
1948 fn derefs_to_slice<'a, 'tcx>(
1949 cx: &LateContext<'a, 'tcx>,
1950 expr: &'tcx hir::Expr,
1952 ) -> Option<&'tcx hir::Expr> {
1953 fn may_slice<'a>(cx: &LateContext<'_, 'a>, ty: Ty<'a>) -> bool {
1955 ty::Slice(_) => true,
1956 ty::Adt(def, _) if def.is_box() => may_slice(cx, ty.boxed_ty()),
1957 ty::Adt(..) => match_type(cx, ty, &paths::VEC),
1958 ty::Array(_, size) => size.eval_usize(cx.tcx, cx.param_env) < 32,
1959 ty::Ref(_, inner, _) => may_slice(cx, inner),
1964 if let hir::ExprKind::MethodCall(ref path, _, ref args) = expr.node {
1965 if path.ident.name == sym!(iter) && may_slice(cx, cx.tables.expr_ty(&args[0])) {
1972 ty::Slice(_) => Some(expr),
1973 ty::Adt(def, _) if def.is_box() && may_slice(cx, ty.boxed_ty()) => Some(expr),
1974 ty::Ref(_, inner, _) => {
1975 if may_slice(cx, inner) {
1986 /// lint use of `unwrap()` for `Option`s and `Result`s
1987 fn lint_unwrap(cx: &LateContext<'_, '_>, expr: &hir::Expr, unwrap_args: &[hir::Expr]) {
1988 let obj_ty = walk_ptrs_ty(cx.tables.expr_ty(&unwrap_args[0]));
1990 let mess = if match_type(cx, obj_ty, &paths::OPTION) {
1991 Some((OPTION_UNWRAP_USED, "an Option", "None"))
1992 } else if match_type(cx, obj_ty, &paths::RESULT) {
1993 Some((RESULT_UNWRAP_USED, "a Result", "Err"))
1998 if let Some((lint, kind, none_value)) = mess {
2004 "used unwrap() on {} value. If you don't want to handle the {} case gracefully, consider \
2005 using expect() to provide a better panic \
2013 /// lint use of `ok().expect()` for `Result`s
2014 fn lint_ok_expect(cx: &LateContext<'_, '_>, expr: &hir::Expr, ok_args: &[hir::Expr]) {
2016 // lint if the caller of `ok()` is a `Result`
2017 if match_type(cx, cx.tables.expr_ty(&ok_args[0]), &paths::RESULT);
2018 let result_type = cx.tables.expr_ty(&ok_args[0]);
2019 if let Some(error_type) = get_error_type(cx, result_type);
2020 if has_debug_impl(error_type, cx);
2027 "called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`",
2033 /// lint use of `map().flatten()` for `Iterators`
2034 fn lint_map_flatten<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr, map_args: &'tcx [hir::Expr]) {
2035 // lint if caller of `.map().flatten()` is an Iterator
2036 if match_trait_method(cx, expr, &paths::ITERATOR) {
2037 let msg = "called `map(..).flatten()` on an `Iterator`. \
2038 This is more succinctly expressed by calling `.flat_map(..)`";
2039 let self_snippet = snippet(cx, map_args[0].span, "..");
2040 let func_snippet = snippet(cx, map_args[1].span, "..");
2041 let hint = format!("{0}.flat_map({1})", self_snippet, func_snippet);
2042 span_lint_and_then(cx, MAP_FLATTEN, expr.span, msg, |db| {
2045 "try using flat_map instead",
2047 Applicability::MachineApplicable,
2053 /// lint use of `map().unwrap_or_else()` for `Option`s and `Result`s
2054 fn lint_map_unwrap_or_else<'a, 'tcx>(
2055 cx: &LateContext<'a, 'tcx>,
2056 expr: &'tcx hir::Expr,
2057 map_args: &'tcx [hir::Expr],
2058 unwrap_args: &'tcx [hir::Expr],
2060 // lint if the caller of `map()` is an `Option`
2061 let is_option = match_type(cx, cx.tables.expr_ty(&map_args[0]), &paths::OPTION);
2062 let is_result = match_type(cx, cx.tables.expr_ty(&map_args[0]), &paths::RESULT);
2064 if is_option || is_result {
2065 // Don't make a suggestion that may fail to compile due to mutably borrowing
2066 // the same variable twice.
2067 let map_mutated_vars = mutated_variables(&map_args[0], cx);
2068 let unwrap_mutated_vars = mutated_variables(&unwrap_args[1], cx);
2069 if let (Some(map_mutated_vars), Some(unwrap_mutated_vars)) = (map_mutated_vars, unwrap_mutated_vars) {
2070 if map_mutated_vars.intersection(&unwrap_mutated_vars).next().is_some() {
2078 let msg = if is_option {
2079 "called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling \
2080 `map_or_else(g, f)` instead"
2082 "called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling \
2083 `ok().map_or_else(g, f)` instead"
2085 // get snippets for args to map() and unwrap_or_else()
2086 let map_snippet = snippet(cx, map_args[1].span, "..");
2087 let unwrap_snippet = snippet(cx, unwrap_args[1].span, "..");
2088 // lint, with note if neither arg is > 1 line and both map() and
2089 // unwrap_or_else() have the same span
2090 let multiline = map_snippet.lines().count() > 1 || unwrap_snippet.lines().count() > 1;
2091 let same_span = map_args[1].span.ctxt() == unwrap_args[1].span.ctxt();
2092 if same_span && !multiline {
2096 OPTION_MAP_UNWRAP_OR_ELSE
2098 RESULT_MAP_UNWRAP_OR_ELSE
2104 "replace `map({0}).unwrap_or_else({1})` with `{2}map_or_else({1}, {0})`",
2107 if is_result { "ok()." } else { "" }
2110 } else if same_span && multiline {
2114 OPTION_MAP_UNWRAP_OR_ELSE
2116 RESULT_MAP_UNWRAP_OR_ELSE
2125 /// lint use of `_.map_or(None, _)` for `Option`s
2126 fn lint_map_or_none<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr, map_or_args: &'tcx [hir::Expr]) {
2127 if match_type(cx, cx.tables.expr_ty(&map_or_args[0]), &paths::OPTION) {
2128 // check if the first non-self argument to map_or() is None
2129 let map_or_arg_is_none = if let hir::ExprKind::Path(ref qpath) = map_or_args[1].node {
2130 match_qpath(qpath, &paths::OPTION_NONE)
2135 if map_or_arg_is_none {
2137 let msg = "called `map_or(None, f)` on an Option value. This can be done more directly by calling \
2138 `and_then(f)` instead";
2139 let map_or_self_snippet = snippet(cx, map_or_args[0].span, "..");
2140 let map_or_func_snippet = snippet(cx, map_or_args[2].span, "..");
2141 let hint = format!("{0}.and_then({1})", map_or_self_snippet, map_or_func_snippet);
2142 span_lint_and_then(cx, OPTION_MAP_OR_NONE, expr.span, msg, |db| {
2145 "try using and_then instead",
2147 Applicability::MachineApplicable, // snippet
2154 /// Lint use of `_.and_then(|x| Some(y))` for `Option`s
2155 fn lint_option_and_then_some(cx: &LateContext<'_, '_>, expr: &hir::Expr, args: &[hir::Expr]) {
2156 const LINT_MSG: &str = "using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)`";
2157 const NO_OP_MSG: &str = "using `Option.and_then(Some)`, which is a no-op";
2159 // Searches an return expressions in `y` in `_.and_then(|x| Some(y))`, which we don't lint
2160 struct RetCallFinder {
2164 impl<'tcx> intravisit::Visitor<'tcx> for RetCallFinder {
2165 fn visit_expr(&mut self, expr: &'tcx hir::Expr) {
2169 if let hir::ExprKind::Ret(..) = &expr.node {
2172 intravisit::walk_expr(self, expr);
2176 fn nested_visit_map<'this>(&'this mut self) -> intravisit::NestedVisitorMap<'this, 'tcx> {
2177 intravisit::NestedVisitorMap::None
2181 let ty = cx.tables.expr_ty(&args[0]);
2182 if !match_type(cx, ty, &paths::OPTION) {
2186 match args[1].node {
2187 hir::ExprKind::Closure(_, _, body_id, closure_args_span, _) => {
2188 let closure_body = cx.tcx.hir().body(body_id);
2189 let closure_expr = remove_blocks(&closure_body.value);
2191 if let hir::ExprKind::Call(ref some_expr, ref some_args) = closure_expr.node;
2192 if let hir::ExprKind::Path(ref qpath) = some_expr.node;
2193 if match_qpath(qpath, &paths::OPTION_SOME);
2194 if some_args.len() == 1;
2196 let inner_expr = &some_args[0];
2198 let mut finder = RetCallFinder { found: false };
2199 finder.visit_expr(inner_expr);
2204 let some_inner_snip = if inner_expr.span.from_expansion() {
2205 snippet_with_macro_callsite(cx, inner_expr.span, "_")
2207 snippet(cx, inner_expr.span, "_")
2210 let closure_args_snip = snippet(cx, closure_args_span, "..");
2211 let option_snip = snippet(cx, args[0].span, "..");
2212 let note = format!("{}.map({} {})", option_snip, closure_args_snip, some_inner_snip);
2215 OPTION_AND_THEN_SOME,
2220 Applicability::MachineApplicable,
2225 // `_.and_then(Some)` case, which is no-op.
2226 hir::ExprKind::Path(ref qpath) => {
2227 if match_qpath(qpath, &paths::OPTION_SOME) {
2228 let option_snip = snippet(cx, args[0].span, "..");
2229 let note = format!("{}", option_snip);
2232 OPTION_AND_THEN_SOME,
2235 "use the expression directly",
2237 Applicability::MachineApplicable,
2245 /// lint use of `filter().next()` for `Iterators`
2246 fn lint_filter_next<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr, filter_args: &'tcx [hir::Expr]) {
2247 // lint if caller of `.filter().next()` is an Iterator
2248 if match_trait_method(cx, expr, &paths::ITERATOR) {
2249 let msg = "called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling \
2250 `.find(p)` instead.";
2251 let filter_snippet = snippet(cx, filter_args[1].span, "..");
2252 if filter_snippet.lines().count() <= 1 {
2253 // add note if not multi-line
2260 &format!("replace `filter({0}).next()` with `find({0})`", filter_snippet),
2263 span_lint(cx, FILTER_NEXT, expr.span, msg);
2268 /// lint use of `filter().map()` for `Iterators`
2269 fn lint_filter_map<'a, 'tcx>(
2270 cx: &LateContext<'a, 'tcx>,
2271 expr: &'tcx hir::Expr,
2272 _filter_args: &'tcx [hir::Expr],
2273 _map_args: &'tcx [hir::Expr],
2275 // lint if caller of `.filter().map()` is an Iterator
2276 if match_trait_method(cx, expr, &paths::ITERATOR) {
2277 let msg = "called `filter(p).map(q)` on an `Iterator`. \
2278 This is more succinctly expressed by calling `.filter_map(..)` instead.";
2279 span_lint(cx, FILTER_MAP, expr.span, msg);
2283 /// lint use of `filter_map().next()` for `Iterators`
2284 fn lint_filter_map_next<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr, filter_args: &'tcx [hir::Expr]) {
2285 if match_trait_method(cx, expr, &paths::ITERATOR) {
2286 let msg = "called `filter_map(p).next()` on an `Iterator`. This is more succinctly expressed by calling \
2287 `.find_map(p)` instead.";
2288 let filter_snippet = snippet(cx, filter_args[1].span, "..");
2289 if filter_snippet.lines().count() <= 1 {
2296 &format!("replace `filter_map({0}).next()` with `find_map({0})`", filter_snippet),
2299 span_lint(cx, FILTER_MAP_NEXT, expr.span, msg);
2304 /// lint use of `find().map()` for `Iterators`
2305 fn lint_find_map<'a, 'tcx>(
2306 cx: &LateContext<'a, 'tcx>,
2307 expr: &'tcx hir::Expr,
2308 _find_args: &'tcx [hir::Expr],
2309 map_args: &'tcx [hir::Expr],
2311 // lint if caller of `.filter().map()` is an Iterator
2312 if match_trait_method(cx, &map_args[0], &paths::ITERATOR) {
2313 let msg = "called `find(p).map(q)` on an `Iterator`. \
2314 This is more succinctly expressed by calling `.find_map(..)` instead.";
2315 span_lint(cx, FIND_MAP, expr.span, msg);
2319 /// lint use of `filter().map()` for `Iterators`
2320 fn lint_filter_map_map<'a, 'tcx>(
2321 cx: &LateContext<'a, 'tcx>,
2322 expr: &'tcx hir::Expr,
2323 _filter_args: &'tcx [hir::Expr],
2324 _map_args: &'tcx [hir::Expr],
2326 // lint if caller of `.filter().map()` is an Iterator
2327 if match_trait_method(cx, expr, &paths::ITERATOR) {
2328 let msg = "called `filter_map(p).map(q)` on an `Iterator`. \
2329 This is more succinctly expressed by only calling `.filter_map(..)` instead.";
2330 span_lint(cx, FILTER_MAP, expr.span, msg);
2334 /// lint use of `filter().flat_map()` for `Iterators`
2335 fn lint_filter_flat_map<'a, 'tcx>(
2336 cx: &LateContext<'a, 'tcx>,
2337 expr: &'tcx hir::Expr,
2338 _filter_args: &'tcx [hir::Expr],
2339 _map_args: &'tcx [hir::Expr],
2341 // lint if caller of `.filter().flat_map()` is an Iterator
2342 if match_trait_method(cx, expr, &paths::ITERATOR) {
2343 let msg = "called `filter(p).flat_map(q)` on an `Iterator`. \
2344 This is more succinctly expressed by calling `.flat_map(..)` \
2345 and filtering by returning an empty Iterator.";
2346 span_lint(cx, FILTER_MAP, expr.span, msg);
2350 /// lint use of `filter_map().flat_map()` for `Iterators`
2351 fn lint_filter_map_flat_map<'a, 'tcx>(
2352 cx: &LateContext<'a, 'tcx>,
2353 expr: &'tcx hir::Expr,
2354 _filter_args: &'tcx [hir::Expr],
2355 _map_args: &'tcx [hir::Expr],
2357 // lint if caller of `.filter_map().flat_map()` is an Iterator
2358 if match_trait_method(cx, expr, &paths::ITERATOR) {
2359 let msg = "called `filter_map(p).flat_map(q)` on an `Iterator`. \
2360 This is more succinctly expressed by calling `.flat_map(..)` \
2361 and filtering by returning an empty Iterator.";
2362 span_lint(cx, FILTER_MAP, expr.span, msg);
2366 /// lint use of `flat_map` for `Iterators` where `flatten` would be sufficient
2367 fn lint_flat_map_identity<'a, 'tcx>(
2368 cx: &LateContext<'a, 'tcx>,
2369 expr: &'tcx hir::Expr,
2370 flat_map_args: &'tcx [hir::Expr],
2371 flat_map_span: Span,
2373 if match_trait_method(cx, expr, &paths::ITERATOR) {
2374 let arg_node = &flat_map_args[1].node;
2376 let apply_lint = |message: &str| {
2380 flat_map_span.with_hi(expr.span.hi()),
2383 "flatten()".to_string(),
2384 Applicability::MachineApplicable,
2389 if let hir::ExprKind::Closure(_, _, body_id, _, _) = arg_node;
2390 let body = cx.tcx.hir().body(*body_id);
2392 if let hir::PatKind::Binding(_, _, binding_ident, _) = body.params[0].pat.node;
2393 if let hir::ExprKind::Path(hir::QPath::Resolved(_, ref path)) = body.value.node;
2395 if path.segments.len() == 1;
2396 if path.segments[0].ident.as_str() == binding_ident.as_str();
2399 apply_lint("called `flat_map(|x| x)` on an `Iterator`");
2404 if let hir::ExprKind::Path(ref qpath) = arg_node;
2406 if match_qpath(qpath, &paths::STD_CONVERT_IDENTITY);
2409 apply_lint("called `flat_map(std::convert::identity)` on an `Iterator`");
2415 /// lint searching an Iterator followed by `is_some()`
2416 fn lint_search_is_some<'a, 'tcx>(
2417 cx: &LateContext<'a, 'tcx>,
2418 expr: &'tcx hir::Expr,
2419 search_method: &str,
2420 search_args: &'tcx [hir::Expr],
2421 is_some_args: &'tcx [hir::Expr],
2424 // lint if caller of search is an Iterator
2425 if match_trait_method(cx, &is_some_args[0], &paths::ITERATOR) {
2427 "called `is_some()` after searching an `Iterator` with {}. This is more succinctly \
2428 expressed by calling `any()`.",
2431 let search_snippet = snippet(cx, search_args[1].span, "..");
2432 if search_snippet.lines().count() <= 1 {
2433 // suggest `any(|x| ..)` instead of `any(|&x| ..)` for `find(|&x| ..).is_some()`
2434 // suggest `any(|..| *..)` instead of `any(|..| **..)` for `find(|..| **..).is_some()`
2435 let any_search_snippet = if_chain! {
2436 if search_method == "find";
2437 if let hir::ExprKind::Closure(_, _, body_id, ..) = search_args[1].node;
2438 let closure_body = cx.tcx.hir().body(body_id);
2439 if let Some(closure_arg) = closure_body.params.get(0);
2441 if let hir::PatKind::Ref(..) = closure_arg.pat.node {
2442 Some(search_snippet.replacen('&', "", 1))
2443 } else if let Some(name) = get_arg_name(&closure_arg.pat) {
2444 Some(search_snippet.replace(&format!("*{}", name), &name.as_str()))
2452 // add note if not multi-line
2456 method_span.with_hi(expr.span.hi()),
2461 any_search_snippet.as_ref().map_or(&*search_snippet, String::as_str)
2463 Applicability::MachineApplicable,
2466 span_lint(cx, SEARCH_IS_SOME, expr.span, &msg);
2471 /// Used for `lint_binary_expr_with_method_call`.
2472 #[derive(Copy, Clone)]
2473 struct BinaryExprInfo<'a> {
2474 expr: &'a hir::Expr,
2475 chain: &'a hir::Expr,
2476 other: &'a hir::Expr,
2480 /// Checks for the `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints.
2481 fn lint_binary_expr_with_method_call(cx: &LateContext<'_, '_>, info: &mut BinaryExprInfo<'_>) {
2482 macro_rules! lint_with_both_lhs_and_rhs {
2483 ($func:ident, $cx:expr, $info:ident) => {
2484 if !$func($cx, $info) {
2485 ::std::mem::swap(&mut $info.chain, &mut $info.other);
2486 if $func($cx, $info) {
2493 lint_with_both_lhs_and_rhs!(lint_chars_next_cmp, cx, info);
2494 lint_with_both_lhs_and_rhs!(lint_chars_last_cmp, cx, info);
2495 lint_with_both_lhs_and_rhs!(lint_chars_next_cmp_with_unwrap, cx, info);
2496 lint_with_both_lhs_and_rhs!(lint_chars_last_cmp_with_unwrap, cx, info);
2499 /// Wrapper fn for `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints.
2501 cx: &LateContext<'_, '_>,
2502 info: &BinaryExprInfo<'_>,
2503 chain_methods: &[&str],
2504 lint: &'static Lint,
2508 if let Some(args) = method_chain_args(info.chain, chain_methods);
2509 if let hir::ExprKind::Call(ref fun, ref arg_char) = info.other.node;
2510 if arg_char.len() == 1;
2511 if let hir::ExprKind::Path(ref qpath) = fun.node;
2512 if let Some(segment) = single_segment_path(qpath);
2513 if segment.ident.name == sym!(Some);
2515 let mut applicability = Applicability::MachineApplicable;
2516 let self_ty = walk_ptrs_ty(cx.tables.expr_ty_adjusted(&args[0][0]));
2518 if self_ty.sty != ty::Str {
2526 &format!("you should use the `{}` method", suggest),
2528 format!("{}{}.{}({})",
2529 if info.eq { "" } else { "!" },
2530 snippet_with_applicability(cx, args[0][0].span, "_", &mut applicability),
2532 snippet_with_applicability(cx, arg_char[0].span, "_", &mut applicability)),
2543 /// Checks for the `CHARS_NEXT_CMP` lint.
2544 fn lint_chars_next_cmp<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, info: &BinaryExprInfo<'_>) -> bool {
2545 lint_chars_cmp(cx, info, &["chars", "next"], CHARS_NEXT_CMP, "starts_with")
2548 /// Checks for the `CHARS_LAST_CMP` lint.
2549 fn lint_chars_last_cmp<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, info: &BinaryExprInfo<'_>) -> bool {
2550 if lint_chars_cmp(cx, info, &["chars", "last"], CHARS_LAST_CMP, "ends_with") {
2553 lint_chars_cmp(cx, info, &["chars", "next_back"], CHARS_LAST_CMP, "ends_with")
2557 /// Wrapper fn for `CHARS_NEXT_CMP` and `CHARS_LAST_CMP` lints with `unwrap()`.
2558 fn lint_chars_cmp_with_unwrap<'a, 'tcx>(
2559 cx: &LateContext<'a, 'tcx>,
2560 info: &BinaryExprInfo<'_>,
2561 chain_methods: &[&str],
2562 lint: &'static Lint,
2566 if let Some(args) = method_chain_args(info.chain, chain_methods);
2567 if let hir::ExprKind::Lit(ref lit) = info.other.node;
2568 if let ast::LitKind::Char(c) = lit.node;
2570 let mut applicability = Applicability::MachineApplicable;
2575 &format!("you should use the `{}` method", suggest),
2577 format!("{}{}.{}('{}')",
2578 if info.eq { "" } else { "!" },
2579 snippet_with_applicability(cx, args[0][0].span, "_", &mut applicability),
2592 /// Checks for the `CHARS_NEXT_CMP` lint with `unwrap()`.
2593 fn lint_chars_next_cmp_with_unwrap<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, info: &BinaryExprInfo<'_>) -> bool {
2594 lint_chars_cmp_with_unwrap(cx, info, &["chars", "next", "unwrap"], CHARS_NEXT_CMP, "starts_with")
2597 /// Checks for the `CHARS_LAST_CMP` lint with `unwrap()`.
2598 fn lint_chars_last_cmp_with_unwrap<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, info: &BinaryExprInfo<'_>) -> bool {
2599 if lint_chars_cmp_with_unwrap(cx, info, &["chars", "last", "unwrap"], CHARS_LAST_CMP, "ends_with") {
2602 lint_chars_cmp_with_unwrap(cx, info, &["chars", "next_back", "unwrap"], CHARS_LAST_CMP, "ends_with")
2606 /// lint for length-1 `str`s for methods in `PATTERN_METHODS`
2607 fn lint_single_char_pattern<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, _expr: &'tcx hir::Expr, arg: &'tcx hir::Expr) {
2609 if let hir::ExprKind::Lit(lit) = &arg.node;
2610 if let ast::LitKind::Str(r, style) = lit.node;
2611 if r.as_str().len() == 1;
2613 let mut applicability = Applicability::MachineApplicable;
2614 let snip = snippet_with_applicability(cx, arg.span, "..", &mut applicability);
2615 let ch = if let ast::StrStyle::Raw(nhash) = style {
2616 let nhash = nhash as usize;
2617 // for raw string: r##"a"##
2618 &snip[(nhash + 2)..(snip.len() - 1 - nhash)]
2620 // for regular string: "a"
2621 &snip[1..(snip.len() - 1)]
2623 let hint = format!("'{}'", if ch == "'" { "\\'" } else { ch });
2626 SINGLE_CHAR_PATTERN,
2628 "single-character string constant used as pattern",
2629 "try using a char instead",
2637 /// Checks for the `USELESS_ASREF` lint.
2638 fn lint_asref(cx: &LateContext<'_, '_>, expr: &hir::Expr, call_name: &str, as_ref_args: &[hir::Expr]) {
2639 // when we get here, we've already checked that the call name is "as_ref" or "as_mut"
2640 // check if the call is to the actual `AsRef` or `AsMut` trait
2641 if match_trait_method(cx, expr, &paths::ASREF_TRAIT) || match_trait_method(cx, expr, &paths::ASMUT_TRAIT) {
2642 // check if the type after `as_ref` or `as_mut` is the same as before
2643 let recvr = &as_ref_args[0];
2644 let rcv_ty = cx.tables.expr_ty(recvr);
2645 let res_ty = cx.tables.expr_ty(expr);
2646 let (base_res_ty, res_depth) = walk_ptrs_ty_depth(res_ty);
2647 let (base_rcv_ty, rcv_depth) = walk_ptrs_ty_depth(rcv_ty);
2648 if base_rcv_ty == base_res_ty && rcv_depth >= res_depth {
2649 // allow the `as_ref` or `as_mut` if it is followed by another method call
2651 if let Some(parent) = get_parent_expr(cx, expr);
2652 if let hir::ExprKind::MethodCall(_, ref span, _) = parent.node;
2653 if span != &expr.span;
2659 let mut applicability = Applicability::MachineApplicable;
2664 &format!("this call to `{}` does nothing", call_name),
2666 snippet_with_applicability(cx, recvr.span, "_", &mut applicability).to_string(),
2673 fn ty_has_iter_method(
2674 cx: &LateContext<'_, '_>,
2675 self_ref_ty: Ty<'_>,
2676 ) -> Option<(&'static Lint, &'static str, &'static str)> {
2677 has_iter_method(cx, self_ref_ty).map(|ty_name| {
2678 let lint = if ty_name == "array" || ty_name == "PathBuf" {
2683 let mutbl = match self_ref_ty.sty {
2684 ty::Ref(_, _, mutbl) => mutbl,
2685 _ => unreachable!(),
2687 let method_name = match mutbl {
2688 hir::MutImmutable => "iter",
2689 hir::MutMutable => "iter_mut",
2691 (lint, ty_name, method_name)
2695 fn lint_into_iter(cx: &LateContext<'_, '_>, expr: &hir::Expr, self_ref_ty: Ty<'_>, method_span: Span) {
2696 if !match_trait_method(cx, expr, &paths::INTO_ITERATOR) {
2699 if let Some((lint, kind, method_name)) = ty_has_iter_method(cx, self_ref_ty) {
2705 "this .into_iter() call is equivalent to .{}() and will not move the {}",
2709 method_name.to_string(),
2710 Applicability::MachineApplicable,
2715 /// lint for `MaybeUninit::uninit().assume_init()` (we already have the latter)
2716 fn lint_maybe_uninit(cx: &LateContext<'_, '_>, expr: &hir::Expr, outer: &hir::Expr) {
2718 if let hir::ExprKind::Call(ref callee, ref args) = expr.node;
2720 if let hir::ExprKind::Path(ref path) = callee.node;
2721 if match_qpath(path, &paths::MEM_MAYBEUNINIT_UNINIT);
2722 if !is_maybe_uninit_ty_valid(cx, cx.tables.expr_ty_adjusted(outer));
2726 UNINIT_ASSUMED_INIT,
2728 "this call for this type may be undefined behavior"
2734 fn is_maybe_uninit_ty_valid(cx: &LateContext<'_, '_>, ty: Ty<'_>) -> bool {
2736 ty::Array(ref component, _) => is_maybe_uninit_ty_valid(cx, component),
2737 ty::Tuple(ref types) => types.types().all(|ty| is_maybe_uninit_ty_valid(cx, ty)),
2738 ty::Adt(ref adt, _) => {
2739 // needs to be a MaybeUninit
2740 match_def_path(cx, adt.did, &paths::MEM_MAYBEUNINIT)
2746 fn lint_suspicious_map(cx: &LateContext<'_, '_>, expr: &hir::Expr) {
2751 "this call to `map()` won't have an effect on the call to `count()`",
2752 "make sure you did not confuse `map` with `filter`",
2756 /// Given a `Result<T, E>` type, return its error type (`E`).
2757 fn get_error_type<'a>(cx: &LateContext<'_, '_>, ty: Ty<'a>) -> Option<Ty<'a>> {
2759 ty::Adt(_, substs) if match_type(cx, ty, &paths::RESULT) => substs.types().nth(1),
2764 /// This checks whether a given type is known to implement Debug.
2765 fn has_debug_impl<'a, 'b>(ty: Ty<'a>, cx: &LateContext<'b, 'a>) -> bool {
2766 match cx.tcx.get_diagnostic_item(sym::debug_trait) {
2767 Some(debug) => implements_trait(cx, ty, debug, &[]),
2774 StartsWith(&'static str),
2778 const CONVENTIONS: [(Convention, &[SelfKind]); 7] = [
2779 (Convention::Eq("new"), &[SelfKind::No]),
2780 (Convention::StartsWith("as_"), &[SelfKind::Ref, SelfKind::RefMut]),
2781 (Convention::StartsWith("from_"), &[SelfKind::No]),
2782 (Convention::StartsWith("into_"), &[SelfKind::Value]),
2783 (Convention::StartsWith("is_"), &[SelfKind::Ref, SelfKind::No]),
2784 (Convention::Eq("to_mut"), &[SelfKind::RefMut]),
2785 (Convention::StartsWith("to_"), &[SelfKind::Ref]),
2789 const TRAIT_METHODS: [(&str, usize, SelfKind, OutType, &str); 30] = [
2790 ("add", 2, SelfKind::Value, OutType::Any, "std::ops::Add"),
2791 ("as_mut", 1, SelfKind::RefMut, OutType::Ref, "std::convert::AsMut"),
2792 ("as_ref", 1, SelfKind::Ref, OutType::Ref, "std::convert::AsRef"),
2793 ("bitand", 2, SelfKind::Value, OutType::Any, "std::ops::BitAnd"),
2794 ("bitor", 2, SelfKind::Value, OutType::Any, "std::ops::BitOr"),
2795 ("bitxor", 2, SelfKind::Value, OutType::Any, "std::ops::BitXor"),
2796 ("borrow", 1, SelfKind::Ref, OutType::Ref, "std::borrow::Borrow"),
2797 ("borrow_mut", 1, SelfKind::RefMut, OutType::Ref, "std::borrow::BorrowMut"),
2798 ("clone", 1, SelfKind::Ref, OutType::Any, "std::clone::Clone"),
2799 ("cmp", 2, SelfKind::Ref, OutType::Any, "std::cmp::Ord"),
2800 ("default", 0, SelfKind::No, OutType::Any, "std::default::Default"),
2801 ("deref", 1, SelfKind::Ref, OutType::Ref, "std::ops::Deref"),
2802 ("deref_mut", 1, SelfKind::RefMut, OutType::Ref, "std::ops::DerefMut"),
2803 ("div", 2, SelfKind::Value, OutType::Any, "std::ops::Div"),
2804 ("drop", 1, SelfKind::RefMut, OutType::Unit, "std::ops::Drop"),
2805 ("eq", 2, SelfKind::Ref, OutType::Bool, "std::cmp::PartialEq"),
2806 ("from_iter", 1, SelfKind::No, OutType::Any, "std::iter::FromIterator"),
2807 ("from_str", 1, SelfKind::No, OutType::Any, "std::str::FromStr"),
2808 ("hash", 2, SelfKind::Ref, OutType::Unit, "std::hash::Hash"),
2809 ("index", 2, SelfKind::Ref, OutType::Ref, "std::ops::Index"),
2810 ("index_mut", 2, SelfKind::RefMut, OutType::Ref, "std::ops::IndexMut"),
2811 ("into_iter", 1, SelfKind::Value, OutType::Any, "std::iter::IntoIterator"),
2812 ("mul", 2, SelfKind::Value, OutType::Any, "std::ops::Mul"),
2813 ("neg", 1, SelfKind::Value, OutType::Any, "std::ops::Neg"),
2814 ("next", 1, SelfKind::RefMut, OutType::Any, "std::iter::Iterator"),
2815 ("not", 1, SelfKind::Value, OutType::Any, "std::ops::Not"),
2816 ("rem", 2, SelfKind::Value, OutType::Any, "std::ops::Rem"),
2817 ("shl", 2, SelfKind::Value, OutType::Any, "std::ops::Shl"),
2818 ("shr", 2, SelfKind::Value, OutType::Any, "std::ops::Shr"),
2819 ("sub", 2, SelfKind::Value, OutType::Any, "std::ops::Sub"),
2823 const PATTERN_METHODS: [(&str, usize); 17] = [
2831 ("split_terminator", 1),
2832 ("rsplit_terminator", 1),
2837 ("match_indices", 1),
2838 ("rmatch_indices", 1),
2839 ("trim_start_matches", 1),
2840 ("trim_end_matches", 1),
2843 #[derive(Clone, Copy, PartialEq, Debug)]
2852 fn matches<'a>(self, cx: &LateContext<'_, 'a>, parent_ty: Ty<'a>, ty: Ty<'a>) -> bool {
2853 fn matches_value(parent_ty: Ty<'_>, ty: Ty<'_>) -> bool {
2854 if ty == parent_ty {
2856 } else if ty.is_box() {
2857 ty.boxed_ty() == parent_ty
2858 } else if ty.is_rc() || ty.is_arc() {
2859 if let ty::Adt(_, substs) = ty.sty {
2860 substs.types().next().map_or(false, |t| t == parent_ty)
2870 cx: &LateContext<'_, 'a>,
2871 mutability: hir::Mutability,
2875 if let ty::Ref(_, t, m) = ty.sty {
2876 return m == mutability && t == parent_ty;
2879 let trait_path = match mutability {
2880 hir::Mutability::MutImmutable => &paths::ASREF_TRAIT,
2881 hir::Mutability::MutMutable => &paths::ASMUT_TRAIT,
2884 let trait_def_id = match get_trait_def_id(cx, trait_path) {
2886 None => return false,
2888 implements_trait(cx, ty, trait_def_id, &[parent_ty.into()])
2892 Self::Value => matches_value(parent_ty, ty),
2894 matches_ref(cx, hir::Mutability::MutImmutable, parent_ty, ty) || ty == parent_ty && is_copy(cx, ty)
2896 Self::RefMut => matches_ref(cx, hir::Mutability::MutMutable, parent_ty, ty),
2897 Self::No => ty != parent_ty,
2901 fn description(self) -> &'static str {
2903 Self::Value => "self by value",
2904 Self::Ref => "self by reference",
2905 Self::RefMut => "self by mutable reference",
2906 Self::No => "no self",
2912 fn check(&self, other: &str) -> bool {
2914 Self::Eq(this) => this == other,
2915 Self::StartsWith(this) => other.starts_with(this) && this != other,
2920 impl fmt::Display for Convention {
2921 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> Result<(), fmt::Error> {
2923 Self::Eq(this) => this.fmt(f),
2924 Self::StartsWith(this) => this.fmt(f).and_then(|_| '*'.fmt(f)),
2929 #[derive(Clone, Copy)]
2938 fn matches(self, cx: &LateContext<'_, '_>, ty: &hir::FunctionRetTy) -> bool {
2939 let is_unit = |ty: &hir::Ty| SpanlessEq::new(cx).eq_ty_kind(&ty.node, &hir::TyKind::Tup(vec![].into()));
2941 (Self::Unit, &hir::DefaultReturn(_)) => true,
2942 (Self::Unit, &hir::Return(ref ty)) if is_unit(ty) => true,
2943 (Self::Bool, &hir::Return(ref ty)) if is_bool(ty) => true,
2944 (Self::Any, &hir::Return(ref ty)) if !is_unit(ty) => true,
2945 (Self::Ref, &hir::Return(ref ty)) => matches!(ty.node, hir::TyKind::Rptr(_, _)),
2951 fn is_bool(ty: &hir::Ty) -> bool {
2952 if let hir::TyKind::Path(ref p) = ty.node {
2953 match_qpath(p, &["bool"])