clippy_lints/src/methods/filter_next.rs

   1 use clippy_utils::diagnostics::{span_lint, span_lint_and_sugg};
   2 use clippy_utils::is_trait_method;
   3 use clippy_utils::source::snippet;
   4 use rustc_errors::Applicability;
   5 use rustc_hir as hir;
   6 use rustc_lint::LateContext;
   7 use rustc_span::sym;
   8
   9 use super::FILTER_NEXT;
  10
  11 /// lint use of `filter().next()` for `Iterators`
  12 pub(super) fn check<'tcx>(
  13     cx: &LateContext<'tcx>,
  14     expr: &'tcx hir::Expr<'_>,
  15     recv: &'tcx hir::Expr<'_>,
  16     filter_arg: &'tcx hir::Expr<'_>,
  17 ) {
  18     // lint if caller of `.filter().next()` is an Iterator
  19     if is_trait_method(cx, expr, sym::Iterator) {
  20         let msg = "called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling \
  21                    `.find(..)` instead";
  22         let filter_snippet = snippet(cx, filter_arg.span, "..");
  23         if filter_snippet.lines().count() <= 1 {
  24             let iter_snippet = snippet(cx, recv.span, "..");
  25             // add note if not multi-line
  26             span_lint_and_sugg(
  27                 cx,
  28                 FILTER_NEXT,
  29                 expr.span,
  30                 msg,
  31                 "try this",
  32                 format!("{}.find({})", iter_snippet, filter_snippet),
  33                 Applicability::MachineApplicable,
  34             );
  35         } else {
  36             span_lint(cx, FILTER_NEXT, expr.span, msg);
  37         }
  38     }
  39 }