1 use crate::utils::paths;
2 use crate::utils::{iter_input_pats, match_type, method_chain_args, snippet, span_lint_and_then};
3 use if_chain::if_chain;
4 use rustc::declare_lint_pass;
6 use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7 use rustc::ty::{self, Ty};
8 use rustc_errors::Applicability;
9 use rustc_session::declare_tool_lint;
10 use syntax::source_map::Span;
12 declare_clippy_lint! {
13 /// **What it does:** Checks for usage of `option.map(f)` where f is a function
14 /// or closure that returns the unit type.
16 /// **Why is this bad?** Readability, this can be written more clearly with
17 /// an if let statement
19 /// **Known problems:** None.
24 /// # fn do_stuff() -> Option<String> { Some(String::new()) }
25 /// # fn log_err_msg(foo: String) -> Option<String> { Some(foo) }
26 /// # fn format_msg(foo: String) -> String { String::new() }
27 /// let x: Option<String> = do_stuff();
28 /// x.map(log_err_msg);
29 /// # let x: Option<String> = do_stuff();
30 /// x.map(|msg| log_err_msg(format_msg(msg)));
33 /// The correct use would be:
36 /// # fn do_stuff() -> Option<String> { Some(String::new()) }
37 /// # fn log_err_msg(foo: String) -> Option<String> { Some(foo) }
38 /// # fn format_msg(foo: String) -> String { String::new() }
39 /// let x: Option<String> = do_stuff();
40 /// if let Some(msg) = x {
44 /// # let x: Option<String> = do_stuff();
45 /// if let Some(msg) = x {
46 /// log_err_msg(format_msg(msg));
49 pub OPTION_MAP_UNIT_FN,
51 "using `option.map(f)`, where f is a function or closure that returns ()"
54 declare_clippy_lint! {
55 /// **What it does:** Checks for usage of `result.map(f)` where f is a function
56 /// or closure that returns the unit type.
58 /// **Why is this bad?** Readability, this can be written more clearly with
59 /// an if let statement
61 /// **Known problems:** None.
66 /// # fn do_stuff() -> Result<String, String> { Ok(String::new()) }
67 /// # fn log_err_msg(foo: String) -> Result<String, String> { Ok(foo) }
68 /// # fn format_msg(foo: String) -> String { String::new() }
69 /// let x: Result<String, String> = do_stuff();
70 /// x.map(log_err_msg);
71 /// # let x: Result<String, String> = do_stuff();
72 /// x.map(|msg| log_err_msg(format_msg(msg)));
75 /// The correct use would be:
78 /// # fn do_stuff() -> Result<String, String> { Ok(String::new()) }
79 /// # fn log_err_msg(foo: String) -> Result<String, String> { Ok(foo) }
80 /// # fn format_msg(foo: String) -> String { String::new() }
81 /// let x: Result<String, String> = do_stuff();
82 /// if let Ok(msg) = x {
85 /// # let x: Result<String, String> = do_stuff();
86 /// if let Ok(msg) = x {
87 /// log_err_msg(format_msg(msg));
90 pub RESULT_MAP_UNIT_FN,
92 "using `result.map(f)`, where f is a function or closure that returns ()"
95 declare_lint_pass!(MapUnit => [OPTION_MAP_UNIT_FN, RESULT_MAP_UNIT_FN]);
97 fn is_unit_type(ty: Ty<'_>) -> bool {
99 ty::Tuple(slice) => slice.is_empty(),
105 fn is_unit_function(cx: &LateContext<'_, '_>, expr: &hir::Expr) -> bool {
106 let ty = cx.tables.expr_ty(expr);
108 if let ty::FnDef(id, _) = ty.kind {
109 if let Some(fn_type) = cx.tcx.fn_sig(id).no_bound_vars() {
110 return is_unit_type(fn_type.output());
116 fn is_unit_expression(cx: &LateContext<'_, '_>, expr: &hir::Expr) -> bool {
117 is_unit_type(cx.tables.expr_ty(expr))
120 /// The expression inside a closure may or may not have surrounding braces and
121 /// semicolons, which causes problems when generating a suggestion. Given an
122 /// expression that evaluates to '()' or '!', recursively remove useless braces
123 /// and semi-colons until is suitable for including in the suggestion template
124 fn reduce_unit_expression<'a>(cx: &LateContext<'_, '_>, expr: &'a hir::Expr) -> Option<Span> {
125 if !is_unit_expression(cx, expr) {
130 hir::ExprKind::Call(_, _) | hir::ExprKind::MethodCall(_, _, _) => {
131 // Calls can't be reduced any more
134 hir::ExprKind::Block(ref block, _) => {
135 match (&block.stmts[..], block.expr.as_ref()) {
136 (&[], Some(inner_expr)) => {
137 // If block only contains an expression,
138 // reduce `{ X }` to `X`
139 reduce_unit_expression(cx, inner_expr)
141 (&[ref inner_stmt], None) => {
142 // If block only contains statements,
143 // reduce `{ X; }` to `X` or `X;`
144 match inner_stmt.kind {
145 hir::StmtKind::Local(ref local) => Some(local.span),
146 hir::StmtKind::Expr(ref e) => Some(e.span),
147 hir::StmtKind::Semi(..) => Some(inner_stmt.span),
148 hir::StmtKind::Item(..) => None,
152 // For closures that contain multiple statements
153 // it's difficult to get a correct suggestion span
154 // for all cases (multi-line closures specifically)
156 // We do not attempt to build a suggestion for those right now.
165 fn unit_closure<'a, 'tcx>(
166 cx: &LateContext<'a, 'tcx>,
168 ) -> Option<(&'tcx hir::Param, &'a hir::Expr)> {
169 if let hir::ExprKind::Closure(_, ref decl, inner_expr_id, _, _) = expr.kind {
170 let body = cx.tcx.hir().body(inner_expr_id);
171 let body_expr = &body.value;
174 if decl.inputs.len() == 1;
175 if is_unit_expression(cx, body_expr);
176 if let Some(binding) = iter_input_pats(&decl, body).next();
178 return Some((binding, body_expr));
185 /// Builds a name for the let binding variable (`var_arg`)
187 /// `x.field` => `x_field`
190 /// Anything else will return `_`.
191 fn let_binding_name(cx: &LateContext<'_, '_>, var_arg: &hir::Expr) -> String {
192 match &var_arg.kind {
193 hir::ExprKind::Field(_, _) => snippet(cx, var_arg.span, "_").replace(".", "_"),
194 hir::ExprKind::Path(_) => format!("_{}", snippet(cx, var_arg.span, "")),
195 _ => "_".to_string(),
200 fn suggestion_msg(function_type: &str, map_type: &str) -> String {
202 "called `map(f)` on an {0} value where `f` is a unit {1}",
203 map_type, function_type
207 fn lint_map_unit_fn(cx: &LateContext<'_, '_>, stmt: &hir::Stmt, expr: &hir::Expr, map_args: &[hir::Expr]) {
208 let var_arg = &map_args[0];
210 let (map_type, variant, lint) = if match_type(cx, cx.tables.expr_ty(var_arg), &paths::OPTION) {
211 ("Option", "Some", OPTION_MAP_UNIT_FN)
212 } else if match_type(cx, cx.tables.expr_ty(var_arg), &paths::RESULT) {
213 ("Result", "Ok", RESULT_MAP_UNIT_FN)
217 let fn_arg = &map_args[1];
219 if is_unit_function(cx, fn_arg) {
220 let msg = suggestion_msg("function", map_type);
221 let suggestion = format!(
222 "if let {0}({binding}) = {1} {{ {2}({binding}) }}",
224 snippet(cx, var_arg.span, "_"),
225 snippet(cx, fn_arg.span, "_"),
226 binding = let_binding_name(cx, var_arg)
229 span_lint_and_then(cx, lint, expr.span, &msg, |db| {
230 db.span_suggestion(stmt.span, "try this", suggestion, Applicability::MachineApplicable);
232 } else if let Some((binding, closure_expr)) = unit_closure(cx, fn_arg) {
233 let msg = suggestion_msg("closure", map_type);
235 span_lint_and_then(cx, lint, expr.span, &msg, |db| {
236 if let Some(reduced_expr_span) = reduce_unit_expression(cx, closure_expr) {
237 let suggestion = format!(
238 "if let {0}({1}) = {2} {{ {3} }}",
240 snippet(cx, binding.pat.span, "_"),
241 snippet(cx, var_arg.span, "_"),
242 snippet(cx, reduced_expr_span, "_")
248 Applicability::MachineApplicable, // snippet
251 let suggestion = format!(
252 "if let {0}({1}) = {2} {{ ... }}",
254 snippet(cx, binding.pat.span, "_"),
255 snippet(cx, var_arg.span, "_"),
257 db.span_suggestion(stmt.span, "try this", suggestion, Applicability::HasPlaceholders);
263 impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MapUnit {
264 fn check_stmt(&mut self, cx: &LateContext<'_, '_>, stmt: &hir::Stmt) {
265 if stmt.span.from_expansion() {
269 if let hir::StmtKind::Semi(ref expr) = stmt.kind {
270 if let Some(arglists) = method_chain_args(expr, &["map"]) {
271 lint_map_unit_fn(cx, stmt, expr, arglists[0]);