clippy_lints/src/manual_unwrap_or.rs

   1 use crate::consts::constant_simple;
   2 use crate::utils;
   3 use crate::utils::sugg;
   4 use if_chain::if_chain;
   5 use rustc_errors::Applicability;
   6 use rustc_hir::{def, Arm, Expr, ExprKind, Pat, PatKind, QPath};
   7 use rustc_lint::LintContext;
   8 use rustc_lint::{LateContext, LateLintPass};
   9 use rustc_middle::lint::in_external_macro;
  10 use rustc_session::{declare_lint_pass, declare_tool_lint};
  11
  12 declare_clippy_lint! {
  13     /// **What it does:**
  14     /// Finds patterns that reimplement `Option::unwrap_or` or `Result::unwrap_or`.
  15     ///
  16     /// **Why is this bad?**
  17     /// Concise code helps focusing on behavior instead of boilerplate.
  18     ///
  19     /// **Known problems:** None.
  20     ///
  21     /// **Example:**
  22     /// ```rust
  23     /// let foo: Option<i32> = None;
  24     /// match foo {
  25     ///     Some(v) => v,
  26     ///     None => 1,
  27     /// };
  28     /// ```
  29     ///
  30     /// Use instead:
  31     /// ```rust
  32     /// let foo: Option<i32> = None;
  33     /// foo.unwrap_or(1);
  34     /// ```
  35     pub MANUAL_UNWRAP_OR,
  36     complexity,
  37     "finds patterns that can be encoded more concisely with `Option::unwrap_or` or `Result::unwrap_or`"
  38 }
  39
  40 declare_lint_pass!(ManualUnwrapOr => [MANUAL_UNWRAP_OR]);
  41
  42 impl LateLintPass<'_> for ManualUnwrapOr {
  43     fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
  44         if in_external_macro(cx.sess(), expr.span) {
  45             return;
  46         }
  47         lint_manual_unwrap_or(cx, expr);
  48     }
  49 }
  50
  51 #[derive(Copy, Clone)]
  52 enum Case {
  53     Option,
  54     Result,
  55 }
  56
  57 impl Case {
  58     fn unwrap_fn_path(&self) -> &str {
  59         match self {
  60             Case::Option => "Option::unwrap_or",
  61             Case::Result => "Result::unwrap_or",
  62         }
  63     }
  64 }
  65
  66 fn lint_manual_unwrap_or<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) {
  67     fn applicable_or_arm<'a>(arms: &'a [Arm<'a>]) -> Option<&'a Arm<'a>> {
  68         if_chain! {
  69             if arms.len() == 2;
  70             if arms.iter().all(|arm| arm.guard.is_none());
  71             if let Some((idx, or_arm)) = arms.iter().enumerate().find(|(_, arm)|
  72                 match arm.pat.kind {
  73                     PatKind::Path(ref some_qpath) =>
  74                         utils::match_qpath(some_qpath, &utils::paths::OPTION_NONE),
  75                     PatKind::TupleStruct(ref err_qpath, &[Pat { kind: PatKind::Wild, .. }], _) =>
  76                         utils::match_qpath(err_qpath, &utils::paths::RESULT_ERR),
  77                     _ => false,
  78                 }
  79             );
  80             let unwrap_arm = &arms[1 - idx];
  81             if let PatKind::TupleStruct(ref unwrap_qpath, &[unwrap_pat], _) = unwrap_arm.pat.kind;
  82             if utils::match_qpath(unwrap_qpath, &utils::paths::OPTION_SOME)
  83                 || utils::match_qpath(unwrap_qpath, &utils::paths::RESULT_OK);
  84             if let PatKind::Binding(_, binding_hir_id, ..) = unwrap_pat.kind;
  85             if let ExprKind::Path(QPath::Resolved(_, body_path)) = unwrap_arm.body.kind;
  86             if let def::Res::Local(body_path_hir_id) = body_path.res;
  87             if body_path_hir_id == binding_hir_id;
  88             if !utils::usage::contains_return_break_continue_macro(or_arm.body);
  89             then {
  90                 Some(or_arm)
  91             } else {
  92                 None
  93             }
  94         }
  95     }
  96
  97     if_chain! {
  98         if let ExprKind::Match(scrutinee, match_arms, _) = expr.kind;
  99         let ty = cx.typeck_results().expr_ty(scrutinee);
 100         if let Some(case) = if utils::is_type_diagnostic_item(cx, ty, sym!(option_type)) {
 101             Some(Case::Option)
 102         } else if utils::is_type_diagnostic_item(cx, ty, sym!(result_type)) {
 103             Some(Case::Result)
 104         } else {
 105             None
 106         };
 107         if let Some(or_arm) = applicable_or_arm(match_arms);
 108         if let Some(or_body_snippet) = utils::snippet_opt(cx, or_arm.body.span);
 109         if let Some(indent) = utils::indent_of(cx, expr.span);
 110         if constant_simple(cx, cx.typeck_results(), or_arm.body).is_some();
 111         then {
 112             let reindented_or_body =
 113                 utils::reindent_multiline(or_body_snippet.into(), true, Some(indent));
 114             utils::span_lint_and_sugg(
 115                 cx,
 116                 MANUAL_UNWRAP_OR, expr.span,
 117                 &format!("this pattern reimplements `{}`", case.unwrap_fn_path()),
 118                 "replace with",
 119                 format!(
 120                     "{}.unwrap_or({})",
 121                     sugg::Sugg::hir(cx, scrutinee, "..").maybe_par(),
 122                     reindented_or_body,
 123                 ),
 124                 Applicability::MachineApplicable,
 125             );
 126         }
 127     }
 128 }