]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
add `implicit_saturating_add` lint
[rust.git] / clippy_lints / src / lib.rs
1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
8 #![feature(lint_reasons)]
9 #![feature(never_type)]
10 #![feature(once_cell)]
11 #![feature(rustc_private)]
12 #![feature(stmt_expr_attributes)]
13 #![recursion_limit = "512"]
14 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
15 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
16 #![warn(trivial_casts, trivial_numeric_casts)]
17 // warn on lints, that are included in `rust-lang/rust`s bootstrap
18 #![warn(rust_2018_idioms, unused_lifetimes)]
19 // warn on rustc internal lints
20 #![warn(rustc::internal)]
21 // Disable this rustc lint for now, as it was also done in rustc
22 #![allow(rustc::potential_query_instability)]
23
24 // FIXME: switch to something more ergonomic here, once available.
25 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
26 extern crate rustc_arena;
27 extern crate rustc_ast;
28 extern crate rustc_ast_pretty;
29 extern crate rustc_attr;
30 extern crate rustc_data_structures;
31 extern crate rustc_driver;
32 extern crate rustc_errors;
33 extern crate rustc_hir;
34 extern crate rustc_hir_analysis;
35 extern crate rustc_hir_pretty;
36 extern crate rustc_index;
37 extern crate rustc_infer;
38 extern crate rustc_lexer;
39 extern crate rustc_lint;
40 extern crate rustc_middle;
41 extern crate rustc_mir_dataflow;
42 extern crate rustc_parse;
43 extern crate rustc_session;
44 extern crate rustc_span;
45 extern crate rustc_target;
46 extern crate rustc_trait_selection;
47
48 #[macro_use]
49 extern crate clippy_utils;
50
51 use clippy_utils::parse_msrv;
52 use rustc_data_structures::fx::FxHashSet;
53 use rustc_lint::LintId;
54 use rustc_semver::RustcVersion;
55 use rustc_session::Session;
56
57 /// Macro used to declare a Clippy lint.
58 ///
59 /// Every lint declaration consists of 4 parts:
60 ///
61 /// 1. The documentation, which is used for the website
62 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
63 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
64 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
65 /// 4. The `description` that contains a short explanation on what's wrong with code where the
66 ///    lint is triggered.
67 ///
68 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
69 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
70 /// changes, please update README.md.
71 ///
72 /// # Example
73 ///
74 /// ```
75 /// #![feature(rustc_private)]
76 /// extern crate rustc_session;
77 /// use rustc_session::declare_tool_lint;
78 /// use clippy_lints::declare_clippy_lint;
79 ///
80 /// declare_clippy_lint! {
81 ///     /// ### What it does
82 ///     /// Checks for ... (describe what the lint matches).
83 ///     ///
84 ///     /// ### Why is this bad?
85 ///     /// Supply the reason for linting the code.
86 ///     ///
87 ///     /// ### Example
88 ///     /// ```rust
89 ///     /// Insert a short example of code that triggers the lint
90 ///     /// ```
91 ///     ///
92 ///     /// Use instead:
93 ///     /// ```rust
94 ///     /// Insert a short example of improved code that doesn't trigger the lint
95 ///     /// ```
96 ///     pub LINT_NAME,
97 ///     pedantic,
98 ///     "description"
99 /// }
100 /// ```
101 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
102 #[macro_export]
103 macro_rules! declare_clippy_lint {
104     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
105         declare_tool_lint! {
106             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
107         }
108     };
109     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
110         declare_tool_lint! {
111             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
112         }
113     };
114     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
115         declare_tool_lint! {
116             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
117         }
118     };
119     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
120         declare_tool_lint! {
121             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
122         }
123     };
124     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
125         declare_tool_lint! {
126             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
127         }
128     };
129     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
130         declare_tool_lint! {
131             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
132         }
133     };
134     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
135         declare_tool_lint! {
136             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
137         }
138     };
139     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
140         declare_tool_lint! {
141             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
142         }
143     };
144     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
145         declare_tool_lint! {
146             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
147         }
148     };
149     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
150         declare_tool_lint! {
151             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
152         }
153     };
154     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
155         declare_tool_lint! {
156             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
157         }
158     };
159 }
160
161 #[cfg(feature = "internal")]
162 pub mod deprecated_lints;
163 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
164 mod utils;
165
166 mod renamed_lints;
167
168 // begin lints modules, do not remove this comment, it’s used in `update_lints`
169 mod almost_complete_letter_range;
170 mod approx_const;
171 mod as_conversions;
172 mod asm_syntax;
173 mod assertions_on_constants;
174 mod assertions_on_result_states;
175 mod async_yields_async;
176 mod attrs;
177 mod await_holding_invalid;
178 mod blocks_in_if_conditions;
179 mod bool_assert_comparison;
180 mod bool_to_int_with_if;
181 mod booleans;
182 mod borrow_deref_ref;
183 mod box_default;
184 mod cargo;
185 mod casts;
186 mod checked_conversions;
187 mod cognitive_complexity;
188 mod collapsible_if;
189 mod comparison_chain;
190 mod copies;
191 mod copy_iterator;
192 mod crate_in_macro_def;
193 mod create_dir;
194 mod dbg_macro;
195 mod default;
196 mod default_instead_of_iter_empty;
197 mod default_numeric_fallback;
198 mod default_union_representation;
199 mod dereference;
200 mod derivable_impls;
201 mod derive;
202 mod disallowed_methods;
203 mod disallowed_names;
204 mod disallowed_script_idents;
205 mod disallowed_types;
206 mod doc;
207 mod double_parens;
208 mod drop_forget_ref;
209 mod duplicate_mod;
210 mod else_if_without_else;
211 mod empty_drop;
212 mod empty_enum;
213 mod empty_structs_with_brackets;
214 mod entry;
215 mod enum_clike;
216 mod enum_variants;
217 mod equatable_if_let;
218 mod escape;
219 mod eta_reduction;
220 mod excessive_bools;
221 mod exhaustive_items;
222 mod exit;
223 mod explicit_write;
224 mod fallible_impl_from;
225 mod float_literal;
226 mod floating_point_arithmetic;
227 mod format;
228 mod format_args;
229 mod format_impl;
230 mod format_push_string;
231 mod formatting;
232 mod from_over_into;
233 mod from_str_radix_10;
234 mod functions;
235 mod future_not_send;
236 mod if_let_mutex;
237 mod if_not_else;
238 mod if_then_some_else_none;
239 mod implicit_hasher;
240 mod implicit_return;
241 mod implicit_saturating_add;
242 mod implicit_saturating_sub;
243 mod inconsistent_struct_constructor;
244 mod index_refutable_slice;
245 mod indexing_slicing;
246 mod infinite_iter;
247 mod inherent_impl;
248 mod inherent_to_string;
249 mod init_numbered_fields;
250 mod inline_fn_without_body;
251 mod int_plus_one;
252 mod invalid_upcast_comparisons;
253 mod invalid_utf8_in_unchecked;
254 mod items_after_statements;
255 mod iter_not_returning_iterator;
256 mod large_const_arrays;
257 mod large_enum_variant;
258 mod large_include_file;
259 mod large_stack_arrays;
260 mod len_zero;
261 mod let_if_seq;
262 mod let_underscore;
263 mod lifetimes;
264 mod literal_representation;
265 mod loops;
266 mod macro_use;
267 mod main_recursion;
268 mod manual_assert;
269 mod manual_async_fn;
270 mod manual_bits;
271 mod manual_clamp;
272 mod manual_instant_elapsed;
273 mod manual_non_exhaustive;
274 mod manual_rem_euclid;
275 mod manual_retain;
276 mod manual_string_new;
277 mod manual_strip;
278 mod map_unit_fn;
279 mod match_result_ok;
280 mod matches;
281 mod mem_forget;
282 mod mem_replace;
283 mod methods;
284 mod minmax;
285 mod misc;
286 mod misc_early;
287 mod mismatching_type_param_order;
288 mod missing_const_for_fn;
289 mod missing_doc;
290 mod missing_enforced_import_rename;
291 mod missing_inline;
292 mod mixed_read_write_in_expression;
293 mod module_style;
294 mod multi_assignments;
295 mod mut_key;
296 mod mut_mut;
297 mod mut_reference;
298 mod mutable_debug_assertion;
299 mod mutex_atomic;
300 mod needless_arbitrary_self_type;
301 mod needless_bool;
302 mod needless_borrowed_ref;
303 mod needless_continue;
304 mod needless_for_each;
305 mod needless_late_init;
306 mod needless_parens_on_range_literals;
307 mod needless_pass_by_value;
308 mod needless_question_mark;
309 mod needless_update;
310 mod neg_cmp_op_on_partial_ord;
311 mod neg_multiply;
312 mod new_without_default;
313 mod no_effect;
314 mod non_copy_const;
315 mod non_expressive_names;
316 mod non_octal_unix_permissions;
317 mod non_send_fields_in_send_ty;
318 mod nonstandard_macro_braces;
319 mod octal_escapes;
320 mod only_used_in_recursion;
321 mod operators;
322 mod option_env_unwrap;
323 mod option_if_let_else;
324 mod overflow_check_conditional;
325 mod panic_in_result_fn;
326 mod panic_unimplemented;
327 mod partialeq_ne_impl;
328 mod partialeq_to_none;
329 mod pass_by_ref_or_value;
330 mod pattern_type_mismatch;
331 mod precedence;
332 mod ptr;
333 mod ptr_offset_with_cast;
334 mod pub_use;
335 mod question_mark;
336 mod ranges;
337 mod rc_clone_in_vec_init;
338 mod read_zero_byte_vec;
339 mod redundant_clone;
340 mod redundant_closure_call;
341 mod redundant_else;
342 mod redundant_field_names;
343 mod redundant_pub_crate;
344 mod redundant_slicing;
345 mod redundant_static_lifetimes;
346 mod ref_option_ref;
347 mod reference;
348 mod regex;
349 mod return_self_not_must_use;
350 mod returns;
351 mod same_name_method;
352 mod self_named_constructors;
353 mod semicolon_if_nothing_returned;
354 mod serde_api;
355 mod shadow;
356 mod single_char_lifetime_names;
357 mod single_component_path_imports;
358 mod size_of_in_element_count;
359 mod slow_vector_initialization;
360 mod std_instead_of_core;
361 mod strings;
362 mod strlen_on_c_strings;
363 mod suspicious_operation_groupings;
364 mod suspicious_trait_impl;
365 mod swap;
366 mod swap_ptr_to_ref;
367 mod tabs_in_doc_comments;
368 mod temporary_assignment;
369 mod to_digit_is_some;
370 mod trailing_empty_array;
371 mod trait_bounds;
372 mod transmute;
373 mod types;
374 mod undocumented_unsafe_blocks;
375 mod unicode;
376 mod uninit_vec;
377 mod unit_return_expecting_ord;
378 mod unit_types;
379 mod unnamed_address;
380 mod unnecessary_owned_empty_strings;
381 mod unnecessary_self_imports;
382 mod unnecessary_wraps;
383 mod unnested_or_patterns;
384 mod unsafe_removed_from_name;
385 mod unused_async;
386 mod unused_io_amount;
387 mod unused_peekable;
388 mod unused_rounding;
389 mod unused_self;
390 mod unused_unit;
391 mod unwrap;
392 mod unwrap_in_result;
393 mod upper_case_acronyms;
394 mod use_self;
395 mod useless_conversion;
396 mod vec;
397 mod vec_init_then_push;
398 mod wildcard_imports;
399 mod write;
400 mod zero_div_zero;
401 mod zero_sized_map_values;
402 // end lints modules, do not remove this comment, it’s used in `update_lints`
403
404 pub use crate::utils::conf::Conf;
405 use crate::utils::conf::{format_error, TryConf};
406
407 /// Register all pre expansion lints
408 ///
409 /// Pre-expansion lints run before any macro expansion has happened.
410 ///
411 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
412 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
413 ///
414 /// Used in `./src/driver.rs`.
415 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
416     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
417
418     let msrv = conf.msrv.as_ref().and_then(|s| {
419         parse_msrv(s, None, None).or_else(|| {
420             sess.err(&format!(
421                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
422             ));
423             None
424         })
425     });
426
427     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
428 }
429
430 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
431     let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
432         .ok()
433         .and_then(|v| parse_msrv(&v, None, None));
434     let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
435         parse_msrv(s, None, None).or_else(|| {
436             sess.err(&format!(
437                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
438             ));
439             None
440         })
441     });
442
443     if let Some(cargo_msrv) = cargo_msrv {
444         if let Some(clippy_msrv) = clippy_msrv {
445             // if both files have an msrv, let's compare them and emit a warning if they differ
446             if clippy_msrv != cargo_msrv {
447                 sess.warn(&format!(
448                     "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{clippy_msrv}` from `clippy.toml`"
449                 ));
450             }
451
452             Some(clippy_msrv)
453         } else {
454             Some(cargo_msrv)
455         }
456     } else {
457         clippy_msrv
458     }
459 }
460
461 #[doc(hidden)]
462 pub fn read_conf(sess: &Session) -> Conf {
463     let file_name = match utils::conf::lookup_conf_file() {
464         Ok(Some(path)) => path,
465         Ok(None) => return Conf::default(),
466         Err(error) => {
467             sess.struct_err(&format!("error finding Clippy's configuration file: {error}"))
468                 .emit();
469             return Conf::default();
470         },
471     };
472
473     let TryConf { conf, errors, warnings } = utils::conf::read(&file_name);
474     // all conf errors are non-fatal, we just use the default conf in case of error
475     for error in errors {
476         sess.err(&format!(
477             "error reading Clippy's configuration file `{}`: {}",
478             file_name.display(),
479             format_error(error)
480         ));
481     }
482
483     for warning in warnings {
484         sess.struct_warn(&format!(
485             "error reading Clippy's configuration file `{}`: {}",
486             file_name.display(),
487             format_error(warning)
488         ))
489         .emit();
490     }
491
492     conf
493 }
494
495 /// Register all lints and lint groups with the rustc plugin registry
496 ///
497 /// Used in `./src/driver.rs`.
498 #[expect(clippy::too_many_lines)]
499 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
500     register_removed_non_tool_lints(store);
501
502     include!("lib.deprecated.rs");
503
504     include!("lib.register_lints.rs");
505     include!("lib.register_restriction.rs");
506     include!("lib.register_pedantic.rs");
507
508     #[cfg(feature = "internal")]
509     include!("lib.register_internal.rs");
510
511     include!("lib.register_all.rs");
512     include!("lib.register_style.rs");
513     include!("lib.register_complexity.rs");
514     include!("lib.register_correctness.rs");
515     include!("lib.register_suspicious.rs");
516     include!("lib.register_perf.rs");
517     include!("lib.register_cargo.rs");
518     include!("lib.register_nursery.rs");
519
520     #[cfg(feature = "internal")]
521     {
522         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
523             store.register_late_pass(|_| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
524             return;
525         }
526     }
527
528     // all the internal lints
529     #[cfg(feature = "internal")]
530     {
531         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
532         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
533         store.register_late_pass(|_| Box::new(utils::internal_lints::CollapsibleCalls));
534         store.register_late_pass(|_| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
535         store.register_late_pass(|_| Box::new(utils::internal_lints::IfChainStyle));
536         store.register_late_pass(|_| Box::new(utils::internal_lints::InvalidPaths));
537         store.register_late_pass(|_| Box::<utils::internal_lints::InterningDefinedSymbol>::default());
538         store.register_late_pass(|_| Box::<utils::internal_lints::LintWithoutLintPass>::default());
539         store.register_late_pass(|_| Box::new(utils::internal_lints::UnnecessaryDefPath));
540         store.register_late_pass(|_| Box::new(utils::internal_lints::OuterExpnDataPass));
541         store.register_late_pass(|_| Box::new(utils::internal_lints::MsrvAttrImpl));
542     }
543
544     let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
545     store.register_late_pass(move |_| {
546         Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
547             arithmetic_side_effects_allowed.clone(),
548         ))
549     });
550     store.register_late_pass(|_| Box::new(utils::dump_hir::DumpHir));
551     store.register_late_pass(|_| Box::new(utils::author::Author));
552     let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
553     store.register_late_pass(move |_| {
554         Box::new(await_holding_invalid::AwaitHolding::new(
555             await_holding_invalid_types.clone(),
556         ))
557     });
558     store.register_late_pass(|_| Box::new(serde_api::SerdeApi));
559     let vec_box_size_threshold = conf.vec_box_size_threshold;
560     let type_complexity_threshold = conf.type_complexity_threshold;
561     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
562     store.register_late_pass(move |_| {
563         Box::new(types::Types::new(
564             vec_box_size_threshold,
565             type_complexity_threshold,
566             avoid_breaking_exported_api,
567         ))
568     });
569     store.register_late_pass(|_| Box::new(booleans::NonminimalBool));
570     store.register_late_pass(|_| Box::new(enum_clike::UnportableVariant));
571     store.register_late_pass(|_| Box::new(float_literal::FloatLiteral));
572     store.register_late_pass(|_| Box::new(ptr::Ptr));
573     store.register_late_pass(|_| Box::new(needless_bool::NeedlessBool));
574     store.register_late_pass(|_| Box::new(needless_bool::BoolComparison));
575     store.register_late_pass(|_| Box::new(needless_for_each::NeedlessForEach));
576     store.register_late_pass(|_| Box::new(misc::MiscLints));
577     store.register_late_pass(|_| Box::new(eta_reduction::EtaReduction));
578     store.register_late_pass(|_| Box::new(mut_mut::MutMut));
579     store.register_late_pass(|_| Box::new(mut_reference::UnnecessaryMutPassed));
580     store.register_late_pass(|_| Box::new(len_zero::LenZero));
581     store.register_late_pass(|_| Box::new(attrs::Attributes));
582     store.register_late_pass(|_| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
583     store.register_late_pass(|_| Box::new(unicode::Unicode));
584     store.register_late_pass(|_| Box::new(uninit_vec::UninitVec));
585     store.register_late_pass(|_| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
586     store.register_late_pass(|_| Box::new(strings::StringAdd));
587     store.register_late_pass(|_| Box::new(implicit_return::ImplicitReturn));
588     store.register_late_pass(|_| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
589     store.register_late_pass(|_| Box::new(default_numeric_fallback::DefaultNumericFallback));
590     store.register_late_pass(|_| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
591     store.register_late_pass(|_| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
592     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
593
594     let msrv = read_msrv(conf, sess);
595     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
596     let allow_expect_in_tests = conf.allow_expect_in_tests;
597     let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
598     store.register_late_pass(move |_| Box::new(approx_const::ApproxConstant::new(msrv)));
599     store.register_late_pass(move |_| {
600         Box::new(methods::Methods::new(
601             avoid_breaking_exported_api,
602             msrv,
603             allow_expect_in_tests,
604             allow_unwrap_in_tests,
605         ))
606     });
607     store.register_late_pass(move |_| Box::new(matches::Matches::new(msrv)));
608     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
609     store.register_late_pass(move |_| Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
610     store.register_late_pass(move |_| Box::new(manual_strip::ManualStrip::new(msrv)));
611     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
612     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
613     store.register_late_pass(move |_| Box::new(checked_conversions::CheckedConversions::new(msrv)));
614     store.register_late_pass(move |_| Box::new(mem_replace::MemReplace::new(msrv)));
615     store.register_late_pass(move |_| Box::new(ranges::Ranges::new(msrv)));
616     store.register_late_pass(move |_| Box::new(from_over_into::FromOverInto::new(msrv)));
617     store.register_late_pass(move |_| Box::new(use_self::UseSelf::new(msrv)));
618     store.register_late_pass(move |_| Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
619     store.register_late_pass(move |_| Box::new(needless_question_mark::NeedlessQuestionMark));
620     store.register_late_pass(move |_| Box::new(casts::Casts::new(msrv)));
621     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
622     store.register_late_pass(|_| Box::new(size_of_in_element_count::SizeOfInElementCount));
623     store.register_late_pass(|_| Box::new(same_name_method::SameNameMethod));
624     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
625     store.register_late_pass(move |_| {
626         Box::new(index_refutable_slice::IndexRefutableSlice::new(
627             max_suggested_slice_pattern_length,
628             msrv,
629         ))
630     });
631     store.register_late_pass(|_| Box::<shadow::Shadow>::default());
632     store.register_late_pass(|_| Box::new(unit_types::UnitTypes));
633     store.register_late_pass(|_| Box::new(loops::Loops));
634     store.register_late_pass(|_| Box::<main_recursion::MainRecursion>::default());
635     store.register_late_pass(|_| Box::new(lifetimes::Lifetimes));
636     store.register_late_pass(|_| Box::new(entry::HashMapPass));
637     store.register_late_pass(|_| Box::new(minmax::MinMaxPass));
638     store.register_late_pass(|_| Box::new(zero_div_zero::ZeroDiv));
639     store.register_late_pass(|_| Box::new(mutex_atomic::Mutex));
640     store.register_late_pass(|_| Box::new(needless_update::NeedlessUpdate));
641     store.register_late_pass(|_| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
642     store.register_late_pass(|_| Box::new(borrow_deref_ref::BorrowDerefRef));
643     store.register_late_pass(|_| Box::new(no_effect::NoEffect));
644     store.register_late_pass(|_| Box::new(temporary_assignment::TemporaryAssignment));
645     store.register_late_pass(move |_| Box::new(transmute::Transmute::new(msrv)));
646     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
647     store.register_late_pass(move |_| {
648         Box::new(cognitive_complexity::CognitiveComplexity::new(
649             cognitive_complexity_threshold,
650         ))
651     });
652     let too_large_for_stack = conf.too_large_for_stack;
653     store.register_late_pass(move |_| Box::new(escape::BoxedLocal { too_large_for_stack }));
654     store.register_late_pass(move |_| Box::new(vec::UselessVec { too_large_for_stack }));
655     store.register_late_pass(|_| Box::new(panic_unimplemented::PanicUnimplemented));
656     store.register_late_pass(|_| Box::new(strings::StringLitAsBytes));
657     store.register_late_pass(|_| Box::new(derive::Derive));
658     store.register_late_pass(|_| Box::new(derivable_impls::DerivableImpls));
659     store.register_late_pass(|_| Box::new(drop_forget_ref::DropForgetRef));
660     store.register_late_pass(|_| Box::new(empty_enum::EmptyEnum));
661     store.register_late_pass(|_| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
662     store.register_late_pass(|_| Box::new(regex::Regex));
663     store.register_late_pass(|_| Box::new(copies::CopyAndPaste));
664     store.register_late_pass(|_| Box::new(copy_iterator::CopyIterator));
665     store.register_late_pass(|_| Box::new(format::UselessFormat));
666     store.register_late_pass(|_| Box::new(swap::Swap));
667     store.register_late_pass(|_| Box::new(overflow_check_conditional::OverflowCheckConditional));
668     store.register_late_pass(|_| Box::<new_without_default::NewWithoutDefault>::default());
669     let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
670     store.register_late_pass(move |_| Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
671     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
672     let too_many_lines_threshold = conf.too_many_lines_threshold;
673     let large_error_threshold = conf.large_error_threshold;
674     store.register_late_pass(move |_| {
675         Box::new(functions::Functions::new(
676             too_many_arguments_threshold,
677             too_many_lines_threshold,
678             large_error_threshold,
679         ))
680     });
681     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
682     store.register_late_pass(move |_| Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
683     store.register_late_pass(|_| Box::new(neg_multiply::NegMultiply));
684     store.register_late_pass(|_| Box::new(mem_forget::MemForget));
685     store.register_late_pass(|_| Box::new(let_if_seq::LetIfSeq));
686     store.register_late_pass(|_| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
687     store.register_late_pass(|_| Box::new(missing_doc::MissingDoc::new()));
688     store.register_late_pass(|_| Box::new(missing_inline::MissingInline));
689     store.register_late_pass(move |_| Box::new(exhaustive_items::ExhaustiveItems));
690     store.register_late_pass(|_| Box::new(match_result_ok::MatchResultOk));
691     store.register_late_pass(|_| Box::new(partialeq_ne_impl::PartialEqNeImpl));
692     store.register_late_pass(|_| Box::new(unused_io_amount::UnusedIoAmount));
693     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
694     store.register_late_pass(move |_| Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
695     store.register_late_pass(|_| Box::new(explicit_write::ExplicitWrite));
696     store.register_late_pass(|_| Box::new(needless_pass_by_value::NeedlessPassByValue));
697     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
698         conf.trivial_copy_size_limit,
699         conf.pass_by_value_size_limit,
700         conf.avoid_breaking_exported_api,
701         &sess.target,
702     );
703     store.register_late_pass(move |_| Box::new(pass_by_ref_or_value));
704     store.register_late_pass(|_| Box::new(ref_option_ref::RefOptionRef));
705     store.register_late_pass(|_| Box::new(infinite_iter::InfiniteIter));
706     store.register_late_pass(|_| Box::new(inline_fn_without_body::InlineFnWithoutBody));
707     store.register_late_pass(|_| Box::<useless_conversion::UselessConversion>::default());
708     store.register_late_pass(|_| Box::new(implicit_hasher::ImplicitHasher));
709     store.register_late_pass(|_| Box::new(fallible_impl_from::FallibleImplFrom));
710     store.register_late_pass(|_| Box::new(question_mark::QuestionMark));
711     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
712     store.register_late_pass(|_| Box::new(suspicious_trait_impl::SuspiciousImpl));
713     store.register_late_pass(|_| Box::new(map_unit_fn::MapUnit));
714     store.register_late_pass(|_| Box::new(inherent_impl::MultipleInherentImpl));
715     store.register_late_pass(|_| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
716     store.register_late_pass(|_| Box::new(unwrap::Unwrap));
717     store.register_late_pass(|_| Box::new(indexing_slicing::IndexingSlicing));
718     store.register_late_pass(|_| Box::new(non_copy_const::NonCopyConst));
719     store.register_late_pass(|_| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
720     store.register_late_pass(|_| Box::new(redundant_clone::RedundantClone));
721     store.register_late_pass(|_| Box::new(slow_vector_initialization::SlowVectorInit));
722     store.register_late_pass(move |_| Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
723     store.register_late_pass(|_| Box::new(assertions_on_constants::AssertionsOnConstants));
724     store.register_late_pass(|_| Box::new(assertions_on_result_states::AssertionsOnResultStates));
725     store.register_late_pass(|_| Box::new(inherent_to_string::InherentToString));
726     let max_trait_bounds = conf.max_trait_bounds;
727     store.register_late_pass(move |_| Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
728     store.register_late_pass(|_| Box::new(comparison_chain::ComparisonChain));
729     store.register_late_pass(|_| Box::new(mut_key::MutableKeyType));
730     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
731     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
732     store.register_late_pass(|_| Box::new(format_impl::FormatImpl::new()));
733     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
734     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
735     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
736     store.register_early_pass(|| Box::new(formatting::Formatting));
737     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
738     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
739     store.register_late_pass(|_| Box::new(redundant_closure_call::RedundantClosureCall));
740     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
741     store.register_late_pass(|_| Box::new(returns::Return));
742     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
743     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
744     store.register_early_pass(|| Box::new(precedence::Precedence));
745     store.register_late_pass(|_| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
746     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
747     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
748     store.register_late_pass(|_| Box::new(create_dir::CreateDir));
749     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
750     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
751     store.register_early_pass(move || {
752         Box::new(literal_representation::LiteralDigitGrouping::new(
753             literal_representation_lint_fraction_readability,
754         ))
755     });
756     let literal_representation_threshold = conf.literal_representation_threshold;
757     store.register_early_pass(move || {
758         Box::new(literal_representation::DecimalLiteralRepresentation::new(
759             literal_representation_threshold,
760         ))
761     });
762     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
763     store.register_late_pass(move |_| {
764         Box::new(enum_variants::EnumVariantNames::new(
765             enum_variant_name_threshold,
766             avoid_breaking_exported_api,
767         ))
768     });
769     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
770     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
771     store.register_late_pass(move |_| {
772         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
773             avoid_breaking_exported_api,
774             upper_case_acronyms_aggressive,
775         ))
776     });
777     store.register_late_pass(|_| Box::<default::Default>::default());
778     store.register_late_pass(move |_| Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
779     store.register_late_pass(|_| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
780     store.register_late_pass(|_| Box::new(exit::Exit));
781     store.register_late_pass(|_| Box::new(to_digit_is_some::ToDigitIsSome));
782     let array_size_threshold = conf.array_size_threshold;
783     store.register_late_pass(move |_| Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
784     store.register_late_pass(move |_| Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
785     store.register_late_pass(|_| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
786     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
787     store.register_late_pass(|_| Box::new(let_underscore::LetUnderscore));
788     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
789     let max_fn_params_bools = conf.max_fn_params_bools;
790     let max_struct_bools = conf.max_struct_bools;
791     store.register_early_pass(move || {
792         Box::new(excessive_bools::ExcessiveBools::new(
793             max_struct_bools,
794             max_fn_params_bools,
795         ))
796     });
797     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
798     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
799     store.register_late_pass(move |_| Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
800     store.register_late_pass(|_| Box::<redundant_pub_crate::RedundantPubCrate>::default());
801     store.register_late_pass(|_| Box::new(unnamed_address::UnnamedAddress));
802     store.register_late_pass(move |_| Box::new(dereference::Dereferencing::new(msrv)));
803     store.register_late_pass(|_| Box::new(option_if_let_else::OptionIfLetElse));
804     store.register_late_pass(|_| Box::new(future_not_send::FutureNotSend));
805     store.register_late_pass(|_| Box::new(if_let_mutex::IfLetMutex));
806     store.register_late_pass(|_| Box::new(if_not_else::IfNotElse));
807     store.register_late_pass(|_| Box::new(equatable_if_let::PatternEquality));
808     store.register_late_pass(|_| Box::new(manual_async_fn::ManualAsyncFn));
809     store.register_late_pass(|_| Box::new(panic_in_result_fn::PanicInResultFn));
810     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
811     store.register_early_pass(move || {
812         Box::new(non_expressive_names::NonExpressiveNames {
813             single_char_binding_names_threshold,
814         })
815     });
816     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
817     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
818     store.register_late_pass(|_| Box::<macro_use::MacroUseImports>::default());
819     store.register_late_pass(|_| Box::new(pattern_type_mismatch::PatternTypeMismatch));
820     store.register_late_pass(|_| Box::new(unwrap_in_result::UnwrapInResult));
821     store.register_late_pass(|_| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
822     store.register_late_pass(|_| Box::new(async_yields_async::AsyncYieldsAsync));
823     let disallowed_methods = conf.disallowed_methods.clone();
824     store.register_late_pass(move |_| Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
825     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
826     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
827     store.register_late_pass(|_| Box::new(empty_drop::EmptyDrop));
828     store.register_late_pass(|_| Box::new(strings::StrToString));
829     store.register_late_pass(|_| Box::new(strings::StringToString));
830     store.register_late_pass(|_| Box::new(zero_sized_map_values::ZeroSizedMapValues));
831     store.register_late_pass(|_| Box::<vec_init_then_push::VecInitThenPush>::default());
832     store.register_late_pass(|_| Box::new(redundant_slicing::RedundantSlicing));
833     store.register_late_pass(|_| Box::new(from_str_radix_10::FromStrRadix10));
834     store.register_late_pass(move |_| Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
835     store.register_late_pass(|_| Box::new(bool_assert_comparison::BoolAssertComparison));
836     store.register_early_pass(move || Box::new(module_style::ModStyle));
837     store.register_late_pass(|_| Box::new(unused_async::UnusedAsync));
838     let disallowed_types = conf.disallowed_types.clone();
839     store.register_late_pass(move |_| Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
840     let import_renames = conf.enforced_import_renames.clone();
841     store.register_late_pass(move |_| {
842         Box::new(missing_enforced_import_rename::ImportRename::new(
843             import_renames.clone(),
844         ))
845     });
846     let scripts = conf.allowed_scripts.clone();
847     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
848     store.register_late_pass(|_| Box::new(strlen_on_c_strings::StrlenOnCStrings));
849     store.register_late_pass(move |_| Box::new(self_named_constructors::SelfNamedConstructors));
850     store.register_late_pass(move |_| Box::new(iter_not_returning_iterator::IterNotReturningIterator));
851     store.register_late_pass(move |_| Box::new(manual_assert::ManualAssert));
852     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
853     store.register_late_pass(move |_| {
854         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
855             enable_raw_pointer_heuristic_for_send,
856         ))
857     });
858     store.register_late_pass(move |_| Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
859     store.register_late_pass(move |_| Box::new(format_args::FormatArgs::new(msrv)));
860     store.register_late_pass(|_| Box::new(trailing_empty_array::TrailingEmptyArray));
861     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
862     store.register_late_pass(|_| Box::new(needless_late_init::NeedlessLateInit));
863     store.register_late_pass(|_| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
864     store.register_late_pass(|_| Box::new(init_numbered_fields::NumberedFields));
865     store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
866     store.register_late_pass(move |_| Box::new(manual_bits::ManualBits::new(msrv)));
867     store.register_late_pass(|_| Box::new(default_union_representation::DefaultUnionRepresentation));
868     store.register_late_pass(|_| Box::<only_used_in_recursion::OnlyUsedInRecursion>::default());
869     let allow_dbg_in_tests = conf.allow_dbg_in_tests;
870     store.register_late_pass(move |_| Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
871     let cargo_ignore_publish = conf.cargo_ignore_publish;
872     store.register_late_pass(move |_| {
873         Box::new(cargo::Cargo {
874             ignore_publish: cargo_ignore_publish,
875         })
876     });
877     store.register_late_pass(|_| Box::<write::Write>::default());
878     store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
879     store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
880     store.register_late_pass(|_| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
881     store.register_early_pass(|| Box::new(pub_use::PubUse));
882     store.register_late_pass(|_| Box::new(format_push_string::FormatPushString));
883     let max_include_file_size = conf.max_include_file_size;
884     store.register_late_pass(move |_| Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
885     store.register_late_pass(|_| Box::new(strings::TrimSplitWhitespace));
886     store.register_late_pass(|_| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
887     store.register_early_pass(|| Box::<duplicate_mod::DuplicateMod>::default());
888     store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
889     store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
890     store.register_late_pass(|_| Box::new(swap_ptr_to_ref::SwapPtrToRef));
891     store.register_late_pass(|_| Box::new(mismatching_type_param_order::TypeParamMismatch));
892     store.register_late_pass(|_| Box::new(read_zero_byte_vec::ReadZeroByteVec));
893     store.register_late_pass(|_| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
894     store.register_late_pass(move |_| Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
895     store.register_late_pass(move |_| Box::new(manual_retain::ManualRetain::new(msrv)));
896     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
897     store.register_late_pass(move |_| Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
898     store.register_late_pass(|_| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
899     store.register_late_pass(|_| Box::<std_instead_of_core::StdReexports>::default());
900     store.register_late_pass(|_| Box::new(manual_instant_elapsed::ManualInstantElapsed));
901     store.register_late_pass(|_| Box::new(partialeq_to_none::PartialeqToNone));
902     store.register_late_pass(move |_| Box::new(manual_clamp::ManualClamp::new(msrv)));
903     store.register_late_pass(|_| Box::new(manual_string_new::ManualStringNew));
904     store.register_late_pass(|_| Box::new(unused_peekable::UnusedPeekable));
905     store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
906     store.register_late_pass(|_| Box::new(bool_to_int_with_if::BoolToIntWithIf));
907     store.register_late_pass(|_| Box::new(box_default::BoxDefault));
908     store.register_late_pass(|_| Box::new(implicit_saturating_add::ImplicitSaturatingAdd));
909     // add lints here, do not remove this comment, it's used in `new_lint`
910 }
911
912 #[rustfmt::skip]
913 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
914     store.register_removed(
915         "should_assert_eq",
916         "`assert!()` will be more flexible with RFC 2011",
917     );
918     store.register_removed(
919         "extend_from_slice",
920         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
921     );
922     store.register_removed(
923         "range_step_by_zero",
924         "`iterator.step_by(0)` panics nowadays",
925     );
926     store.register_removed(
927         "unstable_as_slice",
928         "`Vec::as_slice` has been stabilized in 1.7",
929     );
930     store.register_removed(
931         "unstable_as_mut_slice",
932         "`Vec::as_mut_slice` has been stabilized in 1.7",
933     );
934     store.register_removed(
935         "misaligned_transmute",
936         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
937     );
938     store.register_removed(
939         "assign_ops",
940         "using compound assignment operators (e.g., `+=`) is harmless",
941     );
942     store.register_removed(
943         "if_let_redundant_pattern_matching",
944         "this lint has been changed to redundant_pattern_matching",
945     );
946     store.register_removed(
947         "unsafe_vector_initialization",
948         "the replacement suggested by this lint had substantially different behavior",
949     );
950     store.register_removed(
951         "reverse_range_loop",
952         "this lint is now included in reversed_empty_ranges",
953     );
954 }
955
956 /// Register renamed lints.
957 ///
958 /// Used in `./src/driver.rs`.
959 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
960     for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
961         ls.register_renamed(old_name, new_name);
962     }
963 }
964
965 // only exists to let the dogfood integration test works.
966 // Don't run clippy as an executable directly
967 #[allow(dead_code)]
968 fn main() {
969     panic!("Please use the cargo-clippy executable");
970 }