1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
15 extern crate cargo_metadata;
18 extern crate rustc_target;
19 extern crate rustc_typeck;
21 extern crate syntax_pos;
25 // for unicode nfc normalization
27 extern crate unicode_normalization;
29 // for semver check in attrs.rs
35 extern crate regex_syntax;
37 // for finding minimal boolean expressions
39 extern crate quine_mc_cluskey;
41 extern crate rustc_errors;
42 extern crate rustc_plugin;
45 extern crate matches as matches_macro;
49 extern crate serde_derive;
52 extern crate lazy_static;
54 extern crate itertools;
55 extern crate pulldown_cmark;
59 extern crate if_chain;
61 macro_rules! declare_clippy_lint {
62 { pub $name:tt, style, $description:tt } => {
63 declare_lint! { pub $name, Warn, $description }
65 { pub $name:tt, correctness, $description:tt } => {
66 declare_lint! { pub $name, Deny, $description }
68 { pub $name:tt, complexity, $description:tt } => {
69 declare_lint! { pub $name, Warn, $description }
71 { pub $name:tt, perf, $description:tt } => {
72 declare_lint! { pub $name, Warn, $description }
74 { pub $name:tt, pedantic, $description:tt } => {
75 declare_lint! { pub $name, Allow, $description }
77 { pub $name:tt, restriction, $description:tt } => {
78 declare_lint! { pub $name, Allow, $description }
80 { pub $name:tt, cargo, $description:tt } => {
81 declare_lint! { pub $name, Allow, $description }
83 { pub $name:tt, nursery, $description:tt } => {
84 declare_lint! { pub $name, Allow, $description }
86 { pub $name:tt, internal, $description:tt } => {
87 declare_lint! { pub $name, Allow, $description }
89 { pub $name:tt, internal_warn, $description:tt } => {
90 declare_lint! { pub $name, Warn, $description }
98 // begin lints modules, do not remove this comment, it’s used in `update_lints`
101 pub mod array_indexing;
105 pub mod blacklisted_name;
106 pub mod block_in_if_condition;
109 pub mod collapsible_if;
110 pub mod const_static_lifetime;
112 pub mod cyclomatic_complexity;
115 pub mod double_comparison;
116 pub mod double_parens;
117 pub mod drop_forget_ref;
118 pub mod else_if_without_else;
122 pub mod enum_glob_use;
123 pub mod enum_variants;
127 pub mod eta_reduction;
128 pub mod eval_order_dependence;
129 pub mod excessive_precision;
130 pub mod explicit_write;
131 pub mod fallible_impl_from;
135 pub mod identity_conversion;
137 pub mod if_let_redundant_pattern_matching;
139 pub mod infallible_destructuring_match;
140 pub mod infinite_iter;
141 pub mod inline_fn_without_body;
142 pub mod int_plus_one;
144 pub mod items_after_statements;
145 pub mod large_enum_variant;
149 pub mod literal_representation;
160 pub mod multiple_crate_versions;
162 pub mod mut_reference;
163 pub mod mutex_atomic;
164 pub mod needless_bool;
165 pub mod needless_borrow;
166 pub mod needless_borrowed_ref;
167 pub mod needless_continue;
168 pub mod needless_pass_by_value;
169 pub mod needless_update;
170 pub mod neg_multiply;
171 pub mod new_without_default;
173 pub mod non_expressive_names;
175 pub mod open_options;
176 pub mod overflow_check_conditional;
177 pub mod panic_unimplemented;
178 pub mod partialeq_ne_impl;
181 pub mod question_mark;
183 pub mod redundant_field_names;
186 pub mod replace_consts;
191 pub mod suspicious_trait_impl;
193 pub mod temporary_assignment;
197 pub mod unsafe_removed_from_name;
198 pub mod unused_io_amount;
199 pub mod unused_label;
203 pub mod zero_div_zero;
204 // end lints modules, do not remove this comment, it’s used in `update_lints`
207 pub use syntax::ast::{Name, NodeId};
210 #[cfg_attr(rustfmt, rustfmt_skip)]
211 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
212 let conf = match utils::conf::file_from_args(reg.args()) {
214 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
215 // do not require the file to exist
216 let file_name = if let Some(file_name) = file_name {
219 match utils::conf::lookup_conf_file() {
222 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
228 let file_name = file_name.map(|file_name| if file_name.is_relative() {
230 .local_crate_source_file
232 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
239 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
241 // all conf errors are non-fatal, we just use the default conf in case of error
242 for error in errors {
243 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
248 Err((err, span)) => {
249 reg.sess.struct_span_err(span, err)
250 .span_note(span, "Clippy will use default configuration")
252 toml::from_str("").expect("we never error on empty config files")
256 let mut store = reg.sess.lint_store.borrow_mut();
257 store.register_removed(
259 "`assert!()` will be more flexible with RFC 2011",
261 store.register_removed(
263 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
265 store.register_removed(
266 "range_step_by_zero",
267 "`iterator.step_by(0)` panics nowadays",
269 store.register_removed(
271 "`Vec::as_slice` has been stabilized in 1.7",
273 store.register_removed(
274 "unstable_as_mut_slice",
275 "`Vec::as_mut_slice` has been stabilized in 1.7",
277 store.register_removed(
279 "using `str::to_string` is common even today and specialization will likely happen soon",
281 store.register_removed(
283 "using `string::to_string` is common even today and specialization will likely happen soon",
285 store.register_removed(
286 "misaligned_transmute",
287 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
289 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
291 reg.register_late_lint_pass(box serde_api::Serde);
292 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
293 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
294 reg.register_late_lint_pass(box utils::inspector::Pass);
295 reg.register_late_lint_pass(box utils::author::Pass);
296 reg.register_late_lint_pass(box types::TypePass);
297 reg.register_late_lint_pass(box booleans::NonminimalBool);
298 reg.register_late_lint_pass(box eq_op::EqOp);
299 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
300 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
301 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
302 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
303 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
304 reg.register_late_lint_pass(box ptr::PointerPass);
305 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
306 reg.register_late_lint_pass(box needless_bool::BoolComparison);
307 reg.register_late_lint_pass(box approx_const::Pass);
308 reg.register_late_lint_pass(box misc::Pass);
309 reg.register_early_lint_pass(box precedence::Precedence);
310 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
311 reg.register_late_lint_pass(box eta_reduction::EtaPass);
312 reg.register_late_lint_pass(box identity_op::IdentityOp);
313 reg.register_late_lint_pass(box erasing_op::ErasingOp);
314 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
315 reg.register_late_lint_pass(box mut_mut::MutMut);
316 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
317 reg.register_late_lint_pass(box len_zero::LenZero);
318 reg.register_late_lint_pass(box attrs::AttrPass);
319 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
320 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
321 reg.register_late_lint_pass(box unicode::Unicode);
322 reg.register_late_lint_pass(box strings::StringAdd);
323 reg.register_early_lint_pass(box returns::ReturnPass);
324 reg.register_late_lint_pass(box methods::Pass);
325 reg.register_late_lint_pass(box shadow::Pass);
326 reg.register_late_lint_pass(box types::LetPass);
327 reg.register_late_lint_pass(box types::UnitCmp);
328 reg.register_late_lint_pass(box loops::Pass);
329 reg.register_late_lint_pass(box lifetimes::LifetimePass);
330 reg.register_late_lint_pass(box entry::HashMapLint);
331 reg.register_late_lint_pass(box ranges::Pass);
332 reg.register_late_lint_pass(box types::CastPass);
333 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
334 reg.register_late_lint_pass(box matches::MatchPass);
335 reg.register_late_lint_pass(box minmax::MinMaxPass);
336 reg.register_late_lint_pass(box open_options::NonSensical);
337 reg.register_late_lint_pass(box zero_div_zero::Pass);
338 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
339 reg.register_late_lint_pass(box needless_update::Pass);
340 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
341 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
342 reg.register_late_lint_pass(box no_effect::Pass);
343 reg.register_late_lint_pass(box map_clone::Pass);
344 reg.register_late_lint_pass(box temporary_assignment::Pass);
345 reg.register_late_lint_pass(box transmute::Transmute);
346 reg.register_late_lint_pass(
347 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
349 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
350 reg.register_early_lint_pass(box misc_early::MiscEarly);
351 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
352 reg.register_late_lint_pass(box panic_unimplemented::Pass);
353 reg.register_late_lint_pass(box strings::StringLitAsBytes);
354 reg.register_late_lint_pass(box derive::Derive);
355 reg.register_late_lint_pass(box types::CharLitAsU8);
356 reg.register_late_lint_pass(box write::Pass);
357 reg.register_late_lint_pass(box vec::Pass);
358 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
359 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
361 reg.register_late_lint_pass(box drop_forget_ref::Pass);
362 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
363 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
364 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
365 reg.register_late_lint_pass(box regex::Pass::default());
366 reg.register_late_lint_pass(box copies::CopyAndPaste);
367 reg.register_late_lint_pass(box format::Pass);
368 reg.register_early_lint_pass(box formatting::Formatting);
369 reg.register_late_lint_pass(box swap::Swap);
370 reg.register_early_lint_pass(box if_not_else::IfNotElse);
371 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
372 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
373 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
374 reg.register_late_lint_pass(box unused_label::UnusedLabel);
375 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
376 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
377 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
378 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
379 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
380 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
381 reg.register_late_lint_pass(box mem_forget::MemForget);
382 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
383 reg.register_late_lint_pass(box assign_ops::AssignOps);
384 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
385 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
386 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
387 reg.register_late_lint_pass(box ok_if_let::Pass);
388 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
389 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
390 reg.register_early_lint_pass(box reference::Pass);
391 reg.register_early_lint_pass(box reference::DerefPass);
392 reg.register_early_lint_pass(box double_parens::DoubleParens);
393 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
394 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
395 reg.register_late_lint_pass(box explicit_write::Pass);
396 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
397 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
398 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
399 conf.literal_representation_threshold
401 reg.register_late_lint_pass(box use_self::UseSelf);
402 reg.register_late_lint_pass(box bytecount::ByteCount);
403 reg.register_late_lint_pass(box infinite_iter::Pass);
404 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
405 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
406 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
407 reg.register_late_lint_pass(box types::ImplicitHasher);
408 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
409 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
410 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
411 reg.register_late_lint_pass(box types::UnitArg);
412 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
413 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
414 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
415 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
416 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
417 reg.register_late_lint_pass(box map_unit_fn::Pass);
418 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
421 reg.register_lint_group("clippy_restriction", vec![
422 arithmetic::FLOAT_ARITHMETIC,
423 arithmetic::INTEGER_ARITHMETIC,
424 array_indexing::INDEXING_SLICING,
425 assign_ops::ASSIGN_OPS,
426 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
427 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
428 mem_forget::MEM_FORGET,
429 methods::CLONE_ON_REF_PTR,
430 methods::OPTION_UNWRAP_USED,
431 methods::RESULT_UNWRAP_USED,
432 methods::WRONG_PUB_SELF_CONVENTION,
433 misc::FLOAT_CMP_CONST,
434 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
435 panic_unimplemented::UNIMPLEMENTED,
436 shadow::SHADOW_REUSE,
438 shadow::SHADOW_UNRELATED,
444 reg.register_lint_group("clippy_pedantic", vec![
445 attrs::INLINE_ALWAYS,
446 copies::MATCH_SAME_ARMS,
447 derive::EXPL_IMPL_CLONE_ON_COPY,
449 empty_enum::EMPTY_ENUM,
450 enum_glob_use::ENUM_GLOB_USE,
451 enum_variants::PUB_ENUM_VARIANT_NAMES,
452 enum_variants::STUTTER,
453 if_not_else::IF_NOT_ELSE,
454 infinite_iter::MAYBE_INFINITE_ITER,
455 items_after_statements::ITEMS_AFTER_STATEMENTS,
456 matches::SINGLE_MATCH_ELSE,
458 methods::OPTION_MAP_UNWRAP_OR,
459 methods::OPTION_MAP_UNWRAP_OR_ELSE,
460 methods::RESULT_MAP_UNWRAP_OR_ELSE,
461 misc::USED_UNDERSCORE_BINDING,
462 misc_early::UNSEPARATED_LITERAL_SUFFIX,
464 needless_continue::NEEDLESS_CONTINUE,
465 non_expressive_names::SIMILAR_NAMES,
466 replace_consts::REPLACE_CONSTS,
467 strings::STRING_ADD_ASSIGN,
468 types::CAST_POSSIBLE_TRUNCATION,
469 types::CAST_POSSIBLE_WRAP,
470 types::CAST_PRECISION_LOSS,
471 types::CAST_SIGN_LOSS,
472 types::INVALID_UPCAST_COMPARISONS,
474 unicode::NON_ASCII_LITERAL,
475 unicode::UNICODE_NOT_NFC,
479 reg.register_lint_group("clippy_internal", vec![
480 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
481 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
484 reg.register_lint_group("clippy", vec![
485 approx_const::APPROX_CONSTANT,
486 array_indexing::OUT_OF_BOUNDS_INDEXING,
487 assign_ops::ASSIGN_OP_PATTERN,
488 assign_ops::MISREFACTORED_ASSIGN_OP,
489 attrs::DEPRECATED_SEMVER,
490 attrs::USELESS_ATTRIBUTE,
491 bit_mask::BAD_BIT_MASK,
492 bit_mask::INEFFECTIVE_BIT_MASK,
493 bit_mask::VERBOSE_BIT_MASK,
494 blacklisted_name::BLACKLISTED_NAME,
495 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
496 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
498 booleans::NONMINIMAL_BOOL,
499 bytecount::NAIVE_BYTECOUNT,
500 collapsible_if::COLLAPSIBLE_IF,
501 const_static_lifetime::CONST_STATIC_LIFETIME,
502 copies::IF_SAME_THEN_ELSE,
503 copies::IFS_SAME_COND,
504 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
505 derive::DERIVE_HASH_XOR_EQ,
506 double_comparison::DOUBLE_COMPARISONS,
507 double_parens::DOUBLE_PARENS,
508 drop_forget_ref::DROP_COPY,
509 drop_forget_ref::DROP_REF,
510 drop_forget_ref::FORGET_COPY,
511 drop_forget_ref::FORGET_REF,
513 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
514 enum_variants::ENUM_VARIANT_NAMES,
515 enum_variants::MODULE_INCEPTION,
518 erasing_op::ERASING_OP,
520 eta_reduction::REDUNDANT_CLOSURE,
521 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
522 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
523 excessive_precision::EXCESSIVE_PRECISION,
524 explicit_write::EXPLICIT_WRITE,
525 format::USELESS_FORMAT,
526 formatting::POSSIBLE_MISSING_COMMA,
527 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
528 formatting::SUSPICIOUS_ELSE_FORMATTING,
529 functions::NOT_UNSAFE_PTR_ARG_DEREF,
530 functions::TOO_MANY_ARGUMENTS,
531 identity_conversion::IDENTITY_CONVERSION,
532 identity_op::IDENTITY_OP,
533 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
534 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
535 infinite_iter::INFINITE_ITER,
536 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
537 int_plus_one::INT_PLUS_ONE,
538 invalid_ref::INVALID_REF,
539 large_enum_variant::LARGE_ENUM_VARIANT,
540 len_zero::LEN_WITHOUT_IS_EMPTY,
542 let_if_seq::USELESS_LET_IF_SEQ,
543 lifetimes::EXTRA_UNUSED_LIFETIMES,
544 lifetimes::NEEDLESS_LIFETIMES,
545 literal_representation::INCONSISTENT_DIGIT_GROUPING,
546 literal_representation::LARGE_DIGIT_GROUPS,
547 literal_representation::UNREADABLE_LITERAL,
549 loops::EXPLICIT_COUNTER_LOOP,
550 loops::EXPLICIT_INTO_ITER_LOOP,
551 loops::EXPLICIT_ITER_LOOP,
553 loops::FOR_LOOP_OVER_OPTION,
554 loops::FOR_LOOP_OVER_RESULT,
555 loops::ITER_NEXT_LOOP,
556 loops::MANUAL_MEMCPY,
557 loops::MUT_RANGE_BOUND,
558 loops::NEEDLESS_RANGE_LOOP,
560 loops::REVERSE_RANGE_LOOP,
561 loops::UNUSED_COLLECT,
562 loops::WHILE_IMMUTABLE_CONDITION,
563 loops::WHILE_LET_LOOP,
564 loops::WHILE_LET_ON_ITERATOR,
565 map_clone::MAP_CLONE,
566 map_unit_fn::OPTION_MAP_UNIT_FN,
567 map_unit_fn::RESULT_MAP_UNIT_FN,
568 matches::MATCH_AS_REF,
570 matches::MATCH_OVERLAPPING_ARM,
571 matches::MATCH_REF_PATS,
572 matches::MATCH_WILD_ERR_ARM,
573 matches::SINGLE_MATCH,
574 methods::CHARS_LAST_CMP,
575 methods::CHARS_NEXT_CMP,
576 methods::CLONE_DOUBLE_REF,
577 methods::CLONE_ON_COPY,
578 methods::FILTER_NEXT,
580 methods::ITER_CLONED_COLLECT,
582 methods::ITER_SKIP_NEXT,
583 methods::NEW_RET_NO_SELF,
585 methods::OPTION_MAP_OR_NONE,
586 methods::OR_FUN_CALL,
587 methods::SEARCH_IS_SOME,
588 methods::SHOULD_IMPLEMENT_TRAIT,
589 methods::SINGLE_CHAR_PATTERN,
590 methods::STRING_EXTEND_CHARS,
591 methods::TEMPORARY_CSTRING_AS_PTR,
592 methods::UNNECESSARY_FOLD,
593 methods::USELESS_ASREF,
594 methods::WRONG_SELF_CONVENTION,
600 misc::REDUNDANT_PATTERN,
601 misc::SHORT_CIRCUIT_STATEMENT,
602 misc::TOPLEVEL_REF_ARG,
604 misc_early::BUILTIN_TYPE_SHADOW,
605 misc_early::DOUBLE_NEG,
606 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
607 misc_early::MIXED_CASE_HEX_LITERALS,
608 misc_early::REDUNDANT_CLOSURE_CALL,
609 misc_early::UNNEEDED_FIELD_PATTERN,
610 misc_early::ZERO_PREFIXED_LITERAL,
611 mut_reference::UNNECESSARY_MUT_PASSED,
612 mutex_atomic::MUTEX_ATOMIC,
613 needless_bool::BOOL_COMPARISON,
614 needless_bool::NEEDLESS_BOOL,
615 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
616 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
617 needless_update::NEEDLESS_UPDATE,
618 neg_multiply::NEG_MULTIPLY,
619 new_without_default::NEW_WITHOUT_DEFAULT,
620 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
621 no_effect::NO_EFFECT,
622 no_effect::UNNECESSARY_OPERATION,
623 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
624 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
625 ok_if_let::IF_LET_SOME_RESULT,
626 open_options::NONSENSICAL_OPEN_OPTIONS,
627 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
628 panic_unimplemented::PANIC_PARAMS,
629 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
630 precedence::PRECEDENCE,
634 question_mark::QUESTION_MARK,
635 ranges::ITERATOR_STEP_BY_ZERO,
636 ranges::RANGE_MINUS_ONE,
637 ranges::RANGE_ZIP_WITH_LEN,
638 redundant_field_names::REDUNDANT_FIELD_NAMES,
639 reference::DEREF_ADDROF,
640 reference::REF_IN_DEREF,
641 regex::INVALID_REGEX,
643 regex::TRIVIAL_REGEX,
644 returns::LET_AND_RETURN,
645 returns::NEEDLESS_RETURN,
646 serde_api::SERDE_API_MISUSE,
647 strings::STRING_LIT_AS_BYTES,
648 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
649 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
650 swap::ALMOST_SWAPPED,
652 temporary_assignment::TEMPORARY_ASSIGNMENT,
653 transmute::CROSSPOINTER_TRANSMUTE,
654 transmute::TRANSMUTE_BYTES_TO_STR,
655 transmute::TRANSMUTE_INT_TO_BOOL,
656 transmute::TRANSMUTE_INT_TO_CHAR,
657 transmute::TRANSMUTE_INT_TO_FLOAT,
658 transmute::TRANSMUTE_PTR_TO_PTR,
659 transmute::TRANSMUTE_PTR_TO_REF,
660 transmute::USELESS_TRANSMUTE,
661 transmute::WRONG_TRANSMUTE,
662 types::ABSURD_EXTREME_COMPARISONS,
665 types::CAST_LOSSLESS,
666 types::CAST_PTR_ALIGNMENT,
667 types::CHAR_LIT_AS_U8,
668 types::IMPLICIT_HASHER,
669 types::LET_UNIT_VALUE,
670 types::OPTION_OPTION,
671 types::TYPE_COMPLEXITY,
674 types::UNNECESSARY_CAST,
675 unicode::ZERO_WIDTH_SPACE,
676 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
677 unused_io_amount::UNUSED_IO_AMOUNT,
678 unused_label::UNUSED_LABEL,
680 write::PRINT_LITERAL,
681 write::PRINT_WITH_NEWLINE,
682 write::PRINTLN_EMPTY_STRING,
683 write::WRITE_LITERAL,
684 write::WRITE_WITH_NEWLINE,
685 write::WRITELN_EMPTY_STRING,
686 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
689 reg.register_lint_group("clippy_style", vec![
690 assign_ops::ASSIGN_OP_PATTERN,
691 bit_mask::VERBOSE_BIT_MASK,
692 blacklisted_name::BLACKLISTED_NAME,
693 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
694 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
695 collapsible_if::COLLAPSIBLE_IF,
696 const_static_lifetime::CONST_STATIC_LIFETIME,
697 enum_variants::ENUM_VARIANT_NAMES,
698 enum_variants::MODULE_INCEPTION,
700 eta_reduction::REDUNDANT_CLOSURE,
701 excessive_precision::EXCESSIVE_PRECISION,
702 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
703 formatting::SUSPICIOUS_ELSE_FORMATTING,
704 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
705 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
706 len_zero::LEN_WITHOUT_IS_EMPTY,
708 let_if_seq::USELESS_LET_IF_SEQ,
709 literal_representation::INCONSISTENT_DIGIT_GROUPING,
710 literal_representation::LARGE_DIGIT_GROUPS,
711 literal_representation::UNREADABLE_LITERAL,
713 loops::EXPLICIT_INTO_ITER_LOOP,
714 loops::EXPLICIT_ITER_LOOP,
716 loops::NEEDLESS_RANGE_LOOP,
717 loops::WHILE_LET_ON_ITERATOR,
718 map_clone::MAP_CLONE,
720 matches::MATCH_OVERLAPPING_ARM,
721 matches::MATCH_REF_PATS,
722 matches::MATCH_WILD_ERR_ARM,
723 matches::SINGLE_MATCH,
724 methods::CHARS_LAST_CMP,
726 methods::ITER_CLONED_COLLECT,
727 methods::ITER_SKIP_NEXT,
728 methods::NEW_RET_NO_SELF,
730 methods::OPTION_MAP_OR_NONE,
731 methods::SHOULD_IMPLEMENT_TRAIT,
732 methods::STRING_EXTEND_CHARS,
733 methods::UNNECESSARY_FOLD,
734 methods::WRONG_SELF_CONVENTION,
735 misc::REDUNDANT_PATTERN,
736 misc::TOPLEVEL_REF_ARG,
738 misc_early::BUILTIN_TYPE_SHADOW,
739 misc_early::DOUBLE_NEG,
740 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
741 misc_early::MIXED_CASE_HEX_LITERALS,
742 misc_early::UNNEEDED_FIELD_PATTERN,
743 mut_reference::UNNECESSARY_MUT_PASSED,
744 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
745 neg_multiply::NEG_MULTIPLY,
746 new_without_default::NEW_WITHOUT_DEFAULT,
747 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
748 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
749 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
750 ok_if_let::IF_LET_SOME_RESULT,
751 panic_unimplemented::PANIC_PARAMS,
754 question_mark::QUESTION_MARK,
755 ranges::RANGE_MINUS_ONE,
756 redundant_field_names::REDUNDANT_FIELD_NAMES,
758 regex::TRIVIAL_REGEX,
759 returns::LET_AND_RETURN,
760 returns::NEEDLESS_RETURN,
761 strings::STRING_LIT_AS_BYTES,
762 types::IMPLICIT_HASHER,
763 types::LET_UNIT_VALUE,
764 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
765 write::PRINT_LITERAL,
766 write::PRINT_WITH_NEWLINE,
767 write::PRINTLN_EMPTY_STRING,
768 write::WRITE_LITERAL,
769 write::WRITE_WITH_NEWLINE,
770 write::WRITELN_EMPTY_STRING,
773 reg.register_lint_group("clippy_complexity", vec![
774 assign_ops::MISREFACTORED_ASSIGN_OP,
775 booleans::NONMINIMAL_BOOL,
776 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
777 double_comparison::DOUBLE_COMPARISONS,
778 double_parens::DOUBLE_PARENS,
779 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
780 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
781 explicit_write::EXPLICIT_WRITE,
782 format::USELESS_FORMAT,
783 functions::TOO_MANY_ARGUMENTS,
784 identity_conversion::IDENTITY_CONVERSION,
785 identity_op::IDENTITY_OP,
786 int_plus_one::INT_PLUS_ONE,
787 lifetimes::EXTRA_UNUSED_LIFETIMES,
788 lifetimes::NEEDLESS_LIFETIMES,
789 loops::EXPLICIT_COUNTER_LOOP,
790 loops::MUT_RANGE_BOUND,
791 loops::WHILE_LET_LOOP,
792 map_unit_fn::OPTION_MAP_UNIT_FN,
793 map_unit_fn::RESULT_MAP_UNIT_FN,
794 matches::MATCH_AS_REF,
795 methods::CHARS_NEXT_CMP,
796 methods::CLONE_ON_COPY,
797 methods::FILTER_NEXT,
798 methods::SEARCH_IS_SOME,
799 methods::USELESS_ASREF,
800 misc::SHORT_CIRCUIT_STATEMENT,
801 misc_early::REDUNDANT_CLOSURE_CALL,
802 misc_early::ZERO_PREFIXED_LITERAL,
803 needless_bool::BOOL_COMPARISON,
804 needless_bool::NEEDLESS_BOOL,
805 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
806 needless_update::NEEDLESS_UPDATE,
807 no_effect::NO_EFFECT,
808 no_effect::UNNECESSARY_OPERATION,
809 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
810 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
811 precedence::PRECEDENCE,
812 ranges::RANGE_ZIP_WITH_LEN,
813 reference::DEREF_ADDROF,
814 reference::REF_IN_DEREF,
816 temporary_assignment::TEMPORARY_ASSIGNMENT,
817 transmute::CROSSPOINTER_TRANSMUTE,
818 transmute::TRANSMUTE_BYTES_TO_STR,
819 transmute::TRANSMUTE_INT_TO_BOOL,
820 transmute::TRANSMUTE_INT_TO_CHAR,
821 transmute::TRANSMUTE_INT_TO_FLOAT,
822 transmute::TRANSMUTE_PTR_TO_PTR,
823 transmute::TRANSMUTE_PTR_TO_REF,
824 transmute::USELESS_TRANSMUTE,
826 types::CAST_LOSSLESS,
827 types::CHAR_LIT_AS_U8,
828 types::OPTION_OPTION,
829 types::TYPE_COMPLEXITY,
831 types::UNNECESSARY_CAST,
832 unused_label::UNUSED_LABEL,
833 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
836 reg.register_lint_group("clippy_correctness", vec![
837 approx_const::APPROX_CONSTANT,
838 array_indexing::OUT_OF_BOUNDS_INDEXING,
839 attrs::DEPRECATED_SEMVER,
840 attrs::USELESS_ATTRIBUTE,
841 bit_mask::BAD_BIT_MASK,
842 bit_mask::INEFFECTIVE_BIT_MASK,
844 copies::IF_SAME_THEN_ELSE,
845 copies::IFS_SAME_COND,
846 derive::DERIVE_HASH_XOR_EQ,
847 drop_forget_ref::DROP_COPY,
848 drop_forget_ref::DROP_REF,
849 drop_forget_ref::FORGET_COPY,
850 drop_forget_ref::FORGET_REF,
851 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
853 erasing_op::ERASING_OP,
854 formatting::POSSIBLE_MISSING_COMMA,
855 functions::NOT_UNSAFE_PTR_ARG_DEREF,
856 infinite_iter::INFINITE_ITER,
857 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
858 invalid_ref::INVALID_REF,
859 loops::FOR_LOOP_OVER_OPTION,
860 loops::FOR_LOOP_OVER_RESULT,
861 loops::ITER_NEXT_LOOP,
863 loops::REVERSE_RANGE_LOOP,
864 loops::WHILE_IMMUTABLE_CONDITION,
865 methods::CLONE_DOUBLE_REF,
866 methods::TEMPORARY_CSTRING_AS_PTR,
871 open_options::NONSENSICAL_OPEN_OPTIONS,
873 ranges::ITERATOR_STEP_BY_ZERO,
874 regex::INVALID_REGEX,
875 serde_api::SERDE_API_MISUSE,
876 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
877 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
878 swap::ALMOST_SWAPPED,
879 transmute::WRONG_TRANSMUTE,
880 types::ABSURD_EXTREME_COMPARISONS,
881 types::CAST_PTR_ALIGNMENT,
883 unicode::ZERO_WIDTH_SPACE,
884 unused_io_amount::UNUSED_IO_AMOUNT,
887 reg.register_lint_group("clippy_perf", vec![
888 bytecount::NAIVE_BYTECOUNT,
891 large_enum_variant::LARGE_ENUM_VARIANT,
892 loops::MANUAL_MEMCPY,
893 loops::UNUSED_COLLECT,
895 methods::OR_FUN_CALL,
896 methods::SINGLE_CHAR_PATTERN,
898 mutex_atomic::MUTEX_ATOMIC,
903 reg.register_lint_group("clippy_cargo", vec![
904 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
907 reg.register_lint_group("clippy_nursery", vec![
908 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
909 fallible_impl_from::FALLIBLE_IMPL_FROM,
910 mutex_atomic::MUTEX_INTEGER,
911 needless_borrow::NEEDLESS_BORROW,
912 ranges::RANGE_PLUS_ONE,
916 // only exists to let the dogfood integration test works.
917 // Don't run clippy as an executable directly
918 #[allow(dead_code, print_stdout)]
920 panic!("Please use the cargo-clippy executable");