]> git.lizzy.rs Git - rust.git/blob - clippy_lints/src/lib.rs
Auto merge of #9539 - Jarcho:ice_9445, r=flip1995
[rust.git] / clippy_lints / src / lib.rs
1 #![feature(array_windows)]
2 #![feature(binary_heap_into_iter_sorted)]
3 #![feature(box_patterns)]
4 #![feature(control_flow_enum)]
5 #![feature(drain_filter)]
6 #![feature(iter_intersperse)]
7 #![feature(let_chains)]
8 #![feature(let_else)]
9 #![feature(lint_reasons)]
10 #![feature(never_type)]
11 #![feature(once_cell)]
12 #![feature(rustc_private)]
13 #![feature(stmt_expr_attributes)]
14 #![recursion_limit = "512"]
15 #![cfg_attr(feature = "deny-warnings", deny(warnings))]
16 #![allow(clippy::missing_docs_in_private_items, clippy::must_use_candidate)]
17 #![warn(trivial_casts, trivial_numeric_casts)]
18 // warn on lints, that are included in `rust-lang/rust`s bootstrap
19 #![warn(rust_2018_idioms, unused_lifetimes)]
20 // warn on rustc internal lints
21 #![warn(rustc::internal)]
22 // Disable this rustc lint for now, as it was also done in rustc
23 #![allow(rustc::potential_query_instability)]
24
25 // FIXME: switch to something more ergonomic here, once available.
26 // (Currently there is no way to opt into sysroot crates without `extern crate`.)
27 extern crate rustc_arena;
28 extern crate rustc_ast;
29 extern crate rustc_ast_pretty;
30 extern crate rustc_attr;
31 extern crate rustc_data_structures;
32 extern crate rustc_driver;
33 extern crate rustc_errors;
34 extern crate rustc_hir;
35 extern crate rustc_hir_pretty;
36 extern crate rustc_index;
37 extern crate rustc_infer;
38 extern crate rustc_lexer;
39 extern crate rustc_lint;
40 extern crate rustc_middle;
41 extern crate rustc_mir_dataflow;
42 extern crate rustc_parse;
43 extern crate rustc_session;
44 extern crate rustc_span;
45 extern crate rustc_target;
46 extern crate rustc_trait_selection;
47 extern crate rustc_typeck;
48
49 #[macro_use]
50 extern crate clippy_utils;
51
52 use clippy_utils::parse_msrv;
53 use rustc_data_structures::fx::FxHashSet;
54 use rustc_lint::LintId;
55 use rustc_semver::RustcVersion;
56 use rustc_session::Session;
57
58 /// Macro used to declare a Clippy lint.
59 ///
60 /// Every lint declaration consists of 4 parts:
61 ///
62 /// 1. The documentation, which is used for the website
63 /// 2. The `LINT_NAME`. See [lint naming][lint_naming] on lint naming conventions.
64 /// 3. The `lint_level`, which is a mapping from *one* of our lint groups to `Allow`, `Warn` or
65 ///    `Deny`. The lint level here has nothing to do with what lint groups the lint is a part of.
66 /// 4. The `description` that contains a short explanation on what's wrong with code where the
67 ///    lint is triggered.
68 ///
69 /// Currently the categories `style`, `correctness`, `suspicious`, `complexity` and `perf` are
70 /// enabled by default. As said in the README.md of this repository, if the lint level mapping
71 /// changes, please update README.md.
72 ///
73 /// # Example
74 ///
75 /// ```
76 /// #![feature(rustc_private)]
77 /// extern crate rustc_session;
78 /// use rustc_session::declare_tool_lint;
79 /// use clippy_lints::declare_clippy_lint;
80 ///
81 /// declare_clippy_lint! {
82 ///     /// ### What it does
83 ///     /// Checks for ... (describe what the lint matches).
84 ///     ///
85 ///     /// ### Why is this bad?
86 ///     /// Supply the reason for linting the code.
87 ///     ///
88 ///     /// ### Example
89 ///     /// ```rust
90 ///     /// Insert a short example of code that triggers the lint
91 ///     /// ```
92 ///     ///
93 ///     /// Use instead:
94 ///     /// ```rust
95 ///     /// Insert a short example of improved code that doesn't trigger the lint
96 ///     /// ```
97 ///     pub LINT_NAME,
98 ///     pedantic,
99 ///     "description"
100 /// }
101 /// ```
102 /// [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
103 #[macro_export]
104 macro_rules! declare_clippy_lint {
105     { $(#[$attr:meta])* pub $name:tt, style, $description:tt } => {
106         declare_tool_lint! {
107             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
108         }
109     };
110     { $(#[$attr:meta])* pub $name:tt, correctness, $description:tt } => {
111         declare_tool_lint! {
112             $(#[$attr])* pub clippy::$name, Deny, $description, report_in_external_macro: true
113         }
114     };
115     { $(#[$attr:meta])* pub $name:tt, suspicious, $description:tt } => {
116         declare_tool_lint! {
117             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
118         }
119     };
120     { $(#[$attr:meta])* pub $name:tt, complexity, $description:tt } => {
121         declare_tool_lint! {
122             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
123         }
124     };
125     { $(#[$attr:meta])* pub $name:tt, perf, $description:tt } => {
126         declare_tool_lint! {
127             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
128         }
129     };
130     { $(#[$attr:meta])* pub $name:tt, pedantic, $description:tt } => {
131         declare_tool_lint! {
132             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
133         }
134     };
135     { $(#[$attr:meta])* pub $name:tt, restriction, $description:tt } => {
136         declare_tool_lint! {
137             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
138         }
139     };
140     { $(#[$attr:meta])* pub $name:tt, cargo, $description:tt } => {
141         declare_tool_lint! {
142             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
143         }
144     };
145     { $(#[$attr:meta])* pub $name:tt, nursery, $description:tt } => {
146         declare_tool_lint! {
147             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
148         }
149     };
150     { $(#[$attr:meta])* pub $name:tt, internal, $description:tt } => {
151         declare_tool_lint! {
152             $(#[$attr])* pub clippy::$name, Allow, $description, report_in_external_macro: true
153         }
154     };
155     { $(#[$attr:meta])* pub $name:tt, internal_warn, $description:tt } => {
156         declare_tool_lint! {
157             $(#[$attr])* pub clippy::$name, Warn, $description, report_in_external_macro: true
158         }
159     };
160 }
161
162 #[cfg(feature = "internal")]
163 pub mod deprecated_lints;
164 #[cfg_attr(feature = "internal", allow(clippy::missing_clippy_version_attribute))]
165 mod utils;
166
167 mod renamed_lints;
168
169 // begin lints modules, do not remove this comment, it’s used in `update_lints`
170 mod almost_complete_letter_range;
171 mod approx_const;
172 mod as_conversions;
173 mod asm_syntax;
174 mod assertions_on_constants;
175 mod assertions_on_result_states;
176 mod async_yields_async;
177 mod attrs;
178 mod await_holding_invalid;
179 mod blocks_in_if_conditions;
180 mod bool_assert_comparison;
181 mod bool_to_int_with_if;
182 mod booleans;
183 mod borrow_deref_ref;
184 mod cargo;
185 mod casts;
186 mod checked_conversions;
187 mod cognitive_complexity;
188 mod collapsible_if;
189 mod comparison_chain;
190 mod copies;
191 mod copy_iterator;
192 mod crate_in_macro_def;
193 mod create_dir;
194 mod dbg_macro;
195 mod default;
196 mod default_instead_of_iter_empty;
197 mod default_numeric_fallback;
198 mod default_union_representation;
199 mod dereference;
200 mod derivable_impls;
201 mod derive;
202 mod disallowed_methods;
203 mod disallowed_names;
204 mod disallowed_script_idents;
205 mod disallowed_types;
206 mod doc;
207 mod doc_link_with_quotes;
208 mod double_parens;
209 mod drop_forget_ref;
210 mod duplicate_mod;
211 mod else_if_without_else;
212 mod empty_drop;
213 mod empty_enum;
214 mod empty_structs_with_brackets;
215 mod entry;
216 mod enum_clike;
217 mod enum_variants;
218 mod equatable_if_let;
219 mod escape;
220 mod eta_reduction;
221 mod excessive_bools;
222 mod exhaustive_items;
223 mod exit;
224 mod explicit_write;
225 mod fallible_impl_from;
226 mod float_literal;
227 mod floating_point_arithmetic;
228 mod format;
229 mod format_args;
230 mod format_impl;
231 mod format_push_string;
232 mod formatting;
233 mod from_over_into;
234 mod from_str_radix_10;
235 mod functions;
236 mod future_not_send;
237 mod if_let_mutex;
238 mod if_not_else;
239 mod if_then_some_else_none;
240 mod implicit_hasher;
241 mod implicit_return;
242 mod implicit_saturating_sub;
243 mod inconsistent_struct_constructor;
244 mod index_refutable_slice;
245 mod indexing_slicing;
246 mod infinite_iter;
247 mod inherent_impl;
248 mod inherent_to_string;
249 mod init_numbered_fields;
250 mod inline_fn_without_body;
251 mod int_plus_one;
252 mod invalid_upcast_comparisons;
253 mod invalid_utf8_in_unchecked;
254 mod items_after_statements;
255 mod iter_not_returning_iterator;
256 mod large_const_arrays;
257 mod large_enum_variant;
258 mod large_include_file;
259 mod large_stack_arrays;
260 mod len_zero;
261 mod let_if_seq;
262 mod let_underscore;
263 mod lifetimes;
264 mod literal_representation;
265 mod loops;
266 mod macro_use;
267 mod main_recursion;
268 mod manual_assert;
269 mod manual_async_fn;
270 mod manual_bits;
271 mod manual_instant_elapsed;
272 mod manual_non_exhaustive;
273 mod manual_rem_euclid;
274 mod manual_retain;
275 mod manual_string_new;
276 mod manual_strip;
277 mod map_unit_fn;
278 mod match_result_ok;
279 mod matches;
280 mod mem_forget;
281 mod mem_replace;
282 mod methods;
283 mod minmax;
284 mod misc;
285 mod misc_early;
286 mod mismatching_type_param_order;
287 mod missing_const_for_fn;
288 mod missing_doc;
289 mod missing_enforced_import_rename;
290 mod missing_inline;
291 mod mixed_read_write_in_expression;
292 mod module_style;
293 mod multi_assignments;
294 mod mut_key;
295 mod mut_mut;
296 mod mut_reference;
297 mod mutable_debug_assertion;
298 mod mutex_atomic;
299 mod needless_arbitrary_self_type;
300 mod needless_bool;
301 mod needless_borrowed_ref;
302 mod needless_continue;
303 mod needless_for_each;
304 mod needless_late_init;
305 mod needless_parens_on_range_literals;
306 mod needless_pass_by_value;
307 mod needless_question_mark;
308 mod needless_update;
309 mod neg_cmp_op_on_partial_ord;
310 mod neg_multiply;
311 mod new_without_default;
312 mod no_effect;
313 mod non_copy_const;
314 mod non_expressive_names;
315 mod non_octal_unix_permissions;
316 mod non_send_fields_in_send_ty;
317 mod nonstandard_macro_braces;
318 mod octal_escapes;
319 mod only_used_in_recursion;
320 mod operators;
321 mod option_env_unwrap;
322 mod option_if_let_else;
323 mod overflow_check_conditional;
324 mod panic_in_result_fn;
325 mod panic_unimplemented;
326 mod partialeq_ne_impl;
327 mod partialeq_to_none;
328 mod pass_by_ref_or_value;
329 mod pattern_type_mismatch;
330 mod precedence;
331 mod ptr;
332 mod ptr_offset_with_cast;
333 mod pub_use;
334 mod question_mark;
335 mod ranges;
336 mod rc_clone_in_vec_init;
337 mod read_zero_byte_vec;
338 mod redundant_clone;
339 mod redundant_closure_call;
340 mod redundant_else;
341 mod redundant_field_names;
342 mod redundant_pub_crate;
343 mod redundant_slicing;
344 mod redundant_static_lifetimes;
345 mod ref_option_ref;
346 mod reference;
347 mod regex;
348 mod return_self_not_must_use;
349 mod returns;
350 mod same_name_method;
351 mod self_named_constructors;
352 mod semicolon_if_nothing_returned;
353 mod serde_api;
354 mod shadow;
355 mod single_char_lifetime_names;
356 mod single_component_path_imports;
357 mod size_of_in_element_count;
358 mod slow_vector_initialization;
359 mod std_instead_of_core;
360 mod strings;
361 mod strlen_on_c_strings;
362 mod suspicious_operation_groupings;
363 mod suspicious_trait_impl;
364 mod swap;
365 mod swap_ptr_to_ref;
366 mod tabs_in_doc_comments;
367 mod temporary_assignment;
368 mod to_digit_is_some;
369 mod trailing_empty_array;
370 mod trait_bounds;
371 mod transmute;
372 mod types;
373 mod undocumented_unsafe_blocks;
374 mod unicode;
375 mod uninit_vec;
376 mod unit_return_expecting_ord;
377 mod unit_types;
378 mod unnamed_address;
379 mod unnecessary_owned_empty_strings;
380 mod unnecessary_self_imports;
381 mod unnecessary_wraps;
382 mod unnested_or_patterns;
383 mod unsafe_removed_from_name;
384 mod unused_async;
385 mod unused_io_amount;
386 mod unused_peekable;
387 mod unused_rounding;
388 mod unused_self;
389 mod unused_unit;
390 mod unwrap;
391 mod unwrap_in_result;
392 mod upper_case_acronyms;
393 mod use_self;
394 mod useless_conversion;
395 mod vec;
396 mod vec_init_then_push;
397 mod wildcard_imports;
398 mod write;
399 mod zero_div_zero;
400 mod zero_sized_map_values;
401 // end lints modules, do not remove this comment, it’s used in `update_lints`
402
403 pub use crate::utils::conf::Conf;
404 use crate::utils::conf::{format_error, TryConf};
405
406 /// Register all pre expansion lints
407 ///
408 /// Pre-expansion lints run before any macro expansion has happened.
409 ///
410 /// Note that due to the architecture of the compiler, currently `cfg_attr` attributes on crate
411 /// level (i.e `#![cfg_attr(...)]`) will still be expanded even when using a pre-expansion pass.
412 ///
413 /// Used in `./src/driver.rs`.
414 pub fn register_pre_expansion_lints(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
415     // NOTE: Do not add any more pre-expansion passes. These should be removed eventually.
416
417     let msrv = conf.msrv.as_ref().and_then(|s| {
418         parse_msrv(s, None, None).or_else(|| {
419             sess.err(&format!(
420                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
421             ));
422             None
423         })
424     });
425
426     store.register_pre_expansion_pass(move || Box::new(attrs::EarlyAttributes { msrv }));
427 }
428
429 fn read_msrv(conf: &Conf, sess: &Session) -> Option<RustcVersion> {
430     let cargo_msrv = std::env::var("CARGO_PKG_RUST_VERSION")
431         .ok()
432         .and_then(|v| parse_msrv(&v, None, None));
433     let clippy_msrv = conf.msrv.as_ref().and_then(|s| {
434         parse_msrv(s, None, None).or_else(|| {
435             sess.err(&format!(
436                 "error reading Clippy's configuration file. `{s}` is not a valid Rust version"
437             ));
438             None
439         })
440     });
441
442     if let Some(cargo_msrv) = cargo_msrv {
443         if let Some(clippy_msrv) = clippy_msrv {
444             // if both files have an msrv, let's compare them and emit a warning if they differ
445             if clippy_msrv != cargo_msrv {
446                 sess.warn(&format!(
447                     "the MSRV in `clippy.toml` and `Cargo.toml` differ; using `{clippy_msrv}` from `clippy.toml`"
448                 ));
449             }
450
451             Some(clippy_msrv)
452         } else {
453             Some(cargo_msrv)
454         }
455     } else {
456         clippy_msrv
457     }
458 }
459
460 #[doc(hidden)]
461 pub fn read_conf(sess: &Session) -> Conf {
462     let file_name = match utils::conf::lookup_conf_file() {
463         Ok(Some(path)) => path,
464         Ok(None) => return Conf::default(),
465         Err(error) => {
466             sess.struct_err(&format!("error finding Clippy's configuration file: {error}"))
467                 .emit();
468             return Conf::default();
469         },
470     };
471
472     let TryConf { conf, errors, warnings } = utils::conf::read(&file_name);
473     // all conf errors are non-fatal, we just use the default conf in case of error
474     for error in errors {
475         sess.err(&format!(
476             "error reading Clippy's configuration file `{}`: {}",
477             file_name.display(),
478             format_error(error)
479         ));
480     }
481
482     for warning in warnings {
483         sess.struct_warn(&format!(
484             "error reading Clippy's configuration file `{}`: {}",
485             file_name.display(),
486             format_error(warning)
487         ))
488         .emit();
489     }
490
491     conf
492 }
493
494 /// Register all lints and lint groups with the rustc plugin registry
495 ///
496 /// Used in `./src/driver.rs`.
497 #[expect(clippy::too_many_lines)]
498 pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf: &Conf) {
499     register_removed_non_tool_lints(store);
500
501     include!("lib.deprecated.rs");
502
503     include!("lib.register_lints.rs");
504     include!("lib.register_restriction.rs");
505     include!("lib.register_pedantic.rs");
506
507     #[cfg(feature = "internal")]
508     include!("lib.register_internal.rs");
509
510     include!("lib.register_all.rs");
511     include!("lib.register_style.rs");
512     include!("lib.register_complexity.rs");
513     include!("lib.register_correctness.rs");
514     include!("lib.register_suspicious.rs");
515     include!("lib.register_perf.rs");
516     include!("lib.register_cargo.rs");
517     include!("lib.register_nursery.rs");
518
519     #[cfg(feature = "internal")]
520     {
521         if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) {
522             store.register_late_pass(|| Box::new(utils::internal_lints::metadata_collector::MetadataCollector::new()));
523             return;
524         }
525     }
526
527     // all the internal lints
528     #[cfg(feature = "internal")]
529     {
530         store.register_early_pass(|| Box::new(utils::internal_lints::ClippyLintsInternal));
531         store.register_early_pass(|| Box::new(utils::internal_lints::ProduceIce));
532         store.register_late_pass(|| Box::new(utils::internal_lints::CollapsibleCalls));
533         store.register_late_pass(|| Box::new(utils::internal_lints::CompilerLintFunctions::new()));
534         store.register_late_pass(|| Box::new(utils::internal_lints::IfChainStyle));
535         store.register_late_pass(|| Box::new(utils::internal_lints::InvalidPaths));
536         store.register_late_pass(|| Box::new(utils::internal_lints::InterningDefinedSymbol::default()));
537         store.register_late_pass(|| Box::new(utils::internal_lints::LintWithoutLintPass::default()));
538         store.register_late_pass(|| Box::new(utils::internal_lints::MatchTypeOnDiagItem));
539         store.register_late_pass(|| Box::new(utils::internal_lints::OuterExpnDataPass));
540         store.register_late_pass(|| Box::new(utils::internal_lints::MsrvAttrImpl));
541     }
542
543     let arithmetic_side_effects_allowed = conf.arithmetic_side_effects_allowed.clone();
544     store.register_late_pass(move || {
545         Box::new(operators::arithmetic_side_effects::ArithmeticSideEffects::new(
546             arithmetic_side_effects_allowed.clone(),
547         ))
548     });
549     store.register_late_pass(|| Box::new(utils::dump_hir::DumpHir));
550     store.register_late_pass(|| Box::new(utils::author::Author));
551     let await_holding_invalid_types = conf.await_holding_invalid_types.clone();
552     store.register_late_pass(move || {
553         Box::new(await_holding_invalid::AwaitHolding::new(
554             await_holding_invalid_types.clone(),
555         ))
556     });
557     store.register_late_pass(|| Box::new(serde_api::SerdeApi));
558     let vec_box_size_threshold = conf.vec_box_size_threshold;
559     let type_complexity_threshold = conf.type_complexity_threshold;
560     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
561     store.register_late_pass(move || {
562         Box::new(types::Types::new(
563             vec_box_size_threshold,
564             type_complexity_threshold,
565             avoid_breaking_exported_api,
566         ))
567     });
568     store.register_late_pass(|| Box::new(booleans::NonminimalBool));
569     store.register_late_pass(|| Box::new(enum_clike::UnportableVariant));
570     store.register_late_pass(|| Box::new(float_literal::FloatLiteral));
571     store.register_late_pass(|| Box::new(ptr::Ptr));
572     store.register_late_pass(|| Box::new(needless_bool::NeedlessBool));
573     store.register_late_pass(|| Box::new(needless_bool::BoolComparison));
574     store.register_late_pass(|| Box::new(needless_for_each::NeedlessForEach));
575     store.register_late_pass(|| Box::new(misc::MiscLints));
576     store.register_late_pass(|| Box::new(eta_reduction::EtaReduction));
577     store.register_late_pass(|| Box::new(mut_mut::MutMut));
578     store.register_late_pass(|| Box::new(mut_reference::UnnecessaryMutPassed));
579     store.register_late_pass(|| Box::new(len_zero::LenZero));
580     store.register_late_pass(|| Box::new(attrs::Attributes));
581     store.register_late_pass(|| Box::new(blocks_in_if_conditions::BlocksInIfConditions));
582     store.register_late_pass(|| Box::new(unicode::Unicode));
583     store.register_late_pass(|| Box::new(uninit_vec::UninitVec));
584     store.register_late_pass(|| Box::new(unit_return_expecting_ord::UnitReturnExpectingOrd));
585     store.register_late_pass(|| Box::new(strings::StringAdd));
586     store.register_late_pass(|| Box::new(implicit_return::ImplicitReturn));
587     store.register_late_pass(|| Box::new(implicit_saturating_sub::ImplicitSaturatingSub));
588     store.register_late_pass(|| Box::new(default_numeric_fallback::DefaultNumericFallback));
589     store.register_late_pass(|| Box::new(inconsistent_struct_constructor::InconsistentStructConstructor));
590     store.register_late_pass(|| Box::new(non_octal_unix_permissions::NonOctalUnixPermissions));
591     store.register_early_pass(|| Box::new(unnecessary_self_imports::UnnecessarySelfImports));
592
593     let msrv = read_msrv(conf, sess);
594     let avoid_breaking_exported_api = conf.avoid_breaking_exported_api;
595     let allow_expect_in_tests = conf.allow_expect_in_tests;
596     let allow_unwrap_in_tests = conf.allow_unwrap_in_tests;
597     store.register_late_pass(move || Box::new(approx_const::ApproxConstant::new(msrv)));
598     store.register_late_pass(move || {
599         Box::new(methods::Methods::new(
600             avoid_breaking_exported_api,
601             msrv,
602             allow_expect_in_tests,
603             allow_unwrap_in_tests,
604         ))
605     });
606     store.register_late_pass(move || Box::new(matches::Matches::new(msrv)));
607     store.register_early_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveStruct::new(msrv)));
608     store.register_late_pass(move || Box::new(manual_non_exhaustive::ManualNonExhaustiveEnum::new(msrv)));
609     store.register_late_pass(move || Box::new(manual_strip::ManualStrip::new(msrv)));
610     store.register_early_pass(move || Box::new(redundant_static_lifetimes::RedundantStaticLifetimes::new(msrv)));
611     store.register_early_pass(move || Box::new(redundant_field_names::RedundantFieldNames::new(msrv)));
612     store.register_late_pass(move || Box::new(checked_conversions::CheckedConversions::new(msrv)));
613     store.register_late_pass(move || Box::new(mem_replace::MemReplace::new(msrv)));
614     store.register_late_pass(move || Box::new(ranges::Ranges::new(msrv)));
615     store.register_late_pass(move || Box::new(from_over_into::FromOverInto::new(msrv)));
616     store.register_late_pass(move || Box::new(use_self::UseSelf::new(msrv)));
617     store.register_late_pass(move || Box::new(missing_const_for_fn::MissingConstForFn::new(msrv)));
618     store.register_late_pass(move || Box::new(needless_question_mark::NeedlessQuestionMark));
619     store.register_late_pass(move || Box::new(casts::Casts::new(msrv)));
620     store.register_early_pass(move || Box::new(unnested_or_patterns::UnnestedOrPatterns::new(msrv)));
621     store.register_late_pass(|| Box::new(size_of_in_element_count::SizeOfInElementCount));
622     store.register_late_pass(|| Box::new(same_name_method::SameNameMethod));
623     let max_suggested_slice_pattern_length = conf.max_suggested_slice_pattern_length;
624     store.register_late_pass(move || {
625         Box::new(index_refutable_slice::IndexRefutableSlice::new(
626             max_suggested_slice_pattern_length,
627             msrv,
628         ))
629     });
630     store.register_late_pass(|| Box::new(shadow::Shadow::default()));
631     store.register_late_pass(|| Box::new(unit_types::UnitTypes));
632     store.register_late_pass(|| Box::new(loops::Loops));
633     store.register_late_pass(|| Box::new(main_recursion::MainRecursion::default()));
634     store.register_late_pass(|| Box::new(lifetimes::Lifetimes));
635     store.register_late_pass(|| Box::new(entry::HashMapPass));
636     store.register_late_pass(|| Box::new(minmax::MinMaxPass));
637     store.register_late_pass(|| Box::new(zero_div_zero::ZeroDiv));
638     store.register_late_pass(|| Box::new(mutex_atomic::Mutex));
639     store.register_late_pass(|| Box::new(needless_update::NeedlessUpdate));
640     store.register_late_pass(|| Box::new(needless_borrowed_ref::NeedlessBorrowedRef));
641     store.register_late_pass(|| Box::new(borrow_deref_ref::BorrowDerefRef));
642     store.register_late_pass(|| Box::new(no_effect::NoEffect));
643     store.register_late_pass(|| Box::new(temporary_assignment::TemporaryAssignment));
644     store.register_late_pass(move || Box::new(transmute::Transmute::new(msrv)));
645     let cognitive_complexity_threshold = conf.cognitive_complexity_threshold;
646     store.register_late_pass(move || {
647         Box::new(cognitive_complexity::CognitiveComplexity::new(
648             cognitive_complexity_threshold,
649         ))
650     });
651     let too_large_for_stack = conf.too_large_for_stack;
652     store.register_late_pass(move || Box::new(escape::BoxedLocal { too_large_for_stack }));
653     store.register_late_pass(move || Box::new(vec::UselessVec { too_large_for_stack }));
654     store.register_late_pass(|| Box::new(panic_unimplemented::PanicUnimplemented));
655     store.register_late_pass(|| Box::new(strings::StringLitAsBytes));
656     store.register_late_pass(|| Box::new(derive::Derive));
657     store.register_late_pass(|| Box::new(derivable_impls::DerivableImpls));
658     store.register_late_pass(|| Box::new(drop_forget_ref::DropForgetRef));
659     store.register_late_pass(|| Box::new(empty_enum::EmptyEnum));
660     store.register_late_pass(|| Box::new(invalid_upcast_comparisons::InvalidUpcastComparisons));
661     store.register_late_pass(|| Box::new(regex::Regex));
662     store.register_late_pass(|| Box::new(copies::CopyAndPaste));
663     store.register_late_pass(|| Box::new(copy_iterator::CopyIterator));
664     store.register_late_pass(|| Box::new(format::UselessFormat));
665     store.register_late_pass(|| Box::new(swap::Swap));
666     store.register_late_pass(|| Box::new(overflow_check_conditional::OverflowCheckConditional));
667     store.register_late_pass(|| Box::new(new_without_default::NewWithoutDefault::default()));
668     let disallowed_names = conf.disallowed_names.iter().cloned().collect::<FxHashSet<_>>();
669     store.register_late_pass(move || Box::new(disallowed_names::DisallowedNames::new(disallowed_names.clone())));
670     let too_many_arguments_threshold = conf.too_many_arguments_threshold;
671     let too_many_lines_threshold = conf.too_many_lines_threshold;
672     let large_error_threshold = conf.large_error_threshold;
673     store.register_late_pass(move || {
674         Box::new(functions::Functions::new(
675             too_many_arguments_threshold,
676             too_many_lines_threshold,
677             large_error_threshold,
678         ))
679     });
680     let doc_valid_idents = conf.doc_valid_idents.iter().cloned().collect::<FxHashSet<_>>();
681     store.register_late_pass(move || Box::new(doc::DocMarkdown::new(doc_valid_idents.clone())));
682     store.register_late_pass(|| Box::new(neg_multiply::NegMultiply));
683     store.register_late_pass(|| Box::new(mem_forget::MemForget));
684     store.register_late_pass(|| Box::new(let_if_seq::LetIfSeq));
685     store.register_late_pass(|| Box::new(mixed_read_write_in_expression::EvalOrderDependence));
686     store.register_late_pass(|| Box::new(missing_doc::MissingDoc::new()));
687     store.register_late_pass(|| Box::new(missing_inline::MissingInline));
688     store.register_late_pass(move || Box::new(exhaustive_items::ExhaustiveItems));
689     store.register_late_pass(|| Box::new(match_result_ok::MatchResultOk));
690     store.register_late_pass(|| Box::new(partialeq_ne_impl::PartialEqNeImpl));
691     store.register_late_pass(|| Box::new(unused_io_amount::UnusedIoAmount));
692     let enum_variant_size_threshold = conf.enum_variant_size_threshold;
693     store.register_late_pass(move || Box::new(large_enum_variant::LargeEnumVariant::new(enum_variant_size_threshold)));
694     store.register_late_pass(|| Box::new(explicit_write::ExplicitWrite));
695     store.register_late_pass(|| Box::new(needless_pass_by_value::NeedlessPassByValue));
696     let pass_by_ref_or_value = pass_by_ref_or_value::PassByRefOrValue::new(
697         conf.trivial_copy_size_limit,
698         conf.pass_by_value_size_limit,
699         conf.avoid_breaking_exported_api,
700         &sess.target,
701     );
702     store.register_late_pass(move || Box::new(pass_by_ref_or_value));
703     store.register_late_pass(|| Box::new(ref_option_ref::RefOptionRef));
704     store.register_late_pass(|| Box::new(infinite_iter::InfiniteIter));
705     store.register_late_pass(|| Box::new(inline_fn_without_body::InlineFnWithoutBody));
706     store.register_late_pass(|| Box::new(useless_conversion::UselessConversion::default()));
707     store.register_late_pass(|| Box::new(implicit_hasher::ImplicitHasher));
708     store.register_late_pass(|| Box::new(fallible_impl_from::FallibleImplFrom));
709     store.register_late_pass(|| Box::new(question_mark::QuestionMark));
710     store.register_early_pass(|| Box::new(suspicious_operation_groupings::SuspiciousOperationGroupings));
711     store.register_late_pass(|| Box::new(suspicious_trait_impl::SuspiciousImpl));
712     store.register_late_pass(|| Box::new(map_unit_fn::MapUnit));
713     store.register_late_pass(|| Box::new(inherent_impl::MultipleInherentImpl));
714     store.register_late_pass(|| Box::new(neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd));
715     store.register_late_pass(|| Box::new(unwrap::Unwrap));
716     store.register_late_pass(|| Box::new(indexing_slicing::IndexingSlicing));
717     store.register_late_pass(|| Box::new(non_copy_const::NonCopyConst));
718     store.register_late_pass(|| Box::new(ptr_offset_with_cast::PtrOffsetWithCast));
719     store.register_late_pass(|| Box::new(redundant_clone::RedundantClone));
720     store.register_late_pass(|| Box::new(slow_vector_initialization::SlowVectorInit));
721     store.register_late_pass(move || Box::new(unnecessary_wraps::UnnecessaryWraps::new(avoid_breaking_exported_api)));
722     store.register_late_pass(|| Box::new(assertions_on_constants::AssertionsOnConstants));
723     store.register_late_pass(|| Box::new(assertions_on_result_states::AssertionsOnResultStates));
724     store.register_late_pass(|| Box::new(inherent_to_string::InherentToString));
725     let max_trait_bounds = conf.max_trait_bounds;
726     store.register_late_pass(move || Box::new(trait_bounds::TraitBounds::new(max_trait_bounds)));
727     store.register_late_pass(|| Box::new(comparison_chain::ComparisonChain));
728     store.register_late_pass(|| Box::new(mut_key::MutableKeyType));
729     store.register_early_pass(|| Box::new(reference::DerefAddrOf));
730     store.register_early_pass(|| Box::new(double_parens::DoubleParens));
731     store.register_late_pass(|| Box::new(format_impl::FormatImpl::new()));
732     store.register_early_pass(|| Box::new(unsafe_removed_from_name::UnsafeNameRemoval));
733     store.register_early_pass(|| Box::new(else_if_without_else::ElseIfWithoutElse));
734     store.register_early_pass(|| Box::new(int_plus_one::IntPlusOne));
735     store.register_early_pass(|| Box::new(formatting::Formatting));
736     store.register_early_pass(|| Box::new(misc_early::MiscEarlyLints));
737     store.register_early_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
738     store.register_late_pass(|| Box::new(redundant_closure_call::RedundantClosureCall));
739     store.register_early_pass(|| Box::new(unused_unit::UnusedUnit));
740     store.register_late_pass(|| Box::new(returns::Return));
741     store.register_early_pass(|| Box::new(collapsible_if::CollapsibleIf));
742     store.register_early_pass(|| Box::new(items_after_statements::ItemsAfterStatements));
743     store.register_early_pass(|| Box::new(precedence::Precedence));
744     store.register_late_pass(|| Box::new(needless_parens_on_range_literals::NeedlessParensOnRangeLiterals));
745     store.register_early_pass(|| Box::new(needless_continue::NeedlessContinue));
746     store.register_early_pass(|| Box::new(redundant_else::RedundantElse));
747     store.register_late_pass(|| Box::new(create_dir::CreateDir));
748     store.register_early_pass(|| Box::new(needless_arbitrary_self_type::NeedlessArbitrarySelfType));
749     let literal_representation_lint_fraction_readability = conf.unreadable_literal_lint_fractions;
750     store.register_early_pass(move || {
751         Box::new(literal_representation::LiteralDigitGrouping::new(
752             literal_representation_lint_fraction_readability,
753         ))
754     });
755     let literal_representation_threshold = conf.literal_representation_threshold;
756     store.register_early_pass(move || {
757         Box::new(literal_representation::DecimalLiteralRepresentation::new(
758             literal_representation_threshold,
759         ))
760     });
761     let enum_variant_name_threshold = conf.enum_variant_name_threshold;
762     store.register_late_pass(move || {
763         Box::new(enum_variants::EnumVariantNames::new(
764             enum_variant_name_threshold,
765             avoid_breaking_exported_api,
766         ))
767     });
768     store.register_early_pass(|| Box::new(tabs_in_doc_comments::TabsInDocComments));
769     let upper_case_acronyms_aggressive = conf.upper_case_acronyms_aggressive;
770     store.register_late_pass(move || {
771         Box::new(upper_case_acronyms::UpperCaseAcronyms::new(
772             avoid_breaking_exported_api,
773             upper_case_acronyms_aggressive,
774         ))
775     });
776     store.register_late_pass(|| Box::new(default::Default::default()));
777     store.register_late_pass(move || Box::new(unused_self::UnusedSelf::new(avoid_breaking_exported_api)));
778     store.register_late_pass(|| Box::new(mutable_debug_assertion::DebugAssertWithMutCall));
779     store.register_late_pass(|| Box::new(exit::Exit));
780     store.register_late_pass(|| Box::new(to_digit_is_some::ToDigitIsSome));
781     let array_size_threshold = conf.array_size_threshold;
782     store.register_late_pass(move || Box::new(large_stack_arrays::LargeStackArrays::new(array_size_threshold)));
783     store.register_late_pass(move || Box::new(large_const_arrays::LargeConstArrays::new(array_size_threshold)));
784     store.register_late_pass(|| Box::new(floating_point_arithmetic::FloatingPointArithmetic));
785     store.register_early_pass(|| Box::new(as_conversions::AsConversions));
786     store.register_late_pass(|| Box::new(let_underscore::LetUnderscore));
787     store.register_early_pass(|| Box::new(single_component_path_imports::SingleComponentPathImports));
788     let max_fn_params_bools = conf.max_fn_params_bools;
789     let max_struct_bools = conf.max_struct_bools;
790     store.register_early_pass(move || {
791         Box::new(excessive_bools::ExcessiveBools::new(
792             max_struct_bools,
793             max_fn_params_bools,
794         ))
795     });
796     store.register_early_pass(|| Box::new(option_env_unwrap::OptionEnvUnwrap));
797     let warn_on_all_wildcard_imports = conf.warn_on_all_wildcard_imports;
798     store.register_late_pass(move || Box::new(wildcard_imports::WildcardImports::new(warn_on_all_wildcard_imports)));
799     store.register_late_pass(|| Box::new(redundant_pub_crate::RedundantPubCrate::default()));
800     store.register_late_pass(|| Box::new(unnamed_address::UnnamedAddress));
801     store.register_late_pass(move || Box::new(dereference::Dereferencing::new(msrv)));
802     store.register_late_pass(|| Box::new(option_if_let_else::OptionIfLetElse));
803     store.register_late_pass(|| Box::new(future_not_send::FutureNotSend));
804     store.register_late_pass(|| Box::new(if_let_mutex::IfLetMutex));
805     store.register_late_pass(|| Box::new(if_not_else::IfNotElse));
806     store.register_late_pass(|| Box::new(equatable_if_let::PatternEquality));
807     store.register_late_pass(|| Box::new(manual_async_fn::ManualAsyncFn));
808     store.register_late_pass(|| Box::new(panic_in_result_fn::PanicInResultFn));
809     let single_char_binding_names_threshold = conf.single_char_binding_names_threshold;
810     store.register_early_pass(move || {
811         Box::new(non_expressive_names::NonExpressiveNames {
812             single_char_binding_names_threshold,
813         })
814     });
815     let macro_matcher = conf.standard_macro_braces.iter().cloned().collect::<FxHashSet<_>>();
816     store.register_early_pass(move || Box::new(nonstandard_macro_braces::MacroBraces::new(&macro_matcher)));
817     store.register_late_pass(|| Box::new(macro_use::MacroUseImports::default()));
818     store.register_late_pass(|| Box::new(pattern_type_mismatch::PatternTypeMismatch));
819     store.register_late_pass(|| Box::new(unwrap_in_result::UnwrapInResult));
820     store.register_late_pass(|| Box::new(semicolon_if_nothing_returned::SemicolonIfNothingReturned));
821     store.register_late_pass(|| Box::new(async_yields_async::AsyncYieldsAsync));
822     let disallowed_methods = conf.disallowed_methods.clone();
823     store.register_late_pass(move || Box::new(disallowed_methods::DisallowedMethods::new(disallowed_methods.clone())));
824     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86AttSyntax));
825     store.register_early_pass(|| Box::new(asm_syntax::InlineAsmX86IntelSyntax));
826     store.register_late_pass(|| Box::new(empty_drop::EmptyDrop));
827     store.register_late_pass(|| Box::new(strings::StrToString));
828     store.register_late_pass(|| Box::new(strings::StringToString));
829     store.register_late_pass(|| Box::new(zero_sized_map_values::ZeroSizedMapValues));
830     store.register_late_pass(|| Box::new(vec_init_then_push::VecInitThenPush::default()));
831     store.register_late_pass(|| Box::new(redundant_slicing::RedundantSlicing));
832     store.register_late_pass(|| Box::new(from_str_radix_10::FromStrRadix10));
833     store.register_late_pass(move || Box::new(if_then_some_else_none::IfThenSomeElseNone::new(msrv)));
834     store.register_late_pass(|| Box::new(bool_assert_comparison::BoolAssertComparison));
835     store.register_early_pass(move || Box::new(module_style::ModStyle));
836     store.register_late_pass(|| Box::new(unused_async::UnusedAsync));
837     let disallowed_types = conf.disallowed_types.clone();
838     store.register_late_pass(move || Box::new(disallowed_types::DisallowedTypes::new(disallowed_types.clone())));
839     let import_renames = conf.enforced_import_renames.clone();
840     store.register_late_pass(move || {
841         Box::new(missing_enforced_import_rename::ImportRename::new(
842             import_renames.clone(),
843         ))
844     });
845     let scripts = conf.allowed_scripts.clone();
846     store.register_early_pass(move || Box::new(disallowed_script_idents::DisallowedScriptIdents::new(&scripts)));
847     store.register_late_pass(|| Box::new(strlen_on_c_strings::StrlenOnCStrings));
848     store.register_late_pass(move || Box::new(self_named_constructors::SelfNamedConstructors));
849     store.register_late_pass(move || Box::new(iter_not_returning_iterator::IterNotReturningIterator));
850     store.register_late_pass(move || Box::new(manual_assert::ManualAssert));
851     let enable_raw_pointer_heuristic_for_send = conf.enable_raw_pointer_heuristic_for_send;
852     store.register_late_pass(move || {
853         Box::new(non_send_fields_in_send_ty::NonSendFieldInSendTy::new(
854             enable_raw_pointer_heuristic_for_send,
855         ))
856     });
857     store.register_late_pass(move || Box::new(undocumented_unsafe_blocks::UndocumentedUnsafeBlocks));
858     store.register_late_pass(move || Box::new(format_args::FormatArgs::new(msrv)));
859     store.register_late_pass(|| Box::new(trailing_empty_array::TrailingEmptyArray));
860     store.register_early_pass(|| Box::new(octal_escapes::OctalEscapes));
861     store.register_late_pass(|| Box::new(needless_late_init::NeedlessLateInit));
862     store.register_late_pass(|| Box::new(return_self_not_must_use::ReturnSelfNotMustUse));
863     store.register_late_pass(|| Box::new(init_numbered_fields::NumberedFields));
864     store.register_early_pass(|| Box::new(single_char_lifetime_names::SingleCharLifetimeNames));
865     store.register_late_pass(move || Box::new(manual_bits::ManualBits::new(msrv)));
866     store.register_late_pass(|| Box::new(default_union_representation::DefaultUnionRepresentation));
867     store.register_early_pass(|| Box::new(doc_link_with_quotes::DocLinkWithQuotes));
868     store.register_late_pass(|| Box::new(only_used_in_recursion::OnlyUsedInRecursion::default()));
869     let allow_dbg_in_tests = conf.allow_dbg_in_tests;
870     store.register_late_pass(move || Box::new(dbg_macro::DbgMacro::new(allow_dbg_in_tests)));
871     let cargo_ignore_publish = conf.cargo_ignore_publish;
872     store.register_late_pass(move || {
873         Box::new(cargo::Cargo {
874             ignore_publish: cargo_ignore_publish,
875         })
876     });
877     store.register_late_pass(|| Box::new(write::Write::default()));
878     store.register_early_pass(|| Box::new(crate_in_macro_def::CrateInMacroDef));
879     store.register_early_pass(|| Box::new(empty_structs_with_brackets::EmptyStructsWithBrackets));
880     store.register_late_pass(|| Box::new(unnecessary_owned_empty_strings::UnnecessaryOwnedEmptyStrings));
881     store.register_early_pass(|| Box::new(pub_use::PubUse));
882     store.register_late_pass(|| Box::new(format_push_string::FormatPushString));
883     let max_include_file_size = conf.max_include_file_size;
884     store.register_late_pass(move || Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
885     store.register_late_pass(|| Box::new(strings::TrimSplitWhitespace));
886     store.register_late_pass(|| Box::new(rc_clone_in_vec_init::RcCloneInVecInit));
887     store.register_early_pass(|| Box::new(duplicate_mod::DuplicateMod::default()));
888     store.register_early_pass(|| Box::new(unused_rounding::UnusedRounding));
889     store.register_early_pass(move || Box::new(almost_complete_letter_range::AlmostCompleteLetterRange::new(msrv)));
890     store.register_late_pass(|| Box::new(swap_ptr_to_ref::SwapPtrToRef));
891     store.register_late_pass(|| Box::new(mismatching_type_param_order::TypeParamMismatch));
892     store.register_late_pass(|| Box::new(read_zero_byte_vec::ReadZeroByteVec));
893     store.register_late_pass(|| Box::new(default_instead_of_iter_empty::DefaultIterEmpty));
894     store.register_late_pass(move || Box::new(manual_rem_euclid::ManualRemEuclid::new(msrv)));
895     store.register_late_pass(move || Box::new(manual_retain::ManualRetain::new(msrv)));
896     let verbose_bit_mask_threshold = conf.verbose_bit_mask_threshold;
897     store.register_late_pass(move || Box::new(operators::Operators::new(verbose_bit_mask_threshold)));
898     store.register_late_pass(|| Box::new(invalid_utf8_in_unchecked::InvalidUtf8InUnchecked));
899     store.register_late_pass(|| Box::new(std_instead_of_core::StdReexports::default()));
900     store.register_late_pass(|| Box::new(manual_instant_elapsed::ManualInstantElapsed));
901     store.register_late_pass(|| Box::new(partialeq_to_none::PartialeqToNone));
902     store.register_late_pass(|| Box::new(manual_string_new::ManualStringNew));
903     store.register_late_pass(|| Box::new(unused_peekable::UnusedPeekable));
904     store.register_early_pass(|| Box::new(multi_assignments::MultiAssignments));
905     store.register_late_pass(|| Box::new(bool_to_int_with_if::BoolToIntWithIf));
906     // add lints here, do not remove this comment, it's used in `new_lint`
907 }
908
909 #[rustfmt::skip]
910 fn register_removed_non_tool_lints(store: &mut rustc_lint::LintStore) {
911     store.register_removed(
912         "should_assert_eq",
913         "`assert!()` will be more flexible with RFC 2011",
914     );
915     store.register_removed(
916         "extend_from_slice",
917         "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
918     );
919     store.register_removed(
920         "range_step_by_zero",
921         "`iterator.step_by(0)` panics nowadays",
922     );
923     store.register_removed(
924         "unstable_as_slice",
925         "`Vec::as_slice` has been stabilized in 1.7",
926     );
927     store.register_removed(
928         "unstable_as_mut_slice",
929         "`Vec::as_mut_slice` has been stabilized in 1.7",
930     );
931     store.register_removed(
932         "misaligned_transmute",
933         "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
934     );
935     store.register_removed(
936         "assign_ops",
937         "using compound assignment operators (e.g., `+=`) is harmless",
938     );
939     store.register_removed(
940         "if_let_redundant_pattern_matching",
941         "this lint has been changed to redundant_pattern_matching",
942     );
943     store.register_removed(
944         "unsafe_vector_initialization",
945         "the replacement suggested by this lint had substantially different behavior",
946     );
947     store.register_removed(
948         "reverse_range_loop",
949         "this lint is now included in reversed_empty_ranges",
950     );
951 }
952
953 /// Register renamed lints.
954 ///
955 /// Used in `./src/driver.rs`.
956 pub fn register_renamed(ls: &mut rustc_lint::LintStore) {
957     for (old_name, new_name) in renamed_lints::RENAMED_LINTS {
958         ls.register_renamed(old_name, new_name);
959     }
960 }
961
962 // only exists to let the dogfood integration test works.
963 // Don't run clippy as an executable directly
964 #[allow(dead_code)]
965 fn main() {
966     panic!("Please use the cargo-clippy executable");
967 }