1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(range_contains)]
8 #![feature(macro_vis_matcher)]
9 #![allow(unknown_lints, shadow_reuse, missing_docs_in_private_items)]
10 #![recursion_limit = "256"]
11 #![allow(stable_features)]
12 #![feature(iterator_find_map)]
13 #![feature(macro_at_most_once_rep)]
14 #![feature(rust_2018_preview)]
15 #![warn(rust_2018_idioms)]
16 #![allow(macro_use_extern_crate)]
25 extern crate matches as matches_macro;
28 extern crate serde_derive;
31 extern crate lazy_static;
34 extern crate if_chain;
36 macro_rules! declare_clippy_lint {
37 { pub $name:tt, style, $description:tt } => {
38 declare_lint! { pub $name, Warn, $description }
40 { pub $name:tt, correctness, $description:tt } => {
41 declare_lint! { pub $name, Deny, $description }
43 { pub $name:tt, complexity, $description:tt } => {
44 declare_lint! { pub $name, Warn, $description }
46 { pub $name:tt, perf, $description:tt } => {
47 declare_lint! { pub $name, Warn, $description }
49 { pub $name:tt, pedantic, $description:tt } => {
50 declare_lint! { pub $name, Allow, $description }
52 { pub $name:tt, restriction, $description:tt } => {
53 declare_lint! { pub $name, Allow, $description }
55 { pub $name:tt, cargo, $description:tt } => {
56 declare_lint! { pub $name, Allow, $description }
58 { pub $name:tt, nursery, $description:tt } => {
59 declare_lint! { pub $name, Allow, $description }
61 { pub $name:tt, internal, $description:tt } => {
62 declare_lint! { pub $name, Allow, $description }
64 { pub $name:tt, internal_warn, $description:tt } => {
65 declare_lint! { pub $name, Warn, $description }
73 // begin lints modules, do not remove this comment, it’s used in `update_lints`
79 pub mod blacklisted_name;
80 pub mod block_in_if_condition;
83 pub mod collapsible_if;
84 pub mod const_static_lifetime;
86 pub mod cyclomatic_complexity;
87 pub mod default_trait_access;
90 pub mod double_comparison;
91 pub mod double_parens;
92 pub mod drop_forget_ref;
93 pub mod duration_subsec;
94 pub mod else_if_without_else;
98 pub mod enum_glob_use;
99 pub mod enum_variants;
103 pub mod eta_reduction;
104 pub mod eval_order_dependence;
105 pub mod excessive_precision;
106 pub mod explicit_write;
107 pub mod fallible_impl_from;
111 pub mod identity_conversion;
113 pub mod if_let_redundant_pattern_matching;
115 pub mod indexing_slicing;
116 pub mod infallible_destructuring_match;
117 pub mod infinite_iter;
118 pub mod inherent_impl;
119 pub mod inline_fn_without_body;
120 pub mod int_plus_one;
122 pub mod items_after_statements;
123 pub mod large_enum_variant;
127 pub mod literal_representation;
138 pub mod missing_inline;
139 pub mod multiple_crate_versions;
141 pub mod mut_reference;
142 pub mod mutex_atomic;
143 pub mod needless_bool;
144 pub mod needless_borrow;
145 pub mod needless_borrowed_ref;
146 pub mod needless_continue;
147 pub mod needless_pass_by_value;
148 pub mod needless_update;
149 pub mod neg_cmp_op_on_partial_ord;
150 pub mod neg_multiply;
151 pub mod new_without_default;
153 pub mod non_copy_const;
154 pub mod non_expressive_names;
156 pub mod open_options;
157 pub mod overflow_check_conditional;
158 pub mod panic_unimplemented;
159 pub mod partialeq_ne_impl;
162 pub mod question_mark;
164 pub mod redundant_field_names;
167 pub mod replace_consts;
172 pub mod suspicious_trait_impl;
174 pub mod temporary_assignment;
176 pub mod trivially_copy_pass_by_ref;
179 pub mod unsafe_removed_from_name;
180 pub mod unused_io_amount;
181 pub mod unused_label;
186 pub mod zero_div_zero;
187 // end lints modules, do not remove this comment, it’s used in `update_lints`
190 crate use syntax::ast::{Name, NodeId};
193 #[cfg_attr(rustfmt, rustfmt_skip)]
194 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
195 let conf = match utils::conf::file_from_args(reg.args()) {
197 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
198 // do not require the file to exist
199 let file_name = if let Some(file_name) = file_name {
202 match utils::conf::lookup_conf_file() {
205 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
211 let file_name = file_name.map(|file_name| if file_name.is_relative() {
213 .local_crate_source_file
215 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
222 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
224 // all conf errors are non-fatal, we just use the default conf in case of error
225 for error in errors {
226 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
231 Err((err, span)) => {
232 reg.sess.struct_span_err(span, err)
233 .span_note(span, "Clippy will use default configuration")
235 toml::from_str("").expect("we never error on empty config files")
239 let mut store = reg.sess.lint_store.borrow_mut();
240 store.register_removed(
242 "`assert!()` will be more flexible with RFC 2011",
244 store.register_removed(
246 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
248 store.register_removed(
249 "range_step_by_zero",
250 "`iterator.step_by(0)` panics nowadays",
252 store.register_removed(
254 "`Vec::as_slice` has been stabilized in 1.7",
256 store.register_removed(
257 "unstable_as_mut_slice",
258 "`Vec::as_mut_slice` has been stabilized in 1.7",
260 store.register_removed(
262 "using `str::to_string` is common even today and specialization will likely happen soon",
264 store.register_removed(
266 "using `string::to_string` is common even today and specialization will likely happen soon",
268 store.register_removed(
269 "misaligned_transmute",
270 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
272 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
274 reg.register_late_lint_pass(box serde_api::Serde);
275 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
276 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
277 reg.register_late_lint_pass(box utils::inspector::Pass);
278 reg.register_late_lint_pass(box utils::author::Pass);
279 reg.register_late_lint_pass(box types::TypePass);
280 reg.register_late_lint_pass(box booleans::NonminimalBool);
281 reg.register_late_lint_pass(box eq_op::EqOp);
282 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
283 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
284 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
285 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
286 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
287 reg.register_late_lint_pass(box ptr::PointerPass);
288 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
289 reg.register_late_lint_pass(box needless_bool::BoolComparison);
290 reg.register_late_lint_pass(box approx_const::Pass);
291 reg.register_late_lint_pass(box misc::Pass);
292 reg.register_early_lint_pass(box precedence::Precedence);
293 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
294 reg.register_late_lint_pass(box eta_reduction::EtaPass);
295 reg.register_late_lint_pass(box identity_op::IdentityOp);
296 reg.register_late_lint_pass(box erasing_op::ErasingOp);
297 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
298 reg.register_late_lint_pass(box mut_mut::MutMut);
299 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
300 reg.register_late_lint_pass(box len_zero::LenZero);
301 reg.register_late_lint_pass(box attrs::AttrPass);
302 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
303 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
304 reg.register_late_lint_pass(box unicode::Unicode);
305 reg.register_late_lint_pass(box strings::StringAdd);
306 reg.register_early_lint_pass(box returns::ReturnPass);
307 reg.register_late_lint_pass(box methods::Pass);
308 reg.register_late_lint_pass(box shadow::Pass);
309 reg.register_late_lint_pass(box types::LetPass);
310 reg.register_late_lint_pass(box types::UnitCmp);
311 reg.register_late_lint_pass(box loops::Pass);
312 reg.register_late_lint_pass(box lifetimes::LifetimePass);
313 reg.register_late_lint_pass(box entry::HashMapLint);
314 reg.register_late_lint_pass(box ranges::Pass);
315 reg.register_late_lint_pass(box types::CastPass);
316 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
317 reg.register_late_lint_pass(box matches::MatchPass);
318 reg.register_late_lint_pass(box minmax::MinMaxPass);
319 reg.register_late_lint_pass(box open_options::NonSensical);
320 reg.register_late_lint_pass(box zero_div_zero::Pass);
321 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
322 reg.register_late_lint_pass(box needless_update::Pass);
323 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
324 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
325 reg.register_late_lint_pass(box no_effect::Pass);
326 reg.register_late_lint_pass(box map_clone::Pass);
327 reg.register_late_lint_pass(box temporary_assignment::Pass);
328 reg.register_late_lint_pass(box transmute::Transmute);
329 reg.register_late_lint_pass(
330 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
332 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
333 reg.register_early_lint_pass(box misc_early::MiscEarly);
334 reg.register_late_lint_pass(box panic_unimplemented::Pass);
335 reg.register_late_lint_pass(box strings::StringLitAsBytes);
336 reg.register_late_lint_pass(box derive::Derive);
337 reg.register_late_lint_pass(box types::CharLitAsU8);
338 reg.register_late_lint_pass(box write::Pass);
339 reg.register_late_lint_pass(box vec::Pass);
340 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
341 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
343 reg.register_late_lint_pass(box drop_forget_ref::Pass);
344 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
345 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
346 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
347 reg.register_late_lint_pass(box regex::Pass::default());
348 reg.register_late_lint_pass(box copies::CopyAndPaste);
349 reg.register_late_lint_pass(box format::Pass);
350 reg.register_early_lint_pass(box formatting::Formatting);
351 reg.register_late_lint_pass(box swap::Swap);
352 reg.register_early_lint_pass(box if_not_else::IfNotElse);
353 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
354 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
355 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
356 reg.register_late_lint_pass(box unused_label::UnusedLabel);
357 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
358 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
359 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
360 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
361 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
362 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
363 reg.register_late_lint_pass(box mem_forget::MemForget);
364 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
365 reg.register_late_lint_pass(box assign_ops::AssignOps);
366 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
367 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
368 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
369 reg.register_late_lint_pass(box missing_inline::MissingInline);
370 reg.register_late_lint_pass(box ok_if_let::Pass);
371 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
372 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
373 reg.register_early_lint_pass(box reference::Pass);
374 reg.register_early_lint_pass(box reference::DerefPass);
375 reg.register_early_lint_pass(box double_parens::DoubleParens);
376 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
377 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
378 reg.register_late_lint_pass(box explicit_write::Pass);
379 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
380 reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new(
381 conf.trivial_copy_size_limit,
384 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
385 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
386 conf.literal_representation_threshold
388 reg.register_late_lint_pass(box use_self::UseSelf);
389 reg.register_late_lint_pass(box bytecount::ByteCount);
390 reg.register_late_lint_pass(box infinite_iter::Pass);
391 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
392 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
393 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
394 reg.register_late_lint_pass(box types::ImplicitHasher);
395 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
396 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
397 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
398 reg.register_late_lint_pass(box types::UnitArg);
399 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
400 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
401 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
402 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
403 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
404 reg.register_late_lint_pass(box map_unit_fn::Pass);
405 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
406 reg.register_late_lint_pass(box inherent_impl::Pass::default());
407 reg.register_late_lint_pass(box neg_cmp_op_on_partial_ord::NoNegCompOpForPartialOrd);
408 reg.register_late_lint_pass(box unwrap::Pass);
409 reg.register_late_lint_pass(box duration_subsec::DurationSubsec);
410 reg.register_late_lint_pass(box default_trait_access::DefaultTraitAccess);
411 reg.register_late_lint_pass(box indexing_slicing::IndexingSlicing);
412 reg.register_late_lint_pass(box non_copy_const::NonCopyConst);
414 reg.register_lint_group("clippy_restriction", vec![
415 arithmetic::FLOAT_ARITHMETIC,
416 arithmetic::INTEGER_ARITHMETIC,
417 assign_ops::ASSIGN_OPS,
418 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
419 inherent_impl::MULTIPLE_INHERENT_IMPL,
420 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
421 mem_forget::MEM_FORGET,
422 methods::CLONE_ON_REF_PTR,
423 methods::OPTION_UNWRAP_USED,
424 methods::RESULT_UNWRAP_USED,
425 methods::WRONG_PUB_SELF_CONVENTION,
426 misc::FLOAT_CMP_CONST,
427 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
428 missing_inline::MISSING_INLINE_IN_PUBLIC_ITEMS,
429 panic_unimplemented::UNIMPLEMENTED,
430 shadow::SHADOW_REUSE,
432 shadow::SHADOW_UNRELATED,
438 reg.register_lint_group("clippy_pedantic", vec![
439 attrs::INLINE_ALWAYS,
440 copies::MATCH_SAME_ARMS,
441 default_trait_access::DEFAULT_TRAIT_ACCESS,
442 derive::EXPL_IMPL_CLONE_ON_COPY,
444 empty_enum::EMPTY_ENUM,
445 enum_glob_use::ENUM_GLOB_USE,
446 enum_variants::PUB_ENUM_VARIANT_NAMES,
447 enum_variants::STUTTER,
448 if_not_else::IF_NOT_ELSE,
449 indexing_slicing::INDEXING_SLICING,
450 infinite_iter::MAYBE_INFINITE_ITER,
451 items_after_statements::ITEMS_AFTER_STATEMENTS,
452 matches::SINGLE_MATCH_ELSE,
454 methods::OPTION_MAP_UNWRAP_OR,
455 methods::OPTION_MAP_UNWRAP_OR_ELSE,
456 methods::RESULT_MAP_UNWRAP_OR_ELSE,
457 misc::USED_UNDERSCORE_BINDING,
458 misc_early::UNSEPARATED_LITERAL_SUFFIX,
460 needless_continue::NEEDLESS_CONTINUE,
461 non_expressive_names::SIMILAR_NAMES,
462 replace_consts::REPLACE_CONSTS,
463 strings::STRING_ADD_ASSIGN,
464 types::CAST_POSSIBLE_TRUNCATION,
465 types::CAST_POSSIBLE_WRAP,
466 types::CAST_PRECISION_LOSS,
467 types::CAST_SIGN_LOSS,
468 types::INVALID_UPCAST_COMPARISONS,
470 unicode::NON_ASCII_LITERAL,
471 unicode::UNICODE_NOT_NFC,
475 reg.register_lint_group("clippy_internal", vec![
476 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
477 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
480 reg.register_lint_group("clippy", vec![
481 approx_const::APPROX_CONSTANT,
482 assign_ops::ASSIGN_OP_PATTERN,
483 assign_ops::MISREFACTORED_ASSIGN_OP,
484 attrs::DEPRECATED_SEMVER,
485 attrs::USELESS_ATTRIBUTE,
486 bit_mask::BAD_BIT_MASK,
487 bit_mask::INEFFECTIVE_BIT_MASK,
488 bit_mask::VERBOSE_BIT_MASK,
489 blacklisted_name::BLACKLISTED_NAME,
490 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
491 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
493 booleans::NONMINIMAL_BOOL,
494 bytecount::NAIVE_BYTECOUNT,
495 collapsible_if::COLLAPSIBLE_IF,
496 const_static_lifetime::CONST_STATIC_LIFETIME,
497 copies::IF_SAME_THEN_ELSE,
498 copies::IFS_SAME_COND,
499 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
500 derive::DERIVE_HASH_XOR_EQ,
501 double_comparison::DOUBLE_COMPARISONS,
502 double_parens::DOUBLE_PARENS,
503 drop_forget_ref::DROP_COPY,
504 drop_forget_ref::DROP_REF,
505 drop_forget_ref::FORGET_COPY,
506 drop_forget_ref::FORGET_REF,
507 duration_subsec::DURATION_SUBSEC,
509 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
510 enum_variants::ENUM_VARIANT_NAMES,
511 enum_variants::MODULE_INCEPTION,
514 erasing_op::ERASING_OP,
516 eta_reduction::REDUNDANT_CLOSURE,
517 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
518 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
519 excessive_precision::EXCESSIVE_PRECISION,
520 explicit_write::EXPLICIT_WRITE,
521 format::USELESS_FORMAT,
522 formatting::POSSIBLE_MISSING_COMMA,
523 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
524 formatting::SUSPICIOUS_ELSE_FORMATTING,
525 functions::NOT_UNSAFE_PTR_ARG_DEREF,
526 functions::TOO_MANY_ARGUMENTS,
527 identity_conversion::IDENTITY_CONVERSION,
528 identity_op::IDENTITY_OP,
529 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
530 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
531 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
532 infinite_iter::INFINITE_ITER,
533 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
534 int_plus_one::INT_PLUS_ONE,
535 invalid_ref::INVALID_REF,
536 large_enum_variant::LARGE_ENUM_VARIANT,
537 len_zero::LEN_WITHOUT_IS_EMPTY,
539 let_if_seq::USELESS_LET_IF_SEQ,
540 lifetimes::EXTRA_UNUSED_LIFETIMES,
541 lifetimes::NEEDLESS_LIFETIMES,
542 literal_representation::INCONSISTENT_DIGIT_GROUPING,
543 literal_representation::LARGE_DIGIT_GROUPS,
544 literal_representation::UNREADABLE_LITERAL,
546 loops::EXPLICIT_COUNTER_LOOP,
547 loops::EXPLICIT_INTO_ITER_LOOP,
548 loops::EXPLICIT_ITER_LOOP,
550 loops::FOR_LOOP_OVER_OPTION,
551 loops::FOR_LOOP_OVER_RESULT,
552 loops::ITER_NEXT_LOOP,
553 loops::MANUAL_MEMCPY,
554 loops::MUT_RANGE_BOUND,
555 loops::NEEDLESS_RANGE_LOOP,
557 loops::REVERSE_RANGE_LOOP,
558 loops::UNUSED_COLLECT,
559 loops::WHILE_IMMUTABLE_CONDITION,
560 loops::WHILE_LET_LOOP,
561 loops::WHILE_LET_ON_ITERATOR,
562 map_clone::MAP_CLONE,
563 map_unit_fn::OPTION_MAP_UNIT_FN,
564 map_unit_fn::RESULT_MAP_UNIT_FN,
565 matches::MATCH_AS_REF,
567 matches::MATCH_OVERLAPPING_ARM,
568 matches::MATCH_REF_PATS,
569 matches::MATCH_WILD_ERR_ARM,
570 matches::SINGLE_MATCH,
571 methods::CHARS_LAST_CMP,
572 methods::CHARS_NEXT_CMP,
573 methods::CLONE_DOUBLE_REF,
574 methods::CLONE_ON_COPY,
575 methods::EXPECT_FUN_CALL,
576 methods::FILTER_NEXT,
578 methods::ITER_CLONED_COLLECT,
580 methods::ITER_SKIP_NEXT,
581 methods::NEW_RET_NO_SELF,
583 methods::OPTION_MAP_OR_NONE,
584 methods::OR_FUN_CALL,
585 methods::SEARCH_IS_SOME,
586 methods::SHOULD_IMPLEMENT_TRAIT,
587 methods::SINGLE_CHAR_PATTERN,
588 methods::STRING_EXTEND_CHARS,
589 methods::TEMPORARY_CSTRING_AS_PTR,
590 methods::UNNECESSARY_FOLD,
591 methods::USELESS_ASREF,
592 methods::WRONG_SELF_CONVENTION,
598 misc::REDUNDANT_PATTERN,
599 misc::SHORT_CIRCUIT_STATEMENT,
600 misc::TOPLEVEL_REF_ARG,
602 misc_early::BUILTIN_TYPE_SHADOW,
603 misc_early::DOUBLE_NEG,
604 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
605 misc_early::MIXED_CASE_HEX_LITERALS,
606 misc_early::REDUNDANT_CLOSURE_CALL,
607 misc_early::UNNEEDED_FIELD_PATTERN,
608 misc_early::ZERO_PREFIXED_LITERAL,
609 mut_reference::UNNECESSARY_MUT_PASSED,
610 mutex_atomic::MUTEX_ATOMIC,
611 needless_bool::BOOL_COMPARISON,
612 needless_bool::NEEDLESS_BOOL,
613 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
614 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
615 needless_update::NEEDLESS_UPDATE,
616 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
617 neg_multiply::NEG_MULTIPLY,
618 new_without_default::NEW_WITHOUT_DEFAULT,
619 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
620 no_effect::NO_EFFECT,
621 no_effect::UNNECESSARY_OPERATION,
622 non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
623 non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
624 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
625 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
626 ok_if_let::IF_LET_SOME_RESULT,
627 open_options::NONSENSICAL_OPEN_OPTIONS,
628 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
629 panic_unimplemented::PANIC_PARAMS,
630 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
631 precedence::PRECEDENCE,
635 question_mark::QUESTION_MARK,
636 ranges::ITERATOR_STEP_BY_ZERO,
637 ranges::RANGE_MINUS_ONE,
638 ranges::RANGE_ZIP_WITH_LEN,
639 redundant_field_names::REDUNDANT_FIELD_NAMES,
640 reference::DEREF_ADDROF,
641 reference::REF_IN_DEREF,
642 regex::INVALID_REGEX,
644 regex::TRIVIAL_REGEX,
645 returns::LET_AND_RETURN,
646 returns::NEEDLESS_RETURN,
647 serde_api::SERDE_API_MISUSE,
648 strings::STRING_LIT_AS_BYTES,
649 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
650 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
651 swap::ALMOST_SWAPPED,
653 temporary_assignment::TEMPORARY_ASSIGNMENT,
654 transmute::CROSSPOINTER_TRANSMUTE,
655 transmute::TRANSMUTE_BYTES_TO_STR,
656 transmute::TRANSMUTE_INT_TO_BOOL,
657 transmute::TRANSMUTE_INT_TO_CHAR,
658 transmute::TRANSMUTE_INT_TO_FLOAT,
659 transmute::TRANSMUTE_PTR_TO_PTR,
660 transmute::TRANSMUTE_PTR_TO_REF,
661 transmute::USELESS_TRANSMUTE,
662 transmute::WRONG_TRANSMUTE,
663 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
664 types::ABSURD_EXTREME_COMPARISONS,
667 types::CAST_LOSSLESS,
668 types::CAST_PTR_ALIGNMENT,
669 types::CHAR_LIT_AS_U8,
670 types::FN_TO_NUMERIC_CAST,
671 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
672 types::IMPLICIT_HASHER,
673 types::LET_UNIT_VALUE,
674 types::OPTION_OPTION,
675 types::TYPE_COMPLEXITY,
678 types::UNNECESSARY_CAST,
679 unicode::ZERO_WIDTH_SPACE,
680 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
681 unused_io_amount::UNUSED_IO_AMOUNT,
682 unused_label::UNUSED_LABEL,
684 write::PRINT_LITERAL,
685 write::PRINT_WITH_NEWLINE,
686 write::PRINTLN_EMPTY_STRING,
687 write::WRITE_LITERAL,
688 write::WRITE_WITH_NEWLINE,
689 write::WRITELN_EMPTY_STRING,
690 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
693 reg.register_lint_group("clippy_style", vec![
694 assign_ops::ASSIGN_OP_PATTERN,
695 bit_mask::VERBOSE_BIT_MASK,
696 blacklisted_name::BLACKLISTED_NAME,
697 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
698 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
699 collapsible_if::COLLAPSIBLE_IF,
700 const_static_lifetime::CONST_STATIC_LIFETIME,
701 enum_variants::ENUM_VARIANT_NAMES,
702 enum_variants::MODULE_INCEPTION,
704 eta_reduction::REDUNDANT_CLOSURE,
705 excessive_precision::EXCESSIVE_PRECISION,
706 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
707 formatting::SUSPICIOUS_ELSE_FORMATTING,
708 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
709 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
710 len_zero::LEN_WITHOUT_IS_EMPTY,
712 let_if_seq::USELESS_LET_IF_SEQ,
713 literal_representation::INCONSISTENT_DIGIT_GROUPING,
714 literal_representation::LARGE_DIGIT_GROUPS,
715 literal_representation::UNREADABLE_LITERAL,
717 loops::EXPLICIT_INTO_ITER_LOOP,
718 loops::EXPLICIT_ITER_LOOP,
720 loops::NEEDLESS_RANGE_LOOP,
721 loops::WHILE_LET_ON_ITERATOR,
722 map_clone::MAP_CLONE,
724 matches::MATCH_OVERLAPPING_ARM,
725 matches::MATCH_REF_PATS,
726 matches::MATCH_WILD_ERR_ARM,
727 matches::SINGLE_MATCH,
728 methods::CHARS_LAST_CMP,
730 methods::ITER_CLONED_COLLECT,
731 methods::ITER_SKIP_NEXT,
732 methods::NEW_RET_NO_SELF,
734 methods::OPTION_MAP_OR_NONE,
735 methods::SHOULD_IMPLEMENT_TRAIT,
736 methods::STRING_EXTEND_CHARS,
737 methods::UNNECESSARY_FOLD,
738 methods::WRONG_SELF_CONVENTION,
739 misc::REDUNDANT_PATTERN,
740 misc::TOPLEVEL_REF_ARG,
742 misc_early::BUILTIN_TYPE_SHADOW,
743 misc_early::DOUBLE_NEG,
744 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
745 misc_early::MIXED_CASE_HEX_LITERALS,
746 misc_early::UNNEEDED_FIELD_PATTERN,
747 mut_reference::UNNECESSARY_MUT_PASSED,
748 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
749 neg_multiply::NEG_MULTIPLY,
750 new_without_default::NEW_WITHOUT_DEFAULT,
751 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
752 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
753 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
754 ok_if_let::IF_LET_SOME_RESULT,
755 panic_unimplemented::PANIC_PARAMS,
758 question_mark::QUESTION_MARK,
759 ranges::RANGE_MINUS_ONE,
760 redundant_field_names::REDUNDANT_FIELD_NAMES,
762 regex::TRIVIAL_REGEX,
763 returns::LET_AND_RETURN,
764 returns::NEEDLESS_RETURN,
765 strings::STRING_LIT_AS_BYTES,
766 types::FN_TO_NUMERIC_CAST,
767 types::IMPLICIT_HASHER,
768 types::LET_UNIT_VALUE,
769 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
770 write::PRINT_LITERAL,
771 write::PRINT_WITH_NEWLINE,
772 write::PRINTLN_EMPTY_STRING,
773 write::WRITE_LITERAL,
774 write::WRITE_WITH_NEWLINE,
775 write::WRITELN_EMPTY_STRING,
778 reg.register_lint_group("clippy_complexity", vec![
779 assign_ops::MISREFACTORED_ASSIGN_OP,
780 booleans::NONMINIMAL_BOOL,
781 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
782 double_comparison::DOUBLE_COMPARISONS,
783 double_parens::DOUBLE_PARENS,
784 duration_subsec::DURATION_SUBSEC,
785 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
786 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
787 explicit_write::EXPLICIT_WRITE,
788 format::USELESS_FORMAT,
789 functions::TOO_MANY_ARGUMENTS,
790 identity_conversion::IDENTITY_CONVERSION,
791 identity_op::IDENTITY_OP,
792 int_plus_one::INT_PLUS_ONE,
793 lifetimes::EXTRA_UNUSED_LIFETIMES,
794 lifetimes::NEEDLESS_LIFETIMES,
795 loops::EXPLICIT_COUNTER_LOOP,
796 loops::MUT_RANGE_BOUND,
797 loops::WHILE_LET_LOOP,
798 map_unit_fn::OPTION_MAP_UNIT_FN,
799 map_unit_fn::RESULT_MAP_UNIT_FN,
800 matches::MATCH_AS_REF,
801 methods::CHARS_NEXT_CMP,
802 methods::CLONE_ON_COPY,
803 methods::FILTER_NEXT,
804 methods::SEARCH_IS_SOME,
805 methods::USELESS_ASREF,
806 misc::SHORT_CIRCUIT_STATEMENT,
807 misc_early::REDUNDANT_CLOSURE_CALL,
808 misc_early::ZERO_PREFIXED_LITERAL,
809 needless_bool::BOOL_COMPARISON,
810 needless_bool::NEEDLESS_BOOL,
811 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
812 needless_update::NEEDLESS_UPDATE,
813 neg_cmp_op_on_partial_ord::NEG_CMP_OP_ON_PARTIAL_ORD,
814 no_effect::NO_EFFECT,
815 no_effect::UNNECESSARY_OPERATION,
816 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
817 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
818 precedence::PRECEDENCE,
819 ranges::RANGE_ZIP_WITH_LEN,
820 reference::DEREF_ADDROF,
821 reference::REF_IN_DEREF,
823 temporary_assignment::TEMPORARY_ASSIGNMENT,
824 transmute::CROSSPOINTER_TRANSMUTE,
825 transmute::TRANSMUTE_BYTES_TO_STR,
826 transmute::TRANSMUTE_INT_TO_BOOL,
827 transmute::TRANSMUTE_INT_TO_CHAR,
828 transmute::TRANSMUTE_INT_TO_FLOAT,
829 transmute::TRANSMUTE_PTR_TO_PTR,
830 transmute::TRANSMUTE_PTR_TO_REF,
831 transmute::USELESS_TRANSMUTE,
833 types::CAST_LOSSLESS,
834 types::CHAR_LIT_AS_U8,
835 types::OPTION_OPTION,
836 types::TYPE_COMPLEXITY,
838 types::UNNECESSARY_CAST,
839 unused_label::UNUSED_LABEL,
840 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
843 reg.register_lint_group("clippy_correctness", vec![
844 approx_const::APPROX_CONSTANT,
845 attrs::DEPRECATED_SEMVER,
846 attrs::USELESS_ATTRIBUTE,
847 bit_mask::BAD_BIT_MASK,
848 bit_mask::INEFFECTIVE_BIT_MASK,
850 copies::IF_SAME_THEN_ELSE,
851 copies::IFS_SAME_COND,
852 derive::DERIVE_HASH_XOR_EQ,
853 drop_forget_ref::DROP_COPY,
854 drop_forget_ref::DROP_REF,
855 drop_forget_ref::FORGET_COPY,
856 drop_forget_ref::FORGET_REF,
857 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
859 erasing_op::ERASING_OP,
860 formatting::POSSIBLE_MISSING_COMMA,
861 functions::NOT_UNSAFE_PTR_ARG_DEREF,
862 indexing_slicing::OUT_OF_BOUNDS_INDEXING,
863 infinite_iter::INFINITE_ITER,
864 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
865 invalid_ref::INVALID_REF,
866 loops::FOR_LOOP_OVER_OPTION,
867 loops::FOR_LOOP_OVER_RESULT,
868 loops::ITER_NEXT_LOOP,
870 loops::REVERSE_RANGE_LOOP,
871 loops::WHILE_IMMUTABLE_CONDITION,
872 methods::CLONE_DOUBLE_REF,
873 methods::TEMPORARY_CSTRING_AS_PTR,
878 non_copy_const::BORROW_INTERIOR_MUTABLE_CONST,
879 non_copy_const::DECLARE_INTERIOR_MUTABLE_CONST,
880 open_options::NONSENSICAL_OPEN_OPTIONS,
882 ranges::ITERATOR_STEP_BY_ZERO,
883 regex::INVALID_REGEX,
884 serde_api::SERDE_API_MISUSE,
885 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
886 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
887 swap::ALMOST_SWAPPED,
888 transmute::WRONG_TRANSMUTE,
889 types::ABSURD_EXTREME_COMPARISONS,
890 types::CAST_PTR_ALIGNMENT,
891 types::FN_TO_NUMERIC_CAST_WITH_TRUNCATION,
893 unicode::ZERO_WIDTH_SPACE,
894 unused_io_amount::UNUSED_IO_AMOUNT,
897 reg.register_lint_group("clippy_perf", vec![
898 bytecount::NAIVE_BYTECOUNT,
901 large_enum_variant::LARGE_ENUM_VARIANT,
902 loops::MANUAL_MEMCPY,
903 loops::UNUSED_COLLECT,
904 methods::EXPECT_FUN_CALL,
906 methods::OR_FUN_CALL,
907 methods::SINGLE_CHAR_PATTERN,
909 mutex_atomic::MUTEX_ATOMIC,
910 trivially_copy_pass_by_ref::TRIVIALLY_COPY_PASS_BY_REF,
915 reg.register_lint_group("clippy_cargo", vec![
916 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
919 reg.register_lint_group("clippy_nursery", vec![
920 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
921 fallible_impl_from::FALLIBLE_IMPL_FROM,
922 mutex_atomic::MUTEX_INTEGER,
923 needless_borrow::NEEDLESS_BORROW,
924 ranges::RANGE_PLUS_ONE,
925 unwrap::PANICKING_UNWRAP,
926 unwrap::UNNECESSARY_UNWRAP,
930 // only exists to let the dogfood integration test works.
931 // Don't run clippy as an executable directly
932 #[allow(dead_code, print_stdout)]
934 panic!("Please use the cargo-clippy executable");