1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(custom_attribute)]
5 #![feature(rustc_private)]
6 #![feature(slice_patterns)]
7 #![feature(stmt_expr_attributes)]
8 #![feature(conservative_impl_trait)]
9 #![feature(range_contains)]
10 #![feature(macro_vis_matcher)]
11 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
12 #![recursion_limit = "256"]
14 // FIXME(mark-i-m) remove after i128 stablization merges
15 #![allow(stable_features)]
16 #![feature(i128, i128_type)]
20 extern crate rustc_typeck;
22 extern crate syntax_pos;
26 // for unicode nfc normalization
28 extern crate unicode_normalization;
30 // for semver check in attrs.rs
36 extern crate regex_syntax;
38 // for finding minimal boolean expressions
40 extern crate quine_mc_cluskey;
42 extern crate rustc_const_math;
43 extern crate rustc_errors;
44 extern crate rustc_plugin;
47 extern crate matches as matches_macro;
51 extern crate serde_derive;
54 extern crate lazy_static;
56 extern crate itertools;
57 extern crate pulldown_cmark;
61 extern crate if_chain;
63 macro_rules! declare_clippy_lint {
64 { pub $name:tt, style, $description:tt } => {
65 declare_lint! { pub $name, Warn, $description }
67 { pub $name:tt, correctness, $description:tt } => {
68 declare_lint! { pub $name, Deny, $description }
70 { pub $name:tt, complexity, $description:tt } => {
71 declare_lint! { pub $name, Warn, $description }
73 { pub $name:tt, perf, $description:tt } => {
74 declare_lint! { pub $name, Warn, $description }
76 { pub $name:tt, pedantic, $description:tt } => {
77 declare_lint! { pub $name, Allow, $description }
79 { pub $name:tt, restriction, $description:tt } => {
80 declare_lint! { pub $name, Allow, $description }
82 { pub $name:tt, nursery, $description:tt } => {
83 declare_lint! { pub $name, Allow, $description }
85 { pub $name:tt, internal, $description:tt } => {
86 declare_lint! { pub $name, Allow, $description }
88 { pub $name:tt, internal_warn, $description:tt } => {
89 declare_lint! { pub $name, Warn, $description }
97 // begin lints modules, do not remove this comment, it’s used in `update_lints`
100 pub mod array_indexing;
104 pub mod blacklisted_name;
105 pub mod block_in_if_condition;
108 pub mod collapsible_if;
109 pub mod const_static_lifetime;
111 pub mod cyclomatic_complexity;
114 pub mod double_comparison;
115 pub mod double_parens;
116 pub mod drop_forget_ref;
117 pub mod else_if_without_else;
121 pub mod enum_glob_use;
122 pub mod enum_variants;
126 pub mod eta_reduction;
127 pub mod eval_order_dependence;
128 pub mod explicit_write;
129 pub mod fallible_impl_from;
133 pub mod identity_conversion;
135 pub mod if_let_redundant_pattern_matching;
137 pub mod infinite_iter;
138 pub mod inline_fn_without_body;
139 pub mod int_plus_one;
141 pub mod items_after_statements;
142 pub mod large_enum_variant;
146 pub mod literal_representation;
157 pub mod mut_reference;
158 pub mod mutex_atomic;
159 pub mod needless_bool;
160 pub mod needless_borrow;
161 pub mod needless_borrowed_ref;
162 pub mod needless_continue;
163 pub mod needless_pass_by_value;
164 pub mod needless_update;
165 pub mod neg_multiply;
166 pub mod new_without_default;
168 pub mod non_expressive_names;
170 pub mod open_options;
171 pub mod overflow_check_conditional;
173 pub mod partialeq_ne_impl;
177 pub mod question_mark;
179 pub mod redundant_field_names;
182 pub mod replace_consts;
187 pub mod suspicious_trait_impl;
189 pub mod temporary_assignment;
193 pub mod unsafe_removed_from_name;
194 pub mod unused_io_amount;
195 pub mod unused_label;
198 pub mod zero_div_zero;
199 // end lints modules, do not remove this comment, it’s used in `update_lints`
202 pub use syntax::ast::{Name, NodeId};
205 #[cfg_attr(rustfmt, rustfmt_skip)]
206 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
207 let conf = match utils::conf::file_from_args(reg.args()) {
209 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
210 // do not require the file to exist
211 let file_name = if let Some(file_name) = file_name {
214 match utils::conf::lookup_conf_file() {
217 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
223 let file_name = file_name.map(|file_name| if file_name.is_relative() {
225 .local_crate_source_file
227 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
234 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
236 // all conf errors are non-fatal, we just use the default conf in case of error
237 for error in errors {
238 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
243 Err((err, span)) => {
244 reg.sess.struct_span_err(span, err)
245 .span_note(span, "Clippy will use default configuration")
247 toml::from_str("").expect("we never error on empty config files")
251 let mut store = reg.sess.lint_store.borrow_mut();
252 store.register_removed(
254 "`assert!()` will be more flexible with RFC 2011",
256 store.register_removed(
258 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
260 store.register_removed(
261 "range_step_by_zero",
262 "`iterator.step_by(0)` panics nowadays",
264 store.register_removed(
266 "`Vec::as_slice` has been stabilized in 1.7",
268 store.register_removed(
269 "unstable_as_mut_slice",
270 "`Vec::as_mut_slice` has been stabilized in 1.7",
272 store.register_removed(
274 "using `str::to_string` is common even today and specialization will likely happen soon",
276 store.register_removed(
278 "using `string::to_string` is common even today and specialization will likely happen soon",
280 store.register_removed(
281 "misaligned_transmute",
282 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
284 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
286 reg.register_late_lint_pass(box serde_api::Serde);
287 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
288 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
289 reg.register_late_lint_pass(box utils::inspector::Pass);
290 reg.register_late_lint_pass(box utils::author::Pass);
291 reg.register_late_lint_pass(box types::TypePass);
292 reg.register_late_lint_pass(box booleans::NonminimalBool);
293 reg.register_late_lint_pass(box eq_op::EqOp);
294 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
295 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
296 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
297 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
298 reg.register_late_lint_pass(box ptr::PointerPass);
299 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
300 reg.register_late_lint_pass(box needless_bool::BoolComparison);
301 reg.register_late_lint_pass(box approx_const::Pass);
302 reg.register_late_lint_pass(box misc::Pass);
303 reg.register_early_lint_pass(box precedence::Precedence);
304 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
305 reg.register_late_lint_pass(box eta_reduction::EtaPass);
306 reg.register_late_lint_pass(box identity_op::IdentityOp);
307 reg.register_late_lint_pass(box erasing_op::ErasingOp);
308 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
309 reg.register_late_lint_pass(box mut_mut::MutMut);
310 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
311 reg.register_late_lint_pass(box len_zero::LenZero);
312 reg.register_late_lint_pass(box attrs::AttrPass);
313 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
314 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
315 reg.register_late_lint_pass(box unicode::Unicode);
316 reg.register_late_lint_pass(box strings::StringAdd);
317 reg.register_early_lint_pass(box returns::ReturnPass);
318 reg.register_late_lint_pass(box methods::Pass);
319 reg.register_late_lint_pass(box shadow::Pass);
320 reg.register_late_lint_pass(box types::LetPass);
321 reg.register_late_lint_pass(box types::UnitCmp);
322 reg.register_late_lint_pass(box loops::Pass);
323 reg.register_late_lint_pass(box lifetimes::LifetimePass);
324 reg.register_late_lint_pass(box entry::HashMapLint);
325 reg.register_late_lint_pass(box ranges::Pass);
326 reg.register_late_lint_pass(box types::CastPass);
327 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
328 reg.register_late_lint_pass(box matches::MatchPass);
329 reg.register_late_lint_pass(box minmax::MinMaxPass);
330 reg.register_late_lint_pass(box open_options::NonSensical);
331 reg.register_late_lint_pass(box zero_div_zero::Pass);
332 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
333 reg.register_late_lint_pass(box needless_update::Pass);
334 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
335 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
336 reg.register_late_lint_pass(box no_effect::Pass);
337 reg.register_late_lint_pass(box map_clone::Pass);
338 reg.register_late_lint_pass(box temporary_assignment::Pass);
339 reg.register_late_lint_pass(box transmute::Transmute);
340 reg.register_late_lint_pass(
341 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
343 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
344 reg.register_early_lint_pass(box misc_early::MiscEarly);
345 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
346 reg.register_late_lint_pass(box panic::Pass);
347 reg.register_late_lint_pass(box strings::StringLitAsBytes);
348 reg.register_late_lint_pass(box derive::Derive);
349 reg.register_late_lint_pass(box types::CharLitAsU8);
350 reg.register_late_lint_pass(box print::Pass);
351 reg.register_late_lint_pass(box vec::Pass);
352 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
353 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
355 reg.register_late_lint_pass(box drop_forget_ref::Pass);
356 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
357 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
358 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
359 reg.register_late_lint_pass(box regex::Pass::default());
360 reg.register_late_lint_pass(box copies::CopyAndPaste);
361 reg.register_late_lint_pass(box format::Pass);
362 reg.register_early_lint_pass(box formatting::Formatting);
363 reg.register_late_lint_pass(box swap::Swap);
364 reg.register_early_lint_pass(box if_not_else::IfNotElse);
365 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
366 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
367 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
368 reg.register_late_lint_pass(box unused_label::UnusedLabel);
369 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
370 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
371 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
372 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
373 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
374 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
375 reg.register_late_lint_pass(box mem_forget::MemForget);
376 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
377 reg.register_late_lint_pass(box assign_ops::AssignOps);
378 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
379 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
380 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
381 reg.register_late_lint_pass(box ok_if_let::Pass);
382 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
383 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
384 reg.register_early_lint_pass(box reference::Pass);
385 reg.register_early_lint_pass(box double_parens::DoubleParens);
386 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
387 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
388 reg.register_late_lint_pass(box explicit_write::Pass);
389 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
390 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
391 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
392 conf.literal_representation_threshold
394 reg.register_late_lint_pass(box use_self::UseSelf);
395 reg.register_late_lint_pass(box bytecount::ByteCount);
396 reg.register_late_lint_pass(box infinite_iter::Pass);
397 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
398 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
399 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
400 reg.register_late_lint_pass(box types::ImplicitHasher);
401 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
402 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
403 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
404 reg.register_late_lint_pass(box types::UnitArg);
405 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
406 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
407 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
408 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
411 reg.register_lint_group("clippy_restriction", vec![
412 arithmetic::FLOAT_ARITHMETIC,
413 arithmetic::INTEGER_ARITHMETIC,
414 array_indexing::INDEXING_SLICING,
415 assign_ops::ASSIGN_OPS,
416 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
417 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
418 mem_forget::MEM_FORGET,
419 methods::CLONE_ON_REF_PTR,
420 methods::OPTION_UNWRAP_USED,
421 methods::RESULT_UNWRAP_USED,
422 methods::WRONG_PUB_SELF_CONVENTION,
423 misc::FLOAT_CMP_CONST,
424 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
427 shadow::SHADOW_REUSE,
429 shadow::SHADOW_UNRELATED,
433 reg.register_lint_group("clippy_pedantic", vec![
434 attrs::INLINE_ALWAYS,
435 copies::MATCH_SAME_ARMS,
436 derive::EXPL_IMPL_CLONE_ON_COPY,
438 empty_enum::EMPTY_ENUM,
439 enum_glob_use::ENUM_GLOB_USE,
440 enum_variants::PUB_ENUM_VARIANT_NAMES,
441 enum_variants::STUTTER,
442 if_not_else::IF_NOT_ELSE,
443 infinite_iter::MAYBE_INFINITE_ITER,
444 items_after_statements::ITEMS_AFTER_STATEMENTS,
445 matches::SINGLE_MATCH_ELSE,
447 methods::OPTION_MAP_UNWRAP_OR,
448 methods::OPTION_MAP_UNWRAP_OR_ELSE,
449 methods::RESULT_MAP_UNWRAP_OR_ELSE,
450 misc::USED_UNDERSCORE_BINDING,
451 misc_early::UNSEPARATED_LITERAL_SUFFIX,
453 needless_continue::NEEDLESS_CONTINUE,
454 non_expressive_names::SIMILAR_NAMES,
455 replace_consts::REPLACE_CONSTS,
456 strings::STRING_ADD_ASSIGN,
457 types::CAST_POSSIBLE_TRUNCATION,
458 types::CAST_POSSIBLE_WRAP,
459 types::CAST_PRECISION_LOSS,
460 types::CAST_SIGN_LOSS,
461 types::INVALID_UPCAST_COMPARISONS,
463 unicode::NON_ASCII_LITERAL,
464 unicode::UNICODE_NOT_NFC,
468 reg.register_lint_group("clippy_internal", vec![
469 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
470 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
473 reg.register_lint_group("clippy", vec![
474 approx_const::APPROX_CONSTANT,
475 array_indexing::OUT_OF_BOUNDS_INDEXING,
476 assign_ops::ASSIGN_OP_PATTERN,
477 assign_ops::MISREFACTORED_ASSIGN_OP,
478 attrs::DEPRECATED_SEMVER,
479 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
480 attrs::USELESS_ATTRIBUTE,
481 bit_mask::BAD_BIT_MASK,
482 bit_mask::INEFFECTIVE_BIT_MASK,
483 bit_mask::VERBOSE_BIT_MASK,
484 blacklisted_name::BLACKLISTED_NAME,
485 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
486 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
488 booleans::NONMINIMAL_BOOL,
489 bytecount::NAIVE_BYTECOUNT,
490 collapsible_if::COLLAPSIBLE_IF,
491 const_static_lifetime::CONST_STATIC_LIFETIME,
492 copies::IF_SAME_THEN_ELSE,
493 copies::IFS_SAME_COND,
494 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
495 derive::DERIVE_HASH_XOR_EQ,
496 double_comparison::DOUBLE_COMPARISONS,
497 double_parens::DOUBLE_PARENS,
498 drop_forget_ref::DROP_COPY,
499 drop_forget_ref::DROP_REF,
500 drop_forget_ref::FORGET_COPY,
501 drop_forget_ref::FORGET_REF,
503 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
504 enum_variants::ENUM_VARIANT_NAMES,
505 enum_variants::MODULE_INCEPTION,
508 erasing_op::ERASING_OP,
510 eta_reduction::REDUNDANT_CLOSURE,
511 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
512 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
513 explicit_write::EXPLICIT_WRITE,
514 format::USELESS_FORMAT,
515 formatting::POSSIBLE_MISSING_COMMA,
516 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
517 formatting::SUSPICIOUS_ELSE_FORMATTING,
518 functions::NOT_UNSAFE_PTR_ARG_DEREF,
519 functions::TOO_MANY_ARGUMENTS,
520 identity_conversion::IDENTITY_CONVERSION,
521 identity_op::IDENTITY_OP,
522 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
523 infinite_iter::INFINITE_ITER,
524 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
525 int_plus_one::INT_PLUS_ONE,
526 invalid_ref::INVALID_REF,
527 large_enum_variant::LARGE_ENUM_VARIANT,
528 len_zero::LEN_WITHOUT_IS_EMPTY,
530 let_if_seq::USELESS_LET_IF_SEQ,
531 lifetimes::NEEDLESS_LIFETIMES,
532 lifetimes::UNUSED_LIFETIMES,
533 literal_representation::INCONSISTENT_DIGIT_GROUPING,
534 literal_representation::LARGE_DIGIT_GROUPS,
535 literal_representation::UNREADABLE_LITERAL,
537 loops::EXPLICIT_COUNTER_LOOP,
538 loops::EXPLICIT_INTO_ITER_LOOP,
539 loops::EXPLICIT_ITER_LOOP,
541 loops::FOR_LOOP_OVER_OPTION,
542 loops::FOR_LOOP_OVER_RESULT,
543 loops::ITER_NEXT_LOOP,
544 loops::MANUAL_MEMCPY,
545 loops::MUT_RANGE_BOUND,
546 loops::NEEDLESS_RANGE_LOOP,
548 loops::REVERSE_RANGE_LOOP,
549 loops::UNUSED_COLLECT,
550 loops::WHILE_IMMUTABLE_CONDITION,
551 loops::WHILE_LET_LOOP,
552 loops::WHILE_LET_ON_ITERATOR,
553 map_clone::MAP_CLONE,
554 matches::MATCH_AS_REF,
556 matches::MATCH_OVERLAPPING_ARM,
557 matches::MATCH_REF_PATS,
558 matches::MATCH_WILD_ERR_ARM,
559 matches::SINGLE_MATCH,
560 methods::CHARS_LAST_CMP,
561 methods::CHARS_NEXT_CMP,
562 methods::CLONE_DOUBLE_REF,
563 methods::CLONE_ON_COPY,
564 methods::FILTER_NEXT,
566 methods::ITER_CLONED_COLLECT,
568 methods::ITER_SKIP_NEXT,
569 methods::NEW_RET_NO_SELF,
571 methods::OPTION_MAP_OR_NONE,
572 methods::OR_FUN_CALL,
573 methods::SEARCH_IS_SOME,
574 methods::SHOULD_IMPLEMENT_TRAIT,
575 methods::SINGLE_CHAR_PATTERN,
576 methods::STRING_EXTEND_CHARS,
577 methods::TEMPORARY_CSTRING_AS_PTR,
578 methods::UNNECESSARY_FOLD,
579 methods::USELESS_ASREF,
580 methods::WRONG_SELF_CONVENTION,
586 misc::REDUNDANT_PATTERN,
587 misc::SHORT_CIRCUIT_STATEMENT,
588 misc::TOPLEVEL_REF_ARG,
590 misc_early::BUILTIN_TYPE_SHADOW,
591 misc_early::DOUBLE_NEG,
592 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
593 misc_early::MIXED_CASE_HEX_LITERALS,
594 misc_early::REDUNDANT_CLOSURE_CALL,
595 misc_early::UNNEEDED_FIELD_PATTERN,
596 misc_early::ZERO_PREFIXED_LITERAL,
597 mut_reference::UNNECESSARY_MUT_PASSED,
598 mutex_atomic::MUTEX_ATOMIC,
599 needless_bool::BOOL_COMPARISON,
600 needless_bool::NEEDLESS_BOOL,
601 needless_borrow::NEEDLESS_BORROW,
602 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
603 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
604 needless_update::NEEDLESS_UPDATE,
605 neg_multiply::NEG_MULTIPLY,
606 new_without_default::NEW_WITHOUT_DEFAULT,
607 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
608 no_effect::NO_EFFECT,
609 no_effect::UNNECESSARY_OPERATION,
610 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
611 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
612 ok_if_let::IF_LET_SOME_RESULT,
613 open_options::NONSENSICAL_OPEN_OPTIONS,
614 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
616 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
617 precedence::PRECEDENCE,
618 print::PRINT_WITH_NEWLINE,
619 print::PRINTLN_EMPTY_STRING,
623 question_mark::QUESTION_MARK,
624 ranges::ITERATOR_STEP_BY_ZERO,
625 ranges::RANGE_MINUS_ONE,
626 ranges::RANGE_ZIP_WITH_LEN,
627 redundant_field_names::REDUNDANT_FIELD_NAMES,
628 reference::DEREF_ADDROF,
629 regex::INVALID_REGEX,
631 regex::TRIVIAL_REGEX,
632 returns::LET_AND_RETURN,
633 returns::NEEDLESS_RETURN,
634 serde_api::SERDE_API_MISUSE,
635 strings::STRING_LIT_AS_BYTES,
636 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
637 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
638 swap::ALMOST_SWAPPED,
640 temporary_assignment::TEMPORARY_ASSIGNMENT,
641 transmute::CROSSPOINTER_TRANSMUTE,
642 transmute::TRANSMUTE_BYTES_TO_STR,
643 transmute::TRANSMUTE_INT_TO_BOOL,
644 transmute::TRANSMUTE_INT_TO_CHAR,
645 transmute::TRANSMUTE_INT_TO_FLOAT,
646 transmute::TRANSMUTE_PTR_TO_REF,
647 transmute::TRANSMUTE_PTR_TO_PTR,
648 transmute::USELESS_TRANSMUTE,
649 transmute::WRONG_TRANSMUTE,
650 types::ABSURD_EXTREME_COMPARISONS,
653 types::CAST_LOSSLESS,
654 types::CAST_PTR_ALIGNMENT,
655 types::CHAR_LIT_AS_U8,
656 types::IMPLICIT_HASHER,
657 types::LET_UNIT_VALUE,
658 types::OPTION_OPTION,
659 types::TYPE_COMPLEXITY,
662 types::UNNECESSARY_CAST,
663 unicode::ZERO_WIDTH_SPACE,
664 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
665 unused_io_amount::UNUSED_IO_AMOUNT,
666 unused_label::UNUSED_LABEL,
668 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
671 reg.register_lint_group("clippy_style", vec![
672 assign_ops::ASSIGN_OP_PATTERN,
673 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
674 bit_mask::VERBOSE_BIT_MASK,
675 blacklisted_name::BLACKLISTED_NAME,
676 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
677 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
678 collapsible_if::COLLAPSIBLE_IF,
679 const_static_lifetime::CONST_STATIC_LIFETIME,
680 enum_variants::ENUM_VARIANT_NAMES,
681 enum_variants::MODULE_INCEPTION,
683 eta_reduction::REDUNDANT_CLOSURE,
684 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
685 formatting::SUSPICIOUS_ELSE_FORMATTING,
686 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
687 len_zero::LEN_WITHOUT_IS_EMPTY,
689 let_if_seq::USELESS_LET_IF_SEQ,
690 literal_representation::INCONSISTENT_DIGIT_GROUPING,
691 literal_representation::LARGE_DIGIT_GROUPS,
692 literal_representation::UNREADABLE_LITERAL,
694 loops::EXPLICIT_INTO_ITER_LOOP,
695 loops::EXPLICIT_ITER_LOOP,
697 loops::NEEDLESS_RANGE_LOOP,
698 loops::WHILE_LET_ON_ITERATOR,
699 map_clone::MAP_CLONE,
701 matches::MATCH_OVERLAPPING_ARM,
702 matches::MATCH_REF_PATS,
703 matches::MATCH_WILD_ERR_ARM,
704 matches::SINGLE_MATCH,
705 methods::CHARS_LAST_CMP,
707 methods::ITER_CLONED_COLLECT,
708 methods::ITER_SKIP_NEXT,
709 methods::NEW_RET_NO_SELF,
711 methods::OPTION_MAP_OR_NONE,
712 methods::SHOULD_IMPLEMENT_TRAIT,
713 methods::STRING_EXTEND_CHARS,
714 methods::UNNECESSARY_FOLD,
715 methods::WRONG_SELF_CONVENTION,
716 misc::REDUNDANT_PATTERN,
717 misc::TOPLEVEL_REF_ARG,
719 misc_early::BUILTIN_TYPE_SHADOW,
720 misc_early::DOUBLE_NEG,
721 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
722 misc_early::MIXED_CASE_HEX_LITERALS,
723 misc_early::UNNEEDED_FIELD_PATTERN,
724 mut_reference::UNNECESSARY_MUT_PASSED,
725 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
726 neg_multiply::NEG_MULTIPLY,
727 new_without_default::NEW_WITHOUT_DEFAULT,
728 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
729 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
730 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
731 ok_if_let::IF_LET_SOME_RESULT,
733 print::PRINT_WITH_NEWLINE,
734 print::PRINTLN_EMPTY_STRING,
737 question_mark::QUESTION_MARK,
738 ranges::RANGE_MINUS_ONE,
739 redundant_field_names::REDUNDANT_FIELD_NAMES,
741 regex::TRIVIAL_REGEX,
742 returns::LET_AND_RETURN,
743 returns::NEEDLESS_RETURN,
744 strings::STRING_LIT_AS_BYTES,
745 types::IMPLICIT_HASHER,
746 types::LET_UNIT_VALUE,
747 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
750 reg.register_lint_group("clippy_complexity", vec![
751 assign_ops::MISREFACTORED_ASSIGN_OP,
752 booleans::NONMINIMAL_BOOL,
753 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
754 double_comparison::DOUBLE_COMPARISONS,
755 double_parens::DOUBLE_PARENS,
756 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
757 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
758 explicit_write::EXPLICIT_WRITE,
759 format::USELESS_FORMAT,
760 functions::TOO_MANY_ARGUMENTS,
761 identity_conversion::IDENTITY_CONVERSION,
762 identity_op::IDENTITY_OP,
763 int_plus_one::INT_PLUS_ONE,
764 lifetimes::NEEDLESS_LIFETIMES,
765 lifetimes::UNUSED_LIFETIMES,
766 loops::EXPLICIT_COUNTER_LOOP,
767 loops::MUT_RANGE_BOUND,
768 loops::WHILE_LET_LOOP,
769 matches::MATCH_AS_REF,
770 methods::CHARS_NEXT_CMP,
771 methods::CLONE_ON_COPY,
772 methods::FILTER_NEXT,
773 methods::SEARCH_IS_SOME,
774 methods::USELESS_ASREF,
775 misc::SHORT_CIRCUIT_STATEMENT,
776 misc_early::REDUNDANT_CLOSURE_CALL,
777 misc_early::ZERO_PREFIXED_LITERAL,
778 needless_bool::BOOL_COMPARISON,
779 needless_bool::NEEDLESS_BOOL,
780 needless_borrow::NEEDLESS_BORROW,
781 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
782 needless_update::NEEDLESS_UPDATE,
783 no_effect::NO_EFFECT,
784 no_effect::UNNECESSARY_OPERATION,
785 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
786 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
787 precedence::PRECEDENCE,
788 ranges::RANGE_ZIP_WITH_LEN,
789 reference::DEREF_ADDROF,
791 temporary_assignment::TEMPORARY_ASSIGNMENT,
792 transmute::CROSSPOINTER_TRANSMUTE,
793 transmute::TRANSMUTE_BYTES_TO_STR,
794 transmute::TRANSMUTE_INT_TO_BOOL,
795 transmute::TRANSMUTE_INT_TO_CHAR,
796 transmute::TRANSMUTE_INT_TO_FLOAT,
797 transmute::TRANSMUTE_PTR_TO_REF,
798 transmute::TRANSMUTE_PTR_TO_PTR,
799 transmute::USELESS_TRANSMUTE,
801 types::CAST_LOSSLESS,
802 types::CHAR_LIT_AS_U8,
803 types::OPTION_OPTION,
804 types::TYPE_COMPLEXITY,
806 types::UNNECESSARY_CAST,
807 unused_label::UNUSED_LABEL,
808 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
811 reg.register_lint_group("clippy_correctness", vec![
812 approx_const::APPROX_CONSTANT,
813 array_indexing::OUT_OF_BOUNDS_INDEXING,
814 attrs::DEPRECATED_SEMVER,
815 attrs::USELESS_ATTRIBUTE,
816 bit_mask::BAD_BIT_MASK,
817 bit_mask::INEFFECTIVE_BIT_MASK,
819 copies::IF_SAME_THEN_ELSE,
820 copies::IFS_SAME_COND,
821 derive::DERIVE_HASH_XOR_EQ,
822 drop_forget_ref::DROP_COPY,
823 drop_forget_ref::DROP_REF,
824 drop_forget_ref::FORGET_COPY,
825 drop_forget_ref::FORGET_REF,
826 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
828 erasing_op::ERASING_OP,
829 formatting::POSSIBLE_MISSING_COMMA,
830 functions::NOT_UNSAFE_PTR_ARG_DEREF,
831 infinite_iter::INFINITE_ITER,
832 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
833 invalid_ref::INVALID_REF,
834 loops::FOR_LOOP_OVER_OPTION,
835 loops::FOR_LOOP_OVER_RESULT,
836 loops::ITER_NEXT_LOOP,
838 loops::REVERSE_RANGE_LOOP,
839 loops::WHILE_IMMUTABLE_CONDITION,
840 methods::CLONE_DOUBLE_REF,
841 methods::TEMPORARY_CSTRING_AS_PTR,
846 open_options::NONSENSICAL_OPEN_OPTIONS,
848 ranges::ITERATOR_STEP_BY_ZERO,
849 regex::INVALID_REGEX,
850 serde_api::SERDE_API_MISUSE,
851 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
852 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
853 swap::ALMOST_SWAPPED,
854 transmute::WRONG_TRANSMUTE,
855 types::ABSURD_EXTREME_COMPARISONS,
856 types::CAST_PTR_ALIGNMENT,
858 unicode::ZERO_WIDTH_SPACE,
859 unused_io_amount::UNUSED_IO_AMOUNT,
862 reg.register_lint_group("clippy_perf", vec![
863 bytecount::NAIVE_BYTECOUNT,
866 large_enum_variant::LARGE_ENUM_VARIANT,
867 loops::MANUAL_MEMCPY,
868 loops::UNUSED_COLLECT,
870 methods::OR_FUN_CALL,
871 methods::SINGLE_CHAR_PATTERN,
873 mutex_atomic::MUTEX_ATOMIC,
878 reg.register_lint_group("clippy_nursery", vec![
879 fallible_impl_from::FALLIBLE_IMPL_FROM,
880 mutex_atomic::MUTEX_INTEGER,
881 ranges::RANGE_PLUS_ONE,
885 // only exists to let the dogfood integration test works.
886 // Don't run clippy as an executable directly
887 #[allow(dead_code, print_stdout)]
889 panic!("Please use the cargo-clippy executable");