1 // error-pattern:cargo-clippy
3 #![feature(box_syntax)]
4 #![feature(rustc_private)]
5 #![feature(slice_patterns)]
6 #![feature(stmt_expr_attributes)]
7 #![feature(conservative_impl_trait)]
8 #![feature(range_contains)]
9 #![feature(macro_vis_matcher)]
10 #![allow(unknown_lints, indexing_slicing, shadow_reuse, missing_docs_in_private_items)]
11 #![recursion_limit = "256"]
12 // FIXME(mark-i-m) remove after i128 stablization merges
13 #![allow(stable_features)]
14 #![feature(i128, i128_type)]
15 #![feature(iterator_find_map)]
18 extern crate cargo_metadata;
21 extern crate rustc_typeck;
22 extern crate rustc_target;
24 extern crate syntax_pos;
28 // for unicode nfc normalization
30 extern crate unicode_normalization;
32 // for semver check in attrs.rs
38 extern crate regex_syntax;
40 // for finding minimal boolean expressions
42 extern crate quine_mc_cluskey;
44 extern crate rustc_errors;
45 extern crate rustc_plugin;
48 extern crate matches as matches_macro;
52 extern crate serde_derive;
55 extern crate lazy_static;
57 extern crate itertools;
58 extern crate pulldown_cmark;
62 extern crate if_chain;
64 macro_rules! declare_clippy_lint {
65 { pub $name:tt, style, $description:tt } => {
66 declare_lint! { pub $name, Warn, $description }
68 { pub $name:tt, correctness, $description:tt } => {
69 declare_lint! { pub $name, Deny, $description }
71 { pub $name:tt, complexity, $description:tt } => {
72 declare_lint! { pub $name, Warn, $description }
74 { pub $name:tt, perf, $description:tt } => {
75 declare_lint! { pub $name, Warn, $description }
77 { pub $name:tt, pedantic, $description:tt } => {
78 declare_lint! { pub $name, Allow, $description }
80 { pub $name:tt, restriction, $description:tt } => {
81 declare_lint! { pub $name, Allow, $description }
83 { pub $name:tt, cargo, $description:tt } => {
84 declare_lint! { pub $name, Allow, $description }
86 { pub $name:tt, nursery, $description:tt } => {
87 declare_lint! { pub $name, Allow, $description }
89 { pub $name:tt, internal, $description:tt } => {
90 declare_lint! { pub $name, Allow, $description }
92 { pub $name:tt, internal_warn, $description:tt } => {
93 declare_lint! { pub $name, Warn, $description }
101 // begin lints modules, do not remove this comment, it’s used in `update_lints`
102 pub mod approx_const;
104 pub mod array_indexing;
108 pub mod blacklisted_name;
109 pub mod block_in_if_condition;
112 pub mod collapsible_if;
113 pub mod const_static_lifetime;
115 pub mod cyclomatic_complexity;
118 pub mod double_comparison;
119 pub mod double_parens;
120 pub mod drop_forget_ref;
121 pub mod else_if_without_else;
125 pub mod enum_glob_use;
126 pub mod enum_variants;
130 pub mod eta_reduction;
131 pub mod eval_order_dependence;
132 pub mod excessive_precision;
133 pub mod explicit_write;
134 pub mod fallible_impl_from;
138 pub mod identity_conversion;
140 pub mod if_let_redundant_pattern_matching;
142 pub mod infallible_destructuring_match;
143 pub mod infinite_iter;
144 pub mod inline_fn_without_body;
145 pub mod int_plus_one;
147 pub mod items_after_statements;
148 pub mod large_enum_variant;
152 pub mod literal_representation;
163 pub mod multiple_crate_versions;
165 pub mod mut_reference;
166 pub mod mutex_atomic;
167 pub mod needless_bool;
168 pub mod needless_borrow;
169 pub mod needless_borrowed_ref;
170 pub mod needless_continue;
171 pub mod needless_pass_by_value;
172 pub mod needless_update;
173 pub mod neg_multiply;
174 pub mod new_without_default;
176 pub mod non_expressive_names;
178 pub mod open_options;
179 pub mod overflow_check_conditional;
180 pub mod panic_unimplemented;
181 pub mod partialeq_ne_impl;
184 pub mod question_mark;
186 pub mod redundant_field_names;
189 pub mod replace_consts;
194 pub mod suspicious_trait_impl;
196 pub mod temporary_assignment;
200 pub mod unsafe_removed_from_name;
201 pub mod unused_io_amount;
202 pub mod unused_label;
206 pub mod zero_div_zero;
207 // end lints modules, do not remove this comment, it’s used in `update_lints`
210 pub use syntax::ast::{Name, NodeId};
213 #[cfg_attr(rustfmt, rustfmt_skip)]
214 pub fn register_plugins(reg: &mut rustc_plugin::Registry) {
215 let conf = match utils::conf::file_from_args(reg.args()) {
217 // if the user specified a file, it must exist, otherwise default to `clippy.toml` but
218 // do not require the file to exist
219 let file_name = if let Some(file_name) = file_name {
222 match utils::conf::lookup_conf_file() {
225 reg.sess.struct_err(&format!("error finding Clippy's configuration file: {}", error)).emit();
231 let file_name = file_name.map(|file_name| if file_name.is_relative() {
233 .local_crate_source_file
235 .and_then(|file| std::path::Path::new(&file).parent().map(std::path::Path::to_path_buf))
242 let (conf, errors) = utils::conf::read(file_name.as_ref().map(|p| p.as_ref()));
244 // all conf errors are non-fatal, we just use the default conf in case of error
245 for error in errors {
246 reg.sess.struct_err(&format!("error reading Clippy's configuration file `{}`: {}", file_name.as_ref().and_then(|p| p.to_str()).unwrap_or(""), error)).emit();
251 Err((err, span)) => {
252 reg.sess.struct_span_err(span, err)
253 .span_note(span, "Clippy will use default configuration")
255 toml::from_str("").expect("we never error on empty config files")
259 let mut store = reg.sess.lint_store.borrow_mut();
260 store.register_removed(
262 "`assert!()` will be more flexible with RFC 2011",
264 store.register_removed(
266 "`.extend_from_slice(_)` is a faster way to extend a Vec by a slice",
268 store.register_removed(
269 "range_step_by_zero",
270 "`iterator.step_by(0)` panics nowadays",
272 store.register_removed(
274 "`Vec::as_slice` has been stabilized in 1.7",
276 store.register_removed(
277 "unstable_as_mut_slice",
278 "`Vec::as_mut_slice` has been stabilized in 1.7",
280 store.register_removed(
282 "using `str::to_string` is common even today and specialization will likely happen soon",
284 store.register_removed(
286 "using `string::to_string` is common even today and specialization will likely happen soon",
288 store.register_removed(
289 "misaligned_transmute",
290 "this lint has been split into cast_ptr_alignment and transmute_ptr_to_ptr",
292 // end deprecated lints, do not remove this comment, it’s used in `update_lints`
294 reg.register_late_lint_pass(box serde_api::Serde);
295 reg.register_early_lint_pass(box utils::internal_lints::Clippy);
296 reg.register_late_lint_pass(box utils::internal_lints::LintWithoutLintPass::default());
297 reg.register_late_lint_pass(box utils::inspector::Pass);
298 reg.register_late_lint_pass(box utils::author::Pass);
299 reg.register_late_lint_pass(box types::TypePass);
300 reg.register_late_lint_pass(box booleans::NonminimalBool);
301 reg.register_late_lint_pass(box eq_op::EqOp);
302 reg.register_early_lint_pass(box enum_variants::EnumVariantNames::new(conf.enum_variant_name_threshold));
303 reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
304 reg.register_late_lint_pass(box enum_clike::UnportableVariant);
305 reg.register_late_lint_pass(box excessive_precision::ExcessivePrecision);
306 reg.register_late_lint_pass(box bit_mask::BitMask::new(conf.verbose_bit_mask_threshold));
307 reg.register_late_lint_pass(box ptr::PointerPass);
308 reg.register_late_lint_pass(box needless_bool::NeedlessBool);
309 reg.register_late_lint_pass(box needless_bool::BoolComparison);
310 reg.register_late_lint_pass(box approx_const::Pass);
311 reg.register_late_lint_pass(box misc::Pass);
312 reg.register_early_lint_pass(box precedence::Precedence);
313 reg.register_early_lint_pass(box needless_continue::NeedlessContinue);
314 reg.register_late_lint_pass(box eta_reduction::EtaPass);
315 reg.register_late_lint_pass(box identity_op::IdentityOp);
316 reg.register_late_lint_pass(box erasing_op::ErasingOp);
317 reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatements);
318 reg.register_late_lint_pass(box mut_mut::MutMut);
319 reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
320 reg.register_late_lint_pass(box len_zero::LenZero);
321 reg.register_late_lint_pass(box attrs::AttrPass);
322 reg.register_early_lint_pass(box collapsible_if::CollapsibleIf);
323 reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
324 reg.register_late_lint_pass(box unicode::Unicode);
325 reg.register_late_lint_pass(box strings::StringAdd);
326 reg.register_early_lint_pass(box returns::ReturnPass);
327 reg.register_late_lint_pass(box methods::Pass);
328 reg.register_late_lint_pass(box shadow::Pass);
329 reg.register_late_lint_pass(box types::LetPass);
330 reg.register_late_lint_pass(box types::UnitCmp);
331 reg.register_late_lint_pass(box loops::Pass);
332 reg.register_late_lint_pass(box lifetimes::LifetimePass);
333 reg.register_late_lint_pass(box entry::HashMapLint);
334 reg.register_late_lint_pass(box ranges::Pass);
335 reg.register_late_lint_pass(box types::CastPass);
336 reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
337 reg.register_late_lint_pass(box matches::MatchPass);
338 reg.register_late_lint_pass(box minmax::MinMaxPass);
339 reg.register_late_lint_pass(box open_options::NonSensical);
340 reg.register_late_lint_pass(box zero_div_zero::Pass);
341 reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
342 reg.register_late_lint_pass(box needless_update::Pass);
343 reg.register_late_lint_pass(box needless_borrow::NeedlessBorrow);
344 reg.register_late_lint_pass(box needless_borrowed_ref::NeedlessBorrowedRef);
345 reg.register_late_lint_pass(box no_effect::Pass);
346 reg.register_late_lint_pass(box map_clone::Pass);
347 reg.register_late_lint_pass(box temporary_assignment::Pass);
348 reg.register_late_lint_pass(box transmute::Transmute);
349 reg.register_late_lint_pass(
350 box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold)
352 reg.register_late_lint_pass(box escape::Pass{too_large_for_stack: conf.too_large_for_stack});
353 reg.register_early_lint_pass(box misc_early::MiscEarly);
354 reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
355 reg.register_late_lint_pass(box panic_unimplemented::Pass);
356 reg.register_late_lint_pass(box strings::StringLitAsBytes);
357 reg.register_late_lint_pass(box derive::Derive);
358 reg.register_late_lint_pass(box types::CharLitAsU8);
359 reg.register_late_lint_pass(box write::Pass);
360 reg.register_late_lint_pass(box vec::Pass);
361 reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
362 single_char_binding_names_threshold: conf.single_char_binding_names_threshold,
364 reg.register_late_lint_pass(box drop_forget_ref::Pass);
365 reg.register_late_lint_pass(box empty_enum::EmptyEnum);
366 reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
367 reg.register_late_lint_pass(box types::InvalidUpcastComparisons);
368 reg.register_late_lint_pass(box regex::Pass::default());
369 reg.register_late_lint_pass(box copies::CopyAndPaste);
370 reg.register_late_lint_pass(box format::Pass);
371 reg.register_early_lint_pass(box formatting::Formatting);
372 reg.register_late_lint_pass(box swap::Swap);
373 reg.register_early_lint_pass(box if_not_else::IfNotElse);
374 reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse);
375 reg.register_early_lint_pass(box int_plus_one::IntPlusOne);
376 reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
377 reg.register_late_lint_pass(box unused_label::UnusedLabel);
378 reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
379 reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
380 reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
381 reg.register_early_lint_pass(box doc::Doc::new(conf.doc_valid_idents));
382 reg.register_late_lint_pass(box neg_multiply::NegMultiply);
383 reg.register_early_lint_pass(box unsafe_removed_from_name::UnsafeNameRemoval);
384 reg.register_late_lint_pass(box mem_forget::MemForget);
385 reg.register_late_lint_pass(box arithmetic::Arithmetic::default());
386 reg.register_late_lint_pass(box assign_ops::AssignOps);
387 reg.register_late_lint_pass(box let_if_seq::LetIfSeq);
388 reg.register_late_lint_pass(box eval_order_dependence::EvalOrderDependence);
389 reg.register_late_lint_pass(box missing_doc::MissingDoc::new());
390 reg.register_late_lint_pass(box ok_if_let::Pass);
391 reg.register_late_lint_pass(box if_let_redundant_pattern_matching::Pass);
392 reg.register_late_lint_pass(box partialeq_ne_impl::Pass);
393 reg.register_early_lint_pass(box reference::Pass);
394 reg.register_early_lint_pass(box double_parens::DoubleParens);
395 reg.register_late_lint_pass(box unused_io_amount::UnusedIoAmount);
396 reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold));
397 reg.register_late_lint_pass(box explicit_write::Pass);
398 reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue);
399 reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping);
400 reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new(
401 conf.literal_representation_threshold
403 reg.register_late_lint_pass(box use_self::UseSelf);
404 reg.register_late_lint_pass(box bytecount::ByteCount);
405 reg.register_late_lint_pass(box infinite_iter::Pass);
406 reg.register_late_lint_pass(box inline_fn_without_body::Pass);
407 reg.register_late_lint_pass(box invalid_ref::InvalidRef);
408 reg.register_late_lint_pass(box identity_conversion::IdentityConversion::default());
409 reg.register_late_lint_pass(box types::ImplicitHasher);
410 reg.register_early_lint_pass(box const_static_lifetime::StaticConst);
411 reg.register_late_lint_pass(box fallible_impl_from::FallibleImplFrom);
412 reg.register_late_lint_pass(box replace_consts::ReplaceConsts);
413 reg.register_late_lint_pass(box types::UnitArg);
414 reg.register_late_lint_pass(box double_comparison::DoubleComparisonPass);
415 reg.register_late_lint_pass(box question_mark::QuestionMarkPass);
416 reg.register_late_lint_pass(box suspicious_trait_impl::SuspiciousImpl);
417 reg.register_late_lint_pass(box redundant_field_names::RedundantFieldNames);
418 reg.register_early_lint_pass(box multiple_crate_versions::Pass);
419 reg.register_late_lint_pass(box map_unit_fn::Pass);
420 reg.register_late_lint_pass(box infallible_destructuring_match::Pass);
423 reg.register_lint_group("clippy_restriction", vec![
424 arithmetic::FLOAT_ARITHMETIC,
425 arithmetic::INTEGER_ARITHMETIC,
426 array_indexing::INDEXING_SLICING,
427 assign_ops::ASSIGN_OPS,
428 else_if_without_else::ELSE_IF_WITHOUT_ELSE,
429 literal_representation::DECIMAL_LITERAL_REPRESENTATION,
430 mem_forget::MEM_FORGET,
431 methods::CLONE_ON_REF_PTR,
432 methods::OPTION_UNWRAP_USED,
433 methods::RESULT_UNWRAP_USED,
434 methods::WRONG_PUB_SELF_CONVENTION,
435 misc::FLOAT_CMP_CONST,
436 missing_doc::MISSING_DOCS_IN_PRIVATE_ITEMS,
437 panic_unimplemented::UNIMPLEMENTED,
438 shadow::SHADOW_REUSE,
440 shadow::SHADOW_UNRELATED,
446 reg.register_lint_group("clippy_pedantic", vec![
447 attrs::INLINE_ALWAYS,
448 copies::MATCH_SAME_ARMS,
449 derive::EXPL_IMPL_CLONE_ON_COPY,
451 empty_enum::EMPTY_ENUM,
452 enum_glob_use::ENUM_GLOB_USE,
453 enum_variants::PUB_ENUM_VARIANT_NAMES,
454 enum_variants::STUTTER,
455 if_not_else::IF_NOT_ELSE,
456 infinite_iter::MAYBE_INFINITE_ITER,
457 items_after_statements::ITEMS_AFTER_STATEMENTS,
458 matches::SINGLE_MATCH_ELSE,
460 methods::OPTION_MAP_UNWRAP_OR,
461 methods::OPTION_MAP_UNWRAP_OR_ELSE,
462 methods::RESULT_MAP_UNWRAP_OR_ELSE,
463 misc::USED_UNDERSCORE_BINDING,
464 misc_early::UNSEPARATED_LITERAL_SUFFIX,
466 needless_continue::NEEDLESS_CONTINUE,
467 non_expressive_names::SIMILAR_NAMES,
468 replace_consts::REPLACE_CONSTS,
469 strings::STRING_ADD_ASSIGN,
470 types::CAST_POSSIBLE_TRUNCATION,
471 types::CAST_POSSIBLE_WRAP,
472 types::CAST_PRECISION_LOSS,
473 types::CAST_SIGN_LOSS,
474 types::INVALID_UPCAST_COMPARISONS,
476 unicode::NON_ASCII_LITERAL,
477 unicode::UNICODE_NOT_NFC,
481 reg.register_lint_group("clippy_internal", vec![
482 utils::internal_lints::CLIPPY_LINTS_INTERNAL,
483 utils::internal_lints::LINT_WITHOUT_LINT_PASS,
486 reg.register_lint_group("clippy", vec![
487 approx_const::APPROX_CONSTANT,
488 array_indexing::OUT_OF_BOUNDS_INDEXING,
489 assign_ops::ASSIGN_OP_PATTERN,
490 assign_ops::MISREFACTORED_ASSIGN_OP,
491 attrs::DEPRECATED_SEMVER,
492 attrs::USELESS_ATTRIBUTE,
493 bit_mask::BAD_BIT_MASK,
494 bit_mask::INEFFECTIVE_BIT_MASK,
495 bit_mask::VERBOSE_BIT_MASK,
496 blacklisted_name::BLACKLISTED_NAME,
497 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
498 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
500 booleans::NONMINIMAL_BOOL,
501 bytecount::NAIVE_BYTECOUNT,
502 collapsible_if::COLLAPSIBLE_IF,
503 const_static_lifetime::CONST_STATIC_LIFETIME,
504 copies::IF_SAME_THEN_ELSE,
505 copies::IFS_SAME_COND,
506 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
507 derive::DERIVE_HASH_XOR_EQ,
508 double_comparison::DOUBLE_COMPARISONS,
509 double_parens::DOUBLE_PARENS,
510 drop_forget_ref::DROP_COPY,
511 drop_forget_ref::DROP_REF,
512 drop_forget_ref::FORGET_COPY,
513 drop_forget_ref::FORGET_REF,
515 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
516 enum_variants::ENUM_VARIANT_NAMES,
517 enum_variants::MODULE_INCEPTION,
520 erasing_op::ERASING_OP,
522 eta_reduction::REDUNDANT_CLOSURE,
523 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
524 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
525 excessive_precision::EXCESSIVE_PRECISION,
526 explicit_write::EXPLICIT_WRITE,
527 format::USELESS_FORMAT,
528 formatting::POSSIBLE_MISSING_COMMA,
529 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
530 formatting::SUSPICIOUS_ELSE_FORMATTING,
531 functions::NOT_UNSAFE_PTR_ARG_DEREF,
532 functions::TOO_MANY_ARGUMENTS,
533 identity_conversion::IDENTITY_CONVERSION,
534 identity_op::IDENTITY_OP,
535 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
536 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
537 infinite_iter::INFINITE_ITER,
538 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
539 int_plus_one::INT_PLUS_ONE,
540 invalid_ref::INVALID_REF,
541 large_enum_variant::LARGE_ENUM_VARIANT,
542 len_zero::LEN_WITHOUT_IS_EMPTY,
544 let_if_seq::USELESS_LET_IF_SEQ,
545 lifetimes::NEEDLESS_LIFETIMES,
546 lifetimes::UNUSED_LIFETIMES,
547 literal_representation::INCONSISTENT_DIGIT_GROUPING,
548 literal_representation::LARGE_DIGIT_GROUPS,
549 literal_representation::UNREADABLE_LITERAL,
551 loops::EXPLICIT_COUNTER_LOOP,
552 loops::EXPLICIT_INTO_ITER_LOOP,
553 loops::EXPLICIT_ITER_LOOP,
555 loops::FOR_LOOP_OVER_OPTION,
556 loops::FOR_LOOP_OVER_RESULT,
557 loops::ITER_NEXT_LOOP,
558 loops::MANUAL_MEMCPY,
559 loops::MUT_RANGE_BOUND,
560 loops::NEEDLESS_RANGE_LOOP,
562 loops::REVERSE_RANGE_LOOP,
563 loops::UNUSED_COLLECT,
564 loops::WHILE_IMMUTABLE_CONDITION,
565 loops::WHILE_LET_LOOP,
566 loops::WHILE_LET_ON_ITERATOR,
567 map_clone::MAP_CLONE,
568 map_unit_fn::OPTION_MAP_UNIT_FN,
569 map_unit_fn::RESULT_MAP_UNIT_FN,
570 matches::MATCH_AS_REF,
572 matches::MATCH_OVERLAPPING_ARM,
573 matches::MATCH_REF_PATS,
574 matches::MATCH_WILD_ERR_ARM,
575 matches::SINGLE_MATCH,
576 methods::CHARS_LAST_CMP,
577 methods::CHARS_NEXT_CMP,
578 methods::CLONE_DOUBLE_REF,
579 methods::CLONE_ON_COPY,
580 methods::FILTER_NEXT,
582 methods::ITER_CLONED_COLLECT,
584 methods::ITER_SKIP_NEXT,
585 methods::NEW_RET_NO_SELF,
587 methods::OPTION_MAP_OR_NONE,
588 methods::OR_FUN_CALL,
589 methods::SEARCH_IS_SOME,
590 methods::SHOULD_IMPLEMENT_TRAIT,
591 methods::SINGLE_CHAR_PATTERN,
592 methods::STRING_EXTEND_CHARS,
593 methods::TEMPORARY_CSTRING_AS_PTR,
594 methods::UNNECESSARY_FOLD,
595 methods::USELESS_ASREF,
596 methods::WRONG_SELF_CONVENTION,
602 misc::REDUNDANT_PATTERN,
603 misc::SHORT_CIRCUIT_STATEMENT,
604 misc::TOPLEVEL_REF_ARG,
606 misc_early::BUILTIN_TYPE_SHADOW,
607 misc_early::DOUBLE_NEG,
608 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
609 misc_early::MIXED_CASE_HEX_LITERALS,
610 misc_early::REDUNDANT_CLOSURE_CALL,
611 misc_early::UNNEEDED_FIELD_PATTERN,
612 misc_early::ZERO_PREFIXED_LITERAL,
613 mut_reference::UNNECESSARY_MUT_PASSED,
614 mutex_atomic::MUTEX_ATOMIC,
615 needless_bool::BOOL_COMPARISON,
616 needless_bool::NEEDLESS_BOOL,
617 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
618 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
619 needless_update::NEEDLESS_UPDATE,
620 neg_multiply::NEG_MULTIPLY,
621 new_without_default::NEW_WITHOUT_DEFAULT,
622 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
623 no_effect::NO_EFFECT,
624 no_effect::UNNECESSARY_OPERATION,
625 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
626 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
627 ok_if_let::IF_LET_SOME_RESULT,
628 open_options::NONSENSICAL_OPEN_OPTIONS,
629 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
630 panic_unimplemented::PANIC_PARAMS,
631 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
632 precedence::PRECEDENCE,
636 question_mark::QUESTION_MARK,
637 ranges::ITERATOR_STEP_BY_ZERO,
638 ranges::RANGE_MINUS_ONE,
639 ranges::RANGE_ZIP_WITH_LEN,
640 redundant_field_names::REDUNDANT_FIELD_NAMES,
641 reference::DEREF_ADDROF,
642 regex::INVALID_REGEX,
644 regex::TRIVIAL_REGEX,
645 returns::LET_AND_RETURN,
646 returns::NEEDLESS_RETURN,
647 serde_api::SERDE_API_MISUSE,
648 strings::STRING_LIT_AS_BYTES,
649 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
650 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
651 swap::ALMOST_SWAPPED,
653 temporary_assignment::TEMPORARY_ASSIGNMENT,
654 transmute::CROSSPOINTER_TRANSMUTE,
655 transmute::TRANSMUTE_BYTES_TO_STR,
656 transmute::TRANSMUTE_INT_TO_BOOL,
657 transmute::TRANSMUTE_INT_TO_CHAR,
658 transmute::TRANSMUTE_INT_TO_FLOAT,
659 transmute::TRANSMUTE_PTR_TO_PTR,
660 transmute::TRANSMUTE_PTR_TO_REF,
661 transmute::USELESS_TRANSMUTE,
662 transmute::WRONG_TRANSMUTE,
663 types::ABSURD_EXTREME_COMPARISONS,
666 types::CAST_LOSSLESS,
667 types::CAST_PTR_ALIGNMENT,
668 types::CHAR_LIT_AS_U8,
669 types::IMPLICIT_HASHER,
670 types::LET_UNIT_VALUE,
671 types::OPTION_OPTION,
672 types::TYPE_COMPLEXITY,
675 types::UNNECESSARY_CAST,
676 unicode::ZERO_WIDTH_SPACE,
677 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
678 unused_io_amount::UNUSED_IO_AMOUNT,
679 unused_label::UNUSED_LABEL,
681 write::PRINT_LITERAL,
682 write::PRINT_WITH_NEWLINE,
683 write::PRINTLN_EMPTY_STRING,
684 write::WRITE_LITERAL,
685 write::WRITE_WITH_NEWLINE,
686 write::WRITELN_EMPTY_STRING,
687 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
690 reg.register_lint_group("clippy_style", vec![
691 assign_ops::ASSIGN_OP_PATTERN,
692 bit_mask::VERBOSE_BIT_MASK,
693 blacklisted_name::BLACKLISTED_NAME,
694 block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
695 block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
696 collapsible_if::COLLAPSIBLE_IF,
697 const_static_lifetime::CONST_STATIC_LIFETIME,
698 enum_variants::ENUM_VARIANT_NAMES,
699 enum_variants::MODULE_INCEPTION,
701 eta_reduction::REDUNDANT_CLOSURE,
702 excessive_precision::EXCESSIVE_PRECISION,
703 formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
704 formatting::SUSPICIOUS_ELSE_FORMATTING,
705 if_let_redundant_pattern_matching::IF_LET_REDUNDANT_PATTERN_MATCHING,
706 infallible_destructuring_match::INFALLIBLE_DESTRUCTURING_MATCH,
707 len_zero::LEN_WITHOUT_IS_EMPTY,
709 let_if_seq::USELESS_LET_IF_SEQ,
710 literal_representation::INCONSISTENT_DIGIT_GROUPING,
711 literal_representation::LARGE_DIGIT_GROUPS,
712 literal_representation::UNREADABLE_LITERAL,
714 loops::EXPLICIT_INTO_ITER_LOOP,
715 loops::EXPLICIT_ITER_LOOP,
717 loops::NEEDLESS_RANGE_LOOP,
718 loops::WHILE_LET_ON_ITERATOR,
719 map_clone::MAP_CLONE,
721 matches::MATCH_OVERLAPPING_ARM,
722 matches::MATCH_REF_PATS,
723 matches::MATCH_WILD_ERR_ARM,
724 matches::SINGLE_MATCH,
725 methods::CHARS_LAST_CMP,
727 methods::ITER_CLONED_COLLECT,
728 methods::ITER_SKIP_NEXT,
729 methods::NEW_RET_NO_SELF,
731 methods::OPTION_MAP_OR_NONE,
732 methods::SHOULD_IMPLEMENT_TRAIT,
733 methods::STRING_EXTEND_CHARS,
734 methods::UNNECESSARY_FOLD,
735 methods::WRONG_SELF_CONVENTION,
736 misc::REDUNDANT_PATTERN,
737 misc::TOPLEVEL_REF_ARG,
739 misc_early::BUILTIN_TYPE_SHADOW,
740 misc_early::DOUBLE_NEG,
741 misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
742 misc_early::MIXED_CASE_HEX_LITERALS,
743 misc_early::UNNEEDED_FIELD_PATTERN,
744 mut_reference::UNNECESSARY_MUT_PASSED,
745 needless_pass_by_value::NEEDLESS_PASS_BY_VALUE,
746 neg_multiply::NEG_MULTIPLY,
747 new_without_default::NEW_WITHOUT_DEFAULT,
748 new_without_default::NEW_WITHOUT_DEFAULT_DERIVE,
749 non_expressive_names::JUST_UNDERSCORES_AND_DIGITS,
750 non_expressive_names::MANY_SINGLE_CHAR_NAMES,
751 ok_if_let::IF_LET_SOME_RESULT,
752 panic_unimplemented::PANIC_PARAMS,
755 question_mark::QUESTION_MARK,
756 ranges::RANGE_MINUS_ONE,
757 redundant_field_names::REDUNDANT_FIELD_NAMES,
759 regex::TRIVIAL_REGEX,
760 returns::LET_AND_RETURN,
761 returns::NEEDLESS_RETURN,
762 strings::STRING_LIT_AS_BYTES,
763 types::IMPLICIT_HASHER,
764 types::LET_UNIT_VALUE,
765 unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME,
766 write::PRINT_LITERAL,
767 write::PRINT_WITH_NEWLINE,
768 write::PRINTLN_EMPTY_STRING,
769 write::WRITE_LITERAL,
770 write::WRITE_WITH_NEWLINE,
771 write::WRITELN_EMPTY_STRING,
774 reg.register_lint_group("clippy_complexity", vec![
775 assign_ops::MISREFACTORED_ASSIGN_OP,
776 booleans::NONMINIMAL_BOOL,
777 cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
778 double_comparison::DOUBLE_COMPARISONS,
779 double_parens::DOUBLE_PARENS,
780 eval_order_dependence::DIVERGING_SUB_EXPRESSION,
781 eval_order_dependence::EVAL_ORDER_DEPENDENCE,
782 explicit_write::EXPLICIT_WRITE,
783 format::USELESS_FORMAT,
784 functions::TOO_MANY_ARGUMENTS,
785 identity_conversion::IDENTITY_CONVERSION,
786 identity_op::IDENTITY_OP,
787 int_plus_one::INT_PLUS_ONE,
788 lifetimes::NEEDLESS_LIFETIMES,
789 lifetimes::UNUSED_LIFETIMES,
790 loops::EXPLICIT_COUNTER_LOOP,
791 loops::MUT_RANGE_BOUND,
792 loops::WHILE_LET_LOOP,
793 map_unit_fn::OPTION_MAP_UNIT_FN,
794 map_unit_fn::RESULT_MAP_UNIT_FN,
795 matches::MATCH_AS_REF,
796 methods::CHARS_NEXT_CMP,
797 methods::CLONE_ON_COPY,
798 methods::FILTER_NEXT,
799 methods::SEARCH_IS_SOME,
800 methods::USELESS_ASREF,
801 misc::SHORT_CIRCUIT_STATEMENT,
802 misc_early::REDUNDANT_CLOSURE_CALL,
803 misc_early::ZERO_PREFIXED_LITERAL,
804 needless_bool::BOOL_COMPARISON,
805 needless_bool::NEEDLESS_BOOL,
806 needless_borrowed_ref::NEEDLESS_BORROWED_REFERENCE,
807 needless_update::NEEDLESS_UPDATE,
808 no_effect::NO_EFFECT,
809 no_effect::UNNECESSARY_OPERATION,
810 overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
811 partialeq_ne_impl::PARTIALEQ_NE_IMPL,
812 precedence::PRECEDENCE,
813 ranges::RANGE_ZIP_WITH_LEN,
814 reference::DEREF_ADDROF,
816 temporary_assignment::TEMPORARY_ASSIGNMENT,
817 transmute::CROSSPOINTER_TRANSMUTE,
818 transmute::TRANSMUTE_BYTES_TO_STR,
819 transmute::TRANSMUTE_INT_TO_BOOL,
820 transmute::TRANSMUTE_INT_TO_CHAR,
821 transmute::TRANSMUTE_INT_TO_FLOAT,
822 transmute::TRANSMUTE_PTR_TO_PTR,
823 transmute::TRANSMUTE_PTR_TO_REF,
824 transmute::USELESS_TRANSMUTE,
826 types::CAST_LOSSLESS,
827 types::CHAR_LIT_AS_U8,
828 types::OPTION_OPTION,
829 types::TYPE_COMPLEXITY,
831 types::UNNECESSARY_CAST,
832 unused_label::UNUSED_LABEL,
833 zero_div_zero::ZERO_DIVIDED_BY_ZERO,
836 reg.register_lint_group("clippy_correctness", vec![
837 approx_const::APPROX_CONSTANT,
838 array_indexing::OUT_OF_BOUNDS_INDEXING,
839 attrs::DEPRECATED_SEMVER,
840 attrs::USELESS_ATTRIBUTE,
841 bit_mask::BAD_BIT_MASK,
842 bit_mask::INEFFECTIVE_BIT_MASK,
844 copies::IF_SAME_THEN_ELSE,
845 copies::IFS_SAME_COND,
846 derive::DERIVE_HASH_XOR_EQ,
847 drop_forget_ref::DROP_COPY,
848 drop_forget_ref::DROP_REF,
849 drop_forget_ref::FORGET_COPY,
850 drop_forget_ref::FORGET_REF,
851 enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
853 erasing_op::ERASING_OP,
854 formatting::POSSIBLE_MISSING_COMMA,
855 functions::NOT_UNSAFE_PTR_ARG_DEREF,
856 infinite_iter::INFINITE_ITER,
857 inline_fn_without_body::INLINE_FN_WITHOUT_BODY,
858 invalid_ref::INVALID_REF,
859 loops::FOR_LOOP_OVER_OPTION,
860 loops::FOR_LOOP_OVER_RESULT,
861 loops::ITER_NEXT_LOOP,
863 loops::REVERSE_RANGE_LOOP,
864 loops::WHILE_IMMUTABLE_CONDITION,
865 methods::CLONE_DOUBLE_REF,
866 methods::TEMPORARY_CSTRING_AS_PTR,
871 open_options::NONSENSICAL_OPEN_OPTIONS,
873 ranges::ITERATOR_STEP_BY_ZERO,
874 regex::INVALID_REGEX,
875 serde_api::SERDE_API_MISUSE,
876 suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL,
877 suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL,
878 swap::ALMOST_SWAPPED,
879 transmute::WRONG_TRANSMUTE,
880 types::ABSURD_EXTREME_COMPARISONS,
881 types::CAST_PTR_ALIGNMENT,
883 unicode::ZERO_WIDTH_SPACE,
884 unused_io_amount::UNUSED_IO_AMOUNT,
887 reg.register_lint_group("clippy_perf", vec![
888 bytecount::NAIVE_BYTECOUNT,
891 large_enum_variant::LARGE_ENUM_VARIANT,
892 loops::MANUAL_MEMCPY,
893 loops::UNUSED_COLLECT,
895 methods::OR_FUN_CALL,
896 methods::SINGLE_CHAR_PATTERN,
898 mutex_atomic::MUTEX_ATOMIC,
903 reg.register_lint_group("clippy_cargo", vec![
904 multiple_crate_versions::MULTIPLE_CRATE_VERSIONS,
907 reg.register_lint_group("clippy_nursery", vec![
908 attrs::EMPTY_LINE_AFTER_OUTER_ATTR,
909 fallible_impl_from::FALLIBLE_IMPL_FROM,
910 mutex_atomic::MUTEX_INTEGER,
911 needless_borrow::NEEDLESS_BORROW,
912 ranges::RANGE_PLUS_ONE,
916 // only exists to let the dogfood integration test works.
917 // Don't run clippy as an executable directly
918 #[allow(dead_code, print_stdout)]
920 panic!("Please use the cargo-clippy executable");